From nobody Sun Feb 8 11:17:08 2026 Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC47213E40E for ; Tue, 23 Apr 2024 17:19:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713892762; cv=none; b=s5GmV7vFmCLtIaOX+EpG7PLrs5BrBEHFbYF+D3Y1LC6sMjaXbQ3gvjd8AQWNQRKGZYVo46rdu4giK7wQJLJAqOV9IyXJUTR8ysXyZprG17cYPMqn4lWgVk+XfrHu4kGlmpfeg2jcWqyOCz8CqARc4hzpcecZ32o3k4E5AjtQJYU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713892762; c=relaxed/simple; bh=fjb4FrppOIo0qcDq2yb6XcO5NxeNrkDyh1kECq7BnMs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FLnK77U2qn9H7EYsVTzvoVbw3BjA8I7WfYDuYES8CMj27hdwnFBSLPBuFdb7JCEuexgKXKJu5nWWGA4alYT3b25miiEDpn2nYhHcMsB7GJpvieEB0ZtxjsQjCIdhVYomEnt0QsOPp360OtH65KO6G7nfKG2Bo5xC1I2zf6+mZdQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=LLTjMLGe; arc=none smtp.client-ip=91.218.175.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="LLTjMLGe" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1713892757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fefHnXEFrbmBIUDCc82fL50d6Bt9DvNDq0SHN2U6tZQ=; b=LLTjMLGenW1CYv4kPsXi6igBzHxp//fCs1p9Rq24+X5yiYSr5lmkAaU7S3XVGFvysVuDpu ZrCa1oLi58iTV+PXbWKKQfiyKHQ63VhpF0C4FEDV5PPlGhq6HTDV0crLVoytpj6JlnPl2I xuv+M9q6XOVQjBc5FsEHPQMy52A+H6M= From: Sean Anderson To: Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org Cc: Daniel Vetter , linux-arm-kernel@lists.infradead.org, Michal Simek , linux-kernel@vger.kernel.org, David Airlie , Tomi Valkeinen , Sean Anderson Subject: [PATCH v4 04/13] drm: zynqmp_dp: Adjust training values per-lane Date: Tue, 23 Apr 2024 13:18:50 -0400 Message-Id: <20240423171859.3953024-5-sean.anderson@linux.dev> In-Reply-To: <20240423171859.3953024-1-sean.anderson@linux.dev> References: <20240423171859.3953024-1-sean.anderson@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" The feedback we get from the DPRX is per-lane. Make changes using this information, instead of picking the maximum values from all lanes. This results in more-consistent training on marginal links. Signed-off-by: Sean Anderson Reviewed-by: Tomi Valkeinen --- (no changes since v1) drivers/gpu/drm/xlnx/zynqmp_dp.c | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp= _dp.c index fdea1a9710de..79afe4358d06 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c @@ -605,28 +605,21 @@ static void zynqmp_dp_adjust_train(struct zynqmp_dp *= dp, u8 link_status[DP_LINK_STATUS_SIZE]) { u8 *train_set =3D dp->train_set; - u8 voltage =3D 0, preemphasis =3D 0; u8 i; =20 for (i =3D 0; i < dp->mode.lane_cnt; i++) { - u8 v =3D drm_dp_get_adjust_request_voltage(link_status, i); - u8 p =3D drm_dp_get_adjust_request_pre_emphasis(link_status, i); + u8 voltage =3D drm_dp_get_adjust_request_voltage(link_status, i); + u8 preemphasis =3D + drm_dp_get_adjust_request_pre_emphasis(link_status, i); =20 - if (v > voltage) - voltage =3D v; + if (voltage >=3D DP_TRAIN_VOLTAGE_SWING_LEVEL_3) + voltage |=3D DP_TRAIN_MAX_SWING_REACHED; =20 - if (p > preemphasis) - preemphasis =3D p; - } + if (preemphasis >=3D DP_TRAIN_PRE_EMPH_LEVEL_2) + preemphasis |=3D DP_TRAIN_MAX_PRE_EMPHASIS_REACHED; =20 - if (voltage >=3D DP_TRAIN_VOLTAGE_SWING_LEVEL_3) - voltage |=3D DP_TRAIN_MAX_SWING_REACHED; - - if (preemphasis >=3D DP_TRAIN_PRE_EMPH_LEVEL_2) - preemphasis |=3D DP_TRAIN_MAX_PRE_EMPHASIS_REACHED; - - for (i =3D 0; i < dp->mode.lane_cnt; i++) train_set[i] =3D voltage | preemphasis; + } } =20 /** --=20 2.35.1.1320.gc452695387.dirty