From nobody Sun May 19 08:26:09 2024 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 434CE13D63B for ; Tue, 23 Apr 2024 16:53:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713891214; cv=none; b=D4SMuXGMlgIiJ8BB/AaMnXZbCA1wfmylu2GykijuvtR2VotPA4bZG9WGf+WUQ+vkGbz1FIYBy9CqPDc6ZR8lODYsEdgPyE7DSOtohV6Vb63JvL2J8TMV3mOLKdWuyNVzZh3fGZmfGJryB1wSYBKRUbyE+HrbRsZKqPXPdJnAiu4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713891214; c=relaxed/simple; bh=IIA0cZD11SCgBB3seks1sD5Tm1ngX7ytjSsIqj8LB4M=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=jP7oFZ8wHXJsHnc7QaHKs/Vq20RupngWm2a8v07xqvlkcu90lkM0cbBN8Qc0gX6lRAO/sZQK18tGXM+Q/ZrEhoO8cT5Ttzm+wlk0IP4vVuk7MwZ002hKXqZuWqzW8iDF80QeP0XnEYUlu0HS1ck8gwIpDecdFd/4Gzqf9G6Z05w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=zXi2Kof8; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="zXi2Kof8" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-5cdfd47de98so6324953a12.1 for ; Tue, 23 Apr 2024 09:53:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1713891212; x=1714496012; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=ftFQzTSwFXT1TIp1fPDslrbqn6nx3jYtj/iibVlTl4A=; b=zXi2Kof83cYMXmR1e3PcChCblyi65SbjE9NWdj5+XpI9OQZuvJxlWSV7zOdHgvZ/uh 7vU6o8jgwBk6cDfjUwIhYEVA03W0gfv8CaZpZeaphtVwwTpIbDkPMOBg7ahyiKvdytSh fCScGGmzm/4CQmZz1W5YC+lTimbEomsOxzCjH7TpiiLeYo37i+6jZaCrC/u/c5ZtydmK 4VTNX2Ve1iJuYmi4gchGjUbfspBr+BDJyLb7H8gtCv+dPIXOXyLRMCzNqCX1xXBiaQlc 0SAUdlGxWQOKjzZzkhmOsMP2jG9OUdrfAJXuh0qpt04eyAHnfHWN206Gh6iemk9ELGhj kdeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713891212; x=1714496012; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ftFQzTSwFXT1TIp1fPDslrbqn6nx3jYtj/iibVlTl4A=; b=LkYEwA1qoiHeNKELa1gshYfUj/Nqe+79B6okOz6n5BEKIL0cGIvmQFNWI18XRef+Tc /TZ1Dl6R0cDKbmbxc261Gvog6AMbDWK2C1zDoINt+1AzxwZzSxUMrtwgYpa29iRbpsXD QPjyUksT52TtuiLg5Bt6XysjeTWnOK4fEb38XAmwduIOYSqv7fe4lkyKXBxh9tRF2Eth vWBEoth3y5zngyZoUlJCCfthXPPnSYT80A+ovSx4CkrKY/NLrmSxkPuWy9fZcK10l9P+ geY2Jhuo6pVvut3G+h3rZbkQfVK9hJO5F9H7WMxzRSqFiCkASvK/R8fX79Kctyv+l5Rw B6Xw== X-Forwarded-Encrypted: i=1; AJvYcCXLytvLIWYAkOWuGXDn49f0TCLaqfwUdiarNEPcjc+WPROPxWNEQ315AWcNubdMAQ23sy6uOY7NVvB6XMH8qM4+rBO/T+QOfXo+mY8s X-Gm-Message-State: AOJu0Yw6cZXC2YhzW6A6oi1ND7EK9vm53EFaFY5FArs6MfQKaHIGVaHP 6zx3AoNpA5pZLfn55txxC6VLaAhxb5H3K2Nqsg5UQfp9XeuGqQIYxDhaJ0h6JXTJ/Tna4Q+Y17p S2g== X-Google-Smtp-Source: AGHT+IHMKvgcg5vLMtiLvLskSs3bQ87rsfU5twomg9UnoRcDVBw7UM6yzMuwcxiHO8TKCzQ1vo/xo09ouPs= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a63:2ccb:0:b0:5dc:eb5:19db with SMTP id s194-20020a632ccb000000b005dc0eb519dbmr1690pgs.0.1713891212528; Tue, 23 Apr 2024 09:53:32 -0700 (PDT) Reply-To: Sean Christopherson Date: Tue, 23 Apr 2024 09:53:26 -0700 In-Reply-To: <20240423165328.2853870-1-seanjc@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240423165328.2853870-1-seanjc@google.com> X-Mailer: git-send-email 2.44.0.769.g3c40516874-goog Message-ID: <20240423165328.2853870-2-seanjc@google.com> Subject: [PATCH 1/3] KVM: x86: Fully re-initialize supported_vm_types on vendor module load From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Recompute the entire set of supported VM types when a vendor module is loaded, as preserving supported_vm_types across vendor module unload and reload can result in VM types being incorrectly treated as supported. E.g. if a vendor module is loaded with TDP enabled, unloaded, and then reloaded with TDP disabled, KVM_X86_SW_PROTECTED_VM will be incorrectly retained. Ditto for SEV_VM and SEV_ES_VM and their respective module params in kvm-amd.ko. Fixes: 2a955c4db1dd ("KVM: x86: Add supported_vm_types to kvm_caps") Signed-off-by: Sean Christopherson Reviewed-by: Xiaoyao Li --- arch/x86/kvm/x86.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 2d2619d3eee4..a65a1012d878 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -94,7 +94,6 @@ =20 struct kvm_caps kvm_caps __read_mostly =3D { .supported_mce_cap =3D MCG_CTL_P | MCG_SER_P, - .supported_vm_types =3D BIT(KVM_X86_DEFAULT_VM), }; EXPORT_SYMBOL_GPL(kvm_caps); =20 @@ -9776,6 +9775,8 @@ int kvm_x86_vendor_init(struct kvm_x86_init_ops *ops) if (r) goto out_free_percpu; =20 + kvm_caps.supported_vm_types =3D BIT(KVM_X86_DEFAULT_VM); + if (boot_cpu_has(X86_FEATURE_XSAVE)) { host_xcr0 =3D xgetbv(XCR_XFEATURE_ENABLED_MASK); kvm_caps.supported_xcr0 =3D host_xcr0 & KVM_SUPPORTED_XCR0; --=20 2.44.0.769.g3c40516874-goog From nobody Sun May 19 08:26:09 2024 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 035CD13DB8C for ; Tue, 23 Apr 2024 16:53:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713891216; cv=none; b=cZEBKujpTG2+l+kENMnzlu2+F3ItKf8FliwYgxVPVVT6XOj2/GsrSx50cMYP8Mf+rPzWa0HyQCHtZlvBTVsW1JPpBxijmK1XSUrUEBVHJVjyLYo1gGFtIv/2xvvTsyYaffNOvxwtBVe9G7LtrgNcMuIITyGu2bHo4X0qLL+qyaw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713891216; c=relaxed/simple; bh=ub/c4lMzNuQE/ASob0hO2P7pr3tW5fJO73ybbxmtQhA=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=lkuQMXuS8pPoH308bIg5Hiwy0SF75+M1bazns1uSc9DmkE0OqZOJ+iz6kE+YFEe/nMBqZPc7lScNpFZwwtwbxVv1a/QQVd8gnGvFfDTCG7J+kn7XFv75818JiDIdXmGY/OyE6h4/f0cKPGPAZ5fisFka85nvGIvjrRCDilCyvok= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=XgZ44Gix; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XgZ44Gix" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-6ed2f4e685bso36613b3a.0 for ; Tue, 23 Apr 2024 09:53:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1713891214; x=1714496014; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=vs27nCM79m201+PPivEr2AY28j47w3WHEEMcLDKrspA=; b=XgZ44GixJQ56Rr1DZ8+JUONi1f4avXxmyBl2ogq4Me4fhOEAZxoCd+3MCGKyF/B26c dJ4Y1zPD17A5Tfpeyr5Beuk+DUmZFsmBunhpd4SOM2DPRsArfxlVd8NxxqXGZBYJdymT yolZhpjMscF0OYTyWidp6Goj/Jvmzl9V4xtupqPrKRy94IsX4DehR7wj8t7NxM4dM7fS 2QIvN7h9Tm+baWyNRrNYHNiECgVvqC55mU7xocTTLC6DKzm8uNMOd9LtH1E3a4wwsOxV qDpRJqSdttdlNRUokduMT4td83RjlEPIRpaaFmDSBlqxNtMSfvxoKeMB1cKbkqS2mFZk Hc0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713891214; x=1714496014; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vs27nCM79m201+PPivEr2AY28j47w3WHEEMcLDKrspA=; b=CiTWqobrYCG+PdiOranhidJHOmHt+oaToC5c8nOHRbcOv/1hwYiv+hKbLor3ostBNW Tj+llvYdUGYZuVfCg6hmnai9zImUxBv45I/O+gshY3/AezFAAYzU+Wbg+tAhoQjYnL2H nNPyCBWSHpc7yMB7FFd2R6YI6rQAhjIHqhWXeEbAFac0dQfNYVnerLQDrWlbXxSJoZkC onV6uP6Lc2xcgySgQsZv9RifjJejIAtdrkw//DQ8k8/xXg+nuqeg81I2R9g863B1Muz6 jJTqM5ZTqq0mH42aC41emJ77sqyHH+bZVbPfy6xCuj8b6/fx3v/HbHzjj/d+xkHEpzRj ABYg== X-Forwarded-Encrypted: i=1; AJvYcCXalUmtI+lXGP6U7ITORrbslABMfXty5flTZIHr0SD7+5ICLhb6PK71ZowvmzNXguM0EhN+NTxoInnmxt3Kf1SizgPGaRApQdd6q2Hr X-Gm-Message-State: AOJu0YxXATa7XWYNqgKokACPEid5IkZH4Ji6vxVYJHqbkW0R5GXxnObj c5mXJyH1pvEgfIOzIHocvGmXAlcnjCc7rsCc/2P12ZRiZ0g9DUll+D58cUZfvJmQYzhQc7I6/Pf 0Yw== X-Google-Smtp-Source: AGHT+IHHss4tWuFp3utLNINOqa+jKnoNwBJ+RlJYWs9fS6z+DNT3QK/uQRUw/WQrJokPWQezfnz2mAbl10I= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6a00:4ba4:b0:6ea:e009:1815 with SMTP id kt4-20020a056a004ba400b006eae0091815mr33967pfb.3.1713891214344; Tue, 23 Apr 2024 09:53:34 -0700 (PDT) Reply-To: Sean Christopherson Date: Tue, 23 Apr 2024 09:53:27 -0700 In-Reply-To: <20240423165328.2853870-1-seanjc@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240423165328.2853870-1-seanjc@google.com> X-Mailer: git-send-email 2.44.0.769.g3c40516874-goog Message-ID: <20240423165328.2853870-3-seanjc@google.com> Subject: [PATCH 2/3] KVM: x86: Fully re-initialize supported_mce_cap on vendor module load From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Effectively reset supported_mce_cap on vendor module load to ensure that capabilities aren't unintentionally preserved across module reload, e.g. if kvm-intel.ko added a module param to control LMCE support, or if someone somehow managed to load a vendor module that doesn't support LMCE after loading and unloading kvm-intel.ko. Practically speaking, this bug is a non-issue as kvm-intel.ko doesn't have a module param for LMCE, and there is no system in the world that supports both kvm-intel.ko and kvm-amd.ko. Fixes: c45dcc71b794 ("KVM: VMX: enable guest access to LMCE related MSRs") Signed-off-by: Sean Christopherson Reviewed-by: Xiaoyao Li --- arch/x86/kvm/x86.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index a65a1012d878..44ce187bad89 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -92,9 +92,7 @@ #define MAX_IO_MSRS 256 #define KVM_MAX_MCE_BANKS 32 =20 -struct kvm_caps kvm_caps __read_mostly =3D { - .supported_mce_cap =3D MCG_CTL_P | MCG_SER_P, -}; +struct kvm_caps kvm_caps __read_mostly; EXPORT_SYMBOL_GPL(kvm_caps); =20 #define ERR_PTR_USR(e) ((void __user *)ERR_PTR(e)) @@ -9776,6 +9774,7 @@ int kvm_x86_vendor_init(struct kvm_x86_init_ops *ops) goto out_free_percpu; =20 kvm_caps.supported_vm_types =3D BIT(KVM_X86_DEFAULT_VM); + kvm_caps.supported_mce_cap =3D MCG_CTL_P | MCG_SER_P; =20 if (boot_cpu_has(X86_FEATURE_XSAVE)) { host_xcr0 =3D xgetbv(XCR_XFEATURE_ENABLED_MASK); --=20 2.44.0.769.g3c40516874-goog From nobody Sun May 19 08:26:09 2024 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 786C313E032 for ; Tue, 23 Apr 2024 16:53:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713891220; cv=none; b=Mcxbh1VXUO+nva3QI7PI9vdm713TA7vl9DPmnq0zFucnwcIVnGvcoEtgEV+q4rXBpBX91sAHvqmThYiEmFn4TAxmnRfnuP+Y4szi5UFds3eLTdEK3T1S+5xQj8RjMUtJl6nv04ultDwFv5k+fNikntl4Y6wkfM8zWvs/Ixi7YF0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713891220; c=relaxed/simple; bh=F6jaJv52CDprALPzgiY8c/9fYHL9o+SM83T+9ypBoLM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=pAm73eusFwKoRjRdmMOH1mk6vRh4PA1Dt9RG/1uIRAE32ru1xFzeRNmOJaBPz844uCu1pRkNB1ELlGks/P9coHGOFchQzJjNWuHHNf8GVEAvlTXWqGIVYgeBRujFmulneMfYK3P4rQBdSLeC0qPasT1mEKS8UvqCUl+WBiNd0ZM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=rtPE/21M; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rtPE/21M" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-6188040f3d2so122426417b3.1 for ; Tue, 23 Apr 2024 09:53:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1713891216; x=1714496016; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=sV9yNB6aR8W90fYMIdgt/s8o7GSizOulqAtOjmc/hB4=; b=rtPE/21MiptS2MvgASuGbodmcY5nlHuZ+1sB3J/zzGr0tfGryJFjx1HacGf8AhAhya YAfIH9TOjpgsqdhgFW2RfOMny0bO6DZuM6emVJLXum5BWcl+r4x7tn5BS5hIU4LlWf6g 7PkfcK+Le8ajAIoT4UzlaU28C8Xncb/x+fREVYhAHk1Yn43B3HHjsB9OCpTGD8EUTKDY eyNB91vhXTL5cBvL2Ar9mUldsQNe/05FR1rI0U/xZ/SHfXEeayO5uaCq4ZCY24LpbrE2 gBtdVpsPwxEl0LZERIid/W+aiaIHbhwuydLOj1hkY9wkBg0jOwBR4tvlVV6aSAufTjKI huaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713891216; x=1714496016; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sV9yNB6aR8W90fYMIdgt/s8o7GSizOulqAtOjmc/hB4=; b=MJZ1KcK5wwKCfCnwOshR59BBPlyovdDWdA1n8XOMA2KdKYadM+SEDJKz7785O+97KI Bu7Sdl+xxIDJYiVl0Mqvtf+kyIy+AE0PWnoMKglIeWuW+DUHHNKPQk7UYyNVSpTUvSNj N+L1s2DbtxPB2vv1BFocU5ENsUnukewTzrhLmzmEHsmMK5aKYjVZaCLOUC+cf/7TzEfc mRksWBsUIkU9ZHBac6YkURqZKo8tKqHzBpX0kNCRfi2P5rV3so9uBnIg8ot4zF4Vmh4O S6cdclxYXyONFS/DM3+5Soa6IuTZ9JiDr09e/YsC84yn7vuvNYgCF7SlrHTVZTHym1ZG OZiw== X-Forwarded-Encrypted: i=1; AJvYcCWUYIZh+WKvjPDXwkr9xaq7C4Sc0MJRCp0Or5e9LL0X2pj9C0kLmb8ycPPrOiAKXOEtiwBS68kR9F0/egVnZdQHrjogHxc0ljnu3wJu X-Gm-Message-State: AOJu0YwKH4ylu0dJuPMCegmGlTYhPkAKWWtlt48QgSBFWMWePEfffdG7 UTaChmnKu4snWsTLD1J2hzs5N1jrdq10z+zUT5psmat5JkfcKNYvPMWrfGJciALc/pG5UqaK8BI KtQ== X-Google-Smtp-Source: AGHT+IEKtvFjeB+RwGhO/xxjR9keN4d9sjRQVzhkBfwnys03punNsGEp7Y1n5s+Kg7LT6FmELNYfr5dM7rE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:10c2:b0:dd9:3a6b:11f8 with SMTP id w2-20020a05690210c200b00dd93a6b11f8mr38570ybu.5.1713891216480; Tue, 23 Apr 2024 09:53:36 -0700 (PDT) Reply-To: Sean Christopherson Date: Tue, 23 Apr 2024 09:53:28 -0700 In-Reply-To: <20240423165328.2853870-1-seanjc@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240423165328.2853870-1-seanjc@google.com> X-Mailer: git-send-email 2.44.0.769.g3c40516874-goog Message-ID: <20240423165328.2853870-4-seanjc@google.com> Subject: [PATCH 3/3] KVM: x86: Explicitly zero kvm_caps during vendor module load From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Zero out all of kvm_caps when loading a new vendor module to ensure that KVM can't inadvertently rely on global initialization of a field, and add a comment above the definition of kvm_caps to call out that all fields needs to be explicitly computed during vendor module load. Signed-off-by: Sean Christopherson Reviewed-by: Xiaoyao Li --- arch/x86/kvm/x86.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 44ce187bad89..8f3979d5fc80 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -92,6 +92,11 @@ #define MAX_IO_MSRS 256 #define KVM_MAX_MCE_BANKS 32 =20 +/* + * Note, kvm_caps fields should *never* have default values, all fields mu= st be + * recomputed from scratch during vendor module load, e.g. to account for a + * vendor module being reloaded with different module parameters. + */ struct kvm_caps kvm_caps __read_mostly; EXPORT_SYMBOL_GPL(kvm_caps); =20 @@ -9755,6 +9760,8 @@ int kvm_x86_vendor_init(struct kvm_x86_init_ops *ops) return -EIO; } =20 + memset(&kvm_caps, 0, sizeof(kvm_caps)); + x86_emulator_cache =3D kvm_alloc_emulator_cache(); if (!x86_emulator_cache) { pr_err("failed to allocate cache for x86 emulator\n"); --=20 2.44.0.769.g3c40516874-goog