From nobody Sat May 18 23:44:15 2024 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 206B284FB9 for ; Tue, 23 Apr 2024 12:13:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713874416; cv=none; b=R8AODwvKeRbf7VL6Ue1wj7bn1wvf9NEvWFVHQ5PW5doslOX1G0czp8uenXIDfbNjDIcCBM5Ecb/AiprGx2K1Nr6FQyftVBLRiKlAbEvlTh58vAomOG8YoE4Za5qSa+InDB5EWB+ljCANJNy4Xm4rd0apV4RnwJuSuIFbSY5Swkc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713874416; c=relaxed/simple; bh=QziFJ4eR9MDTLjiQuJbhBL0X5FR4zAfiumoOpS9k6I4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d9UbJnBpAt8rY7PkTqYTUgkx5QpaDcbq7VrXppU52EA9VqahUmwTsoPJQ/ioWRH5CneFFO7xoSIp6BY+luoGdS7xUuEA6o06XsSf/jsUb2tquyzSufc6eImPsDZUymDhEyKuQzJgla3WonBmMyWf4VWjzo5/1jVXP1J6f2ndfDY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=fkPO8oQ7; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="fkPO8oQ7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=ALUIroL5Av0kBMBvQS1RV7KXY+AGT262FLPxDnV1Shw=; b=fkPO8o Q7rcOlTzDXY8qqk7U2qIrnrGr4CGPQIueh03T4tmybAvE2Smxur2HkmXv6sBY5cL LiB0j3FfELdsHUeitZocHUc/+4CUZAmzy2ZqTRT8YsZmxCXEn9YPovAgmubTab4Q eiuxh8Vbg3ETN2pV3kwtSlAfblTblPy6miVYkR0KGSpY1S/bUJBtCWbXI/6lUo/m oJ3OJX6hFYmWPKgZrhsUNaFgGaApkib7UzbA8Gd/LcOr8ednRYQy4T4bt8nnTPBG 9rcSFAMV/Xfdv158toGlNzaLW6Ra2IVe3bkAyXaubvoA/P2UrOBonHVA3rInSCBa ZQCK0J6lkHy5aQog== Received: (qmail 215894 invoked from network); 23 Apr 2024 14:13:28 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 23 Apr 2024 14:13:28 +0200 X-UD-Smtp-Session: l3s3148p1@TNhLe8IWRMIgAwDPXxiyACzheF6dGXh7 From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Jean Delvare , Andi Shyti , linux-kernel@vger.kernel.org Subject: [PATCH v2 1/4] i2c: i801: remove printout on handled timeouts Date: Tue, 23 Apr 2024 14:13:18 +0200 Message-ID: <20240423121322.28460-2-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240423121322.28460-1-wsa+renesas@sang-engineering.com> References: <20240423121322.28460-1-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout and turn the SMBus-specific termination message to debug. Signed-off-by: Wolfram Sang Reviewed-by: Jean Delvare --- drivers/i2c/busses/i2c-i801.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c index e577abc776c1..d2d2a6dbe29f 100644 --- a/drivers/i2c/busses/i2c-i801.c +++ b/drivers/i2c/busses/i2c-i801.c @@ -399,9 +399,7 @@ static int i801_check_post(struct i801_priv *priv, int = status) * If the SMBus is still busy, we give up */ if (unlikely(status < 0)) { - dev_err(&priv->pci_dev->dev, "Transaction timeout\n"); /* try to stop the current command */ - dev_dbg(&priv->pci_dev->dev, "Terminating the current operation\n"); outb_p(SMBHSTCNT_KILL, SMBHSTCNT(priv)); usleep_range(1000, 2000); outb_p(0, SMBHSTCNT(priv)); @@ -410,7 +408,7 @@ static int i801_check_post(struct i801_priv *priv, int = status) status =3D inb_p(SMBHSTSTS(priv)); if ((status & SMBHSTSTS_HOST_BUSY) || !(status & SMBHSTSTS_FAILED)) - dev_err(&priv->pci_dev->dev, + dev_dbg(&priv->pci_dev->dev, "Failed terminating the transaction\n"); return -ETIMEDOUT; } --=20 2.43.0 From nobody Sat May 18 23:44:15 2024 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2062084E16 for ; Tue, 23 Apr 2024 12:13:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713874416; cv=none; b=nbtex/l2XvsyjztN58/xVpRwXyabno79nTxq29Y7Z11w4d59zqzTYFWS1DJtuVPWG69/f/YH8XNM6myauHWIOOAibCNpf2tcpAPM0IHE6V4msCFVkzzb6ziUs2mzcXpNIuTKip+GKTPQ8wg10rrhvYTyRS4RgLyLb2z+lKpJH+s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713874416; c=relaxed/simple; bh=xbf1WNjP4IO1W0OZaIGlDuC4mr4dA5AtAr7R2Nila7w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nk+TM/1AsdUcJ1AR1PeOtOqLL3ZIS+Uffmbl/SdBYJYc/Lb/yRQd7mRCSPoLhTHsYucD1a0NRZ3VaBqCAus2hBOnApsTI5O/rm1em7ppCacMRv0xH2jabXyqKYxbUww9TuLnGBbbNnnRKVgpl3z+T+Ja7yDLDvIICC57qXZdYKc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=OsLrmj9V; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="OsLrmj9V" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=7RDJRV5+hQ+u4dC/v/o4TT1cTTNjvD7fahHVBI9qmOM=; b=OsLrmj 9VBC/sUCRhezmgv2Kvwp5KDUo0sKJFU5oLlAorfOsEsUiGFGnGukpqQ3RGlUKEno 4zqE+6wCW4NOxLyWPx3nlUvMPDwjfnSf6+0gmg8zv+aL59eM6QMcX2jlrrYHqgow a6yCs3Q23+QTl/uQvZfYrgsLX0mtv+WiZ3ieTEot4NbymRk3WrEtFoaT9JJriKuB enmSOkxbQixzHWpKdcQfTaqePkf04sEWzihlWZ77x/bX7e1O/nKqGZV1De79unB0 RW/zpielGkhB4ZMwgkkrzPVWeQLK5BnELptpBOIWJYDUJWnUeLYo9sZAtt5onf70 pvI4I8OxECiLRbfw== Received: (qmail 215926 invoked from network); 23 Apr 2024 14:13:29 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 23 Apr 2024 14:13:29 +0200 X-UD-Smtp-Session: l3s3148p1@3SVZe8IWUsIgAwDPXxiyACzheF6dGXh7 From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Jean Delvare , Andi Shyti , linux-kernel@vger.kernel.org Subject: [PATCH 2/4] i2c: ali1535: remove printout on handled timeouts Date: Tue, 23 Apr 2024 14:13:19 +0200 Message-ID: <20240423121322.28460-3-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240423121322.28460-1-wsa+renesas@sang-engineering.com> References: <20240423121322.28460-1-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang Reviewed-by: Jean Delvare --- drivers/i2c/busses/i2c-ali1535.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-ali1535.c b/drivers/i2c/busses/i2c-ali1= 535.c index 461eb23f9d47..9d7b4efe26ad 100644 --- a/drivers/i2c/busses/i2c-ali1535.c +++ b/drivers/i2c/busses/i2c-ali1535.c @@ -285,10 +285,8 @@ static int ali1535_transaction(struct i2c_adapter *ada= p) && (timeout++ < MAX_TIMEOUT)); =20 /* If the SMBus is still busy, we give up */ - if (timeout > MAX_TIMEOUT) { + if (timeout > MAX_TIMEOUT) result =3D -ETIMEDOUT; - dev_err(&adap->dev, "SMBus Timeout!\n"); - } =20 if (temp & ALI1535_STS_FAIL) { result =3D -EIO; @@ -313,10 +311,8 @@ static int ali1535_transaction(struct i2c_adapter *ada= p) } =20 /* check to see if the "command complete" indication is set */ - if (!(temp & ALI1535_STS_DONE)) { + if (!(temp & ALI1535_STS_DONE)) result =3D -ETIMEDOUT; - dev_err(&adap->dev, "Error: command never completed\n"); - } =20 dev_dbg(&adap->dev, "Transaction (post): STS=3D%02x, TYP=3D%02x, " "CMD=3D%02x, ADD=3D%02x, DAT0=3D%02x, DAT1=3D%02x\n", --=20 2.43.0 From nobody Sat May 18 23:44:15 2024 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2066984FAC for ; Tue, 23 Apr 2024 12:13:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713874416; cv=none; b=DclUtRiU0WDOz3CvjgELTRxUM7VevOTT4ImciCunziOk9J2J34klENa5/XcHRMRzfq7CIw+KdQ1OHMLa+2S3BE4CS6SBQi9s+g2VH7l27yPdfszjwav+t41SU/daYPcKBnUtmz8uOxtgoHhUJWWMXILVKq/5aExDlWpdIjbDt9s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713874416; c=relaxed/simple; bh=4GV9MbW2RUuneAx+t3k0TvU8fbKIZejKkKEkfAigKsY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NOlqnyvH6R20lnAVM7LlCczyuUPkxQl2VeIOqwB5HqMi4n3TCmW6SLiGPrbK4Zzs/fvpNUcQ8lDS2shSqZ+4Wb3I49IR1O5zPeD3WFOnthI2Y33ZTbor+HsYlvtoS3fIX30KBNfAeQOfNwSE79uR+wpyT1oVLBIGAczkn9tSoPQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=CHGkAUtZ; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="CHGkAUtZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=WOkkrOzp70gQH6ESIdM1GW0bOtr5jQu2Mkl7P4COiR8=; b=CHGkAU tZKSh5LQE1xvhXrYl1zayyLSkqmqv+F9dGKxSTY26TAkT24LnloWOpaoHWHlEcjF Unw5N8/t8kq7xu3LyRoatQZnPhe8FChGtLLrwHBtoy3ytI3n2zDPkLKOZ5ZRE+Iu DcxAlBWfoaCu4a9DZo3pc7YeCKhnnY5Mq9SJPQ70zYW/S5Ojk9LA0qAfNpxP5jgQ NdvtFmTiBdN1YtXmiwrRGSV0RRt+lpmH0PpLERABtTvxXpaqquCLvUtSnc06Lfbs 3x0KDClsYlHmUVCXXV3uxSZkZE+zw2+H0Y+7e+WSo17nJlD03tgpnDsAPa3aB2V7 B3XAAChg4Td2HccA== Received: (qmail 215962 invoked from network); 23 Apr 2024 14:13:30 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 23 Apr 2024 14:13:30 +0200 X-UD-Smtp-Session: l3s3148p1@OGhke8IWVsIgAwDPXxiyACzheF6dGXh7 From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Rudolf Marek , Jean Delvare , Andi Shyti , linux-kernel@vger.kernel.org Subject: [PATCH 3/4] i2c: ali1563: remove printout on handled timeouts Date: Tue, 23 Apr 2024 14:13:20 +0200 Message-ID: <20240423121322.28460-4-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240423121322.28460-1-wsa+renesas@sang-engineering.com> References: <20240423121322.28460-1-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang Reviewed-by: Jean Delvare --- drivers/i2c/busses/i2c-ali1563.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-ali1563.c b/drivers/i2c/busses/i2c-ali1= 563.c index 307fb0666ecb..63897a89bb35 100644 --- a/drivers/i2c/busses/i2c-ali1563.c +++ b/drivers/i2c/busses/i2c-ali1563.c @@ -99,7 +99,6 @@ static int ali1563_transaction(struct i2c_adapter *a, int= size) return 0; =20 if (!timeout) { - dev_err(&a->dev, "Timeout - Trying to KILL transaction!\n"); /* Issue 'kill' to host controller */ outb_p(HST_CNTL2_KILL, SMB_HST_CNTL2); data =3D inb_p(SMB_HST_STS); --=20 2.43.0 From nobody Sat May 18 23:44:15 2024 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35EAD84FCB for ; Tue, 23 Apr 2024 12:13:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713874418; cv=none; b=Z7nWtazfJOyV1jDfEWRDQxyozj5nrYyrFckXXi2SRctI25+EbgjZ4qSmhxwdypzR31SAEjQtsa0/d6dY0cP5d1DBQo/agXWSyuJ2w60oSAW0QJrc6HcjtmqOzhdHmDJNaj651ZmD12hb3YfPbw63mgf2UbSn+F3OJTYzGoE5coA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713874418; c=relaxed/simple; bh=0jPmD9w6MO6TfNirky2Ez+VJd/uyuUY40pI0AtAvSpU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eHbjZxTXpeIscxlZ3Xkm6AyDzed0IKNvk6V13FmXkV88Lfrq2yrKzv15Th2hLrt+NyAM5v77NeafQrgQA70VXq0BGnb4Ho/gcay5ssmpreG2IvMEEIwv714kJQcr0GQCrgwtW8YUOaxEt2wOSCJCViJi2Qjcf4ERzfkOxQsALb0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=TzWzw4zX; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="TzWzw4zX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; s=k1; bh=xe5iCNJGYAImX92c4VMr943pPMAZr/upLvt8TB4E1Rk=; b=TzWzw4 zXLdQiwmqYFVdOdf/vhMQHs1khqXsRzXhUUnaGLWq4B4MLBzWbnSQ+SjHGA5w/hs RDlPn5o35fHgrOvLsVcML94E8ZV2VAOVgnevPn/vUjDX9VQLh56eu53g3nsyPJwp ZV/qhYTSA//TE8GReYgaBuG/y9i22nTDx4ifjpAEfN/G9ka5Xh1DvP2cIsIHnQ97 zZ1ea5Yc6BqrI8CnojBEIojVOhIBnhTBJJDrF59MzUrPwACfaTj5Vlu57/dxJ6fC DQyBoohCBHIA4LsTxoGvETCzkRsaZhibgl5cEQxr2Jx0VIWjYrtF+9qTrazSooR4 liVpdILFHALtej5w== Received: (qmail 215997 invoked from network); 23 Apr 2024 14:13:30 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 23 Apr 2024 14:13:30 +0200 X-UD-Smtp-Session: l3s3148p1@iRJwe8IWYMIgAwDPXxiyACzheF6dGXh7 From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Jean Delvare , Andi Shyti , linux-kernel@vger.kernel.org Subject: [PATCH 4/4] i2c: ali15x3: remove printout on handled timeouts Date: Tue, 23 Apr 2024 14:13:21 +0200 Message-ID: <20240423121322.28460-5-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240423121322.28460-1-wsa+renesas@sang-engineering.com> References: <20240423121322.28460-1-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" I2C and SMBus timeouts are not something the user needs to be informed about on controller level. The client driver may know if that really is a problem and give more detailed information to the user. The controller should just pass this information upwards. Remove the printout. Signed-off-by: Wolfram Sang Reviewed-by: Jean Delvare --- drivers/i2c/busses/i2c-ali15x3.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-ali15x3.c b/drivers/i2c/busses/i2c-ali1= 5x3.c index d2fa30deb054..956e5020d71e 100644 --- a/drivers/i2c/busses/i2c-ali15x3.c +++ b/drivers/i2c/busses/i2c-ali15x3.c @@ -294,10 +294,8 @@ static int ali15x3_transaction(struct i2c_adapter *ada= p) && (timeout++ < MAX_TIMEOUT)); =20 /* If the SMBus is still busy, we give up */ - if (timeout > MAX_TIMEOUT) { + if (timeout > MAX_TIMEOUT) result =3D -ETIMEDOUT; - dev_err(&adap->dev, "SMBus Timeout!\n"); - } =20 if (temp & ALI15X3_STS_TERM) { result =3D -EIO; --=20 2.43.0