From nobody Sat May 18 07:09:01 2024 Received: from smtpbgsg2.qq.com (smtpbgsg2.qq.com [54.254.200.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D497D79D3; Tue, 23 Apr 2024 08:31:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.254.200.128 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713861104; cv=none; b=imwsumO9XqomoKXWOsQirIzfZ5cWF4v4wPmMA8+y1i4R3Lw4kh2Vs7Lx0QcjtcGOl0Ax1sDTOEV5CscwpsZDq+9R8+6y3HWvOmuddz+qdrda/MejnnVtKmxEL1n/8gxLzCoAz9chOXFDkrPRvb7MbzI2I70D82CqUBBmHZe42rw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713861104; c=relaxed/simple; bh=eGgBQtvqHszHLZjEaVNOzyrzgGeymXRzgL/zYDf5Cj0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=eTWgdPYEuLzSv88+tdnSh7515TxlmqF47Lb+OYuYv+s3n4Lw1Egn57bzAOu4T6OTV43o8qsHNvXAWRUUP48U9NH5jlKCG6s6yFtlFJqPudnY50XXMHUQxD3Wx9YmQRw+T2HboXaYY/24j3NE1TTyfAYGwnx1Ns23Yw26BzAvXlE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shingroup.cn; spf=pass smtp.mailfrom=shingroup.cn; arc=none smtp.client-ip=54.254.200.128 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shingroup.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shingroup.cn X-QQ-mid: bizesmtp82t1713861067tou125gg X-QQ-Originating-IP: 51OwVtAtuarwI4cCOTceEqcV9mknxm2HbvPOgPobPo0= Received: from localhost ( [112.0.147.129]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 23 Apr 2024 16:31:05 +0800 (CST) X-QQ-SSF: 01400000000000903000000A0000000 X-QQ-FEAT: j86OQQvu8eQ1KhrGmCdEjrtfAbzGLSdea3066tUtHFRZeB3xbcnbrMa6/vNVC qrSR54Kjk6fKefvit8IzvrooMnYPYRldF/GLWR3VBzoNXJDegfDGxizLpcW5z8RAkdnEOqt +u5QwNny/+pQvYGlX5aXNN5X10gLT4fdxQvBOgBde5x+mfYFFoP3lsEba7xyM59vv6tHNzR odb+ahZYquwTveFuVonFYmjHqFZizYWVTnBy33DpzDA4ErmqvAS8Lw4z3SfvdBK3t26FJP+ CNXbFhfNr9+r3NFdR/Nhuy9TFIHpdyXronYd9V+Mgv/mvkXCocZ6vr86HNSkMfm51gmWKoj 2h5hHsqqc4Brr5j4aFah4xry9zGQEtJRkbjvVbbb514WM2qdUxmb11BhkiyIltY7SLDREfd UFtB97v3rjRrcqHuYo6p8g== X-QQ-GoodBg: 2 X-BIZMAIL-ID: 7545835907098097455 From: Dawei Li To: davem@davemloft.net, andreas@gaisler.com Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, sam@ravnborg.org, Dawei Li Subject: [PATCH v3 1/6] sparc/srmmu: Remove on-stack cpumask var Date: Tue, 23 Apr 2024 16:30:38 +0800 Message-Id: <20240423083043.3735921-2-dawei.li@shingroup.cn> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20240423083043.3735921-1-dawei.li@shingroup.cn> References: <20240423083043.3735921-1-dawei.li@shingroup.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:shingroup.cn:qybglogicsvrgz:qybglogicsvrgz5a-1 Content-Type: text/plain; charset="utf-8" In general it's preferable to avoid placing cpumasks on the stack, as for large values of NR_CPUS these can consume significant amounts of stack space and make stack overflows more likely. Use cpumask_any_but() to avoid the need for a temporary cpumask on the stack and simplify code. Reviewed-by: Sam Ravnborg Signed-off-by: Dawei Li --- arch/sparc/mm/srmmu.c | 40 ++++++++++++---------------------------- 1 file changed, 12 insertions(+), 28 deletions(-) diff --git a/arch/sparc/mm/srmmu.c b/arch/sparc/mm/srmmu.c index 852085ada368..9df51a62333d 100644 --- a/arch/sparc/mm/srmmu.c +++ b/arch/sparc/mm/srmmu.c @@ -1653,13 +1653,15 @@ static void smp_flush_tlb_all(void) local_ops->tlb_all(); } =20 +static bool any_other_mm_cpus(struct mm_struct *mm) +{ + return cpumask_any_but(mm_cpumask(mm), smp_processor_id()) < nr_cpu_ids; +} + static void smp_flush_cache_mm(struct mm_struct *mm) { if (mm->context !=3D NO_CONTEXT) { - cpumask_t cpu_mask; - cpumask_copy(&cpu_mask, mm_cpumask(mm)); - cpumask_clear_cpu(smp_processor_id(), &cpu_mask); - if (!cpumask_empty(&cpu_mask)) + if (any_other_mm_cpus(mm)) xc1(local_ops->cache_mm, (unsigned long)mm); local_ops->cache_mm(mm); } @@ -1668,10 +1670,7 @@ static void smp_flush_cache_mm(struct mm_struct *mm) static void smp_flush_tlb_mm(struct mm_struct *mm) { if (mm->context !=3D NO_CONTEXT) { - cpumask_t cpu_mask; - cpumask_copy(&cpu_mask, mm_cpumask(mm)); - cpumask_clear_cpu(smp_processor_id(), &cpu_mask); - if (!cpumask_empty(&cpu_mask)) { + if (any_other_mm_cpus(mm)) { xc1(local_ops->tlb_mm, (unsigned long)mm); if (atomic_read(&mm->mm_users) =3D=3D 1 && current->active_mm =3D=3D mm) cpumask_copy(mm_cpumask(mm), @@ -1688,10 +1687,7 @@ static void smp_flush_cache_range(struct vm_area_str= uct *vma, struct mm_struct *mm =3D vma->vm_mm; =20 if (mm->context !=3D NO_CONTEXT) { - cpumask_t cpu_mask; - cpumask_copy(&cpu_mask, mm_cpumask(mm)); - cpumask_clear_cpu(smp_processor_id(), &cpu_mask); - if (!cpumask_empty(&cpu_mask)) + if (any_other_mm_cpus(mm)) xc3(local_ops->cache_range, (unsigned long)vma, start, end); local_ops->cache_range(vma, start, end); @@ -1705,10 +1701,7 @@ static void smp_flush_tlb_range(struct vm_area_struc= t *vma, struct mm_struct *mm =3D vma->vm_mm; =20 if (mm->context !=3D NO_CONTEXT) { - cpumask_t cpu_mask; - cpumask_copy(&cpu_mask, mm_cpumask(mm)); - cpumask_clear_cpu(smp_processor_id(), &cpu_mask); - if (!cpumask_empty(&cpu_mask)) + if (any_other_mm_cpus(mm)) xc3(local_ops->tlb_range, (unsigned long)vma, start, end); local_ops->tlb_range(vma, start, end); @@ -1720,10 +1713,7 @@ static void smp_flush_cache_page(struct vm_area_stru= ct *vma, unsigned long page) struct mm_struct *mm =3D vma->vm_mm; =20 if (mm->context !=3D NO_CONTEXT) { - cpumask_t cpu_mask; - cpumask_copy(&cpu_mask, mm_cpumask(mm)); - cpumask_clear_cpu(smp_processor_id(), &cpu_mask); - if (!cpumask_empty(&cpu_mask)) + if (any_other_mm_cpus(mm)) xc2(local_ops->cache_page, (unsigned long)vma, page); local_ops->cache_page(vma, page); } @@ -1734,10 +1724,7 @@ static void smp_flush_tlb_page(struct vm_area_struct= *vma, unsigned long page) struct mm_struct *mm =3D vma->vm_mm; =20 if (mm->context !=3D NO_CONTEXT) { - cpumask_t cpu_mask; - cpumask_copy(&cpu_mask, mm_cpumask(mm)); - cpumask_clear_cpu(smp_processor_id(), &cpu_mask); - if (!cpumask_empty(&cpu_mask)) + if (any_other_mm_cpus(mm)) xc2(local_ops->tlb_page, (unsigned long)vma, page); local_ops->tlb_page(vma, page); } @@ -1759,10 +1746,7 @@ static void smp_flush_page_to_ram(unsigned long page) =20 static void smp_flush_sig_insns(struct mm_struct *mm, unsigned long insn_a= ddr) { - cpumask_t cpu_mask; - cpumask_copy(&cpu_mask, mm_cpumask(mm)); - cpumask_clear_cpu(smp_processor_id(), &cpu_mask); - if (!cpumask_empty(&cpu_mask)) + if (any_other_mm_cpus(mm)) xc2(local_ops->sig_insns, (unsigned long)mm, insn_addr); local_ops->sig_insns(mm, insn_addr); } --=20 2.27.0 From nobody Sat May 18 07:09:01 2024 Received: from smtpbgau2.qq.com (smtpbgau2.qq.com [54.206.34.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76D8B55C29; Tue, 23 Apr 2024 08:31:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.206.34.216 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713861105; cv=none; b=FNohrKDjxqxYf6GiZEe90RjCYEcqQ/G1nsHuvd41R4W08jYTNu0tVKtEjF4Lvz8iS/wvgu20lS97ZZ4IhXnF8pGw/Mx569NNMbTSmpRgnOBhktRI2T9lcl6KfYTMNV/iMk1SrjjbzM+anErEJv6KKsshwJ6EprU6L5Jed7dq26o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713861105; c=relaxed/simple; bh=N6XTfdxhJpxdxT4fVSZa/iMWuusbHZ+zYGBsuw2wehU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=U2kdD1oZZjpuG9hn/bG9Z1DEnd/Z2of/4KrDTYdSoIU8n7pDadhE+kQALDEpU6kSxJ9gkhY/z1/oLyEvFy5ukCeDLaL19F2FOVpaFNCAGYqQwozSOJYhyyVOP8AeKA02IbFrJhsvTg9bGdmicJqw51IlYQuQZdIUjn1IaTEk0yU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shingroup.cn; spf=pass smtp.mailfrom=shingroup.cn; arc=none smtp.client-ip=54.206.34.216 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shingroup.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shingroup.cn X-QQ-mid: bizesmtpsz3t1713861072tkyi525 X-QQ-Originating-IP: fGT2JpDpkETB9GS/V58vu3/bYUIW5c4lzZ4qzFlnZTY= Received: from localhost ( [112.0.147.129]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 23 Apr 2024 16:31:11 +0800 (CST) X-QQ-SSF: 01400000000000903000000A0000000 X-QQ-FEAT: +ynUkgUhZJmV6ir1LCfaBLTxrWfpQKuO3gs5cDJVDOKYEFq3lIG2Jn74P36cc RhOHMWGc+DzOw6s8ljXZHqWPeVLy2MOYRnKI7pdP5/v2VIJbeOhYgjt7S8ZvBI4zHRWX+Of GMMHS74/FZZcTUGxaUXez/GyOw4uRlIfO2PW7w8KgDol1rhkGS7BGp9rUhsFVq2Nb2Dawr9 wIjSDrgATISh0AX6I8y44XMamA1TEptpYc3O1Ik5ryhMkWnLTtkr99tPxThx0xt7265oa4J zFqoHfyc9cjNN6vWWvj/qHWhITAdQgOl4u7SbDB3rBeXL47r86eDAggKnr8Or7nGiRsI2Zr u0924ugv14lrZPD2pazOh7XYs2KQRUPwPgkcHw0BJMNihI1qTAB69R1dsLhZTj/uNFnkons 62GkfIH/xsvrN+b7wVJav0rMn3YzY9GV X-QQ-GoodBg: 2 X-BIZMAIL-ID: 4099338334242054873 From: Dawei Li To: davem@davemloft.net, andreas@gaisler.com Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, sam@ravnborg.org, Dawei Li Subject: [PATCH v3 2/6] sparc/irq: Remove on-stack cpumask var Date: Tue, 23 Apr 2024 16:30:39 +0800 Message-Id: <20240423083043.3735921-3-dawei.li@shingroup.cn> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20240423083043.3735921-1-dawei.li@shingroup.cn> References: <20240423083043.3735921-1-dawei.li@shingroup.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtpsz:shingroup.cn:qybglogicsvrgz:qybglogicsvrgz5a-1 Content-Type: text/plain; charset="utf-8" In general it's preferable to avoid placing cpumasks on the stack, as for large values of NR_CPUS these can consume significant amounts of stack space and make stack overflows more likely. - Both 2 arguments of cpumask_equal() is constant and free of change, no need to allocate extra cpumask variables. - Merge cpumask_and(), cpumask_first() and cpumask_empty() into cpumask_first_and(). Reviewed-by: Sam Ravnborg Signed-off-by: Dawei Li --- arch/sparc/kernel/irq_64.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/arch/sparc/kernel/irq_64.c b/arch/sparc/kernel/irq_64.c index 5280e325d4d6..01ee800efde3 100644 --- a/arch/sparc/kernel/irq_64.c +++ b/arch/sparc/kernel/irq_64.c @@ -349,17 +349,13 @@ static unsigned int sun4u_compute_tid(unsigned long i= map, unsigned long cpuid) #ifdef CONFIG_SMP static int irq_choose_cpu(unsigned int irq, const struct cpumask *affinity) { - cpumask_t mask; int cpuid; =20 - cpumask_copy(&mask, affinity); - if (cpumask_equal(&mask, cpu_online_mask)) { + if (cpumask_equal(affinity, cpu_online_mask)) { cpuid =3D map_to_cpu(irq); } else { - cpumask_t tmp; - - cpumask_and(&tmp, cpu_online_mask, &mask); - cpuid =3D cpumask_empty(&tmp) ? map_to_cpu(irq) : cpumask_first(&tmp); + cpuid =3D cpumask_first_and(affinity, cpu_online_mask); + cpuid =3D cpuid < nr_cpu_ids ? cpuid : map_to_cpu(irq); } =20 return cpuid; --=20 2.27.0 From nobody Sat May 18 07:09:01 2024 Received: from smtpbgbr1.qq.com (smtpbgbr1.qq.com [54.207.19.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE47858213; Tue, 23 Apr 2024 08:31:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.207.19.206 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713861112; cv=none; b=Umf6r4k+brUqX0u3w9KQ4gCddWsFu0L0i9jqdY1HP1w2jWYAbjEYiPlOy8g+8KHLWcEN2ZAmbW25khTVrWHdeQWF0q9DjMXywf1GRnwAzAKfhZUxoHiGD6JwaRHDNJCNQJ9KZwnH9Vv9aVs0JPAoqw+BnMd/7tbWInYUTZQS7oM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713861112; c=relaxed/simple; bh=3q4wkwdzr6bsl7CdF20gWvsb13iPgTuP0auF/wmr1+U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=OhTcTMEmdJpp0pil0qwgoSL/Cayy9YOsAi0ckVeInmarfg14n4gYBae49Vg8nfoO5cjf8ENL2Wype4G76ywu3MKCeLMzD/EzNuiQFpVPNRFIhONopkvdeguzXq348ZqmVUF+WWv04ffsoXGzggjsHNqX+tt05txf1vv5ZTxUBBg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shingroup.cn; spf=pass smtp.mailfrom=shingroup.cn; arc=none smtp.client-ip=54.207.19.206 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shingroup.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shingroup.cn X-QQ-mid: bizesmtpsz13t1713861078t9g3en X-QQ-Originating-IP: oo1v9g1UtXxlA5P1iYVb8E7jef9d9GmSEbpxs51XuO8= Received: from localhost ( [112.0.147.129]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 23 Apr 2024 16:31:16 +0800 (CST) X-QQ-SSF: 01400000000000903000000A0000000 X-QQ-FEAT: LrCnY+iDm+P5Z9oGsxBC2K7ubRX/nU+qwaMKFow8WcrOZH9Cxb6cg7RaCKgdz Sn+IcGtj6G86Ab9NYh1gNqo0GN/ErKrN6fnPUIeun79VC2V19aAOQ4d6frfB4pifDSUTBRG uyV1t607EvgqnbBR2gANaRBJ7UxOvUdSXcNlPIj/Gcqe6FANpeyLxo8M2u45bfLb5trB4QG uxgEh1CNRjZH4iDM2+TJESzxhgTypEX85EXz0p3nwpr5K9aAVHX+dP1OowLq7LEQQMHhl8I 2Qta+lMbPEC3QQEbRHhDnRk2+OfzVeEbYjyLe6N4dwoda2683nK6ERpg9VOePwtqSfaH3X/ 84TFHyKe8tuSB5rH7qqNiHBa2Eo1sYUhpp3PE4vwrlfjtFzcgXNK9Ifar23Y9T885evATS1 jd+7qW3oxKwDHv9GeKPCQB9BSGmnlUa2 X-QQ-GoodBg: 2 X-BIZMAIL-ID: 5733590401528816768 From: Dawei Li To: davem@davemloft.net, andreas@gaisler.com Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, sam@ravnborg.org, Dawei Li Subject: [PATCH v3 3/6] sparc/of: Remove on-stack cpumask var Date: Tue, 23 Apr 2024 16:30:40 +0800 Message-Id: <20240423083043.3735921-4-dawei.li@shingroup.cn> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20240423083043.3735921-1-dawei.li@shingroup.cn> References: <20240423083043.3735921-1-dawei.li@shingroup.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtpsz:shingroup.cn:qybglogicsvrgz:qybglogicsvrgz5a-1 Content-Type: text/plain; charset="utf-8" In general it's preferable to avoid placing cpumasks on the stack, as for large values of NR_CPUS these can consume significant amounts of stack space and make stack overflows more likely. @cpumask of irq_set_affinity() is read-only and free of change, drop unneeded cpumask var. Reviewed-by: Sam Ravnborg Signed-off-by: Dawei Li --- arch/sparc/kernel/of_device_64.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/sparc/kernel/of_device_64.c b/arch/sparc/kernel/of_device= _64.c index c350c58c7f69..f98c2901f335 100644 --- a/arch/sparc/kernel/of_device_64.c +++ b/arch/sparc/kernel/of_device_64.c @@ -624,10 +624,7 @@ static unsigned int __init build_one_device_irq(struct= platform_device *op, out: nid =3D of_node_to_nid(dp); if (nid !=3D -1) { - cpumask_t numa_mask; - - cpumask_copy(&numa_mask, cpumask_of_node(nid)); - irq_set_affinity(irq, &numa_mask); + irq_set_affinity(irq, cpumask_of_node(nid)); } =20 return irq; --=20 2.27.0 From nobody Sat May 18 07:09:01 2024 Received: from smtpbg153.qq.com (smtpbg153.qq.com [13.245.218.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59B5754FAD; Tue, 23 Apr 2024 08:31:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.245.218.24 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713861117; cv=none; b=Bxd/lc0Q0IWOBMz5qdeessvWvVmsm5XaxnRynVmCYGgHUd387NlXUjgp6YjL9k3YRU1+1/3lU6qEENxil4rMWLr2w8hr4pp341Ad5tPnH+6Nv++AGmiazBhNDysytwBUdLaoZzDeHDBNDzu7AGZiSgxl/mhCJ9hs7t/BLShTQww= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713861117; c=relaxed/simple; bh=j26qiSSL/SsQJ3RIDKCP/7AkspKH1HFq2LoNpDQ+AE0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Mlgjpgmz5drGQoMJaUJLk0T4ZAUtbrwbT4goi5uFVi2ecoONe/fZ89GhmS9lNkgswpPFiDbaXtpGjx9psAf+3s1cnyCavU7QqZj+mRlK2yYhIVhhtVAPqmGB5zr3Q0bbUtFHrezaurlyI+n8cdeLomP5YQGZFS3K3c396FogX24= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shingroup.cn; spf=pass smtp.mailfrom=shingroup.cn; arc=none smtp.client-ip=13.245.218.24 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shingroup.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shingroup.cn X-QQ-mid: bizesmtp87t1713861083trzeblda X-QQ-Originating-IP: kv1ZmXjt1ON8o7UDJCJT8yqN8nFiT1WeTFRAy5VFkDk= Received: from localhost ( [112.0.147.129]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 23 Apr 2024 16:31:22 +0800 (CST) X-QQ-SSF: 01400000000000903000000A0000000 X-QQ-FEAT: 9GmJvWU2rBxyUWLB+viF7MgQDFd59YNLn9ApIRMx48b6m1Q6ZqTYLN/MTavQH ROG5zX6sxbwaPJjPwossOL84vpBqVP0morJV0BjcGnQEMn98GPEdQAzBoP+lHV75KZu6pMk GKMTAJSHuDW0GtUzGs2zzRprBgajp+Y4eKF2WXNMnL3Llhf6/2jlqwnIMbWJ3qIF/Q8hFGv 1dcYyzZuTLyXnbrWMqvoYcaFKxN5FBgDnKksdZfsm8a5Ye98PrQDReFMyrCCVaSqRZrMzXL vLOoJyJ+CiJh0YZ3h6QtW/JFREWA9urn3FEHM5BTmlq87iDtxzGBEbsONq4Yfqe8W8oyTSg M9wulzBYcUkaK1wJOR/SiZJgz7PXxZTuoiQecSUi0tKhDFz7hJ/FcaOGasKzvh8lVIn6PSw caSERtx0552JSpvkDHjB7oUi3vtfQ3HS X-QQ-GoodBg: 2 X-BIZMAIL-ID: 1692039969414298604 From: Dawei Li To: davem@davemloft.net, andreas@gaisler.com Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, sam@ravnborg.org, Dawei Li Subject: [PATCH v3 4/6] sparc/pci_msi: Remove on-stack cpumask var Date: Tue, 23 Apr 2024 16:30:41 +0800 Message-Id: <20240423083043.3735921-5-dawei.li@shingroup.cn> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20240423083043.3735921-1-dawei.li@shingroup.cn> References: <20240423083043.3735921-1-dawei.li@shingroup.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:shingroup.cn:qybglogicsvrgz:qybglogicsvrgz5a-1 Content-Type: text/plain; charset="utf-8" In general it's preferable to avoid placing cpumasks on the stack, as for large values of NR_CPUS these can consume significant amounts of stack space and make stack overflows more likely. @cpumask of irq_set_affinity() is read-only and free of change, drop unneeded cpumask var. Reviewed-by: Sam Ravnborg Signed-off-by: Dawei Li --- arch/sparc/kernel/pci_msi.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/sparc/kernel/pci_msi.c b/arch/sparc/kernel/pci_msi.c index fc7402948b7b..acb2f83a1d5c 100644 --- a/arch/sparc/kernel/pci_msi.c +++ b/arch/sparc/kernel/pci_msi.c @@ -287,10 +287,7 @@ static int bringup_one_msi_queue(struct pci_pbm_info *= pbm, =20 nid =3D pbm->numa_node; if (nid !=3D -1) { - cpumask_t numa_mask; - - cpumask_copy(&numa_mask, cpumask_of_node(nid)); - irq_set_affinity(irq, &numa_mask); + irq_set_affinity(irq, cpumask_of_node(nid)); } err =3D request_irq(irq, sparc64_msiq_interrupt, 0, "MSIQ", --=20 2.27.0 From nobody Sat May 18 07:09:01 2024 Received: from smtpbg151.qq.com (smtpbg151.qq.com [18.169.211.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D24E5914C; Tue, 23 Apr 2024 08:31:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.169.211.239 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713861123; cv=none; b=iQETiklktwg7RvrvrxEAA5ensJ8HixPfn4VkYQpkEk0++E8vh6q8clRpe+bhAOqVEai2ANXJNuyilfF7ZnhgvG81/xig+xMa4VnEEWAlKGkx9G2XSh90oXASAv1589GqobZMFqq/DnU/4GTo7aecNhhbdKaooMGlvjMlIZsjP8k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713861123; c=relaxed/simple; bh=/BNrLKrkj1zztdJw2Le2jc+2s6d9f8gUuEhcw02th40=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=HqqZ93bDJADras4TJCD6Ok0P9G8a6bxOBiQVa1K3ahuECs1c8s1oGB1mPzSEU1djIrOJuJToMjWYQVMnDYfEwXaDmFK6HgSdD1zYIllpFGThZhxHHMKuxwpJyvhRxfBZ2XVQAxZk7ldC8H9lNsV/RPwxTrBIEn14QiPuJpVS/94= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shingroup.cn; spf=pass smtp.mailfrom=shingroup.cn; arc=none smtp.client-ip=18.169.211.239 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shingroup.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shingroup.cn X-QQ-mid: bizesmtp89t1713861089t0jhys44 X-QQ-Originating-IP: cUCVoziNrOH0fCzCgaYoM4CE29S8xvLsFE/5E51zYr4= Received: from localhost ( [112.0.147.129]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 23 Apr 2024 16:31:28 +0800 (CST) X-QQ-SSF: 01400000000000903000000A0000000 X-QQ-FEAT: 3M0okmaRx3gIbRIk2WH2P98KRMGrw6qQIogcjcz+juF05Qy9jWNZ5WfFQNFP+ Qdg736uGmqd4IulIwzKDwxF/x5o3JLvSNQqZkXdSLDIfEEABzxBYxs3GIKR7tdYbTbIh6VW lGjtboHecdALAcVUsLh3e5EPQbJWdoIWRtcEX+nimoHqh3FW5MkRsdrBFi/XoGWIGio7Pw4 cCExKXTgxcaJkPwjd4BQsS/lRtg3O93DFoz8UQA9DL0wPxVgYjm4U4bfsxls9IZCJi57Uzc qASAiXm1mHblBWjweThsDHm6hnslRtaIpU83G1xwkNLsXPgSucX/vuzYvd7bZS+Q+WMANGP ElGWHsRJZTUna1M+D3pim5bFsMXPBLNPs0hZXkzXth9kCCWYnsma2sb0z8rknmDX5wXFbg6 3cDdArJ0vLd2k34QBRBoDm4g3+fgXAh0 X-QQ-GoodBg: 2 X-BIZMAIL-ID: 10010987221185693144 From: Dawei Li To: davem@davemloft.net, andreas@gaisler.com Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, sam@ravnborg.org, Dawei Li Subject: [PATCH v3 5/6] sparc/init: Remove on-stack cpumask var Date: Tue, 23 Apr 2024 16:30:42 +0800 Message-Id: <20240423083043.3735921-6-dawei.li@shingroup.cn> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20240423083043.3735921-1-dawei.li@shingroup.cn> References: <20240423083043.3735921-1-dawei.li@shingroup.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:shingroup.cn:qybglogicsvrgz:qybglogicsvrgz5a-1 Content-Type: text/plain; charset="utf-8" In general it's preferable to avoid placing cpumasks on the stack, as for large values of NR_CPUS these can consume significant amounts of stack space and make stack overflows more likely. Since the cpumask var resides in __init function, which means it's free of any concurrenct access, it can be safely marked with static to get rid of allocation on stack. Signed-off-by: Dawei Li --- arch/sparc/mm/init_64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c index 1ca9054d9b97..9edbf57a2c59 100644 --- a/arch/sparc/mm/init_64.c +++ b/arch/sparc/mm/init_64.c @@ -1438,7 +1438,7 @@ static int __init numa_attach_mlgroup(struct mdesc_ha= ndle *md, u64 grp, static int __init numa_parse_mdesc_group(struct mdesc_handle *md, u64 grp, int index) { - cpumask_t mask; + static cpumask_t mask; int cpu; =20 numa_parse_mdesc_group_cpus(md, grp, &mask); --=20 2.27.0 From nobody Sat May 18 07:09:01 2024 Received: from smtpbgsg1.qq.com (smtpbgsg1.qq.com [54.254.200.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93E6D5914A; Tue, 23 Apr 2024 08:31:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.254.200.92 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713861122; cv=none; b=q2XZ2Rs0P00mnjQ+Y/e4H6ibRts31sTgjVRvEyPzr7oiECxREVVOVT7aCAWu0w4SAbzYWt/G0Wg626hE6AIOvFS0YxzDX0C0tlar4bHaSJ/Lve9B6mEvOxY7ilkIMGhBsHm+fWfPu6NZwyJVXeqFemIFELlEHKdvuCmopgZbGAw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713861122; c=relaxed/simple; bh=HWaOv2WaYtGj0iTIw2G2YzAPc0ZR6ectSGNf9jiMO48=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=M6jNjwaofswmkNxCZRThwZbOmxZFuwWH6n4eM/MlmIefoH5AYogruzAD+32ZNJTai418GlzX/Se2xgxdc3gRMEE0RTVx3tvl4CiEVG6dlTX85dyZ6MZrwozukxZ92ZiNCXMQ6N9vaEYIlmpq2sKsbrdRfC9Lb7EL3e4l2IoSC2E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shingroup.cn; spf=pass smtp.mailfrom=shingroup.cn; arc=none smtp.client-ip=54.254.200.92 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=shingroup.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shingroup.cn X-QQ-mid: bizesmtpsz7t1713861094tqgo9ne X-QQ-Originating-IP: lutf5bzmJ+wbPedIhfSab7lj8PN8lQro23AoaHRKdWM= Received: from localhost ( [112.0.147.129]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 23 Apr 2024 16:31:33 +0800 (CST) X-QQ-SSF: 01400000000000903000000A0000000 X-QQ-FEAT: uGhnJwy6xZIizkFrb/rVCurMDKP/+zTB8OFqsvNeXejTj8VZ9Sxq8g+ekbZUt PMba5l+JTWxdLtFbdtdCDmH34yN51tjkxmHh1s2QrrTCHn2wO+I6GnCo1bgbkKxtw/ZqFg2 tANj+CHcr/JctFwzpeP3bugRDzA0VPk6NdOP5fvDnFg5GvEXtfCbHameZpNmzU5CC2VGXdO 9V8bzKevFVcgNjZWH/Qh0IfnEOFC8elDcpcQrvNZVTk5DxC3cDhRpywfWAyknsb3ea5/tOR DH4CgpC09gvWomJ+jvCOyPp38Kc/ZpitxJKqUmh91NU88pU3/7I09pOrZYXlYdxxm/ELOuc tTU9LpVYpTM5V0Uh4yQYa9ckPrW8ENfEIAQ4TBjzodHZi8SJYYCFTXTTZfziOY2uSFKDUIT fzCXbr5VavSmxRTybMT/cfUodPiO0rTV X-QQ-GoodBg: 2 X-BIZMAIL-ID: 4735814251220725647 From: Dawei Li To: davem@davemloft.net, andreas@gaisler.com Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, sam@ravnborg.org, Dawei Li Subject: [PATCH v3 6/6] sparc/leon: Remove on-stack cpumask var Date: Tue, 23 Apr 2024 16:30:43 +0800 Message-Id: <20240423083043.3735921-7-dawei.li@shingroup.cn> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20240423083043.3735921-1-dawei.li@shingroup.cn> References: <20240423083043.3735921-1-dawei.li@shingroup.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtpsz:shingroup.cn:qybglogicsvrgz:qybglogicsvrgz5a-1 Content-Type: text/plain; charset="utf-8" In general it's preferable to avoid placing cpumasks on the stack, as for large values of NR_CPUS these can consume significant amounts of stack space and make stack overflows more likely. Use cpumask_subset() and cpumask_first_and() to avoid the need for a temporary cpumask on the stack. Signed-off-by: Dawei Li Reviewed-by: Sam Ravnborg --- arch/sparc/kernel/leon_kernel.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/sparc/kernel/leon_kernel.c b/arch/sparc/kernel/leon_kerne= l.c index 4c61da491fee..a43cf794bb1e 100644 --- a/arch/sparc/kernel/leon_kernel.c +++ b/arch/sparc/kernel/leon_kernel.c @@ -106,13 +106,12 @@ unsigned long leon_get_irqmask(unsigned int irq) #ifdef CONFIG_SMP static int irq_choose_cpu(const struct cpumask *affinity) { - cpumask_t mask; + unsigned int cpu =3D cpumask_first_and(affinity, cpu_online_mask); =20 - cpumask_and(&mask, cpu_online_mask, affinity); - if (cpumask_equal(&mask, cpu_online_mask) || cpumask_empty(&mask)) + if (cpumask_subset(cpu_online_mask, affinity) || cpu >=3D nr_cpu_ids) return boot_cpu_id; else - return cpumask_first(&mask); + return cpu; } #else #define irq_choose_cpu(affinity) boot_cpu_id --=20 2.27.0