From nobody Fri Feb 13 17:31:39 2026 Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB3AC12F38C for ; Fri, 19 Apr 2024 15:18:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713539887; cv=none; b=BApC5o37nk788kCAo/YH9tngZk3dyPKbEo3C33jia+rrH8Z7FyJfhUBZT6XgKTpUp+GaGL4QZvlrFoA0rIPJCJVfh13IrTJ7n6P8SOLlWcuSFrLppoRFkab8Ib254gIuQI38wnlf9lJ1gDx3seF1XyhycViK3K7MPMbWm70B7o0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713539887; c=relaxed/simple; bh=fD4GtJkND5n3skuzOjX/NHgWkIf/VxMqfAgE+7qbH6A=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Q+gRh42Iv+vJ5SU1jHp6LMzb1lbMICbDN4aOU+Ip9XtBjRGPhmVSMyNAHf177YAQfOzHhfjdeXqDnLOH2C0V2b8yphpaRYvLI3/qLdlC7CHIyBpsWb2xye3+qZ29fFqK7FOe5Zgu0NRd+yN1SnfQ/1S6GGEm/OYzGEaG/J5oE54= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PpElE5Nx; arc=none smtp.client-ip=209.85.166.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PpElE5Nx" Received: by mail-io1-f51.google.com with SMTP id ca18e2360f4ac-7d5e4097a9aso77908739f.3 for ; Fri, 19 Apr 2024 08:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713539885; x=1714144685; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ozWFvCz/JSLWpvmqAUWIX5N+6wqlehvl2PgyPqAmf3Y=; b=PpElE5NxiDJcZR4OOvs5nu5/wF89pl4vwR75fkFv4T+er+HfAvvrX9fwAD7CJ93ALV Z2uguRnOU8eQgzfN1ea0rqdJWm6IoYdwBkZHOQXyKi86iDoQ9n7DhSztABi+RiQ5oBoh /bdzKio6xCE9/h/T2T7kbNi3HG8m4CXkEDtoYPOEBS1Na5basepfGJTvqUlrkHaAVA3f 5nSX7nBhESOL5I9bYezGRyv0dCy5RzAdV09IW82oTh3Vgr0rxHdUEgcY4n0DHYCDVkCw EVmA1bD05rCGMy5ONiDYISGCty+Js2Sz5PjGviBFfoJwOw1zwiEHAHkCXOK7RcFah8z9 yA2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713539885; x=1714144685; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ozWFvCz/JSLWpvmqAUWIX5N+6wqlehvl2PgyPqAmf3Y=; b=hBO5s0lZ82kNL8VZVSGzaETUqAzJH/9xqx3rT7uD8voF4PEBUGooRVIG3bmHBNKcFU IU6cDZQwOfyMktC0E7HdIiUWEsv77SaGg86ftJZS9yxUdQ/UbdQf28VhL4w81lVh8L+o tu1+BYPO2e3AF0d1+hjnJR2np18TBgtAAdnrQAxZcMkx0AOMxpmifazabHxg8Wz5jAQr 9xTdw8m6061OIsKUOOXybJRTkOb6dlHQ8f4b43sUAY6EUG7o3hXtAGQx1qrVgDctZdnT u5j1dh5qdxDLUUO3JVl5ky90Eo9d95Wm2QimwSkHsBKXI/5A7iTpc51FVchDpYJlEuSl de9w== X-Forwarded-Encrypted: i=1; AJvYcCWIapO2Em6yLjPvd6FGaxkFV162xK2aFBc9BLUNaRkCGObSDn4mINK+HcmMyqidikjkXHq9rDswumgZ/fXjWXP58dDXPD2WS+dwxEFZ X-Gm-Message-State: AOJu0YzlB1gD59P1RnzJCMo2wucPkpDMBU8EiJgZDSQfncIdmqN5NBD8 e/PoR+mHkYw6H/MvqWxdRwE1LTQoolQ86Zjyrt34CrJZwXVtkVZ4Bv6q3T8wRQs= X-Google-Smtp-Source: AGHT+IEoLoAQWS9gMBMZDr7ok+++sYe7DskbfxC7uwOH1LqCCmAzw/fyNZQHJP1MEjnS2s9+s5izXg== X-Received: by 2002:a6b:ed0e:0:b0:7d5:f78f:ab0c with SMTP id n14-20020a6bed0e000000b007d5f78fab0cmr2950857iog.20.1713539885132; Fri, 19 Apr 2024 08:18:05 -0700 (PDT) Received: from localhost.localdomain (c-73-228-159-35.hsd1.mn.comcast.net. [73.228.159.35]) by smtp.gmail.com with ESMTPSA id lc8-20020a056638958800b00484e9c7014bsm116126jab.153.2024.04.19.08.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 08:18:04 -0700 (PDT) From: Alex Elder To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: mka@chromium.org, andersson@kernel.org, quic_cpratapa@quicinc.com, quic_avuyyuru@quicinc.com, quic_jponduru@quicinc.com, quic_subashab@quicinc.com, elder@kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 1/8] net: ipa: maintain bitmap of suspend-enabled endpoints Date: Fri, 19 Apr 2024 10:17:53 -0500 Message-Id: <20240419151800.2168903-2-elder@linaro.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240419151800.2168903-1-elder@linaro.org> References: <20240419151800.2168903-1-elder@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Keep track of which endpoints have the SUSPEND IPA interrupt enabled in a variable-length bitmap. This will be used in the next patch to allow the SUSPEND interrupt type to be disabled except when needed. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_interrupt.c | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/net/ipa/ipa_interrupt.c b/drivers/net/ipa/ipa_interrup= t.c index 4d472f4b0002e..18036e9cd161f 100644 --- a/drivers/net/ipa/ipa_interrupt.c +++ b/drivers/net/ipa/ipa_interrupt.c @@ -37,11 +37,13 @@ * @ipa: IPA pointer * @irq: Linux IRQ number used for IPA interrupts * @enabled: Mask indicating which interrupts are enabled + * @suspend_enabled: Bitmap of endpoints with the SUSPEND interrupt enabled */ struct ipa_interrupt { struct ipa *ipa; u32 irq; u32 enabled; + unsigned long *suspend_enabled; }; =20 /* Clear the suspend interrupt for all endpoints that signaled it */ @@ -211,6 +213,7 @@ static void ipa_interrupt_suspend_control(struct ipa_in= terrupt *interrupt, val |=3D mask; else val &=3D ~mask; + __change_bit(endpoint_id, interrupt->suspend_enabled); =20 iowrite32(val, ipa->reg_virt + offset); } @@ -246,7 +249,16 @@ int ipa_interrupt_config(struct ipa *ipa) =20 interrupt->ipa =3D ipa; =20 - /* Disable all IPA interrupt types */ + /* Initially all IPA interrupt types are disabled */ + interrupt->enabled =3D 0; + interrupt->suspend_enabled =3D bitmap_zalloc(ipa->endpoint_count, + GFP_KERNEL); + if (!interrupt->suspend_enabled) { + ret =3D -ENOMEM; + goto err_kfree; + } + + /* Disable IPA interrupt types */ reg =3D ipa_reg(ipa, IPA_IRQ_EN); iowrite32(0, ipa->reg_virt + reg_offset(reg)); =20 @@ -254,7 +266,7 @@ int ipa_interrupt_config(struct ipa *ipa) "ipa", interrupt); if (ret) { dev_err(dev, "error %d requesting \"ipa\" IRQ\n", ret); - goto err_kfree; + goto err_free_bitmap; } =20 ret =3D dev_pm_set_wake_irq(dev, irq); @@ -270,6 +282,8 @@ int ipa_interrupt_config(struct ipa *ipa) =20 err_free_irq: free_irq(interrupt->irq, interrupt); +err_free_bitmap: + bitmap_free(interrupt->suspend_enabled); err_kfree: kfree(interrupt); =20 @@ -286,6 +300,7 @@ void ipa_interrupt_deconfig(struct ipa *ipa) =20 dev_pm_clear_wake_irq(dev); free_irq(interrupt->irq, interrupt); + bitmap_free(interrupt->suspend_enabled); } =20 /* Initialize the IPA interrupt structure */ --=20 2.40.1 From nobody Fri Feb 13 17:31:39 2026 Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B6ED12F5BB for ; Fri, 19 Apr 2024 15:18:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713539889; cv=none; b=TfprLKrLT792SW+MG/VRz+r/PDvAOKYCKg88cbYdtYEMasBkbJIVyQPsAFA/XREXdTR1LtQyQGFUjkVQpWtN5uPuGiWsxTmBjJY/PEUFYK07dHWhBPA3Ot6EjjiTjgSg3DDCGxiBq5Oa1eKKLi3NYmBn+/UGjv+YwSXoQBdR6cw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713539889; c=relaxed/simple; bh=e14D7TKpEvZf5OnwvIcuBGe61+yGxis+fUvADt/aWF8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jfqlFUmBt202OggSrIAuWo8IEy9OeaOaaqLwW+YTMk3fZ0GfEIWDJXe46UczU2sn18tGNvEitMHeYCrqubiiiBCpEri2IAX3KXmZNqo4KLd5qEnoz53CKilms62v2tyns3GYFTP6YWJqUwPoO1MGWBux0l3PZBThO2E47fS9qnk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DkeoN7vB; arc=none smtp.client-ip=209.85.166.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DkeoN7vB" Received: by mail-io1-f48.google.com with SMTP id ca18e2360f4ac-7d6a772af5bso76170739f.1 for ; Fri, 19 Apr 2024 08:18:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713539886; x=1714144686; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r1/gGz9kpYbLFaH+UuJD8Tkj5MFD/GFitlOxG2qqSIA=; b=DkeoN7vBIArbqwo5yn5aa+wB11wkFXPKDN6Wur1K2Zk0iJFcQ9jraGQgq1VPAMZAUd CGyu/2R4yY+pbEQnTJRMU/xRoTEzegwxL95PSzJNkhCjbf8PxR/O5gWP8XxHx3iYeuzV crV7IysD6L7iZ/SaQIvZbJ8ioinZ8XrHP2AZLR5RKrVlkt6F6PNf22f2atWsUit7JmNt V3AyEMuiL4M9Gc5jS22XWvANxPJG4bi20RU9ZasNXhaqz78a6FUHBBGE9wtyihno9bvg AW32otsPUocuv0AmvwojygcX5pOW3wackxw7lr6EV7AP9+YZBkLbYTNBbjHAamUBsJtS dpxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713539886; x=1714144686; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r1/gGz9kpYbLFaH+UuJD8Tkj5MFD/GFitlOxG2qqSIA=; b=Crr26ntLbin3EJXd39hFQeX33S95aAocbsrtdrxHJpEo9P0Sy++c4pGuMxERMphVkx d63WnuiiicIBKHEeTzYQ2y96JvHE5L6waPRsEiBbSL1ykYlKHB3OXhr7aeFS53OG3G0B y8A2/TNrSglLUYLcN0Vny7PHh14QI8p6SLXGp6P5wXh9FpgWYquun/vxwtoWT8FQxkke dnpY8kbD+SugZSCr4QTigA9PU4HlaiN+dc2VsRGGbZ7QGISgIWVE61AyGIPCbxWpIkEQ NBr0BBd0PCVfNGVRdX6L3y3cEjtT3mtq64IMn0XBoL5VSGAVgKgmx9HoTxA98kPgmddO XgzQ== X-Forwarded-Encrypted: i=1; AJvYcCV6isdSMd3DN0d/mnza29uv7w7Zj9x5OKmwwJFaTNNm+i9RdBydANrj8chHhJAYcyh8ovWWVjyhnM4hbaYxSx6Kh/1xHz9WRabgbm1h X-Gm-Message-State: AOJu0Yw5g14TNupdCqtrrWrXAXf4EEeCyLpmtFZ55U0RUmk26s9cwiJG 7GAQmqep/W8WueED2HJtGlj81XvZIJ1yqm14qh76o64B7dDw4S7RBBJiCHJJb9E= X-Google-Smtp-Source: AGHT+IGmMBrA8dMR9MNSQF58KLAm84ynEVXwhg/TqwiDztGgWaBhEIIt+WXVFFaf50zLl0b9PEK4AA== X-Received: by 2002:a05:6602:4a86:b0:7da:1885:50b5 with SMTP id ej6-20020a0566024a8600b007da188550b5mr2631577iob.9.1713539886236; Fri, 19 Apr 2024 08:18:06 -0700 (PDT) Received: from localhost.localdomain (c-73-228-159-35.hsd1.mn.comcast.net. [73.228.159.35]) by smtp.gmail.com with ESMTPSA id lc8-20020a056638958800b00484e9c7014bsm116126jab.153.2024.04.19.08.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 08:18:05 -0700 (PDT) From: Alex Elder To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: mka@chromium.org, andersson@kernel.org, quic_cpratapa@quicinc.com, quic_avuyyuru@quicinc.com, quic_jponduru@quicinc.com, quic_subashab@quicinc.com, elder@kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 2/8] net: ipa: only enable the SUSPEND IPA interrupt when needed Date: Fri, 19 Apr 2024 10:17:54 -0500 Message-Id: <20240419151800.2168903-3-elder@linaro.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240419151800.2168903-1-elder@linaro.org> References: <20240419151800.2168903-1-elder@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Only enable the SUSPEND IPA interrupt type when at least one endpoint has that interrupt enabled. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_interrupt.c | 8 ++++++++ drivers/net/ipa/ipa_power.c | 11 +---------- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/net/ipa/ipa_interrupt.c b/drivers/net/ipa/ipa_interrup= t.c index 18036e9cd161f..2ef640f9197c7 100644 --- a/drivers/net/ipa/ipa_interrupt.c +++ b/drivers/net/ipa/ipa_interrupt.c @@ -196,6 +196,7 @@ static void ipa_interrupt_suspend_control(struct ipa_in= terrupt *interrupt, u32 mask =3D BIT(endpoint_id % 32); u32 unit =3D endpoint_id / 32; const struct reg *reg; + unsigned long weight; u32 offset; u32 val; =20 @@ -205,6 +206,10 @@ static void ipa_interrupt_suspend_control(struct ipa_i= nterrupt *interrupt, if (ipa->version =3D=3D IPA_VERSION_3_0) return; =20 + weight =3D bitmap_weight(interrupt->suspend_enabled, ipa->endpoint_count); + if (weight =3D=3D 1 && !enable) + ipa_interrupt_disable(ipa, IPA_IRQ_TX_SUSPEND); + reg =3D ipa_reg(ipa, IRQ_SUSPEND_EN); offset =3D reg_n_offset(reg, unit); val =3D ioread32(ipa->reg_virt + offset); @@ -216,6 +221,9 @@ static void ipa_interrupt_suspend_control(struct ipa_in= terrupt *interrupt, __change_bit(endpoint_id, interrupt->suspend_enabled); =20 iowrite32(val, ipa->reg_virt + offset); + + if (!weight && enable) + ipa_interrupt_enable(ipa, IPA_IRQ_TX_SUSPEND); } =20 /* Enable TX_SUSPEND for an endpoint */ diff --git a/drivers/net/ipa/ipa_power.c b/drivers/net/ipa/ipa_power.c index 3a7049923c381..1a413061472d8 100644 --- a/drivers/net/ipa/ipa_power.c +++ b/drivers/net/ipa/ipa_power.c @@ -234,21 +234,12 @@ void ipa_power_retention(struct ipa *ipa, bool enable) =20 int ipa_power_setup(struct ipa *ipa) { - int ret; - - ipa_interrupt_enable(ipa, IPA_IRQ_TX_SUSPEND); - - ret =3D device_init_wakeup(ipa->dev, true); - if (ret) - ipa_interrupt_disable(ipa, IPA_IRQ_TX_SUSPEND); - - return ret; + return device_init_wakeup(ipa->dev, true); } =20 void ipa_power_teardown(struct ipa *ipa) { (void)device_init_wakeup(ipa->dev, false); - ipa_interrupt_disable(ipa, IPA_IRQ_TX_SUSPEND); } =20 /* Initialize IPA power management */ --=20 2.40.1 From nobody Fri Feb 13 17:31:39 2026 Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23D4912FF76 for ; Fri, 19 Apr 2024 15:18:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713539889; cv=none; b=ufSdQwyP8ZPPS6imC5bJNtm0gFUD4rwAjIMv8RwHgLgts8w9ef2FEhVwY13q7OsnppJ4iqcSq0zgst5g1I4imO3EccNS7RB4vtbknc+8FgCzJcsPG7otbET0mXZrtkPjhO7TwGbHmruF48PrzLDJBpwSLe4Q4ZPd9GqJqx0gglk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713539889; c=relaxed/simple; bh=Q0E7FhXIRDhGAblpeieYVhQkwbjvfK6IuTNLIIQZVUY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=saVUGUHrfh0Hd8ucNU7+bUE+GUq7aDzOPW4thSReh0wsoYg9qYrBebQV+fOh2baPhWZq0J/bmrqUkhIOXh9hDdbP/FSgt5i9Lp/1h7/uJQEG3FHSrw8/lswuhJzSgbNdEalIG+bPyCYUrSWyTQDcMf8uwl9KXdSsomZxTzn7gpw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zs4XPMpR; arc=none smtp.client-ip=209.85.166.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zs4XPMpR" Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-7c8ad87b2acso56560639f.3 for ; Fri, 19 Apr 2024 08:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713539887; x=1714144687; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fHMnYNBF3duo4/+KlP8bC20trtUqzEZR9+R77ODU+ms=; b=zs4XPMpRES3TNyK+j9+QHQTgL+NJShzfWixar8oc/Nzf3mZ8uKQvG6E/kZEY4u4IOO IajvXiPrBbc8T6ituCkQjP0raFR7nD8GJ0vdpfZRo5eDfvgfInct1m/Usnbv9Yo89aCs ZGzBEhoPYlHdfw02udGGlJo2ETffqxAyHHqepWsQzmC6v4e9+Xi7pyK2BJ3ycoQ5m7Hh /TRlrYInI0DLXiTet/5NzEz931+/q44n464D35PW+JgPEmgUURP0K4CqKcoRJ7OQsFAG eVV7rueNix9HwHMXdS6NGraHLiMKB/kihBo1tNQNqKsAhbBCHhP59hIJJhLBvlDG2g7V yrSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713539887; x=1714144687; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fHMnYNBF3duo4/+KlP8bC20trtUqzEZR9+R77ODU+ms=; b=I9pPoWF/Q4hDYttx3iWoYHIFAOUv8rt0r8DCFZ4X34V4Ew2aQ8S5Z5g9IcqUaKFSxR iEoez4Jk0O7uMnj4dEU/tOmc62f94wQCu2Orwq90hVz8GXqpxvyb0Qiz6KzEPEwOxb3z J3d9q71JOFYA04CHZ6JTw007jxmX0V8AHdAd5z5Ui19chzMVS0OrPtXGlw0q8qWEyaYh /tUBIS0T8T0AfYrRQdo0nlts0nx3kJ/BMtSlYQkW8XJ4AY2rgBAMAAZLX/85+lTb5dkx lTuxoxaMvi3gNJ8OGsVvQLwCjZR6qtRo/NmmqxZmtyrnrexo8JzAHd2yKAJrWnJzrqWX T2qQ== X-Forwarded-Encrypted: i=1; AJvYcCUjyPftG57fuzKH3Pchj2rcO3WZJ1hYPXMtVsN1sctvP+yIYWysmmkJcyrpUWpPoAC2vxOD4GO4iKnCKgkA+c+s9jDkJ+r9x7bLUUjZ X-Gm-Message-State: AOJu0Yxyby0AW2ZqeM1eNSrgw5Uwy3GS/kcVC9Zd0diXY5YWGU9tiKMd /F+SDXlr1RIAnS1gj1OY2vqfvFbNKmftY7Pxhaq0xS9I6b4OZv4aevGYRyMBMMY= X-Google-Smtp-Source: AGHT+IF7GPcHIRyDVCOIwyo6NIzltkE/fTfp0QyP4PY6C2+tHxBzXNvbfCeSsFlZBX8lhUSM7W80YA== X-Received: by 2002:a05:6602:1d52:b0:7d9:6474:812e with SMTP id hi18-20020a0566021d5200b007d96474812emr3076780iob.2.1713539887321; Fri, 19 Apr 2024 08:18:07 -0700 (PDT) Received: from localhost.localdomain (c-73-228-159-35.hsd1.mn.comcast.net. [73.228.159.35]) by smtp.gmail.com with ESMTPSA id lc8-20020a056638958800b00484e9c7014bsm116126jab.153.2024.04.19.08.18.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 08:18:07 -0700 (PDT) From: Alex Elder To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: mka@chromium.org, andersson@kernel.org, quic_cpratapa@quicinc.com, quic_avuyyuru@quicinc.com, quic_jponduru@quicinc.com, quic_subashab@quicinc.com, elder@kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 3/8] net: ipa: call device_init_wakeup() earlier Date: Fri, 19 Apr 2024 10:17:55 -0500 Message-Id: <20240419151800.2168903-4-elder@linaro.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240419151800.2168903-1-elder@linaro.org> References: <20240419151800.2168903-1-elder@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently, enabling wakeup for the IPA device doesn't occur until the setup phase of initialization (in ipa_power_setup()). There is no need to delay doing that, however. We can conveniently do it during the config phase, in ipa_interrupt_config(), where we enable power management wakeup mode for the IPA interrupt. Moving the device_init_wakeup() out of ipa_power_setup() leaves that function empty, so it can just be eliminated. Similarly, rearrange all of the matching inverse calls, disabling device wakeup in ipa_interrupt_deconfig() and removing that function as well. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_interrupt.c | 11 ++++++++++- drivers/net/ipa/ipa_main.c | 7 ------- drivers/net/ipa/ipa_power.c | 10 ---------- drivers/net/ipa/ipa_power.h | 14 -------------- 4 files changed, 10 insertions(+), 32 deletions(-) diff --git a/drivers/net/ipa/ipa_interrupt.c b/drivers/net/ipa/ipa_interrup= t.c index 2ef640f9197c7..245a069970556 100644 --- a/drivers/net/ipa/ipa_interrupt.c +++ b/drivers/net/ipa/ipa_interrupt.c @@ -277,17 +277,25 @@ int ipa_interrupt_config(struct ipa *ipa) goto err_free_bitmap; } =20 + ret =3D device_init_wakeup(dev, true); + if (ret) { + dev_err(dev, "error %d enabling wakeup\n", ret); + goto err_free_irq; + } + ret =3D dev_pm_set_wake_irq(dev, irq); if (ret) { dev_err(dev, "error %d registering \"ipa\" IRQ as wakeirq\n", ret); - goto err_free_irq; + goto err_disable_wakeup; } =20 ipa->interrupt =3D interrupt; =20 return 0; =20 +err_disable_wakeup: + (void)device_init_wakeup(dev, false); err_free_irq: free_irq(interrupt->irq, interrupt); err_free_bitmap: @@ -307,6 +315,7 @@ void ipa_interrupt_deconfig(struct ipa *ipa) ipa->interrupt =3D NULL; =20 dev_pm_clear_wake_irq(dev); + (void)device_init_wakeup(dev, false); free_irq(interrupt->irq, interrupt); bitmap_free(interrupt->suspend_enabled); } diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c index 6523878c0d7f6..b13a59f27106d 100644 --- a/drivers/net/ipa/ipa_main.c +++ b/drivers/net/ipa/ipa_main.c @@ -119,10 +119,6 @@ int ipa_setup(struct ipa *ipa) if (ret) return ret; =20 - ret =3D ipa_power_setup(ipa); - if (ret) - goto err_gsi_teardown; - ipa_endpoint_setup(ipa); =20 /* We need to use the AP command TX endpoint to perform other @@ -169,8 +165,6 @@ int ipa_setup(struct ipa *ipa) ipa_endpoint_disable_one(command_endpoint); err_endpoint_teardown: ipa_endpoint_teardown(ipa); - ipa_power_teardown(ipa); -err_gsi_teardown: gsi_teardown(&ipa->gsi); =20 return ret; @@ -195,7 +189,6 @@ static void ipa_teardown(struct ipa *ipa) command_endpoint =3D ipa->name_map[IPA_ENDPOINT_AP_COMMAND_TX]; ipa_endpoint_disable_one(command_endpoint); ipa_endpoint_teardown(ipa); - ipa_power_teardown(ipa); gsi_teardown(&ipa->gsi); } =20 diff --git a/drivers/net/ipa/ipa_power.c b/drivers/net/ipa/ipa_power.c index 1a413061472d8..65fd14da0f86f 100644 --- a/drivers/net/ipa/ipa_power.c +++ b/drivers/net/ipa/ipa_power.c @@ -232,16 +232,6 @@ void ipa_power_retention(struct ipa *ipa, bool enable) ret, enable ? "en" : "dis"); } =20 -int ipa_power_setup(struct ipa *ipa) -{ - return device_init_wakeup(ipa->dev, true); -} - -void ipa_power_teardown(struct ipa *ipa) -{ - (void)device_init_wakeup(ipa->dev, false); -} - /* Initialize IPA power management */ struct ipa_power * ipa_power_init(struct device *dev, const struct ipa_power_data *data) diff --git a/drivers/net/ipa/ipa_power.h b/drivers/net/ipa/ipa_power.h index 3ffaa0687caa8..a83524a61c28b 100644 --- a/drivers/net/ipa/ipa_power.h +++ b/drivers/net/ipa/ipa_power.h @@ -31,20 +31,6 @@ u32 ipa_core_clock_rate(struct ipa *ipa); */ void ipa_power_retention(struct ipa *ipa, bool enable); =20 -/** - * ipa_power_setup() - Set up IPA power management - * @ipa: IPA pointer - * - * Return: 0 if successful, or a negative error code - */ -int ipa_power_setup(struct ipa *ipa); - -/** - * ipa_power_teardown() - Inverse of ipa_power_setup() - * @ipa: IPA pointer - */ -void ipa_power_teardown(struct ipa *ipa); - /** * ipa_power_init() - Initialize IPA power management * @dev: IPA device --=20 2.40.1 From nobody Fri Feb 13 17:31:39 2026 Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46BD6130A44 for ; Fri, 19 Apr 2024 15:18:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713539891; cv=none; b=mO+knWxCi9Nk/ZFDH4Cr/VItrNuJ9952YiodkU3j/mP+agoqUfT98MUonxs4xiGBN15y5/2UhNbgI/eCNOZaVrGdkNSXN0WcV+cz1Iep9Qm0J3fdDixOu2gPKFhPIMKC0v5eaahzHiWewSPE0t05nm41TtUu522JbPvLy4JXpH0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713539891; c=relaxed/simple; bh=oB096HyNcXkj+8OW4Cvuw9utWZDB5OfhuhFopOEo+XU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=neTWPzQaNL1A4XN+49Qp4DT7Ydd5sIK0D2dm6EtaivQV591RFpz49+cvIqJSnQhQd589Y+83AQZL9Y1jYCmWtAGIw55TJA9FhYTQoi7jxkt6S4+2cW3V5Kyav81CPLRJ5moJ+vwm5Sw+rFNhcDIeH36Y+vtT2k7L9xOfHVtDb98= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=vcqrhD6B; arc=none smtp.client-ip=209.85.166.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vcqrhD6B" Received: by mail-io1-f52.google.com with SMTP id ca18e2360f4ac-7da42137c64so54018539f.1 for ; Fri, 19 Apr 2024 08:18:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713539888; x=1714144688; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KW+xodU0leEhVx50ESvAxH61dvrN0r6GXKBXbX3qcpk=; b=vcqrhD6BA9b8Mo1yqcCoBriSKlStkiODJW9Yv7YU5iOrVfSzs2+UgA8DAha7gNCTPG 9JQJIsnIZ4bDXO8tIfiZiR7hn6ZSFDgYAqxMzmli6KLgacE2kmysiPsmKxfMrWJTWZQz 0wWJViVjNclzFLS1DFEnwt0gHeZn3Vx0fXsGjfdpfCkSw+876bNI2XYZhgeGykFzv5ZM JV4vxpwQmbT2FQagAB2U0aDlEUm26ueB7vJXO4+suXwRP54OKUgd+mujj6/kLnmSJ01H hLx+1I7N7+w1+cRHDAeJMg676wgPCL+MqY1wW2VUjx1juskIVfrHx6pymiB422s8MwhB WMeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713539888; x=1714144688; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KW+xodU0leEhVx50ESvAxH61dvrN0r6GXKBXbX3qcpk=; b=Ln6QhDnK9YimfKwRHR/whnlR0V73cQ7UkA/EO4QNAXPOOjWWDOEmSUpmF/au9YCFtn Q/397ZE84XRIRmBKiG8uA/tUCoNXHRYR7D5nOwRO12isLHwJknyztx7SHQL/RLFF5hrj XbMlzaPdZC8qiESBMmFROLr52EGVW/GBcub1vmeXvPpasmD20yIlRe0d19les4OH+Oag CG1UGFYQW9ZLPNGPbI1ov0ujjtcrBlfmfri5bamoV2su5Vk6WT7vpGWMg7XDFPhkIb01 4NIvk3GBkJV4EvoqEqy3xWPOeLjpHiTrN0wWjgw8ScCiOELUK8vLnOP2HYATDkVvKjFx E4Hw== X-Forwarded-Encrypted: i=1; AJvYcCWdecJCcbAjvrjnagDe99TGI8ArFtG9446Z42nFKRtmL0ze33Ue+JZ24HpEUKvUM4GAO25UZUlsJXIzS6s5PMjcIJc0rkzi4ez1qNH7 X-Gm-Message-State: AOJu0YwyISZWKIDBg763Ix4/ac9+F2vvpns9lVpKjPrxxnUmxlTINRD4 1gjgGQ8wsnDVF+FpUmmOyy9fjnnWV1mPTseaEqCgYh8M5b1kppndY+jLIzxOfmc= X-Google-Smtp-Source: AGHT+IG+dQS0s8hDk+7SovzXn0ZCvGbkZQQZ2v0B2TFNw4W36id+MfFXUHuGZlHqxwI/1RglHK6trw== X-Received: by 2002:a5d:8995:0:b0:7d0:d84d:9e13 with SMTP id m21-20020a5d8995000000b007d0d84d9e13mr2743043iol.19.1713539888393; Fri, 19 Apr 2024 08:18:08 -0700 (PDT) Received: from localhost.localdomain (c-73-228-159-35.hsd1.mn.comcast.net. [73.228.159.35]) by smtp.gmail.com with ESMTPSA id lc8-20020a056638958800b00484e9c7014bsm116126jab.153.2024.04.19.08.18.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 08:18:08 -0700 (PDT) From: Alex Elder To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: mka@chromium.org, andersson@kernel.org, quic_cpratapa@quicinc.com, quic_avuyyuru@quicinc.com, quic_jponduru@quicinc.com, quic_subashab@quicinc.com, elder@kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 4/8] net: ipa: remove unneeded FILT_ROUT_HASH_EN definitions Date: Fri, 19 Apr 2024 10:17:56 -0500 Message-Id: <20240419151800.2168903-5-elder@linaro.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240419151800.2168903-1-elder@linaro.org> References: <20240419151800.2168903-1-elder@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The FILT_ROUT_HASH_EN register is only used for IPA v4.2. There, routing and filter table hashing are not supported, and so the register must be written to disable the feature. No other version uses this register, so its definition can be removed. If we need to use these some day (for example, explicitly enable the feature) this commit can be reverted. Signed-off-by: Alex Elder --- drivers/net/ipa/reg/ipa_reg-v3.1.c | 14 -------------- drivers/net/ipa/reg/ipa_reg-v3.5.1.c | 14 -------------- drivers/net/ipa/reg/ipa_reg-v4.11.c | 14 -------------- drivers/net/ipa/reg/ipa_reg-v4.5.c | 14 -------------- drivers/net/ipa/reg/ipa_reg-v4.7.c | 14 -------------- drivers/net/ipa/reg/ipa_reg-v4.9.c | 14 -------------- 6 files changed, 84 deletions(-) diff --git a/drivers/net/ipa/reg/ipa_reg-v3.1.c b/drivers/net/ipa/reg/ipa_r= eg-v3.1.c index 63a44dce88353..a891037015836 100644 --- a/drivers/net/ipa/reg/ipa_reg-v3.1.c +++ b/drivers/net/ipa/reg/ipa_reg-v3.1.c @@ -78,19 +78,6 @@ static const u32 reg_qsb_max_reads_fmask[] =3D { =20 REG_FIELDS(QSB_MAX_READS, qsb_max_reads, 0x00000078); =20 -static const u32 reg_filt_rout_hash_en_fmask[] =3D { - [IPV6_ROUTER_HASH] =3D BIT(0), - /* Bits 1-3 reserved */ - [IPV6_FILTER_HASH] =3D BIT(4), - /* Bits 5-7 reserved */ - [IPV4_ROUTER_HASH] =3D BIT(8), - /* Bits 9-11 reserved */ - [IPV4_FILTER_HASH] =3D BIT(12), - /* Bits 13-31 reserved */ -}; - -REG_FIELDS(FILT_ROUT_HASH_EN, filt_rout_hash_en, 0x000008c); - static const u32 reg_filt_rout_hash_flush_fmask[] =3D { [IPV6_ROUTER_HASH] =3D BIT(0), /* Bits 1-3 reserved */ @@ -405,7 +392,6 @@ static const struct reg *reg_array[] =3D { [SHARED_MEM_SIZE] =3D ®_shared_mem_size, [QSB_MAX_WRITES] =3D ®_qsb_max_writes, [QSB_MAX_READS] =3D ®_qsb_max_reads, - [FILT_ROUT_HASH_EN] =3D ®_filt_rout_hash_en, [FILT_ROUT_HASH_FLUSH] =3D ®_filt_rout_hash_flush, [STATE_AGGR_ACTIVE] =3D ®_state_aggr_active, [IPA_BCR] =3D ®_ipa_bcr, diff --git a/drivers/net/ipa/reg/ipa_reg-v3.5.1.c b/drivers/net/ipa/reg/ipa= _reg-v3.5.1.c index 4a7b6d92207de..c81c48ec51f90 100644 --- a/drivers/net/ipa/reg/ipa_reg-v3.5.1.c +++ b/drivers/net/ipa/reg/ipa_reg-v3.5.1.c @@ -83,19 +83,6 @@ static const u32 reg_qsb_max_reads_fmask[] =3D { =20 REG_FIELDS(QSB_MAX_READS, qsb_max_reads, 0x00000078); =20 -static const u32 reg_filt_rout_hash_en_fmask[] =3D { - [IPV6_ROUTER_HASH] =3D BIT(0), - /* Bits 1-3 reserved */ - [IPV6_FILTER_HASH] =3D BIT(4), - /* Bits 5-7 reserved */ - [IPV4_ROUTER_HASH] =3D BIT(8), - /* Bits 9-11 reserved */ - [IPV4_FILTER_HASH] =3D BIT(12), - /* Bits 13-31 reserved */ -}; - -REG_FIELDS(FILT_ROUT_HASH_EN, filt_rout_hash_en, 0x000008c); - static const u32 reg_filt_rout_hash_flush_fmask[] =3D { [IPV6_ROUTER_HASH] =3D BIT(0), /* Bits 1-3 reserved */ @@ -416,7 +403,6 @@ static const struct reg *reg_array[] =3D { [SHARED_MEM_SIZE] =3D ®_shared_mem_size, [QSB_MAX_WRITES] =3D ®_qsb_max_writes, [QSB_MAX_READS] =3D ®_qsb_max_reads, - [FILT_ROUT_HASH_EN] =3D ®_filt_rout_hash_en, [FILT_ROUT_HASH_FLUSH] =3D ®_filt_rout_hash_flush, [STATE_AGGR_ACTIVE] =3D ®_state_aggr_active, [IPA_BCR] =3D ®_ipa_bcr, diff --git a/drivers/net/ipa/reg/ipa_reg-v4.11.c b/drivers/net/ipa/reg/ipa_= reg-v4.11.c index 257eaff9436e5..18bddc32c9318 100644 --- a/drivers/net/ipa/reg/ipa_reg-v4.11.c +++ b/drivers/net/ipa/reg/ipa_reg-v4.11.c @@ -115,19 +115,6 @@ static const u32 reg_qsb_max_reads_fmask[] =3D { =20 REG_FIELDS(QSB_MAX_READS, qsb_max_reads, 0x00000078); =20 -static const u32 reg_filt_rout_hash_en_fmask[] =3D { - [IPV6_ROUTER_HASH] =3D BIT(0), - /* Bits 1-3 reserved */ - [IPV6_FILTER_HASH] =3D BIT(4), - /* Bits 5-7 reserved */ - [IPV4_ROUTER_HASH] =3D BIT(8), - /* Bits 9-11 reserved */ - [IPV4_FILTER_HASH] =3D BIT(12), - /* Bits 13-31 reserved */ -}; - -REG_FIELDS(FILT_ROUT_HASH_EN, filt_rout_hash_en, 0x0000148); - static const u32 reg_filt_rout_hash_flush_fmask[] =3D { [IPV6_ROUTER_HASH] =3D BIT(0), /* Bits 1-3 reserved */ @@ -472,7 +459,6 @@ static const struct reg *reg_array[] =3D { [SHARED_MEM_SIZE] =3D ®_shared_mem_size, [QSB_MAX_WRITES] =3D ®_qsb_max_writes, [QSB_MAX_READS] =3D ®_qsb_max_reads, - [FILT_ROUT_HASH_EN] =3D ®_filt_rout_hash_en, [FILT_ROUT_HASH_FLUSH] =3D ®_filt_rout_hash_flush, [STATE_AGGR_ACTIVE] =3D ®_state_aggr_active, [LOCAL_PKT_PROC_CNTXT] =3D ®_local_pkt_proc_cntxt, diff --git a/drivers/net/ipa/reg/ipa_reg-v4.5.c b/drivers/net/ipa/reg/ipa_r= eg-v4.5.c index dc396344d868a..8494731efdd3b 100644 --- a/drivers/net/ipa/reg/ipa_reg-v4.5.c +++ b/drivers/net/ipa/reg/ipa_reg-v4.5.c @@ -109,19 +109,6 @@ static const u32 reg_qsb_max_reads_fmask[] =3D { =20 REG_FIELDS(QSB_MAX_READS, qsb_max_reads, 0x00000078); =20 -static const u32 reg_filt_rout_hash_en_fmask[] =3D { - [IPV6_ROUTER_HASH] =3D BIT(0), - /* Bits 1-3 reserved */ - [IPV6_FILTER_HASH] =3D BIT(4), - /* Bits 5-7 reserved */ - [IPV4_ROUTER_HASH] =3D BIT(8), - /* Bits 9-11 reserved */ - [IPV4_FILTER_HASH] =3D BIT(12), - /* Bits 13-31 reserved */ -}; - -REG_FIELDS(FILT_ROUT_HASH_EN, filt_rout_hash_en, 0x0000148); - static const u32 reg_filt_rout_hash_flush_fmask[] =3D { [IPV6_ROUTER_HASH] =3D BIT(0), /* Bits 1-3 reserved */ @@ -491,7 +478,6 @@ static const struct reg *reg_array[] =3D { [SHARED_MEM_SIZE] =3D ®_shared_mem_size, [QSB_MAX_WRITES] =3D ®_qsb_max_writes, [QSB_MAX_READS] =3D ®_qsb_max_reads, - [FILT_ROUT_HASH_EN] =3D ®_filt_rout_hash_en, [FILT_ROUT_HASH_FLUSH] =3D ®_filt_rout_hash_flush, [STATE_AGGR_ACTIVE] =3D ®_state_aggr_active, [LOCAL_PKT_PROC_CNTXT] =3D ®_local_pkt_proc_cntxt, diff --git a/drivers/net/ipa/reg/ipa_reg-v4.7.c b/drivers/net/ipa/reg/ipa_r= eg-v4.7.c index 37a2e466e4755..2c161cf691935 100644 --- a/drivers/net/ipa/reg/ipa_reg-v4.7.c +++ b/drivers/net/ipa/reg/ipa_reg-v4.7.c @@ -109,19 +109,6 @@ static const u32 reg_qsb_max_reads_fmask[] =3D { =20 REG_FIELDS(QSB_MAX_READS, qsb_max_reads, 0x00000078); =20 -static const u32 reg_filt_rout_hash_en_fmask[] =3D { - [IPV6_ROUTER_HASH] =3D BIT(0), - /* Bits 1-3 reserved */ - [IPV6_FILTER_HASH] =3D BIT(4), - /* Bits 5-7 reserved */ - [IPV4_ROUTER_HASH] =3D BIT(8), - /* Bits 9-11 reserved */ - [IPV4_FILTER_HASH] =3D BIT(12), - /* Bits 13-31 reserved */ -}; - -REG_FIELDS(FILT_ROUT_HASH_EN, filt_rout_hash_en, 0x0000148); - static const u32 reg_filt_rout_hash_flush_fmask[] =3D { [IPV6_ROUTER_HASH] =3D BIT(0), /* Bits 1-3 reserved */ @@ -464,7 +451,6 @@ static const struct reg *reg_array[] =3D { [SHARED_MEM_SIZE] =3D ®_shared_mem_size, [QSB_MAX_WRITES] =3D ®_qsb_max_writes, [QSB_MAX_READS] =3D ®_qsb_max_reads, - [FILT_ROUT_HASH_EN] =3D ®_filt_rout_hash_en, [FILT_ROUT_HASH_FLUSH] =3D ®_filt_rout_hash_flush, [STATE_AGGR_ACTIVE] =3D ®_state_aggr_active, [LOCAL_PKT_PROC_CNTXT] =3D ®_local_pkt_proc_cntxt, diff --git a/drivers/net/ipa/reg/ipa_reg-v4.9.c b/drivers/net/ipa/reg/ipa_r= eg-v4.9.c index 09755d700784e..fa6fd312e4867 100644 --- a/drivers/net/ipa/reg/ipa_reg-v4.9.c +++ b/drivers/net/ipa/reg/ipa_reg-v4.9.c @@ -114,19 +114,6 @@ static const u32 reg_qsb_max_reads_fmask[] =3D { =20 REG_FIELDS(QSB_MAX_READS, qsb_max_reads, 0x00000078); =20 -static const u32 reg_filt_rout_hash_en_fmask[] =3D { - [IPV6_ROUTER_HASH] =3D BIT(0), - /* Bits 1-3 reserved */ - [IPV6_FILTER_HASH] =3D BIT(4), - /* Bits 5-7 reserved */ - [IPV4_ROUTER_HASH] =3D BIT(8), - /* Bits 9-11 reserved */ - [IPV4_FILTER_HASH] =3D BIT(12), - /* Bits 13-31 reserved */ -}; - -REG_FIELDS(FILT_ROUT_HASH_EN, filt_rout_hash_en, 0x0000148); - static const u32 reg_filt_rout_hash_flush_fmask[] =3D { [IPV6_ROUTER_HASH] =3D BIT(0), /* Bits 1-3 reserved */ @@ -469,7 +456,6 @@ static const struct reg *reg_array[] =3D { [SHARED_MEM_SIZE] =3D ®_shared_mem_size, [QSB_MAX_WRITES] =3D ®_qsb_max_writes, [QSB_MAX_READS] =3D ®_qsb_max_reads, - [FILT_ROUT_HASH_EN] =3D ®_filt_rout_hash_en, [FILT_ROUT_HASH_FLUSH] =3D ®_filt_rout_hash_flush, [STATE_AGGR_ACTIVE] =3D ®_state_aggr_active, [LOCAL_PKT_PROC_CNTXT] =3D ®_local_pkt_proc_cntxt, --=20 2.40.1 From nobody Fri Feb 13 17:31:39 2026 Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66F9D130AEE for ; Fri, 19 Apr 2024 15:18:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713539892; cv=none; b=jij1RRfo0VBG1XueXABuRcyU4ByY6GpVYmJrFbjTfo5/yaS7W0yOgSgqeuhP1Jsp10p8uS7nDFBLgHyblvkesSyBuxkMQ+VQ9K7Fq+sxDhx9I/uqLHm7JX6sk9zVsdaozE1Q93ECttTTx3J77topvJ3YEtF4GXdPZQTchZxIx4g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713539892; c=relaxed/simple; bh=mgG51iYBDDFdQeIEUv5d3iCvX4AlEHh4+4ja42oAgYE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZvE3Wl181O4wX98Wjw/93bfw+0wpIe4J5A/JaefoJ7MlRnzsBF29nFE24O0LxHkdPmSWH/VYVBfeD3t9leDxqAmLPJRhXbSDEmjW0h4s1FB579wTTyriLANrb9t24sQC/KjSbLCENYhCFlCboTeiOa4wGtL3ot2MqXn02rDWnP0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zm2w4PNo; arc=none smtp.client-ip=209.85.166.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zm2w4PNo" Received: by mail-io1-f47.google.com with SMTP id ca18e2360f4ac-7d9e2a5e097so71059139f.3 for ; Fri, 19 Apr 2024 08:18:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713539889; x=1714144689; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BfCN4tlBj+RpqK9tOiyo6f0tvsgy7nTKe81fkNY9Se8=; b=zm2w4PNooR42TiMCwEYKQTbZj8yz0Mc7TI2DTm+6HzdKP5CcQ2tO85RyJ7FxXC6g5a ZCcKfcJc+Oz8P2zuuxf3Fj7IEYzwoDMLeROw9dGUHr2HpVKH/P/vCi1R1CkqrwRldIoE lB33OXq2P2DYGeCZr2tpqqr9coyNY84J7WohWXTgFsH8gw7HvSpwPnBMYM3VcfaaHkuJ uQP2iFDNDtIb4/nAKl6yH3GGVoA+/TfV0fh1KginmlVCsyhX3DFaSOnInxnmYvoL0iRP 9gdaiaqyDkqiGXy9lNFSTq4VASSuKGkmo6i0rPuk6ulUs01bRB4582b9lVCLf93bXdLD 1CTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713539889; x=1714144689; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BfCN4tlBj+RpqK9tOiyo6f0tvsgy7nTKe81fkNY9Se8=; b=unyV++n27JHSavOudgGiiU2dsnqfh3Vt6esgsEG4Nm5dxVMcEzcUg9q0BSXJCkqkG3 2ibz4tKF23cQCyZ0iJM/h0vYJqeLw8OacKfbR1AG74gvTQlETmF0EzIvgtEURqwcoBoT yn7bqdC1L8oZP4gR8OBRlM0qXWNdww4ubLN/Ni9QTYSiyUiuJBDpUB50yZdQ/CgdgedX zko+oucaqGSsS5e3xlLNF6bLH2s5MsmYlFWXtxliszwGFo7/VkqgEIwo88/y3ig3OvZ1 risMGTm6uga9CSRSPTE2MgqAbNDz+nOH5sX0ERYm6oKasqkQcr/7HdLsoYr5jWzj8tJp AM9Q== X-Forwarded-Encrypted: i=1; AJvYcCXW7TPWTn7Jbljp1jpj1yOHC2Y8VKF8rVS7S2SMHlbBh6ivVxNs9869CbgUdlfHi78nQgsXUNvJfSpuBZc0YP7CwEn8kO4dIvgnruPA X-Gm-Message-State: AOJu0YwdvUSC0h9BN2qGNW4xrrJdVLvN2e8uj6aXW+DGWpc9n9+WHEJF Y8QKBA+T8x570sJEW7e6qVjvs60U32YnH8pMjN5Mir8KCyG9WFTioqDEolM7Ons= X-Google-Smtp-Source: AGHT+IFzvpR/FxtDaUoycVyCQ0DALrphK+JAM+rF9e/T3ecb+xze3a7ALLi+77hxZ7f3BlMDFxC8Rw== X-Received: by 2002:a5e:9910:0:b0:7d5:df5e:506 with SMTP id t16-20020a5e9910000000b007d5df5e0506mr2970977ioj.9.1713539889593; Fri, 19 Apr 2024 08:18:09 -0700 (PDT) Received: from localhost.localdomain (c-73-228-159-35.hsd1.mn.comcast.net. [73.228.159.35]) by smtp.gmail.com with ESMTPSA id lc8-20020a056638958800b00484e9c7014bsm116126jab.153.2024.04.19.08.18.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 08:18:09 -0700 (PDT) From: Alex Elder To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: mka@chromium.org, andersson@kernel.org, quic_cpratapa@quicinc.com, quic_avuyyuru@quicinc.com, quic_jponduru@quicinc.com, quic_subashab@quicinc.com, elder@kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 5/8] net: ipa: make ipa_table_hash_support() a real function Date: Fri, 19 Apr 2024 10:17:57 -0500 Message-Id: <20240419151800.2168903-6-elder@linaro.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240419151800.2168903-1-elder@linaro.org> References: <20240419151800.2168903-1-elder@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" With the exception of ipa_table_hash_support(), nothing defined in "ipa_table.h" requires the full definition of the IPA structure. Change that function to be a "real" function rather than an inline, to avoid requring the IPA structure to be defined. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_table.c | 8 +++++++- drivers/net/ipa/ipa_table.h | 7 ++----- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/net/ipa/ipa_table.c b/drivers/net/ipa/ipa_table.c index 45eb24be78a2e..4e4a3f8aa8e84 100644 --- a/drivers/net/ipa/ipa_table.c +++ b/drivers/net/ipa/ipa_table.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 =20 /* Copyright (c) 2012-2018, The Linux Foundation. All rights reserved. - * Copyright (C) 2018-2023 Linaro Ltd. + * Copyright (C) 2018-2024 Linaro Ltd. */ =20 #include @@ -158,6 +158,12 @@ ipa_table_mem(struct ipa *ipa, bool filter, bool hashe= d, bool ipv6) return ipa_mem_find(ipa, mem_id); } =20 +/* Return true if hashed tables are supported */ +bool ipa_table_hash_support(struct ipa *ipa) +{ + return ipa->version !=3D IPA_VERSION_4_2; +} + bool ipa_filtered_valid(struct ipa *ipa, u64 filtered) { struct device *dev =3D ipa->dev; diff --git a/drivers/net/ipa/ipa_table.h b/drivers/net/ipa/ipa_table.h index 7cc951904bb48..16d4d15df9e9c 100644 --- a/drivers/net/ipa/ipa_table.h +++ b/drivers/net/ipa/ipa_table.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0 */ =20 /* Copyright (c) 2012-2018, The Linux Foundation. All rights reserved. - * Copyright (C) 2019-2022 Linaro Ltd. + * Copyright (C) 2019-2024 Linaro Ltd. */ #ifndef _IPA_TABLE_H_ #define _IPA_TABLE_H_ @@ -23,10 +23,7 @@ bool ipa_filtered_valid(struct ipa *ipa, u64 filtered); * ipa_table_hash_support() - Return true if hashed tables are supported * @ipa: IPA pointer */ -static inline bool ipa_table_hash_support(struct ipa *ipa) -{ - return ipa->version !=3D IPA_VERSION_4_2; -} +bool ipa_table_hash_support(struct ipa *ipa); =20 /** * ipa_table_reset() - Reset filter and route tables entries to "none" --=20 2.40.1 From nobody Fri Feb 13 17:31:39 2026 Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F940131180 for ; Fri, 19 Apr 2024 15:18:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713539894; cv=none; b=Amq7ya3kLaLzYDx5UpPe500IA9kFoXxdoDOuhjktDbyVYPURnhROPgKKwP7i4JquugAPdA8c4/dei+Pwlqtb/uuIJ/61ewwPqEKCSUPFMqOb/C9/V+TAo6fS4nxQPAZdkOCZvHu4q3znRftJSV5xa2ihEjfkzRWAbTWb2oLPmMg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713539894; c=relaxed/simple; bh=erv4VXroO0M21slKGUyDFXCqBxmjZSFL8Sl5lqDo4rY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=AYv2qrgu2xWIrXiBDBCe1F+5YPv34CpYoPdjirArbNgW30coB9B493xbTQ8FbsXXFQk9AZBz8Rc1FiUBb6I6LuwTJHDVLunTAiWSCY3OuWzrIfjhf5khMKRXQbhW9dNWDebXVimzN77Tz8seoCBb+/Py/GVxAjfv/NXLzbemeTg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=kl1XPb4v; arc=none smtp.client-ip=209.85.166.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kl1XPb4v" Received: by mail-io1-f48.google.com with SMTP id ca18e2360f4ac-7da382f57a5so63518239f.1 for ; Fri, 19 Apr 2024 08:18:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713539891; x=1714144691; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lwnKPG2Aybimx/N3MD6w+czRD9+BNJvZbpMTIj3AUuA=; b=kl1XPb4vePOvoPx1YiVC+9UC8u+4l4xrn6Sx5P1ftQO0m5EEojo9VrGyRKIsEFgUvh 4JcPSsgto1PdAFu9Uh/Q+FBTLgkYj57op+6b6FnRKuah/uqrDBQL9AQJJ8SjX9M+P2i5 u2gXoCDixfRrjDCEei0VU1+D2Mmgdmy1bD5Am9qI2j9htoEvWTcmpbTiI14xoFoJ2suY DxJIYD1GI5I8/ODdJQJFfWo9WCu7gCijYqErXZ4nG/s3dmRVbCy1Jzw5ACoMpp6l7tfN rnU2yyd0ZbMU3kYygaETXuOr/HR5qfRdAmWQtEHCcSm+vFDPC1On3UpvnSl4wZv9Bevo sKZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713539891; x=1714144691; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lwnKPG2Aybimx/N3MD6w+czRD9+BNJvZbpMTIj3AUuA=; b=iOZfnEvRd0Mdjgw+mR4/1wzKQ8oYkoFdfE1BNfN31sjS8Im3z6Pw+tnKWI4LjIXZcm PracF0pTGsIl8g5XnHhq5w1XYTSQwnMtCdqAIvGZaCRSOjdrco7utb29vJq1tljNTJil q+SNx/my2KZX0Denb/pMhZ/sbl8Je0uLLPc8U1NqszzpQEBzvqSbx8QnGGXrD8CAEm8S bEjwRVRsr/QKk4DFiKmbq1X7NweNuTw8wUAQZwiagXbz7EAuwiGEzWWjyCcaa/YXEQDm j7Nx3kqZvrnWmec/WuDm8JeE/1lghSYCvJOsXVa8iibic87V3/QzpM2goLNcqYFlMy3M e3SA== X-Forwarded-Encrypted: i=1; AJvYcCUOeIQQszTD7cIYY36o0gRT+/Sp5R4/xfBL85KTcbxW01ANRM3uIDXDDX+JGATOAe/6X7p4Mo4jydwcdnYv9JCWWxQvB4gwveaArfHv X-Gm-Message-State: AOJu0Ywr1qp3IhP9yYuNSAsgJvEhh6nCHbP9m+CP7gUylEU3d7Mi1s0A I98FU9ShKp1qREDEhydvcRcvS6L0P0PiptaneqhW3pG/djTvFgQRbvT8JNPnyuw= X-Google-Smtp-Source: AGHT+IE9uu6ak6BSrNZjfqIaY8j4SEnqF00T+KY3FChxz87UgQ+A6nXOPiLVnowpl6k8ZRP6dhGsAQ== X-Received: by 2002:a6b:6c0e:0:b0:7d5:d60b:c425 with SMTP id a14-20020a6b6c0e000000b007d5d60bc425mr2679541ioh.19.1713539890773; Fri, 19 Apr 2024 08:18:10 -0700 (PDT) Received: from localhost.localdomain (c-73-228-159-35.hsd1.mn.comcast.net. [73.228.159.35]) by smtp.gmail.com with ESMTPSA id lc8-20020a056638958800b00484e9c7014bsm116126jab.153.2024.04.19.08.18.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 08:18:10 -0700 (PDT) From: Alex Elder To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: mka@chromium.org, andersson@kernel.org, quic_cpratapa@quicinc.com, quic_avuyyuru@quicinc.com, quic_jponduru@quicinc.com, quic_subashab@quicinc.com, elder@kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 6/8] net: ipa: fix two bogus argument names Date: Fri, 19 Apr 2024 10:17:58 -0500 Message-Id: <20240419151800.2168903-7-elder@linaro.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240419151800.2168903-1-elder@linaro.org> References: <20240419151800.2168903-1-elder@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In "ipa_endpoint.h", two function declarations have bogus argument names. Fix these. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_endpoint.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ipa/ipa_endpoint.h b/drivers/net/ipa/ipa_endpoint.h index 328b90dfd1695..e7d8ae6c6f6a6 100644 --- a/drivers/net/ipa/ipa_endpoint.h +++ b/drivers/net/ipa/ipa_endpoint.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0 */ =20 /* Copyright (c) 2012-2018, The Linux Foundation. All rights reserved. - * Copyright (C) 2019-2023 Linaro Ltd. + * Copyright (C) 2019-2024 Linaro Ltd. */ #ifndef _IPA_ENDPOINT_H_ #define _IPA_ENDPOINT_H_ @@ -199,9 +199,9 @@ int ipa_endpoint_init(struct ipa *ipa, u32 count, const struct ipa_gsi_endpoint_data *data); void ipa_endpoint_exit(struct ipa *ipa); =20 -void ipa_endpoint_trans_complete(struct ipa_endpoint *ipa, +void ipa_endpoint_trans_complete(struct ipa_endpoint *endpoint, struct gsi_trans *trans); -void ipa_endpoint_trans_release(struct ipa_endpoint *ipa, +void ipa_endpoint_trans_release(struct ipa_endpoint *endpoint, struct gsi_trans *trans); =20 #endif /* _IPA_ENDPOINT_H_ */ --=20 2.40.1 From nobody Fri Feb 13 17:31:39 2026 Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC24D131BCB for ; Fri, 19 Apr 2024 15:18:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713539894; cv=none; b=gROFAk959lANg6Kuww4S6Jz7Qi4f5Nhn29dYdTbygFktXPtpZS7A2gOd298KB/Xc9tWjI0RQGZ46zTKQQxcP1q6YUwFLup0PaLhNVyyeNfgitPQJyMmz9+DdIKP1KT3UuoIxh9SZ9g5GJJAd/aJe1Kk0s6ttlihER2j/DO8QuXg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713539894; c=relaxed/simple; bh=29UQTRms78NT9PmEmVPmwD7BlBFzDdceaYcGgV2Ra8M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CJVMsSH6Pt7t/lNwovpdtLafxTDadMTk3aODiC0+eMAXLTpUm6ZmOge6AGvsbCjSlw741ep8YxXP9/AXiQCV4UzHw6N3ASryzJ9x5jSHDVDMM3n+ubTDaIwduZ5jBaUYkfyoELNWUsKyRjR8uGU/X9DbLFeqXabAzh2R2Tk39d0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JY2mHB5c; arc=none smtp.client-ip=209.85.166.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JY2mHB5c" Received: by mail-io1-f54.google.com with SMTP id ca18e2360f4ac-7da42137c64so54020439f.1 for ; Fri, 19 Apr 2024 08:18:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713539892; x=1714144692; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RNVrYLH0wb76uVIxxR6dH2jv6p++X/8Jk5CCf1uTdzw=; b=JY2mHB5ceKbhrSDbuj1c+3GB1u3p/0i4hG7ILO46BaeJvwf8F63OVdNCvby5/s6Z2K 5mDIwS3AIlJkDhldG8cq1ugu/ADL+pMtuqTLHfUvDv0xkGZvRZCGFGXjcJ3bDjPL7g7a TFadgwnc2JidoRAmpr0KFV7NsLQe229vBYKXMdyFLSvjsj5oj0tiWDFTA9KMGmmJRqK3 4WganPDT0AI0Y+wSi2+nBbuBzksDfs3+oOZW7kENk0KaOmGPxpdkuScpJLko4je/hUAP xERZRC0zBM/PplXQhpmR5ucFTXl3xFO6DK3F5dDSeUTqpuVxi5EBizTCBLyCA2Hi23M1 OsUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713539892; x=1714144692; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RNVrYLH0wb76uVIxxR6dH2jv6p++X/8Jk5CCf1uTdzw=; b=qN1rWW9stqPDrMK5Qmbwn1mdnSG8c9aShR5q/QVSqlMRbSe78t1chxPEfLErupIC3C AekrX1lN0SyXZURMfqLQpEkmtJGCgV6gMJVEOIgq1hrhE48A6Q9IUClNcmev+zEha35t P/lYOXq9wFXzKVNG7qQH/J0R1zjRMH6Z7ZyY9OjkVr8N+oi3Dn+ZBXy3+vsVADNhcTEa KUAenXU18Ts/5DN7wVRdJP6f7UZhKkHMBHNe4HXXjedUZ+8ab+DSLtQQKkxN6r561EbB R6vcISIth4Ip1OwSBbeG2cVXCKJB49eJVMdbeMED9PKLW/gWBLl6FTH9Nn0YnSyb6oFg 82cg== X-Forwarded-Encrypted: i=1; AJvYcCWbPLBvq/0AKzTyEbdFY0du25YKawotkADjgEircAW7aLSD8Z+lMQqDjUMvviQy6NjTTY+rvg04fQogG4q5AQSdMtwmj0GSO2tL1fXS X-Gm-Message-State: AOJu0YxpOrvuxd0zIsJf4Au/LaKlqWNAW/Nk0Cswm6oTKuXLTiL2j2IM HBQCejXJgZKxTWgfvFlmhMExWa5H8PlHsalSqxb4Ck+uDCOKmNlCOMRUD6FS+yg= X-Google-Smtp-Source: AGHT+IFigKq8yuqDrNndjHBMbYyQIQ1Pnj1JL8I9PBudmiqEMtVw+in69/DdYxB8/vTe9aRyxy+MRg== X-Received: by 2002:a5d:8995:0:b0:7d0:d84d:9e13 with SMTP id m21-20020a5d8995000000b007d0d84d9e13mr2743219iol.19.1713539891870; Fri, 19 Apr 2024 08:18:11 -0700 (PDT) Received: from localhost.localdomain (c-73-228-159-35.hsd1.mn.comcast.net. [73.228.159.35]) by smtp.gmail.com with ESMTPSA id lc8-20020a056638958800b00484e9c7014bsm116126jab.153.2024.04.19.08.18.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 08:18:11 -0700 (PDT) From: Alex Elder To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: mka@chromium.org, andersson@kernel.org, quic_cpratapa@quicinc.com, quic_avuyyuru@quicinc.com, quic_jponduru@quicinc.com, quic_subashab@quicinc.com, elder@kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 7/8] net: ipa: fix two minor ipa_cmd problems Date: Fri, 19 Apr 2024 10:17:59 -0500 Message-Id: <20240419151800.2168903-8-elder@linaro.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240419151800.2168903-1-elder@linaro.org> References: <20240419151800.2168903-1-elder@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In "ipa_cmd.h", ipa_cmd_data_valid() is declared, but that function does not exist. So delete that declaration. Also, for some reason ipa_cmd_init() never gets called. It isn't really critical--it just validates that some memory offsets and a size can be represented in some register fields, and they won't fail with current data. Regardless, call the function in ipa_probe(). Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_cmd.h | 8 -------- drivers/net/ipa/ipa_main.c | 4 ++++ 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/ipa/ipa_cmd.h b/drivers/net/ipa/ipa_cmd.h index 5824bb131ebab..2077fdbade99c 100644 --- a/drivers/net/ipa/ipa_cmd.h +++ b/drivers/net/ipa/ipa_cmd.h @@ -53,14 +53,6 @@ enum ipa_cmd_opcode { bool ipa_cmd_table_init_valid(struct ipa *ipa, const struct ipa_mem *mem, bool route); =20 -/** - * ipa_cmd_data_valid() - Validate command-realted configuration is valid - * @ipa: - IPA pointer - * - * Return: true if assumptions required for command are valid - */ -bool ipa_cmd_data_valid(struct ipa *ipa); - /** * ipa_cmd_pool_init() - initialize command channel pools * @channel: AP->IPA command TX GSI channel pointer diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c index b13a59f27106d..6a0fec873cddf 100644 --- a/drivers/net/ipa/ipa_main.c +++ b/drivers/net/ipa/ipa_main.c @@ -865,6 +865,10 @@ static int ipa_probe(struct platform_device *pdev) if (ret) goto err_reg_exit; =20 + ret =3D ipa_cmd_init(ipa); + if (ret) + goto err_mem_exit; + ret =3D gsi_init(&ipa->gsi, pdev, ipa->version, data->endpoint_count, data->endpoint_data); if (ret) --=20 2.40.1 From nobody Fri Feb 13 17:31:39 2026 Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0EC81327E2 for ; Fri, 19 Apr 2024 15:18:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713539896; cv=none; b=SZTChiRm1iZHKD5hd/8DsyQEw6kjk4nDYammWgWVx6fKpFfLdrFpS22kIqqhzCF1vEbogarTWMwn0X+F/PBUYQfqjEI+NVloPvm4vIoB/Lgjct4eBXjUpjwd1n5RERP1Jz3awnT2HPlotmtoJD9Lm5p92tjaQsVifLkrRoX1MQw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713539896; c=relaxed/simple; bh=YisC0o7NBuOn0cgVONhypNsd+DSyG4nGqdGcgmtrUzg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=R6Gg0CCgXuDlsrjlOSltBSeFS5KGaajS3/zNT0mEjI7C1CU4S4GUoimaPlT2I/e2fTjz9LWYmASidqFVbvtBj6oNHJ7a3ysGb5hh9WVoi2foFcw6Hmx+M/euJlZ0BI7rTVEXfximUl7Qau9x8XFbJeznW7N42jSSslSUMd3sIrw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=eOZPd+Qg; arc=none smtp.client-ip=209.85.166.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eOZPd+Qg" Received: by mail-io1-f44.google.com with SMTP id ca18e2360f4ac-7da41c6aa37so59246939f.2 for ; Fri, 19 Apr 2024 08:18:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713539893; x=1714144693; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ki95sU34hn/iZbtQLEcQxjo1Z3fzAhmDa03BSf1KS14=; b=eOZPd+Qg1J/5Xy29wNO8G1/cwD83KSjW2rlMZWrxrQ9wZwqVkoGZdMV8YMv+jwgVMK Z+YVJCezkZFHwEro5l8ICB99ad9uyawFZas60BZoRn15K5okbzBL87yUdsr9ZFKAVoRd 5W8Jq8D3PXVkkoFMfGPmASwgzQyueXCapRDL+M3IvOE0xwW4HgRr7BRk59vU73Z9bF7c 2iWt7v5zysi+n55HFhLwThgt0vrQqQ1/fsJKRRgVtY7QvNzv5CE4JvdkfwmorGHN1WPQ BswRgxHdUpBA5hOpJWdE+DZcUPAvT7g8xQZumWu/UAvKg2qvRAbjEmf34G/QhkYoYC96 wJXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713539893; x=1714144693; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ki95sU34hn/iZbtQLEcQxjo1Z3fzAhmDa03BSf1KS14=; b=IGlO3bIZprHbs54m9i3JM7ymUX1/pQi7Cuna43mKpDU+ABOE0tUTnKKCMcPVL3Kn5J MyKPOnHIWikTh5mJgCsb/NK76YVHwkjEjUAy03/G+AdEjyFQpHe/YqjcjDHzsHjN3akZ gGdJU75RqoHzU/p51OuztTRXSPqAhjTTYnoNAA6Z8d7vJuZfGyOuuHWJMI7mkISThmY5 rihSxGn/RwznfEGZSZMlUqpeYl+Djb95WATBT/xRfG6N8Zt/FmjU6DxXekyL+JfFIFWc C3sM3Mwk8PacZR6NSZ4CTxAPa/Bfd0SPDH5CBf5w6iFstjD0GK6PVOhDfUnxM0Ngyw19 YeTA== X-Forwarded-Encrypted: i=1; AJvYcCXPUJXovGuOTuf8j6HQn6+zVjFt8rIIyjwXuMDwCrzVjzihBmChceHQupyhZlVdQsHNpPWZ2IvwlO7R4QojTnRDGaJRUQmF36F+Ag/u X-Gm-Message-State: AOJu0YzwqKbQ6hzvBuhXsHGHkYpAWyrkh9HAgB8JE2rMZsHmRKkzSc5S skFjLIIWGx59bhYRtGvOvYXifaY8uQlfTdpkA7Z7U7svJekmWaR7L9LWmX9RIMw= X-Google-Smtp-Source: AGHT+IELxfc7N5E6oEEqqJYaRLhd0NyK8sD8JOzWpxuh38rFalVcKuxOZJ5AihG+/A9vUu1KqCtQpw== X-Received: by 2002:a5e:8302:0:b0:7da:3757:8c3e with SMTP id x2-20020a5e8302000000b007da37578c3emr3384592iom.15.1713539893004; Fri, 19 Apr 2024 08:18:13 -0700 (PDT) Received: from localhost.localdomain (c-73-228-159-35.hsd1.mn.comcast.net. [73.228.159.35]) by smtp.gmail.com with ESMTPSA id lc8-20020a056638958800b00484e9c7014bsm116126jab.153.2024.04.19.08.18.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 08:18:12 -0700 (PDT) From: Alex Elder To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: mka@chromium.org, andersson@kernel.org, quic_cpratapa@quicinc.com, quic_avuyyuru@quicinc.com, quic_jponduru@quicinc.com, quic_subashab@quicinc.com, elder@kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 8/8] net: ipa: kill ipa_version_supported() Date: Fri, 19 Apr 2024 10:18:00 -0500 Message-Id: <20240419151800.2168903-9-elder@linaro.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240419151800.2168903-1-elder@linaro.org> References: <20240419151800.2168903-1-elder@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The only place ipa_version_supported() is called is in the probe function. The version comes from the match data. Rather than checking the version validity separately, just consider anything that has match data to be supported. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_main.c | 5 ----- drivers/net/ipa/ipa_version.h | 18 ------------------ 2 files changed, 23 deletions(-) diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c index 6a0fec873cddf..5f3dd5a2dcf46 100644 --- a/drivers/net/ipa/ipa_main.c +++ b/drivers/net/ipa/ipa_main.c @@ -810,11 +810,6 @@ static int ipa_probe(struct platform_device *pdev) return -ENODEV; } =20 - if (!ipa_version_supported(data->version)) { - dev_err(dev, "unsupported IPA version %u\n", data->version); - return -EINVAL; - } - if (!data->modem_route_count) { dev_err(dev, "modem_route_count cannot be zero\n"); return -EINVAL; diff --git a/drivers/net/ipa/ipa_version.h b/drivers/net/ipa/ipa_version.h index 156388e90a141..38c47f51a50c9 100644 --- a/drivers/net/ipa/ipa_version.h +++ b/drivers/net/ipa/ipa_version.h @@ -47,24 +47,6 @@ enum ipa_version { IPA_VERSION_COUNT, /* Last; not a version */ }; =20 -static inline bool ipa_version_supported(enum ipa_version version) -{ - switch (version) { - case IPA_VERSION_3_1: - case IPA_VERSION_3_5_1: - case IPA_VERSION_4_2: - case IPA_VERSION_4_5: - case IPA_VERSION_4_7: - case IPA_VERSION_4_9: - case IPA_VERSION_4_11: - case IPA_VERSION_5_0: - case IPA_VERSION_5_5: - return true; - default: - return false; - } -} - /* Execution environment IDs */ enum gsi_ee_id { GSI_EE_AP =3D 0x0, --=20 2.40.1