From nobody Fri Feb 13 19:27:39 2026 Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FE151A0AFA for ; Thu, 18 Apr 2024 20:47:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713473266; cv=none; b=AjaQxS93/Un/6CnoeJglriBpc4KIrUHxhZVXcLjqlRSnIDezvty/23uaDRqkXe6Ya5KS/oGzeuaOscVH+p8rInX0ghkHEiTDGfro2HbPFFHKlvGrIr6fCBKOhjafp+s3jm/SgJggf2i9thgNeCieMRKcj/h+WWTTIj5HDvFM1MU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713473266; c=relaxed/simple; bh=EM+PQeT/+Ayv+DqVTXJ6eeqpjOeHpKwRxGVuenJZOr8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PkQ88QCxOElPq3z/gURQTcBtAcDrd7Vib9aTXb1KkZkRprph/t36uNx8iKlCMQTo6gdWEy4QI5apRlt3+XbPxkLK0UvRH+LxnUQJ5WgP+Z5dVux+AeRYHfY2VxpRuOPMKXtv2jIVH6nLE0fXzhSvvhwtojRFdZl1sz5Q3ZcmO8w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=V7ImgRe7; arc=none smtp.client-ip=209.85.160.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="V7ImgRe7" Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-22edcfcd187so489434fac.2 for ; Thu, 18 Apr 2024 13:47:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713473264; x=1714078064; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NOsLWHf1aG7QjlwAYhzu9K+FfSOj8nw2eYMqyFikvmc=; b=V7ImgRe7jkpHOts93G+lm8ZfO9vtJki+bHJ0OYnS501S6N72QFl2VAqL0oZk92QG3q m02rMzaHK9lln9LRB+LTNpKjMZM8eEUfyD2J1i88LyKH7kHzLT25MnE9nQFjXSSa0nNA LZCG0xLUPXsSPUL7eoiKlZgCVixeEm3fhiN/bh+NLnpt4pdDafK0fLfYLL0RSWF9ZqPN Tt2ff0T86NtzDvaqQ3/zBxJpzMMar+O82fDKHWqoBt3Ak9Odhwa0bcnlHrzZSbNbBHWH WrtxPOv+FVFLhMoupMyksg6vgMYsANQq0WHtaV62EczENhL4tIsGr+Tu4JF1S1Hg7+ji dq9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713473264; x=1714078064; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NOsLWHf1aG7QjlwAYhzu9K+FfSOj8nw2eYMqyFikvmc=; b=oKT2QfRNKt5RYaM5vN8VQI7l5OTy89XTS2SErCim6t10YqxcAwYeCCkwv/A6EpH0u6 Xrn6TnK3ECF5wOkPoQ5eH0Sz4rIyIRia1J6QcayVpfWIhCee7qbbT2GQam42hfX9hvwI EwZq96iYeh0SoflzMnONILommPipMcNX18UIUvLshyLdFB/Q81pHiBL6z0QhVFehe5TV yJhxt4f16R1+o8QcbDvDI22kmtpeyhQK6//T1ybD3nPaUQvEaswKygAFenNe50xhw6Z4 tLH11IYZyFRXNeb/ztp+FPAlfcEe9GLMdsxLjq2qHDFdkoBhi0E6mexiMHU5oe4E2fc4 el0A== X-Forwarded-Encrypted: i=1; AJvYcCWdXCbLoo+ebHL1xF0JN6svURRZiKISmjcgbbABe6T1HqSqGm/EqBgj6bThlC3zUXT27X3IFjAZYwexfND7mJTykVSoJN3FxTA3zqn6 X-Gm-Message-State: AOJu0Yyp4FiYMlbFXSI1OSeN6er1YcK+KlBlHq74PFZurj4ZQIn2zQGr 3Qg/wS0Oq6RmvEqeulsbkS9+qH0tkQRbGL+Eq7sP/x1a2hJ/flhQ2ngAa6JlGsE= X-Google-Smtp-Source: AGHT+IHgblJ9h1CLqLo4U6C2hS5Ih8NHrIzQTKnvXZ8o0ZznahnKl3ojygI4TwopwZYSah+zGVzmBw== X-Received: by 2002:a05:6870:d886:b0:22e:e1e5:b8d with SMTP id oe6-20020a056870d88600b0022ee1e50b8dmr240440oac.51.1713473264566; Thu, 18 Apr 2024 13:47:44 -0700 (PDT) Received: from localhost.localdomain (c-73-228-159-35.hsd1.mn.comcast.net. [73.228.159.35]) by smtp.gmail.com with ESMTPSA id r6-20020a056638300600b00484948cb8f5sm626998jak.91.2024.04.18.13.47.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 13:47:44 -0700 (PDT) From: Alex Elder To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: mka@chromium.org, andersson@kernel.org, quic_cpratapa@quicinc.com, quic_avuyyuru@quicinc.com, quic_jponduru@quicinc.com, quic_subashab@quicinc.com, elder@kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 7/8] net: ipa: fix two minor ipa_cmd problems Date: Thu, 18 Apr 2024 15:47:28 -0500 Message-Id: <20240418204729.1952353-8-elder@linaro.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240418204729.1952353-1-elder@linaro.org> References: <20240418204729.1952353-1-elder@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In "ipa_cmd.h", ipa_cmd_data_valid() is declared, but that function does not exist. So delete that declaration. Also, for some reason ipa_cmd_init() never gets called. It isn't really critical--it just validates that some memory offsets and a size can be represented in some register fields, and they won't fail with current data. Regardless, call the function in ipa_probe(). Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_cmd.h | 8 -------- drivers/net/ipa/ipa_main.c | 4 ++++ 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/ipa/ipa_cmd.h b/drivers/net/ipa/ipa_cmd.h index e2cf1c2b0ef24..100a4e1133b5e 100644 --- a/drivers/net/ipa/ipa_cmd.h +++ b/drivers/net/ipa/ipa_cmd.h @@ -57,14 +57,6 @@ enum ipa_cmd_opcode { bool ipa_cmd_table_init_valid(struct ipa *ipa, const struct ipa_mem *mem, bool route); =20 -/** - * ipa_cmd_data_valid() - Validate command-realted configuration is valid - * @ipa: - IPA pointer - * - * Return: true if assumptions required for command are valid - */ -bool ipa_cmd_data_valid(struct ipa *ipa); - /** * ipa_cmd_pool_init() - initialize command channel pools * @channel: AP->IPA command TX GSI channel pointer diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c index 59e7abb4a0d19..04dc0540ff7fb 100644 --- a/drivers/net/ipa/ipa_main.c +++ b/drivers/net/ipa/ipa_main.c @@ -866,6 +866,10 @@ static int ipa_probe(struct platform_device *pdev) if (ret) goto err_reg_exit; =20 + ret =3D ipa_cmd_init(ipa); + if (ret) + goto err_mem_exit; + ret =3D gsi_init(&ipa->gsi, pdev, ipa->version, data->endpoint_count, data->endpoint_data); if (ret) --=20 2.40.1