From nobody Fri Feb 13 15:42:36 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35652155388; Thu, 18 Apr 2024 08:31:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713429109; cv=none; b=lF52zZlXsWpvWc4ZVGTwaFVfAqkzxSQTfIzje1c4cXW66jVxnmxB51RIRKZx/3AMouN1wsH9nMrUiKz2w2jqFpvf8beecVnN2LbyMdkCpUVEJ29vS7kwbZrgs6SiN8+/Ns/0Ng4whJtosTOLwJTSfxE9CRA6u1qgMrZF1CKja6k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713429109; c=relaxed/simple; bh=M3btJCCB5zygjQXZTT1q7MxcWhz/b3GtTsDQxAN7tpg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=QiAHNVK/E4oc0XYxaD9Dj0qEAmwt2ic0FNTlcEwnEcmPxqA0JX8WZYgBn5nVeEOCo+NN0XlVHJUT1pJTuYlnngBp/fiYvemyKIuw4ahclA0PFRNcVCjEfXJMiouv8WQ3z0ht3OwWOqtCWVBFVOH8iSEby1xvvko2xeBR/Jku+Po= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 1366cf88fd5e11ee9305a59a3cc225df-20240418 X-CID-O-RULE: Release_Ham X-CID-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.37,REQID:a0c11aa4-70a4-42d5-8230-bea924440967,IP:10, URL:0,TC:0,Content:-25,EDM:0,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACT ION:release,TS:-20 X-CID-INFO: VERSION:1.1.37,REQID:a0c11aa4-70a4-42d5-8230-bea924440967,IP:10,UR L:0,TC:0,Content:-25,EDM:0,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:-20 X-CID-META: VersionHash:6f543d0,CLOUDID:f91d5bae69d231735bc110360b603ea8,BulkI D:240418163140BSUDYQ6O,BulkQuantity:0,Recheck:0,SF:72|19|44|66|24|102,TC:n il,Content:0,EDM:-3,IP:-2,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,CO L:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CC_NO_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME HR_SJ_DIGIT_LEN, HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM HR_SJ_PHRASE, HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT HR_TO_NO_NAME, IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_EXISTED SN_UNTRUSTED, SN_UNFAMILIAR, SPF_NOPASS, DKIM_NOPASS, DMARC_NOPASS CIE_BAD, CIE_GOOD, CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO GTI_C_BU, AMN_T1, AMN_GOOD, AMN_C_TI, AMN_C_BU ABX_MISS_RDNS X-UUID: 1366cf88fd5e11ee9305a59a3cc225df-20240418 X-User: jiangyunshui@kylinos.cn Received: from kylin-pc.. [(112.64.161.44)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA) with ESMTP id 908215557; Thu, 18 Apr 2024 16:31:38 +0800 From: yunshui To: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Cc: corentin.chary@gmail.com, luke@ljones.dev, hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com, yunshui , Ai Chao Subject: [PATCH] platform/x86: asus-laptop: Use sysfs_emit() to replace sprintf() Date: Thu, 18 Apr 2024 16:31:36 +0800 Message-Id: <20240418083136.668869-1-jiangyunshui@kylinos.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As Documentation/filesystems/sysfs.rst suggested, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: yunshui Signed-off-by: Ai Chao --- drivers/platform/x86/asus-laptop.c | 44 +++++++++++++++--------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus= -laptop.c index 78c42767295a..2857aefc3d60 100644 --- a/drivers/platform/x86/asus-laptop.c +++ b/drivers/platform/x86/asus-laptop.c @@ -852,8 +852,8 @@ static ssize_t infos_show(struct device *dev, struct de= vice_attribute *attr, * so we don't set eof to 1 */ =20 - len +=3D sprintf(page, ASUS_LAPTOP_NAME " " ASUS_LAPTOP_VERSION "\n"); - len +=3D sprintf(page + len, "Model reference : %s\n", asus->name); + len +=3D sysfs_emit(page, ASUS_LAPTOP_NAME " " ASUS_LAPTOP_VERSION "\n"); + len +=3D sysfs_emit(page + len, "Model reference : %s\n", asus->name); /* * The SFUN method probably allows the original driver to get the list * of features supported by a given model. For now, 0x0100 or 0x0800 @@ -862,7 +862,7 @@ static ssize_t infos_show(struct device *dev, struct de= vice_attribute *attr, */ rv =3D acpi_evaluate_integer(asus->handle, "SFUN", NULL, &temp); if (ACPI_SUCCESS(rv)) - len +=3D sprintf(page + len, "SFUN value : %#x\n", + len +=3D sysfs_emit(page + len, "SFUN value : %#x\n", (uint) temp); /* * The HWRS method return informations about the hardware. @@ -874,7 +874,7 @@ static ssize_t infos_show(struct device *dev, struct de= vice_attribute *attr, */ rv =3D acpi_evaluate_integer(asus->handle, "HWRS", NULL, &temp); if (ACPI_SUCCESS(rv)) - len +=3D sprintf(page + len, "HWRS value : %#x\n", + len +=3D sysfs_emit(page + len, "HWRS value : %#x\n", (uint) temp); /* * Another value for userspace: the ASYM method returns 0x02 for @@ -885,25 +885,25 @@ static ssize_t infos_show(struct device *dev, struct = device_attribute *attr, */ rv =3D acpi_evaluate_integer(asus->handle, "ASYM", NULL, &temp); if (ACPI_SUCCESS(rv)) - len +=3D sprintf(page + len, "ASYM value : %#x\n", + len +=3D sysfs_emit(page + len, "ASYM value : %#x\n", (uint) temp); if (asus->dsdt_info) { snprintf(buf, 16, "%d", asus->dsdt_info->length); - len +=3D sprintf(page + len, "DSDT length : %s\n", buf); + len +=3D sysfs_emit(page + len, "DSDT length : %s\n", buf); snprintf(buf, 16, "%d", asus->dsdt_info->checksum); - len +=3D sprintf(page + len, "DSDT checksum : %s\n", buf); + len +=3D sysfs_emit(page + len, "DSDT checksum : %s\n", buf); snprintf(buf, 16, "%d", asus->dsdt_info->revision); - len +=3D sprintf(page + len, "DSDT revision : %s\n", buf); + len +=3D sysfs_emit(page + len, "DSDT revision : %s\n", buf); snprintf(buf, 7, "%s", asus->dsdt_info->oem_id); - len +=3D sprintf(page + len, "OEM id : %s\n", buf); + len +=3D sysfs_emit(page + len, "OEM id : %s\n", buf); snprintf(buf, 9, "%s", asus->dsdt_info->oem_table_id); - len +=3D sprintf(page + len, "OEM table id : %s\n", buf); + len +=3D sysfs_emit(page + len, "OEM table id : %s\n", buf); snprintf(buf, 16, "%x", asus->dsdt_info->oem_revision); - len +=3D sprintf(page + len, "OEM revision : 0x%s\n", buf); + len +=3D sysfs_emit(page + len, "OEM revision : 0x%s\n", buf); snprintf(buf, 5, "%s", asus->dsdt_info->asl_compiler_id); - len +=3D sprintf(page + len, "ASL comp vendor id : %s\n", buf); + len +=3D sysfs_emit(page + len, "ASL comp vendor id : %s\n", buf); snprintf(buf, 16, "%x", asus->dsdt_info->asl_compiler_revision); - len +=3D sprintf(page + len, "ASL comp revision : 0x%s\n", buf); + len +=3D sysfs_emit(page + len, "ASL comp revision : 0x%s\n", buf); } =20 return len; @@ -933,7 +933,7 @@ static ssize_t ledd_show(struct device *dev, struct dev= ice_attribute *attr, { struct asus_laptop *asus =3D dev_get_drvdata(dev); =20 - return sprintf(buf, "0x%08x\n", asus->ledd_status); + return sysfs_emit(buf, "0x%08x\n", asus->ledd_status); } =20 static ssize_t ledd_store(struct device *dev, struct device_attribute *att= r, @@ -993,7 +993,7 @@ static ssize_t wlan_show(struct device *dev, struct dev= ice_attribute *attr, { struct asus_laptop *asus =3D dev_get_drvdata(dev); =20 - return sprintf(buf, "%d\n", asus_wireless_status(asus, WL_RSTS)); + return sysfs_emit(buf, "%d\n", asus_wireless_status(asus, WL_RSTS)); } =20 static ssize_t wlan_store(struct device *dev, struct device_attribute *att= r, @@ -1022,7 +1022,7 @@ static ssize_t bluetooth_show(struct device *dev, str= uct device_attribute *attr, { struct asus_laptop *asus =3D dev_get_drvdata(dev); =20 - return sprintf(buf, "%d\n", asus_wireless_status(asus, BT_RSTS)); + return sysfs_emit(buf, "%d\n", asus_wireless_status(asus, BT_RSTS)); } =20 static ssize_t bluetooth_store(struct device *dev, @@ -1052,7 +1052,7 @@ static ssize_t wimax_show(struct device *dev, struct = device_attribute *attr, { struct asus_laptop *asus =3D dev_get_drvdata(dev); =20 - return sprintf(buf, "%d\n", asus_wireless_status(asus, WM_RSTS)); + return sysfs_emit(buf, "%d\n", asus_wireless_status(asus, WM_RSTS)); } =20 static ssize_t wimax_store(struct device *dev, struct device_attribute *at= tr, @@ -1081,7 +1081,7 @@ static ssize_t wwan_show(struct device *dev, struct d= evice_attribute *attr, { struct asus_laptop *asus =3D dev_get_drvdata(dev); =20 - return sprintf(buf, "%d\n", asus_wireless_status(asus, WW_RSTS)); + return sysfs_emit(buf, "%d\n", asus_wireless_status(asus, WW_RSTS)); } =20 static ssize_t wwan_store(struct device *dev, struct device_attribute *att= r, @@ -1151,7 +1151,7 @@ static ssize_t ls_switch_show(struct device *dev, str= uct device_attribute *attr, { struct asus_laptop *asus =3D dev_get_drvdata(dev); =20 - return sprintf(buf, "%d\n", asus->light_switch); + return sysfs_emit(buf, "%d\n", asus->light_switch); } =20 static ssize_t ls_switch_store(struct device *dev, @@ -1182,7 +1182,7 @@ static ssize_t ls_level_show(struct device *dev, stru= ct device_attribute *attr, { struct asus_laptop *asus =3D dev_get_drvdata(dev); =20 - return sprintf(buf, "%d\n", asus->light_level); + return sysfs_emit(buf, "%d\n", asus->light_level); } =20 static ssize_t ls_level_store(struct device *dev, struct device_attribute = *attr, @@ -1228,7 +1228,7 @@ static ssize_t ls_value_show(struct device *dev, stru= ct device_attribute *attr, if (!err) err =3D pega_int_read(asus, PEGA_READ_ALS_L, &lo); if (!err) - return sprintf(buf, "%d\n", 10 * hi + lo); + return sysfs_emit(buf, "%d\n", 10 * hi + lo); return err; } static DEVICE_ATTR_RO(ls_value); @@ -1264,7 +1264,7 @@ static ssize_t gps_show(struct device *dev, struct de= vice_attribute *attr, { struct asus_laptop *asus =3D dev_get_drvdata(dev); =20 - return sprintf(buf, "%d\n", asus_gps_status(asus)); + return sysfs_emit(buf, "%d\n", asus_gps_status(asus)); } =20 static ssize_t gps_store(struct device *dev, struct device_attribute *attr, --=20 2.34.1