From nobody Fri Feb 13 15:41:10 2026 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA14B23758 for ; Wed, 17 Apr 2024 19:15:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713381324; cv=none; b=EEd8h5Kn2Ja8MiY356SVEHbhHPkJBmpmKvin+nevkoR458Qu40Gh7bJJo2Zr9aIX6DsqHr3ROUykt+LLkpxbV/65BhhszTX22UcsIjdlusn969Vaq/GWShIyIaLDggPmeJaKE/5CnzNeUXKGcGWqBJYMK0y8DNMdFW3UIvWqzsw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713381324; c=relaxed/simple; bh=uI8tSqgzNQr2KV6CBwiC+zzrx9zKH+jxJVnlJoO9Zao=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=DX5HrE11Cb6+vJYBv3liMi7AqmzPmF/4DC9Sp84FwxEyqpyUmFAk7F3O39/YPdwfqPXe3utNQBMjSqptIKMFXRYy65mkaAhba0wb3RPxTWfMKGbiV8Dw0wJ1EoFvwxJ//F83pWntXdT6aJulWU6wsazV0AfPcl3NM/XgO4H+G7E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--cmllamas.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=kEXbZHfC; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--cmllamas.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kEXbZHfC" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-6f041e39bc7so196874b3a.1 for ; Wed, 17 Apr 2024 12:15:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1713381322; x=1713986122; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=yw0xNn0IGHj4PbZTLDlFMunyd5B02kMRO4eEUv/pl/M=; b=kEXbZHfCH6F29rWHamKyLmCvDghnNAajhN9huaYMs3Bm46ZHq6zRtVQ8A1YsC2GSap Omp+ti1qPuBT7z4lYm+hgXxTk4UIsL8sTfGl0Yuligni4vePa8QtLWSj2sPCvlYUZA+k PAw7wxoAebc/CgmgY1Pez/gz1vWvYjekN36zxEYf2tqFGZdLqrfi104k+D7s2CnNXSRX TkljiW8fRTY6T+f272Xb8UKKW3D5oH6zRJOuDC+1YD1EF7rwz3MggYy6XNKAnfq6nh6E gu7QNMrfKNYyJhQiHkM6nQlgXtQJvM2rLzsaM/LOeYjd9eTliY1LXaDS6ktXzWTRldhG b2Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713381322; x=1713986122; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=yw0xNn0IGHj4PbZTLDlFMunyd5B02kMRO4eEUv/pl/M=; b=wB9+A3swjsPXBoVdHNrstH+gapYPKZ8uv9SqC7F32jMAzLN08Q2AhKNzS6sGB9nHMp qwbrVu+QmdufHmRT6V9PT3OQ+UhWo0R+SRIY3N52/TgYtYxk21xYA5zaBjPknEIOg4K/ wLMYghG2r5ncIIp0HjbRLlVJhPUz822gMhuojSmODqZsXJaAtQAqK5BHTgwbLVF+/S8l 81DT/si7kTVpQ5UQlQKA1k/N2UG1nqggfS4PQYA1TEK/pPlN8AFLJzqYKeXplcR/IbFI sxBhGBHiFVpHS0WznY6Zh8BinlYehuKzuI3Xs8pcPHAEeIwuNywaQOYM5o+20Jutvycw 0HEg== X-Gm-Message-State: AOJu0Ywb/5rHJ5PKxWuscIj26x2DzjZLVfuL8NW6mjnN8X4fxTOr87Sj GKo8ESur9TWTczKsYOqEimOZNh+1IeokqSf1xvBljXELNlTCrMWgmMB+8uDqF6Ahl2nXzfiV+11 IkE/fBrvkcA== X-Google-Smtp-Source: AGHT+IH38TtfKM2Mr8apHkGPxGYU2dAh7XueTrQaf5Unr5eg1HhWygxnsjTkNpU67yyve2aPRl/L3z7Y3tlbcw== X-Received: from xllamas.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5070]) (user=cmllamas job=sendgmr) by 2002:a05:6a00:98f:b0:6ed:344:9faa with SMTP id u15-20020a056a00098f00b006ed03449faamr51828pfg.1.1713381321996; Wed, 17 Apr 2024 12:15:21 -0700 (PDT) Date: Wed, 17 Apr 2024 19:13:44 +0000 In-Reply-To: <20240417191418.1341988-1-cmllamas@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240417191418.1341988-1-cmllamas@google.com> X-Mailer: git-send-email 2.44.0.683.g7961c838ac-goog Message-ID: <20240417191418.1341988-5-cmllamas@google.com> Subject: [PATCH 4/4] binder: fix max_thread type inconsistency From: Carlos Llamas To: Greg Kroah-Hartman , "=?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?=" , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Carlos Llamas , Suren Baghdasaryan , Serban Constantinescu Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, Alice Ryhl , stable@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The type defined for the BINDER_SET_MAX_THREADS ioctl was changed from size_t to __u32 in order to avoid incompatibility issues between 32 and 64-bit kernels. However, the internal types used to copy from user and store the value were never updated. Use u32 to fix the inconsistency. Fixes: a9350fc859ae ("staging: android: binder: fix BINDER_SET_MAX_THREADS = declaration") Reported-by: Arve Hj=C3=B8nnev=C3=A5g Cc: stable@vger.kernel.org Signed-off-by: Carlos Llamas --- drivers/android/binder.c | 2 +- drivers/android/binder_internal.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/android/binder.c b/drivers/android/binder.c index f120a24c9ae6..2596cbfa16d0 100644 --- a/drivers/android/binder.c +++ b/drivers/android/binder.c @@ -5408,7 +5408,7 @@ static long binder_ioctl(struct file *filp, unsigned = int cmd, unsigned long arg) goto err; break; case BINDER_SET_MAX_THREADS: { - int max_threads; + u32 max_threads; =20 if (copy_from_user(&max_threads, ubuf, sizeof(max_threads))) { diff --git a/drivers/android/binder_internal.h b/drivers/android/binder_int= ernal.h index 221ab7a6384a..3c522698083f 100644 --- a/drivers/android/binder_internal.h +++ b/drivers/android/binder_internal.h @@ -426,7 +426,7 @@ struct binder_proc { struct list_head todo; struct binder_stats stats; struct list_head delivered_death; - int max_threads; + u32 max_threads; int requested_threads; int requested_threads_started; int tmp_ref; --=20 2.44.0.683.g7961c838ac-goog