From nobody Fri Feb 13 14:11:10 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B3181487F7; Wed, 17 Apr 2024 17:01:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713373273; cv=none; b=ay0mt+0zYbtCmMp4M4F2YV7TBYQ88Bh6XtzmDxI3LoOSVE4ItZoFbGovRCnmK4HesVv6dAgo3IkA4n8f3gIsFHTAoX0E9J/4zj9WwUVV8zGmm2yTIU7pxxn3LPl9skTS0B6DMt9I1xrXeqwVHh6x3vL4auZ/Ti44wm/XSuNjD+A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713373273; c=relaxed/simple; bh=Fnq/TM5nqxh6n4xvyFsAt9TORsJQjjD4YNC+GMRMdPg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=EqTB2KWJMD8O02Gc3epjUXi/+45xHAHk80M1ORTjZFyqjMDx1sslJ6qWTJwxSi/o5qYnd1KNUawG9YIy4Vg/bMP4LMy4eHjcQEV6KWNR22mX7G9aJgt5beDQ6Gj3fsYDOWta2MjEyr5Ds3b0CrQGpyNLCeFxqeKVC3nKaSuDTU4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b8wXOVlD; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b8wXOVlD" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-418c2bf2f15so5282545e9.3; Wed, 17 Apr 2024 10:01:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713373268; x=1713978068; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dykPh5RAPxYJdWFmBmCaPuYTC+omHF64St3jDBsho9o=; b=b8wXOVlDEpylL2kjabn2Ypy+kfRmW1bsv2OClOURcWIPVSsX9xHGtoROC0JiPnUtob M5dMufUwiJ5d+LC38PECbuGCddDxio1hv4+nBbDFGtqYCAfpzS36l23i+CtIK/4ltgbX CrSZKD82oPT8cZ6ox/dhlD0i/dk/ks7rG/W7HQaok8+5S8WKq6Su4uekNFA3b1tAgeHI IsehunymSR8+ex25sTyNhz74iLd4s/2pkqrtL1X6sj5sNI/9wSCSXHoCvorzuM3yeb3H +rXQq/iL0pNiHHxdCZP8r99wAlF7Qmep/6D+go2XuJWt9uztqBNxUuWOHIsytVdQGu0L UeuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713373268; x=1713978068; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dykPh5RAPxYJdWFmBmCaPuYTC+omHF64St3jDBsho9o=; b=NvBPiGlf5dRDkuCF8Zaakl3EZSJlC9cJ/lO0BrIxExeSedanr2zDnO5dZBETUf4qxx 068RbpxE9k46yPB/gUYJQrRpor8i1zS6XHkLNdYqgYslLDpLrUN/kUZ7A1g805s46uol 5BDlpcZlUATGxqH8SlccqRGhrK8hCXuDEnbQEFL2+uY4uZn+gjiWygRgs2As8fdrMxAO jwh8kyHX2HaBXkDB753CA12hlB10ulxUz9//nVt18mppQgdCuRQIHT6lXcd6hj4AHeCL kB2DxUPfIom9iP6yWtY9ogffqLE7vCWKM23T9Hss4d5HC4sTTWpF1/c/8ZXhKZToYRQk m0CA== X-Forwarded-Encrypted: i=1; AJvYcCVFdCqRBRrrWnwf9ESudwepIo7TkLBvCo0zYLxo98fYceJsMk8w+xiyy53Vl3rFwMhcNtfB9vCRXuZ8gE94U1l20o8SuXkY+LXfVXWfnSkdAUSThXVuE1RLs7EG81aFVpjlctgm4HVCdrUnr3r5OX2Me8gJemnXhiCGAcBPCEVvM4KqHw== X-Gm-Message-State: AOJu0YyKboB0KgVhLScabdFuD46oPKtVWdwYH/mtKCxcs99Ge0zJJrXi qSfQiE+6Lmd4HgQmOwTw4N7zNVDeotICzK/5NF3nfmu8cwjqS7NN X-Google-Smtp-Source: AGHT+IHO3P7G2ACgRgHRWuPR2N7doNp8zWEKcCg2aPHO3ocLIJTd+T1tQkqgT2neR0+ux3KUa1ErbA== X-Received: by 2002:a05:600c:458d:b0:418:2a04:d8cb with SMTP id r13-20020a05600c458d00b004182a04d8cbmr144543wmo.14.1713373268328; Wed, 17 Apr 2024 10:01:08 -0700 (PDT) Received: from spiri.. ([86.124.122.31]) by smtp.gmail.com with ESMTPSA id g2-20020adff3c2000000b00343300a4eb8sm17949441wrp.49.2024.04.17.10.01.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 10:01:08 -0700 (PDT) From: Alisa-Dariana Roman X-Google-Original-From: Alisa-Dariana Roman To: michael.hennerich@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: alexandru.tachici@analog.com, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, andy@kernel.org, nuno.sa@analog.com, marcelo.schmitt@analog.com, bigunclemax@gmail.com, dlechner@baylibre.com, okan.sahin@analog.com, fr0st61te@gmail.com, alisa.roman@analog.com, marcus.folkesson@gmail.com, schnelle@linux.ibm.com, liambeguin@gmail.com Subject: [PATCH v6 1/5] iio: adc: ad7192: Use standard attribute Date: Wed, 17 Apr 2024 20:00:50 +0300 Message-Id: <20240417170054.140587-2-alisa.roman@analog.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240417170054.140587-1-alisa.roman@analog.com> References: <20240417170054.140587-1-alisa.roman@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace custom attribute filter_low_pass_3db_frequency_available with standard attribute. Store the available values in ad7192_state struct. The function that used to compute those values replaced by ad7192_update_filter_freq_avail(). Function ad7192_show_filter_avail() is no longer needed. Note that the initial available values are hardcoded. Signed-off-by: Alisa-Dariana Roman Reviewed-by: David Lechner --- drivers/iio/adc/ad7192.c | 67 ++++++++++++++++++---------------------- 1 file changed, 30 insertions(+), 37 deletions(-) diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c index 7bcc7e2aa2a2..fe8dbb68a8ba 100644 --- a/drivers/iio/adc/ad7192.c +++ b/drivers/iio/adc/ad7192.c @@ -190,6 +190,7 @@ struct ad7192_state { u32 mode; u32 conf; u32 scale_avail[8][2]; + u32 filter_freq_avail[4][2]; u32 oversampling_ratio_avail[4]; u8 gpocon; u8 clock_sel; @@ -473,6 +474,16 @@ static int ad7192_setup(struct iio_dev *indio_dev, str= uct device *dev) st->oversampling_ratio_avail[2] =3D 8; st->oversampling_ratio_avail[3] =3D 16; =20 + st->filter_freq_avail[0][0] =3D 600; + st->filter_freq_avail[1][0] =3D 800; + st->filter_freq_avail[2][0] =3D 2300; + st->filter_freq_avail[3][0] =3D 2720; + + st->filter_freq_avail[0][1] =3D 1000; + st->filter_freq_avail[1][1] =3D 1000; + st->filter_freq_avail[2][1] =3D 1000; + st->filter_freq_avail[3][1] =3D 1000; + return 0; } =20 @@ -586,48 +597,24 @@ static int ad7192_get_f_adc(struct ad7192_state *st) f_order * FIELD_GET(AD7192_MODE_RATE_MASK, st->mode)); } =20 -static void ad7192_get_available_filter_freq(struct ad7192_state *st, - int *freq) +static void ad7192_update_filter_freq_avail(struct ad7192_state *st) { unsigned int fadc; =20 /* Formulas for filter at page 25 of the datasheet */ fadc =3D ad7192_compute_f_adc(st, false, true); - freq[0] =3D DIV_ROUND_CLOSEST(fadc * 240, 1024); + st->filter_freq_avail[0][0] =3D DIV_ROUND_CLOSEST(fadc * 240, 1024); =20 fadc =3D ad7192_compute_f_adc(st, true, true); - freq[1] =3D DIV_ROUND_CLOSEST(fadc * 240, 1024); + st->filter_freq_avail[1][0] =3D DIV_ROUND_CLOSEST(fadc * 240, 1024); =20 fadc =3D ad7192_compute_f_adc(st, false, false); - freq[2] =3D DIV_ROUND_CLOSEST(fadc * 230, 1024); + st->filter_freq_avail[2][0] =3D DIV_ROUND_CLOSEST(fadc * 230, 1024); =20 fadc =3D ad7192_compute_f_adc(st, true, false); - freq[3] =3D DIV_ROUND_CLOSEST(fadc * 272, 1024); + st->filter_freq_avail[3][0] =3D DIV_ROUND_CLOSEST(fadc * 272, 1024); } =20 -static ssize_t ad7192_show_filter_avail(struct device *dev, - struct device_attribute *attr, - char *buf) -{ - struct iio_dev *indio_dev =3D dev_to_iio_dev(dev); - struct ad7192_state *st =3D iio_priv(indio_dev); - unsigned int freq_avail[4], i; - size_t len =3D 0; - - ad7192_get_available_filter_freq(st, freq_avail); - - for (i =3D 0; i < ARRAY_SIZE(freq_avail); i++) - len +=3D sysfs_emit_at(buf, len, "%d.%03d ", freq_avail[i] / 1000, - freq_avail[i] % 1000); - - buf[len - 1] =3D '\n'; - - return len; -} - -static IIO_DEVICE_ATTR(filter_low_pass_3db_frequency_available, - 0444, ad7192_show_filter_avail, NULL, 0); - static IIO_DEVICE_ATTR(bridge_switch_en, 0644, ad7192_show_bridge_switch, ad7192_set, AD7192_REG_GPOCON); @@ -637,7 +624,6 @@ static IIO_DEVICE_ATTR(ac_excitation_en, 0644, AD7192_REG_CONF); =20 static struct attribute *ad7192_attributes[] =3D { - &iio_dev_attr_filter_low_pass_3db_frequency_available.dev_attr.attr, &iio_dev_attr_bridge_switch_en.dev_attr.attr, NULL }; @@ -647,7 +633,6 @@ static const struct attribute_group ad7192_attribute_gr= oup =3D { }; =20 static struct attribute *ad7195_attributes[] =3D { - &iio_dev_attr_filter_low_pass_3db_frequency_available.dev_attr.attr, &iio_dev_attr_bridge_switch_en.dev_attr.attr, &iio_dev_attr_ac_excitation_en.dev_attr.attr, NULL @@ -665,17 +650,15 @@ static unsigned int ad7192_get_temp_scale(bool unipol= ar) static int ad7192_set_3db_filter_freq(struct ad7192_state *st, int val, int val2) { - int freq_avail[4], i, ret, freq; + int i, ret, freq; unsigned int diff_new, diff_old; int idx =3D 0; =20 diff_old =3D U32_MAX; freq =3D val * 1000 + val2; =20 - ad7192_get_available_filter_freq(st, freq_avail); - - for (i =3D 0; i < ARRAY_SIZE(freq_avail); i++) { - diff_new =3D abs(freq - freq_avail[i]); + for (i =3D 0; i < ARRAY_SIZE(st->filter_freq_avail); i++) { + diff_new =3D abs(freq - st->filter_freq_avail[i][0]); if (diff_new < diff_old) { diff_old =3D diff_new; idx =3D i; @@ -826,6 +809,7 @@ static int ad7192_write_raw(struct iio_dev *indio_dev, st->mode &=3D ~AD7192_MODE_RATE_MASK; st->mode |=3D FIELD_PREP(AD7192_MODE_RATE_MASK, div); ad_sd_write_reg(&st->sd, AD7192_REG_MODE, 3, st->mode); + ad7192_update_filter_freq_avail(st); break; case IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY: ret =3D ad7192_set_3db_filter_freq(st, val, val2 / 1000); @@ -845,6 +829,7 @@ static int ad7192_write_raw(struct iio_dev *indio_dev, 3, st->mode); break; } + ad7192_update_filter_freq_avail(st); mutex_unlock(&st->lock); break; default: @@ -888,6 +873,12 @@ static int ad7192_read_avail(struct iio_dev *indio_dev, /* Values are stored in a 2D matrix */ *length =3D ARRAY_SIZE(st->scale_avail) * 2; =20 + return IIO_AVAIL_LIST; + case IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY: + *vals =3D (int *)st->filter_freq_avail; + *type =3D IIO_VAL_FRACTIONAL; + *length =3D ARRAY_SIZE(st->filter_freq_avail) * 2; + return IIO_AVAIL_LIST; case IIO_CHAN_INFO_OVERSAMPLING_RATIO: *vals =3D (int *)st->oversampling_ratio_avail; @@ -956,7 +947,9 @@ static const struct iio_info ad7195_info =3D { BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY) | \ (_mask_all), \ .info_mask_shared_by_type_available =3D (_mask_type_av), \ - .info_mask_shared_by_all_available =3D (_mask_all_av), \ + .info_mask_shared_by_all_available =3D \ + BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY) | \ + (_mask_all_av), \ .ext_info =3D (_ext_info), \ .scan_index =3D (_si), \ .scan_type =3D { \ --=20 2.34.1 From nobody Fri Feb 13 14:11:10 2026 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B62F317332C; Wed, 17 Apr 2024 17:01:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713373278; cv=none; b=hiYg5izfPSSk3KRo6CwFVn+PYddaFridIdwXdYC1PQ+4E9Kh27Ipw3rvqL99Ci2yUTeMuLHQCnajLGSwLQLyrm6Z/SFoSnZa/gPo2rRTzY4wWZdij7qgD29yfPCVO6gAWbxXc70hPjON+Nso/wPNYvUeaS//xcji6TiV1346Crc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713373278; c=relaxed/simple; bh=TOyZKbeCGpd5qK8JqBhxEudXpI8VIDThjxkgR3KBD4Q=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LtfekLQAd3iZ6LUyxzGnAY7+qGU3sSOPRUtzE5t6nRb3gMJzrYj+jEc5F86VonEEjGJqp8bMQ0WEb35Hs0rNsX9R6bZ3m8Jz3TTfoK03mIT3jdXW5lsXjCyBUQd1H08lPvuwYUFVvaK5o2PyG9j+DUWEmqiDLKFQHYtWViJsd7k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H+FTHk9m; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H+FTHk9m" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2d8b2389e73so67940761fa.3; Wed, 17 Apr 2024 10:01:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713373273; x=1713978073; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xCV+1nW68JSPi8LOst0Jr3R20tY+mLN4dqQafn+72gs=; b=H+FTHk9mWZoLDsfEssNGl06FYQ2XkcZqFaQM5A1uxNnWN8I3xVs98YJFoz63yA8rNY 8yWAVaTNJzrE0YLZKgNA9ROJwi2sUvb4ptZaTlu5cWRP1uub41Bdu00D4hpogHwMCAQQ R7hPXZha4MNX7UgzMOjd4pLuHY3weDBn0blMQsxTrCtkxraBPkajByVbgVHtqHOx9fv8 A+UUAVikaUjbM++Df85y0LPeDan41MDz1gvjFjbF9l65VVh/Uss2oJUFXfnzjkPoyJuv 5l5QKXel+f90p16iMjxRGvEQxtTqrrEed+L5qv3rk7OCPzkytZZDOpYuxEbKtqQS/1eD PRHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713373273; x=1713978073; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xCV+1nW68JSPi8LOst0Jr3R20tY+mLN4dqQafn+72gs=; b=YoqFlLwod7285DKhCOe1CSB/c+NTlk0Flr7+6h4c0qIq3V0oAhIhNOfd2YD65NcclG iQIFIuAGK+equDtPEWv3aXEGNkiQ+jxSzhPzyUH+r06wrXSUsShbuDjdhFSgOyiGfqDF MgmFgMMFw0Qda48Kk6WkH6Gd3JgZwnpLfKSIRpbw74cI9hhYV23xwZYZSePPaU/Cm61G VlhRCccSWYWYNr4xe3mmhthMYX4VeRZGemE6Rb3GB9b+yjn8iNfivCPBlgqyHkpldris fEAm6p9DhpCul86bgGHjgMCBKtWMtme9YbLlZsSTG/LwnkfC7Qsdu+WvYS/WlW6mOeTk D2Qg== X-Forwarded-Encrypted: i=1; AJvYcCXgVWfawCgZ18b+RpGCwyUHw2uN2KxvHj7UmeHOLEyjCyMAjE3Cgp6d2ZQ5kx4YcYhWPJoIf8t4PWDdzyv6Wrm2KU25MxFLqGA7Iy5fN2Om2tlNVNgxoZu/9tCgtM9isxkI8J8VpEM2joP5l1KYqPadS11dUAmQdCfXgJgYyGWP9Rd8qw== X-Gm-Message-State: AOJu0YzEFNyRP9/bELokILPHUMkmlolF4MuB5xVwaBcODKGfN+1MnsDE BKHkpvUOltqbSaE9u7Dl6SOlUkW0KogLfJzBkXroN2wjawCIEhoc X-Google-Smtp-Source: AGHT+IFwgCFu/sSAPuv3xp3yaJ0ULBnAv7pNb9bLlOcEAccJrbHBak4G6ZwupLNX81w0GOcglWvZ3Q== X-Received: by 2002:a2e:8046:0:b0:2d8:658e:7e9f with SMTP id p6-20020a2e8046000000b002d8658e7e9fmr10318053ljg.39.1713373272538; Wed, 17 Apr 2024 10:01:12 -0700 (PDT) Received: from spiri.. ([86.124.122.31]) by smtp.gmail.com with ESMTPSA id g2-20020adff3c2000000b00343300a4eb8sm17949441wrp.49.2024.04.17.10.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 10:01:12 -0700 (PDT) From: Alisa-Dariana Roman X-Google-Original-From: Alisa-Dariana Roman To: michael.hennerich@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: alexandru.tachici@analog.com, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, andy@kernel.org, nuno.sa@analog.com, marcelo.schmitt@analog.com, bigunclemax@gmail.com, dlechner@baylibre.com, okan.sahin@analog.com, fr0st61te@gmail.com, alisa.roman@analog.com, marcus.folkesson@gmail.com, schnelle@linux.ibm.com, liambeguin@gmail.com Subject: [PATCH v6 2/5] dt-bindings: iio: adc: ad7192: Add aincom supply Date: Wed, 17 Apr 2024 20:00:51 +0300 Message-Id: <20240417170054.140587-3-alisa.roman@analog.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240417170054.140587-1-alisa.roman@analog.com> References: <20240417170054.140587-1-alisa.roman@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" AINCOM should actually be a supply. AINx inputs are referenced to AINCOM in pseduo-differential operation mode. AINCOM voltage represets the offset of corresponding channels. Signed-off-by: Alisa-Dariana Roman Reviewed-by: Rob Herring (Arm) --- Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml b/Do= cumentation/devicetree/bindings/iio/adc/adi,ad7192.yaml index 16def2985ab4..cf5c568f140a 100644 --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml @@ -41,6 +41,11 @@ properties: interrupts: maxItems: 1 =20 + aincom-supply: + description: | + AINCOM voltage supply. Analog inputs AINx are referenced to this inp= ut + when configured for pseudo-differential operation. + dvdd-supply: description: DVdd voltage supply =20 @@ -117,6 +122,7 @@ examples: clock-names =3D "mclk"; interrupts =3D <25 0x2>; interrupt-parent =3D <&gpio>; + aincom-supply =3D <&aincom>; dvdd-supply =3D <&dvdd>; avdd-supply =3D <&avdd>; vref-supply =3D <&vref>; --=20 2.34.1 From nobody Fri Feb 13 14:11:10 2026 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A05EE171099; Wed, 17 Apr 2024 17:01:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713373282; cv=none; b=jSv/H00p/Ika32fJ+8kyxrctc1ZvWzOH6hN3Nr9lcm+eoRylj3mvWsC5SR0R2gxoFvXO8dYR6ju0zUNIL46Mh/D55tVtbAclGPGy8pxE79ZOU46cBhsvufYqrpf3/dQyMf7fVP/4HbXr8ThOTjFq4a01bXrUZXpiKesTQnMYdDw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713373282; c=relaxed/simple; bh=pCvbn1jf61MwV669wcYaAao51BqGxjxViYHqPph/RqE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=aPKnDTpEjIrjsf/xlcU/a37dmCIaFuyilnPOP5Sh/3t0X3dcXlSaghmmE+KyXv8/TLwT/2wKZpPrTQfWYCMJ7q28JVVCG0fFp/pPLHXImQyaSPRTgT8n1OpowgtLAp7o6Mo+Y7dI41BOkJtnP85YD6DZK8FWEWJrKIf3APck+J8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ToSFFcbE; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ToSFFcbE" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-343d1003106so4078906f8f.1; Wed, 17 Apr 2024 10:01:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713373277; x=1713978077; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZG4WqLxP5AYNlP8VpmeGoz9TMkj0yHMcCFSjBYjuRRE=; b=ToSFFcbEQfUEBaKNvdLMVQgqLsWgD3E1rSsxBR6UmxHwhp2SJAEq1wr3nh0ePGtIBR or5rJ3bMOMXqV6q/QzRdTISWkDTLLpIC1sJ1Y2f2RGX9cvnEKcMzFtKL4Yz95CoP4m9j lLTEACzARpRiQQTEZMriiWbH3qvy/DejZIgvDhV9ZnIlAEoiHvnxu1EGlBeg6eGJGBYT 10T6SDdchL0O1la9iiVPAhBRCuK4GSGvP5uZo6qz+G86X5aScupRZQrgS0FYd//gMBt3 8gLXuqe5O0XjkV+aiMkccjsbOqIFFuDlAk9Vs2M1EEgLO0YWt/ljd6try6t+ssyVl0/Q cegg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713373277; x=1713978077; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZG4WqLxP5AYNlP8VpmeGoz9TMkj0yHMcCFSjBYjuRRE=; b=B3ciQbMTqIp/URG6j6zrCbqYawXYOD47M2ap4RKF10GpZpZtgouWUgyT8p16CWfd41 48I+JXC6kYouV08S6xanxT7yRCulZKrH3LcCF21I6H3VoJO1VeaiFVm+5x4HpkKzLt/i /N4Qc4hDPOoEz/oy335kp+qL9utik8D+8E0e6RgbhU4dSL1lIzX3YK3PIoKF/gqGeelS h+EAlJ16VmGfmysvUZA913wE6S2Lm7aPNuqipTu140t1phkBt39nFRR6E5kZtAQnBByZ /dYQleZRcfiNeMdTFcDJnfS2JEIGzEpzDNZm8lgzfWLsbWG9DP8PosalDgJPReqmUwN/ +vFQ== X-Forwarded-Encrypted: i=1; AJvYcCVr03w3xqbrr1xwNpZWA2ZLrmzkcuWzPLJDUtngXjcP7PnhO1K6t/urC93A5yocZcKC9gxR70Nhj90So2ES47jmkukLKnR4hvIlSLrA1/cPNAo/FLuLKFf2TVf5JC0TK7fazcfcViBF9TMMg3f3H8RK2nxyQZIr4q78RxxYURXkEF18hA== X-Gm-Message-State: AOJu0Yy0kIUK99sa+iDdU3zeB7WXm57Z0FDhv2lB2Ev5zCwzkbK3YNIV a4ZwcvwU0f6SXMFhMVmHOU958ibUIEZ4Gue9KYE8TbBrfVn1lCrO X-Google-Smtp-Source: AGHT+IGabgp0ffGze20cmg3gFkaG8DErVtupbaTCdQjsgtC1r5LnagzvVjbp+F6lV6IWNTAkPYw89Q== X-Received: by 2002:adf:f542:0:b0:349:d779:3d60 with SMTP id j2-20020adff542000000b00349d7793d60mr1261551wrp.57.1713373276711; Wed, 17 Apr 2024 10:01:16 -0700 (PDT) Received: from spiri.. ([86.124.122.31]) by smtp.gmail.com with ESMTPSA id g2-20020adff3c2000000b00343300a4eb8sm17949441wrp.49.2024.04.17.10.01.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 10:01:16 -0700 (PDT) From: Alisa-Dariana Roman X-Google-Original-From: Alisa-Dariana Roman To: michael.hennerich@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: alexandru.tachici@analog.com, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, andy@kernel.org, nuno.sa@analog.com, marcelo.schmitt@analog.com, bigunclemax@gmail.com, dlechner@baylibre.com, okan.sahin@analog.com, fr0st61te@gmail.com, alisa.roman@analog.com, marcus.folkesson@gmail.com, schnelle@linux.ibm.com, liambeguin@gmail.com Subject: [PATCH v6 3/5] iio: adc: ad7192: Add aincom supply Date: Wed, 17 Apr 2024 20:00:52 +0300 Message-Id: <20240417170054.140587-4-alisa.roman@analog.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240417170054.140587-1-alisa.roman@analog.com> References: <20240417170054.140587-1-alisa.roman@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" AINCOM should actually be a supply. AINx inputs are referenced to AINCOM in pseduo-differential operation mode. AINCOM voltage represets the offset of corresponding channels. Signed-off-by: Alisa-Dariana Roman --- drivers/iio/adc/ad7192.c | 37 +++++++++++++++++++++++++++++++++++-- 1 file changed, 35 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c index fe8dbb68a8ba..8d56cf889973 100644 --- a/drivers/iio/adc/ad7192.c +++ b/drivers/iio/adc/ad7192.c @@ -186,6 +186,7 @@ struct ad7192_state { struct regulator *vref; struct clk *mclk; u16 int_vref_mv; + u32 aincom_mv; u32 fclk; u32 mode; u32 conf; @@ -742,10 +743,19 @@ static int ad7192_read_raw(struct iio_dev *indio_dev, *val =3D -(1 << (chan->scan_type.realbits - 1)); else *val =3D 0; + switch (chan->type) { + case IIO_VOLTAGE: + if (st->aincom_mv && !chan->differential) + *val +=3D DIV_ROUND_CLOSEST_ULL((u64)st->aincom_mv * 1000000000, + st->scale_avail[gain][1]); + return IIO_VAL_INT; /* Kelvin to Celsius */ - if (chan->type =3D=3D IIO_TEMP) + case IIO_TEMP: *val -=3D 273 * ad7192_get_temp_scale(unipolar); - return IIO_VAL_INT; + return IIO_VAL_INT; + default: + return -EINVAL; + } case IIO_CHAN_INFO_SAMP_FREQ: *val =3D DIV_ROUND_CLOSEST(ad7192_get_f_adc(st), 1024); return IIO_VAL_INT; @@ -1052,6 +1062,7 @@ static int ad7192_probe(struct spi_device *spi) { struct ad7192_state *st; struct iio_dev *indio_dev; + struct regulator *aincom; int ret; =20 if (!spi->irq) { @@ -1067,6 +1078,27 @@ static int ad7192_probe(struct spi_device *spi) =20 mutex_init(&st->lock); =20 + aincom =3D devm_regulator_get_optional(&spi->dev, "aincom"); + if (!IS_ERR(aincom)) { + ret =3D regulator_enable(aincom); + if (ret) { + dev_err(&spi->dev, "Failed to enable specified AINCOM supply\n"); + return ret; + } + + ret =3D devm_add_action_or_reset(&spi->dev, ad7192_reg_disable, aincom); + if (ret) + return ret; + + ret =3D regulator_get_voltage(aincom); + if (ret < 0) + return dev_err_probe(&spi->dev, ret, + "Device tree error, AINCOM voltage undefined\n"); + st->aincom_mv =3D ret / 1000; + } else { + st->aincom_mv =3D 0; + } + st->avdd =3D devm_regulator_get(&spi->dev, "avdd"); if (IS_ERR(st->avdd)) return PTR_ERR(st->avdd); @@ -1113,6 +1145,7 @@ static int ad7192_probe(struct spi_device *spi) st->int_vref_mv =3D ret / 1000; =20 st->chip_info =3D spi_get_device_match_data(spi); + indio_dev->name =3D st->chip_info->name; indio_dev->modes =3D INDIO_DIRECT_MODE; indio_dev->channels =3D st->chip_info->channels; --=20 2.34.1 From nobody Fri Feb 13 14:11:10 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2781317335E; Wed, 17 Apr 2024 17:01:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713373285; cv=none; b=hV8Q4i5Iqa7mI3zyKfDPR5r6DgnkTyqaY/+o57JqmARvZGQwRDcV2bLMyIdkPx0y8hKgpxSF9AEyw6oF1xxgl+Y1iehS4BR0hnd/ckt7c/nk4qsHkykHdslkQ/q5T8Gbek1wqZKJkcrQqtYoeVt4Jpzdnq2ArBQVS1ELIm823IA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713373285; c=relaxed/simple; bh=HeNgvg0merXOvICLIdduBoIju+D5EL2ctk64FGZpyuw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ho1vqW6eIQJXKBnjEetySVnEcsAHmFB+HH0zdWf+euD+jaZlFO3aQAnhITunk8nhxcJxhy48fkq+1hr/SLKfGQljzZP41i2OlkIdxQtp9ZhI24IW5JvHuGhzGgaTxemUnk55GqRkGUJdYBYLkSfWImYGLIuqbViiD1DkRXNGkyI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a0RtsMps; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a0RtsMps" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-418a2de4d8fso11595705e9.2; Wed, 17 Apr 2024 10:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713373280; x=1713978080; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BtgVF9SCtDu/QsYS3bPqYpnMCKPhrvap137EfB1aKuE=; b=a0RtsMpsrUh2zAUX6MJ5ufdDEzL43jCPMctCkN5xMFv9L8nFUvKedJJEi7WLxuGDan dFFQkSGlfMpAlNqXcuSzn2PLEekQeDrVviQ1JorW4bQECJ/c0YU0V11sRaU9s0B6y+yX Cj9oaoqhV8Kj3V2DuN281RB17Jss1oOBP6RLtau7db+h0laXWxkl9F/Wo6w4JaTu+RlF S0namDm0tIUoKsJx2g24stS2rk2HG/VQRFppmYDLBY55DgSHroRwqsAcpvhK048LP4QB OMeuYAwCh1l9fJvTYtD45iXI80hPIpKJUlw6nAwKJAlDwSDHmLottUg9LKCJ++4nfgaR G7Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713373280; x=1713978080; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BtgVF9SCtDu/QsYS3bPqYpnMCKPhrvap137EfB1aKuE=; b=ht2ezmIe7Wc+9iCiQ62hmfmc/AAnx4CE6JqWdK9yhdHuqP3XjEBuXU8aFk+HLyw+Wh 9o2zWYoFPqV+L/2oe6CtnM2b7vz5DJZeRM0yPel660fVmzwj2cEazS7fzjKdlKKO+ApK EdYjzk5eqMCpe/GASw/x5ZYafb/W97xu1yX+1UWqSxzw3by9Ck2BrCK5e3llNN0HzoTe tko0pJVua/QxvML6wTsm/JSD7OAbv21E7g6x+lz8vsP5K4bzuDxsVhdEOk5CWwolNxX4 4RTPcAuJWcyHxZsSwRWNtHWgYvcIzaPhYBET3a1lXamrVTj5EmetZIT/UUgl40xHuHaL IfoQ== X-Forwarded-Encrypted: i=1; AJvYcCVM4/D39v6dqvUfLzOlIW6o8qjT87qGbPToG201prC7rxpMyP277VqFbmHWlsBLf0VpW4MNfO5rYGbTszJ4a13BQRpqSToyq12ZQTrtpq6/Rnfm2XcADJTzRZ9iZvBtdVjuZu96Es+jzZZhp7WI3GNnPKELciPC+1TuqGPrv1BWaxASXg== X-Gm-Message-State: AOJu0YzUnagBu/PUPD8vv1XoBJgREs7bd0553zngoHb8PmplNtt5YO0Y oZ5vaRpoHedLuzAHk443rTUAl8utTCOKh7zcSa/0b0U4v/3bsYOX X-Google-Smtp-Source: AGHT+IFh/7u4KRBpvpRx47rZgfcnINcUca+nHPyvqq/eTvyQmNyronxH89zYvQXR+PZvwpsDTwbbMw== X-Received: by 2002:adf:b35c:0:b0:349:bd11:1bea with SMTP id k28-20020adfb35c000000b00349bd111beamr1792268wrd.11.1713373280427; Wed, 17 Apr 2024 10:01:20 -0700 (PDT) Received: from spiri.. ([86.124.122.31]) by smtp.gmail.com with ESMTPSA id g2-20020adff3c2000000b00343300a4eb8sm17949441wrp.49.2024.04.17.10.01.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 10:01:20 -0700 (PDT) From: Alisa-Dariana Roman X-Google-Original-From: Alisa-Dariana Roman To: michael.hennerich@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: alexandru.tachici@analog.com, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, andy@kernel.org, nuno.sa@analog.com, marcelo.schmitt@analog.com, bigunclemax@gmail.com, dlechner@baylibre.com, okan.sahin@analog.com, fr0st61te@gmail.com, alisa.roman@analog.com, marcus.folkesson@gmail.com, schnelle@linux.ibm.com, liambeguin@gmail.com Subject: [PATCH v6 4/5] dt-bindings: iio: adc: ad7192: Add AD7194 support Date: Wed, 17 Apr 2024 20:00:53 +0300 Message-Id: <20240417170054.140587-5-alisa.roman@analog.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240417170054.140587-1-alisa.roman@analog.com> References: <20240417170054.140587-1-alisa.roman@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Unlike the other AD719Xs, AD7194 has configurable differential channels. The user can dynamically configure them in the devicetree. Also add an example for AD7194 devicetree. Signed-off-by: Alisa-Dariana Roman --- .../bindings/iio/adc/adi,ad7192.yaml | 77 +++++++++++++++++++ 1 file changed, 77 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml b/Do= cumentation/devicetree/bindings/iio/adc/adi,ad7192.yaml index cf5c568f140a..7e4e15e4e648 100644 --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml @@ -21,8 +21,15 @@ properties: - adi,ad7190 - adi,ad7192 - adi,ad7193 + - adi,ad7194 - adi,ad7195 =20 + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + reg: maxItems: 1 =20 @@ -89,6 +96,30 @@ properties: description: see Documentation/devicetree/bindings/iio/adc/adc.yaml type: boolean =20 +patternProperties: + "^channel@[0-9a-z]+$": + type: object + $ref: adc.yaml + unevaluatedProperties: false + + properties: + reg: + description: The channel index. + minimum: 1 + maximum: 256 + + diff-channels: + description: | + Both inputs can be connected to pins AIN1 to AIN16 by choosing t= he + appropriate value from 1 to 16. + items: + minimum: 1 + maximum: 16 + + required: + - reg + - diff-channels + required: - compatible - reg @@ -103,6 +134,17 @@ required: =20 allOf: - $ref: /schemas/spi/spi-peripheral-props.yaml# + - if: + properties: + compatible: + enum: + - adi,ad7190 + - adi,ad7192 + - adi,ad7193 + - adi,ad7195 + then: + patternProperties: + "^channel@[0-9a-z]+$": false =20 unevaluatedProperties: false =20 @@ -133,3 +175,38 @@ examples: adi,burnout-currents-enable; }; }; + - | + spi { + #address-cells =3D <1>; + #size-cells =3D <0>; + + adc@0 { + compatible =3D "adi,ad7194"; + reg =3D <0>; + + #address-cells =3D <1>; + #size-cells =3D <0>; + + spi-max-frequency =3D <1000000>; + spi-cpol; + spi-cpha; + clocks =3D <&ad7192_mclk>; + clock-names =3D "mclk"; + interrupts =3D <25 0x2>; + interrupt-parent =3D <&gpio>; + aincom-supply =3D <&aincom>; + dvdd-supply =3D <&dvdd>; + avdd-supply =3D <&avdd>; + vref-supply =3D <&vref>; + + channel@1 { + reg =3D <1>; + diff-channels =3D <1 6>; + }; + + channel@2 { + reg =3D <2>; + diff-channels =3D <16 5>; + }; + }; + }; --=20 2.34.1 From nobody Fri Feb 13 14:11:10 2026 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40B12178CE8; Wed, 17 Apr 2024 17:01:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713373290; cv=none; b=Qkaejqd/mhDIopH9mIbaaFAJcQnm7qSMgmD9L/QSYNvLVZcQs9IZzAIdrKrLCHiTbKMzn7Ent6F1OICoCGOwJrQ8m7y7SWFY7eE3ggk0j+dZAC6yICBuzqW8AH3KmkDBb0Jk13eb/qEp3INi68p0fasaKprtx0CgGDXP8niyETo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713373290; c=relaxed/simple; bh=ZSYcEoEeIbTMMApoUpft+vWV6+yLewZlnSX6ans5n7A=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=O+EebquhKymOc1Zu1zIdChqn/Pee3Et/yXh7LQ429PcPWNu3Wh0BjnkaUWVnvmbyqh0QE/gtXAMTDxOyfKzzcNVqQdA2bFMI/WaYErSt28ErECF72EbGdo/qaJYz01h8VWiC0cysCE247FZivwohC6Jp4lUGP0zQ05Ovyr7msVc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PO5cLLea; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PO5cLLea" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3455ff1339dso3969013f8f.0; Wed, 17 Apr 2024 10:01:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713373284; x=1713978084; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DhLj2QxSVDUqsIOYdaogivE14AODPOTFZug6/MH3QPU=; b=PO5cLLeaHJf35DN0mjZfE+tizcu6HP0kmEGx5Cmmc7sIlLRLoPR9bEd8uXXiP8P5oL aHdpCiAOxdnpY4n7pr8tIQOVHhG4eUxRq96IBFC0ehoUwfXJ70kwY0PAOJpUxliPH1QK hlUp87ZuPg+YK4Ep+ACfCAY/A1EKP9TA6aJ+mNZbKs+FT99uYjzlpIOuAYk5mSrWVf9J as8Iz2VR+RKKicVxBIPAGjj8KGNOK9hKWq3bwBc8sctJfiE39N3V12TD9e15ODQ2WFou dt9ON0cFtkk6khkuEmVvuf3xKlEdbKYP+Fj8bmUDoJBrcwFkwmc3PHDAlVdDZsW6A6rU edOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713373284; x=1713978084; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DhLj2QxSVDUqsIOYdaogivE14AODPOTFZug6/MH3QPU=; b=MgkD1THHDLr6SE+R9y9ev7P2BRwzj/pJXGJte9mNoHiXxJh1/4QjhaoUxse5AojHrN N837WLFw8NzI0R6nRqot2zqqAOlzDXaFHqZxKu7fKGXmWFS/oP/XbMpmhnBUWZg90aO9 xt6LpaJyetCNiJVkcmsi5pQgxq/jGVhQluz1B7wfWYTYULNnL28CMYxmmN/2zR/B2f9z 9EQ8Ymfd6XAHM6NH2O6QcVPAq/Z8Sk0bUrGCwFIrAplXF5EZe9XelKjPAJaNzZinHQ/D ghcqoJrAEhG8o499TljAyUEHR+64J6ppiyTYGSygD0sCRcKKmtFGp3pIq+oAB90s/FM3 iO3A== X-Forwarded-Encrypted: i=1; AJvYcCUn4au04MWwdVjELx8+kGz+cP3BjrgDCABpXYAZF+t0oc2DL6BlZ2Obhviz9+XQ6XWBCzkZ5IVBqqEUN2QBGP2BLv9PvfkynpBF1R2JqPJNrDEMD78IUtqiAqRwehJEavUydgYVvbG4Rivv/BS1mkro7PxucwwTqpTSz+KdvtbmCnlvEA== X-Gm-Message-State: AOJu0YwV4q9zYiFZQKvyMsBFRRnLr28epZo+pOPeBysQd88xjG+y6Vjb DHy2tG82lWhU0IDcEwGfToSm4OByMxKLKk60PyFBqngKqdWaFvn0CXHEL9KB X-Google-Smtp-Source: AGHT+IGXrK591hj3hABFljdZRz43asx7yRqpdEIWY8sPqqC54ulXCqVUZ2fyaKMrPebr4TOku8xTxA== X-Received: by 2002:a5d:6da6:0:b0:343:30a2:3a3d with SMTP id u6-20020a5d6da6000000b0034330a23a3dmr16258824wrs.62.1713373284421; Wed, 17 Apr 2024 10:01:24 -0700 (PDT) Received: from spiri.. ([86.124.122.31]) by smtp.gmail.com with ESMTPSA id g2-20020adff3c2000000b00343300a4eb8sm17949441wrp.49.2024.04.17.10.01.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 10:01:24 -0700 (PDT) From: Alisa-Dariana Roman X-Google-Original-From: Alisa-Dariana Roman To: michael.hennerich@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: alexandru.tachici@analog.com, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, andy@kernel.org, nuno.sa@analog.com, marcelo.schmitt@analog.com, bigunclemax@gmail.com, dlechner@baylibre.com, okan.sahin@analog.com, fr0st61te@gmail.com, alisa.roman@analog.com, marcus.folkesson@gmail.com, schnelle@linux.ibm.com, liambeguin@gmail.com Subject: [PATCH v6 5/5] iio: adc: ad7192: Add AD7194 support Date: Wed, 17 Apr 2024 20:00:54 +0300 Message-Id: <20240417170054.140587-6-alisa.roman@analog.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240417170054.140587-1-alisa.roman@analog.com> References: <20240417170054.140587-1-alisa.roman@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Unlike the other AD719Xs, AD7194 has configurable differential channels. The user can dynamically configure them in the devicetree. Also modify config AD7192 description for better scaling. Signed-off-by: Alisa-Dariana Roman --- drivers/iio/adc/Kconfig | 11 +++- drivers/iio/adc/ad7192.c | 122 +++++++++++++++++++++++++++++++++++++-- 2 files changed, 126 insertions(+), 7 deletions(-) diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index 8db68b80b391..74fecc284f1a 100644 --- a/drivers/iio/adc/Kconfig +++ b/drivers/iio/adc/Kconfig @@ -88,12 +88,17 @@ config AD7173 called ad7173. =20 config AD7192 - tristate "Analog Devices AD7190 AD7192 AD7193 AD7195 ADC driver" + tristate "Analog Devices AD7192 and similar ADC driver" depends on SPI select AD_SIGMA_DELTA help - Say yes here to build support for Analog Devices AD7190, - AD7192, AD7193 or AD7195 SPI analog to digital converters (ADC). + Say yes here to build support for Analog Devices SPI analog to digital + converters (ADC): + - AD7190 + - AD7192 + - AD7193 + - AD7194 + - AD7195 If unsure, say N (but it's safe to say "Y"). =20 To compile this driver as a module, choose M here: the diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c index 8d56cf889973..dc113405f1bc 100644 --- a/drivers/iio/adc/ad7192.c +++ b/drivers/iio/adc/ad7192.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 /* - * AD7190 AD7192 AD7193 AD7195 SPI ADC driver + * AD7192 and similar SPI ADC driver * * Copyright 2011-2015 Analog Devices Inc. */ @@ -128,10 +128,21 @@ #define AD7193_CH_AIN8 0x480 /* AIN7 - AINCOM */ #define AD7193_CH_AINCOM 0x600 /* AINCOM - AINCOM */ =20 +#define AD7194_CH_POS(x) (((x) - 1) << 4) +#define AD7194_CH_NEG(x) ((x) - 1) +#define AD7194_CH_DIFF(pos, neg) \ + (((neg) =3D=3D 0 ? BIT(10) : AD7194_CH_NEG(neg)) | AD7194_CH_POS(pos)) +#define AD7194_CH_TEMP 0x100 /* Temp sensor */ +#define AD7194_CH_BASE_NR 18 +#define AD7194_CH_AIN_START 1 +#define AD7194_CH_AIN_NR 16 +#define AD7194_CH_DIFF_NR_MAX 256 + /* ID Register Bit Designations (AD7192_REG_ID) */ #define CHIPID_AD7190 0x4 #define CHIPID_AD7192 0x0 #define CHIPID_AD7193 0x2 +#define CHIPID_AD7194 0x3 #define CHIPID_AD7195 0x6 #define AD7192_ID_MASK GENMASK(3, 0) =20 @@ -169,6 +180,7 @@ enum { ID_AD7190, ID_AD7192, ID_AD7193, + ID_AD7194, ID_AD7195, }; =20 @@ -178,6 +190,7 @@ struct ad7192_chip_info { const struct iio_chan_spec *channels; u8 num_channels; const struct iio_info *info; + int (*parse_channels)(struct iio_dev *indio_dev); }; =20 struct ad7192_state { @@ -931,6 +944,15 @@ static const struct iio_info ad7192_info =3D { .update_scan_mode =3D ad7192_update_scan_mode, }; =20 +static const struct iio_info ad7194_info =3D { + .read_raw =3D ad7192_read_raw, + .write_raw =3D ad7192_write_raw, + .write_raw_get_fmt =3D ad7192_write_raw_get_fmt, + .read_avail =3D ad7192_read_avail, + .validate_trigger =3D ad_sd_validate_trigger, + .update_scan_mode =3D ad7192_update_scan_mode, +}; + static const struct iio_info ad7195_info =3D { .read_raw =3D ad7192_read_raw, .write_raw =3D ad7192_write_raw, @@ -1022,6 +1044,84 @@ static const struct iio_chan_spec ad7193_channels[] = =3D { IIO_CHAN_SOFT_TIMESTAMP(14), }; =20 +static int ad7194_parse_channel(struct fwnode_handle *child, + struct iio_chan_spec *ad7194_channel) +{ + u32 ain[2]; + int ret; + + ret =3D fwnode_property_read_u32_array(child, "diff-channels", ain, + ARRAY_SIZE(ain)); + if (ret) + return ret; + + if (!in_range(ain[0], AD7194_CH_AIN_START, AD7194_CH_AIN_NR) || + !in_range(ain[1], AD7194_CH_AIN_START, AD7194_CH_AIN_NR)) + return -EINVAL; + + ad7194_channel->channel =3D ain[0]; + ad7194_channel->channel2 =3D ain[1]; + ad7194_channel->address =3D AD7194_CH_DIFF(ain[0], ain[1]); + + return 0; +} + +static int ad7194_parse_channels(struct iio_dev *indio_dev) +{ + struct device *dev =3D indio_dev->dev.parent; + struct iio_chan_spec *ad7194_channels; + struct fwnode_handle *child; + struct iio_chan_spec ad7194_chan =3D AD7193_CHANNEL(0, 0, 0); + struct iio_chan_spec ad7194_chan_diff =3D AD7193_DIFF_CHANNEL(0, 0, 0, 0); + struct iio_chan_spec ad7194_chan_temp =3D AD719x_TEMP_CHANNEL(0, 0); + struct iio_chan_spec ad7194_chan_timestamp =3D IIO_CHAN_SOFT_TIMESTAMP(0); + unsigned int num_channels, index =3D 0, ain_chan; + int ret; + + num_channels =3D device_get_child_node_count(dev); + if (num_channels > AD7194_CH_DIFF_NR_MAX) + return -EINVAL; + + num_channels +=3D AD7194_CH_BASE_NR; + + ad7194_channels =3D devm_kcalloc(dev, num_channels, + sizeof(*ad7194_channels), GFP_KERNEL); + if (!ad7194_channels) + return -ENOMEM; + + indio_dev->channels =3D ad7194_channels; + indio_dev->num_channels =3D num_channels; + + device_for_each_child_node(dev, child) { + *ad7194_channels =3D ad7194_chan_diff; + ad7194_channels->scan_index =3D index++; + ret =3D ad7194_parse_channel(child, ad7194_channels); + if (ret) { + fwnode_handle_put(child); + return ret; + } + ad7194_channels++; + } + + *ad7194_channels =3D ad7194_chan_temp; + ad7194_channels->scan_index =3D index++; + ad7194_channels->address =3D AD7194_CH_TEMP; + ad7194_channels++; + + for (ain_chan =3D 1; ain_chan <=3D 16; ain_chan++) { + *ad7194_channels =3D ad7194_chan; + ad7194_channels->scan_index =3D index++; + ad7194_channels->channel =3D ain_chan; + ad7194_channels->address =3D AD7194_CH_DIFF(ain_chan, 0); + ad7194_channels++; + } + + *ad7194_channels =3D ad7194_chan_timestamp; + ad7194_channels->scan_index =3D index; + + return 0; +} + static const struct ad7192_chip_info ad7192_chip_info_tbl[] =3D { [ID_AD7190] =3D { .chip_id =3D CHIPID_AD7190, @@ -1044,6 +1144,12 @@ static const struct ad7192_chip_info ad7192_chip_inf= o_tbl[] =3D { .num_channels =3D ARRAY_SIZE(ad7193_channels), .info =3D &ad7192_info, }, + [ID_AD7194] =3D { + .chip_id =3D CHIPID_AD7194, + .name =3D "ad7194", + .info =3D &ad7194_info, + .parse_channels =3D ad7194_parse_channels, + }, [ID_AD7195] =3D { .chip_id =3D CHIPID_AD7195, .name =3D "ad7195", @@ -1148,9 +1254,15 @@ static int ad7192_probe(struct spi_device *spi) =20 indio_dev->name =3D st->chip_info->name; indio_dev->modes =3D INDIO_DIRECT_MODE; - indio_dev->channels =3D st->chip_info->channels; - indio_dev->num_channels =3D st->chip_info->num_channels; indio_dev->info =3D st->chip_info->info; + if (st->chip_info->parse_channels) { + ret =3D st->chip_info->parse_channels(indio_dev); + if (ret) + return ret; + } else { + indio_dev->channels =3D st->chip_info->channels; + indio_dev->num_channels =3D st->chip_info->num_channels; + } =20 ret =3D ad_sd_init(&st->sd, indio_dev, spi, &ad7192_sigma_delta_info); if (ret) @@ -1189,6 +1301,7 @@ static const struct of_device_id ad7192_of_match[] = =3D { { .compatible =3D "adi,ad7190", .data =3D &ad7192_chip_info_tbl[ID_AD7190= ] }, { .compatible =3D "adi,ad7192", .data =3D &ad7192_chip_info_tbl[ID_AD7192= ] }, { .compatible =3D "adi,ad7193", .data =3D &ad7192_chip_info_tbl[ID_AD7193= ] }, + { .compatible =3D "adi,ad7194", .data =3D &ad7192_chip_info_tbl[ID_AD7194= ] }, { .compatible =3D "adi,ad7195", .data =3D &ad7192_chip_info_tbl[ID_AD7195= ] }, {} }; @@ -1198,6 +1311,7 @@ static const struct spi_device_id ad7192_ids[] =3D { { "ad7190", (kernel_ulong_t)&ad7192_chip_info_tbl[ID_AD7190] }, { "ad7192", (kernel_ulong_t)&ad7192_chip_info_tbl[ID_AD7192] }, { "ad7193", (kernel_ulong_t)&ad7192_chip_info_tbl[ID_AD7193] }, + { "ad7194", (kernel_ulong_t)&ad7192_chip_info_tbl[ID_AD7194] }, { "ad7195", (kernel_ulong_t)&ad7192_chip_info_tbl[ID_AD7195] }, {} }; @@ -1214,6 +1328,6 @@ static struct spi_driver ad7192_driver =3D { module_spi_driver(ad7192_driver); =20 MODULE_AUTHOR("Michael Hennerich "); -MODULE_DESCRIPTION("Analog Devices AD7190, AD7192, AD7193, AD7195 ADC"); +MODULE_DESCRIPTION("Analog Devices AD7192 and similar ADC"); MODULE_LICENSE("GPL v2"); MODULE_IMPORT_NS(IIO_AD_SIGMA_DELTA); --=20 2.34.1