From nobody Tue Feb 10 15:43:39 2026 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 490FA3BBD9; Mon, 15 Apr 2024 08:15:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713168902; cv=none; b=aZTfyzdUpkYcp38m542j8bAy2Ocq6hRbS9Eslo9tAgTa9YQzUndromo1VXQP9OU3hHSlgFHU7lQN43xI3qvi4XwA7JJOfzamKVPRlim8kc3SL3bEAc1idMji6yKUueSiZ+3w17i595g4hqhziwEbBWcog9HBAwPYqfuBoWcP1aA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713168902; c=relaxed/simple; bh=1vW++xN8zF1A0z3Y8yp49FhFAPI2if6N2fDvYtR7R4w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KmRAFrl5JjAYs7qR0jLJ6U/lMK5HqvrOUUb8LDUehiE+9CnlHBLuImzsIcadsH23Ir3AXgZ8Lskb/+PQr/ptGz0gjm41pBC3JGoWROwsUDhCknloT6a3b9z+DPY4fBaQEnPDa+OM8e5dfpIIKmtMXZd3uLvGFkMs/hde0rGrvqc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 170D81476; Mon, 15 Apr 2024 01:15:28 -0700 (PDT) Received: from e126817.cambridge.arm.com (e126817.cambridge.arm.com [10.2.3.5]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 14AAF3F64C; Mon, 15 Apr 2024 01:14:57 -0700 (PDT) From: Ben Gainey To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org Cc: james.clark@arm.com, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Gainey Subject: [PATCH v5 1/4] perf: Support PERF_SAMPLE_READ with inherit Date: Mon, 15 Apr 2024 09:14:45 +0100 Message-ID: <20240415081448.123789-2-ben.gainey@arm.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240415081448.123789-1-ben.gainey@arm.com> References: <20240415081448.123789-1-ben.gainey@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This change allows events to use PERF_SAMPLE READ with inherit so long as PERF_SAMPLE_TID is also set. In this configuration, an event will be inherited into any child processes / threads, allowing convenient profiling of a multiprocess or multithreaded application, whilst allowing profiling tools to collect per-thread samples, in particular of groups of counters. The read_format field of both PERF_RECORD_READ and PERF_RECORD_SAMPLE are changed by this new configuration, but calls to `read()` on the same event file descriptor are unaffected and continue to return the cumulative total. Signed-off-by: Ben Gainey --- include/linux/perf_event.h | 1 + kernel/events/core.c | 82 ++++++++++++++++++++++++++++---------- 2 files changed, 62 insertions(+), 21 deletions(-) diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index d2a15c0c6f8a..e7eed33c50f1 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h @@ -932,6 +932,7 @@ struct perf_event_context { =20 int nr_task_data; int nr_stat; + int nr_inherit_read; int nr_freq; int rotate_disable; =20 diff --git a/kernel/events/core.c b/kernel/events/core.c index 724e6d7e128f..bf0639a2e2b1 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -1767,6 +1767,18 @@ perf_event_groups_next(struct perf_event *event, str= uct pmu *pmu) event =3D rb_entry_safe(rb_next(&event->group_node), \ typeof(*event), group_node)) =20 +/* + * Does the event attribute request inherit with PERF_SAMPLE_READ + */ +#define perf_attr_has_inherit_and_sample_read(attr) \ + ((attr)->inherit && ((attr)->sample_type & PERF_SAMPLE_READ)) + +/* + * Does the event request an attribte that requests inherit with PERF_SAMP= LE_READ + */ +#define perf_event_has_inherit_and_sample_read(event) \ + perf_attr_has_inherit_and_sample_read(&((event)->attr)) + /* * Add an event from the lists for its context. * Must be called with ctx->mutex and ctx->lock held. @@ -1797,6 +1809,8 @@ list_add_event(struct perf_event *event, struct perf_= event_context *ctx) ctx->nr_user++; if (event->attr.inherit_stat) ctx->nr_stat++; + if (perf_event_has_inherit_and_sample_read(event)) + ctx->nr_inherit_read++; =20 if (event->state > PERF_EVENT_STATE_OFF) perf_cgroup_event_enable(event, ctx); @@ -2021,6 +2035,8 @@ list_del_event(struct perf_event *event, struct perf_= event_context *ctx) ctx->nr_user--; if (event->attr.inherit_stat) ctx->nr_stat--; + if (perf_event_has_inherit_and_sample_read(event)) + ctx->nr_inherit_read--; =20 list_del_rcu(&event->event_entry); =20 @@ -3529,11 +3545,18 @@ perf_event_context_sched_out(struct task_struct *ta= sk, struct task_struct *next) perf_ctx_disable(ctx, false); =20 /* PMIs are disabled; ctx->nr_pending is stable. */ - if (local_read(&ctx->nr_pending) || + if (ctx->nr_inherit_read || + next_ctx->nr_inherit_read || + local_read(&ctx->nr_pending) || local_read(&next_ctx->nr_pending)) { /* * Must not swap out ctx when there's pending * events that rely on the ctx->task relation. + * + * Likewise, when a context contains inherit + + * SAMPLE_READ events they should be switched + * out using the slow path so that they are + * treated as if they were distinct contexts. */ raw_spin_unlock(&next_ctx->lock); rcu_read_unlock(); @@ -4533,11 +4556,19 @@ static void __perf_event_read(void *info) raw_spin_unlock(&ctx->lock); } =20 -static inline u64 perf_event_count(struct perf_event *event) +static inline u64 perf_event_count_cumulative(struct perf_event *event) { return local64_read(&event->count) + atomic64_read(&event->child_count); } =20 +static inline u64 perf_event_count(struct perf_event *event, bool self_val= ue_only) +{ + if (self_value_only && perf_event_has_inherit_and_sample_read(event)) + return local64_read(&event->count); + + return perf_event_count_cumulative(event); +} + static void calc_timer_values(struct perf_event *event, u64 *now, u64 *enabled, @@ -5454,7 +5485,7 @@ static u64 __perf_event_read_value(struct perf_event = *event, u64 *enabled, u64 * mutex_lock(&event->child_mutex); =20 (void)perf_event_read(event, false); - total +=3D perf_event_count(event); + total +=3D perf_event_count_cumulative(event); =20 *enabled +=3D event->total_time_enabled + atomic64_read(&event->child_total_time_enabled); @@ -5463,7 +5494,7 @@ static u64 __perf_event_read_value(struct perf_event = *event, u64 *enabled, u64 * =20 list_for_each_entry(child, &event->child_list, child_list) { (void)perf_event_read(child, false); - total +=3D perf_event_count(child); + total +=3D perf_event_count_cumulative(child); *enabled +=3D child->total_time_enabled; *running +=3D child->total_time_running; } @@ -5545,14 +5576,14 @@ static int __perf_read_group_add(struct perf_event = *leader, /* * Write {count,id} tuples for every sibling. */ - values[n++] +=3D perf_event_count(leader); + values[n++] +=3D perf_event_count_cumulative(leader); if (read_format & PERF_FORMAT_ID) values[n++] =3D primary_event_id(leader); if (read_format & PERF_FORMAT_LOST) values[n++] =3D atomic64_read(&leader->lost_samples); =20 for_each_sibling_event(sub, leader) { - values[n++] +=3D perf_event_count(sub); + values[n++] +=3D perf_event_count_cumulative(sub); if (read_format & PERF_FORMAT_ID) values[n++] =3D primary_event_id(sub); if (read_format & PERF_FORMAT_LOST) @@ -6132,7 +6163,7 @@ void perf_event_update_userpage(struct perf_event *ev= ent) ++userpg->lock; barrier(); userpg->index =3D perf_event_index(event); - userpg->offset =3D perf_event_count(event); + userpg->offset =3D perf_event_count_cumulative(event); if (userpg->index) userpg->offset -=3D local64_read(&event->hw.prev_count); =20 @@ -7194,13 +7225,14 @@ void perf_event__output_id_sample(struct perf_event= *event, =20 static void perf_output_read_one(struct perf_output_handle *handle, struct perf_event *event, - u64 enabled, u64 running) + u64 enabled, u64 running, + bool from_sample) { u64 read_format =3D event->attr.read_format; u64 values[5]; int n =3D 0; =20 - values[n++] =3D perf_event_count(event); + values[n++] =3D perf_event_count(event, from_sample); if (read_format & PERF_FORMAT_TOTAL_TIME_ENABLED) { values[n++] =3D enabled + atomic64_read(&event->child_total_time_enabled); @@ -7218,8 +7250,9 @@ static void perf_output_read_one(struct perf_output_h= andle *handle, } =20 static void perf_output_read_group(struct perf_output_handle *handle, - struct perf_event *event, - u64 enabled, u64 running) + struct perf_event *event, + u64 enabled, u64 running, + bool from_sample) { struct perf_event *leader =3D event->group_leader, *sub; u64 read_format =3D event->attr.read_format; @@ -7245,7 +7278,7 @@ static void perf_output_read_group(struct perf_output= _handle *handle, (leader->state =3D=3D PERF_EVENT_STATE_ACTIVE)) leader->pmu->read(leader); =20 - values[n++] =3D perf_event_count(leader); + values[n++] =3D perf_event_count(leader, from_sample); if (read_format & PERF_FORMAT_ID) values[n++] =3D primary_event_id(leader); if (read_format & PERF_FORMAT_LOST) @@ -7260,7 +7293,7 @@ static void perf_output_read_group(struct perf_output= _handle *handle, (sub->state =3D=3D PERF_EVENT_STATE_ACTIVE)) sub->pmu->read(sub); =20 - values[n++] =3D perf_event_count(sub); + values[n++] =3D perf_event_count(sub, from_sample); if (read_format & PERF_FORMAT_ID) values[n++] =3D primary_event_id(sub); if (read_format & PERF_FORMAT_LOST) @@ -7281,9 +7314,14 @@ static void perf_output_read_group(struct perf_outpu= t_handle *handle, * The problem is that its both hard and excessively expensive to iterate = the * child list, not to mention that its impossible to IPI the children runn= ing * on another CPU, from interrupt/NMI context. + * + * Instead the combination of PERF_SAMPLE_READ and inherit will track per-= thread + * counts rather than attempting to accumulate some value across all child= ren on + * all cores. */ static void perf_output_read(struct perf_output_handle *handle, - struct perf_event *event) + struct perf_event *event, + bool from_sample) { u64 enabled =3D 0, running =3D 0, now; u64 read_format =3D event->attr.read_format; @@ -7301,9 +7339,9 @@ static void perf_output_read(struct perf_output_handl= e *handle, calc_timer_values(event, &now, &enabled, &running); =20 if (event->attr.read_format & PERF_FORMAT_GROUP) - perf_output_read_group(handle, event, enabled, running); + perf_output_read_group(handle, event, enabled, running, from_sample); else - perf_output_read_one(handle, event, enabled, running); + perf_output_read_one(handle, event, enabled, running, from_sample); } =20 void perf_output_sample(struct perf_output_handle *handle, @@ -7343,7 +7381,7 @@ void perf_output_sample(struct perf_output_handle *ha= ndle, perf_output_put(handle, data->period); =20 if (sample_type & PERF_SAMPLE_READ) - perf_output_read(handle, event); + perf_output_read(handle, event, true); =20 if (sample_type & PERF_SAMPLE_CALLCHAIN) { int size =3D 1; @@ -7944,7 +7982,7 @@ perf_event_read_event(struct perf_event *event, return; =20 perf_output_put(&handle, read_event); - perf_output_read(&handle, event); + perf_output_read(&handle, event, false); perf_event__output_id_sample(event, &handle, &sample); =20 perf_output_end(&handle); @@ -12006,10 +12044,12 @@ perf_event_alloc(struct perf_event_attr *attr, in= t cpu, local64_set(&hwc->period_left, hwc->sample_period); =20 /* - * We currently do not support PERF_SAMPLE_READ on inherited events. + * We do not support PERF_SAMPLE_READ on inherited events unless + * PERF_SAMPLE_TID is also selected, which allows inherited events to + * collect per-thread samples. * See perf_output_read(). */ - if (attr->inherit && (attr->sample_type & PERF_SAMPLE_READ)) + if (perf_attr_has_inherit_and_sample_read(attr) && !(attr->sample_type & = PERF_SAMPLE_TID)) goto err_ns; =20 if (!has_branch_stack(event)) @@ -13033,7 +13073,7 @@ static void sync_child_event(struct perf_event *chi= ld_event) perf_event_read_event(child_event, task); } =20 - child_val =3D perf_event_count(child_event); + child_val =3D perf_event_count_cumulative(child_event); =20 /* * Add back the child's count to the parent's count: --=20 2.44.0 From nobody Tue Feb 10 15:43:39 2026 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 421383D969; Mon, 15 Apr 2024 08:15:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713168903; cv=none; b=Ay8QL0ywEOt2f3k6Sr3cefVSMlNpOS9PPq8P6bdW8uxBuBCSmMAzdP3MoyjRCmI75/ilYlR+kZGjo8bU7Pz1jjzLOrYLqJJCWyiaO6erjCPntz7dPdvwQiK947/xBbiI4FbooKz4zfvkSgs9+nXKWg4vj72lj1FvKABy1CObDFg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713168903; c=relaxed/simple; bh=wvmEMvCUzSgouK7RL1vaW0SFREP1d3S87z3s6JyC/4U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ovkEvN7hlL7Gg3WO24UpVLDjTEt+VXPTAdZY8ceKf7Tgw8oANMyTKyHpVAxnpO85s5N0BmeskFoFCvP5DqALqgYVxdMKyDEhGsTjJLRSux1IqA5UmMVW7kAuI+y3AzT/qYP9ZYOOD6kTiyWSEgVGXhF7OFaVs5J+u/IrfokGPfY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 02C261515; Mon, 15 Apr 2024 01:15:30 -0700 (PDT) Received: from e126817.cambridge.arm.com (e126817.cambridge.arm.com [10.2.3.5]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id F3F353F64C; Mon, 15 Apr 2024 01:14:59 -0700 (PDT) From: Ben Gainey To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org Cc: james.clark@arm.com, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Gainey Subject: [PATCH v5 2/4] tools/perf: Track where perf_sample_ids need per-thread periods Date: Mon, 15 Apr 2024 09:14:46 +0100 Message-ID: <20240415081448.123789-3-ben.gainey@arm.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240415081448.123789-1-ben.gainey@arm.com> References: <20240415081448.123789-1-ben.gainey@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" perf_sample_ids and related evlist/evsel code are modified to track which events combine inherit+PERF_SAMPLE_READ+PERF_SAMPLE_TID. Events with this combination of properties must be handled differently when calculating each sample period. They must use the combination of (ID + TID) to uniquely identify each distinct sequence of values. Signed-off-by: Ben Gainey --- tools/lib/perf/evlist.c | 1 + tools/lib/perf/evsel.c | 7 +++++++ tools/lib/perf/include/internal/evsel.h | 9 +++++++++ 3 files changed, 17 insertions(+) diff --git a/tools/lib/perf/evlist.c b/tools/lib/perf/evlist.c index c6d67fc9e57e..d17288eeaee4 100644 --- a/tools/lib/perf/evlist.c +++ b/tools/lib/perf/evlist.c @@ -255,6 +255,7 @@ static void perf_evlist__id_hash(struct perf_evlist *ev= list, =20 sid->id =3D id; sid->evsel =3D evsel; + sid->period_per_thread =3D perf_evsel__attr_has_per_thread_sample_period(= evsel); hash =3D hash_64(sid->id, PERF_EVLIST__HLIST_BITS); hlist_add_head(&sid->node, &evlist->heads[hash]); } diff --git a/tools/lib/perf/evsel.c b/tools/lib/perf/evsel.c index c07160953224..f7abb879f416 100644 --- a/tools/lib/perf/evsel.c +++ b/tools/lib/perf/evsel.c @@ -537,6 +537,13 @@ void perf_evsel__free_id(struct perf_evsel *evsel) evsel->ids =3D 0; } =20 +bool perf_evsel__attr_has_per_thread_sample_period(struct perf_evsel *evse= l) +{ + return (evsel->attr.sample_type & PERF_SAMPLE_READ) + && (evsel->attr.sample_type & PERF_SAMPLE_TID) + && evsel->attr.inherit; +} + void perf_counts_values__scale(struct perf_counts_values *count, bool scale, __s8 *pscaled) { diff --git a/tools/lib/perf/include/internal/evsel.h b/tools/lib/perf/inclu= de/internal/evsel.h index 5cd220a61962..f8de2bf89c76 100644 --- a/tools/lib/perf/include/internal/evsel.h +++ b/tools/lib/perf/include/internal/evsel.h @@ -36,6 +36,13 @@ struct perf_sample_id { =20 /* Holds total ID period value for PERF_SAMPLE_READ processing. */ u64 period; + + /* + * When inherit is combined with PERF_SAMPLE_READ, the period value is + * per (id, thread) tuple, rather than per id, so use the stream_id to + * uniquely identify the period, rather than the id. + */ + bool period_per_thread; }; =20 struct perf_evsel { @@ -88,4 +95,6 @@ int perf_evsel__apply_filter(struct perf_evsel *evsel, co= nst char *filter); int perf_evsel__alloc_id(struct perf_evsel *evsel, int ncpus, int nthreads= ); void perf_evsel__free_id(struct perf_evsel *evsel); =20 +bool perf_evsel__attr_has_per_thread_sample_period(struct perf_evsel *evse= l); + #endif /* __LIBPERF_INTERNAL_EVSEL_H */ --=20 2.44.0 From nobody Tue Feb 10 15:43:39 2026 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 78B8E40848; Mon, 15 Apr 2024 08:15:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713168906; cv=none; b=W0Ydk9zbNbeAn4UayufTbsJbHEP8Y2ZBOWqjfGNLvX/GMy4rCgQNxpFe5IIeqRVstH6nZRQgB7jaQ4sagOWLTSG3VEF4ygU9aUMosxrQRyarSxVQXE2qRq/rGDrJGtuhJXFMVP5+v7AAKXmgKfZTXcZBCVEGXfpmBl8AdJPVIe8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713168906; c=relaxed/simple; bh=U9hIhF9fC6YL0InDSbxbfxWlnGldn0YUv9xHZRIB78E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AxZEgJvAt0J7XZ5UVTc7D67d0pMV8DvtjfQ35Nku+EGMxgQbBaA/HGN/cSVDg9TciC4uto2EixQKJztmolq4XEI8ePQN7JLjVWm9oPNhdsZUgohCB2V5istKr8ZEww2ZVKHF4ov/hNP+8SKEJWmwA9XZdD+WYk4GI5h43SIPnzc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E29932F; Mon, 15 Apr 2024 01:15:31 -0700 (PDT) Received: from e126817.cambridge.arm.com (e126817.cambridge.arm.com [10.2.3.5]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DFB1D3F64C; Mon, 15 Apr 2024 01:15:01 -0700 (PDT) From: Ben Gainey To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org Cc: james.clark@arm.com, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Gainey Subject: [PATCH v5 3/4] tools/perf: Correctly calculate sample period for inherited SAMPLE_READ values Date: Mon, 15 Apr 2024 09:14:47 +0100 Message-ID: <20240415081448.123789-4-ben.gainey@arm.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240415081448.123789-1-ben.gainey@arm.com> References: <20240415081448.123789-1-ben.gainey@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Sample period calculation is updated to take into account the fact that events with inherit+PERF_SAMPLE_READ+PERF_SAMPLE_TID should use the TID in combination with the ID field in the read_format data to identify which value represents the previous accumulated counter total used= to calculate the period delta since the last sample. perf_sample_id is modified to support tracking per-thread values, along with the existing global per-id values. In the per-thread case, values are stored in a hash by TID within the perf_sample_id, and are dynamically allocated as the number is not known ahead of time. deliver_sample_value is modified to correctly locate the previous sample storage based on the attribute, stream id and thread id. Signed-off-by: Ben Gainey --- tools/lib/perf/evsel.c | 41 ++++++++++++++++++++++ tools/lib/perf/include/internal/evsel.h | 45 +++++++++++++++++++++++-- tools/perf/util/session.c | 11 ++++-- 3 files changed, 92 insertions(+), 5 deletions(-) diff --git a/tools/lib/perf/evsel.c b/tools/lib/perf/evsel.c index f7abb879f416..26f3d7ba0f26 100644 --- a/tools/lib/perf/evsel.c +++ b/tools/lib/perf/evsel.c @@ -5,6 +5,7 @@ #include #include #include +#include #include #include #include @@ -23,6 +24,7 @@ void perf_evsel__init(struct perf_evsel *evsel, struct pe= rf_event_attr *attr, int idx) { INIT_LIST_HEAD(&evsel->node); + INIT_LIST_HEAD(&evsel->per_stream_periods); evsel->attr =3D *attr; evsel->idx =3D idx; evsel->leader =3D evsel; @@ -531,10 +533,17 @@ int perf_evsel__alloc_id(struct perf_evsel *evsel, in= t ncpus, int nthreads) =20 void perf_evsel__free_id(struct perf_evsel *evsel) { + struct perf_sample_id_period *pos, *n; + xyarray__delete(evsel->sample_id); evsel->sample_id =3D NULL; zfree(&evsel->id); evsel->ids =3D 0; + + perf_evsel_for_each_per_thread_period_safe(evsel, n, pos) { + list_del_init(&pos->node); + free(pos); + } } =20 bool perf_evsel__attr_has_per_thread_sample_period(struct perf_evsel *evse= l) @@ -544,6 +553,38 @@ bool perf_evsel__attr_has_per_thread_sample_period(str= uct perf_evsel *evsel) && evsel->attr.inherit; } =20 +u64 *perf_sample_id__get_period_storage(struct perf_sample_id *sid, u32 ti= d) +{ + struct hlist_head *head; + struct perf_sample_id_period *res; + int hash; + + if (!sid->period_per_thread) + return &sid->period; + + hash =3D hash_32(tid, PERF_SAMPLE_ID__HLIST_BITS); + head =3D &sid->periods[hash]; + + hlist_for_each_entry(res, head, hnode) + if (res->tid =3D=3D tid) + return &res->period; + + if (sid->evsel =3D=3D NULL) + return NULL; + + res =3D zalloc(sizeof(struct perf_sample_id_period)); + if (res =3D=3D NULL) + return NULL; + + INIT_LIST_HEAD(&res->node); + res->tid =3D tid; + + list_add_tail(&res->node, &sid->evsel->per_stream_periods); + hlist_add_head(&res->hnode, &sid->periods[hash]); + + return &res->period; +} + void perf_counts_values__scale(struct perf_counts_values *count, bool scale, __s8 *pscaled) { diff --git a/tools/lib/perf/include/internal/evsel.h b/tools/lib/perf/inclu= de/internal/evsel.h index f8de2bf89c76..797dc9d78254 100644 --- a/tools/lib/perf/include/internal/evsel.h +++ b/tools/lib/perf/include/internal/evsel.h @@ -11,6 +11,32 @@ struct perf_thread_map; struct xyarray; =20 +/** + * The per-thread accumulated period storage node. + */ +struct perf_sample_id_period { + struct list_head node; + struct hlist_node hnode; + /* Holds total ID period value for PERF_SAMPLE_READ processing. */ + u64 period; + /* The TID that the values belongs to */ + u32 tid; +}; + +/** + * perf_evsel_for_each_per_thread_period_safe - safely iterate thru all the + * per_stream_periods + * @evlist:perf_evsel instance to iterate + * @item: struct perf_sample_id_period iterator + * @tmp: struct perf_sample_id_period temp iterator + */ +#define perf_evsel_for_each_per_thread_period_safe(evsel, tmp, item) \ + list_for_each_entry_safe(item, tmp, &(evsel)->per_stream_periods, node) + + +#define PERF_SAMPLE_ID__HLIST_BITS 4 +#define PERF_SAMPLE_ID__HLIST_SIZE (1 << PERF_SAMPLE_ID__HLIST_BITS) + /* * Per fd, to map back from PERF_SAMPLE_ID to evsel, only used when there = are * more than one entry in the evlist. @@ -34,8 +60,18 @@ struct perf_sample_id { pid_t machine_pid; struct perf_cpu vcpu; =20 - /* Holds total ID period value for PERF_SAMPLE_READ processing. */ - u64 period; + union { + /* + * Holds total ID period value for PERF_SAMPLE_READ processing + * (when period is not per-thread). + */ + u64 period; + /* + * Holds total ID period value for PERF_SAMPLE_READ processing + * (when period is per-thread). + */ + struct hlist_head periods[PERF_SAMPLE_ID__HLIST_SIZE]; + }; =20 /* * When inherit is combined with PERF_SAMPLE_READ, the period value is @@ -65,6 +101,9 @@ struct perf_evsel { u32 ids; struct perf_evsel *leader; =20 + /* Where period_per_thread is true, stores the per-thread values */ + struct list_head per_stream_periods; + /* parse modifier helper */ int nr_members; /* @@ -97,4 +136,6 @@ void perf_evsel__free_id(struct perf_evsel *evsel); =20 bool perf_evsel__attr_has_per_thread_sample_period(struct perf_evsel *evse= l); =20 +u64 *perf_sample_id__get_period_storage(struct perf_sample_id *sid, u32 ti= d); + #endif /* __LIBPERF_INTERNAL_EVSEL_H */ diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c index 06d0bd7fb459..2c66b730780a 100644 --- a/tools/perf/util/session.c +++ b/tools/perf/util/session.c @@ -1478,14 +1478,19 @@ static int deliver_sample_value(struct evlist *evli= st, { struct perf_sample_id *sid =3D evlist__id2sid(evlist, v->id); struct evsel *evsel; + u64 *storage =3D NULL; =20 if (sid) { + storage =3D perf_sample_id__get_period_storage(sid, sample->tid); + } + + if (storage) { sample->id =3D v->id; - sample->period =3D v->value - sid->period; - sid->period =3D v->value; + sample->period =3D v->value - *storage; + *storage =3D v->value; } =20 - if (!sid || sid->evsel =3D=3D NULL) { + if (!storage || sid->evsel =3D=3D NULL) { ++evlist->stats.nr_unknown_id; return 0; } --=20 2.44.0 From nobody Tue Feb 10 15:43:39 2026 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F1F9C3F9D6; Mon, 15 Apr 2024 08:15:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713168908; cv=none; b=B6f6sCEm57oPNPc+VbY7gCr65q0JgrFVoYO/IO/sMZRsjwYL2/GGhGD1ZB95soOPvrrnQJZ6ihIlJ1RRY+x7BdbHD6QUkLcId6w7xhBqDQ0dmopC/6IpixWZ2cVMGfXn+kWxnC2pvRfns5IJYJ0KYvkeUXyHKpsEGdS+hKqmRj4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713168908; c=relaxed/simple; bh=3gjzfTH+4fjds3uBhK81w63Ko4AfYzNDlr1/LBHgbmY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bzkefMQA2GYAVIBhu290r2kCypuuw9Mh9DhczYC1Xrl9ntV0+nDyzYb9vijX5i+nEwKPj1U2EQJURq/luX5PI1JlT5bnlxE3FL7WKDQvZK1onDQM2H8c04dFsxIuhYqlR3JqfwBDFyutL0m+4MlG7SsN7QVcYzUYGnvF91l0CGo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CE581DA7; Mon, 15 Apr 2024 01:15:33 -0700 (PDT) Received: from e126817.cambridge.arm.com (e126817.cambridge.arm.com [10.2.3.5]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id CB85F3F64C; Mon, 15 Apr 2024 01:15:03 -0700 (PDT) From: Ben Gainey To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org Cc: james.clark@arm.com, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Gainey Subject: [PATCH v5 4/4] tools/perf: Allow inherit + PERF_SAMPLE_READ when opening events Date: Mon, 15 Apr 2024 09:14:48 +0100 Message-ID: <20240415081448.123789-5-ben.gainey@arm.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240415081448.123789-1-ben.gainey@arm.com> References: <20240415081448.123789-1-ben.gainey@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The tool will now default to this new mode if the user specifies a sampling group when not in system-wide mode, and when --no-inherit is not specified. This change updates evsel to allow the combination of inherit and PERF_SAMPLE_READ. A fallback is implemented for kernel versions where this feature is not supported. Signed-off-by: Ben Gainey --- tools/perf/tests/attr/README | 2 + .../tests/attr/test-record-group-sampling | 39 ------------ .../tests/attr/test-record-group-sampling1 | 50 ++++++++++++++++ .../tests/attr/test-record-group-sampling2 | 60 +++++++++++++++++++ tools/perf/tests/attr/test-record-group2 | 9 +-- tools/perf/util/evsel.c | 19 +++++- tools/perf/util/evsel.h | 1 + 7 files changed, 135 insertions(+), 45 deletions(-) delete mode 100644 tools/perf/tests/attr/test-record-group-sampling create mode 100644 tools/perf/tests/attr/test-record-group-sampling1 create mode 100644 tools/perf/tests/attr/test-record-group-sampling2 diff --git a/tools/perf/tests/attr/README b/tools/perf/tests/attr/README index 4066fec7180a..67c4ca76b85d 100644 --- a/tools/perf/tests/attr/README +++ b/tools/perf/tests/attr/README @@ -51,6 +51,8 @@ Following tests are defined (with perf commands): perf record --call-graph fp kill (test-record-graph-fp-aarc= h64) perf record -e '{cycles,instructions}' kill (test-record-group1) perf record -e '{cycles/period=3D1/,instructions/period=3D2/}:S' kill (t= est-record-group2) + perf record -e '{cycles,cache-misses}:S' kill (test-record-group-samplin= g1) + perf record -c 10000 -e '{cycles,cache-misses}:S' kill (test-record-grou= p-sampling2) perf record -D kill (test-record-no-delay) perf record -i kill (test-record-no-inherit) perf record -n kill (test-record-no-samples) diff --git a/tools/perf/tests/attr/test-record-group-sampling b/tools/perf/= tests/attr/test-record-group-sampling deleted file mode 100644 index 97e7e64a38f0..000000000000 --- a/tools/perf/tests/attr/test-record-group-sampling +++ /dev/null @@ -1,39 +0,0 @@ -[config] -command =3D record -args =3D --no-bpf-event -e '{cycles,cache-misses}:S' kill >/dev/null 2>= &1 -ret =3D 1 - -[event-1:base-record] -fd=3D1 -group_fd=3D-1 -sample_type=3D343 -read_format=3D12|28 -inherit=3D0 - -[event-2:base-record] -fd=3D2 -group_fd=3D1 - -# cache-misses -type=3D0 -config=3D3 - -# default | PERF_SAMPLE_READ -sample_type=3D343 - -# PERF_FORMAT_ID | PERF_FORMAT_GROUP | PERF_FORMAT_LOST -read_format=3D12|28 -task=3D0 -mmap=3D0 -comm=3D0 -enable_on_exec=3D0 -disabled=3D0 - -# inherit is disabled for group sampling -inherit=3D0 - -# sampling disabled -sample_freq=3D0 -sample_period=3D0 -freq=3D0 -write_backward=3D0 diff --git a/tools/perf/tests/attr/test-record-group-sampling1 b/tools/perf= /tests/attr/test-record-group-sampling1 new file mode 100644 index 000000000000..9b8730626632 --- /dev/null +++ b/tools/perf/tests/attr/test-record-group-sampling1 @@ -0,0 +1,50 @@ +[config] +command =3D record +args =3D --no-bpf-event -e '{cycles,cache-misses}:S' kill >/dev/null 2>= &1 +ret =3D 1 + +[event-1:base-record] +fd=3D1 +group_fd=3D-1 + +# cycles +type=3D0 +config=3D0 + +# default | PERF_SAMPLE_READ +sample_type=3D343 + +# PERF_FORMAT_ID | PERF_FORMAT_GROUP | PERF_FORMAT_LOST | PERF_FORMAT_TOT= AL_TIME_ENABLED | PERF_FORMAT_TOTAL_TIME_RUNNING +read_format=3D28|31 +task=3D1 +mmap=3D1 +comm=3D1 +enable_on_exec=3D1 +disabled=3D1 + +# inherit is enabled for group sampling +inherit=3D1 + +[event-2:base-record] +fd=3D2 +group_fd=3D1 + +# cache-misses +type=3D0 +config=3D3 + +# default | PERF_SAMPLE_READ +sample_type=3D343 + +# PERF_FORMAT_ID | PERF_FORMAT_GROUP | PERF_FORMAT_LOST | PERF_FORMAT_TOT= AL_TIME_ENABLED | PERF_FORMAT_TOTAL_TIME_RUNNING +read_format=3D28|31 +task=3D0 +mmap=3D0 +comm=3D0 +enable_on_exec=3D0 +disabled=3D0 +freq=3D0 + +# inherit is enabled for group sampling +inherit=3D1 + diff --git a/tools/perf/tests/attr/test-record-group-sampling2 b/tools/perf= /tests/attr/test-record-group-sampling2 new file mode 100644 index 000000000000..8e29fc13f666 --- /dev/null +++ b/tools/perf/tests/attr/test-record-group-sampling2 @@ -0,0 +1,60 @@ +[config] +command =3D record +args =3D --no-bpf-event -c 10000 -e '{cycles,cache-misses}:S' kill >/de= v/null 2>&1 +ret =3D 1 + +[event-1:base-record] +fd=3D1 +group_fd=3D-1 + +# cycles +type=3D0 +config=3D0 + +# default | PERF_SAMPLE_READ +sample_type=3D87 + +# PERF_FORMAT_ID | PERF_FORMAT_GROUP | PERF_FORMAT_LOST | PERF_FORMAT_TOT= AL_TIME_ENABLED | PERF_FORMAT_TOTAL_TIME_RUNNING +read_format=3D28|31 +task=3D1 +mmap=3D1 +comm=3D1 +enable_on_exec=3D1 +disabled=3D1 + +# inherit is enabled for group sampling +inherit=3D1 + +# sampling disabled +sample_freq=3D0 +sample_period=3D10000 +freq=3D0 +write_backward=3D0 + +[event-2:base-record] +fd=3D2 +group_fd=3D1 + +# cache-misses +type=3D0 +config=3D3 + +# default | PERF_SAMPLE_READ +sample_type=3D87 + +# PERF_FORMAT_ID | PERF_FORMAT_GROUP | PERF_FORMAT_LOST | PERF_FORMAT_TOT= AL_TIME_ENABLED | PERF_FORMAT_TOTAL_TIME_RUNNING +read_format=3D28|31 +task=3D0 +mmap=3D0 +comm=3D0 +enable_on_exec=3D0 +disabled=3D0 + +# inherit is enabled for group sampling +inherit=3D1 + +# sampling disabled +sample_freq=3D0 +sample_period=3D0 +freq=3D0 +write_backward=3D0 diff --git a/tools/perf/tests/attr/test-record-group2 b/tools/perf/tests/at= tr/test-record-group2 index cebdaa8e64e4..785892a54d9e 100644 --- a/tools/perf/tests/attr/test-record-group2 +++ b/tools/perf/tests/attr/test-record-group2 @@ -9,8 +9,9 @@ group_fd=3D-1 config=3D0|1 sample_period=3D1234000 sample_type=3D87 -read_format=3D12|28 -inherit=3D0 +read_format=3D28|31 +disabled=3D1 +inherit=3D1 freq=3D0 =20 [event-2:base-record] @@ -19,9 +20,9 @@ group_fd=3D1 config=3D0|1 sample_period=3D6789000 sample_type=3D87 -read_format=3D12|28 +read_format=3D28|31 disabled=3D0 -inherit=3D0 +inherit=3D1 mmap=3D0 comm=3D0 freq=3D0 diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 3536404e9447..557d409c53d6 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -1156,7 +1156,15 @@ void evsel__config(struct evsel *evsel, struct recor= d_opts *opts, */ if (leader->core.nr_members > 1) { attr->read_format |=3D PERF_FORMAT_GROUP; - attr->inherit =3D 0; + } + + /* + * Inherit + SAMPLE_READ requires SAMPLE_TID in the read_format + */ + if (attr->inherit) { + evsel__set_sample_bit(evsel, TID); + evsel->core.attr.read_format |=3D + PERF_FORMAT_ID; } } =20 @@ -1832,6 +1840,8 @@ static int __evsel__prepare_open(struct evsel *evsel,= struct perf_cpu_map *cpus, =20 static void evsel__disable_missing_features(struct evsel *evsel) { + if (perf_missing_features.inherit_sample_read) + evsel->core.attr.inherit =3D 0; if (perf_missing_features.branch_counters) evsel->core.attr.branch_sample_type &=3D ~PERF_SAMPLE_BRANCH_COUNTERS; if (perf_missing_features.read_lost) @@ -1887,7 +1897,12 @@ bool evsel__detect_missing_features(struct evsel *ev= sel) * Must probe features in the order they were added to the * perf_event_attr interface. */ - if (!perf_missing_features.branch_counters && + if (!perf_missing_features.inherit_sample_read && + evsel->core.attr.inherit && (evsel->core.attr.sample_type & PERF_SAMP= LE_READ)) { + perf_missing_features.inherit_sample_read =3D true; + pr_debug2("Using PERF_SAMPLE_READ / :S modifier is not compatible with i= nherit, falling back to no-inherit.\n"); + return true; + } else if (!perf_missing_features.branch_counters && (evsel->core.attr.branch_sample_type & PERF_SAMPLE_BRANCH_COUNTERS)) { perf_missing_features.branch_counters =3D true; pr_debug2("switching off branch counters support\n"); diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h index 517cff431de2..21b8b7e70e75 100644 --- a/tools/perf/util/evsel.h +++ b/tools/perf/util/evsel.h @@ -192,6 +192,7 @@ struct perf_missing_features { bool weight_struct; bool read_lost; bool branch_counters; + bool inherit_sample_read; }; =20 extern struct perf_missing_features perf_missing_features; --=20 2.44.0