From nobody Wed Feb 11 09:22:44 2026 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CC4528EB for ; Sun, 14 Apr 2024 00:34:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713054883; cv=none; b=o2eTlvzfBALgC8mY9cpbDArO+xHm5FUG4omXjbFKEH1zCdVLWSCMQoOcx6atZQHPXjGPcEncjqnkv9gItu1WSEvgLhgjxB9bAKUAaOZy17uym58GJMG6Jyk9qSU5ng+QUp8FZSDmztZMlfBkbPNWLuGKpJ83Mc22QtjI13YBQ3c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713054883; c=relaxed/simple; bh=L+hcPMDz664CiSzjx5vCeaIpcd0SuW4AkOW1T87ubao=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Hz2NgcEFalns/3/ymRaYfy40b/TcHDpOOQG0vwjWLNnHmuGwyWmuE+Jd6TdCFcODgPzcekqxQS75yLQr8auNnraak88gumlIZRSQxCxNgCx2P4gjtyqn+8Ghcuv+CU2odZ/cEZbWYZMpbVM8P1LNwI1ubl/N9/bEjy3JdtzWJEc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=orbstack.dev; spf=pass smtp.mailfrom=orbstack.dev; dkim=pass (2048-bit key) header.d=orbstack.dev header.i=@orbstack.dev header.b=T3CaZWKs; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=orbstack.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=orbstack.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=orbstack.dev header.i=@orbstack.dev header.b="T3CaZWKs" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-58962bf3f89so370993a12.0 for ; Sat, 13 Apr 2024 17:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orbstack.dev; s=google; t=1713054881; x=1713659681; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=sPkffr7oJwwppX/b4yHu5vHFxXVuD8HMrnwiaJycajs=; b=T3CaZWKs9FZtNf1QuBReuhNmCdB2z6KwCLivsVd8+Tj+JNeBLndh8WoFUHGdSUEfe9 eUT11iYt1fyYF0ZVZCLJUbv8geY5QA20HiNDmDvHOLXvdi45M/MZvQw4tO1bKwRE2cuC 3yS50l1RJJtPvLg3xRVDFjwfkYpcfAds/iZEU/hGwFOIHkGnJmyDXM72fAsb8zeGOIMg P4jCM+xdCKC2lucEWueigZF9Hr52sn2Fqymm6Pg+h6vyqKhPh9F2GKfMn63Gs59YEYNc QWZhKIswb4doWlCuUU0nPtY3dPPxR3N6Y0zt29CJaYN6lMo7JmCnqrY4tDudas3wo3pW cVrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713054881; x=1713659681; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sPkffr7oJwwppX/b4yHu5vHFxXVuD8HMrnwiaJycajs=; b=FH1E5yGysLDJzB3cKXMGsULCouT0UKXRYAWZpN5xnp+cn3HwpI33JHv2KFhtgUJbZJ VRyWIoQmVbfpbZGmfplzMitH7YZj8u/0rlkXIuZer3ozn/DBAYNfpa+P0lkba8JB3GDZ bIlmKL/CY+c+qx8gKnXom2oCgW6PKdCDsAwH+BnrzzO77euwAJwjXGRbs5f6UIhWEao8 UPqJp1eT8egXds+5UTQP1/vLUhDPFapojhrgl8aJ5MDt6ZiL4XhbbPxl8xsTn7aAZKs6 zsC3OKQP4qbEbdUGWKPNJoczjvtpfpN7vimzpR0z2PhbrfusbHfMukkY136YfPvyrt6L zubw== X-Forwarded-Encrypted: i=1; AJvYcCWkkHTHSZ6flvt2AK5ePH8OcEf/+iXGi8k3ynRO3fACwa86Y6DsjoVSGDBhHW2xWk9VRIyckcjYBoSVe6x4FWQup4PpEXCvpZOwnrdu X-Gm-Message-State: AOJu0Yy9OCUOcRDHEhET+/nnbeOeW8TWZOpZ39STxcIpppB+WfkC4kmH 97g86Yiz3jXMVPidoh3NVyIjxSs/DGPeMu0gp4u3+rqq/LEuaEsk4vrycJT0kD4= X-Google-Smtp-Source: AGHT+IGZ6S8G0CCgNd4/Hh9ER28bC30ZT6Nn8CO+e7t8gmRLHN84YqdmTld2xWVSDkY17bs6yi8PWg== X-Received: by 2002:a17:902:f682:b0:1dd:e128:16b1 with SMTP id l2-20020a170902f68200b001dde12816b1mr7760259plg.6.1713054880697; Sat, 13 Apr 2024 17:34:40 -0700 (PDT) Received: from arch.. ([68.65.175.34]) by smtp.gmail.com with ESMTPSA id n16-20020a17090aab9000b002a46c730a5csm4646143pjq.39.2024.04.13.17.34.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Apr 2024 17:34:40 -0700 (PDT) From: Danny Lin To: danny@orbstack.dev Cc: stable@vger.kernel.org, Miklos Szeredi , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] fuse: fix leaked ENOSYS error on first statx call Date: Sat, 13 Apr 2024 17:34:31 -0700 Message-ID: <20240414003434.2659-1-danny@orbstack.dev> X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" FUSE attempts to detect server support for statx by trying it once and setting no_statx=3D1 if it fails with ENOSYS, but consider the following scenario: - Userspace (e.g. sh) calls stat() on a file * succeeds - Userspace (e.g. lsd) calls statx(BTIME) on the same file - request_mask =3D STATX_BASIC_STATS | STATX_BTIME - first pass: sync=3Dtrue due to differing cache_mask - statx fails and returns ENOSYS - set no_statx and retry - retry sets mask =3D STATX_BASIC_STATS - now mask =3D=3D cache_mask; sync=3Dfalse (time_before: still valid) - so we take the "else if (stat)" path - "err" is still ENOSYS from the failed statx call Fix this by zeroing "err" before retrying the failed call. Fixes: d3045530bdd2 ("fuse: implement statx") Cc: stable@vger.kernel.org # v6.6 Signed-off-by: Danny Lin --- fs/fuse/dir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c index de452cdbf3cf..a63125ce70a4 100644 --- a/fs/fuse/dir.c +++ b/fs/fuse/dir.c @@ -1362,6 +1362,7 @@ static int fuse_update_get_attr(struct inode *inode, = struct file *file, err =3D fuse_do_statx(inode, file, stat); if (err =3D=3D -ENOSYS) { fc->no_statx =3D 1; + err =3D 0; goto retry; } } else { --=20 2.44.0