From nobody Fri Feb 13 06:58:53 2026 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.4]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EE94F1C2A5 for ; Sat, 13 Apr 2024 11:50:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.4 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713009048; cv=none; b=D0uQq3V3Y4snNMBjl1sTi69/6IOwbNIiCDVPcotdJkD8zwJ7YxNKlVjU8YG10+WqSfXtA9ZvWrkNDe1EACmKWG6w/oee6fgpRjelFl786LMtYIWK5HPb9OCcJvqxvNc+UJhjgtSXnxVH8IzmCEzTSXYS2AM5rH9eeI0H8yz1Llo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713009048; c=relaxed/simple; bh=PtC7jHiLyTKBTG9iP7AvPgc+6ZXScdOk3HuslgLZ8wE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=YeEFbdFq1r1q/xJbVpYP49ML7zmsLtYmqapQ2NjB2Ov3r9XiWghkeIIIaCw7gH7U8zL9BjYhUj0jwOxEfLfXy2/ad/AlhR/afTHkbsWObDsI8qD8gylOb3ibI6ogaxmFRuPP1L9kKPSiO5R2xbUzS83Y9mbCU5rUJdriIlgt/Hw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=UPNMQpXN; arc=none smtp.client-ip=117.135.210.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="UPNMQpXN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=C/i+R Nq5Pzo3i3TYLnj/DsICAobD6rQqS8xqCwClBB8=; b=UPNMQpXNGkCqNPfm/uiqr 2JLtqx5FZ36szmAX/TW6XXOB3u/8XlO7c1ZjCSGYrO542eBkWiM9MfDktyvIqC9w NfF9P5APJbRxV5gLjeh2MHduBSbPEPpeQOolaVPxVYgvglUD9sO0rfvbCpsIBf+9 NBiH31uQOjv+9dDiQgAofE= Received: from ProDesk.. (unknown [58.22.7.114]) by gzga-smtp-mta-g3-5 (Coremail) with SMTP id _____wD3n+hVcRpmDvQVBA--.50814S2; Sat, 13 Apr 2024 19:49:45 +0800 (CST) From: Andy Yan To: boris.brezillon@collabora.com Cc: daniel@ffwll.ch, airlied@gmail.com, liviu.dudau@arm.com, maarten.lankhorst@linux.intel.com, steven.price@arm.com, tzimmermann@suse.de, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Andy Yan Subject: [PATCH] drm/panthor: Add defer probe for firmware load Date: Sat, 13 Apr 2024 19:49:38 +0800 Message-Id: <20240413114938.740631-1-andyshrk@163.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wD3n+hVcRpmDvQVBA--.50814S2 X-Coremail-Antispam: 1Uf129KBjvdXoWruryxWryrCr4fKF1rKw1kuFg_yoWDtwc_CF 4jyr1fXw48Ga4qqF1vka129Fy2kF4rZF1kZanYq34fCrnrGasrt39Fqry3W3y5WF10vasr ua4UXr40krW7CjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU84v3UUUUUU== X-CM-SenderInfo: 5dqg52xkunqiywtou0bp/xtbBEBu-XmVODWy+XAABsD Content-Type: text/plain; charset="utf-8" From: Andy Yan The firmware in the rootfs will not be accessible until we are in the SYSTEM_RUNNING state, so return EPROBE_DEFER until that point. This let the driver can load firmware when it is builtin. Signed-off-by: Andy Yan --- drivers/gpu/drm/panthor/panthor_fw.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor= /panthor_fw.c index 33c87a59834e..25e375f8333c 100644 --- a/drivers/gpu/drm/panthor/panthor_fw.c +++ b/drivers/gpu/drm/panthor/panthor_fw.c @@ -1336,8 +1336,17 @@ int panthor_fw_init(struct panthor_device *ptdev) } =20 ret =3D panthor_fw_load(ptdev); - if (ret) + if (ret) { + /* + * The firmware in the rootfs will not be accessible until we + * are in the SYSTEM_RUNNING state, so return EPROBE_DEFER until + * that point. + */ + if (system_state < SYSTEM_RUNNING) + ret =3D -EPROBE_DEFER; + goto err_unplug_fw; + } =20 ret =3D panthor_vm_active(fw->vm); if (ret) --=20 2.34.1