From nobody Sun Feb 8 18:39:20 2026 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C14A3205E0D for ; Thu, 11 Apr 2024 21:17:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712870276; cv=none; b=JrMfd3P+qcEUBzl6j7u5AIAZOJGciIzR/mWBd48+yfAUbes1ttM0jecnnaMMeHtXm/wIQ/WzOs9IzCh4nG24SWRVM8PdygFHfExJS6ZBAO7ctXu5NsNTttKYTW7+h+JHRNwYIGL6tH2oOKN3//Op+0veSpWYCzYO72bDxU/TMgU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712870276; c=relaxed/simple; bh=ulv1JL7xWZsExyNUt9ao2hlmY9qTFZqMDhceV7YHm44=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kddPEyTyuLQ4sdCqPBxl+Tc8q+6jt0kN9EONJo5GInw+/vPuOvRZgWW5YuLjJz7w6MvZ2W5slycsYwEydEcqtOuirNgFxdxmUOeedfhDxpFRlEtLENO94Q8QhdemXynVo4OAAnfV6tjPUxm71manng4OLiAdG+x79aRxX+Uspyc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=UMJglONx; arc=none smtp.client-ip=209.85.160.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="UMJglONx" Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-434a76386feso1834821cf.1 for ; Thu, 11 Apr 2024 14:17:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1712870274; x=1713475074; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=KJkkcaX8CIYhd9XR8ScMRJRxMuN5zFK8kc96J/lpLIM=; b=UMJglONx7J8e4urvd2gDSLQDRIBrZp7O+Vx3DRJ8eoB2BWOQUMOHmxIFdq4iTFbwfv cS5iPNta+LHLy3EZNaeVeYip+AHjYoiRqkKkOCdRGrDW1PhV2NrxXdLcAVC1T+UJ7HYL iNbFgxps236tOIgf31Fpjm4GAXnR+GN3POcnI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712870274; x=1713475074; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KJkkcaX8CIYhd9XR8ScMRJRxMuN5zFK8kc96J/lpLIM=; b=CUOa8o0exp+arTlLkiAeiev9BskecJPPw0GZFkCO3Gw6HAM4ODMZKGobvbj92xlLBY d+nDaKF4rdbgC5bCRuC51wqwy8kagPlghazhz08Hj4QBXSWE8csq+NYN43fUN1QxAXpw mkM+VPyk67nzrxlZF/8ivuaTi4DAnp8RJT3qKlqteoDhQNfSfOlXzCp26adMHXNAWppy ZZYFjgfuS6Nn9Xp9NoUZZZhAcivzWYwRbwc1b4ntmGLwYRyIX9M/Z/phVjzQE7NuyuVO SeXKYKMrj4f/YgPqvTp6+XJShPW4CaUXUNQ07ighJw2uI11aF61etdecLXpwj0vKD/gG NzFw== X-Forwarded-Encrypted: i=1; AJvYcCV+iLgTfepY245FpYXOXbk36r1Twedie/ycaVFcvtFqBRutkbtK8fcefRMqL+xkzeSpqxAfX6XsreD7T3EU0BS4LCHUxRM0Tq8JJRpr X-Gm-Message-State: AOJu0YxInFaJkD3TzBW6CBxGYvosWuB3Su1V1p91JLTE3pauPkGISRwT TuwbG+8Jdb8TzO4I53D3kRUnsGrW6VYaDERR0vtt9V4k91QF51f/PjLQdhieIw== X-Google-Smtp-Source: AGHT+IFTnqRZcteRINuntinTUGBmdgsxI+3hZuPuD7cseAqS47blu7YOY7bCkvUON9r8YSt9U/Nl/Q== X-Received: by 2002:a05:622a:107:b0:434:68f6:ae2a with SMTP id u7-20020a05622a010700b0043468f6ae2amr1066381qtw.16.1712870273700; Thu, 11 Apr 2024 14:17:53 -0700 (PDT) Received: from denia.c.googlers.com (200.234.86.34.bc.googleusercontent.com. [34.86.234.200]) by smtp.gmail.com with ESMTPSA id k20-20020ac84794000000b00434d7c4f9fasm1373362qtq.8.2024.04.11.14.17.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 14:17:52 -0700 (PDT) From: Ricardo Ribalda Date: Thu, 11 Apr 2024 21:17:50 +0000 Subject: [PATCH 1/7] media: solo6x10: Use pcim functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240411-fix-smatch-v1-1-045f92467937@chromium.org> References: <20240411-fix-smatch-v1-0-045f92467937@chromium.org> In-Reply-To: <20240411-fix-smatch-v1-0-045f92467937@chromium.org> To: Bluecherry Maintainers , Anton Sviridenko , Andrey Utkin , Ismael Luceno , Mauro Carvalho Chehab , Patrice Chotard Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ricardo Ribalda X-Mailer: b4 0.12.4 Instead of handling manually the release of the memory regions let devm do that for us. Makes smatch happy: drivers/media/pci/solo6x10/solo6x10-core.c:631 solo_pci_probe() warn: 'pdev= ' from pci_request_regions() not released on lines: 631. Signed-off-by: Ricardo Ribalda --- drivers/media/pci/solo6x10/solo6x10-core.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/media/pci/solo6x10/solo6x10-core.c b/drivers/media/pci= /solo6x10/solo6x10-core.c index 6d87fbb0ee04a..abf30b7609e17 100644 --- a/drivers/media/pci/solo6x10/solo6x10-core.c +++ b/drivers/media/pci/solo6x10/solo6x10-core.c @@ -145,10 +145,8 @@ static void free_solo_dev(struct solo_dev *solo_dev) /* Now cleanup the PCI device */ solo_irq_off(solo_dev, ~0); free_irq(pdev->irq, solo_dev); - pci_iounmap(pdev, solo_dev->reg_base); } =20 - pci_release_regions(pdev); pci_disable_device(pdev); v4l2_device_unregister(&solo_dev->v4l2_dev); pci_set_drvdata(pdev, NULL); @@ -480,15 +478,10 @@ static int solo_pci_probe(struct pci_dev *pdev, const= struct pci_device_id *id) pci_write_config_byte(pdev, 0x40, 0x00); pci_write_config_byte(pdev, 0x41, 0x00); =20 - ret =3D pci_request_regions(pdev, SOLO6X10_NAME); + ret =3D pcim_iomap_regions(pdev, BIT(0), SOLO6X10_NAME); if (ret) goto fail_probe; - - solo_dev->reg_base =3D pci_ioremap_bar(pdev, 0); - if (solo_dev->reg_base =3D=3D NULL) { - ret =3D -ENOMEM; - goto fail_probe; - } + solo_dev->reg_base =3D pcim_iomap_table(pdev)[0]; =20 chip_id =3D solo_reg_read(solo_dev, SOLO_CHIP_OPTION) & SOLO_CHIP_ID_MASK; --=20 2.44.0.683.g7961c838ac-goog From nobody Sun Feb 8 18:39:20 2026 Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5762E36AEF for ; Thu, 11 Apr 2024 21:17:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712870276; cv=none; b=H8qComAmqhFP1pFbMYEWsoitQ/AQu+SIAhOgOM2ldaZ6pvcwPMBHEIjpHJCRFvDsXJRi3sZaPUIfOimYQxIBQiJogQxcalgP8ult1qtc6YhINf3bILxxYU5lLbrYZtnGY2WveAAuGnbE2xiixeOFX/BAagVEs1gMjHMgvJNUJ9A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712870276; c=relaxed/simple; bh=ufd7B+p2FkYNpk8qLtjfnLDHP5pTTghrh6j0nvh6z8w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PeCe0QNCDprDBquOB5jW47jB1rMjUK2YwQCoUvU5hRA9KTdAJqQMYFET+K3z43/iuWlLn+AeAcOztU0ArtQ8u1zbWIz69u9JBxUteiM06x1ztsYi7wjOZ/oS73JIv+PlddRID/1vxFRU0AcEkG5aJhLMAYLU81/mYceS4YmMiI8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=UxxTBHrH; arc=none smtp.client-ip=209.85.167.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="UxxTBHrH" Received: by mail-oi1-f182.google.com with SMTP id 5614622812f47-3c3aeef1385so136709b6e.3 for ; Thu, 11 Apr 2024 14:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1712870274; x=1713475074; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=A4R8SNBXJ275CXC4IwKn1Nf9LGrTrEst208ivldsCOI=; b=UxxTBHrHcEKj9qrhNBiFUPaGnqdS/+eENZ2ttbwLqITLIKri0XMmg6AKrgp4gGJhuZ EH3AOdhoM/HLqiS6kg7WC5Yh31ZKxUSvPczi2LQqpPKhH9TTCxw/oK3SUmokervwXr/z 16CGv6lHerxMx1binx3punJNY74MwyI4k0NCQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712870274; x=1713475074; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A4R8SNBXJ275CXC4IwKn1Nf9LGrTrEst208ivldsCOI=; b=Mn+DNiIabdyCnAwRyd3WWB5KClkU6Uhf0yjqa9vRqqGSDD/L+bUQBrVUR+njihroDV u0WIF5zrxdexKCu3/+eaLY+Q5qVzjOBSs3opPfJEWw2qyKxCCukMjU02/UZCZfxzMsBy UAGKlCwV6s3uRG1n+LVYSO8POidslFclHhLgHUMCxP827q7PI0x69EYbO9JcHYUZp0rf 0pUFjKMhM6mhvPlQmE0AI4qLHP0LL+uCt7b9qVB8kEkKc3vIwoxln6o+Sp3MwycWoNVf bc7vBdgGpvnK49bQ0SMF7vYIAODDvbO+g3ysoXGXkb07h/yx4yTqBl0wCan7tEBwvgEV diSw== X-Forwarded-Encrypted: i=1; AJvYcCWz2mIepaNDxfC4mbLC+FGOzlBGMHrJPeckhw5Lw5Knj7FNYI9OxLzqGgBK0e5UkCd9xYD3RArJjcRebGXlfbpemeIbEUXAI101FkyG X-Gm-Message-State: AOJu0YxZfqQA1NKGsBsKQ0lyjjOvISnId7J8ONpOmjphLVeHq4fDineN /cR5PzjamQgqNpgLXRp6oWPrk+MASLjdUkkR+wPQfwrhaq84C851Y3eO1vBceohbUnTkDPTa3IN 9sg== X-Google-Smtp-Source: AGHT+IEC1vdgwkjJJheMAKozxbMmu/L/tTm4eEGL7yncy97G5OW/5qnYsDss86EcRfqPSpyjplNl8g== X-Received: by 2002:a05:6808:1cf:b0:3c4:f70b:7755 with SMTP id x15-20020a05680801cf00b003c4f70b7755mr793202oic.20.1712870274492; Thu, 11 Apr 2024 14:17:54 -0700 (PDT) Received: from denia.c.googlers.com (200.234.86.34.bc.googleusercontent.com. [34.86.234.200]) by smtp.gmail.com with ESMTPSA id k20-20020ac84794000000b00434d7c4f9fasm1373362qtq.8.2024.04.11.14.17.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 14:17:54 -0700 (PDT) From: Ricardo Ribalda Date: Thu, 11 Apr 2024 21:17:51 +0000 Subject: [PATCH 2/7] media: solo6x10: Use devm functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240411-fix-smatch-v1-2-045f92467937@chromium.org> References: <20240411-fix-smatch-v1-0-045f92467937@chromium.org> In-Reply-To: <20240411-fix-smatch-v1-0-045f92467937@chromium.org> To: Bluecherry Maintainers , Anton Sviridenko , Andrey Utkin , Ismael Luceno , Mauro Carvalho Chehab , Patrice Chotard Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ricardo Ribalda X-Mailer: b4 0.12.4 Let devm handle the life cycle of the irq request. Makes smatch happier: drivers/media/pci/solo6x10/solo6x10-core.c:631 solo_pci_probe() warn: 'pdev= ' from pci_request_regions() not released on lines: 631. Signed-off-by: Ricardo Ribalda --- drivers/media/pci/solo6x10/solo6x10-core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/pci/solo6x10/solo6x10-core.c b/drivers/media/pci= /solo6x10/solo6x10-core.c index abf30b7609e17..1a9e2bccc4136 100644 --- a/drivers/media/pci/solo6x10/solo6x10-core.c +++ b/drivers/media/pci/solo6x10/solo6x10-core.c @@ -144,7 +144,6 @@ static void free_solo_dev(struct solo_dev *solo_dev) =20 /* Now cleanup the PCI device */ solo_irq_off(solo_dev, ~0); - free_irq(pdev->irq, solo_dev); } =20 pci_disable_device(pdev); @@ -544,8 +543,8 @@ static int solo_pci_probe(struct pci_dev *pdev, const s= truct pci_device_id *id) /* PLL locking time of 1ms */ mdelay(1); =20 - ret =3D request_irq(pdev->irq, solo_isr, IRQF_SHARED, SOLO6X10_NAME, - solo_dev); + ret =3D devm_request_irq(&pdev->dev, pdev->irq, solo_isr, IRQF_SHARED, + SOLO6X10_NAME, solo_dev); if (ret) goto fail_probe; =20 --=20 2.44.0.683.g7961c838ac-goog From nobody Sun Feb 8 18:39:20 2026 Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C91AD3B2A8 for ; Thu, 11 Apr 2024 21:17:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712870278; cv=none; b=raN9Ni3wvwbz/VTr3cHOPWmgDw3O7js0HNykSeQ5JynJRky4Mt779g2VKGsMILrheW3nbO+gP9czpD1Nub5B5otZaBPBkV8zsLAQwL0h013f2iClhkCxAEm780xXb68d6RjDb7/8wGw/w5kvHLe0Xf4hfxVJSMa6T6+h0VCUbvc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712870278; c=relaxed/simple; bh=hqC8XsEkIIDvzCq8ORFwWKB0b/ku6Day+SYeCNMIfRs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Y8SzUNJeLCOLZJsQgfLl4ydy3c+vxi9jdcjWMHLrE3WNk4PZ+dlcYVYlxk2MM8Y3SQS2g0w9JKhAFsccD/iGPMKMs97KAM3WELeAGgajrPaCe4ryOuzP9SuIGR9IJFJAz2VmspHV2JIAp62UhbsVNxB7xKjR/KUY9kAk4opw++Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Rn5BPnCb; arc=none smtp.client-ip=209.85.161.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Rn5BPnCb" Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-5aa1b7a37b5so178493eaf.2 for ; Thu, 11 Apr 2024 14:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1712870276; x=1713475076; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Lp9xnoohaSw2cIC3dXNX7smv9LqAayoL7R0pHvEFgA4=; b=Rn5BPnCbOscHe0u3kHyjlv9o2Jn0Zntz4D2J0C18f0NWorJ6IkhhdenO98E4uDPmyE 5BVeDPyrYzxNaKqc5SxJFosUHQfpriYOHi5VBC68RrVN/6QLTCHu/PvCG9yXF0wxmU4m guXWLU9a5FNuJnEL1g8JRJ2Cfst1eeQ23JXns= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712870276; x=1713475076; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Lp9xnoohaSw2cIC3dXNX7smv9LqAayoL7R0pHvEFgA4=; b=NihPtLT+LuzW2GTxlngUkeGZ5PimXJkL2uZMNmjCW8l427Y7ZZpHQSjYFTbh8CycUB FbuxiyNhm7OJBLH9qGeFIcnXBe1zx+5yfYy5B5LCl36WlUPlAOwG++GgftDj5+iQqm33 jgRfMFG9LYQ52z4Xe1Am9bcCwwNLS9HoJtsNAd9fI/DEq7RGD2zh1nGT98cC0QEbpE3g mIfw8iuoo5vJmV/nnF5KGR/3Swv2ud6w6wOU7ymHB9D+UZ/5a+9iIYE8mOEO9yivIEOm y6/ab9EBx6JIM+wy8KDVEPOIgKWwRo+9MoHSufLjIvD1jPaUBz3erojjxSmPs3kdrnYp MpyA== X-Forwarded-Encrypted: i=1; AJvYcCUKcm++6OsoHFBuDgHux64+Y/f1qF1o7egnDSGwULWCVDCjRp9vBvx1WwKMO8SAqXFwVWd4tkJa1+3X+sXUcAyeI+JB0vm2Try04+vX X-Gm-Message-State: AOJu0YzNipj5rKlNTc+z0tKigAaVdlGBN1dJ3+VFWVN/z6T5W/2pV0BS Up26ZiOq0SXH8mJOijBKThOxi7ndCedbXNEKyywCiMxGtx1zlwbCemrBgBkPKkuxa++DzCXIwZe CVw== X-Google-Smtp-Source: AGHT+IH3PJPjNl18QWxefWFNkOVbJgNcIMMPhh3UNIigB6AYGmwgvHF3AHr6NydkhiUfqoz4uLkfNA== X-Received: by 2002:a05:6358:838c:b0:183:7f41:8c10 with SMTP id c12-20020a056358838c00b001837f418c10mr339839rwk.31.1712870275864; Thu, 11 Apr 2024 14:17:55 -0700 (PDT) Received: from denia.c.googlers.com (200.234.86.34.bc.googleusercontent.com. [34.86.234.200]) by smtp.gmail.com with ESMTPSA id k20-20020ac84794000000b00434d7c4f9fasm1373362qtq.8.2024.04.11.14.17.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 14:17:55 -0700 (PDT) From: Ricardo Ribalda Date: Thu, 11 Apr 2024 21:17:52 +0000 Subject: [PATCH 3/7] media: saa7134: Use devm_request_irq Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240411-fix-smatch-v1-3-045f92467937@chromium.org> References: <20240411-fix-smatch-v1-0-045f92467937@chromium.org> In-Reply-To: <20240411-fix-smatch-v1-0-045f92467937@chromium.org> To: Bluecherry Maintainers , Anton Sviridenko , Andrey Utkin , Ismael Luceno , Mauro Carvalho Chehab , Patrice Chotard Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ricardo Ribalda X-Mailer: b4 0.12.4 The handled version of request_irq let us remove the free_irq and makes smatch happier: drivers/media/pci/saa7134/saa7134-alsa.c:1186 alsa_card_saa7134_create() wa= rn: 'dev->pci->irq' from request_irq() not released on lines: 1186 Signed-off-by: Ricardo Ribalda --- drivers/media/pci/saa7134/saa7134-alsa.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/media/pci/saa7134/saa7134-alsa.c b/drivers/media/pci/s= aa7134/saa7134-alsa.c index d3cde05a6ebab..dd2236c5c4a17 100644 --- a/drivers/media/pci/saa7134/saa7134-alsa.c +++ b/drivers/media/pci/saa7134/saa7134-alsa.c @@ -1096,9 +1096,6 @@ static void snd_saa7134_free(struct snd_card * card) if (chip->dev->dmasound.priv_data =3D=3D NULL) return; =20 - if (chip->irq >=3D 0) - free_irq(chip->irq, &chip->dev->dmasound); - chip->dev->dmasound.priv_data =3D NULL; =20 } @@ -1147,10 +1144,8 @@ static int alsa_card_saa7134_create(struct saa7134_d= ev *dev, int devnum) chip->iobase =3D pci_resource_start(dev->pci, 0); =20 =20 - err =3D request_irq(dev->pci->irq, saa7134_alsa_irq, - IRQF_SHARED, dev->name, - (void*) &dev->dmasound); - + err =3D devm_request_irq(&dev->pci->dev, dev->pci->irq, saa7134_alsa_irq, + IRQF_SHARED, dev->name, &dev->dmasound); if (err < 0) { pr_err("%s: can't get IRQ %d for ALSA\n", dev->name, dev->pci->irq); --=20 2.44.0.683.g7961c838ac-goog From nobody Sun Feb 8 18:39:20 2026 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 903843E462 for ; Thu, 11 Apr 2024 21:17:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712870280; cv=none; b=QgZ4rc7xqZIsVHvEiMGx+Ngis/sQydN/TPHzMF1WnYQ0rREbnDeP0XxnEeQ72PlDfl5MI2ItTxCDJeeAWQTyQQ5hkEebA2z3gk8l4mI+YvyGXb9CqsKuASP2zhkdRi/JVq/FZU1gkgm8+dMHvpgBYApxuUlCh1kiPICRmc4dUlQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712870280; c=relaxed/simple; bh=jVTlH6xfXoB6FESZXfYYk6pPpl6OaLfHd2BNU/Y9GQU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dCIqM9tbtJNczkRRdyIQVhv/7CM4LpIihEomM4iPjvil2ut3RCMRjL/wHHWaB6S4mrxOp0v4qM1T7mTJSpmZVQDHB8ZxMnl+Fbg6ioqU7utzHrM2SRccSIvha4tnuehVelJpPbhjyCdNucT/82VAVPlydtSZlMSNYic3Iau/wW8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Tc3ha5I9; arc=none smtp.client-ip=209.85.160.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Tc3ha5I9" Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-43651b7004bso1522451cf.1 for ; Thu, 11 Apr 2024 14:17:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1712870277; x=1713475077; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TL6JnALE0FuyaUB3vxEn5mmMwRa1J5olT0hONBuxBN8=; b=Tc3ha5I97/v6Oelp3/EyyzXlyuwIlYoEN8/V4u36Cv+ClIxOJ72jDg2dny8L0jIuqo M8c2HwBoKlo8lQecZDp6VFv8YIQMxhTd3lioZp5SPHsSnHS725uO1v5Rkg4t1Kq/Y6La DHOox7fUZaYMAf2JZiQW3G1omxGWo4EMVyctA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712870277; x=1713475077; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TL6JnALE0FuyaUB3vxEn5mmMwRa1J5olT0hONBuxBN8=; b=QYoXoyLu4OUuLktrIQKK+awrSg5WsJkU5Naujr+jXfpFtDLnEv4pHnhGHn3ie0wW6C l/cx/n4jpYh31wy1iCRy269qBPSpg1hVzgtRaopifyovsu9EiNiAo2EJQyvAWlN5JDUv ZmfpG/JXtlfb2siSKn5HWYROxNgzsU3AU1bRs9Mq0I+A2bMH6cEXAvCaT7LQa1zjNHPg utZr4/vQ/VsUh3yjo8U4RVdWgBd2eemwFGJClaJq9iuQwkry7hKhl748kvn1190zgTYl mRD3brM/O5hBSyhSoH1tkWSvvkAH2xVKeGkzQ9aDeHI++YXlr8VfNJm3mOnCJeRGdN3s UGJg== X-Forwarded-Encrypted: i=1; AJvYcCVlauGiAMTGmNIG1pc1W4/FkQv4OGO8/VZonhYd/TQmAGBPQqEqqoQU+gqJuPyg+fDEepZ7IsuP+RiygDFvlpNrkGGlgBHBRrNlLL/u X-Gm-Message-State: AOJu0YwsOLOw5UX583fT0Bsn45C0Tl+S59Z8M2K5dwNdbKE9cSOjZIzi 4cZAlGy2e9ck6VlYw0mcJLi5GEvBfermuOzC334LMg1/nnSOdcJHiylSlh6eSw== X-Google-Smtp-Source: AGHT+IE1U/PUZQGaG+rxwc5mHpekiX8Y0J1WJQ10omBwhTFJ78n8RVlNr6NTsPRSnF/PRA/dbuDuOg== X-Received: by 2002:a05:622a:1897:b0:436:89bf:5706 with SMTP id v23-20020a05622a189700b0043689bf5706mr270247qtc.17.1712870277703; Thu, 11 Apr 2024 14:17:57 -0700 (PDT) Received: from denia.c.googlers.com (200.234.86.34.bc.googleusercontent.com. [34.86.234.200]) by smtp.gmail.com with ESMTPSA id k20-20020ac84794000000b00434d7c4f9fasm1373362qtq.8.2024.04.11.14.17.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 14:17:56 -0700 (PDT) From: Ricardo Ribalda Date: Thu, 11 Apr 2024 21:17:53 +0000 Subject: [PATCH 4/7] media: c8sectpfe: Refactor load_c8sectpfe_fw Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240411-fix-smatch-v1-4-045f92467937@chromium.org> References: <20240411-fix-smatch-v1-0-045f92467937@chromium.org> In-Reply-To: <20240411-fix-smatch-v1-0-045f92467937@chromium.org> To: Bluecherry Maintainers , Anton Sviridenko , Andrey Utkin , Ismael Luceno , Mauro Carvalho Chehab , Patrice Chotard Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ricardo Ribalda X-Mailer: b4 0.12.4 release_firmware() in the same function that it was requested. It is more clear and makes smatch happy. drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c:1146 load_c8sectpf= e_fw() warn: 'fw' from request_firmware() not released on lines: 1125,1132. Signed-off-by: Ricardo Ribalda --- drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c b/dri= vers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c index e4cf27b5a0727..ce0fd6ace8032 100644 --- a/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c +++ b/drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c @@ -1097,7 +1097,6 @@ static int load_slim_core_fw(const struct firmware *f= w, struct c8sectpfei *fei) } } =20 - release_firmware(fw); return err; } =20 @@ -1121,6 +1120,7 @@ static int load_c8sectpfe_fw(struct c8sectpfei *fei) } =20 err =3D load_slim_core_fw(fw, fei); + release_firmware(fw); if (err) { dev_err(fei->dev, "load_slim_core_fw failed err=3D(%d)\n", err); return err; --=20 2.44.0.683.g7961c838ac-goog From nobody Sun Feb 8 18:39:20 2026 Received: from mail-oo1-f46.google.com (mail-oo1-f46.google.com [209.85.161.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 371D13FB0F for ; Thu, 11 Apr 2024 21:17:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712870280; cv=none; b=CpHMuLOBtQfJxAPr3FcL2geTZ4mOZLcJdVqu8hz79oRvkZaF2LCcIIza+gNRDZsrj/rfINtood+zQ509ed0i5RDc3DEh0oDFLr778Eb+Z17N2wFxGD05lvecRu3vv0044HvdE5F/a1YYNlKuOxajUabrBt40QWf+7IvcXsnBuFY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712870280; c=relaxed/simple; bh=dp4RMhErGFhr4bpB4GWRG+LeS25vv/r3I5ywr16IJEQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Z9I2ayxoPzDDxjdjdejGzKDXavver+f/Xgi2lDww39gVhMdKdy1phWPlz3JINTxD15ZbWTSSJJsu4nDQIJAZrwHwgWX1FvuHHil71R0RYDnjg8K3lzGws9enGPY4ZEWDN0DY99Se8USWdU+wMzsbP7yrFWSQvm0cLDDHPDDhV4A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=ntrkH0K0; arc=none smtp.client-ip=209.85.161.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ntrkH0K0" Received: by mail-oo1-f46.google.com with SMTP id 006d021491bc7-5aa1b7a37b3so180588eaf.0 for ; Thu, 11 Apr 2024 14:17:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1712870278; x=1713475078; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7uKL1mHSZL4YF4kY3BJqD6MsU90syv43Ru49OzukfDM=; b=ntrkH0K086JJwfBHvGT5bb5VuGHKzxCZeV+zfZjg9H/AZdpOIBuvUBnFqqiE4Gzdu7 /TfWC86WGODUY5y7LbE5XimrOgNAg9qwRaxzK0yDKN8yikvlUcZVfXOY+I2MDtbohfKx sKuEWleuiHBybEx64rdHSYKamoQK0IgBIAqYY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712870278; x=1713475078; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7uKL1mHSZL4YF4kY3BJqD6MsU90syv43Ru49OzukfDM=; b=vRKqOtE2snS14F3Xz5HtuTN+33/k4DS1dAM+r+3m+8YwJn5rDjig+QdaTvkAuPY3K+ vTLaty4Ejz8xcgjT/81vSbERNrDNIeAotD6Cr/+POSPr2lIaOIZuastMn6bDhNzvkyjN B4UqCvxnKm+gB248vh31BWBvc1XQxPG0Y06fH5jSt6p1mUyhqVJEEat3ih+FYpzoJzVR Jfv8JAHDgL0ezl12CPY0S7+NaWWen8WykEcG0d+JZOYj3ysFXUBBAZ8S1888qbIa1I+g 2ms0+kqAaQ3obZ9AuOV+8+IHWXPhUnCrAL9dIoumTTL97WjkfoNiUOir2lg5F4ASiX8M Pouw== X-Forwarded-Encrypted: i=1; AJvYcCXVzWWlaLqBtxg7sOlD3N11a9D68esSl1yUSlQvFjoBQw49DtsqB3BgD7eE5rxeKsWrKfl8kjVBKY9oVLIdQwa8mmowo5pnooZ6qhsZ X-Gm-Message-State: AOJu0Yw3d02lIF3xmYkvvG7THC3AlcrZMOPYzkozclYY1M5VW7PDAAGi 0+QLtLGU5/g5FL4ycr3Hd0kVps5Xbhj+v1ztvsQpH0it+pbwiPLPWzmBod069g== X-Google-Smtp-Source: AGHT+IGhlN9obDs811TzuFeTw+yQpMZFy0dDvN3jgb99c2lssw4pJXubU4SOxjWfkOF/RoOypkxSZg== X-Received: by 2002:a05:6358:9807:b0:186:12cb:d1a8 with SMTP id y7-20020a056358980700b0018612cbd1a8mr629894rwa.25.1712870278344; Thu, 11 Apr 2024 14:17:58 -0700 (PDT) Received: from denia.c.googlers.com (200.234.86.34.bc.googleusercontent.com. [34.86.234.200]) by smtp.gmail.com with ESMTPSA id k20-20020ac84794000000b00434d7c4f9fasm1373362qtq.8.2024.04.11.14.17.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 14:17:58 -0700 (PDT) From: Ricardo Ribalda Date: Thu, 11 Apr 2024 21:17:54 +0000 Subject: [PATCH 5/7] media: tunner: xc5000: Refactor firmware load Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240411-fix-smatch-v1-5-045f92467937@chromium.org> References: <20240411-fix-smatch-v1-0-045f92467937@chromium.org> In-Reply-To: <20240411-fix-smatch-v1-0-045f92467937@chromium.org> To: Bluecherry Maintainers , Anton Sviridenko , Andrey Utkin , Ismael Luceno , Mauro Carvalho Chehab , Patrice Chotard Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ricardo Ribalda , Shuah Khan X-Mailer: b4 0.12.4 Make sure the firmware is released when we leave xc_load_fw_and_init_tuner() This change makes smatch happy: drivers/media/tuners/xc5000.c:1213 xc_load_fw_and_init_tuner() warn: 'fw' f= rom request_firmware() not released on lines: 1213. Cc: Shuah Khan Signed-off-by: Ricardo Ribalda --- drivers/media/tuners/xc5000.c | 39 +++++++++++++++++---------------------- 1 file changed, 17 insertions(+), 22 deletions(-) diff --git a/drivers/media/tuners/xc5000.c b/drivers/media/tuners/xc5000.c index 2182e5b7b6064..30aa4ee958bde 100644 --- a/drivers/media/tuners/xc5000.c +++ b/drivers/media/tuners/xc5000.c @@ -58,7 +58,7 @@ struct xc5000_priv { struct dvb_frontend *fe; struct delayed_work timer_sleep; =20 - const struct firmware *firmware; + bool inited; }; =20 /* Misc Defines */ @@ -1110,23 +1110,19 @@ static int xc_load_fw_and_init_tuner(struct dvb_fro= ntend *fe, int force) if (!force && xc5000_is_firmware_loaded(fe) =3D=3D 0) return 0; =20 - if (!priv->firmware) { - ret =3D request_firmware(&fw, desired_fw->name, - priv->i2c_props.adap->dev.parent); - if (ret) { - pr_err("xc5000: Upload failed. rc %d\n", ret); - return ret; - } - dprintk(1, "firmware read %zu bytes.\n", fw->size); + ret =3D request_firmware(&fw, desired_fw->name, + priv->i2c_props.adap->dev.parent); + if (ret) { + pr_err("xc5000: Upload failed. rc %d\n", ret); + return ret; + } + dprintk(1, "firmware read %zu bytes.\n", fw->size); =20 - if (fw->size !=3D desired_fw->size) { - pr_err("xc5000: Firmware file with incorrect size\n"); - release_firmware(fw); - return -EINVAL; - } - priv->firmware =3D fw; - } else - fw =3D priv->firmware; + if (fw->size !=3D desired_fw->size) { + pr_err("xc5000: Firmware file with incorrect size\n"); + release_firmware(fw); + return -EINVAL; + } =20 /* Try up to 5 times to load firmware */ for (i =3D 0; i < 5; i++) { @@ -1204,6 +1200,7 @@ static int xc_load_fw_and_init_tuner(struct dvb_front= end *fe, int force) } =20 err: + release_firmware(fw); if (!ret) printk(KERN_INFO "xc5000: Firmware %s loaded and running.\n", desired_fw->name); @@ -1274,7 +1271,7 @@ static int xc5000_resume(struct dvb_frontend *fe) =20 /* suspended before firmware is loaded. Avoid firmware load in resume path. */ - if (!priv->firmware) + if (!priv->inited) return 0; =20 return xc5000_set_params(fe); @@ -1293,6 +1290,8 @@ static int xc5000_init(struct dvb_frontend *fe) if (debug) xc_debug_dump(priv); =20 + priv->inited =3D true; + return 0; } =20 @@ -1306,10 +1305,6 @@ static void xc5000_release(struct dvb_frontend *fe) =20 if (priv) { cancel_delayed_work(&priv->timer_sleep); - if (priv->firmware) { - release_firmware(priv->firmware); - priv->firmware =3D NULL; - } hybrid_tuner_release_state(priv); } =20 --=20 2.44.0.683.g7961c838ac-goog From nobody Sun Feb 8 18:39:20 2026 Received: from mail-oo1-f46.google.com (mail-oo1-f46.google.com [209.85.161.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F049241744 for ; Thu, 11 Apr 2024 21:18:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712870282; cv=none; b=tpm1wp2GJG5eReU2pTRWKec0JkNuzpCmTKiYhSHyEZ1q4CFKxstC8sBy13qCDhvD68qHyMV5uFjEm00T15WTtJZBTlMRrPfl9iwfajF5mequFiYQUBdnPQ8LpSb+fTQEA0F4Xb8NBHT6YJSnpurZbUwtV/7Q1axGJVbL0KTVLys= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712870282; c=relaxed/simple; bh=Ogh+hSh4Or5uPuB9tfRQOhwkH7pUIRHWmEF19NCyWzA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=t0cqE7wN9h8ID7WZgW10RoW9HrKAiNPgKh8HUJJAJSL3Q8TB1z3QEH2hd1mDge31lm6H2ehL0aDfnQO9jSGaQp6Wmqp5HtLwYecPQ+ctUgC0p4raDzkjIW6pGqyUxPgtwP5UciXbXqqHbvILBTgaAkBs3NU89qu97Y+3wri5eB8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=OR3RTLBD; arc=none smtp.client-ip=209.85.161.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="OR3RTLBD" Received: by mail-oo1-f46.google.com with SMTP id 006d021491bc7-5aa3f0fcd46so172123eaf.1 for ; Thu, 11 Apr 2024 14:18:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1712870280; x=1713475080; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=e5nSR1yFGYwMcL96r69NW1l3sh3LFO29KJ2x2ErdnHk=; b=OR3RTLBD8M6HjvxKqQsArPSGRNkTaTccLQxASsqwwgk10DQFBL1f00ZYJq6qZEPWRn +/9KPeOmghux+xSZjoJZtiJWkd3UnceAQSRastwyRf+TRN9KLg7JtzpoiqG6jDn8cnVO 929Kd8wu+awJ27msuRO8KN1r/IR82+UXECqR4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712870280; x=1713475080; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e5nSR1yFGYwMcL96r69NW1l3sh3LFO29KJ2x2ErdnHk=; b=j96mIAaNxlMCZME/TXMHiIdY1TdNdnpHc7MqtezfkxxRXdo7xoYs4yvk05SNw92uMe OqG8gV4HUB1YNByLNa0Alo7aFmitLUJWaEevnS5UdioRO8kuiXqBu3VV69Pb8aPbas/k 1ePhXRLJjxNwNAaPzr53QFQObwJ7zWHUuixFsBOoIx2pdLZBf91hTQdWDUVhrCBIVzW3 ns1VpLgTxtLUvdOxdbBVwK5EhSX3PkjKcHWSl9j1FtkG/jeJW2ci7cuQ9UK8GfmpXCrz Y3P8pWhAvGWkQ37W0HHpJkMl22bxGAOpusUxK4RdtmH5lKxZwYPvAwrRtlj7/st4KCu3 tUbw== X-Forwarded-Encrypted: i=1; AJvYcCU+zKxsoIvRmLtZIhQwE+WfoQwlPLPdz202JdIdrqnH1wYUbLNaGsqX3VlgiCED1jD3nsbwi45qHB56O5aVzL3bBoLxHfDDSq1Ivn9f X-Gm-Message-State: AOJu0YyHdopOjIh2dAvnTxHvhK8nzlYdA1gOpv5zOTaTIIZsD8f5drKD HP5H2keQDrjTWD62Qbf9Jih7VSHlHCs5FlF46JvohkZBe+ZoRsKz6epJ9V/LvmHaoHXQ5Ivo9iR HNQ== X-Google-Smtp-Source: AGHT+IEh0blwfOKKlbWUs8oomzyYZwweaLJ6NFxR3Gr9CI9V/VL83VlcnszoDVWX3MZ+lZ28+ZL6Tg== X-Received: by 2002:a05:6358:4b45:b0:186:f3f:3252 with SMTP id ks5-20020a0563584b4500b001860f3f3252mr667180rwc.14.1712870279979; Thu, 11 Apr 2024 14:17:59 -0700 (PDT) Received: from denia.c.googlers.com (200.234.86.34.bc.googleusercontent.com. [34.86.234.200]) by smtp.gmail.com with ESMTPSA id k20-20020ac84794000000b00434d7c4f9fasm1373362qtq.8.2024.04.11.14.17.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 14:17:59 -0700 (PDT) From: Ricardo Ribalda Date: Thu, 11 Apr 2024 21:17:55 +0000 Subject: [PATCH 6/7] media: dvb-frontends: drx39xyj: Refactor firmware upload Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240411-fix-smatch-v1-6-045f92467937@chromium.org> References: <20240411-fix-smatch-v1-0-045f92467937@chromium.org> In-Reply-To: <20240411-fix-smatch-v1-0-045f92467937@chromium.org> To: Bluecherry Maintainers , Anton Sviridenko , Andrey Utkin , Ismael Luceno , Mauro Carvalho Chehab , Patrice Chotard Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ricardo Ribalda X-Mailer: b4 0.12.4 Do not cache the file, instead load it on demand. This makes smatch a happy parser: drivers/media/dvb-frontends/drx39xyj/drxj.c:11908 drx_ctrl_u_code() warn: '= fw' from request_firmware() not released on lines: 11877,11886,11896. Signed-off-by: Ricardo Ribalda --- drivers/media/dvb-frontends/drx39xyj/drx_driver.h | 2 - drivers/media/dvb-frontends/drx39xyj/drxj.c | 49 +++++++++++--------= ---- 2 files changed, 23 insertions(+), 28 deletions(-) diff --git a/drivers/media/dvb-frontends/drx39xyj/drx_driver.h b/drivers/me= dia/dvb-frontends/drx39xyj/drx_driver.h index 15f7e58c5a308..2c2fd4bf79ccf 100644 --- a/drivers/media/dvb-frontends/drx39xyj/drx_driver.h +++ b/drivers/media/dvb-frontends/drx39xyj/drx_driver.h @@ -33,7 +33,6 @@ =20 #include #include -#include #include =20 /* @@ -1910,7 +1909,6 @@ struct drx_demod_instance { /* generic demodulator data */ =20 struct i2c_adapter *i2c; - const struct firmware *firmware; }; =20 /*------------------------------------------------------------------------- diff --git a/drivers/media/dvb-frontends/drx39xyj/drxj.c b/drivers/media/dv= b-frontends/drx39xyj/drxj.c index 19d8de400a687..1ef53754bc037 100644 --- a/drivers/media/dvb-frontends/drx39xyj/drxj.c +++ b/drivers/media/dvb-frontends/drx39xyj/drxj.c @@ -56,6 +56,7 @@ INCLUDE FILES #define pr_fmt(fmt) KBUILD_MODNAME ":%s: " fmt, __func__ =20 #include +#include #include #include #include @@ -11750,6 +11751,7 @@ static int drx_ctrl_u_code(struct drx_demod_instanc= e *demod, u8 *mc_data =3D NULL; unsigned size; char *mc_file; + const struct firmware *fw; =20 /* Check arguments */ if (!mc_info || !mc_info->mc_file) @@ -11757,28 +11759,22 @@ static int drx_ctrl_u_code(struct drx_demod_insta= nce *demod, =20 mc_file =3D mc_info->mc_file; =20 - if (!demod->firmware) { - const struct firmware *fw =3D NULL; - - rc =3D request_firmware(&fw, mc_file, demod->i2c->dev.parent); - if (rc < 0) { - pr_err("Couldn't read firmware %s\n", mc_file); - return rc; - } - demod->firmware =3D fw; - - if (demod->firmware->size < 2 * sizeof(u16)) { - rc =3D -EINVAL; - pr_err("Firmware is too short!\n"); - goto release; - } + rc =3D request_firmware(&fw, mc_file, demod->i2c->dev.parent); + if (rc < 0) { + pr_err("Couldn't read firmware %s\n", mc_file); + return rc; + } =20 - pr_info("Firmware %s, size %zu\n", - mc_file, demod->firmware->size); + if (fw->size < 2 * sizeof(u16)) { + rc =3D -EINVAL; + pr_err("Firmware is too short!\n"); + goto release; } =20 - mc_data_init =3D demod->firmware->data; - size =3D demod->firmware->size; + pr_info("Firmware %s, size %zu\n", mc_file, fw->size); + + mc_data_init =3D fw->data; + size =3D fw->size; =20 mc_data =3D (void *)mc_data_init; /* Check data */ @@ -11874,7 +11870,8 @@ static int drx_ctrl_u_code(struct drx_demod_instanc= e *demod, 0x0000)) { pr_err("error reading firmware at pos %zd\n", mc_data - mc_data_init); - return -EIO; + rc =3D -EIO; + goto release; } =20 result =3D memcmp(curr_ptr, mc_data_buffer, @@ -11883,7 +11880,8 @@ static int drx_ctrl_u_code(struct drx_demod_instanc= e *demod, if (result) { pr_err("error verifying firmware at pos %zd\n", mc_data - mc_data_init); - return -EIO; + rc =3D -EIO; + goto release; } =20 curr_addr +=3D ((dr_xaddr_t)(bytes_to_comp / 2)); @@ -11893,17 +11891,17 @@ static int drx_ctrl_u_code(struct drx_demod_insta= nce *demod, break; } default: - return -EINVAL; + rc =3D -EINVAL; + goto release; =20 } mc_data +=3D mc_block_nr_bytes; } =20 - return 0; + rc =3D 0; =20 release: - release_firmware(demod->firmware); - demod->firmware =3D NULL; + release_firmware(fw); =20 return rc; } @@ -12271,7 +12269,6 @@ static void drx39xxj_release(struct dvb_frontend *f= e) kfree(demod->my_ext_attr); kfree(demod->my_common_attr); kfree(demod->my_i2c_dev_addr); - release_firmware(demod->firmware); kfree(demod); kfree(state); } --=20 2.44.0.683.g7961c838ac-goog From nobody Sun Feb 8 18:39:20 2026 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A80CD4596E for ; Thu, 11 Apr 2024 21:18:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712870285; cv=none; b=t0sYM6rUk6tUW+O+a3WyMX0pBFI1imZpgxFbSkzv/tPrU4NqrrFrlZ9fR8wEiXvu5Ajscko4KCLt1DjsTtFEMOQs29i8zrEgw/siefG970L9+WtTt2ORZSe2M6Bmu0zhXgEZ4mB6YPYO5za5BRROEG/adLtW7V2t7Ti5Ub5enMA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712870285; c=relaxed/simple; bh=jWvovnNbCjwB2C+VXHGftHmA5T8gil6/DHr34mWgtoE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ONLUvr43rDM6Q/6UObaZcULQ4qcC6/6MJewNzt8tDhdnzgRUKHog60iHRBLr3jP1fR2QGKfHTFPVWI7mu5YLXpoSdcbDdfHhgCdicht0UgHZ5nG6ICr1eDaelRxpDtHlfXGmXxYyI10uHhBm8sSh3YCddNX27H3e6akqTcxfN6M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=bCxvtOHZ; arc=none smtp.client-ip=209.85.167.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="bCxvtOHZ" Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-3bbbc6b4ed1so137424b6e.2 for ; Thu, 11 Apr 2024 14:18:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1712870283; x=1713475083; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IOIqD2cEf2Ajo/2bzueQZnF061I92Ltj+ENaeP2eHJQ=; b=bCxvtOHZLkuithzlYNA0ADaPlt5s5uEzOGaLTqUGhjnH1nblKRIXwclN4Op6w0MTmm qI1AXJrRWIM9jOMCWxAAUaLwUBlp7XJO0RAvONF4UzdBg9G1qjAsjvCHLGUJKd8VFhJ7 COLjgMLLu8TywhN5x8AomQ7Zrn6UkNvhlZ0uc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712870283; x=1713475083; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IOIqD2cEf2Ajo/2bzueQZnF061I92Ltj+ENaeP2eHJQ=; b=ek+/7QYGzId4/59Wsqk7pO7e5zrLpQZlB/72GeoxyYWMFFJF3XkN1zA2Lvh/UJ8a70 1PueiOBl1HsKtP2SbSW2iXFLduIn3UlWQ3O74QFS4z5zLjv1qjBO9So4SxdBU/76SVLD 8aFzSXnjigjrK7fMjuh4uZUw+a6GxmG0kDrUTKemJDUATweTIvYmEpyymKPVvhiptOea 0J/ptPvKIZVTWgCGhmf1CInESUuQL/BP3Pp72HkWYYAqQcY2c4aomx2Hhl0UJFvO+pVq 5UHDoZnkYZcpVCSUghHtsGLCaWbiHLCwseWz0pi+xkILDyWZeGraGpsJiqxZBQPRo0dd SAug== X-Forwarded-Encrypted: i=1; AJvYcCWQeV7TCv4lUWa+9OOBWZ2OiLZYvrnQOzdye+3yEb1C1e7KESxBG0wd+MsUpluoOxIfW49ZBl7lHsOYQsa7B+GveLMn0d1BLPEKpKpH X-Gm-Message-State: AOJu0Yx5EABTaGpdE1LK5fNFnOXw5fkuI/1dzc2iM7ftkz0TPIAoWg3C aaZ1Rib1e26FeKRuQITuo0zFjhSqURUyP4Cps/Lu/1JBXU/QqVtf+obLJ3jS9g== X-Google-Smtp-Source: AGHT+IFC+MhkQWiHdHFKMOyxd+8dV1gTziJ5gXLj4MpOfJR3ww+hXqqwT2lBycXPTw1zfx8RyZUR8w== X-Received: by 2002:a05:6808:198e:b0:3c6:beb:20b2 with SMTP id bj14-20020a056808198e00b003c60beb20b2mr665356oib.51.1712870281598; Thu, 11 Apr 2024 14:18:01 -0700 (PDT) Received: from denia.c.googlers.com (200.234.86.34.bc.googleusercontent.com. [34.86.234.200]) by smtp.gmail.com with ESMTPSA id k20-20020ac84794000000b00434d7c4f9fasm1373362qtq.8.2024.04.11.14.18.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 14:18:01 -0700 (PDT) From: Ricardo Ribalda Date: Thu, 11 Apr 2024 21:17:56 +0000 Subject: [PATCH 7/7] media: dvb-usb: dib0700_devices: Add missing release_firmware() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240411-fix-smatch-v1-7-045f92467937@chromium.org> References: <20240411-fix-smatch-v1-0-045f92467937@chromium.org> In-Reply-To: <20240411-fix-smatch-v1-0-045f92467937@chromium.org> To: Bluecherry Maintainers , Anton Sviridenko , Andrey Utkin , Ismael Luceno , Mauro Carvalho Chehab , Patrice Chotard Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ricardo Ribalda X-Mailer: b4 0.12.4 Add missing release_firmware on the error paths. drivers/media/usb/dvb-usb/dib0700_devices.c:2415 stk9090m_frontend_attach()= warn: 'state->frontend_firmware' from request_firmware() not released on l= ines: 2415. drivers/media/usb/dvb-usb/dib0700_devices.c:2497 nim9090md_frontend_attach(= ) warn: 'state->frontend_firmware' from request_firmware() not released on = lines: 2489,2497. Signed-off-by: Ricardo Ribalda --- drivers/media/usb/dvb-usb/dib0700_devices.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/dvb-usb/dib0700_devices.c b/drivers/media/us= b/dvb-usb/dib0700_devices.c index 3af594134a6de..6ddc205133939 100644 --- a/drivers/media/usb/dvb-usb/dib0700_devices.c +++ b/drivers/media/usb/dvb-usb/dib0700_devices.c @@ -2412,7 +2412,12 @@ static int stk9090m_frontend_attach(struct dvb_usb_a= dapter *adap) =20 adap->fe_adap[0].fe =3D dvb_attach(dib9000_attach, &adap->dev->i2c_adap, = 0x80, &stk9090m_config); =20 - return adap->fe_adap[0].fe =3D=3D NULL ? -ENODEV : 0; + if (!adap->fe_adap[0].fe) { + release_firmware(state->frontend_firmware); + return -ENODEV; + } + + return 0; } =20 static int dib9090_tuner_attach(struct dvb_usb_adapter *adap) @@ -2485,8 +2490,10 @@ static int nim9090md_frontend_attach(struct dvb_usb_= adapter *adap) dib9000_i2c_enumeration(&adap->dev->i2c_adap, 1, 0x20, 0x80); adap->fe_adap[0].fe =3D dvb_attach(dib9000_attach, &adap->dev->i2c_adap, = 0x80, &nim9090md_config[0]); =20 - if (adap->fe_adap[0].fe =3D=3D NULL) + if (!adap->fe_adap[0].fe) { + release_firmware(state->frontend_firmware); return -ENODEV; + } =20 i2c =3D dib9000_get_i2c_master(adap->fe_adap[0].fe, DIBX000_I2C_INTERFACE= _GPIO_3_4, 0); dib9000_i2c_enumeration(i2c, 1, 0x12, 0x82); @@ -2494,7 +2501,12 @@ static int nim9090md_frontend_attach(struct dvb_usb_= adapter *adap) fe_slave =3D dvb_attach(dib9000_attach, i2c, 0x82, &nim9090md_config[1]); dib9000_set_slave_frontend(adap->fe_adap[0].fe, fe_slave); =20 - return fe_slave =3D=3D NULL ? -ENODEV : 0; + if (!fe_slave) { + release_firmware(state->frontend_firmware); + return -ENODEV; + } + + return 0; } =20 static int nim9090md_tuner_attach(struct dvb_usb_adapter *adap) --=20 2.44.0.683.g7961c838ac-goog