From nobody Sun Feb 8 17:03:54 2026 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 829E618410F for ; Wed, 10 Apr 2024 21:54:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712786089; cv=none; b=DfkaG37lT/uTGjjenVBwoMo7D2aGhOJT88cZJX4R1eTK+2Qse0M2TWQjBI5cNuRIbn2ifAQW66tcvS3+jU0qq0z2wIl7Lqf/sHybL65AWhl4pSWGQqVcN+Fag9t367T9pyilEtX4NK8jdS6Bft53tpDa6Fy4TKV43GdcxGOtoPM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712786089; c=relaxed/simple; bh=rzGNe4hZhMnB8M/40dl2p6r/nVedCnlrPhrsN56MHoE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fwTr+TYzuiBHHKrcOntCHOeo4i1cd0Egh1NhuQt9Ab1dt3h19hBBv/GJIj2F5oXuq6avaqvQaJhu04o5kiljo9twszzGo73oSSGDihZ+qpF24rVu5fbydzS/ZZUx7e4jQ45xBgK6i5Yr8g1ib8kLKoKn+cDrnywr7Pb6P4fDpv4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=F/eeD8sE; arc=none smtp.client-ip=209.85.160.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="F/eeD8sE" Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-434d85cdb05so9521751cf.0 for ; Wed, 10 Apr 2024 14:54:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1712786086; x=1713390886; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=nPW2ppTL8S189BnwjTGvFf2yuc7RYQzJKkrIYHPYwNk=; b=F/eeD8sEjrY+EhekZafyZQoJa27/IyQrTtkPnnDb5U32vvUEhclqgJvnkF3yk2IA9s b/I2HvnnaY4uosfvxdHNI9Y47+AKPYlkUJ9vjHEzNxwYapYUYRJ+hONV3g5voEXutj1R S91spzMhdSx1FopiRRS3HNBIvbRWtNgmhSq2U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712786086; x=1713390886; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nPW2ppTL8S189BnwjTGvFf2yuc7RYQzJKkrIYHPYwNk=; b=wnmsuQNEO0h+ZwsMM5kX2TibWw86ixP1feXYSglEJoALUkVb4HdUYV31IHC5kZoeoq t7AlKLzge2o049Ni5RN0rVwLtSiqZBnvBkzGuQ2cjFLV768HDSE9ydaF4kF+vFp9Ctv6 V5wQQ5innnhN0rhN6M5/f/V5N+B4Gq/s71ejSeMdHAnSoGK5ZKSQ2PeiG2cT0WOv1Y6u Yjyebk0/UnZrHTVWV1rE+lv9T/4Di1cx8yYaqGI9QMn18PUuPMZbNe8Sy2mlqU8FNtS8 Upj7IdDZVsbHefXv4TkdtLNadcyXYj5IX+rYhSASiCKzvKolXA7tnYcXR+WgolQ0yEy4 t0Lg== X-Forwarded-Encrypted: i=1; AJvYcCX0Pt7NWXiG4umyf1kXhO/g5MK5q0s8LyM9S8VpNILZzj28Vif67jTtQijLPqk5GcLFycR4IvZ9E5Tn3wE/j1LbGfHEMX0UHAdfOefJ X-Gm-Message-State: AOJu0Yxh96lYo/+OyGz1Unzr1VOEWlQzgKLptPQSSKUEId3VN5y/+kQv ykMVzI7wPX15XiG78tTHR1O2BmBEdnblnB0bl03+FpYIkJiiBeKNHNvbNS08sQ== X-Google-Smtp-Source: AGHT+IGqJ1+HwPYyX9JNsLSdWW24aYLgwinvggdSsd1dVYnvyZyEESK2vRNNPs8/wL4dw6XEd0RjjQ== X-Received: by 2002:a05:622a:10b:b0:436:5628:d6a6 with SMTP id u11-20020a05622a010b00b004365628d6a6mr818871qtw.48.1712786086346; Wed, 10 Apr 2024 14:54:46 -0700 (PDT) Received: from denia.c.googlers.com (188.173.86.34.bc.googleusercontent.com. [34.86.173.188]) by smtp.gmail.com with ESMTPSA id kg26-20020a05622a761a00b00434c1eedb0esm67330qtb.36.2024.04.10.14.54.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 14:54:45 -0700 (PDT) From: Ricardo Ribalda Date: Wed, 10 Apr 2024 21:54:38 +0000 Subject: [PATCH 1/6] media: usb: siano: Fix allocation of urbs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240410-smatch-v1-1-785d009a852b@chromium.org> References: <20240410-smatch-v1-0-785d009a852b@chromium.org> In-Reply-To: <20240410-smatch-v1-0-785d009a852b@chromium.org> To: Mauro Carvalho Chehab , Yasunari Takiguchi , Jean-Christophe Trotin , Lars-Peter Clausen , Dmitry Torokhov Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 USB urbs must be allocated with usb_alloc_urb. Quoting the manual Only use this function (usb_init_urb) if you _really_ understand what you are doing. Fix the following smatch error: drivers/media/usb/siano/smsusb.c:53:38: warning: array of flexible structur= es Signed-off-by: Ricardo Ribalda --- drivers/media/usb/siano/smsusb.c | 28 ++++++++++++++++++++-------- 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/drivers/media/usb/siano/smsusb.c b/drivers/media/usb/siano/sms= usb.c index 723510520d092..d85308e0785db 100644 --- a/drivers/media/usb/siano/smsusb.c +++ b/drivers/media/usb/siano/smsusb.c @@ -40,7 +40,7 @@ struct smsusb_urb_t { struct smscore_buffer_t *cb; struct smsusb_device_t *dev; =20 - struct urb urb; + struct urb *urb; =20 /* For the bottom half */ struct work_struct wq; @@ -160,7 +160,7 @@ static int smsusb_submit_urb(struct smsusb_device_t *de= v, } =20 usb_fill_bulk_urb( - &surb->urb, + surb->urb, dev->udev, usb_rcvbulkpipe(dev->udev, dev->in_ep), surb->cb->p, @@ -168,9 +168,9 @@ static int smsusb_submit_urb(struct smsusb_device_t *de= v, smsusb_onresponse, surb ); - surb->urb.transfer_flags |=3D URB_FREE_BUFFER; + surb->urb->transfer_flags |=3D URB_FREE_BUFFER; =20 - return usb_submit_urb(&surb->urb, GFP_ATOMIC); + return usb_submit_urb(surb->urb, GFP_ATOMIC); } =20 static void smsusb_stop_streaming(struct smsusb_device_t *dev) @@ -178,7 +178,7 @@ static void smsusb_stop_streaming(struct smsusb_device_= t *dev) int i; =20 for (i =3D 0; i < MAX_URBS; i++) { - usb_kill_urb(&dev->surbs[i].urb); + usb_kill_urb(dev->surbs[i].urb); if (dev->surbs[i].wq.func) cancel_work_sync(&dev->surbs[i].wq); =20 @@ -338,6 +338,8 @@ static void smsusb_term_device(struct usb_interface *in= tf) struct smsusb_device_t *dev =3D usb_get_intfdata(intf); =20 if (dev) { + int i; + dev->state =3D SMSUSB_DISCONNECTED; =20 smsusb_stop_streaming(dev); @@ -346,6 +348,9 @@ static void smsusb_term_device(struct usb_interface *in= tf) if (dev->coredev) smscore_unregister_device(dev->coredev); =20 + for (i =3D 0; i < MAX_URBS; i++) + usb_free_urb(dev->surbs[i].urb); + pr_debug("device 0x%p destroyed\n", dev); kfree(dev); } @@ -390,6 +395,7 @@ static int smsusb_init_device(struct usb_interface *int= f, int board_id) void *mdev; int i, rc; int align =3D 0; + int n_urb =3D 0; =20 /* create device object */ dev =3D kzalloc(sizeof(struct smsusb_device_t), GFP_KERNEL); @@ -461,9 +467,11 @@ static int smsusb_init_device(struct usb_interface *in= tf, int board_id) dev->coredev->is_usb_device =3D true; =20 /* initialize urbs */ - for (i =3D 0; i < MAX_URBS; i++) { - dev->surbs[i].dev =3D dev; - usb_init_urb(&dev->surbs[i].urb); + for (n_urb =3D 0; n_urb < MAX_URBS; n_urb++) { + dev->surbs[n_urb].dev =3D dev; + dev->surbs[n_urb].urb =3D usb_alloc_urb(0, GFP_KERNEL); + if (!dev->surbs[n_urb].urb) + goto free_urbs; } =20 pr_debug("smsusb_start_streaming(...).\n"); @@ -485,6 +493,10 @@ static int smsusb_init_device(struct usb_interface *in= tf, int board_id) =20 return rc; =20 +free_urbs: + for (i =3D 0; i < n_urb; i++) + usb_free_urb(dev->surbs[n_urb].urb); + err_unregister_device: smsusb_term_device(intf); #ifdef CONFIG_MEDIA_CONTROLLER_DVB --=20 2.44.0.478.gd926399ef9-goog From nobody Sun Feb 8 17:03:54 2026 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26DAD184110 for ; Wed, 10 Apr 2024 21:54:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712786089; cv=none; b=d/FmvnrKDZHRsmuchOvrrloZJfWG492+K2sA6cemlASN7f45DbUR8YwkfaM3+URNya8H96W9m90eJN85N0SgUiN1WTwbdDkrf+5WGcR8VkgKqDWTgl3d+lK087V5oMBiwCGBCdghzmlnXAYVPwti6laD0EQ0qbikyty4vLv8L34= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712786089; c=relaxed/simple; bh=EzXC/4xYw8bpGVae+0wn0GICDiD54D8PeB0vdxO26YU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RxU3+PoIU1sHudqG+n+IRGDhiI25z7qzO5RlsMhe5L1FcfW2FQf/nalgKlf/GT0mX5i4lfLaGtxGgnmaEWssXvOHJNGss3u7I7n7gM3XAfMC8pYcJCJCx1LJWA47LeAn56/59hS6PDJztZ06X4AdM1/vJfjqCEiYAGqGG551cxQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=n96c89I7; arc=none smtp.client-ip=209.85.160.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="n96c89I7" Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-4347dadc2cfso28422151cf.3 for ; Wed, 10 Apr 2024 14:54:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1712786087; x=1713390887; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Nzns2XXp3BgsyesnfwW5lSLxfDYY59eLeE+bSWeFTSk=; b=n96c89I7TMHVMCc/s6vrIhqnxubPtwm+pP7n4E2Etkr7KLOibOht7/atptAJVm5qQE 5a8sOfSNQU9I7RvHh66kkv3XPQa+DWLpX1Jrv3398ZIdLUpbUST13bMnP4qkoifkHLLo 5RMXkdJUCUBS6WvuorAfXfMT9pzdmgj+Eocxw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712786087; x=1713390887; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nzns2XXp3BgsyesnfwW5lSLxfDYY59eLeE+bSWeFTSk=; b=oupyNF12Hf5X8VWQnPxFi+zjgKiJ6XtIf9sZuT8sQe3f2U5hn+0/dnVK67QPmA/uaV cw5pI3NHSmwRv1aHiGq/m8B3LDVvapuCCuVWmsmrssTVIqMrRVrnZUlOsjLo0djH7ptH IPHshnMLtdnicuHNbNyiW4nkUID7gI2gTPw7Pgds/qR7sso7+XTeTuNNsb5g42RdzlZ3 lCcgUI28l1PLJws9GWVOS4NeKGiQ2SaWtQ3nIUE3fOtwqO7R5Bp+I3UVTbNMIuJW1A09 VRWjgVtXAz7MKxKlcqqelhOx1YAfFuJeX2OJjgFqjUKgjB/YVgHIlCLcdCzHv0nMNhJF h7FQ== X-Forwarded-Encrypted: i=1; AJvYcCW0/JsqMHhbwTDZK6SItjdLthRRra+hKn6bu8h0NylckOciGHwS1daHu20wfDMat87dJsEl+jTr2IhijpXLQ9tEjzghuQpL1qjz6bTB X-Gm-Message-State: AOJu0YxvaByiPUFUD+NriN0dvnCRY7/EbvbI7AtBwSMbn9nesiJadVPf 1rvaaAbz/+ibjVTKYPHjwTTg+36aop/184gN9OgekQcwnZTHrjW8qnLWeDsQOw== X-Google-Smtp-Source: AGHT+IH9ibfw4+QYfFH/7vnhBrr0v60dMc5TlmaLcG2PPAu465t/Cz8VYSfyv7RTeGYj9Z4zy/bAtA== X-Received: by 2002:ac8:5f0a:0:b0:434:b349:da7 with SMTP id x10-20020ac85f0a000000b00434b3490da7mr4288466qta.26.1712786087041; Wed, 10 Apr 2024 14:54:47 -0700 (PDT) Received: from denia.c.googlers.com (188.173.86.34.bc.googleusercontent.com. [34.86.173.188]) by smtp.gmail.com with ESMTPSA id kg26-20020a05622a761a00b00434c1eedb0esm67330qtb.36.2024.04.10.14.54.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 14:54:46 -0700 (PDT) From: Ricardo Ribalda Date: Wed, 10 Apr 2024 21:54:39 +0000 Subject: [PATCH 2/6] media: cxd2880: Replaze kmalloc with kzalloc Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240410-smatch-v1-2-785d009a852b@chromium.org> References: <20240410-smatch-v1-0-785d009a852b@chromium.org> In-Reply-To: <20240410-smatch-v1-0-785d009a852b@chromium.org> To: Mauro Carvalho Chehab , Yasunari Takiguchi , Jean-Christophe Trotin , Lars-Peter Clausen , Dmitry Torokhov Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 Fix smatch error: drivers/media/spi/cxd2880-spi.c:391 cxd2880_start_feed() warn: Please consi= der using kzalloc instead of kmalloc Signed-off-by: Ricardo Ribalda --- drivers/media/spi/cxd2880-spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/spi/cxd2880-spi.c b/drivers/media/spi/cxd2880-sp= i.c index 6be4e5528879f..65fa7f857fcaf 100644 --- a/drivers/media/spi/cxd2880-spi.c +++ b/drivers/media/spi/cxd2880-spi.c @@ -388,7 +388,7 @@ static int cxd2880_start_feed(struct dvb_demux_feed *fe= ed) =20 if (dvb_spi->feed_count =3D=3D 0) { dvb_spi->ts_buf =3D - kmalloc(MAX_TRANS_PKT * 188, + kzalloc(MAX_TRANS_PKT * 188, GFP_KERNEL | GFP_DMA); if (!dvb_spi->ts_buf) { pr_err("ts buffer allocate failed\n"); --=20 2.44.0.478.gd926399ef9-goog From nobody Sun Feb 8 17:03:54 2026 Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 130D7184127 for ; Wed, 10 Apr 2024 21:54:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712786090; cv=none; b=R/iXCWe387AI4qGWJSahBvyccbKrIo9bZLRrnaqNEOOHoI6t+hz47qnRvq52QfdDuNxaCG0qxM0LcxalqzFpweBgt7hJoWcdewC41tcA5762D6dftYZILX3hFwYzN7SINfMtBhF3Y0sEExY5ZlZLc3/lPGvasmYBwNRunAt0l7M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712786090; c=relaxed/simple; bh=CNOEK2aWkC3W8YJDXsiqotp6WsB7BgDuWRBpQs7crVU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=X3XGUEnD3cUdOc/mFJlfHJ6ogQBYM3Y99wQFvVacWeKDrUlVJi56i4WMc97mW1f/KKPyjx9E7cy220H7jgBdRToTOfArOCPFxBjgKfHH02ytQ1nCvPDD4unnBok0GD9JJftt9uVpzE2R9nJCP1Ck3sNZMaZiLmuHauFxmaqcxKI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=SCZqqIHh; arc=none smtp.client-ip=209.85.219.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="SCZqqIHh" Received: by mail-yb1-f174.google.com with SMTP id 3f1490d57ef6-dcbef31a9dbso4775388276.1 for ; Wed, 10 Apr 2024 14:54:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1712786088; x=1713390888; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=s6vhOcczX0Rso19zsRzhH1nUym0L4HSC9FS2OUDhpCI=; b=SCZqqIHhAbzTPWD+OERGE/77Jwb5jSH/ZN9+jIiYC4RhRU4pYeLTtQ8S0cjQm08oX4 ZLaTYJoh1V+WQRE0WQaAyxucj/8t3Mn9Rdcw1EWUchjIpP1+5OXFHgqgLbyfLtMTxvKN ThiQCA1T3+VLDlGfGNUQsQwyJ9TPb63f9x608= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712786088; x=1713390888; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s6vhOcczX0Rso19zsRzhH1nUym0L4HSC9FS2OUDhpCI=; b=WGtapXnpSJmVgMTF0kFPw6fVFIXC3JvBGdpk+/fkSRZjP5Guvk1tXumNAbJ2HOnGwO vk7aOFoFS5aL4+DRjZYKw86qggAt/tCkfsvtbPWkLYaWF5zI83FHlfrY9nYcGFvF0FrO PZEUaR3Hn6nbvgwNVThwu4kvcCL4i6tRQ+BlOpTecaVFptJ/HUJzt1LTxARfV4i5s0T7 FBin9171CQZYOwmgOgkPEt/9pPJF/rdu2Q5+vCbsREuHg/tUDPGGoP0E7A4+A00XklYj A3G/2XWFDBhr1o+fC5rHeY0WCQVH4VBi9uJ+ZtmDENGJUbjAZ3ZVJkgphSzHNdqDf3Cn QZlg== X-Forwarded-Encrypted: i=1; AJvYcCUQksN04apBYPdyIRSTv6FY+rAojaVKZIH5PG5kQPAaxPS+eK9DRAsQOgiG4thlkQeuTmDdSo5PGosNLn2mgJRLikfoW80cy6Fg1J3t X-Gm-Message-State: AOJu0Yw7YUfCm6FOmC1J1/ebiSGTLbuzi4nWBiG7e3f66nOyYGxvLVya bLpkFnVZJSWhotwHzBlFP5J7BF4W5IWPqD+9um6g1gLh0pgUcJaelYTnOPV1yQ== X-Google-Smtp-Source: AGHT+IGIfO/2mFuyvVoujR3E89kj5KMNHwJfRYxvWyAQjc1xNMc4jdF0XAAcb1kFRJTlscFJbgdi9Q== X-Received: by 2002:a25:acc1:0:b0:dcd:5bfa:8184 with SMTP id x1-20020a25acc1000000b00dcd5bfa8184mr4697141ybd.39.1712786087887; Wed, 10 Apr 2024 14:54:47 -0700 (PDT) Received: from denia.c.googlers.com (188.173.86.34.bc.googleusercontent.com. [34.86.173.188]) by smtp.gmail.com with ESMTPSA id kg26-20020a05622a761a00b00434c1eedb0esm67330qtb.36.2024.04.10.14.54.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 14:54:47 -0700 (PDT) From: Ricardo Ribalda Date: Wed, 10 Apr 2024 21:54:40 +0000 Subject: [PATCH 3/6] media: platform: sti: hva: clk_unprepare unconditionally Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240410-smatch-v1-3-785d009a852b@chromium.org> References: <20240410-smatch-v1-0-785d009a852b@chromium.org> In-Reply-To: <20240410-smatch-v1-0-785d009a852b@chromium.org> To: Mauro Carvalho Chehab , Yasunari Takiguchi , Jean-Christophe Trotin , Lars-Peter Clausen , Dmitry Torokhov Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 hva->clk cannot be NULL at this point. Simplify the code and make smatch happy: drivers/media/platform/st/sti/hva/hva-hw.c:412 hva_hw_probe() warn: 'hva->c= lk' from clk_prepare() not released on lines: 412 Signed-off-by: Ricardo Ribalda --- drivers/media/platform/st/sti/hva/hva-hw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/platform/st/sti/hva/hva-hw.c b/drivers/media/pla= tform/st/sti/hva/hva-hw.c index fe4ea2e7f37e3..fcb18fb52fdd7 100644 --- a/drivers/media/platform/st/sti/hva/hva-hw.c +++ b/drivers/media/platform/st/sti/hva/hva-hw.c @@ -406,8 +406,7 @@ int hva_hw_probe(struct platform_device *pdev, struct h= va_dev *hva) err_disable: pm_runtime_disable(dev); err_clk: - if (hva->clk) - clk_unprepare(hva->clk); + clk_unprepare(hva->clk); =20 return ret; } --=20 2.44.0.478.gd926399ef9-goog From nobody Sun Feb 8 17:03:54 2026 Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73D99184130 for ; Wed, 10 Apr 2024 21:54:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712786091; cv=none; b=M93GsuCCVZOYr66xTgpFIO0aw0jYaq2KpbFSX3wAo3An4oll5cqzwpNwrD5VKNP9uu2ehrucuZIZKfujk2vkE1Hv+/FUdmn5hujtn4euWOhBSWfbelE6X8w/znr9Ia2zv6AzBBkkhke7YPOsgdT1PbTu6zsS0nzESpG3XZrgzP8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712786091; c=relaxed/simple; bh=XZj893oOgJO+TuxebqQUH7FBZLqRq2EAjtnxNCWS4dQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fRb5KQjrEXMkuAz2rr27flOW9yhf5Vc28QM6AB2ZjFQkZP7mUYTLTgtzLXEELKHoMSFUiDgeil9UOes3R2wpTJxcajr+JSD0gywesVwXZ7qwkTmGBAUzO203yIaenEujpTr/RCast0HYFaCwuYxf6Cnp+xcWpqsuA0Id3985pSM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Vs+sGN5v; arc=none smtp.client-ip=209.85.167.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Vs+sGN5v" Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-3c6032ede0dso560955b6e.0 for ; Wed, 10 Apr 2024 14:54:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1712786088; x=1713390888; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=udjeys4Odih0ujJKT10PCL6WQWBbIkHJU3t+XfW9ZzY=; b=Vs+sGN5vS13k1kK+yHJoP7NFOtTQvWYNPAxMOSPndIMYRuZCnvxeQ971u1t3HaGgP+ e+pVM4yEd0+Bx4d6FmTo4b5uGugVI+5VgouOza5n1VqgGF9Kqr2UBuJpmO0iOsWsV8Zh pDzRWsTnqMA0mqLTUpkq7yJQXUSsYmz2qxP8k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712786088; x=1713390888; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=udjeys4Odih0ujJKT10PCL6WQWBbIkHJU3t+XfW9ZzY=; b=dSLQTpyRcXBls45RtZvjIR/2NnWxdFUBScRDlJbd0y0qvr8wpoX0y3SwTWlK0cTFSo pB9pNfw1yARZMb6R3QzBPplw4V11YAqse+32GaEjYF5TcT6Osf7QeqcFG8zYhDJpn7ms LIU0HkRv8DPm7m8c+ZLfxWdmMtAWskD3JYX6TF90MOk3cbYJJOHQdJGLc0afd+DBkdtO Hix1MDJDC6HBO8m+5eyVX5soUjMhAbLZDBw9ZvV/yMYUTMcQ7CqLXScJ810gxS9wjVnP T0BM+QYqPzGHeKZTl4PtTxuw3++64+qIT/Pc7+SKtTSlm9B82GofU4gXkivmLtz7LlQj OZJg== X-Forwarded-Encrypted: i=1; AJvYcCWyzUsrSFkf2doBwpeth2x5LyMdsMv2y2GN3gE9F3WxJ6GpCZgrx4lDJTbfITY9yMoDqL+TgZhtHc2eYziHe9g9lQkgt9EeqJLWmx6I X-Gm-Message-State: AOJu0Ywgg5vPxzRq44K+pmPvVQHF/luOt1oRF7okXqMrjOBjxlYNPTSY txWtnWvAAQlUH+9Qe4z1xjXzzWjibuZNEFRO1ATXITwuGz7XHgCE28FP5oc3vA== X-Google-Smtp-Source: AGHT+IHR53mUa7EISt68wfOzVTMhiwwKLj8khagoL81qi8dkm725vDXUVJ8C3dvMoDM7Stak1r7Z3w== X-Received: by 2002:a05:6808:b10:b0:3c6:1412:3541 with SMTP id s16-20020a0568080b1000b003c614123541mr424100oij.34.1712786088631; Wed, 10 Apr 2024 14:54:48 -0700 (PDT) Received: from denia.c.googlers.com (188.173.86.34.bc.googleusercontent.com. [34.86.173.188]) by smtp.gmail.com with ESMTPSA id kg26-20020a05622a761a00b00434c1eedb0esm67330qtb.36.2024.04.10.14.54.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 14:54:48 -0700 (PDT) From: Ricardo Ribalda Date: Wed, 10 Apr 2024 21:54:41 +0000 Subject: [PATCH 4/6] media: v4l2-ctrls-core.c: Do not use iterator outside loop Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240410-smatch-v1-4-785d009a852b@chromium.org> References: <20240410-smatch-v1-0-785d009a852b@chromium.org> In-Reply-To: <20240410-smatch-v1-0-785d009a852b@chromium.org> To: Mauro Carvalho Chehab , Yasunari Takiguchi , Jean-Christophe Trotin , Lars-Peter Clausen , Dmitry Torokhov Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 Simplify a bit the code introducing a new variable for iterating through the control list. It also makes smatch happy: drivers/media/v4l2-core/v4l2-ctrls-api.c:1091 v4l2_query_ext_ctrl() warn: i= terator used outside loop: 'ref' Signed-off-by: Ricardo Ribalda --- drivers/media/v4l2-core/v4l2-ctrls-api.c | 33 ++++++++++++++++++----------= ---- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-ctrls-api.c b/drivers/media/v4l2-= core/v4l2-ctrls-api.c index d9a422017bd9d..42b7a45bfa79c 100644 --- a/drivers/media/v4l2-core/v4l2-ctrls-api.c +++ b/drivers/media/v4l2-core/v4l2-ctrls-api.c @@ -1052,35 +1052,40 @@ int v4l2_query_ext_ctrl(struct v4l2_ctrl_handler *h= dl, struct v4l2_query_ext_ctr if (id >=3D node2id(hdl->ctrl_refs.prev)) { ref =3D NULL; /* Yes, so there is no next control */ } else if (ref) { + struct v4l2_ctrl_ref *pos =3D ref; + /* * We found a control with the given ID, so just get * the next valid one in the list. */ - list_for_each_entry_continue(ref, &hdl->ctrl_refs, node) { - is_compound =3D ref->ctrl->is_array || - ref->ctrl->type >=3D V4L2_CTRL_COMPOUND_TYPES; - if (id < ref->ctrl->id && - (is_compound & mask) =3D=3D match) + ref =3D NULL; + list_for_each_entry_continue(pos, &hdl->ctrl_refs, node) { + is_compound =3D pos->ctrl->is_array || + pos->ctrl->type >=3D V4L2_CTRL_COMPOUND_TYPES; + if (id < pos->ctrl->id && + (is_compound & mask) =3D=3D match) { + ref =3D pos; break; + } } - if (&ref->node =3D=3D &hdl->ctrl_refs) - ref =3D NULL; } else { + struct v4l2_ctrl_ref *pos; + /* * No control with the given ID exists, so start * searching for the next largest ID. We know there * is one, otherwise the first 'if' above would have * been true. */ - list_for_each_entry(ref, &hdl->ctrl_refs, node) { - is_compound =3D ref->ctrl->is_array || - ref->ctrl->type >=3D V4L2_CTRL_COMPOUND_TYPES; - if (id < ref->ctrl->id && - (is_compound & mask) =3D=3D match) + list_for_each_entry(pos, &hdl->ctrl_refs, node) { + is_compound =3D pos->ctrl->is_array || + pos->ctrl->type >=3D V4L2_CTRL_COMPOUND_TYPES; + if (id < pos->ctrl->id && + (is_compound & mask) =3D=3D match) { + ref =3D pos; break; + } } - if (&ref->node =3D=3D &hdl->ctrl_refs) - ref =3D NULL; } } mutex_unlock(hdl->lock); --=20 2.44.0.478.gd926399ef9-goog From nobody Sun Feb 8 17:03:54 2026 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47B21184115 for ; Wed, 10 Apr 2024 21:54:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712786091; cv=none; b=MEBdWA4RRcqNzwd/juqlNweqw1PGbSKbNqBg7kJCU8LjKe28mUSHSVfd7I4Z5kAqdN221KPE8a42baWjbk1Q81O8bC4k8/o9RIlPWOofe1fE1UCqu51LK5+BScWNachD96bP6kF6N5FAFJwGcWahjcvWVGJcvqv2Fp+yD0cx5OU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712786091; c=relaxed/simple; bh=erFijxCE7zR4MV8ri3c+dXbrtlOTrRZHHMfpIM9iaXc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EG2qCWrvXcZwxlFC19FGbncHdcWO6EO5cVlv3KsN04h+kz/ic8VLhFYfz/l1JSZIH/D0z6Vw7CyiyS9grySCV2htVJlVTSDCEFCJCtvwRx/toGM4wc++tqzTWOUHg3byedGYLlQKziHC/dIUrhXuNNJ7p5V+Odjoa7N59X8lrdU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=dj0O1aJc; arc=none smtp.client-ip=209.85.160.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dj0O1aJc" Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-436433a44bcso4289171cf.1 for ; Wed, 10 Apr 2024 14:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1712786089; x=1713390889; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8qecfLVtRY76Bzg8oTSRe9RiU8Ab1ycKtqOn34KzQpM=; b=dj0O1aJcd8aLrfFIDPAHRcIK0AoBdX/2TG3hNhzkW/pkpX4cQ3HNqIG32rAX5V/c++ 2yBq0kx0oOgpcQOcbBwtKsm72jiUIrvuG+hPgJzmhpmEhO3fnnihkkOwqfSY6viUeqVR Mch4HjnRyMWJkzTxbKkEdsmEatC4ucBWeHFG8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712786089; x=1713390889; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8qecfLVtRY76Bzg8oTSRe9RiU8Ab1ycKtqOn34KzQpM=; b=oepgDmh+NAaeVzRZVsLKyhocZwSfjqpV+pzercZ3/M2D5uZ48PYkcP0K5jUAvbPvkM 1qCE1+Vk+sBcCmKRMvEovNdo8vvd8t+ljCtz4NG0y+/VbYLzqHV7ibm1g2JyYhskbkP5 ZteM/W2lG3GP7ybPNYuHnXfeup0VK/LW3uBAxe9C1taCuavixUjWD3o4ua1lcFDjemcH PwSYgbPO84HVBRIJNcimQBIZqIdldQi9+R61XXTxyHbOgViBOIzTs6AqOGX5P2d9TBsY EIAdKUiZDt75soMQV63jtrlRh0zvzOVqZINdSxFbFKnucFe8IxiNYOQB+M1eyL+uwBYa CiuA== X-Forwarded-Encrypted: i=1; AJvYcCV+UulxHDZDzfcZkmtJF/1kTqCw2j9J0/38iyw5KDOHuzQS7TQuZq9EumStWHRNGqc3neikrVcelSM9A+0VAm2k97KDvTALykApGYPO X-Gm-Message-State: AOJu0Yw+ZcTcl71Qyl0AlfDR1QHnoc006X/yGFewScwUXAiJGxeLuCD9 9nLIAgoftISr96mB4PinwxNQMOgGlq2mLtybTTwOe6AeaSkbLtNJ+2bxy/7ewg== X-Google-Smtp-Source: AGHT+IHWRJcHJfSG5kAL0HKOg8jZfMWKObhg9YFida2UCaj9AtmVdqisiCqcJB1326MCtC9PfVIBrQ== X-Received: by 2002:ac8:7f42:0:b0:434:8cf5:b274 with SMTP id g2-20020ac87f42000000b004348cf5b274mr4147900qtk.59.1712786089349; Wed, 10 Apr 2024 14:54:49 -0700 (PDT) Received: from denia.c.googlers.com (188.173.86.34.bc.googleusercontent.com. [34.86.173.188]) by smtp.gmail.com with ESMTPSA id kg26-20020a05622a761a00b00434c1eedb0esm67330qtb.36.2024.04.10.14.54.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 14:54:49 -0700 (PDT) From: Ricardo Ribalda Date: Wed, 10 Apr 2024 21:54:42 +0000 Subject: [PATCH 5/6] media: adv7180: Only request valids IRQs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240410-smatch-v1-5-785d009a852b@chromium.org> References: <20240410-smatch-v1-0-785d009a852b@chromium.org> In-Reply-To: <20240410-smatch-v1-0-785d009a852b@chromium.org> To: Mauro Carvalho Chehab , Yasunari Takiguchi , Jean-Christophe Trotin , Lars-Peter Clausen , Dmitry Torokhov Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 i2c_device_probe(), seems to assume that irq =3D 0 means that there is no irq to request. The driver also believes that on the clean path. So lets be consistent here. Also make smatch happy. Fix: drivers/media/i2c/adv7180.c:1526 adv7180_probe() warn: 'client->irq' from r= equest_threaded_irq() not released on lines: 1526 Signed-off-by: Ricardo Ribalda --- drivers/media/i2c/adv7180.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c index 4829cbe324198..819ff9f7c90fe 100644 --- a/drivers/media/i2c/adv7180.c +++ b/drivers/media/i2c/adv7180.c @@ -1486,7 +1486,7 @@ static int adv7180_probe(struct i2c_client *client) if (ret) goto err_media_entity_cleanup; =20 - if (state->irq) { + if (state->irq > 0) { ret =3D request_threaded_irq(client->irq, NULL, adv7180_irq, IRQF_ONESHOT | IRQF_TRIGGER_FALLING, KBUILD_MODNAME, state); --=20 2.44.0.478.gd926399ef9-goog From nobody Sun Feb 8 17:03:54 2026 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED14C19068D for ; Wed, 10 Apr 2024 21:54:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712786092; cv=none; b=kjg73HcyB0BcP6KJDi4oFt7ZPF60Umj3HHf2aGF5c1SpfZICYtaCOEIeNVqIIM32GANowxfxPzzXhexyMJfFdQHZLPiJHwkTFrUhMdXSEtdzA4FmQO1k4IMPj7ybFwCLhhxH2W+yH2znsO4H45CMCXdNidHwgjB2XnNZ6QATGLc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712786092; c=relaxed/simple; bh=qYUzmqmdLZgDJPzb/J2uf6pd/pTz/IsAT54nGnkJH48=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BoK90sURhn+/11xpgxfy+atxQ6u81RmkC1eDjRFwSvPL02TbZXX1OoQ1899nfNu46YYZ6x0a+2JZdvYjh6eGEcpwLIZ2dqt29DaesrJnm34dReAkNeh0qAX4J3GjgQKhcoy/yf7dLAlbnZvO3pPpKGNF6sF9feDPS94g6gAIV6I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=dhuK/Gub; arc=none smtp.client-ip=209.85.160.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dhuK/Gub" Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-43446959b33so31105811cf.3 for ; Wed, 10 Apr 2024 14:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1712786090; x=1713390890; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=qTzjP1Nv4ThzlLlE1Ju5kdcsL0LhZGtnYro6XcnlOmk=; b=dhuK/Gubb2eeHhJXl6V5/9G4V3kAKIumQyn5+PG8yTe1F1kXUknFJfB4MEs0hv/NNF RG3vjW0kOgl/N6Y+3wrt2JYaFoz6P9Lrb4NuWSKmU0m2g8P4ETz8YXxX9v1OkMK9363F GJFdE2D7ImvLiiCUQstdNFqD4iK/qQRpyefms= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712786090; x=1713390890; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qTzjP1Nv4ThzlLlE1Ju5kdcsL0LhZGtnYro6XcnlOmk=; b=avEhF3LcaD0zb8q3RzK9PSjKeDzw5bsTQE5kHXkq+p3tmC16Z0NI5oiWAjwDL4UWAp +5kZD9Bw85ZH+UET+vO91vqdLlR7o7MHSsrvTUhKUpwzG8MnGpNyAbC2R4QA7S5eGFq5 n4S0ju9KGoIX4KEV7SpPIywr2na8Ek5Yot67yPXV7uwhxExXdGD2wOJcjnpHOQiVUF/o 9Q5wZ/oCl7200jP8bDXR77H4NtzqrKszWD0bn1QBLdRYzjZPEem8dHIu/Cb9y7F2C94S 0uQi3nioN8ZyADGRuXIPh5IUkaZ9DeCrkqhDod4D5BlnXaegYzfXrA5mLAi/fdu/No/e SX2g== X-Forwarded-Encrypted: i=1; AJvYcCWVpjndQYSaSuj0r9OHub6zJyKCQY9Fs9TKVFTO4NJwFJaNsTAY38SG2JDrdEbhIWIO0f9OGuxxC1o6bGxrMyF/XtcaTOpiN+LZbcCq X-Gm-Message-State: AOJu0YzK1zAglNkeu+kuPqXv4zIB4NcikwfkvF7kMgYSGs4secGcJWT9 rnZABNAgNeVRJzdPK2hexiSKYk/o389boH3F4vc7Y7cwgpdFcVG6oD5mKB6CLA== X-Google-Smtp-Source: AGHT+IHLvqSrxvThaEcLle6Xam6RG78CJ3NyLYmwXsqsdgP3jJ/C4bjd1BGbbwL3hfA5aXl4iG7EWw== X-Received: by 2002:a05:622a:34d:b0:435:18b:d78 with SMTP id r13-20020a05622a034d00b00435018b0d78mr4122157qtw.29.1712786089958; Wed, 10 Apr 2024 14:54:49 -0700 (PDT) Received: from denia.c.googlers.com (188.173.86.34.bc.googleusercontent.com. [34.86.173.188]) by smtp.gmail.com with ESMTPSA id kg26-20020a05622a761a00b00434c1eedb0esm67330qtb.36.2024.04.10.14.54.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 14:54:49 -0700 (PDT) From: Ricardo Ribalda Date: Wed, 10 Apr 2024 21:54:43 +0000 Subject: [PATCH 6/6] media: touchscreen: sur40: convert le16 to cpu before use Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240410-smatch-v1-6-785d009a852b@chromium.org> References: <20240410-smatch-v1-0-785d009a852b@chromium.org> In-Reply-To: <20240410-smatch-v1-0-785d009a852b@chromium.org> To: Mauro Carvalho Chehab , Yasunari Takiguchi , Jean-Christophe Trotin , Lars-Peter Clausen , Dmitry Torokhov Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.12.4 Smatch found this issue: drivers/input/touchscreen/sur40.c:424:55: warning: incorrect type in argume= nt 2 (different base types) drivers/input/touchscreen/sur40.c:424:55: expected int key drivers/input/touchscreen/sur40.c:424:55: got restricted __le16 [usertyp= e] blob_id Signed-off-by: Ricardo Ribalda --- drivers/input/touchscreen/sur40.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/= sur40.c index ae3aab4283370..5f2cf8881e724 100644 --- a/drivers/input/touchscreen/sur40.c +++ b/drivers/input/touchscreen/sur40.c @@ -421,7 +421,7 @@ static void sur40_report_blob(struct sur40_blob *blob, = struct input_dev *input) if (blob->type !=3D SUR40_TOUCH) return; =20 - slotnum =3D input_mt_get_slot_by_key(input, blob->blob_id); + slotnum =3D input_mt_get_slot_by_key(input, le16_to_cpu(blob->blob_id)); if (slotnum < 0 || slotnum >=3D MAX_CONTACTS) return; =20 --=20 2.44.0.478.gd926399ef9-goog