From nobody Mon Feb 9 01:16:49 2026 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0545A6A033 for ; Tue, 9 Apr 2024 02:32:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712629951; cv=none; b=GbHCbxryKeXM4+TV4TvSCxEREwAeVnkKP1QWEYn4Hav9Rq+KJ3N5c6LzWcQ+75ace6n2ZZTTiBt2kRPXolTnm0pXWQjm1x8rInVBaDDi4c9YxEvAtz4k+X5jGxmiswP1Jdg8pxz9ZDnK6RgO+d+4gyEylPFaJNkH8yIAFYepg+0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712629951; c=relaxed/simple; bh=xHsqseGo45EFWIp81P0tGMdoFgzohP0SXk8wpRgIZ/M=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=D/5B7EhNGzN+GHblQCfzqJ/H3Q+2paXuSrWTtLsAkHcdHcBccVYdbug3YlJnRESBK3LkZI3bRIQ51NeoInXm51ghVztMIBYlK9wfjz/Z8O0g074fHN/3Ph11xbT/ec3Q8LytXbrnitiBjYNrBmhqUIMDku5l3qRD/nGRCbfjY/U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=KRIQdS6g; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="KRIQdS6g" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dc64f63d768so8681860276.2 for ; Mon, 08 Apr 2024 19:32:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712629949; x=1713234749; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=/BAUdVwmPAN+ChmE3q8Tcu1VmgKAoqUPA+AHxJ0JyqY=; b=KRIQdS6gSqM7Cz4ZpXf/TfjU83+ld8PARjdjgsTjZB5jsDSlyJQH1FNp6vtjdUev/V Ha3ouiLTbpzSfQtYQSU+HjLfut72Myxq7xmC7f7awy0FKWZN8SyVH2dXwiAimE1IVrqV KYphCN5vLXaSOuZ2GJs78uKk+QVwz4sBlp+A1nx9ioR8t1Eg5yFUco/cXa1jB3NHsVdq DRdGJMdozmX18lywuA/2Esh7RnGdVXt4mqjPOqGggEQ1T0vh8rL0FOIzTl+PvHU/P7Q8 VYq6Ox0UYyWoC5MN/JKwopRDYGr0SdGU2LqdKscCXo2PQbSF/cCHaXLuRz+p0vHm7BvD yYBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712629949; x=1713234749; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/BAUdVwmPAN+ChmE3q8Tcu1VmgKAoqUPA+AHxJ0JyqY=; b=XHbpsIcVzqSGTlChYWYDRy0ed2G0k0lduLDQQUUyKzHyM/6a3smUQZPIcXQTqN2JOj u2TOqQlC9oOCE2aw7vWdvO9xc4cu1szNhvl7IJmpMrKU02a9fieklUaLOk5GtvqF2IKF 2WlAVEbKPFF2sch0cKEz2ehJqCK94KVIcVAB+OyjqkoyWv4d0juBuqiUHTNhcpFyoaVo NT1BHYz1bCeSCsy/q3ExOgJcW0sd+rNNn3MnSt3uXWqhzcSvHySa31yciMxBhXImSHW7 WfLjtKq29O6I6JSnqsPGvhliM2LasCIY1t3+mbSzs6vox7hCW6Vl0hVkV0O3tVVyWyft Z9OQ== X-Forwarded-Encrypted: i=1; AJvYcCWLi8eZDEJO8v3XfzCXMY/6fGCHMRS1UrtSngqcclNALFFhRFhocT1o/VzVzB/Ib85gAsBqcw6DrlkJLJORV6xl08hwvHIRnNzRXCfO X-Gm-Message-State: AOJu0YxP3TQ/36KwPZhFDqMCxqAQcYdDu2DEnaad9xLGWtb/Jvqpi00d DvOkATCFOr1rWVLPncYzrwRL8wweJ+3GG0ub8JwtgerPukG5tZHchYrI2+lXdqRlzzXqWsqnsnX fNmBvyw== X-Google-Smtp-Source: AGHT+IGF6ZTjnu8dVcNXGrughSGYScPK3AYo0PJxMnN9RAliJjpZ62UnoVFK8B/Xe/xfHylwSeuiBANHAUhu X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:5520:7788:6b7d:7115]) (user=irogers job=sendgmr) by 2002:a05:6902:70d:b0:dc6:dfd9:d431 with SMTP id k13-20020a056902070d00b00dc6dfd9d431mr3087229ybt.1.1712629949240; Mon, 08 Apr 2024 19:32:29 -0700 (PDT) Date: Mon, 8 Apr 2024 19:32:16 -0700 In-Reply-To: <20240409023216.2342032-1-irogers@google.com> Message-Id: <20240409023216.2342032-5-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240409023216.2342032-1-irogers@google.com> X-Mailer: git-send-email 2.44.0.478.gd926399ef9-goog Subject: [PATCH v1 4/4] perf trace beauty: Add shellcheck to scripts From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Ravi Bangoria , Kajol Jain , Athira Rajeev , Oliver Upton , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add shell check to scripts generating perf trace lookup tables. Fix quoting issue in arch_errno_names.sh. Signed-off-by: Ian Rogers --- tools/perf/trace/beauty/Build | 14 ++++++++++++++ tools/perf/trace/beauty/arch_errno_names.sh | 8 +++++--- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/tools/perf/trace/beauty/Build b/tools/perf/trace/beauty/Build index d8ce1b698983..cb3c1399ff40 100644 --- a/tools/perf/trace/beauty/Build +++ b/tools/perf/trace/beauty/Build @@ -20,3 +20,17 @@ perf-y +=3D statx.o perf-y +=3D sync_file_range.o perf-y +=3D timespec.o perf-y +=3D tracepoints/ + +ifdef SHELLCHECK + SHELL_TESTS :=3D $(wildcard trace/beauty/*.sh) + TEST_LOGS :=3D $(SHELL_TESTS:trace/beauty/%=3D%.shellcheck_log) +else + SHELL_TESTS :=3D + TEST_LOGS :=3D +endif + +$(OUTPUT)%.shellcheck_log: % + $(call rule_mkdir) + $(Q)$(call echo-cmd,test)shellcheck -s bash -a -S warning "$<" > $@ || (c= at $@ && rm $@ && false) + +perf-y +=3D $(TEST_LOGS) diff --git a/tools/perf/trace/beauty/arch_errno_names.sh b/tools/perf/trace= /beauty/arch_errno_names.sh index 7df4bf5b55a3..30d3889b2957 100755 --- a/tools/perf/trace/beauty/arch_errno_names.sh +++ b/tools/perf/trace/beauty/arch_errno_names.sh @@ -60,10 +60,12 @@ create_arch_errno_table_func() printf 'arch_syscalls__strerrno_t *arch_syscalls__strerrno_function(const= char *arch)\n' printf '{\n' for arch in $archlist; do - printf '\tif (!strcmp(arch, "%s"))\n' $(arch_string "$arch") - printf '\t\treturn errno_to_name__%s;\n' $(arch_string "$arch") + arch_str=3D$(arch_string "$arch") + printf '\tif (!strcmp(arch, "%s"))\n' "$arch_str" + printf '\t\treturn errno_to_name__%s;\n' "$arch_str" done - printf '\treturn errno_to_name__%s;\n' $(arch_string "$default") + arch_str=3D$(arch_string "$default") + printf '\treturn errno_to_name__%s;\n' "$arch_str" printf '}\n' } =20 --=20 2.44.0.478.gd926399ef9-goog