From nobody Sun Feb 8 06:04:22 2026 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CECA916EC03 for ; Fri, 5 Apr 2024 14:15:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326505; cv=none; b=j5yti2t8NGwFjNa1c5RHNUqRiC0I+cMmjeqddSJjjeMjavQX5InpmKzD2j4U5UeaJWwg52WS5FPgdBv4pW3GXMluhRTY2nagTA8b6ZcuWEaOH+kmH//bL8g45l22r4yRyw1o3kBE+3COLij2QPTKrKOh+abRvCkypDpEP7YUDck= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326505; c=relaxed/simple; bh=5XRJmffCvoTFmT8VVV2m0fHxLKA4GHevMj3V5iq7Qd8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=nZ5VBsNDGi/b6yXXMDZAQikIWIcdoC52LG6JQeXt/Tk04QhrdmxTUVCkhLJeI78HxwXjO6ghH1U6V9NFJr2dRnoNhaF5lmXcUINL2OpVjR9WDGbR1OZIua1ZMTQkQKUnousNUzZfcN/nQaBJrH5GTNpBomFRRPL6F8KhjjDWaSE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=NoHgHgf4; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="NoHgHgf4" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-4155e2ed5d8so16674095e9.1 for ; Fri, 05 Apr 2024 07:15:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712326502; x=1712931302; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=jnT4iGgtwWQMG15A5RV71jOjD3/1N8JXSjbIzrqMBWI=; b=NoHgHgf4dxBorDPnOm1HhYp+TU+A6W7awm1ERggt9ry6y4s34IZH6OJnurh1inBy7w p+9R2TMXipvSLut8Q+0OwJzVkzUj85XtT963Qw8FqjEMXw+NRGrj83bXd4sskoEj1vsm Dhx+bhuZVXscvcVLw00TAoQMNekqPrjlXQYOEpLiMyrML60gDD5zAMIFXhYtYKZjrTlu pjMWUQujFM3r13E1JaVYjVqOyAjRAaKQr5ny258C8eyplzfCUyMdKX0p2NlpyLM150YI tnjwH8wHsVBrGymsjNTmc96Ph+4qPQRX+FJE+ApkWwLuPyNOwc0Zdx4gosGVkY5aE5y5 Z09A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712326502; x=1712931302; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=jnT4iGgtwWQMG15A5RV71jOjD3/1N8JXSjbIzrqMBWI=; b=DBCWHkYGrW/KXoGjORZUtoPOK01PFHV8MhRz4aDSCUezC0AeRwAIJGO9LIwtko2nZJ 5L3b15vXK2LO4wbag6CwLXuyYC/iuVV9rGXjtl8q5m87k3Zx/73ok50ZQw0ZbpohviLS bgeXoYyI5VetGvrmycskH8WKoEE2px0333uOJHDNeJGBgnbqJqpGMVEGbZ+1vbmRAmmU ep8ofpZwuQHzLbZxRRqv+IV6p+5sUtn6disdsOrtA8qQzB3dHbVQQdERv+GmkfMPgXSd myGw8qO5bPHzdUk5mNymNnhAP89/xARTu5CwuFKxfsfuCj60doktN11hyT+OEOMpIkXk NuhQ== X-Forwarded-Encrypted: i=1; AJvYcCW5voMXEoF2ENAOPf1Ls45WsmDAB0HDFykoWp1Kgw7/jMQIMX2Iewo9MWWcxvFU9UJa7YKJKyNWod1ieoZQ9j4IQ080ZrFTHBIdHhew X-Gm-Message-State: AOJu0YwQcldvPu5OJXt7chbxGkkqwrW3tfGmVZ+HJZ42fX8MY3J2sEt3 EmUHu6c0sxwMdzcWZ5CakezdNg/AuDAc06xEx9g5s6ZN1zMf3Av4szlO0q2dTPxkieeiHc5GLce ysXxRlVl86A== X-Google-Smtp-Source: AGHT+IF7fT+tsywJe0mO2bG/yk2w9c89FveDuuUwn/6Zcv/Ube9lm7A2JE006Ic154bx2/3VtCB/27lzySO0ug== X-Received: from szatan.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:2d83]) (user=panikiel job=sendgmr) by 2002:a05:600c:470d:b0:416:3307:a047 with SMTP id v13-20020a05600c470d00b004163307a047mr17569wmo.2.1712326502095; Fri, 05 Apr 2024 07:15:02 -0700 (PDT) Date: Fri, 5 Apr 2024 14:13:56 +0000 In-Reply-To: <20240405141411.1807189-1-panikiel@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240405141411.1807189-1-panikiel@google.com> X-Mailer: git-send-email 2.44.0.478.gd926399ef9-goog Message-ID: <20240405141411.1807189-2-panikiel@google.com> Subject: [PATCH 01/16] media: v4l2-subdev: Add pad versions of dv timing subdev calls From: "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" To: kieran.bingham@ideasonboard.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, tharvey@gateworks.com, niklas.soderlund@ragnatech.se, prabhakar.csengg@gmail.com, charles-antoine.couret@nexvision.fr, thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com, luca.ceresoli@bootlin.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chromeos-krk-upstreaming@google.com, "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently, subdev dv timing calls (i.e. g/s/query_dv_timings) are video ops without a pad argument. This is a problem if the subdevice can have different dv timings for each pad (e.g. a DisplayPort receiver with multiple virtual channels). To solve this, change these calls to include a pad argument, and put them into pad ops. Keep the old ones temporarily to make the switch easier. Signed-off-by: Pawe=C5=82 Anikiel --- drivers/media/v4l2-core/v4l2-subdev.c | 33 +++++++++++++++++++++++++++ include/media/v4l2-subdev.h | 14 ++++++++++++ 2 files changed, 47 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-cor= e/v4l2-subdev.c index 4c6198c48dd6..07759cdd0844 100644 --- a/drivers/media/v4l2-core/v4l2-subdev.c +++ b/drivers/media/v4l2-core/v4l2-subdev.c @@ -369,6 +369,36 @@ static int call_set_edid(struct v4l2_subdev *sd, struc= t v4l2_subdev_edid *edid) return check_edid(sd, edid) ? : sd->ops->pad->set_edid(sd, edid); } =20 +static int call_s_dv_timings(struct v4l2_subdev *sd, unsigned int pad, + struct v4l2_dv_timings *timings) +{ + if (!timings) + return -EINVAL; + + return check_pad(sd, pad) ? : + sd->ops->pad->s_dv_timings(sd, pad, timings); +} + +static int call_g_dv_timings(struct v4l2_subdev *sd, unsigned int pad, + struct v4l2_dv_timings *timings) +{ + if (!timings) + return -EINVAL; + + return check_pad(sd, pad) ? : + sd->ops->pad->g_dv_timings(sd, pad, timings); +} + +static int call_query_dv_timings(struct v4l2_subdev *sd, unsigned int pad, + struct v4l2_dv_timings *timings) +{ + if (!timings) + return -EINVAL; + + return check_pad(sd, pad) ? : + sd->ops->pad->query_dv_timings(sd, pad, timings); +} + static int call_dv_timings_cap(struct v4l2_subdev *sd, struct v4l2_dv_timings_cap *cap) { @@ -487,6 +517,9 @@ static const struct v4l2_subdev_pad_ops v4l2_subdev_cal= l_pad_wrappers =3D { .set_frame_interval =3D call_set_frame_interval, .get_edid =3D call_get_edid, .set_edid =3D call_set_edid, + .s_dv_timings =3D call_s_dv_timings, + .g_dv_timings =3D call_g_dv_timings, + .query_dv_timings =3D call_query_dv_timings, .dv_timings_cap =3D call_dv_timings_cap, .enum_dv_timings =3D call_enum_dv_timings, .get_frame_desc =3D call_get_frame_desc, diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h index a9e6b8146279..a5213411ef2b 100644 --- a/include/media/v4l2-subdev.h +++ b/include/media/v4l2-subdev.h @@ -791,6 +791,14 @@ struct v4l2_subdev_state { * * @set_edid: callback for VIDIOC_SUBDEV_S_EDID() ioctl handler code. * + * @s_dv_timings: Set custom dv timings in the sub device. This is used + * when sub device is capable of setting detailed timing information + * in the hardware to generate/detect the video signal. + * + * @g_dv_timings: Get custom dv timings in the sub device. + * + * @query_dv_timings: callback for VIDIOC_QUERY_DV_TIMINGS() ioctl handler= code. + * * @dv_timings_cap: callback for VIDIOC_SUBDEV_DV_TIMINGS_CAP() ioctl hand= ler * code. * @@ -864,6 +872,12 @@ struct v4l2_subdev_pad_ops { struct v4l2_subdev_frame_interval *interval); int (*get_edid)(struct v4l2_subdev *sd, struct v4l2_edid *edid); int (*set_edid)(struct v4l2_subdev *sd, struct v4l2_edid *edid); + int (*s_dv_timings)(struct v4l2_subdev *sd, unsigned int pad, + struct v4l2_dv_timings *timings); + int (*g_dv_timings)(struct v4l2_subdev *sd, unsigned int pad, + struct v4l2_dv_timings *timings); + int (*query_dv_timings)(struct v4l2_subdev *sd, unsigned int pad, + struct v4l2_dv_timings *timings); int (*dv_timings_cap)(struct v4l2_subdev *sd, struct v4l2_dv_timings_cap *cap); int (*enum_dv_timings)(struct v4l2_subdev *sd, --=20 2.44.0.478.gd926399ef9-goog From nobody Sun Feb 8 06:04:22 2026 Received: from mail-wr1-f74.google.com (mail-wr1-f74.google.com [209.85.221.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BAEF16EC1D for ; Fri, 5 Apr 2024 14:15:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326507; cv=none; b=S1qL+M/aPkx0UznHvaTYrDXpterxyZgpvYYB+Hyip9pt4Iw9CZYzQoN4E7+hHxYQPYjgE63qlZhq0MXwA5S9fYTnjjzb5PiywacWuDpo3jX5+65xXTB7CepGpyqDcKABNU9LPlGNiY5UUYcEFrr1eILSCWOXy6KM6H7D0U+Cf9U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326507; c=relaxed/simple; bh=6EehccEvTPWYOq7+XxW7U39Z7ElCZmB+5qet67lPQQs=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Mhav7C/nyF21LTTjWzyygF7bRyELOzB3vvI5As4FCJxYvrtke1pqCyhHwn7O+n1EWeThAhu/Uih+qKoYWmeo3wh6CMyHhffqeDOJzru9oMvifnIVlODgmmV52nvXSA3kupix5DRPBchQgH1x0mypcHrYZBj5orVPvjZ/2V41+kE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=r5l6/Ip/; arc=none smtp.client-ip=209.85.221.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="r5l6/Ip/" Received: by mail-wr1-f74.google.com with SMTP id ffacd0b85a97d-3418412a734so1425092f8f.0 for ; Fri, 05 Apr 2024 07:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712326504; x=1712931304; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=EB1OqCeM+zzEWfmV9H/3BRd83N3O3aUGhb7gLO7v4Gs=; b=r5l6/Ip/rFUB8dW3ahq9kAitPKmB9Lngsi3ub2sxepQil40+4ROeQkPAvQUAWFsgc7 xfoIezE6JCZf0nD0tTKsr9FE45OVKMVrhqf8oRuZalW7p9cqKECi7SCf4r7kMhhk8PV9 VtZ4vBAVwJ+TSwkOejCwdapx0zwPQulR1jxfEsZBN3dv9HHPZDEYMbfnOBVLak/cs64X 6AFdmUBQRJc2rQvdeWkjbNOXH8VZhBpTs3e2QI1XiCvBmj2zzUk/vpvXc2CTtASlaGyj 0X/Sbeaud4Q3qWHRDdxmj/+HF6J+DOfqAjBL6IZnhhImCMxKfsirjt/VC9J+dVQyqDmL 0mZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712326504; x=1712931304; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=EB1OqCeM+zzEWfmV9H/3BRd83N3O3aUGhb7gLO7v4Gs=; b=vSrWGoY8KoghKV90qnti/g6PrEbbx/HzVM5PCXqfPIaCPg6N/6hcbvNdf8/Ez6wZ0b TAoHiL5WkdLISax8oaZEvD5NIObNhKA8MDHrmj4Pi6df3cnrFBGpAZCIk6wL2W9D8vPm S1Lfozqs3b4qhGtZXtK10wS6cB3WTJxp88qegs2xx4gaEycgQfeVKuMZdh3uqom0tnrw be7lXcmxxa6aRLLrv5KQBjF4bfq8k3qd/Syro4Vp4F5P3i1gK8wsidogHliEosm88o3o vud0ZWW8/wZkSfX7G4h8uLlch2XCIb1LZCiVwBd10xbgIkZUOoX3MnnHDHZAoDsJh5SJ G05w== X-Forwarded-Encrypted: i=1; AJvYcCWEBapIiJAUXGsrt0Mxwlf8t2PFY4p8es5/vECkJUhpgpZClBEdTh/0Ojzz09tPEWlKKFiTKn/ijG36l+0oXhLqT4IOYRpe9j+X70ez X-Gm-Message-State: AOJu0YwSM4UXNI8Y50tc94TA8TfhGLpLtS16KLVcR3yQYth4xwoysrt0 ARCs3ANIKblK+dZGMYX3jKWgx+beeoy/ni4OxOkA8Bf4Z6pmxIcMXRE12njJ06Dxb9jtqfA0uP2 5cN1+tZFnpA== X-Google-Smtp-Source: AGHT+IHxUh/sNELzePmUjUKXOONpTWRH6C10MHQYsitlB4/bEok8pDIcPZmqe/e/AmmgnCRzPUYVo9trVTS96A== X-Received: from szatan.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:2d83]) (user=panikiel job=sendgmr) by 2002:a05:6000:1d9c:b0:343:ce9e:3732 with SMTP id bk28-20020a0560001d9c00b00343ce9e3732mr2847wrb.11.1712326504331; Fri, 05 Apr 2024 07:15:04 -0700 (PDT) Date: Fri, 5 Apr 2024 14:13:57 +0000 In-Reply-To: <20240405141411.1807189-1-panikiel@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240405141411.1807189-1-panikiel@google.com> X-Mailer: git-send-email 2.44.0.478.gd926399ef9-goog Message-ID: <20240405141411.1807189-3-panikiel@google.com> Subject: [PATCH 02/16] media: i2c: adv748x: Switch dv timing callbacks to pad ops From: "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" To: kieran.bingham@ideasonboard.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, tharvey@gateworks.com, niklas.soderlund@ragnatech.se, prabhakar.csengg@gmail.com, charles-antoine.couret@nexvision.fr, thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com, luca.ceresoli@bootlin.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chromeos-krk-upstreaming@google.com, "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Change all (s|g|query)_dv_timings subdev callbacks to include a pad argument. Signed-off-by: Pawe=C5=82 Anikiel Tested-by: Niklas S=C3=B6derlund --- drivers/media/i2c/adv748x/adv748x-hdmi.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/media/i2c/adv748x/adv748x-hdmi.c b/drivers/media/i2c/a= dv748x/adv748x-hdmi.c index ec151dc69c23..a4db9bae5f79 100644 --- a/drivers/media/i2c/adv748x/adv748x-hdmi.c +++ b/drivers/media/i2c/adv748x/adv748x-hdmi.c @@ -214,7 +214,7 @@ static int adv748x_hdmi_set_video_timings(struct adv748= x_state *state, * v4l2_subdev_video_ops */ =20 -static int adv748x_hdmi_s_dv_timings(struct v4l2_subdev *sd, +static int adv748x_hdmi_s_dv_timings(struct v4l2_subdev *sd, unsigned int = pad, struct v4l2_dv_timings *timings) { struct adv748x_hdmi *hdmi =3D adv748x_sd_to_hdmi(sd); @@ -254,7 +254,7 @@ static int adv748x_hdmi_s_dv_timings(struct v4l2_subdev= *sd, return ret; } =20 -static int adv748x_hdmi_g_dv_timings(struct v4l2_subdev *sd, +static int adv748x_hdmi_g_dv_timings(struct v4l2_subdev *sd, unsigned int = pad, struct v4l2_dv_timings *timings) { struct adv748x_hdmi *hdmi =3D adv748x_sd_to_hdmi(sd); @@ -269,7 +269,7 @@ static int adv748x_hdmi_g_dv_timings(struct v4l2_subdev= *sd, return 0; } =20 -static int adv748x_hdmi_query_dv_timings(struct v4l2_subdev *sd, +static int adv748x_hdmi_query_dv_timings(struct v4l2_subdev *sd, unsigned = int pad, struct v4l2_dv_timings *timings) { struct adv748x_hdmi *hdmi =3D adv748x_sd_to_hdmi(sd); @@ -392,9 +392,6 @@ static int adv748x_hdmi_g_pixelaspect(struct v4l2_subde= v *sd, } =20 static const struct v4l2_subdev_video_ops adv748x_video_ops_hdmi =3D { - .s_dv_timings =3D adv748x_hdmi_s_dv_timings, - .g_dv_timings =3D adv748x_hdmi_g_dv_timings, - .query_dv_timings =3D adv748x_hdmi_query_dv_timings, .g_input_status =3D adv748x_hdmi_g_input_status, .s_stream =3D adv748x_hdmi_s_stream, .g_pixelaspect =3D adv748x_hdmi_g_pixelaspect, @@ -413,7 +410,7 @@ static int adv748x_hdmi_propagate_pixelrate(struct adv7= 48x_hdmi *hdmi) if (!tx) return -ENOLINK; =20 - adv748x_hdmi_query_dv_timings(&hdmi->sd, &timings); + adv748x_hdmi_query_dv_timings(&hdmi->sd, 0, &timings); =20 return adv748x_csi2_set_pixelrate(tx, timings.bt.pixelclock); } @@ -610,6 +607,9 @@ static const struct v4l2_subdev_pad_ops adv748x_pad_ops= _hdmi =3D { .get_fmt =3D adv748x_hdmi_get_format, .get_edid =3D adv748x_hdmi_get_edid, .set_edid =3D adv748x_hdmi_set_edid, + .s_dv_timings =3D adv748x_hdmi_s_dv_timings, + .g_dv_timings =3D adv748x_hdmi_g_dv_timings, + .query_dv_timings =3D adv748x_hdmi_query_dv_timings, .dv_timings_cap =3D adv748x_hdmi_dv_timings_cap, .enum_dv_timings =3D adv748x_hdmi_enum_dv_timings, }; @@ -734,7 +734,7 @@ int adv748x_hdmi_init(struct adv748x_hdmi *hdmi) struct v4l2_dv_timings cea1280x720 =3D V4L2_DV_BT_CEA_1280X720P30; int ret; =20 - adv748x_hdmi_s_dv_timings(&hdmi->sd, &cea1280x720); + adv748x_hdmi_s_dv_timings(&hdmi->sd, 0, &cea1280x720); =20 /* Initialise a default 16:9 aspect ratio */ hdmi->aspect_ratio.numerator =3D 16; --=20 2.44.0.478.gd926399ef9-goog From nobody Sun Feb 8 06:04:22 2026 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DB8F16F0CD for ; Fri, 5 Apr 2024 14:15:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326509; cv=none; b=HueU4bGAUlnSfAxf1bn/8yexG9DjwQL4N7dHQFXk+3L/i9jASnZXJqCrqqmnkCCyAD89zAwctIqk3QPyXfbZmfEr1YhXUU90MhfI0b1fAp1GK0lpcEDrG+ffOr9xwWlUwYqpi1M3r+is7QspyX0hS2xgg3IjCHqr3EfMC88JWBY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326509; c=relaxed/simple; bh=iylO9QdIY6acvXIk57+sD8IMYliPnmH08v8DfuMIWpw=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=LxYmhLbH+1mSAJmCzdEKCjo/AVfa/jI6CAf/yCK0PTlafOdAIuGVHW1nt0B78YnvCCGQowmrcFSPOYCS8a8+xnXaSZbI8cH9haZ/dai+UGbHMidxVvMT3+9iY7AmjZ0KZgi2thDqOQjfGy+0tFDYN3mBb06vEhDj6OATxeGCiCw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Cvaz3ecz; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Cvaz3ecz" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-dc6b26845cdso3247476276.3 for ; Fri, 05 Apr 2024 07:15:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712326506; x=1712931306; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=G/Y7QBSs5jxIOwBWz8/SWyYZH9f8APjHhQAUen0aR5o=; b=Cvaz3ecztK7QiHLYudSp4uip7Nc6m5FTdgW1nGERFl1sSnImCnMFBhZWdyFl2oyWnk +KppcYTs19XDsvzeT9EVkguEiurx51Ax7V5QmNe7wKvq+P1DYMSRjOfC6Y504EFb5UJx zvHX238iiZZVM5EGzH7XckfQjk2ezOhfezVmCSiTo6veLlUb0SblOIvcIrJwolrCBOcp w26Bz0GiTPvje5f3RTPjrdk2m90f6zZ6jkjpG64inrQjAgGRNhPXHG9sGD3VgJWo3JFR QYiUK+91WgLHvVSM1YyBVQ93GM+EWWmVJm572Lie+rmsfPJakwwdoeJwfuGq0quDE5yc tm0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712326506; x=1712931306; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=G/Y7QBSs5jxIOwBWz8/SWyYZH9f8APjHhQAUen0aR5o=; b=o4A4TVUHAK+rE/mG3VHck+NQhIkVJi4kzV79n7h9AaUCqk/As9wAMh2kQd9mpT/zIV QVyNOqKI7Zfkg8tutH8ZRLYANcMSWr3wBWypecUVt9JmI6ddKm0JOgSVThj064PTCLk6 jZRBbUZm9cXikE/rea/6oTRtaUM9JheXMQ0XoBwf1GMXRcvb4WfkVdbROEiy8uQ53Szd kRQX7UYYf+02mD2daPMLgL5/zm63QlQOq/Qm8EZyMW3pZ3JndOJ2b9QF7CMv04SdvGbV IydK57kJeQX0QK91oXqEB0UbZIiQA3XuX8M7FPLDx1kDTJzNzCFmmtO3y5IbYYAXT/Od lw0w== X-Forwarded-Encrypted: i=1; AJvYcCVTQGpQpuhpo1y/HBnxMJn9Bjc+co9ZIxI3uYru3FW2E83Z1XvL1LzakrgP0zJlSOQ24HtqrV/Qac2lr88PIAna092NZEjEdoKTGHhF X-Gm-Message-State: AOJu0Yz/jkCpS2NSl3NunFnvPyhmMxCJYaL5aUiITIFZaxDIRHj0a/dw qF+baZcMt0rFgFpLuUgEGv1gcSPvEFDIAfJz5CJ2BYlc7mI7LRpHSeu/hnQltUX9n/NniYzl628 5MndbC4NKMg== X-Google-Smtp-Source: AGHT+IFl16zX1rOrdVwa2sMyYfgvPB9BWMtRkPdr6CNPVhFQBRvPklQwYD9v0qOkBRPDEwYWoreVm7kZ3ErTug== X-Received: from szatan.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:2d83]) (user=panikiel job=sendgmr) by 2002:a05:6902:100b:b0:dcc:6065:2b3d with SMTP id w11-20020a056902100b00b00dcc60652b3dmr393635ybt.8.1712326506516; Fri, 05 Apr 2024 07:15:06 -0700 (PDT) Date: Fri, 5 Apr 2024 14:13:58 +0000 In-Reply-To: <20240405141411.1807189-1-panikiel@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240405141411.1807189-1-panikiel@google.com> X-Mailer: git-send-email 2.44.0.478.gd926399ef9-goog Message-ID: <20240405141411.1807189-4-panikiel@google.com> Subject: [PATCH 03/16] media: i2c: adv7511: Switch dv timing callbacks to pad ops From: "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" To: kieran.bingham@ideasonboard.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, tharvey@gateworks.com, niklas.soderlund@ragnatech.se, prabhakar.csengg@gmail.com, charles-antoine.couret@nexvision.fr, thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com, luca.ceresoli@bootlin.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chromeos-krk-upstreaming@google.com, "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Change all (s|g|query)_dv_timings subdev callbacks to include a pad argument. Signed-off-by: Pawe=C5=82 Anikiel --- drivers/media/i2c/adv7511-v4l2.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/adv7511-v4l2.c b/drivers/media/i2c/adv7511-v= 4l2.c index 0f780eb6ef63..00fbe411429a 100644 --- a/drivers/media/i2c/adv7511-v4l2.c +++ b/drivers/media/i2c/adv7511-v4l2.c @@ -995,7 +995,7 @@ static int adv7511_s_stream(struct v4l2_subdev *sd, int= enable) return 0; } =20 -static int adv7511_s_dv_timings(struct v4l2_subdev *sd, +static int adv7511_s_dv_timings(struct v4l2_subdev *sd, unsigned int pad, struct v4l2_dv_timings *timings) { struct adv7511_state *state =3D get_adv7511_state(sd); @@ -1004,6 +1004,9 @@ static int adv7511_s_dv_timings(struct v4l2_subdev *s= d, =20 v4l2_dbg(1, debug, sd, "%s:\n", __func__); =20 + if (pad !=3D 0) + return -EINVAL; + /* quick sanity check */ if (!v4l2_valid_dv_timings(timings, &adv7511_timings_cap, NULL, NULL)) return -EINVAL; @@ -1042,13 +1045,16 @@ static int adv7511_s_dv_timings(struct v4l2_subdev = *sd, return 0; } =20 -static int adv7511_g_dv_timings(struct v4l2_subdev *sd, +static int adv7511_g_dv_timings(struct v4l2_subdev *sd, unsigned int pad, struct v4l2_dv_timings *timings) { struct adv7511_state *state =3D get_adv7511_state(sd); =20 v4l2_dbg(1, debug, sd, "%s:\n", __func__); =20 + if (pad !=3D 0) + return -EINVAL; + if (!timings) return -EINVAL; =20 @@ -1078,8 +1084,6 @@ static int adv7511_dv_timings_cap(struct v4l2_subdev = *sd, =20 static const struct v4l2_subdev_video_ops adv7511_video_ops =3D { .s_stream =3D adv7511_s_stream, - .s_dv_timings =3D adv7511_s_dv_timings, - .g_dv_timings =3D adv7511_g_dv_timings, }; =20 /* ------------------------------ AUDIO OPS ------------------------------= */ @@ -1403,6 +1407,8 @@ static const struct v4l2_subdev_pad_ops adv7511_pad_o= ps =3D { .enum_mbus_code =3D adv7511_enum_mbus_code, .get_fmt =3D adv7511_get_fmt, .set_fmt =3D adv7511_set_fmt, + .s_dv_timings =3D adv7511_s_dv_timings, + .g_dv_timings =3D adv7511_g_dv_timings, .enum_dv_timings =3D adv7511_enum_dv_timings, .dv_timings_cap =3D adv7511_dv_timings_cap, }; --=20 2.44.0.478.gd926399ef9-goog From nobody Sun Feb 8 06:04:22 2026 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90C5E16F0F3 for ; Fri, 5 Apr 2024 14:15:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326511; cv=none; b=mcueNhlZeKmZ75cCo5KbHmV2MEjHMZ8adrzipPp0k4VmGAIHZnNfjEg9mYVqcsJOrwTfx/OcZMvbJQFTveG3VorUZ7iL6DswXEreGuelGeUZONB5iKYosQuypq3FEyR1ZzgXbCI5nVfwSTcHi3NyZwyCA+lXVAIuuu6576hojdg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326511; c=relaxed/simple; bh=idYrd+JwFJEmpLa5TUjmluycyXqG6/ydzEQ0w5bLKts=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Y8U0S/xlrZ84zLVDP54AnmGwCJPl42h1dZfJObW1RpzZ0NCxpqCZ4WSkl9AMfRMwTOAY2RXQwSbiJyKP4hOY0VbkFCwilwgVeYqe2a7AwHsc56vP/9UbHBfJE/lAvjytV0eMvMTlSHH3DMQTsIputcwGMK9tq2bdGwIuTnP+Ub4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=EiBJ9d/x; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="EiBJ9d/x" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dcc05887ee9so3254110276.1 for ; Fri, 05 Apr 2024 07:15:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712326508; x=1712931308; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=JdSgusrl9te1mUbflA4RpHsrzTFXpOMOzAPL8Ip4ilw=; b=EiBJ9d/x/t09F9LMVgs6z4RGVViUk67UgdWAXJe+kD3UBIIgdX5etzfNa8AHsB8CFH 0TzCq9rk8L5pJkaW9x4lUNDpVfmW8v3jKjuEcJ8M5HOXArjP1KqxssqzVWzF/Zfakj1a 6YGNZgC5B6X1IdH5gn3Xk1YH3ai5NM2/BHKU5boNvx2eBZ0rsOkGcmGdwD71kq44g3XL PrCTexR4gVIVt/Lnwe4hgsM3fh+9J8QFdyUeuesGzGFEDteEUL3R3aZXktjiXojLXD30 lHc+QgQZtCRaGb0kqE/+Ff1ZPBjtfBRnIgDUDByYBWIeG1V5LSUM9ubdCjooYRJbDfmp MbIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712326508; x=1712931308; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=JdSgusrl9te1mUbflA4RpHsrzTFXpOMOzAPL8Ip4ilw=; b=j61ZBIAgnAoYE1YbJ364oHnGfJIUPNsik8b/kLrfz7bHe+eJy2R15+BVlPz5H+NNiC o1vfTo8Z3OTOcY+ckE4EFv66tMydYvI0NDMvFe6qZ7izK3ab2m63lS1kBER/wtwSvk3q z7I7eOs9nCNw/GPPam8GE5Z/MIB5W/nlS86JTvJhSAI2iNC6W7m1N4kt39HIANUy02TA bpvmv61slCx12ub/cGgiT38qhPJD226KF8D5CBQNFAHRs4HjGeTEnE4Cggu0n6xZfzCT Q3zs+plZoSzEpDvxE2gXHkwXRkoAHR7BwKI7ZHRl7uuRvmedcdotqPkFOVy5wPzNG649 cBRw== X-Forwarded-Encrypted: i=1; AJvYcCVssnxm+Gr99fW5OMxzceKCzqYIOBBGZms9wSxmunRYTlJWW9SnVMTMf4i7FLwG1f1npDHoTQRYU+8Id6VgoUbZwgNLntDRIkYxCPRu X-Gm-Message-State: AOJu0Yzin5gueyCQ5eCh0BEr4V1vgyUEsgVmaZVrq4LsA6F12PSt2U4m BIOWND9361qGmohlwpdQNRJ6Inu+9ato2RMdI7yJNP32yjXk2LXM5GCbofSEpnEnOFF5f5yqnqO c6S3sAa58NA== X-Google-Smtp-Source: AGHT+IEaUHqRZ1t/645SPuoM0Mq1wtBDlBAVyUzDU3uFVn4lz8fochNj8syLSt9Fpo1fHuDprzN3KNVBj/p5rA== X-Received: from szatan.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:2d83]) (user=panikiel job=sendgmr) by 2002:a05:6902:100a:b0:dc6:c94e:fb85 with SMTP id w10-20020a056902100a00b00dc6c94efb85mr71969ybt.2.1712326508757; Fri, 05 Apr 2024 07:15:08 -0700 (PDT) Date: Fri, 5 Apr 2024 14:13:59 +0000 In-Reply-To: <20240405141411.1807189-1-panikiel@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240405141411.1807189-1-panikiel@google.com> X-Mailer: git-send-email 2.44.0.478.gd926399ef9-goog Message-ID: <20240405141411.1807189-5-panikiel@google.com> Subject: [PATCH 04/16] media: i2c: adv7604: Switch dv timing callbacks to pad ops From: "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" To: kieran.bingham@ideasonboard.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, tharvey@gateworks.com, niklas.soderlund@ragnatech.se, prabhakar.csengg@gmail.com, charles-antoine.couret@nexvision.fr, thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com, luca.ceresoli@bootlin.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chromeos-krk-upstreaming@google.com, "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Change all (s|g|query)_dv_timings subdev callbacks to include a pad argument. Signed-off-by: Pawe=C5=82 Anikiel --- drivers/media/i2c/adv7604.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c index 319db3e847c4..404ccc9b42f0 100644 --- a/drivers/media/i2c/adv7604.c +++ b/drivers/media/i2c/adv7604.c @@ -1557,7 +1557,7 @@ static unsigned int adv76xx_read_hdmi_pixelclock(stru= ct v4l2_subdev *sd) return freq; } =20 -static int adv76xx_query_dv_timings(struct v4l2_subdev *sd, +static int adv76xx_query_dv_timings(struct v4l2_subdev *sd, unsigned int p= ad, struct v4l2_dv_timings *timings) { struct adv76xx_state *state =3D to_state(sd); @@ -1687,7 +1687,7 @@ static int adv76xx_query_dv_timings(struct v4l2_subde= v *sd, return 0; } =20 -static int adv76xx_s_dv_timings(struct v4l2_subdev *sd, +static int adv76xx_s_dv_timings(struct v4l2_subdev *sd, unsigned int pad, struct v4l2_dv_timings *timings) { struct adv76xx_state *state =3D to_state(sd); @@ -1730,7 +1730,7 @@ static int adv76xx_s_dv_timings(struct v4l2_subdev *s= d, return 0; } =20 -static int adv76xx_g_dv_timings(struct v4l2_subdev *sd, +static int adv76xx_g_dv_timings(struct v4l2_subdev *sd, unsigned int pad, struct v4l2_dv_timings *timings) { struct adv76xx_state *state =3D to_state(sd); @@ -2607,7 +2607,7 @@ static int adv76xx_log_status(struct v4l2_subdev *sd) stdi.lcf, stdi.bl, stdi.lcvs, stdi.interlaced ? "interlaced" : "progressive", stdi.hs_pol, stdi.vs_pol); - if (adv76xx_query_dv_timings(sd, &timings)) + if (adv76xx_query_dv_timings(sd, 0, &timings)) v4l2_info(sd, "No video detected\n"); else v4l2_print_dv_timings(sd->name, "Detected format: ", @@ -2726,9 +2726,6 @@ static const struct v4l2_subdev_core_ops adv76xx_core= _ops =3D { static const struct v4l2_subdev_video_ops adv76xx_video_ops =3D { .s_routing =3D adv76xx_s_routing, .g_input_status =3D adv76xx_g_input_status, - .s_dv_timings =3D adv76xx_s_dv_timings, - .g_dv_timings =3D adv76xx_g_dv_timings, - .query_dv_timings =3D adv76xx_query_dv_timings, }; =20 static const struct v4l2_subdev_pad_ops adv76xx_pad_ops =3D { @@ -2738,6 +2735,9 @@ static const struct v4l2_subdev_pad_ops adv76xx_pad_o= ps =3D { .set_fmt =3D adv76xx_set_format, .get_edid =3D adv76xx_get_edid, .set_edid =3D adv76xx_set_edid, + .s_dv_timings =3D adv76xx_s_dv_timings, + .g_dv_timings =3D adv76xx_g_dv_timings, + .query_dv_timings =3D adv76xx_query_dv_timings, .dv_timings_cap =3D adv76xx_dv_timings_cap, .enum_dv_timings =3D adv76xx_enum_dv_timings, }; --=20 2.44.0.478.gd926399ef9-goog From nobody Sun Feb 8 06:04:22 2026 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7967E16F290 for ; Fri, 5 Apr 2024 14:15:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326514; cv=none; b=hwJLuUVcvzGg8gsSyPwQlJGecM5kBOnkW74bwl/tJKJtW2L9Z3eid1TWluhsMVCz7mLeUkEYsfLfdzrPhihIHPxs3aff8OMbpP9/J8eSGLvGxqG5xgBUXJ/qNu3/vP/aJ5A8vvgzHqhcRCgUqrXQrEiDJEHVsjLQDqwpD/Dc5tg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326514; c=relaxed/simple; bh=8aQ18Uj04YT2A+P3Oh2IhoxHUDUc0ZferNgCl6q/rqY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ecbc7V3u1JxFAGxL36PbIS16XjjZEOpMwmSH/OMTt18Gj6CEVaMofRvTZhP1A1/2CouOySMXDbpHXbqxM5L1oPy6EJ6QI9Foz9u5lqUIztvBL0yPEP6JZ8ZtOmJMLyaLESH5FYkM5BknNYj0ygs89pHkKUxwwY1b5E0VRw0btLc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ajyTNn22; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ajyTNn22" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-4155db7b58cso11187675e9.1 for ; Fri, 05 Apr 2024 07:15:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712326511; x=1712931311; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=My1wqn+atygHUN+jmKPzc06Fma5b+VEUv6s9yO8/Vks=; b=ajyTNn22yOMMVgwV2TyOxLo8XPjO/AleimyLqn3iEdvfaTrxp0IyjoFvhRbsmb7/Nq suiKWC4KGMWKgo+xmYdEol4ylR9gHLsYFATSbL8pIOgj3yh9KD3LNpEM33p6n8aDRQsA JpORTSKPYPySYOOTHcf0BsMWC6S/RUhQtgpCWVXGeegd7YWIG/WAZCoHrxx1gYEli50l GUFTsbssCb9Ef08p8BrdTlB6sI+ljnFgzTVIHDLGzPPLJDISeEkk2mjt4lhi/a0YtfPg a5FXNsEj5OpTVtVoUXm1IvU1J+QJ4t4pBjylUOJdO6+iKfv68rOCMbZSOV3BG/37S/YS NUZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712326511; x=1712931311; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=My1wqn+atygHUN+jmKPzc06Fma5b+VEUv6s9yO8/Vks=; b=D+cib0Yc/+5rT7Se2U5BT4jz1deXRaWm/boMT6M4vwR94g13wv33Mh6dYIHclt4CXk 36SsbbW11AsMuJnTqKHY+HB0Wo4XfN5xgJeTDMHg9hbdMuqBhkprq2XW7Lk9zDGExaUa MwqJS++o5EyqYJi5BBWsKG/gGfvgBJZNlIs1SlP29COGLSnB5gxjEC2WJv344xwR7MqC rNMAIGDx9qXGGgWWHS9/2UfAmDwyFJhCsccE/SVinAYKu8NR7Oi1tPuMYBtNNrkUu232 nH3FR/ZK3vTrwEqwoYinoJN4x8iCOeaHLT9HM/jyhSnALhYTB7mP9hKl2kf9v0X0TaeZ 69xg== X-Forwarded-Encrypted: i=1; AJvYcCVqkuKWoTjk1/Liik31IKX1PK/IHbkY/PC5BUi9mrTdlE94GtKqNsEnHrSFoOyjpbM6QSyeh3FLQ1PtwXtDwSAwTaxESNbTlQMg0jUB X-Gm-Message-State: AOJu0YwsCgilv7Gm99ZT2z7LtAuaOjIyhe7JyuC8dQxruvsK85AeXzjo XXs8NRPFTBGHYBqYnX3jh9JCDFkwnVcAGuOqQ/KBHBd+gCwoycRi5WswPJk3dBhGk4NS2LHfVc+ 78dWwMKjz7Q== X-Google-Smtp-Source: AGHT+IEdrMjCWzhSnkncvw6N1O1UZ1VCF1PMUEfzJPCR3jpkvdvdrcU6A9BajfE3olsmjFosqv9KN+QUA9LFZA== X-Received: from szatan.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:2d83]) (user=panikiel job=sendgmr) by 2002:a5d:5a98:0:b0:343:2ec2:e4e8 with SMTP id bp24-20020a5d5a98000000b003432ec2e4e8mr4389wrb.3.1712326511044; Fri, 05 Apr 2024 07:15:11 -0700 (PDT) Date: Fri, 5 Apr 2024 14:14:00 +0000 In-Reply-To: <20240405141411.1807189-1-panikiel@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240405141411.1807189-1-panikiel@google.com> X-Mailer: git-send-email 2.44.0.478.gd926399ef9-goog Message-ID: <20240405141411.1807189-6-panikiel@google.com> Subject: [PATCH 05/16] media: i2c: adv7842: Switch dv timing callbacks to pad ops From: "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" To: kieran.bingham@ideasonboard.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, tharvey@gateworks.com, niklas.soderlund@ragnatech.se, prabhakar.csengg@gmail.com, charles-antoine.couret@nexvision.fr, thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com, luca.ceresoli@bootlin.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chromeos-krk-upstreaming@google.com, "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Change all (s|g|query)_dv_timings subdev callbacks to include a pad argument. Signed-off-by: Pawe=C5=82 Anikiel --- drivers/media/i2c/adv7842.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/media/i2c/adv7842.c b/drivers/media/i2c/adv7842.c index 2ad0f9f5503d..f2d4217310e7 100644 --- a/drivers/media/i2c/adv7842.c +++ b/drivers/media/i2c/adv7842.c @@ -1518,7 +1518,7 @@ static void adv7842_fill_optional_dv_timings_fields(s= truct v4l2_subdev *sd, timings->bt.flags |=3D V4L2_DV_FL_CAN_DETECT_REDUCED_FPS; } =20 -static int adv7842_query_dv_timings(struct v4l2_subdev *sd, +static int adv7842_query_dv_timings(struct v4l2_subdev *sd, unsigned int p= ad, struct v4l2_dv_timings *timings) { struct adv7842_state *state =3D to_state(sd); @@ -1527,6 +1527,9 @@ static int adv7842_query_dv_timings(struct v4l2_subde= v *sd, =20 v4l2_dbg(1, debug, sd, "%s:\n", __func__); =20 + if (pad !=3D 0) + return -EINVAL; + memset(timings, 0, sizeof(struct v4l2_dv_timings)); =20 /* SDP block */ @@ -1643,7 +1646,7 @@ static int adv7842_query_dv_timings(struct v4l2_subde= v *sd, return 0; } =20 -static int adv7842_s_dv_timings(struct v4l2_subdev *sd, +static int adv7842_s_dv_timings(struct v4l2_subdev *sd, unsigned int pad, struct v4l2_dv_timings *timings) { struct adv7842_state *state =3D to_state(sd); @@ -1652,6 +1655,9 @@ static int adv7842_s_dv_timings(struct v4l2_subdev *s= d, =20 v4l2_dbg(1, debug, sd, "%s:\n", __func__); =20 + if (pad !=3D 0) + return -EINVAL; + if (state->mode =3D=3D ADV7842_MODE_SDP) return -ENODATA; =20 @@ -1689,11 +1695,14 @@ static int adv7842_s_dv_timings(struct v4l2_subdev = *sd, return 0; } =20 -static int adv7842_g_dv_timings(struct v4l2_subdev *sd, +static int adv7842_g_dv_timings(struct v4l2_subdev *sd, unsigned int pad, struct v4l2_dv_timings *timings) { struct adv7842_state *state =3D to_state(sd); =20 + if (pad !=3D 0) + return -EINVAL; + if (state->mode =3D=3D ADV7842_MODE_SDP) return -ENODATA; *timings =3D state->timings; @@ -2780,7 +2789,7 @@ static int adv7842_cp_log_status(struct v4l2_subdev *= sd) "interlaced" : "progressive", hs_pol, vs_pol); } - if (adv7842_query_dv_timings(sd, &timings)) + if (adv7842_query_dv_timings(sd, 0, &timings)) v4l2_info(sd, "No video detected\n"); else v4l2_print_dv_timings(sd->name, "Detected format: ", @@ -3226,7 +3235,7 @@ static int adv7842_command_ram_test(struct v4l2_subde= v *sd) =20 memset(&state->timings, 0, sizeof(struct v4l2_dv_timings)); =20 - adv7842_s_dv_timings(sd, &timings); + adv7842_s_dv_timings(sd, 0, &timings); =20 return ret; } @@ -3298,9 +3307,6 @@ static const struct v4l2_subdev_video_ops adv7842_vid= eo_ops =3D { .s_routing =3D adv7842_s_routing, .querystd =3D adv7842_querystd, .g_input_status =3D adv7842_g_input_status, - .s_dv_timings =3D adv7842_s_dv_timings, - .g_dv_timings =3D adv7842_g_dv_timings, - .query_dv_timings =3D adv7842_query_dv_timings, }; =20 static const struct v4l2_subdev_pad_ops adv7842_pad_ops =3D { @@ -3309,6 +3315,9 @@ static const struct v4l2_subdev_pad_ops adv7842_pad_o= ps =3D { .set_fmt =3D adv7842_set_format, .get_edid =3D adv7842_get_edid, .set_edid =3D adv7842_set_edid, + .s_dv_timings =3D adv7842_s_dv_timings, + .g_dv_timings =3D adv7842_g_dv_timings, + .query_dv_timings =3D adv7842_query_dv_timings, .enum_dv_timings =3D adv7842_enum_dv_timings, .dv_timings_cap =3D adv7842_dv_timings_cap, }; --=20 2.44.0.478.gd926399ef9-goog From nobody Sun Feb 8 06:04:22 2026 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33CD516F822 for ; Fri, 5 Apr 2024 14:15:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326516; cv=none; b=TrIjaP7a48STCOBf93ScmkTozRAd9bK6zkT7TtXpEzSidp2eo5fc8qUbIGoX0y70MmgefZ7kFnIJAvT0eW9ojsPsXQAS3plu1VpPIdxiaDeHAHUCKTJLDoa2WIZbIGhu7EaB0iq/RtGV1Scs032+j8XEE/f7skgh8c1Wn12dLJM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326516; c=relaxed/simple; bh=4wtNik17CJrGwo09hGU5FCupPfVKAQ7aXZ/lboHZCY8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=eMvS8ie0Ctif6DycKvkF+RO6EF1sCsiT+RUAcvHDEiRb5UZVfLsGr6sUjWvLEi4U/h9yfYh4kMR0FZYCpqrNBmC3BPlvPCuM3SPZ+uII536sHLzCEPt2H06/yvWsZd/Pi9+GyxP49rPPHo6ElMGN6vSzr6MjvwOesvRw/G19F+0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=IIPYXxXj; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="IIPYXxXj" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-60cbba6f571so35724887b3.1 for ; Fri, 05 Apr 2024 07:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712326513; x=1712931313; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=Elc5l/UMF2FSTb8MiWLeLSVgKSF7YacOuvj79p+V2jg=; b=IIPYXxXjaykjQPMrEzLPVJmy22WhyOCQUXPZunT/nLENBxuS5nqVuKtMmtqaYtgH/p kYQex1NfKKuJaw5tR8WGbOdKsMWCtX/HY8R8GTaL7AGjuZyVsgVf6UaXzdOm8KrXf7ux RRJOdJ8V0N7CBAXc8rn9WVt9Pllu9Cch2HjVra8aLvu2eCph4gXjwac/NQ9uhwlXhr8X POrnxTbtIhZCPm9pmFoQlTS6Wf4n+7Pe9knhhftfSM8fLFPjj8rkuMJ2maFS/Zt7qcDq 1AzHpsKxEBEncvyoLl78wqCaDzKz9UdPoOBXY2Fkbd9644jSh5CYh0MoPCPNP676zRLE afFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712326513; x=1712931313; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Elc5l/UMF2FSTb8MiWLeLSVgKSF7YacOuvj79p+V2jg=; b=GEnot01V9PP8jhVS3cm3j2mBQZ+4tY8jwZ0D0QD0/kwZVWb7HstQjqqu68o3dcK8+f vIl3ziDOZFysElAfrNdDT/lgXbTCga9gZnyn+ogQnNcH2CdmTI3xG6zqT2OBxFeTrOIm 6YId87DDAV81qiI+qZZrxrA8df3YBXnhBcOIfczmnR5eT1yYM2+5NYpn8gquBFkgcGSl IqWlMsZhsHWnLSMTSgXI3rz7MDgPRSU+dlC+IvoKCoEjDmkwduYy+ghv2A1x0Fa51k52 nwyhZhgFfX8lCAmGxDZ2iSAWGmPb1gdpaNkeGWMSIeuDk9x18aKHGV4sT8lBYAZbzCU1 oPQA== X-Forwarded-Encrypted: i=1; AJvYcCW1NzSkv6tt/zoNUQ6YMDsnmVmOpx0xrEz4Roc30JA0K+299e02Xed0a0iwy9RcHaaNABWUR8ZX83bs31ZnECc/P5fJ01fmYPDwTvCC X-Gm-Message-State: AOJu0Yx0AxFtEX6DYUQ3LHndTTNOpsGQpC8NRizLpTnT52f3XJQMPq/H 1OGAa2XLbzu5ZCYvs1hzcbNhk3uCDU1mUWNeUWoy2Kk44ISGXzslt8QcOTvUs6ijh6FbqLq/5ec v8ax1E3DnYA== X-Google-Smtp-Source: AGHT+IHNeI5HSh0A3wDhTGZD/QoxygxfQJND3EBhOMUo7WjeYvOYmOryZPypoQlS0NMtGL+mlRC1y7EXBD6Fnw== X-Received: from szatan.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:2d83]) (user=panikiel job=sendgmr) by 2002:a05:6902:1108:b0:dc7:68b5:4f21 with SMTP id o8-20020a056902110800b00dc768b54f21mr374791ybu.9.1712326513206; Fri, 05 Apr 2024 07:15:13 -0700 (PDT) Date: Fri, 5 Apr 2024 14:14:01 +0000 In-Reply-To: <20240405141411.1807189-1-panikiel@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240405141411.1807189-1-panikiel@google.com> X-Mailer: git-send-email 2.44.0.478.gd926399ef9-goog Message-ID: <20240405141411.1807189-7-panikiel@google.com> Subject: [PATCH 06/16] media: i2c: tc358743: Switch dv timing callbacks to pad ops From: "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" To: kieran.bingham@ideasonboard.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, tharvey@gateworks.com, niklas.soderlund@ragnatech.se, prabhakar.csengg@gmail.com, charles-antoine.couret@nexvision.fr, thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com, luca.ceresoli@bootlin.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chromeos-krk-upstreaming@google.com, "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Change all (s|g|query)_dv_timings subdev callbacks to include a pad argument. Signed-off-by: Pawe=C5=82 Anikiel --- drivers/media/i2c/tc358743.c | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index 3192a334aaab..303c1d06c8b5 100644 --- a/drivers/media/i2c/tc358743.c +++ b/drivers/media/i2c/tc358743.c @@ -1521,11 +1521,14 @@ static int tc358743_g_input_status(struct v4l2_subd= ev *sd, u32 *status) return 0; } =20 -static int tc358743_s_dv_timings(struct v4l2_subdev *sd, +static int tc358743_s_dv_timings(struct v4l2_subdev *sd, unsigned int pad, struct v4l2_dv_timings *timings) { struct tc358743_state *state =3D to_state(sd); =20 + if (pad !=3D 0) + return -EINVAL; + if (!timings) return -EINVAL; =20 @@ -1553,11 +1556,14 @@ static int tc358743_s_dv_timings(struct v4l2_subdev= *sd, return 0; } =20 -static int tc358743_g_dv_timings(struct v4l2_subdev *sd, +static int tc358743_g_dv_timings(struct v4l2_subdev *sd, unsigned int pad, struct v4l2_dv_timings *timings) { struct tc358743_state *state =3D to_state(sd); =20 + if (pad !=3D 0) + return -EINVAL; + *timings =3D state->timings; =20 return 0; @@ -1573,11 +1579,14 @@ static int tc358743_enum_dv_timings(struct v4l2_sub= dev *sd, &tc358743_timings_cap, NULL, NULL); } =20 -static int tc358743_query_dv_timings(struct v4l2_subdev *sd, +static int tc358743_query_dv_timings(struct v4l2_subdev *sd, unsigned int = pad, struct v4l2_dv_timings *timings) { int ret; =20 + if (pad !=3D 0) + return -EINVAL; + ret =3D tc358743_get_detected_timings(sd, timings); if (ret) return ret; @@ -1822,9 +1831,6 @@ static const struct v4l2_subdev_core_ops tc358743_cor= e_ops =3D { =20 static const struct v4l2_subdev_video_ops tc358743_video_ops =3D { .g_input_status =3D tc358743_g_input_status, - .s_dv_timings =3D tc358743_s_dv_timings, - .g_dv_timings =3D tc358743_g_dv_timings, - .query_dv_timings =3D tc358743_query_dv_timings, .s_stream =3D tc358743_s_stream, }; =20 @@ -1834,6 +1840,9 @@ static const struct v4l2_subdev_pad_ops tc358743_pad_= ops =3D { .get_fmt =3D tc358743_get_fmt, .get_edid =3D tc358743_g_edid, .set_edid =3D tc358743_s_edid, + .s_dv_timings =3D tc358743_s_dv_timings, + .g_dv_timings =3D tc358743_g_dv_timings, + .query_dv_timings =3D tc358743_query_dv_timings, .enum_dv_timings =3D tc358743_enum_dv_timings, .dv_timings_cap =3D tc358743_dv_timings_cap, .get_mbus_config =3D tc358743_get_mbus_config, @@ -2110,7 +2119,7 @@ static int tc358743_probe(struct i2c_client *client) =20 tc358743_initial_setup(sd); =20 - tc358743_s_dv_timings(sd, &default_timing); + tc358743_s_dv_timings(sd, 0, &default_timing); =20 tc358743_set_csi_color_space(sd); =20 --=20 2.44.0.478.gd926399ef9-goog From nobody Sun Feb 8 06:04:22 2026 Received: from mail-wr1-f74.google.com (mail-wr1-f74.google.com [209.85.221.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A657F16F29A for ; Fri, 5 Apr 2024 14:15:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326518; cv=none; b=qOE2mbx6+sN0dNj7FxlaCcAddgOroE2HxppVgOKlW30RgDGN2AlgdYw8KH9a9vra9tzogTEy1E8zhri1qZq35RGk9sN+ufwu11kKT1INbSjXHn2va1fmUGqTC/0wKHPd4wFB7X6m6te0KMg+xf9YqvOBpeoVuTFcq0oXf9ATeYc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326518; c=relaxed/simple; bh=ntS1pULOfao09pkQklGZunQlgY3iQS75f26X4n18NUw=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=n2UVeSOpsX5Z3XbOhYhEBoc0Yrs2YMZSABIjyY2SsiawtHL9hXezWF/w0bs5N1BT0d3kKgvk98W6NH5LeLPcUJJlz9lUtDuBs7g0nRHJ9/T1SxlIcJyfItNq/0s0r8obiWqYxaGzt1PGLNhFgY7TFjfnUlDqfXaczxagrZfxJaQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=qRkHnNXK; arc=none smtp.client-ip=209.85.221.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="qRkHnNXK" Received: by mail-wr1-f74.google.com with SMTP id ffacd0b85a97d-343f1064acaso237737f8f.3 for ; Fri, 05 Apr 2024 07:15:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712326515; x=1712931315; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=u/DYRsGuD2azP54ih0vSn8RrFIexS1cmRe6nsqzzojM=; b=qRkHnNXKIYbHHthPbRLJGyG/3qm8nlmuS6LXEYAPcqVgEwOXjgySjvseR1NnGuzy26 UtWq1BzLHoPhH3ONLPZBlV5hZMnErzPukIJ2N+Xm6jIBCG4vOb2TxBXjwh+n0t1FKOq+ +KyVSILdrrLX+r7UyD9pckK0qoqQC9HRg2YAbbQ+QwrsTSJG3Z60J3+RLt81vubRXGEa A479idsPVc7bVzK42jZrCXL94/daRzg7CjzVdswwzkL94SBZol00xDKhlV0otUU2BiMg xAZ/6OCTXZBSpOKT72D8BTL8KHVahqti9eWVLYzomYEf9iEsx5rguOba/Yd0ErYlCFhv 4vIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712326515; x=1712931315; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=u/DYRsGuD2azP54ih0vSn8RrFIexS1cmRe6nsqzzojM=; b=W+emvzHwGNoNXtl62bve5Tq4RGr/wKa6/garlksEdhZwKA04G2xKMWJ4a14cc3NHRW F6Z2Nd8mSAWbrhuRsbZDy4bsaJQKbS4mdcRCaWaeYq0p3fOLwsXhFNnYODuW3Lj9uIgr RXFkiQAlGRh8AL3vARGIxVcXpoQEwQoKKju6mVzIkVpOrqDraNe2FAJVrycB396j7XTh u8kjD+4RF9b4SK9zZS0IplqtRtCdpOX5LmuOxk2zIovzOGsDnipoeNi4QZHK/aT30p29 a44kCijF49ISCX9hLx0tLwt8YCZiy3guVyX5Sl4wKOCmXR620kQfCqkiGFRLDPJ6K4Vm ptMw== X-Forwarded-Encrypted: i=1; AJvYcCVWrcniHQzGnfGzNvLq1ffeDmCjKymnAgqRUTcmzdRUjcdmjbHFES4T3wDWjXsxiqq8MlAhRS6s2lBO95sW7/uZGJ52Bx/thxS9ZVGo X-Gm-Message-State: AOJu0YxO/buDEzwYbxh+/aQYrQ9sxvSLoys5MZwhQzfYSePHpNE7l9bk EsIlah9sKdpdXDNP5EbboPGP8lGOXDQRxBniBXR6SmGPRQX0sln3ywqG/kvs0Q5wgcavj1nSyo+ 2jc/CXK/m3w== X-Google-Smtp-Source: AGHT+IGVcif+Faaig453j1h+31TrZh3tBMb+AFeW0Uj0gxfTGG7Ih3adQK1q6wGfDlzXEzt+uvm5oUV+rRa+3A== X-Received: from szatan.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:2d83]) (user=panikiel job=sendgmr) by 2002:adf:9d91:0:b0:343:8420:4d1c with SMTP id p17-20020adf9d91000000b0034384204d1cmr3903wre.3.1712326515313; Fri, 05 Apr 2024 07:15:15 -0700 (PDT) Date: Fri, 5 Apr 2024 14:14:02 +0000 In-Reply-To: <20240405141411.1807189-1-panikiel@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240405141411.1807189-1-panikiel@google.com> X-Mailer: git-send-email 2.44.0.478.gd926399ef9-goog Message-ID: <20240405141411.1807189-8-panikiel@google.com> Subject: [PATCH 07/16] media: i2c: tda1997x: Switch dv timing callbacks to pad ops From: "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" To: kieran.bingham@ideasonboard.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, tharvey@gateworks.com, niklas.soderlund@ragnatech.se, prabhakar.csengg@gmail.com, charles-antoine.couret@nexvision.fr, thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com, luca.ceresoli@bootlin.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chromeos-krk-upstreaming@google.com, "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Change all (s|g|query)_dv_timings subdev callbacks to include a pad argument. Signed-off-by: Pawe=C5=82 Anikiel --- drivers/media/i2c/tda1997x.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/media/i2c/tda1997x.c b/drivers/media/i2c/tda1997x.c index 8e4a0718c4b6..55a0b5d39893 100644 --- a/drivers/media/i2c/tda1997x.c +++ b/drivers/media/i2c/tda1997x.c @@ -1669,7 +1669,7 @@ tda1997x_g_input_status(struct v4l2_subdev *sd, u32 *= status) return 0; }; =20 -static int tda1997x_s_dv_timings(struct v4l2_subdev *sd, +static int tda1997x_s_dv_timings(struct v4l2_subdev *sd, unsigned int pad, struct v4l2_dv_timings *timings) { struct tda1997x_state *state =3D to_state(sd); @@ -1694,7 +1694,7 @@ static int tda1997x_s_dv_timings(struct v4l2_subdev *= sd, return 0; } =20 -static int tda1997x_g_dv_timings(struct v4l2_subdev *sd, +static int tda1997x_g_dv_timings(struct v4l2_subdev *sd, unsigned int pad, struct v4l2_dv_timings *timings) { struct tda1997x_state *state =3D to_state(sd); @@ -1707,7 +1707,7 @@ static int tda1997x_g_dv_timings(struct v4l2_subdev *= sd, return 0; } =20 -static int tda1997x_query_dv_timings(struct v4l2_subdev *sd, +static int tda1997x_query_dv_timings(struct v4l2_subdev *sd, unsigned int = pad, struct v4l2_dv_timings *timings) { struct tda1997x_state *state =3D to_state(sd); @@ -1724,9 +1724,6 @@ static int tda1997x_query_dv_timings(struct v4l2_subd= ev *sd, =20 static const struct v4l2_subdev_video_ops tda1997x_video_ops =3D { .g_input_status =3D tda1997x_g_input_status, - .s_dv_timings =3D tda1997x_s_dv_timings, - .g_dv_timings =3D tda1997x_g_dv_timings, - .query_dv_timings =3D tda1997x_query_dv_timings, }; =20 =20 @@ -1930,6 +1927,9 @@ static const struct v4l2_subdev_pad_ops tda1997x_pad_= ops =3D { .set_fmt =3D tda1997x_set_format, .get_edid =3D tda1997x_get_edid, .set_edid =3D tda1997x_set_edid, + .s_dv_timings =3D tda1997x_s_dv_timings, + .g_dv_timings =3D tda1997x_g_dv_timings, + .query_dv_timings =3D tda1997x_query_dv_timings, .dv_timings_cap =3D tda1997x_get_dv_timings_cap, .enum_dv_timings =3D tda1997x_enum_dv_timings, }; --=20 2.44.0.478.gd926399ef9-goog From nobody Sun Feb 8 06:04:22 2026 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A38E816F853 for ; Fri, 5 Apr 2024 14:15:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326520; cv=none; b=tpvPQO7ODpwHOO38rxkv+MGAGn970zO+mE+WVRm7bRzWyK7QoeC+34/HWrTE6HkyrrG26qt5V5U7m7CCeDeGJBeHhhEnTJBZuUixJRixwM8uij/r8WwmsOk1ds6OYfyQJ0g78TPqmPY7hWmogQ6/J4EBCOfGFZTjG2eZOee8kWM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326520; c=relaxed/simple; bh=ZMS7hM6KW9z07sWnfqtb0vfUnCFSGDurCvDVGwpKtH4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=lUcmF/Vrg0ISMr8qRgDN3SIHv9HBPA7PuvwNoTKFWa0lKqElK1aDPJuuHfOwsd23OpRGchqVBn0Pm6YTY44Wzrxw/CAdRUmwGopFdbR0URMXYoh8dmIU1EqqsmMgQglWfReNBuBED3QF/Izie01y0gB1QagHnJVMjbWPcMBWNxc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=koNcX9m1; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="koNcX9m1" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-61504a34400so35540817b3.0 for ; Fri, 05 Apr 2024 07:15:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712326517; x=1712931317; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=94YlLU32Aw+sMxB+PMoafcDiaHrqtTcDMU3Gx4Hxs1I=; b=koNcX9m1Ps2wwp0tQBqFmNo8qemsmuR+pkJ6lBfjalreLVYj/Zg9JtbXfU70owHpWh gPAqGJDJIhZIIxEwuucfEyiAylMu1JOTyWOleu7XpgjxDxixOvtMxq1/PVfx2//nLIEe w1eGhREbvLdrl6mgqJ0RWWrXZMzpYvQft2Znd3xun1qiWyJ6ZaHp61+1Y4BKDlfertnY 0Vyc7SYwtitDBZ7TZLZ7iJIfTjJaoBFdEdSKJ/aEzElPRkcVOVJ/gVkXO4M+bbkDXGDl E3EjnCEcd7+9m1VEHmauaMeYN6EuJ20XJWndN9QzTn9M/x12GlY/BhXURA1Hl9CMWvbF WO1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712326517; x=1712931317; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=94YlLU32Aw+sMxB+PMoafcDiaHrqtTcDMU3Gx4Hxs1I=; b=f/uCg6IfCB4uUKtTDbajgiXk0aavU88/T/Pl1SXpadd7VigD6MEyrJ/JSTW3eXMd9G XMEEOia4zDIxDQyOJtPmChGSEJe2BDJBrzqMpLZ4tJHSQqe9Wk9RyfyaNEj0zho7TKfo eL+IfX0FmMzNqjkgBTQ2i6C9BwFkmqJmkFQTla+ia6JiXKQ5eUFYKTFyUI2zSApbnGSu 2A+R0m+ON6GUaA7T5ifoq+cFOf8nOSyPEXyNYz1EYIbzBxu/nR+gOpAtEdFDydzA0FQk 8uigN6Ix/WasgqEX7Klhd3wvICG9JbqAc0gO0kBxYcR4MQKyKaMj2wl/KP5N6kPSID9y FF0A== X-Forwarded-Encrypted: i=1; AJvYcCX4W4xGuWdvwBs4bdEUkngyD+egQ/YP7yp9cVDbKFFHFr+lWun3LvXALvQHgnv+7WrHLFhSKk65X/CfROBp5BNjcu6xz3C7+wZfLeFw X-Gm-Message-State: AOJu0YycLB66e4ep86CAp7o/msHDxgZpTv5omwW4VVyGJFLhzoH5m3bJ iPr0jCVrjV3YkYbHVb9fP7Zv2GjFZNlb+nKsQdip/aXnTeblQSWEMeKboq59GrTNudaWifOWgNd Py3lKl18T8A== X-Google-Smtp-Source: AGHT+IGrK5D+Al9x3FTMCHj14GU/jIUebXWjMWxE2WeT0/GABiLAK8y3wTuNfqwVvbVtebybpNUuNDmYAKkDAA== X-Received: from szatan.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:2d83]) (user=panikiel job=sendgmr) by 2002:a05:6902:1502:b0:dd9:1b94:edb5 with SMTP id q2-20020a056902150200b00dd91b94edb5mr78790ybu.10.1712326517609; Fri, 05 Apr 2024 07:15:17 -0700 (PDT) Date: Fri, 5 Apr 2024 14:14:03 +0000 In-Reply-To: <20240405141411.1807189-1-panikiel@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240405141411.1807189-1-panikiel@google.com> X-Mailer: git-send-email 2.44.0.478.gd926399ef9-goog Message-ID: <20240405141411.1807189-9-panikiel@google.com> Subject: [PATCH 08/16] media: i2c: ths7303: Switch dv timing callbacks to pad ops From: "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" To: kieran.bingham@ideasonboard.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, tharvey@gateworks.com, niklas.soderlund@ragnatech.se, prabhakar.csengg@gmail.com, charles-antoine.couret@nexvision.fr, thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com, luca.ceresoli@bootlin.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chromeos-krk-upstreaming@google.com, "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Change all (s|g|query)_dv_timings subdev callbacks to include a pad argument. Signed-off-by: Pawe=C5=82 Anikiel --- drivers/media/i2c/ths7303.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/ths7303.c b/drivers/media/i2c/ths7303.c index ea70c1c13872..5e4a76eaf507 100644 --- a/drivers/media/i2c/ths7303.c +++ b/drivers/media/i2c/ths7303.c @@ -193,7 +193,7 @@ static int ths7303_s_stream(struct v4l2_subdev *sd, int= enable) } =20 /* for setting filter for HD output */ -static int ths7303_s_dv_timings(struct v4l2_subdev *sd, +static int ths7303_s_dv_timings(struct v4l2_subdev *sd, unsigned int pad, struct v4l2_dv_timings *dv_timings) { struct ths7303_state *state =3D to_state(sd); @@ -210,7 +210,6 @@ static int ths7303_s_dv_timings(struct v4l2_subdev *sd, static const struct v4l2_subdev_video_ops ths7303_video_ops =3D { .s_stream =3D ths7303_s_stream, .s_std_output =3D ths7303_s_std_output, - .s_dv_timings =3D ths7303_s_dv_timings, }; =20 #ifdef CONFIG_VIDEO_ADV_DEBUG @@ -317,9 +316,14 @@ static const struct v4l2_subdev_core_ops ths7303_core_= ops =3D { #endif }; =20 +static const struct v4l2_subdev_pad_ops ths7303_pad_ops =3D { + .s_dv_timings =3D ths7303_s_dv_timings, +}; + static const struct v4l2_subdev_ops ths7303_ops =3D { .core =3D &ths7303_core_ops, .video =3D &ths7303_video_ops, + .pad =3D &ths7303_pad_ops, }; =20 static int ths7303_probe(struct i2c_client *client) --=20 2.44.0.478.gd926399ef9-goog From nobody Sun Feb 8 06:04:22 2026 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 372DD16F906 for ; Fri, 5 Apr 2024 14:15:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326522; cv=none; b=LFYQ2XPZzCH8QogBBNtt3YkQChQ+FZNBetJSGb98S05ZSPd0bK44ol5uADIDgcu3NOJOd7BHNScIcomxo6WzKBT4vRpLV25dPLo35tWsRvxh8BB3jonXs8Kz7IwqmS14js7yWoKKF0boO6jtvnRIQ4ox80tIQvkKcW+2nzsA2b8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326522; c=relaxed/simple; bh=6SE0kPCYxfLmOcadEJPk07sX9YIfwYS2lpWnkue2zR8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=etLi8CHfuuTCNTiUcUqnubeIpgez7VQ/PNyD3NUZ2VrTuNxK0RMZOfXRTlGTzbNUUSn0r7nTQHIsT7njPYI2uRcvIIxBFvUmC9jgBCH7ctJlaqwbUNlJV/x0XfYI4ugQSqkpbQHWn+XIZHngjS65b22Kkg1HJ7d/SC2f4vZWg2A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=aGVrssa2; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="aGVrssa2" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-41481ad9364so16300375e9.0 for ; Fri, 05 Apr 2024 07:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712326519; x=1712931319; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=tPWJ94tQJYhK3/OOBFjDm8S/NzfWr3sQ4mvAu40pbWw=; b=aGVrssa208/JedoXdhuAsfVNsbChm8ilvckj5H+2nfjKmQhqWXzeEFotcsfeNU7Ngy G6qqHzMWDo+GYN/rs1Ot/FsHE21DGl28cYBv8MKFsModJMsVnhlgN5XDI02CezGC/cD5 yHlKpH97FucAjF1VfHEeyrtkTnCGC0+Cy40BWpiGTFcss4wYCTWMuuloRmGM3+hX1DE1 ZIg47Uuqx4VMzT+A2+Fjz+CwC0KMRCeU5sDF8JhbSYiipNNL+Qx44Dep88ITy0R8zOw3 ySHS5peYFH3y1XPMk+fjBCtDr7qOETY5vlcHPYF3jfegCP6KZx9bxaDk9w/djpf44yXN NJfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712326519; x=1712931319; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=tPWJ94tQJYhK3/OOBFjDm8S/NzfWr3sQ4mvAu40pbWw=; b=XG+M0K7bNS5YUpuyyDPObkJy0coEtGQiy3PurID2huf59JMvvO7uByf18dhCEiSCLp 3QECljUKr8Rz0vFfCuZzXWuCSdSeTjDpHi36hHSw5YLBN7WpeK6aIbE5kv+UcO6KQaOm gmIR482J1RqqE2ztEz1WPFsUrtQ7vT/orKFPFgRhSYNnoevdNqYS4AU0A4iQZ9Ow9Obd paGpJzazv7UjAHxQpZjrQWoYuDn1jvkjWjgXSrfovF9hnOihAG6rWdJ2ggWPa2G484Ti G7jFJs50lzA3xiBvvO9hLFOTQ5mAI1gHzsr2rmuubfuY9DsNZZhLgKepoBNJUNcLTEDr +9iA== X-Forwarded-Encrypted: i=1; AJvYcCXOYNb20Hs5MjjwMbNL1RsMy7/L4a69H5pyI42J8s5BHEZZqpynesA8XscypxxmUmBz48vTG/CwkCtI2V8E6NJxN+FO3FNuBi+LC87n X-Gm-Message-State: AOJu0YwEciMhF7kPeW2oSfiuS5EN+bryV2l3c90u79bPX1HLfUHJ2Z+a js7qweoUx/eOwB3ZKwm6KvCNzCNFmafLW8XS5NVEvzg51afCdh9TfXWmV6i6QZ+k4TXI3AZIK2l eDGHQWkljcQ== X-Google-Smtp-Source: AGHT+IHQfTupTS6QFxw4wd1lUfUH34e1AoeuC2pe3b5AQePG8p20sMvmkeKQHBjCW7WGybe4z/i4eJInLgDU+Q== X-Received: from szatan.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:2d83]) (user=panikiel job=sendgmr) by 2002:a05:600c:1d12:b0:416:2c7a:6b6 with SMTP id l18-20020a05600c1d1200b004162c7a06b6mr5110wms.0.1712326519687; Fri, 05 Apr 2024 07:15:19 -0700 (PDT) Date: Fri, 5 Apr 2024 14:14:04 +0000 In-Reply-To: <20240405141411.1807189-1-panikiel@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240405141411.1807189-1-panikiel@google.com> X-Mailer: git-send-email 2.44.0.478.gd926399ef9-goog Message-ID: <20240405141411.1807189-10-panikiel@google.com> Subject: [PATCH 09/16] media: i2c: ths8200: Switch dv timing callbacks to pad ops From: "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" To: kieran.bingham@ideasonboard.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, tharvey@gateworks.com, niklas.soderlund@ragnatech.se, prabhakar.csengg@gmail.com, charles-antoine.couret@nexvision.fr, thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com, luca.ceresoli@bootlin.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chromeos-krk-upstreaming@google.com, "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Change all (s|g|query)_dv_timings subdev callbacks to include a pad argument. Signed-off-by: Pawe=C5=82 Anikiel --- drivers/media/i2c/ths8200.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ths8200.c b/drivers/media/i2c/ths8200.c index 0e0f676cd221..ce0a7f809f19 100644 --- a/drivers/media/i2c/ths8200.c +++ b/drivers/media/i2c/ths8200.c @@ -358,13 +358,16 @@ static void ths8200_setup(struct v4l2_subdev *sd, str= uct v4l2_bt_timings *bt) bt->hsync, bt->vsync); } =20 -static int ths8200_s_dv_timings(struct v4l2_subdev *sd, +static int ths8200_s_dv_timings(struct v4l2_subdev *sd, unsigned int pad, struct v4l2_dv_timings *timings) { struct ths8200_state *state =3D to_state(sd); =20 v4l2_dbg(1, debug, sd, "%s:\n", __func__); =20 + if (pad !=3D 0) + return -EINVAL; + if (!v4l2_valid_dv_timings(timings, &ths8200_timings_cap, NULL, NULL)) return -EINVAL; @@ -385,13 +388,16 @@ static int ths8200_s_dv_timings(struct v4l2_subdev *s= d, return 0; } =20 -static int ths8200_g_dv_timings(struct v4l2_subdev *sd, +static int ths8200_g_dv_timings(struct v4l2_subdev *sd, unsigned int pad, struct v4l2_dv_timings *timings) { struct ths8200_state *state =3D to_state(sd); =20 v4l2_dbg(1, debug, sd, "%s:\n", __func__); =20 + if (pad !=3D 0) + return -EINVAL; + *timings =3D state->dv_timings; =20 return 0; @@ -420,11 +426,11 @@ static int ths8200_dv_timings_cap(struct v4l2_subdev = *sd, /* Specific video subsystem operation handlers */ static const struct v4l2_subdev_video_ops ths8200_video_ops =3D { .s_stream =3D ths8200_s_stream, - .s_dv_timings =3D ths8200_s_dv_timings, - .g_dv_timings =3D ths8200_g_dv_timings, }; =20 static const struct v4l2_subdev_pad_ops ths8200_pad_ops =3D { + .s_dv_timings =3D ths8200_s_dv_timings, + .g_dv_timings =3D ths8200_g_dv_timings, .enum_dv_timings =3D ths8200_enum_dv_timings, .dv_timings_cap =3D ths8200_dv_timings_cap, }; --=20 2.44.0.478.gd926399ef9-goog From nobody Sun Feb 8 06:04:22 2026 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27B0716F91E for ; Fri, 5 Apr 2024 14:15:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326526; cv=none; b=KL/Ja92LFPLK/el685MabpeXpC5GloKNcQB8rfxIr39HPsm6ghbL080P5HRTy0CSk0Gxp493CEXaUhXaXpwNmjD7wo8HGXu/PrV70lwgYOXZukI1lmLJBoPKyUaIZn8vbvyYSo21S1cJVnrSg7EeYqNDznPGFvSm4P1RQQaVOg8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326526; c=relaxed/simple; bh=5xnfmi2lBhW03BQCHOlNVYiVElPi3SW0dm8sNuaFNl0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ixxm643/ilkWSjDwo0d6Kb02N634lWPXddRvluAKrv9DdTFNyQfZCEQeVtmB1n5j/KzUQeiZ+qVkIk08n0UAlfOjfkmIHa9qREpon1ms7/d5goDzzMS6oWWvGC95VKEX4ClOxxsa3t7yVU+ympBCMwTjJvRl9zblDilGd7aOyCA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Se8eeWoI; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Se8eeWoI" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-4140225e68aso10707235e9.1 for ; Fri, 05 Apr 2024 07:15:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712326521; x=1712931321; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=lsbtTl/lsCYzP7KPwMVeecq4kI9jqfdKIXhI66el1Xk=; b=Se8eeWoI87xA6B53PvKAoBuk0DYolqT2e1Ct54thzg3XTtLGnTP4W2FwOgw3aEFvRk +nd96GDpkFmuWkZUfM8MnDtuOGHXUDuxR9vRaWo90ymQieOMRCxt2C9av8rMurmmbk77 PKKwGuDg1CUJbaNBDn318EUehdXAIuAhD82z+XO+REcaXwt3klGypAHKpgf5GHdVrYUy 260/EMVDCKqGFuNjRvSXM1wqWq5C2UtZ3RZbIAnHP57jsYtLD/djIfSk8gpjtY+tSTj4 s51Toj9fc0q4fNeqm1RAz7DNYEBwm2d431+wFrUpBZevBIxOU5LZ3FnM4xgi2rIwfcup KM2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712326521; x=1712931321; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=lsbtTl/lsCYzP7KPwMVeecq4kI9jqfdKIXhI66el1Xk=; b=XhZ3x2J500xHBltfkgIvZI6RVSedzElRCifKdvmA/xjqx2A/724oXnWlPOUuBw4xd7 AGY4F8nBRFI5Kba8YT8id0LwUF0CSG+vRUeWaFnmvVp5aU5H9jxMDrFw3laNDUuKm5a1 gIeylQegfUXy3hB38vPdBJDQdzXgE9eIAYJUpquiGhjbhTqMjXhM0tvADpqfaCYz7M0E WRUbLNq5Ks2Zv6UOnz+U6kuiXAnKwuj/E5Lv4+M4UnMX24YCUnSCrI6pt523Vd5p/ZZI BNvbEB0MVL+eXGK+WpBRP0jqgHAhIXQ4R6Ph+V/karVySNgHQWoa0i7DGWg7/B312Q8z 9slA== X-Forwarded-Encrypted: i=1; AJvYcCXFqowWZIXtkYFPQOj+wjrKWItAhLlTEGV8bR+PDXDtAWpBzDWs/BbZaqIBqFAldS919SJ3KvMOw0xdNHsgiV9p3Hq8hR/xSRHKywG9 X-Gm-Message-State: AOJu0YybNHTdfLiZEid05q/7uuPGDWvtiuftyu36u0hOTTir8jraLTCD ur0hRTkq13CVEN5mq4T6LNeRPXHt11HjP9Yvk04AtX2czRSVtU3rWltnEW7jWxZUwJy+eCjVDgr xNuG/yXAG1Q== X-Google-Smtp-Source: AGHT+IH7z/NIPYYuKTmisFXZIC5ABdbzSu5MmdtE9zAPHxlH0uA6LOlXz/68FujAlmVAv7FZ/1iKrTnqtbILTg== X-Received: from szatan.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:2d83]) (user=panikiel job=sendgmr) by 2002:a05:600c:3b08:b0:414:76ce:98fe with SMTP id m8-20020a05600c3b0800b0041476ce98femr4860wms.5.1712326521624; Fri, 05 Apr 2024 07:15:21 -0700 (PDT) Date: Fri, 5 Apr 2024 14:14:05 +0000 In-Reply-To: <20240405141411.1807189-1-panikiel@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240405141411.1807189-1-panikiel@google.com> X-Mailer: git-send-email 2.44.0.478.gd926399ef9-goog Message-ID: <20240405141411.1807189-11-panikiel@google.com> Subject: [PATCH 10/16] media: i2c: tvp7002: Switch dv timing callbacks to pad ops From: "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" To: kieran.bingham@ideasonboard.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, tharvey@gateworks.com, niklas.soderlund@ragnatech.se, prabhakar.csengg@gmail.com, charles-antoine.couret@nexvision.fr, thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com, luca.ceresoli@bootlin.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chromeos-krk-upstreaming@google.com, "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Change all (s|g|query)_dv_timings subdev callbacks to include a pad argument. Signed-off-by: Pawe=C5=82 Anikiel --- drivers/media/i2c/tvp7002.c | 26 ++++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/drivers/media/i2c/tvp7002.c b/drivers/media/i2c/tvp7002.c index 6a04ffae5343..881b54f46d41 100644 --- a/drivers/media/i2c/tvp7002.c +++ b/drivers/media/i2c/tvp7002.c @@ -546,13 +546,16 @@ static int tvp7002_write_inittab(struct v4l2_subdev *= sd, return error; } =20 -static int tvp7002_s_dv_timings(struct v4l2_subdev *sd, +static int tvp7002_s_dv_timings(struct v4l2_subdev *sd, unsigned int pad, struct v4l2_dv_timings *dv_timings) { struct tvp7002 *device =3D to_tvp7002(sd); const struct v4l2_bt_timings *bt =3D &dv_timings->bt; int i; =20 + if (pad !=3D 0) + return -EINVAL; + if (dv_timings->type !=3D V4L2_DV_BT_656_1120) return -EINVAL; for (i =3D 0; i < NUM_TIMINGS; i++) { @@ -566,11 +569,14 @@ static int tvp7002_s_dv_timings(struct v4l2_subdev *s= d, return -EINVAL; } =20 -static int tvp7002_g_dv_timings(struct v4l2_subdev *sd, +static int tvp7002_g_dv_timings(struct v4l2_subdev *sd, unsigned int pad, struct v4l2_dv_timings *dv_timings) { struct tvp7002 *device =3D to_tvp7002(sd); =20 + if (pad !=3D 0) + return -EINVAL; + *dv_timings =3D device->current_timings->timings; return 0; } @@ -659,12 +665,16 @@ static int tvp7002_query_dv(struct v4l2_subdev *sd, i= nt *index) return 0; } =20 -static int tvp7002_query_dv_timings(struct v4l2_subdev *sd, +static int tvp7002_query_dv_timings(struct v4l2_subdev *sd, unsigned int p= ad, struct v4l2_dv_timings *timings) { int index; - int err =3D tvp7002_query_dv(sd, &index); + int err; + + if (pad !=3D 0) + return -EINVAL; =20 + err =3D tvp7002_query_dv(sd, &index); if (err) return err; *timings =3D tvp7002_timings[index].timings; @@ -861,9 +871,6 @@ static const struct v4l2_subdev_core_ops tvp7002_core_o= ps =3D { =20 /* Specific video subsystem operation handlers */ static const struct v4l2_subdev_video_ops tvp7002_video_ops =3D { - .g_dv_timings =3D tvp7002_g_dv_timings, - .s_dv_timings =3D tvp7002_s_dv_timings, - .query_dv_timings =3D tvp7002_query_dv_timings, .s_stream =3D tvp7002_s_stream, }; =20 @@ -872,6 +879,9 @@ static const struct v4l2_subdev_pad_ops tvp7002_pad_ops= =3D { .enum_mbus_code =3D tvp7002_enum_mbus_code, .get_fmt =3D tvp7002_get_pad_format, .set_fmt =3D tvp7002_set_pad_format, + .g_dv_timings =3D tvp7002_g_dv_timings, + .s_dv_timings =3D tvp7002_s_dv_timings, + .query_dv_timings =3D tvp7002_query_dv_timings, .enum_dv_timings =3D tvp7002_enum_dv_timings, }; =20 @@ -1001,7 +1011,7 @@ static int tvp7002_probe(struct i2c_client *c) =20 /* Set registers according to default video mode */ timings =3D device->current_timings->timings; - error =3D tvp7002_s_dv_timings(sd, &timings); + error =3D tvp7002_s_dv_timings(sd, 0, &timings); =20 #if defined(CONFIG_MEDIA_CONTROLLER) device->pad.flags =3D MEDIA_PAD_FL_SOURCE; --=20 2.44.0.478.gd926399ef9-goog From nobody Sun Feb 8 06:04:22 2026 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F91016FF3D for ; Fri, 5 Apr 2024 14:15:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326526; cv=none; b=TG9LlaQLWHMCP37HK2KPH/EG8bFV0XHcetMK59tuxR1bMll4JfBkICWK426maziEGDuG4B+z39WdL7aRqwh8neLbe9ppf6V7DdaNIcmgXT8xgYd2MUMRL3US0lhtkw42PWeDF+om1+2TxiLyZA6LrijFuVB6WqJuNlT7Ti1P/8E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326526; c=relaxed/simple; bh=NDwy44L0Jhu5ltK/Qxlk6F2up/ZRjhK55Rnmu42WtFo=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=l2osZ12iNm8a4r2ZwOubnoZT7gBL1uYp1Wtqu6JqGxp7CtCU6o3DPxOUPVRPQdn+RfRMvVaL5osLyfOOX/iZDibwWx+tkpbDE7dOT/f8VDST+mGPrjGiOmX5jUS+awu9T+rrBVoCqtozBqqOiaxFZShB5qWLIAPTVpTiPq5nU+c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=iGkRBpWr; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="iGkRBpWr" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-dd8e82dd47eso3266156276.2 for ; Fri, 05 Apr 2024 07:15:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712326523; x=1712931323; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=lJXjeQEubm8j9rzfDm3JhpB2lxNrpssVrF6JxlheeFU=; b=iGkRBpWrTtvioIUngKWxG6ipIXrrTGsmm0rchtJGXXLdkDfXTl/lYb4pAPI8Mxa5ad 3KD55i7DxmNgZI8K/14Ks3B05gg200XD8rgwTY/CV7vBdhJiKGr1fE3vTDeuy24JJe+M kd1lDsHeJtB9Ti++HBeENFzGzhcdaV7l6fj6wPUOfo+xJWEMH7sf/xg+Y6RQfGLxSKqE 5OF8ajTSDbzta5a+FpISc4Flk/s+a+Is+XA29aWU1tvAzr+lsG4WG7F9r0Ty+SV9WJ1d CHPdXWXDl8S+xJKnqnJ/r4KvpCCr9wQb+OkANqdBjKuxKMTSvI2OBOM/+jMsVp+IL+tO c1rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712326523; x=1712931323; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=lJXjeQEubm8j9rzfDm3JhpB2lxNrpssVrF6JxlheeFU=; b=jBaY1xcVkp8uoTBS2manZSvM5qOT1rTJF5RgkWzCBjiSEhgPNv9rkkkUlDadbQMHuO PDRj5p+vbXh+E+qTF+ESkZMA50+x77SS5nRS0Hk51aSe5De/qHrA5XP04DiZsKmwUFUB mZ6Pwz5Z1oVHm5DJFQIeaugE6Ig1eopdhzhdUgS3tE/I4IeotD7RZFiQdy/KN48rLzwi j9L2d/yh0joN6WW+eVDfQBkU70dIHucHe7kjghBIYc1HhZ24j4dL7Ptk09Kwwz4IXrpH oRpqGhYZK4R93cAgx5On7+LFMpNj0Gm9Mth7nwk7hN85m8GMMvvHWhHwTVgSI0nOyum9 XKbg== X-Forwarded-Encrypted: i=1; AJvYcCV2AExsKU7mj7HZQU6N7nioAl5udgCA4kRFMyWaDLOYw4gKXdbDZtdLrwzmGcRuoZFtYQW/fiYHqn1fiaS9GkUUxlNObGCpb5TOxl9p X-Gm-Message-State: AOJu0Ywly6Pu401UoEsU6F2cttfhbiO+JAYJSFr9fOBGLwLskXlGs93F MKoc4sAF4d9//FgqCKvxo6Qnv9DztNX9fAHVkeH8eulCky2f0zv7VLK9jjYWgu2cChYrAGPh3V3 ENKDs8TSCBw== X-Google-Smtp-Source: AGHT+IFVFwlZU1PraJh7zR4KWB5k+lXQt0DhRwiJsHwWvJZodZ5pAkCM37kDWlFescohXveYraQyCFA+NS+Tqw== X-Received: from szatan.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:2d83]) (user=panikiel job=sendgmr) by 2002:a05:6902:f87:b0:dbe:30cd:8fcb with SMTP id ft7-20020a0569020f8700b00dbe30cd8fcbmr71259ybb.0.1712326523732; Fri, 05 Apr 2024 07:15:23 -0700 (PDT) Date: Fri, 5 Apr 2024 14:14:06 +0000 In-Reply-To: <20240405141411.1807189-1-panikiel@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240405141411.1807189-1-panikiel@google.com> X-Mailer: git-send-email 2.44.0.478.gd926399ef9-goog Message-ID: <20240405141411.1807189-12-panikiel@google.com> Subject: [PATCH 11/16] media: spi: gs1662: Switch dv timing callbacks to pad ops From: "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" To: kieran.bingham@ideasonboard.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, tharvey@gateworks.com, niklas.soderlund@ragnatech.se, prabhakar.csengg@gmail.com, charles-antoine.couret@nexvision.fr, thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com, luca.ceresoli@bootlin.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chromeos-krk-upstreaming@google.com, "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Change all (s|g|query)_dv_timings subdev callbacks to include a pad argument. Signed-off-by: Pawe=C5=82 Anikiel --- drivers/media/spi/gs1662.c | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/media/spi/gs1662.c b/drivers/media/spi/gs1662.c index 75c21a93e6d0..44f97e99ff15 100644 --- a/drivers/media/spi/gs1662.c +++ b/drivers/media/spi/gs1662.c @@ -259,12 +259,15 @@ static inline struct gs *to_gs(struct v4l2_subdev *sd) return container_of(sd, struct gs, sd); } =20 -static int gs_s_dv_timings(struct v4l2_subdev *sd, +static int gs_s_dv_timings(struct v4l2_subdev *sd, unsigned int pad, struct v4l2_dv_timings *timings) { struct gs *gs =3D to_gs(sd); int reg_value; =20 + if (pad !=3D 0) + return -EINVAL; + reg_value =3D get_register_timings(timings); if (reg_value =3D=3D 0x0) return -EINVAL; @@ -273,16 +276,19 @@ static int gs_s_dv_timings(struct v4l2_subdev *sd, return 0; } =20 -static int gs_g_dv_timings(struct v4l2_subdev *sd, +static int gs_g_dv_timings(struct v4l2_subdev *sd, unsigned int pad, struct v4l2_dv_timings *timings) { struct gs *gs =3D to_gs(sd); =20 + if (pad !=3D 0) + return -EINVAL; + *timings =3D gs->current_timings; return 0; } =20 -static int gs_query_dv_timings(struct v4l2_subdev *sd, +static int gs_query_dv_timings(struct v4l2_subdev *sd, unsigned int pad, struct v4l2_dv_timings *timings) { struct gs *gs =3D to_gs(sd); @@ -290,6 +296,9 @@ static int gs_query_dv_timings(struct v4l2_subdev *sd, u16 reg_value, i; int ret; =20 + if (pad !=3D 0) + return -EINVAL; + if (gs->enabled) return -EBUSY; =20 @@ -410,14 +419,14 @@ static const struct v4l2_subdev_core_ops gs_core_ops = =3D { }; =20 static const struct v4l2_subdev_video_ops gs_video_ops =3D { - .s_dv_timings =3D gs_s_dv_timings, - .g_dv_timings =3D gs_g_dv_timings, .s_stream =3D gs_s_stream, .g_input_status =3D gs_g_input_status, - .query_dv_timings =3D gs_query_dv_timings, }; =20 static const struct v4l2_subdev_pad_ops gs_pad_ops =3D { + .s_dv_timings =3D gs_s_dv_timings, + .g_dv_timings =3D gs_g_dv_timings, + .query_dv_timings =3D gs_query_dv_timings, .enum_dv_timings =3D gs_enum_dv_timings, .dv_timings_cap =3D gs_dv_timings_cap, }; --=20 2.44.0.478.gd926399ef9-goog From nobody Sun Feb 8 06:04:22 2026 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87956171073 for ; Fri, 5 Apr 2024 14:15:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326529; cv=none; b=MBxmm46zHmxNRlnaNTTkKvcybW/Gy3fvEpbDMEfrbh30U3dXGDllCn1S3vGHK93U8IV+xNgNkueLuhKVrJC0NiS7qgDAtPvbZUyMmK0dl1v1tmeh8CJYInJ8jWFy811PprTSqfEhK+0ac4RTWs3F0AzOziqFgvtVnb1/7gBiG4Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326529; c=relaxed/simple; bh=mfc1m6KDq5p7GnXUa2OC5+vQdowDmHrvR4jMIquIzew=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=oxSx50GD1neBrQlAX4ceWVM+Q9OhyHXV2iEN2lWkCQaB+ROEVHQhHSY3FbASmhVNEBgJEBRxH/d3DXwvm6SNj1i+38Kyc+OZhwT7RIzX7aLUnPyAKDgxOPwTj+dtC7+CWlIfMWHgaKjMb3b1l8GSYA9DW3JMlUR8CZd83BJ2RM8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ifTDKXB0; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ifTDKXB0" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-41545bc8962so11152515e9.2 for ; Fri, 05 Apr 2024 07:15:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712326526; x=1712931326; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=wugwx+VMt8ynxKvmOS+NYWFgHzSCikAiIg38gbA/J2Y=; b=ifTDKXB0IPsN1TKwwdaZSIgfQoNkhEOnvZkZzg5fnDOGNxgCPUzzU+JdxPp9RMvBii sPZNCCPprlffIp0fm7cbh6ucvJ2nieW20NrJMnUGK5K8tadoiYevaId3Af/MzMuo2HDD NHdPgOqR0lFxer+/mtFEVfISh4nmxFOE7GBdlUG8IJpoYIIjGvs1gY0dluiti9Iwi4c8 cQFnH6htFZlOoN3QKYoSzPDIJyPTWth7dq4aGOb3HQLR0dq5lNpLk2U+d/Ejg6icrziz wxzSPsyWoWKLHXWM4yoVEX6Z+VFZot9UBEdaFDTdnCDOuJMcpoDnqIiFGVpWdxgRSRuO odRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712326526; x=1712931326; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=wugwx+VMt8ynxKvmOS+NYWFgHzSCikAiIg38gbA/J2Y=; b=IXAoQpQQ59LDReAeqAEYOkwbZg1SOrmwcBnSBCHI8ttamRLKaLYJvfztSoU1/KRtgg GPOlnVaHkca3ptW6VYEBKu/eNg0NVVcB3Mch7ErXhnUKPR/9nurEE5VnkceHF3y29/S3 ZUFqsHxXjeLHBntYybycIy9TYZ+OA1+blBro2mjjjWkIMHe0owydYfy4eCjImjk/E90n 3PY+JfG4D2bZdpRKBCNQjdgKcoOTQ3PiPhTlQO1I4pUhOu7CmPot9ajFs2Fo0glGSHKM o9eYF8Hs38rX8NkZEemKJhplxIdgEpDJhaQwxZPjFBzpc1eOLcDBJjfwVM8VynvjHZOc BOwg== X-Forwarded-Encrypted: i=1; AJvYcCWta32cAqorIyjB+ZJY+QWG4c3AjocrGGYe67hfBG60fgjzgiUNqXNq/Lg2db9FoDX60cXkbjgVfloCPDmMTfjJv/POHzoU9qt2UJKX X-Gm-Message-State: AOJu0YyQXFnJDzka1AhwGTBHHlmKDKiOCE4eGYta8NygEzcMbgVDEVU0 z/blITr7/f+lsp79pxWCJtUL1npnnlcTQHHMUztMHfaRS2pNGarsxxn1VOTUry+Vkju0eBSMfow 9ZcFB3xhyOA== X-Google-Smtp-Source: AGHT+IEw3A0Uc6NCN5jC8nFV1gniwcXIKQUoVyZzSeSYIjiu5QNMVRGAQCd+P4ZhwXiSptLaQwbbPf4g4bXbXg== X-Received: from szatan.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:2d83]) (user=panikiel job=sendgmr) by 2002:a05:600c:3b8e:b0:414:8933:a617 with SMTP id n14-20020a05600c3b8e00b004148933a617mr4543wms.4.1712326525846; Fri, 05 Apr 2024 07:15:25 -0700 (PDT) Date: Fri, 5 Apr 2024 14:14:07 +0000 In-Reply-To: <20240405141411.1807189-1-panikiel@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240405141411.1807189-1-panikiel@google.com> X-Mailer: git-send-email 2.44.0.478.gd926399ef9-goog Message-ID: <20240405141411.1807189-13-panikiel@google.com> Subject: [PATCH 12/16] media: cobalt: Use pad variant of dv timing subdev calls From: "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" To: kieran.bingham@ideasonboard.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, tharvey@gateworks.com, niklas.soderlund@ragnatech.se, prabhakar.csengg@gmail.com, charles-antoine.couret@nexvision.fr, thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com, luca.ceresoli@bootlin.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chromeos-krk-upstreaming@google.com, "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the pad variant for all (s|g|query)_dv_timings subdev calls, which includes a pad argument. Signed-off-by: Pawe=C5=82 Anikiel --- drivers/media/pci/cobalt/cobalt-v4l2.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/media/pci/cobalt/cobalt-v4l2.c b/drivers/media/pci/cob= alt/cobalt-v4l2.c index 77ba08ace29f..d4d7b264c965 100644 --- a/drivers/media/pci/cobalt/cobalt-v4l2.c +++ b/drivers/media/pci/cobalt/cobalt-v4l2.c @@ -633,7 +633,7 @@ static int cobalt_s_dv_timings(struct file *file, void = *priv_fh, return -EBUSY; =20 err =3D v4l2_subdev_call(s->sd, - video, s_dv_timings, timings); + pad, s_dv_timings, 0, timings); if (!err) { s->timings =3D *timings; s->width =3D timings->bt.width; @@ -653,7 +653,7 @@ static int cobalt_g_dv_timings(struct file *file, void = *priv_fh, return 0; } return v4l2_subdev_call(s->sd, - video, g_dv_timings, timings); + pad, g_dv_timings, 0, timings); } =20 static int cobalt_query_dv_timings(struct file *file, void *priv_fh, @@ -666,7 +666,7 @@ static int cobalt_query_dv_timings(struct file *file, v= oid *priv_fh, return 0; } return v4l2_subdev_call(s->sd, - video, query_dv_timings, timings); + pad, query_dv_timings, 0, timings); } =20 static int cobalt_dv_timings_cap(struct file *file, void *priv_fh, @@ -1080,7 +1080,7 @@ static int cobalt_g_pixelaspect(struct file *file, vo= id *fh, if (s->input =3D=3D 1) timings =3D cea1080p60; else - err =3D v4l2_subdev_call(s->sd, video, g_dv_timings, &timings); + err =3D v4l2_subdev_call(s->sd, pad, g_dv_timings, 0, &timings); if (!err) *f =3D v4l2_dv_timings_aspect_ratio(&timings); return err; @@ -1099,7 +1099,7 @@ static int cobalt_g_selection(struct file *file, void= *fh, if (s->input =3D=3D 1) timings =3D cea1080p60; else - err =3D v4l2_subdev_call(s->sd, video, g_dv_timings, &timings); + err =3D v4l2_subdev_call(s->sd, pad, g_dv_timings, 0, &timings); =20 if (err) return err; @@ -1243,7 +1243,7 @@ static int cobalt_node_register(struct cobalt *cobalt= , int node) if (s->sd) vdev->ctrl_handler =3D s->sd->ctrl_handler; s->timings =3D dv1080p60; - v4l2_subdev_call(s->sd, video, s_dv_timings, &s->timings); + v4l2_subdev_call(s->sd, pad, s_dv_timings, 0, &s->timings); if (!s->is_output && s->sd) cobalt_enable_input(s); vdev->ioctl_ops =3D s->is_dummy ? &cobalt_ioctl_empty_ops : --=20 2.44.0.478.gd926399ef9-goog From nobody Sun Feb 8 06:04:22 2026 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0313C17108B for ; Fri, 5 Apr 2024 14:15:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326530; cv=none; b=ujB/9HZhiU65fJ2/EI1k1CN7X1LHUQgJRTQkxjMjzCMBycU8Iq8JY8k+FZOWFynslbrTmUwy12+5gUUgnQQG4fRm1fJDXUbgq16uJGlKhbSZTghrtmWesCAz50wXhg7FyZjbYJlp9dZ1Ug8S9XMR7kK7lViLF8K1z9k76Y5iHJQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326530; c=relaxed/simple; bh=yvs5ohvMMIVQE6dxuoqe23hp8oOeKkHAZNgJM1b+eKo=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=mCUkyR1iDD/nMrV6wjHk1mJ9WURLZhMn2BfmcEsy9H2mQVzpDedlNyCDsP6t3AUHyJmBmBSlicWJG8OjK63N2OC+zk0bqAdciHCjfxWlL1z6jH0sdoIDA5Dn7pEesPfnhBII4lbwA44F7wyxAYMrkW+1+5SYvVMqNtBs3YuJtzc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=1NDS4pOq; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="1NDS4pOq" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-dbf618042daso3441917276.0 for ; Fri, 05 Apr 2024 07:15:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712326528; x=1712931328; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=/C3TWz2wSP1NLw9gzEQpvHS/0ZIC1cjOjpTFuVIJ/6s=; b=1NDS4pOqa1MUMC9X9Dt/O2w125FOzhVlpogK4thoUyLctqpGh6i+LY+PxQj3blJ1tX q1HxiQNm/TqaSWQXI4Dhd6Bpc3WbxrFWuHIIVl6NzsrNMeFOhG2pCso9dK6N2Znw2seH Jd0bIfy9dHMziuUc/RoqvpnmHX+uz2oJc7tDVtkB2rzWFhteVVq11SV/70QFLsBn6zPj toaipmG4wLpkq0u4SgM7qehQ/PGOJjAnZ9GzVBbu09qmALdAmIGrTGSjXjJHsk+ATIV6 DA34rc44LaLekwFBaTkCRoQX881V9Jl0Y1YgCZwU04oQLTQOEDLb9+av/bVX3fzG7oto m0/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712326528; x=1712931328; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=/C3TWz2wSP1NLw9gzEQpvHS/0ZIC1cjOjpTFuVIJ/6s=; b=n3vaN7Jkz94/S0WEt4dzwtfnQDeR4jPP0QkJ/9qbfkLxszAN5/FEbFDREDFFJrGOgf PJiWvjTOwEe8TcXGJ+Rjg7bE8CTFVY40JmErnpQOOaj+E7dgsBjAYO0MDgD/yrxWfR3K OVGXNH4np8v0TxFhYQVFZJQP/uPDPeoLol8NwnJ0PgjVEDO+uj1DPoIMdoKt+394UGmr K20ZJmlzKz+FyhLk2GFtzWsQWbqAaynpLG/wXW145pEclGZv/6F6DtaR+Izcavau8l5c FnY4mr9RH2Tqprbizo+iNgD5UeUYK9jfgfJY89HT9L0WAW92Nza2AL/Ytgb8qIfaFBCL bmfw== X-Forwarded-Encrypted: i=1; AJvYcCWZYnRk3mvLl1LbjOXzVBQ3qOFEFs7bG7g8RXhHE5eWKilREvUKZts/l3gayJLD9KkJLeZ8lOc5ZgsM2XxjagICRc1B+HNmA6XlWiwQ X-Gm-Message-State: AOJu0YzlafOCSE5tmhSPipWuNK4YPmzLZ5k6yD0v8eZYDal62gxRzyD1 /Xu+DNURtR9oNNbxJNXuN1J3yXzCyCQ7hEO1cK8rDh1a/owZw9Ia+86ecFjK3ilTCCnhlS48w2l R1Dj08SSLKA== X-Google-Smtp-Source: AGHT+IEvp+BsuWIh3iX4/LFegWn3KNCA11AfpYD2+Kk6/aMGIrt5lA5NyDXfFDJdRSyf+ooQiTrgoqyEH/yGTA== X-Received: from szatan.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:2d83]) (user=panikiel job=sendgmr) by 2002:a05:6902:1108:b0:dc7:865b:22c6 with SMTP id o8-20020a056902110800b00dc7865b22c6mr78546ybu.8.1712326528036; Fri, 05 Apr 2024 07:15:28 -0700 (PDT) Date: Fri, 5 Apr 2024 14:14:08 +0000 In-Reply-To: <20240405141411.1807189-1-panikiel@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240405141411.1807189-1-panikiel@google.com> X-Mailer: git-send-email 2.44.0.478.gd926399ef9-goog Message-ID: <20240405141411.1807189-14-panikiel@google.com> Subject: [PATCH 13/16] media: rcar-vin: Use pad variant of dv timing subdev calls From: "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" To: kieran.bingham@ideasonboard.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, tharvey@gateworks.com, niklas.soderlund@ragnatech.se, prabhakar.csengg@gmail.com, charles-antoine.couret@nexvision.fr, thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com, luca.ceresoli@bootlin.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chromeos-krk-upstreaming@google.com, "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the pad variant for all (s|g|query)_dv_timings subdev calls, which includes a pad argument. Signed-off-by: Pawe=C5=82 Anikiel Tested-by: Niklas S=C3=B6derlund --- drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c b/drivers/= media/platform/renesas/rcar-vin/rcar-v4l2.c index 073f70c6ac68..bb4b07bed28d 100644 --- a/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c +++ b/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c @@ -730,7 +730,8 @@ static int rvin_s_dv_timings(struct file *file, void *p= riv_fh, struct v4l2_subdev *sd =3D vin_to_source(vin); int ret; =20 - ret =3D v4l2_subdev_call(sd, video, s_dv_timings, timings); + ret =3D v4l2_subdev_call(sd, pad, s_dv_timings, + vin->parallel.sink_pad, timings); if (ret) return ret; =20 @@ -744,7 +745,8 @@ static int rvin_g_dv_timings(struct file *file, void *p= riv_fh, struct rvin_dev *vin =3D video_drvdata(file); struct v4l2_subdev *sd =3D vin_to_source(vin); =20 - return v4l2_subdev_call(sd, video, g_dv_timings, timings); + return v4l2_subdev_call(sd, pad, g_dv_timings, + vin->parallel.sink_pad, timings); } =20 static int rvin_query_dv_timings(struct file *file, void *priv_fh, @@ -753,7 +755,8 @@ static int rvin_query_dv_timings(struct file *file, voi= d *priv_fh, struct rvin_dev *vin =3D video_drvdata(file); struct v4l2_subdev *sd =3D vin_to_source(vin); =20 - return v4l2_subdev_call(sd, video, query_dv_timings, timings); + return v4l2_subdev_call(sd, pad, query_dv_timings, + vin->parallel.sink_pad, timings); } =20 static int rvin_dv_timings_cap(struct file *file, void *priv_fh, --=20 2.44.0.478.gd926399ef9-goog From nobody Sun Feb 8 06:04:22 2026 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10A49171653 for ; Fri, 5 Apr 2024 14:15:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326532; cv=none; b=H3D7JcyExhQ9zgr9QI6Nt5GGrmbWGW0/zKcvGryzleR8CFtK0LejVXW+Ljo0hphgKUXpzcrtojp4aPtbDy4kInZ7uq26ybYC3XukJ8PmBVuZWO91gPHaOewLGDNZhDYHOz1beHn/ESedzJMV1NyfDv8Odv20/eMoffamsSH/01g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326532; c=relaxed/simple; bh=Gj3IPZ/cV8XkfW4/IgCRVRhUfpKtTDbbVSp/MYuw5kI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ogqV4T8tjg8aSZja/GzLl28jXU3sN7JLCUjmy6Gmy8X0KR71FlKuVV3l2IkCYMmuT/ZKfDyuuKm04cHABZS497BrwXm+HsHA/DdKO/01dAa8kwFRAGDSlJ0SrSt0olnEWlGML8Rmz1R3tM+UIQ62hrqfZ3NsJ/i2OijyzJ3in7M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=K6d0uWwc; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="K6d0uWwc" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dcbfe1a42a4so3760997276.2 for ; Fri, 05 Apr 2024 07:15:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712326530; x=1712931330; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=9A37cgV5rFPpxOwI7Xp0bOeOJhNv60o94qm0Vr/m29M=; b=K6d0uWwcZnkeh2hgIAOIU90QMYBZDeteKQ4gzvEQq+0lJzMIcPQk6p9Uo28cu+0ZvH uJh6ZGYj0UvMdPqoM9OvAZ69pXJn4x17eaLVy3d7yqctq0l64KWzPXpDY1iHcBPvWHqj QtTgfIVihF6LADjHlUllvC77h/v2kxJfD50K4EvuutWr5VRDUkuOre/QqvvXnff6OGfB MpHV1F098tnZw9ZFL5F2KEharw3+VlmjVVzbpSOn5jlvxdC7fjUQRQ33FrbIvKK+4E25 RTm2jv8M8IOxoJfbC8C7Xb5cDYgPrfJLtV0Y1voUENLKENjmThRtpg7NdE+Ow5ykj6Rn gVEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712326530; x=1712931330; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9A37cgV5rFPpxOwI7Xp0bOeOJhNv60o94qm0Vr/m29M=; b=qpVM1P5mOEWby0Pt6V1/n8bpZRggJoH6CcFiF2b+tlRdudhSA9H2UJ0Szj9sm9Rgqa +WQ3sP5Hb2h4nZVSxxBPix79YLApFVVNmGa7WDK76ywSLz9lh+VJ70fuqIiTR2DX6ddC ygUHozO2l3kV6hw6HVPvX/40e1lRGRJwwRvjwHxHUmjRWsjHtTL77aDTILR0MEqeDH5P CHg64WY1iJfJNrItjYPT2E8pqcAMNO12HiEFjkI+QDiIX1qeIQwFNGEVl1E+9xVW+1uV VCj/G23UGMwm2OLqdUr/QN6YKs67OLh1i29KmzYAwLuQR0DMSQj186g9EW39WA4LcGGP McPQ== X-Forwarded-Encrypted: i=1; AJvYcCUyWpBDhwF34yn3tbS6cUROD7M0Oo16RbkInolI+UcCJ5nJ0YbBoMbpCePqKqTWxazaTtMSYxrIdqPueZt9MW/eUP/6OvLd45TpSteF X-Gm-Message-State: AOJu0Yxe7Owq3iHH22x5c/kiEr7n7iRPcnw+07klcvAvcwhGSJhRsnow mTdN8Uook6sFqXQbjBEKg40SAe6fjCJyvGint/ZU5LXweKANWOn2W/X4Jkp5lrlTGIuQxtQUZat yq9x8URNEXw== X-Google-Smtp-Source: AGHT+IGf8GetzSX8AEJwlaqvDvL5MrA0JXoPMyjXUoUj+or0FEsWZ+U/ylOjbpKO18vhlQTas1pDdH/t0YW6Kw== X-Received: from szatan.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:2d83]) (user=panikiel job=sendgmr) by 2002:a05:6902:100b:b0:dcc:6065:2b3d with SMTP id w11-20020a056902100b00b00dcc60652b3dmr394034ybt.8.1712326530209; Fri, 05 Apr 2024 07:15:30 -0700 (PDT) Date: Fri, 5 Apr 2024 14:14:09 +0000 In-Reply-To: <20240405141411.1807189-1-panikiel@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240405141411.1807189-1-panikiel@google.com> X-Mailer: git-send-email 2.44.0.478.gd926399ef9-goog Message-ID: <20240405141411.1807189-15-panikiel@google.com> Subject: [PATCH 14/16] media: vpif_capture: Use pad variant of dv timing subdev calls From: "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" To: kieran.bingham@ideasonboard.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, tharvey@gateworks.com, niklas.soderlund@ragnatech.se, prabhakar.csengg@gmail.com, charles-antoine.couret@nexvision.fr, thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com, luca.ceresoli@bootlin.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chromeos-krk-upstreaming@google.com, "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the pad variant for all (s|g|query)_dv_timings subdev calls, which includes a pad argument. Signed-off-by: Pawe=C5=82 Anikiel --- drivers/media/platform/ti/davinci/vpif_capture.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/ti/davinci/vpif_capture.c b/drivers/med= ia/platform/ti/davinci/vpif_capture.c index c31a5566fc5a..c28794b6677b 100644 --- a/drivers/media/platform/ti/davinci/vpif_capture.c +++ b/drivers/media/platform/ti/davinci/vpif_capture.c @@ -1132,7 +1132,7 @@ vpif_query_dv_timings(struct file *file, void *priv, if (input.capabilities !=3D V4L2_IN_CAP_DV_TIMINGS) return -ENODATA; =20 - ret =3D v4l2_subdev_call(ch->sd, video, query_dv_timings, timings); + ret =3D v4l2_subdev_call(ch->sd, pad, query_dv_timings, 0, timings); if (ret =3D=3D -ENOIOCTLCMD || ret =3D=3D -ENODEV) return -ENODATA; =20 @@ -1177,7 +1177,7 @@ static int vpif_s_dv_timings(struct file *file, void = *priv, return -EBUSY; =20 /* Configure subdevice timings, if any */ - ret =3D v4l2_subdev_call(ch->sd, video, s_dv_timings, timings); + ret =3D v4l2_subdev_call(ch->sd, pad, s_dv_timings, 0, timings); if (ret =3D=3D -ENOIOCTLCMD || ret =3D=3D -ENODEV) ret =3D 0; if (ret < 0) { --=20 2.44.0.478.gd926399ef9-goog From nobody Sun Feb 8 06:04:22 2026 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41A67171E40 for ; Fri, 5 Apr 2024 14:15:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326534; cv=none; b=HCCXcVJwjrUSEAaS0QbzLWNJPNL3i8q7Zrp028zneRP6S/R/7PKbbQ3ElObFWGepXd73mkBsiDwF/ZdiQuofnq9jXWCdNBlnX0zl0+ZehRhwhhTmqXYkUjsKyxl74QtSEwMhD/b04IwSPzFIfyvvKfbszKKE2HsmgsOL63KhHq4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326534; c=relaxed/simple; bh=l0oG3N8c8mojKDmxECCVZ1V3hwbkCu1xRwc6SEUeGck=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=pRHnXGxxPXfsqzpv/723Qzc5mqKeK/V66+bC2Xw0Qkr5xkHs+MR1jl+VGgVqV2fhpzFDoPbtQEfeSiHkMwonYwEK4RpjxHPKJc1zSMU2iHiRzgIOptqo3v9jaXV26gG+eEyydwNjFkZvD1IHjto+jho2LQ8Rmbh5WdrccuLculg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=lGfM31qn; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lGfM31qn" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-6150e36ca0dso35169937b3.1 for ; Fri, 05 Apr 2024 07:15:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712326532; x=1712931332; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=HIc/vnSojBwtbKTlmQZ+P1NRRI2WMTZiwEa64VZPTHs=; b=lGfM31qnbTW8rUmAx5p+NPQwxJZcUuZOLG4Y2sn1VWK7CmT6WR3G65fN9SExuf4cQ4 kQxcpxezF8f1dO36zRBubuRdpDoDQcEHaPYBZNpgij9d6opO2ev25X/QOtRSCKx6YAd+ zgM7mx39tC5sApE94sTL24ZWxsjNvmMF9cvsBKZ/7qfp8QF/ThdVIVQ/OQpQdhjEiKUw pWfQ+cu5uF8dCNPZvJ2Jz/DuA34hVNiYhjFmVshHDrnMXsZBZNxaiKW3rlGf69aJN9zk zyUbw3nutYyEIu79f7fOq55MUNmCRliqtDS+spMzoYIi2HWPQEzCQqcvFAgDoN6TUwfh WBCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712326532; x=1712931332; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=HIc/vnSojBwtbKTlmQZ+P1NRRI2WMTZiwEa64VZPTHs=; b=n+waLSun5vWuk/x5y4NrJhTprBkA+zLYJJQwzd1sliOWFHbsWew1mctPWVU1k2euQm ShOGjYStryeTxMmKeLZxqTS5zzUb1jQ4Ho0TsFpPsp5T4MIXXrlAtdICEMe7G2dWvyXh BuUH571j4QYwdcoqht0kb8d5IYz47NVbOF18uCkPunIRuQoWwwEhDbtHxBORYaVXVyhk udec5fXot9OyL8EQNkWbBo/jD3j4o1OsqZZup133ZUyILhwB1HwdR1GpH2eTiiAhhq47 Dukc2iWbtzeResfCDOkeDx3nzdPl0C+i//xFDdxNOLFuyov0seEsrcd2I6y5gjRhAc99 mNBw== X-Forwarded-Encrypted: i=1; AJvYcCX5gTjXH8K9J3dP5p7KbUmcANW1QMWmMZR/ORy52tfudgmyE0qP5bBugMtij22s8iojqOnhBQ73xWf/J876DTRmEjoeeQRUnSFRQTsg X-Gm-Message-State: AOJu0YywDPX8nMxlP3zlpNY5RdptNLqpj88NjMnGy0Pxa9QCACjwN2GF PkK+O7FtHxR7fJvmZYrlgLDvH5FC3iRqr9KSgbRuPH0xvCQ1MXNZvluW+c8XO40ftWjDBVNDxr0 eiy4rsDXwkQ== X-Google-Smtp-Source: AGHT+IEz1h6qQXkUMFl83+ZlYjZaKW4vvKVyMAs0V5zDifiOK4TkxQWVP3Z2WIWTgMXCjmjqeMR6zOmDG+MU6Q== X-Received: from szatan.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:2d83]) (user=panikiel job=sendgmr) by 2002:a05:6902:100a:b0:dc6:c94e:fb85 with SMTP id w10-20020a056902100a00b00dc6c94efb85mr72164ybt.2.1712326532310; Fri, 05 Apr 2024 07:15:32 -0700 (PDT) Date: Fri, 5 Apr 2024 14:14:10 +0000 In-Reply-To: <20240405141411.1807189-1-panikiel@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240405141411.1807189-1-panikiel@google.com> X-Mailer: git-send-email 2.44.0.478.gd926399ef9-goog Message-ID: <20240405141411.1807189-16-panikiel@google.com> Subject: [PATCH 15/16] media: tegra-video: Use pad variant of dv timing subdev calls From: "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" To: kieran.bingham@ideasonboard.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, tharvey@gateworks.com, niklas.soderlund@ragnatech.se, prabhakar.csengg@gmail.com, charles-antoine.couret@nexvision.fr, thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com, luca.ceresoli@bootlin.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chromeos-krk-upstreaming@google.com, "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the pad variant for all (s|g|query)_dv_timings subdev calls, which includes a pad argument. Signed-off-by: Pawe=C5=82 Anikiel --- drivers/staging/media/tegra-video/vi.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media= /tegra-video/vi.c index af6e3a0d8df4..57a856a21e90 100644 --- a/drivers/staging/media/tegra-video/vi.c +++ b/drivers/staging/media/tegra-video/vi.c @@ -719,11 +719,11 @@ static int tegra_channel_g_dv_timings(struct file *fi= le, void *fh, struct v4l2_subdev *subdev; =20 subdev =3D tegra_channel_get_remote_source_subdev(chan); - if (!v4l2_subdev_has_op(subdev, video, g_dv_timings)) + if (!v4l2_subdev_has_op(subdev, pad, g_dv_timings)) return -ENOTTY; =20 return v4l2_device_call_until_err(chan->video.v4l2_dev, 0, - video, g_dv_timings, timings); + pad, g_dv_timings, 0, timings); } =20 static int tegra_channel_s_dv_timings(struct file *file, void *fh, @@ -736,7 +736,7 @@ static int tegra_channel_s_dv_timings(struct file *file= , void *fh, int ret; =20 subdev =3D tegra_channel_get_remote_source_subdev(chan); - if (!v4l2_subdev_has_op(subdev, video, s_dv_timings)) + if (!v4l2_subdev_has_op(subdev, pad, s_dv_timings)) return -ENOTTY; =20 ret =3D tegra_channel_g_dv_timings(file, fh, &curr_timings); @@ -750,7 +750,7 @@ static int tegra_channel_s_dv_timings(struct file *file= , void *fh, return -EBUSY; =20 ret =3D v4l2_device_call_until_err(chan->video.v4l2_dev, 0, - video, s_dv_timings, timings); + pad, s_dv_timings, 0, timings); if (ret) return ret; =20 @@ -771,11 +771,11 @@ static int tegra_channel_query_dv_timings(struct file= *file, void *fh, struct v4l2_subdev *subdev; =20 subdev =3D tegra_channel_get_remote_source_subdev(chan); - if (!v4l2_subdev_has_op(subdev, video, query_dv_timings)) + if (!v4l2_subdev_has_op(subdev, pad, query_dv_timings)) return -ENOTTY; =20 return v4l2_device_call_until_err(chan->video.v4l2_dev, 0, - video, query_dv_timings, timings); + pad, query_dv_timings, 0, timings); } =20 static int tegra_channel_enum_dv_timings(struct file *file, void *fh, --=20 2.44.0.478.gd926399ef9-goog From nobody Sun Feb 8 06:04:22 2026 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BC8416F0D3 for ; Fri, 5 Apr 2024 14:15:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326536; cv=none; b=Wk66UdIAhbSvGF27wLpXC4vmbI4CrHmpwRhdknh5aua/zT1iT709bpgawSkvDmutQkXwnR6RREzvFys7Huf1Jz6XIoaaWU6Dd+EP50Kk7kGU2pUhasYT4Onq6RFchr9sq3VeGLfIVdMkr53eowI+NFHmLPh3AEEjpImf8t/UIEU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712326536; c=relaxed/simple; bh=i4Tr+nVq+Xi4RO9+q//9cew+LkXLU25d9j5EEYLNZ0w=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=XmoTCjvLThMe/PtUpUgOgw9PnlzDXwWNZQ8cp9/Q20SyleQRFZRr/EDxSenNT+cUfPQMaeZ+P32MaDBsTEZ2UcOrpg0eIQyVSfK+LhLuN++G0qwpnuhWyxT3i1FFXGF0awaRNs5Y+mJq20eH/CTmJfv0CeVwnXLLjmvkT2AwjB4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=yCIY2Y5r; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--panikiel.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="yCIY2Y5r" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-60a61b31993so36780037b3.1 for ; Fri, 05 Apr 2024 07:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712326534; x=1712931334; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=zsDOfX+3b1RUaLhcJa3oIsCx6Cf2GznngtDV1SnNmvI=; b=yCIY2Y5r52Kg6SeycmYxCmlYo5begxTNog5Kx0TJ9ixkHE7TKjqSHA6Ykf72dzaucG fYUsOsB7xI2/Lp8dPDQxyitXD+hKdadvHKdreDk03wTWvegycvnnQjysvhOYd+GmNsJM V9INDvqTjD6zRrL1UW3oVrRwAyVStaq89EU2rLASAn4InIOBcK9XUKm64D7zObIAPVT7 +KDf2U0j1fJXvQZ9EI4wj4PkXVmfYySLWw921dCyKovkc0JlgyxyAMVugJreVfC8K6+J 41LVyunD7aJBqE0+iKbMHbJOz3IsO3XgHc8nHPNZUCuxYx74dTJV0yRqaiYug50wnzoc 13Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712326534; x=1712931334; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=zsDOfX+3b1RUaLhcJa3oIsCx6Cf2GznngtDV1SnNmvI=; b=dZxE7JgrwutEmjkX0ffme9uj+EH4icf8+tHf9e78K+59FJT6MPhKkyEdwJA29IGBv8 JMQ4aZT7Nnj3FPJ/cyjRRclTFG7gaCP43EOB04eFLpqaB24q3OTiBZeXFG0//cdN5SOO vke9NIJ8uc3WlztbaRchzUW6GlywVycbzsKdtJhcZfjfeE87I4sINPbGoAOrUDcaQJPw QAlG3thNARnR/Lg3ubHYQ10CjLC7TU66xxH3Gn2VaYkupwk3ZB5AOGdZSytTigvO2rbe 2la1EzZg76e6ahpf6KFUFA8PW2Uu1jdQqsBMiTrIwV9gT0CqUJIb9HdJYFoLIKSntz3n o8Iw== X-Forwarded-Encrypted: i=1; AJvYcCXIIJCTnQtvH8AecAKR9A+ynbthBjSTx8WjF9tRSGsZBl3wL4lWZaEK+21OlziAObXgWY/QJXw6mwrnTzwT4Y5wwzbbXCV/rxcmNIJe X-Gm-Message-State: AOJu0YzrImmr0kxumqx4yoLiP+jsARWHaLBJVmz8Bav8dXYZHptENgC9 JwA6c0zdKuWUkRZNHSbsBiJnMHmIPMeYtgCjwEyELc/SlfamFDWSnL9W1qeenHuNldoc+jGsWax oX68Cbi/uoA== X-Google-Smtp-Source: AGHT+IEazU1D3+af0NVMWywuHy/ujQAr1fDtXw2VNn2XTE2hgtIiqfvfx0Pk6JxWWw8zhjW8vAbmO2PrbYxeKw== X-Received: from szatan.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:2d83]) (user=panikiel job=sendgmr) by 2002:a81:6c92:0:b0:617:cb4f:a5df with SMTP id h140-20020a816c92000000b00617cb4fa5dfmr370403ywc.3.1712326534377; Fri, 05 Apr 2024 07:15:34 -0700 (PDT) Date: Fri, 5 Apr 2024 14:14:11 +0000 In-Reply-To: <20240405141411.1807189-1-panikiel@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240405141411.1807189-1-panikiel@google.com> X-Mailer: git-send-email 2.44.0.478.gd926399ef9-goog Message-ID: <20240405141411.1807189-17-panikiel@google.com> Subject: [PATCH 16/16] media: v4l2-subdev: Remove non-pad dv timing callbacks From: "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" To: kieran.bingham@ideasonboard.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, tharvey@gateworks.com, niklas.soderlund@ragnatech.se, prabhakar.csengg@gmail.com, charles-antoine.couret@nexvision.fr, thierry.reding@gmail.com, jonathanh@nvidia.com, skomatineni@nvidia.com, luca.ceresoli@bootlin.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chromeos-krk-upstreaming@google.com, "=?UTF-8?q?Pawe=C5=82=20Anikiel?=" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" After the conversion of dv timing calls to use a pad argument is done, remove the old callbacks. Update the subdev ioctl handlers to use the new callbacks. Signed-off-by: Pawe=C5=82 Anikiel --- drivers/media/v4l2-core/v4l2-subdev.c | 6 +++--- include/media/v4l2-subdev.h | 14 -------------- 2 files changed, 3 insertions(+), 17 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-cor= e/v4l2-subdev.c index 07759cdd0844..6572667fd5c4 100644 --- a/drivers/media/v4l2-core/v4l2-subdev.c +++ b/drivers/media/v4l2-core/v4l2-subdev.c @@ -906,16 +906,16 @@ static long subdev_do_ioctl(struct file *file, unsign= ed int cmd, void *arg, } =20 case VIDIOC_SUBDEV_QUERY_DV_TIMINGS: - return v4l2_subdev_call(sd, video, query_dv_timings, arg); + return v4l2_subdev_call(sd, pad, query_dv_timings, 0, arg); =20 case VIDIOC_SUBDEV_G_DV_TIMINGS: - return v4l2_subdev_call(sd, video, g_dv_timings, arg); + return v4l2_subdev_call(sd, pad, g_dv_timings, 0, arg); =20 case VIDIOC_SUBDEV_S_DV_TIMINGS: if (ro_subdev) return -EPERM; =20 - return v4l2_subdev_call(sd, video, s_dv_timings, arg); + return v4l2_subdev_call(sd, pad, s_dv_timings, 0, arg); =20 case VIDIOC_SUBDEV_G_STD: return v4l2_subdev_call(sd, video, g_std, arg); diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h index a5213411ef2b..1af16b16f0bf 100644 --- a/include/media/v4l2-subdev.h +++ b/include/media/v4l2-subdev.h @@ -452,14 +452,6 @@ enum v4l2_subdev_pre_streamon_flags { * * @g_pixelaspect: callback to return the pixelaspect ratio. * - * @s_dv_timings: Set custom dv timings in the sub device. This is used - * when sub device is capable of setting detailed timing information - * in the hardware to generate/detect the video signal. - * - * @g_dv_timings: Get custom dv timings in the sub device. - * - * @query_dv_timings: callback for VIDIOC_QUERY_DV_TIMINGS() ioctl handler= code. - * * @s_rx_buffer: set a host allocated memory buffer for the subdev. The su= bdev * can adjust @size to a lower value and must not write more data to the * buffer starting at @data than the original value of @size. @@ -490,12 +482,6 @@ struct v4l2_subdev_video_ops { int (*g_input_status)(struct v4l2_subdev *sd, u32 *status); int (*s_stream)(struct v4l2_subdev *sd, int enable); int (*g_pixelaspect)(struct v4l2_subdev *sd, struct v4l2_fract *aspect); - int (*s_dv_timings)(struct v4l2_subdev *sd, - struct v4l2_dv_timings *timings); - int (*g_dv_timings)(struct v4l2_subdev *sd, - struct v4l2_dv_timings *timings); - int (*query_dv_timings)(struct v4l2_subdev *sd, - struct v4l2_dv_timings *timings); int (*s_rx_buffer)(struct v4l2_subdev *sd, void *buf, unsigned int *size); int (*pre_streamon)(struct v4l2_subdev *sd, u32 flags); --=20 2.44.0.478.gd926399ef9-goog