From nobody Thu Feb 12 14:45:32 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 565BD12EBE3 for ; Fri, 5 Apr 2024 07:40:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712302813; cv=none; b=CYIG8p8m514WsUBVo8LFuKDmijcfm2Gs7zHp27TTRfIacMOzOok+zUqtS1KhphoOyLvXg35/ZLVCw3c/Ho5cAK8ftcPNV4RzycGWpZGA32cC29Lob9UdvIxinHeGBsgswsdELe8+jGLsB54qRK5uQUYROVhNvUkye71QNX4HV5k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712302813; c=relaxed/simple; bh=g/WMOp/DBXdvY4p/J51T2DdQvuOBI7ftgCcNNdq/ZQg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gsCR1cv8FMaSBOPAE60K7aeKR9YRnJrD5mezh0V4uHwqdbGDlYk+zOLvEqJAz830FrxicZr6wtHqQh/zwqe+JzdjnFe9nm3hEPpCgCWqBsozMCNQgYo4qJcmL7pFeb+W7pKjH9HNgfWnjSGMosm3z7/r45jPhgmjZUuml349JE0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O6c2ioHm; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O6c2ioHm" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-343cd12630aso837628f8f.1 for ; Fri, 05 Apr 2024 00:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712302809; x=1712907609; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AwPl8LYnfW65bMF9In5HJ2vXzRSbzAQqtlyK3TQNiLw=; b=O6c2ioHmM6UHqD82oZb7itLZ1/dZkbupucM00HrIGRsXmE97pu3ymcvi/gRqRQuYzD SBTsTPCpFmujAL2z4wU6E7EmJJZ0sohJV40Qon8VXZTe20lnIzxX2fBb7q494edRtWcP Hup7x7eVQhlRgBKHkVWRYiNW00SHcHhTX40sLWwVkE9BVPtgibwfk0l2wfv3SL+fFeDF nCL4pa39IwXqHkr+uIwBJxBe0EFbDq3bY5HM5PHAMo8paZNwqS6g2OKtlvN+BpgMuLaC J0VDUn8XcDgnLSERHOHYalLs8bsc4nJNtTRXmb/i/mzz4a814bIxCvRcuZq+xEADvtMe v6pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712302809; x=1712907609; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AwPl8LYnfW65bMF9In5HJ2vXzRSbzAQqtlyK3TQNiLw=; b=t3mKUzu4EsxiZ0W9snJ+83A/wAyE0PaKQO1U4kkXLXBfN2djcFoLjhhKMS12BYaszW RLqIxq++d9zBCoPSzhyY2tkb2T0JXwDFN26l6d49FN2IYFdFwEYRlEEyLgr+qxX+ikhr PZrdo4o7RNfopg6cVZvoNGewzUlaHinbUAhMakITJttRJL3AHsiJJaB2IKxbb2kpcrW/ 5eAF/zJ32lQxrivZvJ14A+EvjLXl+LVpILlh3z0Wd1DHwrAyc7LrWnR3nlJcogGH0YdX neHB6pGW6CevyqJxhvJomlucOGGcUmllROLI4HBCxGzCUnWF0bMMjFSBqHTZWWNe7CL0 Tv1A== X-Forwarded-Encrypted: i=1; AJvYcCXYbehpqBAzTC2Z3r9I8mvSyQ5KR5i2Oo06BKBHNYZ957rYC6zKIBXkDDEYpvv2GZCII1XZJU6Vsqw9uiBEFUXY5hJYbS9+dpoZUBEm X-Gm-Message-State: AOJu0Yxt7tqLfIOfPgAA7NWvxJpbP6n13w65zsaNIOgwNQG93OAA0VR6 pBvaeMPJ6KSCs6tASo2+Kwkqkf4Tq427lhdHKn9uB0iC21L8W4Ao X-Google-Smtp-Source: AGHT+IE0sMMNCxSYmp0x3kPCLZg78NOnz9SZri+Mr58KiTRI2D6/xbzd9ED7iUBVyJbGpQkDY/NsWQ== X-Received: by 2002:adf:f345:0:b0:343:75eb:bb79 with SMTP id e5-20020adff345000000b0034375ebbb79mr490731wrp.49.1712302809544; Fri, 05 Apr 2024 00:40:09 -0700 (PDT) Received: from localhost.localdomain ([2a06:c701:737b:ef00:2bdf:f41a:ebd1:fb2c]) by smtp.gmail.com with ESMTPSA id l10-20020adfe58a000000b003434f526cb5sm1311643wrm.95.2024.04.05.00.40.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 00:40:08 -0700 (PDT) From: Shahar Avidar To: gregkh@linuxfoundation.org, hverkuil-cisco@xs4all.nl, andriy.shevchenko@linux.intel.com, robh@kernel.org, felixkimbu1@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/7] staging: pi433: Rename struct pi433_device buffer field to tx_buffer. Date: Fri, 5 Apr 2024 10:39:54 +0300 Message-Id: <20240405074000.3481217-2-ikobh7@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240405074000.3481217-1-ikobh7@gmail.com> References: <20240405074000.3481217-1-ikobh7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver holds buffers in different structs, as does the HW. Using explicit names for buffers increases readability. Signed-off-by: Shahar Avidar Reviewed-by: Dan Carpenter --- drivers/staging/pi433/pi433_if.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433= _if.c index 8c513ac62156..13b464ab7db8 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -90,7 +90,7 @@ struct pi433_device { struct task_struct *tx_task_struct; wait_queue_head_t tx_wait_queue; u8 free_in_fifo; - char buffer[MAX_MSG_SIZE]; + char tx_buffer[MAX_MSG_SIZE]; =20 /* rx related values */ struct pi433_rx_cfg rx_cfg; @@ -613,8 +613,8 @@ static int pi433_tx_thread(void *data) if (tx_cfg.enable_address_byte =3D=3D OPTION_ON) size++; =20 - /* prime buffer */ - memset(device->buffer, 0, size); + /* prime tx_buffer */ + memset(device->tx_buffer, 0, size); position =3D 0; =20 /* add length byte, if requested */ @@ -623,15 +623,15 @@ static int pi433_tx_thread(void *data) * according to spec, length byte itself must be * excluded from the length calculation */ - device->buffer[position++] =3D size - 1; + device->tx_buffer[position++] =3D size - 1; =20 /* add adr byte, if requested */ if (tx_cfg.enable_address_byte =3D=3D OPTION_ON) - device->buffer[position++] =3D tx_cfg.address_byte; + device->tx_buffer[position++] =3D tx_cfg.address_byte; =20 /* finally get message data from fifo */ - retval =3D kfifo_out(&device->tx_fifo, &device->buffer[position], - sizeof(device->buffer) - position); + retval =3D kfifo_out(&device->tx_fifo, &device->tx_buffer[position], + sizeof(device->tx_buffer) - position); dev_dbg(device->dev, "read %d message byte(s) from fifo queue.\n", retval); =20 @@ -715,7 +715,7 @@ static int pi433_tx_thread(void *data) =20 device->free_in_fifo =3D 0; rf69_write_fifo(spi, - &device->buffer[position], + &device->tx_buffer[position], write_size); position +=3D write_size; } else { @@ -723,7 +723,7 @@ static int pi433_tx_thread(void *data) device->free_in_fifo -=3D size; repetitions--; rf69_write_fifo(spi, - &device->buffer[position], + &device->tx_buffer[position], (size - position)); position =3D 0; /* reset for next repetition */ } --=20 2.34.1 From nobody Thu Feb 12 14:45:32 2026 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F55912FF64 for ; Fri, 5 Apr 2024 07:40:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712302816; cv=none; b=sg1r/4I/oH/cfepQOKP2hnhwRT347SmAX15pvb0JNwPE4Frx2cQ2FBz9edzs3dLc8wDNsxEib3XRgotpo8U111TRgHuXIC7ZkX2VUPd71B8Ulg1G24VZPgFy7eODTmovh1MK7dYSzUQixIrquuJ4zsk+0Zw0vpzWKMIU299JJLU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712302816; c=relaxed/simple; bh=WfR3fzgOc+lYO6U7TgwGQD81mZqIEEtqO9tFKn6iuM4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WT3aCB3118NzlC+CPiM5N0fUhmPEYnAKLFBmjjopUYqri5rvSTX7vF2x8eS3R2YrB/wmpw9wgxPoPTF23I5+XCYUHPw7N9p+0FwXE2q6opa2JXE12sNsSkuyKspeDs9OWWqeHOdqzjNU7t423l+ULiYmax8/9M1j9tE0wzmvfGY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SAErXAND; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SAErXAND" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-34388753650so850779f8f.3 for ; Fri, 05 Apr 2024 00:40:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712302811; x=1712907611; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9LP7LwhNxKs9alceF3MwlRSStgVkDK9Wscv2B2RIGfw=; b=SAErXAND7f1RYrY2UMk72uay4ZgV2oEfrjpbwjJlZsYn80NjdnFDlI50/+rtYmR2e7 kGEU7vUO1C2AEn1vqHaK6HEyM+8ClU2dpxy1irktp4iAKBw+Xf61EkV2rlH91WUG3RtX MjNOFOJPHT1nBTfS02YASbLBmLqqK0peC6GPUZUC5ybdWlRGrArD6sq3gtag5UiX6qp8 bj7afTbje27YhPProcXtc0YKJNa+3116X2i3TW/Q0y65ifz/NoId4Y030NBv8uqS9zsK 6mz96K8WAQHPykx4y3iFMfD7xq7IHNrsrheYOZbFVDVoiGoPOkEQ51uSBg/bXSOxs3hn b/ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712302811; x=1712907611; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9LP7LwhNxKs9alceF3MwlRSStgVkDK9Wscv2B2RIGfw=; b=gtfCde3hR8K5WES+hrGuFGcpbMYe5CsjChbZFfl3s5kKiVfY8t1GRGcHXomBJqyFGc Cwxuwgj8GT9LRPzxOD6JHG1RZc/fX6FB8JhHF/84CqXmi7iaAwoshvgfiQrrUq7vmQ3E +CJzgKqfJbKqdiM89XPp4L/82eLBurOTZmRaniVz6+fDqVkwaRwRHSxBy9xrZQI7qvz8 QETuvMrgfnamOd+pYQennLhEgYd0G9TGP+evS6Xb3X/51VjQFOalUFaKcz06frpCq3Vz qhsN67+QOk683Sn48D6R8NexxplDqRTPcAmvBb27vvJmrvF9b1zowkz8M85ncCs6p45A Mjkg== X-Forwarded-Encrypted: i=1; AJvYcCWGeSwnPx1Y8Me10wGXWY9Qh31R9bJ8Q5FstHhykzl1E4yA1u/zhAG/YTnvqjYyadUA6fLy17hsbnUwc3O9oHf4EHnCl35P9SjH8kyO X-Gm-Message-State: AOJu0YyxINeYW2d9t/uf3qpO6fZC1o+3mOCOjtTmWlpY5gw+4tKo05Yw +ZAxxoga+76eCv2XZLxMfNELBSN2KG68LFb0odFsDVIUJ7KnxUdO X-Google-Smtp-Source: AGHT+IGCsPkWnNAIaosQtxn1qOWpENK8q1HyGVshaAtkMXtouAdNIqkgO9q0XAMS3tK4t7WSCof+KA== X-Received: by 2002:a05:6000:1864:b0:343:5cac:8d9e with SMTP id d4-20020a056000186400b003435cac8d9emr579813wri.33.1712302811116; Fri, 05 Apr 2024 00:40:11 -0700 (PDT) Received: from localhost.localdomain ([2a06:c701:737b:ef00:2bdf:f41a:ebd1:fb2c]) by smtp.gmail.com with ESMTPSA id l10-20020adfe58a000000b003434f526cb5sm1311643wrm.95.2024.04.05.00.40.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 00:40:10 -0700 (PDT) From: Shahar Avidar To: gregkh@linuxfoundation.org, hverkuil-cisco@xs4all.nl, andriy.shevchenko@linux.intel.com, robh@kernel.org, felixkimbu1@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/7] staging: pi433: Rename struct pi433_device instances to pi433. Date: Fri, 5 Apr 2024 10:39:55 +0300 Message-Id: <20240405074000.3481217-3-ikobh7@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240405074000.3481217-1-ikobh7@gmail.com> References: <20240405074000.3481217-1-ikobh7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Just as other devices use specific names for instantiation, struct_pi433 should also have a distinct name. Moreover, some other structs use the "dev" or "device" in their naming conventions for members, which can be confusing. Signed-off-by: Shahar Avidar Reviewed-by: Dan Carpenter --- drivers/staging/pi433/pi433_if.c | 654 +++++++++++++++---------------- 1 file changed, 327 insertions(+), 327 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433= _if.c index 13b464ab7db8..7efe6b8501e3 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -113,7 +113,7 @@ struct pi433_device { }; =20 struct pi433_instance { - struct pi433_device *device; + struct pi433_device *pi433; struct pi433_tx_cfg tx_cfg; =20 /* control flags */ @@ -125,19 +125,19 @@ struct pi433_instance { /* GPIO interrupt handlers */ static irqreturn_t DIO0_irq_handler(int irq, void *dev_id) { - struct pi433_device *device =3D dev_id; - - if (device->irq_state[DIO0] =3D=3D DIO_PACKET_SENT) { - device->free_in_fifo =3D FIFO_SIZE; - dev_dbg(device->dev, "DIO0 irq: Packet sent\n"); - wake_up_interruptible(&device->fifo_wait_queue); - } else if (device->irq_state[DIO0] =3D=3D DIO_RSSI_DIO0) { - dev_dbg(device->dev, "DIO0 irq: RSSI level over threshold\n"); - wake_up_interruptible(&device->rx_wait_queue); - } else if (device->irq_state[DIO0] =3D=3D DIO_PAYLOAD_READY) { - dev_dbg(device->dev, "DIO0 irq: Payload ready\n"); - device->free_in_fifo =3D 0; - wake_up_interruptible(&device->fifo_wait_queue); + struct pi433_device *pi433 =3D dev_id; + + if (pi433->irq_state[DIO0] =3D=3D DIO_PACKET_SENT) { + pi433->free_in_fifo =3D FIFO_SIZE; + dev_dbg(pi433->dev, "DIO0 irq: Packet sent\n"); + wake_up_interruptible(&pi433->fifo_wait_queue); + } else if (pi433->irq_state[DIO0] =3D=3D DIO_RSSI_DIO0) { + dev_dbg(pi433->dev, "DIO0 irq: RSSI level over threshold\n"); + wake_up_interruptible(&pi433->rx_wait_queue); + } else if (pi433->irq_state[DIO0] =3D=3D DIO_PAYLOAD_READY) { + dev_dbg(pi433->dev, "DIO0 irq: Payload ready\n"); + pi433->free_in_fifo =3D 0; + wake_up_interruptible(&pi433->fifo_wait_queue); } =20 return IRQ_HANDLED; @@ -145,19 +145,19 @@ static irqreturn_t DIO0_irq_handler(int irq, void *de= v_id) =20 static irqreturn_t DIO1_irq_handler(int irq, void *dev_id) { - struct pi433_device *device =3D dev_id; + struct pi433_device *pi433 =3D dev_id; =20 - if (device->irq_state[DIO1] =3D=3D DIO_FIFO_NOT_EMPTY_DIO1) { - device->free_in_fifo =3D FIFO_SIZE; - } else if (device->irq_state[DIO1] =3D=3D DIO_FIFO_LEVEL) { - if (device->rx_active) - device->free_in_fifo =3D FIFO_THRESHOLD - 1; + if (pi433->irq_state[DIO1] =3D=3D DIO_FIFO_NOT_EMPTY_DIO1) { + pi433->free_in_fifo =3D FIFO_SIZE; + } else if (pi433->irq_state[DIO1] =3D=3D DIO_FIFO_LEVEL) { + if (pi433->rx_active) + pi433->free_in_fifo =3D FIFO_THRESHOLD - 1; else - device->free_in_fifo =3D FIFO_SIZE - FIFO_THRESHOLD - 1; + pi433->free_in_fifo =3D FIFO_SIZE - FIFO_THRESHOLD - 1; } - dev_dbg(device->dev, - "DIO1 irq: %d bytes free in fifo\n", device->free_in_fifo); - wake_up_interruptible(&device->fifo_wait_queue); + dev_dbg(pi433->dev, + "DIO1 irq: %d bytes free in fifo\n", pi433->free_in_fifo); + wake_up_interruptible(&pi433->fifo_wait_queue); =20 return IRQ_HANDLED; } @@ -165,94 +165,94 @@ static irqreturn_t DIO1_irq_handler(int irq, void *de= v_id) /*------------------------------------------------------------------------= -*/ =20 static int -rf69_set_rx_cfg(struct pi433_device *dev, struct pi433_rx_cfg *rx_cfg) +rf69_set_rx_cfg(struct pi433_device *pi433, struct pi433_rx_cfg *rx_cfg) { int ret; int payload_length; =20 /* receiver config */ - ret =3D rf69_set_frequency(dev->spi, rx_cfg->frequency); + ret =3D rf69_set_frequency(pi433->spi, rx_cfg->frequency); if (ret < 0) return ret; - ret =3D rf69_set_modulation(dev->spi, rx_cfg->modulation); + ret =3D rf69_set_modulation(pi433->spi, rx_cfg->modulation); if (ret < 0) return ret; - ret =3D rf69_set_bit_rate(dev->spi, rx_cfg->bit_rate); + ret =3D rf69_set_bit_rate(pi433->spi, rx_cfg->bit_rate); if (ret < 0) return ret; - ret =3D rf69_set_antenna_impedance(dev->spi, rx_cfg->antenna_impedance); + ret =3D rf69_set_antenna_impedance(pi433->spi, rx_cfg->antenna_impedance); if (ret < 0) return ret; - ret =3D rf69_set_rssi_threshold(dev->spi, rx_cfg->rssi_threshold); + ret =3D rf69_set_rssi_threshold(pi433->spi, rx_cfg->rssi_threshold); if (ret < 0) return ret; - ret =3D rf69_set_ook_threshold_dec(dev->spi, rx_cfg->threshold_decrement); + ret =3D rf69_set_ook_threshold_dec(pi433->spi, rx_cfg->threshold_decremen= t); if (ret < 0) return ret; - ret =3D rf69_set_bandwidth(dev->spi, rx_cfg->bw_mantisse, + ret =3D rf69_set_bandwidth(pi433->spi, rx_cfg->bw_mantisse, rx_cfg->bw_exponent); if (ret < 0) return ret; - ret =3D rf69_set_bandwidth_during_afc(dev->spi, rx_cfg->bw_mantisse, + ret =3D rf69_set_bandwidth_during_afc(pi433->spi, rx_cfg->bw_mantisse, rx_cfg->bw_exponent); if (ret < 0) return ret; - ret =3D rf69_set_dagc(dev->spi, rx_cfg->dagc); + ret =3D rf69_set_dagc(pi433->spi, rx_cfg->dagc); if (ret < 0) return ret; =20 - dev->rx_bytes_to_drop =3D rx_cfg->bytes_to_drop; + pi433->rx_bytes_to_drop =3D rx_cfg->bytes_to_drop; =20 /* packet config */ /* enable */ if (rx_cfg->enable_sync =3D=3D OPTION_ON) { - ret =3D rf69_enable_sync(dev->spi); + ret =3D rf69_enable_sync(pi433->spi); if (ret < 0) return ret; =20 - ret =3D rf69_set_fifo_fill_condition(dev->spi, + ret =3D rf69_set_fifo_fill_condition(pi433->spi, after_sync_interrupt); if (ret < 0) return ret; } else { - ret =3D rf69_disable_sync(dev->spi); + ret =3D rf69_disable_sync(pi433->spi); if (ret < 0) return ret; =20 - ret =3D rf69_set_fifo_fill_condition(dev->spi, always); + ret =3D rf69_set_fifo_fill_condition(pi433->spi, always); if (ret < 0) return ret; } if (rx_cfg->enable_length_byte =3D=3D OPTION_ON) { - ret =3D rf69_set_packet_format(dev->spi, packet_length_var); + ret =3D rf69_set_packet_format(pi433->spi, packet_length_var); if (ret < 0) return ret; } else { - ret =3D rf69_set_packet_format(dev->spi, packet_length_fix); + ret =3D rf69_set_packet_format(pi433->spi, packet_length_fix); if (ret < 0) return ret; } - ret =3D rf69_set_address_filtering(dev->spi, + ret =3D rf69_set_address_filtering(pi433->spi, rx_cfg->enable_address_filtering); if (ret < 0) return ret; =20 if (rx_cfg->enable_crc =3D=3D OPTION_ON) { - ret =3D rf69_enable_crc(dev->spi); + ret =3D rf69_enable_crc(pi433->spi); if (ret < 0) return ret; } else { - ret =3D rf69_disable_crc(dev->spi); + ret =3D rf69_disable_crc(pi433->spi); if (ret < 0) return ret; } =20 /* lengths */ - ret =3D rf69_set_sync_size(dev->spi, rx_cfg->sync_length); + ret =3D rf69_set_sync_size(pi433->spi, rx_cfg->sync_length); if (ret < 0) return ret; if (rx_cfg->enable_length_byte =3D=3D OPTION_ON) { - ret =3D rf69_set_payload_length(dev->spi, 0xff); + ret =3D rf69_set_payload_length(pi433->spi, 0xff); if (ret < 0) return ret; } else if (rx_cfg->fixed_message_length !=3D 0) { @@ -261,26 +261,26 @@ rf69_set_rx_cfg(struct pi433_device *dev, struct pi43= 3_rx_cfg *rx_cfg) payload_length++; if (rx_cfg->enable_address_filtering !=3D filtering_off) payload_length++; - ret =3D rf69_set_payload_length(dev->spi, payload_length); + ret =3D rf69_set_payload_length(pi433->spi, payload_length); if (ret < 0) return ret; } else { - ret =3D rf69_set_payload_length(dev->spi, 0); + ret =3D rf69_set_payload_length(pi433->spi, 0); if (ret < 0) return ret; } =20 /* values */ if (rx_cfg->enable_sync =3D=3D OPTION_ON) { - ret =3D rf69_set_sync_values(dev->spi, rx_cfg->sync_pattern); + ret =3D rf69_set_sync_values(pi433->spi, rx_cfg->sync_pattern); if (ret < 0) return ret; } if (rx_cfg->enable_address_filtering !=3D filtering_off) { - ret =3D rf69_set_node_address(dev->spi, rx_cfg->node_address); + ret =3D rf69_set_node_address(pi433->spi, rx_cfg->node_address); if (ret < 0) return ret; - ret =3D rf69_set_broadcast_address(dev->spi, + ret =3D rf69_set_broadcast_address(pi433->spi, rx_cfg->broadcast_address); if (ret < 0) return ret; @@ -290,76 +290,76 @@ rf69_set_rx_cfg(struct pi433_device *dev, struct pi43= 3_rx_cfg *rx_cfg) } =20 static int -rf69_set_tx_cfg(struct pi433_device *dev, struct pi433_tx_cfg *tx_cfg) +rf69_set_tx_cfg(struct pi433_device *pi433, struct pi433_tx_cfg *tx_cfg) { int ret; =20 - ret =3D rf69_set_frequency(dev->spi, tx_cfg->frequency); + ret =3D rf69_set_frequency(pi433->spi, tx_cfg->frequency); if (ret < 0) return ret; - ret =3D rf69_set_modulation(dev->spi, tx_cfg->modulation); + ret =3D rf69_set_modulation(pi433->spi, tx_cfg->modulation); if (ret < 0) return ret; - ret =3D rf69_set_bit_rate(dev->spi, tx_cfg->bit_rate); + ret =3D rf69_set_bit_rate(pi433->spi, tx_cfg->bit_rate); if (ret < 0) return ret; - ret =3D rf69_set_deviation(dev->spi, tx_cfg->dev_frequency); + ret =3D rf69_set_deviation(pi433->spi, tx_cfg->dev_frequency); if (ret < 0) return ret; - ret =3D rf69_set_pa_ramp(dev->spi, tx_cfg->pa_ramp); + ret =3D rf69_set_pa_ramp(pi433->spi, tx_cfg->pa_ramp); if (ret < 0) return ret; - ret =3D rf69_set_modulation_shaping(dev->spi, tx_cfg->mod_shaping); + ret =3D rf69_set_modulation_shaping(pi433->spi, tx_cfg->mod_shaping); if (ret < 0) return ret; - ret =3D rf69_set_tx_start_condition(dev->spi, tx_cfg->tx_start_condition); + ret =3D rf69_set_tx_start_condition(pi433->spi, tx_cfg->tx_start_conditio= n); if (ret < 0) return ret; =20 /* packet format enable */ if (tx_cfg->enable_preamble =3D=3D OPTION_ON) { - ret =3D rf69_set_preamble_length(dev->spi, + ret =3D rf69_set_preamble_length(pi433->spi, tx_cfg->preamble_length); if (ret < 0) return ret; } else { - ret =3D rf69_set_preamble_length(dev->spi, 0); + ret =3D rf69_set_preamble_length(pi433->spi, 0); if (ret < 0) return ret; } =20 if (tx_cfg->enable_sync =3D=3D OPTION_ON) { - ret =3D rf69_set_sync_size(dev->spi, tx_cfg->sync_length); + ret =3D rf69_set_sync_size(pi433->spi, tx_cfg->sync_length); if (ret < 0) return ret; - ret =3D rf69_set_sync_values(dev->spi, tx_cfg->sync_pattern); + ret =3D rf69_set_sync_values(pi433->spi, tx_cfg->sync_pattern); if (ret < 0) return ret; - ret =3D rf69_enable_sync(dev->spi); + ret =3D rf69_enable_sync(pi433->spi); if (ret < 0) return ret; } else { - ret =3D rf69_disable_sync(dev->spi); + ret =3D rf69_disable_sync(pi433->spi); if (ret < 0) return ret; } =20 if (tx_cfg->enable_length_byte =3D=3D OPTION_ON) { - ret =3D rf69_set_packet_format(dev->spi, packet_length_var); + ret =3D rf69_set_packet_format(pi433->spi, packet_length_var); if (ret < 0) return ret; } else { - ret =3D rf69_set_packet_format(dev->spi, packet_length_fix); + ret =3D rf69_set_packet_format(pi433->spi, packet_length_fix); if (ret < 0) return ret; } =20 if (tx_cfg->enable_crc =3D=3D OPTION_ON) { - ret =3D rf69_enable_crc(dev->spi); + ret =3D rf69_enable_crc(pi433->spi); if (ret < 0) return ret; } else { - ret =3D rf69_disable_crc(dev->spi); + ret =3D rf69_disable_crc(pi433->spi); if (ret < 0) return ret; } @@ -369,38 +369,38 @@ rf69_set_tx_cfg(struct pi433_device *dev, struct pi43= 3_tx_cfg *tx_cfg) =20 /*------------------------------------------------------------------------= -*/ =20 -static int pi433_start_rx(struct pi433_device *dev) +static int pi433_start_rx(struct pi433_device *pi433) { int retval; =20 /* return without action, if no pending read request */ - if (!dev->rx_active) + if (!pi433->rx_active) return 0; =20 /* setup for receiving */ - retval =3D rf69_set_rx_cfg(dev, &dev->rx_cfg); + retval =3D rf69_set_rx_cfg(pi433, &pi433->rx_cfg); if (retval) return retval; =20 /* setup rssi irq */ - retval =3D rf69_set_dio_mapping(dev->spi, DIO0, DIO_RSSI_DIO0); + retval =3D rf69_set_dio_mapping(pi433->spi, DIO0, DIO_RSSI_DIO0); if (retval < 0) return retval; - dev->irq_state[DIO0] =3D DIO_RSSI_DIO0; - irq_set_irq_type(dev->irq_num[DIO0], IRQ_TYPE_EDGE_RISING); + pi433->irq_state[DIO0] =3D DIO_RSSI_DIO0; + irq_set_irq_type(pi433->irq_num[DIO0], IRQ_TYPE_EDGE_RISING); =20 /* setup fifo level interrupt */ - retval =3D rf69_set_fifo_threshold(dev->spi, FIFO_SIZE - FIFO_THRESHOLD); + retval =3D rf69_set_fifo_threshold(pi433->spi, FIFO_SIZE - FIFO_THRESHOLD= ); if (retval < 0) return retval; - retval =3D rf69_set_dio_mapping(dev->spi, DIO1, DIO_FIFO_LEVEL); + retval =3D rf69_set_dio_mapping(pi433->spi, DIO1, DIO_FIFO_LEVEL); if (retval < 0) return retval; - dev->irq_state[DIO1] =3D DIO_FIFO_LEVEL; - irq_set_irq_type(dev->irq_num[DIO1], IRQ_TYPE_EDGE_RISING); + pi433->irq_state[DIO1] =3D DIO_FIFO_LEVEL; + irq_set_irq_type(pi433->irq_num[DIO1], IRQ_TYPE_EDGE_RISING); =20 /* set module to receiving mode */ - retval =3D rf69_set_mode(dev->spi, receive); + retval =3D rf69_set_mode(pi433->spi, receive); if (retval < 0) return retval; =20 @@ -411,50 +411,50 @@ static int pi433_start_rx(struct pi433_device *dev) =20 static int pi433_receive(void *data) { - struct pi433_device *dev =3D data; - struct spi_device *spi =3D dev->spi; + struct pi433_device *pi433 =3D data; + struct spi_device *spi =3D pi433->spi; int bytes_to_read, bytes_total; int retval; =20 - dev->interrupt_rx_allowed =3D false; + pi433->interrupt_rx_allowed =3D false; =20 /* wait for any tx to finish */ - dev_dbg(dev->dev, "rx: going to wait for any tx to finish\n"); - retval =3D wait_event_interruptible(dev->rx_wait_queue, !dev->tx_active); + dev_dbg(pi433->dev, "rx: going to wait for any tx to finish\n"); + retval =3D wait_event_interruptible(pi433->rx_wait_queue, !pi433->tx_acti= ve); if (retval) { /* wait was interrupted */ - dev->interrupt_rx_allowed =3D true; - wake_up_interruptible(&dev->tx_wait_queue); + pi433->interrupt_rx_allowed =3D true; + wake_up_interruptible(&pi433->tx_wait_queue); return retval; } =20 /* prepare status vars */ - dev->free_in_fifo =3D FIFO_SIZE; - dev->rx_position =3D 0; - dev->rx_bytes_dropped =3D 0; + pi433->free_in_fifo =3D FIFO_SIZE; + pi433->rx_position =3D 0; + pi433->rx_bytes_dropped =3D 0; =20 /* setup radio module to listen for something "in the air" */ - retval =3D pi433_start_rx(dev); + retval =3D pi433_start_rx(pi433); if (retval) return retval; =20 /* now check RSSI, if low wait for getting high (RSSI interrupt) */ while (!(rf69_read_reg(spi, REG_IRQFLAGS1) & MASK_IRQFLAGS1_RSSI)) { /* allow tx to interrupt us while waiting for high RSSI */ - dev->interrupt_rx_allowed =3D true; - wake_up_interruptible(&dev->tx_wait_queue); + pi433->interrupt_rx_allowed =3D true; + wake_up_interruptible(&pi433->tx_wait_queue); =20 /* wait for RSSI level to become high */ - dev_dbg(dev->dev, "rx: going to wait for high RSSI level\n"); - retval =3D wait_event_interruptible(dev->rx_wait_queue, + dev_dbg(pi433->dev, "rx: going to wait for high RSSI level\n"); + retval =3D wait_event_interruptible(pi433->rx_wait_queue, rf69_read_reg(spi, REG_IRQFLAGS1) & MASK_IRQFLAGS1_RSSI); if (retval) /* wait was interrupted */ goto abort; - dev->interrupt_rx_allowed =3D false; + pi433->interrupt_rx_allowed =3D false; =20 /* cross check for ongoing tx */ - if (!dev->tx_active) + if (!pi433->tx_active) break; } =20 @@ -462,97 +462,97 @@ static int pi433_receive(void *data) retval =3D rf69_set_dio_mapping(spi, DIO0, DIO_PAYLOAD_READY); if (retval < 0) goto abort; - dev->irq_state[DIO0] =3D DIO_PAYLOAD_READY; - irq_set_irq_type(dev->irq_num[DIO0], IRQ_TYPE_EDGE_RISING); + pi433->irq_state[DIO0] =3D DIO_PAYLOAD_READY; + irq_set_irq_type(pi433->irq_num[DIO0], IRQ_TYPE_EDGE_RISING); =20 /* fixed or unlimited length? */ - if (dev->rx_cfg.fixed_message_length !=3D 0) { - if (dev->rx_cfg.fixed_message_length > dev->rx_buffer_size) { + if (pi433->rx_cfg.fixed_message_length !=3D 0) { + if (pi433->rx_cfg.fixed_message_length > pi433->rx_buffer_size) { retval =3D -1; goto abort; } - bytes_total =3D dev->rx_cfg.fixed_message_length; - dev_dbg(dev->dev, "rx: msg len set to %d by fixed length\n", + bytes_total =3D pi433->rx_cfg.fixed_message_length; + dev_dbg(pi433->dev, "rx: msg len set to %d by fixed length\n", bytes_total); } else { - bytes_total =3D dev->rx_buffer_size; - dev_dbg(dev->dev, "rx: msg len set to %d as requested by read\n", + bytes_total =3D pi433->rx_buffer_size; + dev_dbg(pi433->dev, "rx: msg len set to %d as requested by read\n", bytes_total); } =20 /* length byte enabled? */ - if (dev->rx_cfg.enable_length_byte =3D=3D OPTION_ON) { - retval =3D wait_event_interruptible(dev->fifo_wait_queue, - dev->free_in_fifo < FIFO_SIZE); + if (pi433->rx_cfg.enable_length_byte =3D=3D OPTION_ON) { + retval =3D wait_event_interruptible(pi433->fifo_wait_queue, + pi433->free_in_fifo < FIFO_SIZE); if (retval) /* wait was interrupted */ goto abort; =20 rf69_read_fifo(spi, (u8 *)&bytes_total, 1); - if (bytes_total > dev->rx_buffer_size) { + if (bytes_total > pi433->rx_buffer_size) { retval =3D -1; goto abort; } - dev->free_in_fifo++; - dev_dbg(dev->dev, "rx: msg len reset to %d due to length byte\n", + pi433->free_in_fifo++; + dev_dbg(pi433->dev, "rx: msg len reset to %d due to length byte\n", bytes_total); } =20 /* address byte enabled? */ - if (dev->rx_cfg.enable_address_filtering !=3D filtering_off) { + if (pi433->rx_cfg.enable_address_filtering !=3D filtering_off) { u8 dummy; =20 bytes_total--; =20 - retval =3D wait_event_interruptible(dev->fifo_wait_queue, - dev->free_in_fifo < FIFO_SIZE); + retval =3D wait_event_interruptible(pi433->fifo_wait_queue, + pi433->free_in_fifo < FIFO_SIZE); if (retval) /* wait was interrupted */ goto abort; =20 rf69_read_fifo(spi, &dummy, 1); - dev->free_in_fifo++; - dev_dbg(dev->dev, "rx: address byte stripped off\n"); + pi433->free_in_fifo++; + dev_dbg(pi433->dev, "rx: address byte stripped off\n"); } =20 /* get payload */ - while (dev->rx_position < bytes_total) { + while (pi433->rx_position < bytes_total) { if (!(rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_PAYLOAD_READY))= { - retval =3D wait_event_interruptible(dev->fifo_wait_queue, - dev->free_in_fifo < FIFO_SIZE); + retval =3D wait_event_interruptible(pi433->fifo_wait_queue, + pi433->free_in_fifo < FIFO_SIZE); if (retval) /* wait was interrupted */ goto abort; } =20 /* need to drop bytes or acquire? */ - if (dev->rx_bytes_to_drop > dev->rx_bytes_dropped) - bytes_to_read =3D dev->rx_bytes_to_drop - - dev->rx_bytes_dropped; + if (pi433->rx_bytes_to_drop > pi433->rx_bytes_dropped) + bytes_to_read =3D pi433->rx_bytes_to_drop - + pi433->rx_bytes_dropped; else - bytes_to_read =3D bytes_total - dev->rx_position; + bytes_to_read =3D bytes_total - pi433->rx_position; =20 /* access the fifo */ - if (bytes_to_read > FIFO_SIZE - dev->free_in_fifo) - bytes_to_read =3D FIFO_SIZE - dev->free_in_fifo; + if (bytes_to_read > FIFO_SIZE - pi433->free_in_fifo) + bytes_to_read =3D FIFO_SIZE - pi433->free_in_fifo; retval =3D rf69_read_fifo(spi, - &dev->rx_buffer[dev->rx_position], + &pi433->rx_buffer[pi433->rx_position], bytes_to_read); if (retval) /* read failed */ goto abort; =20 - dev->free_in_fifo +=3D bytes_to_read; + pi433->free_in_fifo +=3D bytes_to_read; =20 /* adjust status vars */ - if (dev->rx_bytes_to_drop > dev->rx_bytes_dropped) - dev->rx_bytes_dropped +=3D bytes_to_read; + if (pi433->rx_bytes_to_drop > pi433->rx_bytes_dropped) + pi433->rx_bytes_dropped +=3D bytes_to_read; else - dev->rx_position +=3D bytes_to_read; + pi433->rx_position +=3D bytes_to_read; } =20 /* rx done, wait was interrupted or error occurred */ abort: - dev->interrupt_rx_allowed =3D true; - if (rf69_set_mode(dev->spi, standby)) + pi433->interrupt_rx_allowed =3D true; + if (rf69_set_mode(pi433->spi, standby)) pr_err("rf69_set_mode(): radio module failed to go standby\n"); - wake_up_interruptible(&dev->tx_wait_queue); + wake_up_interruptible(&pi433->tx_wait_queue); =20 if (retval) return retval; @@ -562,8 +562,8 @@ static int pi433_receive(void *data) =20 static int pi433_tx_thread(void *data) { - struct pi433_device *device =3D data; - struct spi_device *spi =3D device->spi; + struct pi433_device *pi433 =3D data; + struct spi_device *spi =3D pi433->spi; struct pi433_tx_cfg tx_cfg; size_t size; bool rx_interrupted =3D false; @@ -572,9 +572,9 @@ static int pi433_tx_thread(void *data) =20 while (1) { /* wait for fifo to be populated or for request to terminate*/ - dev_dbg(device->dev, "thread: going to wait for new messages\n"); - wait_event_interruptible(device->tx_wait_queue, - (!kfifo_is_empty(&device->tx_fifo) || + dev_dbg(pi433->dev, "thread: going to wait for new messages\n"); + wait_event_interruptible(pi433->tx_wait_queue, + (!kfifo_is_empty(&pi433->tx_fifo) || kthread_should_stop())); if (kthread_should_stop()) return 0; @@ -585,17 +585,17 @@ static int pi433_tx_thread(void *data) * - size of message * - message */ - retval =3D kfifo_out(&device->tx_fifo, &tx_cfg, sizeof(tx_cfg)); + retval =3D kfifo_out(&pi433->tx_fifo, &tx_cfg, sizeof(tx_cfg)); if (retval !=3D sizeof(tx_cfg)) { - dev_dbg(device->dev, + dev_dbg(pi433->dev, "reading tx_cfg from fifo failed: got %d byte(s), expected %d\n", retval, (unsigned int)sizeof(tx_cfg)); continue; } =20 - retval =3D kfifo_out(&device->tx_fifo, &size, sizeof(size_t)); + retval =3D kfifo_out(&pi433->tx_fifo, &size, sizeof(size_t)); if (retval !=3D sizeof(size_t)) { - dev_dbg(device->dev, + dev_dbg(pi433->dev, "reading msg size from fifo failed: got %d, expected %d\n", retval, (unsigned int)sizeof(size_t)); continue; @@ -614,7 +614,7 @@ static int pi433_tx_thread(void *data) size++; =20 /* prime tx_buffer */ - memset(device->tx_buffer, 0, size); + memset(pi433->tx_buffer, 0, size); position =3D 0; =20 /* add length byte, if requested */ @@ -623,16 +623,16 @@ static int pi433_tx_thread(void *data) * according to spec, length byte itself must be * excluded from the length calculation */ - device->tx_buffer[position++] =3D size - 1; + pi433->tx_buffer[position++] =3D size - 1; =20 /* add adr byte, if requested */ if (tx_cfg.enable_address_byte =3D=3D OPTION_ON) - device->tx_buffer[position++] =3D tx_cfg.address_byte; + pi433->tx_buffer[position++] =3D tx_cfg.address_byte; =20 /* finally get message data from fifo */ - retval =3D kfifo_out(&device->tx_fifo, &device->tx_buffer[position], - sizeof(device->tx_buffer) - position); - dev_dbg(device->dev, + retval =3D kfifo_out(&pi433->tx_fifo, &pi433->tx_buffer[position], + sizeof(pi433->tx_buffer) - position); + dev_dbg(pi433->dev, "read %d message byte(s) from fifo queue.\n", retval); =20 /* @@ -642,23 +642,23 @@ static int pi433_tx_thread(void *data) * place otherwise we need to wait for the incoming telegram * to finish */ - wait_event_interruptible(device->tx_wait_queue, - !device->rx_active || - device->interrupt_rx_allowed); + wait_event_interruptible(pi433->tx_wait_queue, + !pi433->rx_active || + pi433->interrupt_rx_allowed); =20 /* * prevent race conditions * irq will be re-enabled after tx config is set */ - disable_irq(device->irq_num[DIO0]); - device->tx_active =3D true; + disable_irq(pi433->irq_num[DIO0]); + pi433->tx_active =3D true; =20 /* clear fifo, set fifo threshold, set payload length */ retval =3D rf69_set_mode(spi, standby); /* this clears the fifo */ if (retval < 0) goto abort; =20 - if (device->rx_active && !rx_interrupted) { + if (pi433->rx_active && !rx_interrupted) { /* * rx is currently waiting for a telegram; * we need to set the radio module to standby @@ -680,7 +680,7 @@ static int pi433_tx_thread(void *data) } =20 /* configure the rf chip */ - retval =3D rf69_set_tx_cfg(device, &tx_cfg); + retval =3D rf69_set_tx_cfg(pi433, &tx_cfg); if (retval < 0) goto abort; =20 @@ -688,16 +688,16 @@ static int pi433_tx_thread(void *data) retval =3D rf69_set_dio_mapping(spi, DIO1, DIO_FIFO_LEVEL); if (retval < 0) goto abort; - device->irq_state[DIO1] =3D DIO_FIFO_LEVEL; - irq_set_irq_type(device->irq_num[DIO1], IRQ_TYPE_EDGE_FALLING); + pi433->irq_state[DIO1] =3D DIO_FIFO_LEVEL; + irq_set_irq_type(pi433->irq_num[DIO1], IRQ_TYPE_EDGE_FALLING); =20 /* enable packet sent interrupt */ retval =3D rf69_set_dio_mapping(spi, DIO0, DIO_PACKET_SENT); if (retval < 0) goto abort; - device->irq_state[DIO0] =3D DIO_PACKET_SENT; - irq_set_irq_type(device->irq_num[DIO0], IRQ_TYPE_EDGE_RISING); - enable_irq(device->irq_num[DIO0]); /* was disabled by rx active check */ + pi433->irq_state[DIO0] =3D DIO_PACKET_SENT; + irq_set_irq_type(pi433->irq_num[DIO0], IRQ_TYPE_EDGE_RISING); + enable_irq(pi433->irq_num[DIO0]); /* was disabled by rx active check */ =20 /* enable transmission */ retval =3D rf69_set_mode(spi, transmit); @@ -705,61 +705,61 @@ static int pi433_tx_thread(void *data) goto abort; =20 /* transfer this msg (and repetitions) to chip fifo */ - device->free_in_fifo =3D FIFO_SIZE; + pi433->free_in_fifo =3D FIFO_SIZE; position =3D 0; repetitions =3D tx_cfg.repetitions; while ((repetitions > 0) && (size > position)) { - if ((size - position) > device->free_in_fifo) { + if ((size - position) > pi433->free_in_fifo) { /* msg to big for fifo - take a part */ - int write_size =3D device->free_in_fifo; + int write_size =3D pi433->free_in_fifo; =20 - device->free_in_fifo =3D 0; + pi433->free_in_fifo =3D 0; rf69_write_fifo(spi, - &device->tx_buffer[position], + &pi433->tx_buffer[position], write_size); position +=3D write_size; } else { /* msg fits into fifo - take all */ - device->free_in_fifo -=3D size; + pi433->free_in_fifo -=3D size; repetitions--; rf69_write_fifo(spi, - &device->tx_buffer[position], + &pi433->tx_buffer[position], (size - position)); position =3D 0; /* reset for next repetition */ } =20 - retval =3D wait_event_interruptible(device->fifo_wait_queue, - device->free_in_fifo > 0); + retval =3D wait_event_interruptible(pi433->fifo_wait_queue, + pi433->free_in_fifo > 0); if (retval) { - dev_dbg(device->dev, "ABORT\n"); + dev_dbg(pi433->dev, "ABORT\n"); goto abort; } } =20 /* we are done. Wait for packet to get sent */ - dev_dbg(device->dev, + dev_dbg(pi433->dev, "thread: wait for packet to get sent/fifo to be empty\n"); - wait_event_interruptible(device->fifo_wait_queue, - device->free_in_fifo =3D=3D FIFO_SIZE || + wait_event_interruptible(pi433->fifo_wait_queue, + pi433->free_in_fifo =3D=3D FIFO_SIZE || kthread_should_stop()); if (kthread_should_stop()) return 0; =20 /* STOP_TRANSMISSION */ - dev_dbg(device->dev, "thread: Packet sent. Set mode to stby.\n"); + dev_dbg(pi433->dev, "thread: Packet sent. Set mode to stby.\n"); retval =3D rf69_set_mode(spi, standby); if (retval < 0) goto abort; =20 /* everything sent? */ - if (kfifo_is_empty(&device->tx_fifo)) { + if (kfifo_is_empty(&pi433->tx_fifo)) { abort: if (rx_interrupted) { rx_interrupted =3D false; - pi433_start_rx(device); + pi433_start_rx(pi433); } - device->tx_active =3D false; - wake_up_interruptible(&device->rx_wait_queue); + pi433->tx_active =3D false; + wake_up_interruptible(&pi433->rx_wait_queue); } } } @@ -770,7 +770,7 @@ static ssize_t pi433_read(struct file *filp, char __user *buf, size_t size, loff_t *f_pos) { struct pi433_instance *instance; - struct pi433_device *device; + struct pi433_device *pi433; int bytes_received; ssize_t retval; =20 @@ -779,31 +779,31 @@ pi433_read(struct file *filp, char __user *buf, size_= t size, loff_t *f_pos) return -EMSGSIZE; =20 instance =3D filp->private_data; - device =3D instance->device; + pi433 =3D instance->pi433; =20 /* just one read request at a time */ - mutex_lock(&device->rx_lock); - if (device->rx_active) { - mutex_unlock(&device->rx_lock); + mutex_lock(&pi433->rx_lock); + if (pi433->rx_active) { + mutex_unlock(&pi433->rx_lock); return -EAGAIN; } =20 - device->rx_active =3D true; - mutex_unlock(&device->rx_lock); + pi433->rx_active =3D true; + mutex_unlock(&pi433->rx_lock); =20 /* start receiving */ /* will block until something was received*/ - device->rx_buffer_size =3D size; - bytes_received =3D pi433_receive(device); + pi433->rx_buffer_size =3D size; + bytes_received =3D pi433_receive(pi433); =20 /* release rx */ - mutex_lock(&device->rx_lock); - device->rx_active =3D false; - mutex_unlock(&device->rx_lock); + mutex_lock(&pi433->rx_lock); + pi433->rx_active =3D false; + mutex_unlock(&pi433->rx_lock); =20 /* if read was successful copy to user space*/ if (bytes_received > 0) { - retval =3D copy_to_user(buf, device->rx_buffer, bytes_received); + retval =3D copy_to_user(buf, pi433->rx_buffer, bytes_received); if (retval) return -EFAULT; } @@ -816,12 +816,12 @@ pi433_write(struct file *filp, const char __user *buf, size_t count, loff_t *f_pos) { struct pi433_instance *instance; - struct pi433_device *device; + struct pi433_device *pi433; int retval; unsigned int required, available, copied; =20 instance =3D filp->private_data; - device =3D instance->device; + pi433 =3D instance->pi433; =20 /* * check, whether internal buffer (tx thread) is big enough @@ -835,7 +835,7 @@ pi433_write(struct file *filp, const char __user *buf, * config the RF trasmitter correctly due to invalid settings */ if (!instance->tx_cfg_initialized) { - dev_notice_once(device->dev, + dev_notice_once(pi433->dev, "write: failed due to unconfigured tx_cfg (see PI433_IOC_WR_TX_CFG)\n"= ); return -EINVAL; } @@ -846,49 +846,49 @@ pi433_write(struct file *filp, const char __user *buf, * - size of message * - message */ - mutex_lock(&device->tx_fifo_lock); + mutex_lock(&pi433->tx_fifo_lock); =20 required =3D sizeof(instance->tx_cfg) + sizeof(size_t) + count; - available =3D kfifo_avail(&device->tx_fifo); + available =3D kfifo_avail(&pi433->tx_fifo); if (required > available) { - dev_dbg(device->dev, "write to fifo failed: %d bytes required but %d ava= ilable\n", + dev_dbg(pi433->dev, "write to fifo failed: %d bytes required but %d avai= lable\n", required, available); - mutex_unlock(&device->tx_fifo_lock); + mutex_unlock(&pi433->tx_fifo_lock); return -EAGAIN; } =20 - retval =3D kfifo_in(&device->tx_fifo, &instance->tx_cfg, + retval =3D kfifo_in(&pi433->tx_fifo, &instance->tx_cfg, sizeof(instance->tx_cfg)); if (retval !=3D sizeof(instance->tx_cfg)) goto abort; =20 - retval =3D kfifo_in(&device->tx_fifo, &count, sizeof(size_t)); + retval =3D kfifo_in(&pi433->tx_fifo, &count, sizeof(size_t)); if (retval !=3D sizeof(size_t)) goto abort; =20 - retval =3D kfifo_from_user(&device->tx_fifo, buf, count, &copied); + retval =3D kfifo_from_user(&pi433->tx_fifo, buf, count, &copied); if (retval || copied !=3D count) goto abort; =20 - mutex_unlock(&device->tx_fifo_lock); + mutex_unlock(&pi433->tx_fifo_lock); =20 /* start transfer */ - wake_up_interruptible(&device->tx_wait_queue); - dev_dbg(device->dev, "write: generated new msg with %d bytes.\n", copied); + wake_up_interruptible(&pi433->tx_wait_queue); + dev_dbg(pi433->dev, "write: generated new msg with %d bytes.\n", copied); =20 return copied; =20 abort: - dev_warn(device->dev, + dev_warn(pi433->dev, "write to fifo failed, non recoverable: 0x%x\n", retval); - mutex_unlock(&device->tx_fifo_lock); + mutex_unlock(&pi433->tx_fifo_lock); return -EAGAIN; } =20 static long pi433_ioctl(struct file *filp, unsigned int cmd, unsigned long= arg) { struct pi433_instance *instance; - struct pi433_device *device; + struct pi433_device *pi433; struct pi433_tx_cfg tx_cfg; void __user *argp =3D (void __user *)arg; =20 @@ -897,9 +897,9 @@ static long pi433_ioctl(struct file *filp, unsigned int= cmd, unsigned long arg) return -ENOTTY; =20 instance =3D filp->private_data; - device =3D instance->device; + pi433 =3D instance->pi433; =20 - if (!device) + if (!pi433) return -ESHUTDOWN; =20 switch (cmd) { @@ -911,32 +911,32 @@ static long pi433_ioctl(struct file *filp, unsigned i= nt cmd, unsigned long arg) case PI433_IOC_WR_TX_CFG: if (copy_from_user(&tx_cfg, argp, sizeof(struct pi433_tx_cfg))) return -EFAULT; - mutex_lock(&device->tx_fifo_lock); + mutex_lock(&pi433->tx_fifo_lock); memcpy(&instance->tx_cfg, &tx_cfg, sizeof(struct pi433_tx_cfg)); instance->tx_cfg_initialized =3D true; - mutex_unlock(&device->tx_fifo_lock); + mutex_unlock(&pi433->tx_fifo_lock); break; case PI433_IOC_RD_RX_CFG: - if (copy_to_user(argp, &device->rx_cfg, + if (copy_to_user(argp, &pi433->rx_cfg, sizeof(struct pi433_rx_cfg))) return -EFAULT; break; case PI433_IOC_WR_RX_CFG: - mutex_lock(&device->rx_lock); + mutex_lock(&pi433->rx_lock); =20 /* during pending read request, change of config not allowed */ - if (device->rx_active) { - mutex_unlock(&device->rx_lock); + if (pi433->rx_active) { + mutex_unlock(&pi433->rx_lock); return -EAGAIN; } =20 - if (copy_from_user(&device->rx_cfg, argp, + if (copy_from_user(&pi433->rx_cfg, argp, sizeof(struct pi433_rx_cfg))) { - mutex_unlock(&device->rx_lock); + mutex_unlock(&pi433->rx_lock); return -EFAULT; } =20 - mutex_unlock(&device->rx_lock); + mutex_unlock(&pi433->rx_lock); break; default: return -EINVAL; @@ -949,13 +949,13 @@ static long pi433_ioctl(struct file *filp, unsigned i= nt cmd, unsigned long arg) =20 static int pi433_open(struct inode *inode, struct file *filp) { - struct pi433_device *device; + struct pi433_device *pi433; struct pi433_instance *instance; =20 mutex_lock(&minor_lock); - device =3D idr_find(&pi433_idr, iminor(inode)); + pi433 =3D idr_find(&pi433_idr, iminor(inode)); mutex_unlock(&minor_lock); - if (!device) { + if (!pi433) { pr_debug("device: minor %d unknown.\n", iminor(inode)); return -ENODEV; } @@ -965,7 +965,7 @@ static int pi433_open(struct inode *inode, struct file = *filp) return -ENOMEM; =20 /* setup instance data*/ - instance->device =3D device; + instance->pi433 =3D pi433; =20 /* instance data as context */ filp->private_data =3D instance; @@ -987,7 +987,7 @@ static int pi433_release(struct inode *inode, struct fi= le *filp) =20 /*------------------------------------------------------------------------= -*/ =20 -static int setup_gpio(struct pi433_device *device) +static int setup_gpio(struct pi433_device *pi433) { char name[5]; int retval; @@ -1000,89 +1000,89 @@ static int setup_gpio(struct pi433_device *device) for (i =3D 0; i < NUM_DIO; i++) { /* "construct" name and get the gpio descriptor */ snprintf(name, sizeof(name), "DIO%d", i); - device->gpiod[i] =3D gpiod_get(&device->spi->dev, name, - 0 /*GPIOD_IN*/); + pi433->gpiod[i] =3D gpiod_get(&pi433->spi->dev, name, + 0 /*GPIOD_IN*/); =20 - if (device->gpiod[i] =3D=3D ERR_PTR(-ENOENT)) { - dev_dbg(&device->spi->dev, + if (pi433->gpiod[i] =3D=3D ERR_PTR(-ENOENT)) { + dev_dbg(&pi433->spi->dev, "Could not find entry for %s. Ignoring.\n", name); continue; } =20 - if (device->gpiod[i] =3D=3D ERR_PTR(-EBUSY)) - dev_dbg(&device->spi->dev, "%s is busy.\n", name); + if (pi433->gpiod[i] =3D=3D ERR_PTR(-EBUSY)) + dev_dbg(&pi433->spi->dev, "%s is busy.\n", name); =20 - if (IS_ERR(device->gpiod[i])) { - retval =3D PTR_ERR(device->gpiod[i]); + if (IS_ERR(pi433->gpiod[i])) { + retval =3D PTR_ERR(pi433->gpiod[i]); /* release already allocated gpios */ for (i--; i >=3D 0; i--) { - free_irq(device->irq_num[i], device); - gpiod_put(device->gpiod[i]); + free_irq(pi433->irq_num[i], pi433); + gpiod_put(pi433->gpiod[i]); } return retval; } =20 /* configure the pin */ - retval =3D gpiod_direction_input(device->gpiod[i]); + retval =3D gpiod_direction_input(pi433->gpiod[i]); if (retval) return retval; =20 /* configure irq */ - device->irq_num[i] =3D gpiod_to_irq(device->gpiod[i]); - if (device->irq_num[i] < 0) { - device->gpiod[i] =3D ERR_PTR(-EINVAL); - return device->irq_num[i]; + pi433->irq_num[i] =3D gpiod_to_irq(pi433->gpiod[i]); + if (pi433->irq_num[i] < 0) { + pi433->gpiod[i] =3D ERR_PTR(-EINVAL); + return pi433->irq_num[i]; } - retval =3D request_irq(device->irq_num[i], + retval =3D request_irq(pi433->irq_num[i], DIO_irq_handler[i], 0, /* flags */ name, - device); + pi433); =20 if (retval) return retval; =20 - dev_dbg(&device->spi->dev, "%s successfully configured\n", name); + dev_dbg(&pi433->spi->dev, "%s successfully configured\n", name); } =20 return 0; } =20 -static void free_gpio(struct pi433_device *device) +static void free_gpio(struct pi433_device *pi433) { int i; =20 for (i =3D 0; i < NUM_DIO; i++) { /* check if gpiod is valid */ - if (IS_ERR(device->gpiod[i])) + if (IS_ERR(pi433->gpiod[i])) continue; =20 - free_irq(device->irq_num[i], device); - gpiod_put(device->gpiod[i]); + free_irq(pi433->irq_num[i], pi433); + gpiod_put(pi433->gpiod[i]); } } =20 -static int pi433_get_minor(struct pi433_device *device) +static int pi433_get_minor(struct pi433_device *pi433) { int retval =3D -ENOMEM; =20 mutex_lock(&minor_lock); - retval =3D idr_alloc(&pi433_idr, device, 0, N_PI433_MINORS, GFP_KERNEL); + retval =3D idr_alloc(&pi433_idr, pi433, 0, N_PI433_MINORS, GFP_KERNEL); if (retval >=3D 0) { - device->minor =3D retval; + pi433->minor =3D retval; retval =3D 0; } else if (retval =3D=3D -ENOSPC) { - dev_err(&device->spi->dev, "too many pi433 devices\n"); + dev_err(&pi433->spi->dev, "too many pi433 devices\n"); retval =3D -EINVAL; } mutex_unlock(&minor_lock); return retval; } =20 -static void pi433_free_minor(struct pi433_device *dev) +static void pi433_free_minor(struct pi433_device *pi433) { mutex_lock(&minor_lock); - idr_remove(&pi433_idr, dev->minor); + idr_remove(&pi433_idr, pi433->minor); mutex_unlock(&minor_lock); } =20 @@ -1106,35 +1106,35 @@ static const struct file_operations pi433_fops =3D { =20 static int pi433_debugfs_regs_show(struct seq_file *m, void *p) { - struct pi433_device *dev; + struct pi433_device *pi433; u8 reg_data[114]; int i; char *fmt =3D "0x%02x, 0x%02x\n"; int ret; =20 - dev =3D m->private; + pi433 =3D m->private; =20 - mutex_lock(&dev->tx_fifo_lock); - mutex_lock(&dev->rx_lock); + mutex_lock(&pi433->tx_fifo_lock); + mutex_lock(&pi433->rx_lock); =20 // wait for on-going operations to finish - ret =3D wait_event_interruptible(dev->rx_wait_queue, !dev->tx_active); + ret =3D wait_event_interruptible(pi433->rx_wait_queue, !pi433->tx_active); if (ret) goto out_unlock; =20 - ret =3D wait_event_interruptible(dev->tx_wait_queue, !dev->rx_active); + ret =3D wait_event_interruptible(pi433->tx_wait_queue, !pi433->rx_active); if (ret) goto out_unlock; =20 // skip FIFO register (0x0) otherwise this can affect some of uC ops for (i =3D 1; i < 0x50; i++) - reg_data[i] =3D rf69_read_reg(dev->spi, i); + reg_data[i] =3D rf69_read_reg(pi433->spi, i); =20 - reg_data[REG_TESTLNA] =3D rf69_read_reg(dev->spi, REG_TESTLNA); - reg_data[REG_TESTPA1] =3D rf69_read_reg(dev->spi, REG_TESTPA1); - reg_data[REG_TESTPA2] =3D rf69_read_reg(dev->spi, REG_TESTPA2); - reg_data[REG_TESTDAGC] =3D rf69_read_reg(dev->spi, REG_TESTDAGC); - reg_data[REG_TESTAFC] =3D rf69_read_reg(dev->spi, REG_TESTAFC); + reg_data[REG_TESTLNA] =3D rf69_read_reg(pi433->spi, REG_TESTLNA); + reg_data[REG_TESTPA1] =3D rf69_read_reg(pi433->spi, REG_TESTPA1); + reg_data[REG_TESTPA2] =3D rf69_read_reg(pi433->spi, REG_TESTPA2); + reg_data[REG_TESTDAGC] =3D rf69_read_reg(pi433->spi, REG_TESTDAGC); + reg_data[REG_TESTAFC] =3D rf69_read_reg(pi433->spi, REG_TESTAFC); =20 seq_puts(m, "# reg, val\n"); =20 @@ -1148,8 +1148,8 @@ static int pi433_debugfs_regs_show(struct seq_file *m= , void *p) seq_printf(m, fmt, REG_TESTAFC, reg_data[REG_TESTAFC]); =20 out_unlock: - mutex_unlock(&dev->rx_lock); - mutex_unlock(&dev->tx_fifo_lock); + mutex_unlock(&pi433->rx_lock); + mutex_unlock(&pi433->tx_fifo_lock); =20 return ret; } @@ -1159,7 +1159,7 @@ DEFINE_SHOW_ATTRIBUTE(pi433_debugfs_regs); =20 static int pi433_probe(struct spi_device *spi) { - struct pi433_device *device; + struct pi433_device *pi433; int retval; struct dentry *entry; =20 @@ -1196,37 +1196,37 @@ static int pi433_probe(struct spi_device *spi) } =20 /* Allocate driver data */ - device =3D kzalloc(sizeof(*device), GFP_KERNEL); - if (!device) + pi433 =3D kzalloc(sizeof(*pi433), GFP_KERNEL); + if (!pi433) return -ENOMEM; =20 /* Initialize the driver data */ - device->spi =3D spi; - device->rx_active =3D false; - device->tx_active =3D false; - device->interrupt_rx_allowed =3D false; + pi433->spi =3D spi; + pi433->rx_active =3D false; + pi433->tx_active =3D false; + pi433->interrupt_rx_allowed =3D false; =20 /* init rx buffer */ - device->rx_buffer =3D kmalloc(MAX_MSG_SIZE, GFP_KERNEL); - if (!device->rx_buffer) { + pi433->rx_buffer =3D kmalloc(MAX_MSG_SIZE, GFP_KERNEL); + if (!pi433->rx_buffer) { retval =3D -ENOMEM; goto RX_failed; } =20 /* init wait queues */ - init_waitqueue_head(&device->tx_wait_queue); - init_waitqueue_head(&device->rx_wait_queue); - init_waitqueue_head(&device->fifo_wait_queue); + init_waitqueue_head(&pi433->tx_wait_queue); + init_waitqueue_head(&pi433->rx_wait_queue); + init_waitqueue_head(&pi433->fifo_wait_queue); =20 /* init fifo */ - INIT_KFIFO(device->tx_fifo); + INIT_KFIFO(pi433->tx_fifo); =20 /* init mutexes and locks */ - mutex_init(&device->tx_fifo_lock); - mutex_init(&device->rx_lock); + mutex_init(&pi433->tx_fifo_lock); + mutex_init(&pi433->rx_lock); =20 /* setup GPIO (including irq_handler) for the different DIOs */ - retval =3D setup_gpio(device); + retval =3D setup_gpio(pi433); if (retval) { dev_dbg(&spi->dev, "setup of GPIOs failed\n"); goto GPIO_failed; @@ -1256,105 +1256,105 @@ static int pi433_probe(struct spi_device *spi) goto minor_failed; =20 /* determ minor number */ - retval =3D pi433_get_minor(device); + retval =3D pi433_get_minor(pi433); if (retval) { dev_dbg(&spi->dev, "get of minor number failed\n"); goto minor_failed; } =20 /* create device */ - device->devt =3D MKDEV(MAJOR(pi433_dev), device->minor); - device->dev =3D device_create(&pi433_class, - &spi->dev, - device->devt, - device, - "pi433.%d", - device->minor); - if (IS_ERR(device->dev)) { + pi433->devt =3D MKDEV(MAJOR(pi433_dev), pi433->minor); + pi433->dev =3D device_create(&pi433_class, + &spi->dev, + pi433->devt, + pi433, + "pi433.%d", + pi433->minor); + if (IS_ERR(pi433->dev)) { pr_err("pi433: device register failed\n"); - retval =3D PTR_ERR(device->dev); + retval =3D PTR_ERR(pi433->dev); goto device_create_failed; } else { - dev_dbg(device->dev, + dev_dbg(pi433->dev, "created device for major %d, minor %d\n", MAJOR(pi433_dev), - device->minor); + pi433->minor); } =20 /* start tx thread */ - device->tx_task_struct =3D kthread_run(pi433_tx_thread, - device, - "pi433.%d_tx_task", - device->minor); - if (IS_ERR(device->tx_task_struct)) { - dev_dbg(device->dev, "start of send thread failed\n"); - retval =3D PTR_ERR(device->tx_task_struct); + pi433->tx_task_struct =3D kthread_run(pi433_tx_thread, + pi433, + "pi433.%d_tx_task", + pi433->minor); + if (IS_ERR(pi433->tx_task_struct)) { + dev_dbg(pi433->dev, "start of send thread failed\n"); + retval =3D PTR_ERR(pi433->tx_task_struct); goto send_thread_failed; } =20 /* create cdev */ - device->cdev =3D cdev_alloc(); - if (!device->cdev) { - dev_dbg(device->dev, "allocation of cdev failed\n"); + pi433->cdev =3D cdev_alloc(); + if (!pi433->cdev) { + dev_dbg(pi433->dev, "allocation of cdev failed\n"); retval =3D -ENOMEM; goto cdev_failed; } - device->cdev->owner =3D THIS_MODULE; - cdev_init(device->cdev, &pi433_fops); - retval =3D cdev_add(device->cdev, device->devt, 1); + pi433->cdev->owner =3D THIS_MODULE; + cdev_init(pi433->cdev, &pi433_fops); + retval =3D cdev_add(pi433->cdev, pi433->devt, 1); if (retval) { - dev_dbg(device->dev, "register of cdev failed\n"); + dev_dbg(pi433->dev, "register of cdev failed\n"); goto del_cdev; } =20 /* spi setup */ - spi_set_drvdata(spi, device); + spi_set_drvdata(spi, pi433); =20 - entry =3D debugfs_create_dir(dev_name(device->dev), root_dir); - debugfs_create_file("regs", 0400, entry, device, &pi433_debugfs_regs_fops= ); + entry =3D debugfs_create_dir(dev_name(pi433->dev), root_dir); + debugfs_create_file("regs", 0400, entry, pi433, &pi433_debugfs_regs_fops); =20 return 0; =20 del_cdev: - cdev_del(device->cdev); + cdev_del(pi433->cdev); cdev_failed: - kthread_stop(device->tx_task_struct); + kthread_stop(pi433->tx_task_struct); send_thread_failed: - device_destroy(&pi433_class, device->devt); + device_destroy(&pi433_class, pi433->devt); device_create_failed: - pi433_free_minor(device); + pi433_free_minor(pi433); minor_failed: - free_gpio(device); + free_gpio(pi433); GPIO_failed: - kfree(device->rx_buffer); + kfree(pi433->rx_buffer); RX_failed: - kfree(device); + kfree(pi433); =20 return retval; } =20 static void pi433_remove(struct spi_device *spi) { - struct pi433_device *device =3D spi_get_drvdata(spi); + struct pi433_device *pi433 =3D spi_get_drvdata(spi); =20 - debugfs_lookup_and_remove(dev_name(device->dev), root_dir); + debugfs_lookup_and_remove(dev_name(pi433->dev), root_dir); =20 /* free GPIOs */ - free_gpio(device); + free_gpio(pi433); =20 /* make sure ops on existing fds can abort cleanly */ - device->spi =3D NULL; + pi433->spi =3D NULL; =20 - kthread_stop(device->tx_task_struct); + kthread_stop(pi433->tx_task_struct); =20 - device_destroy(&pi433_class, device->devt); + device_destroy(&pi433_class, pi433->devt); =20 - cdev_del(device->cdev); + cdev_del(pi433->cdev); =20 - pi433_free_minor(device); + pi433_free_minor(pi433); =20 - kfree(device->rx_buffer); - kfree(device); + kfree(pi433->rx_buffer); + kfree(pi433); } =20 static const struct of_device_id pi433_dt_ids[] =3D { --=20 2.34.1 From nobody Thu Feb 12 14:45:32 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3AC213C818 for ; Fri, 5 Apr 2024 07:40:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712302816; cv=none; b=NKKcc8iIfX32GQF1jPyhXrbKrbX5tgr1Iki2WZp2p6hje4US3Gcl1rDTb0OMx2V96jtwjSIEJIM0z5anxLxeqpyORsZNJGJ2RQIydLB/GLAQmWohCaCzL16DNpM1e4cWw+xu1FyXPbM8HtyWiImWbzkTQeZ4CqdEH/XxVqaqJug= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712302816; c=relaxed/simple; bh=jK+AFaPuB4QJkOlQSpapYzjziTfiCfCCfo7UWLC+ajY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=se7XvGCY854zT/fXf/tomr7bFNfcfsxtnfC6zOcYcLK9Fp/Yb8hPVITrIKaS8vnqoXzU177OrywTVY1qIUqvl4rsU8Lk4f5WekHyPE6NBMND5tsrYRfM79cLGsjJv0q+IylkkAvY5ZMd0uPP8fKZSBpWLpHZs9rgLO9Mpo3V/Dk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f5pb8Frt; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f5pb8Frt" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4163181a7ceso914505e9.0 for ; Fri, 05 Apr 2024 00:40:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712302813; x=1712907613; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bF9nmGQgrbBBKoEODSqmsdf3m34vi7We9f5KYGrq5eQ=; b=f5pb8FrtNq5bN9vUR5SN3MWUBJSn6tuFJxtsiI0hvH0FmZKlScDZZsWytgRFdcKGKn b9EF2xbvcwsrkfT0CrVcFSmEZRvwWk2d5bhTVoz3nIyk6TLBznlfI0RHPK8crqx09dEZ l37LZJhqYNt4GyNeU7eWiK64FLuwDksuLHXjO7imhgfYmUfpDFFht2XwEoOX1c8Og4My nacBNPuW6Nhn1RU8un0YbMC9gUnDm7bEAqYWHC8uWpLj5lcYLsuGXE2DtqhS6ZqjemKR WDqQqaQVGrD8LsVeoV03AqlR8hovMDnc0KzDmK2zweanSBaXOY0sKSJJY8cJ77fknLrt 1S2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712302813; x=1712907613; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bF9nmGQgrbBBKoEODSqmsdf3m34vi7We9f5KYGrq5eQ=; b=sYZGsPjL0d+LWsfm9S11O1w9j6Ci+pWl+9slksNJ/uX+nEHVPSn0X3yXccIE6RZeKH 9TORmEoE5t1LJHNyixiKnXW16Gmk8sHU58BUrKiznQNMTs7IJp5rc09/NATNnPAzg+Mg 7p8mGCntQ/eMUuIZcfR1FrpaIF0awYi/v7M6PIUC3d7Yk1PwuZemSdNt/O6J1k+nx6ht 4uVKsH1EcMhq5VwIqpGSWyflyYG7DwWaz7XDoQ5yIOuUIjzw9CMtF/A5kTXzRUOzRhK4 toKS/o/3lbAMAgxCMMpotZt/Y4OfqNp9Kz8Vzptx+n6ERx/Jki/DngBzDGOefdlemwo8 TYhg== X-Forwarded-Encrypted: i=1; AJvYcCXQ7D4aOcXCVfxEGHwO4tBrR/JcqsKM+hWROEUrkAQwZLQ+rzr4Xj62Q2tEva29qew/wtg4vMwyudC4w0P+bWJNgnT7xVoWxphCJzA3 X-Gm-Message-State: AOJu0YyyyRHkH2EYxfSBIvKAWWoO0FB2W9xttdj8lr0mjGUNmbaQnJYK rrC+AlBnoork55WvUb9B0mDW3aN3/sKR3ECPOVSVG4l3ZmOQYLND X-Google-Smtp-Source: AGHT+IGA6WB5h1Vgmp1Wazyi22zgCR/Dq8OWifgDgcuzQPoRI0/Ng2ajPekvSxYAfohaQEbeAsQE9w== X-Received: by 2002:a5d:4684:0:b0:343:b252:2222 with SMTP id u4-20020a5d4684000000b00343b2522222mr472681wrq.6.1712302813154; Fri, 05 Apr 2024 00:40:13 -0700 (PDT) Received: from localhost.localdomain ([2a06:c701:737b:ef00:2bdf:f41a:ebd1:fb2c]) by smtp.gmail.com with ESMTPSA id l10-20020adfe58a000000b003434f526cb5sm1311643wrm.95.2024.04.05.00.40.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 00:40:12 -0700 (PDT) From: Shahar Avidar To: gregkh@linuxfoundation.org, hverkuil-cisco@xs4all.nl, andriy.shevchenko@linux.intel.com, robh@kernel.org, felixkimbu1@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3 3/7] staging: pi433: Replace pi433_receive param void type to struct pi433_device. Date: Fri, 5 Apr 2024 10:39:56 +0300 Message-Id: <20240405074000.3481217-4-ikobh7@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240405074000.3481217-1-ikobh7@gmail.com> References: <20240405074000.3481217-1-ikobh7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" pi433_receive is only called once. It immediately assigns the data param to a struct pi433_device. Rename param name to pi433. Signed-off-by: Shahar Avidar Reviewed-by: Dan Carpenter --- drivers/staging/pi433/pi433_if.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433= _if.c index 7efe6b8501e3..208c0c6d3649 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -409,9 +409,8 @@ static int pi433_start_rx(struct pi433_device *pi433) =20 /*------------------------------------------------------------------------= -*/ =20 -static int pi433_receive(void *data) +static int pi433_receive(struct pi433_device *pi433) { - struct pi433_device *pi433 =3D data; struct spi_device *spi =3D pi433->spi; int bytes_to_read, bytes_total; int retval; --=20 2.34.1 From nobody Thu Feb 12 14:45:32 2026 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B94A13C824 for ; Fri, 5 Apr 2024 07:40:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712302818; cv=none; b=rnm4EuwMPLjO1g+xo5qLYbm2wwZwcNQKvLT6ZawluMMIB6wzVCGCAMHhkQvVXOwBhEEuAZueqZQGKH6FX8fNwzqU3k2l3SbopFf1z3AsnG01hbWP3Nflcr/ov4Ddm2CsO1erBFZNgypno0CTzXO3+gPY2XaqTDNhIPuBsC7uPLs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712302818; c=relaxed/simple; bh=HjRvMGXjDbwDSvM16WAhK4wPegt0yyIWO/1j4Z95mjo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FBG/3HBDTFj3JTiRGUe2USO33YOhY5tcMMEIrdi2lNfEE11ry0m7nOTIijFwbpUYnbwLDS2pv+KDSw7GSMd/RK5w6Vn3mkqFVijgqsHgaMvNmS/P4NsnIalFa/tbmyS1ti9N0fgwicTJXWMJ3SKwM1epunqzt7YBLZO+IfAMufU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SdbRbhq/; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SdbRbhq/" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-34356f794a5so1561673f8f.1 for ; Fri, 05 Apr 2024 00:40:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712302814; x=1712907614; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YJrpsii5KxAd/+yN0rzfHDl19GAcoZcZzgV5GRtFABE=; b=SdbRbhq/kRtaGAEPNQjvYs2vERxUMh2dGSlRANUqcdWELhEsnJffzaArQbaqQi5826 ZlzH1krbSuut1VWlNHLS77fR2NC642Qx+1HnWdLvRsuyhcgU0MWRl47zWMLhfaBWguFt yil5JJ9DX64owGxBYnzGTatl+YsWfHtRGJsvjv0KhLAZWHKM6uukpx+jM1O+rykBQPar vu3JFQlSJ4ku/xNV+kiItaGkzrz3VKLUdGAkXoEmVDvhr5/FELDTg0uKx7DngvT7paMD mA4E/QVHOyNlklM2T1IS+feD0a+rj8IPvb8x0Lu3L6/dPa3ZYyAscEKOi+Zwce/Dp7al sYgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712302814; x=1712907614; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YJrpsii5KxAd/+yN0rzfHDl19GAcoZcZzgV5GRtFABE=; b=sdgyQIPk5s7zoQEgEdBhnvR5nR23AKz5Ir4RM9+psneCJPqwfzieAnlfJj86oodyAw mOqEceSA964tjGGbxsoU7nDtzHx9DjRKpxz3ucHCmxaBVVbs8AvC/FBFJzmIqM41Tr+p 5FLdJBk96TGhlsNvjEsyPNpgfY5NNtuCXjqvotyA/G/I0+Fdo3yFKT6htseW27kG2NQy +r/rmrwBlF6CRH4jlmg8Nfti+Ngddur8hU7GhZQO3jSCgbnuTVhbOhTMYqukaNnX8CdM Z38ukd944+iYFEQpD/sXSKJPRe+hP9laG2/frPiHBSw4zW2JQjbS8WP2uSAQHjtI7uGz B6tQ== X-Forwarded-Encrypted: i=1; AJvYcCWs9jWRFRzN/VpQd6GeKue8k6PLddQQtIA+QLfKERGGaqxOcDTpcZlBrsXO6RzvVuV354S5BVLwzYREMNO0amPssKBkbLROFDnQ73Hk X-Gm-Message-State: AOJu0YxzmCBd4ZG7O6bDi9RyNxXiH5tFG377VWfdwTHOxQY6UXXhNZCO sM1UPKrQR1vPb5Z2WIVCcnylw0/AemdZQmr3Lx/7GGoHcof0SZhP X-Google-Smtp-Source: AGHT+IEaEi2jQPgVCrw/T+VlZ/QJsDFrDO0tljJfL2LpyogJgEVc50Wraut/Somejqvdw6J/VSQQMw== X-Received: by 2002:adf:fd91:0:b0:343:a8cb:7990 with SMTP id d17-20020adffd91000000b00343a8cb7990mr616644wrr.29.1712302814528; Fri, 05 Apr 2024 00:40:14 -0700 (PDT) Received: from localhost.localdomain ([2a06:c701:737b:ef00:2bdf:f41a:ebd1:fb2c]) by smtp.gmail.com with ESMTPSA id l10-20020adfe58a000000b003434f526cb5sm1311643wrm.95.2024.04.05.00.40.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 00:40:14 -0700 (PDT) From: Shahar Avidar To: gregkh@linuxfoundation.org, hverkuil-cisco@xs4all.nl, andriy.shevchenko@linux.intel.com, robh@kernel.org, felixkimbu1@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3 4/7] staging: pi433: Rename "pi433_dev" of type "dev_t" to "pi433_devt" Date: Fri, 5 Apr 2024 10:39:57 +0300 Message-Id: <20240405074000.3481217-5-ikobh7@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240405074000.3481217-1-ikobh7@gmail.com> References: <20240405074000.3481217-1-ikobh7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Distinguish struct device type instances from dev_t instances to enhance readability. Signed-off-by: Shahar Avidar Reviewed-by: Dan Carpenter --- drivers/staging/pi433/pi433_if.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433= _if.c index 208c0c6d3649..62ce75b07bf0 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -53,7 +53,7 @@ #define FIFO_THRESHOLD 15 /* bytes */ #define NUM_DIO 2 =20 -static dev_t pi433_dev; +static dev_t pi433_devt; static DEFINE_IDR(pi433_idr); static DEFINE_MUTEX(minor_lock); /* Protect idr accesses */ static struct dentry *root_dir; /* debugfs root directory for the driver */ @@ -1262,7 +1262,7 @@ static int pi433_probe(struct spi_device *spi) } =20 /* create device */ - pi433->devt =3D MKDEV(MAJOR(pi433_dev), pi433->minor); + pi433->devt =3D MKDEV(MAJOR(pi433_devt), pi433->minor); pi433->dev =3D device_create(&pi433_class, &spi->dev, pi433->devt, @@ -1276,7 +1276,7 @@ static int pi433_probe(struct spi_device *spi) } else { dev_dbg(pi433->dev, "created device for major %d, minor %d\n", - MAJOR(pi433_dev), + MAJOR(pi433_devt), pi433->minor); } =20 @@ -1398,13 +1398,13 @@ static int __init pi433_init(void) * that will key udev/mdev to add/remove /dev nodes. * Last, register the driver which manages those device numbers. */ - status =3D alloc_chrdev_region(&pi433_dev, 0, N_PI433_MINORS, "pi433"); + status =3D alloc_chrdev_region(&pi433_devt, 0, N_PI433_MINORS, "pi433"); if (status < 0) return status; =20 status =3D class_register(&pi433_class); if (status) { - unregister_chrdev(MAJOR(pi433_dev), + unregister_chrdev(MAJOR(pi433_devt), pi433_spi_driver.driver.name); return status; } @@ -1414,7 +1414,7 @@ static int __init pi433_init(void) status =3D spi_register_driver(&pi433_spi_driver); if (status < 0) { class_unregister(&pi433_class); - unregister_chrdev(MAJOR(pi433_dev), + unregister_chrdev(MAJOR(pi433_devt), pi433_spi_driver.driver.name); } =20 @@ -1427,7 +1427,7 @@ static void __exit pi433_exit(void) { spi_unregister_driver(&pi433_spi_driver); class_unregister(&pi433_class); - unregister_chrdev(MAJOR(pi433_dev), pi433_spi_driver.driver.name); + unregister_chrdev(MAJOR(pi433_devt), pi433_spi_driver.driver.name); debugfs_remove(root_dir); } module_exit(pi433_exit); --=20 2.34.1 From nobody Thu Feb 12 14:45:32 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1B7813C833 for ; Fri, 5 Apr 2024 07:40:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712302819; cv=none; b=K4D5+XwBetCohf8TEr9Er9sgvmGHJQtbN0fSstgoQjv9ks3Td1bNTBwbxytWAepfG0NMPPscaYlnoBPLZENf8vXYTMaahG2oOP9uL+Vewrp6INAtrbs6rc2TNfHtYxGPLHzSMqm1ApfkYiRibqXrE+xa4e0JNwAPqqrwm7SRVS0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712302819; c=relaxed/simple; bh=t9HJqxPdA5XNwvqxEEAAekCfSRdNt7vbuUaJ67rE5xE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Hnrf5EzcK9haDOGs4DWFv/gH0VhTu7DrSZQ4yE1oEXdovLD/tABtzuSQ1oQRLs4h21XX/B43bmimGmkno3M/f5LM+Sr55/pitZK7QwQ/mKxyj6rVeZ8amwWtlINihCmUX7zbQZ3A9n2rmVfp68O13Ri1R+LEggjrqhfcTdq/MeM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jjE2CDQQ; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jjE2CDQQ" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4162c2109a5so7955015e9.1 for ; Fri, 05 Apr 2024 00:40:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712302816; x=1712907616; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sfMYrnadCJ5fGBi6dgXMCcmaOaqurwY7DOo3APmaJ9E=; b=jjE2CDQQvd6y9QpNtFK1CWziP5n12JKYBkWdgeeqHlxjKkI56dZ1K8fFYloQVGl92D sJygoufJTRWRPj7pcHTOTtwYv9PHjZ6bSgLbQ72gAurphrUy+iKA1q6JeggJU/ORUWLw v2VGWO5jfjzkNfIdOJW2PRYgwEfinY56l8TLoxkrwb9h278QxnMhgOohO9peuC+bIfxI +R8gkH3zTpGW8Itg+NNHY5y0gKp+tIbb4VS9In2hnJMGmZ4D03+JO2PDA/NWUwT2Cjsv EHRttfSuHgEjHNL2BUV4xj8J4HL5aI/vPlknf6Npzkw0IjEz37vxETVQJD9CM5GYOzpa 02PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712302816; x=1712907616; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sfMYrnadCJ5fGBi6dgXMCcmaOaqurwY7DOo3APmaJ9E=; b=A3J4/+o9n4elmQ+C5faWYPFqPKUz/uemv2RZm/91vku4db4Ti5mSG9G+2syah+FSWM qM2umpmh454XSudo8F8siMhSAdKFP8nGenIKVEByr0iIjXZ+oxw2yyRDyhsm4L8UFYgb zR4ImN8VkrA5ZuBkndFRBkZl4sFims7QsL18vnNphjxxuSiNTC0bGKrkIhZ3uiLqTGVW gMz6jmxSBALSLioeuuIW7pEMZyYn60lwfmmpAtmL17gJCjnSas0cH3L+2godeu/uIKiN kQQO272YCgljhBt6C9KG2hGzmIZIJfwXC8OIfKCuuCX5YZtx4fQLrOj82YWlqedOKH7O RKOg== X-Forwarded-Encrypted: i=1; AJvYcCWewZlFFvPGR0PPZ769XM05ESHLdf86QIP02spPJXTnjPjc6X9veCKNF1xWBUcNJXyZG28kahGv6pB3ayWZvWw4sHR+Z9v84fzS0dAv X-Gm-Message-State: AOJu0YxtCr3ajpe9dyISK46V5D/xFyBwekijT3wg23baxickD0ZAa5pN do3ZRoOeejzhO4WSOX3q5CKyBOeLb6r5jeD2pJXSHveC2awxMONZ X-Google-Smtp-Source: AGHT+IF1lzcGczrfopACd2bNaeA2KFZKHgaZLXDgXTnFS30ViuvSTtE/WdMepCeKM5nHgE7NKp1zzg== X-Received: by 2002:a05:600c:19d1:b0:412:dcab:7c79 with SMTP id u17-20020a05600c19d100b00412dcab7c79mr519544wmq.10.1712302815994; Fri, 05 Apr 2024 00:40:15 -0700 (PDT) Received: from localhost.localdomain ([2a06:c701:737b:ef00:2bdf:f41a:ebd1:fb2c]) by smtp.gmail.com with ESMTPSA id l10-20020adfe58a000000b003434f526cb5sm1311643wrm.95.2024.04.05.00.40.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 00:40:15 -0700 (PDT) From: Shahar Avidar To: gregkh@linuxfoundation.org, hverkuil-cisco@xs4all.nl, andriy.shevchenko@linux.intel.com, robh@kernel.org, felixkimbu1@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3 5/7] staging: pi433: Remove duplicated code using the "goto" error recovery scheme. Date: Fri, 5 Apr 2024 10:39:58 +0300 Message-Id: <20240405074000.3481217-6-ikobh7@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240405074000.3481217-1-ikobh7@gmail.com> References: <20240405074000.3481217-1-ikobh7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" pi433_init had "unregister_chrdev" called twice. Remove it using goto statements. Signed-off-by: Shahar Avidar Reviewed-by: Dan Carpenter --- v2->v1: Followed by Dan Carpenter's comments: - Remove empty "fail" goto tag. - Reorder pi433 init & exit calls so they have reverse order. - Add "unreg_spi_drv" goto tag. - Check "debugfs_create_dir" return value. - Update "if" statments for consistency. v2->v3: - Undo pi433 init & exit calls reordering. Reorder exit calls in a seperate patch. - Remove "unreg_spi_drv" tag. - Undo return value checking for "debugfs_create_dir". - Undo "if" statements update. drivers/staging/pi433/pi433_if.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433= _if.c index 62ce75b07bf0..b01ee145ff3c 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -1403,21 +1403,21 @@ static int __init pi433_init(void) return status; =20 status =3D class_register(&pi433_class); - if (status) { - unregister_chrdev(MAJOR(pi433_devt), - pi433_spi_driver.driver.name); - return status; - } + if (status) + goto unreg_chrdev; =20 root_dir =3D debugfs_create_dir(KBUILD_MODNAME, NULL); =20 status =3D spi_register_driver(&pi433_spi_driver); - if (status < 0) { - class_unregister(&pi433_class); - unregister_chrdev(MAJOR(pi433_devt), - pi433_spi_driver.driver.name); - } + if (status < 0) + goto unreg_class_and_remove_dbfs; =20 + return 0; + +unreg_class_and_remove_dbfs: + class_unregister(&pi433_class); +unreg_chrdev: + unregister_chrdev(MAJOR(pi433_devt), pi433_spi_driver.driver.name); return status; } =20 --=20 2.34.1 From nobody Thu Feb 12 14:45:32 2026 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B41312FB0F for ; Fri, 5 Apr 2024 07:40:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712302820; cv=none; b=rh6Dbuoo5REN66cnJ8QKUXH422V4/wkOElhx9+UZuHD+JfQs/iTm6ybN/4LLb0fihEu5+shvxVFeLxH7CIIVvP7nrQSZ406ZrREbzOeYLum1XHKPaHiaHXm4sG63EVj/FgDUrrt5zEXCDPcUm/eFU6258DOylzETHOH/rJuINQI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712302820; c=relaxed/simple; bh=YoCK0eHi9vC1QpW8oygU2C2KyLLNC61wcBUkYFvHKuQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=fh3o0QZxVhdzzHaed7gnVzOb3nqagoXLRm+JMLryD/HCXByKcwV0dSHfKPjqo/Da/Q7VGuaEH0oRonBlJ9Xel9oagXYDV+EaOwQEF9qc0qz5eAdWNvfAIqTUEe5nrzT0bA7eejA3qhdPAuQ35l4lcPFS0e7qxvM/LmG4BNcr4C8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BeBA8KKK; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BeBA8KKK" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-34339f01cd2so1313347f8f.2 for ; Fri, 05 Apr 2024 00:40:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712302817; x=1712907617; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RNwZe5BOe/LQIqDd4/80RXtPtgdVPrSCbY1S4wwVTwY=; b=BeBA8KKK+hB+Tw7K6TnUgNj+s+MGxDNmBUJCl4GvX4YtAs7pFxG3047fZG/gjBiG2B hPLYPa+qg19HJBWTQzBPMJa9Kn/ASLVEo7r02OpyKXc6x/17dJEyB6rc77UV4vHG380j yZhoOfAk9kSkLSx7uevLEFt2Cs0oZlYxiQflJYSbKG+oMIzO4jGkQPb4xIQ2DfImmnCe MXpc4ALNuKABL7y682A+atzXRPSOrfTyIqhOjMYkAQ0kFnbC4XLam7KXyWIA8FDQrTQw EBOhWe33tOKSSMhrPvFXC91pgN6KLb06IhHVplQ6QPFiSwp2QsESY1iV/5sM1fV7eTYh 7USw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712302817; x=1712907617; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RNwZe5BOe/LQIqDd4/80RXtPtgdVPrSCbY1S4wwVTwY=; b=SA02AMuxXdaE0IQTDL2I5o0arJhQXinH4/mEJUkPa+SIY7ozi18MNjBrJU7kqCfcoo mICGrnsVe1xndVbZRDLofmNk+tNU7rNmBVJ8j8gK78Ikw8QHUn+HCnFQszLDMSMj5zw2 HHhG6ET2WrTy/rQ4a8f3JdbzaYaZgrENCuGIUVIVOAzVNqONMhrMX1u5HyRV3RqO0kj4 RXsxpuOj0kA+f7AUsarMHn5UpqH51gjMwp3IRomqNdy21FyGVUmLnFHjzjmCSKVCg5Vq eIU3dV8btRRx2kt4AMJzBZV5sxRGlT2qttqoTm2wt99mTQ7t2BnSfw7/dMInMd2snVo9 KsYA== X-Forwarded-Encrypted: i=1; AJvYcCXRJhERQkkScPA3/IWov7d7e6nvD4/I7V3KeGqTJmFUwUIdPLgK2lHrxYdGW6hH9WFQXmXq8Kbm9bSVbp/bgXpPdzVhi6QbJOvI/o75 X-Gm-Message-State: AOJu0YzVaFSdwsLpdI8iKrFeerJ20ayLkt+rxN88isZDOzCk77thRGw/ tX9HgYMoNMGJstZAh+rAInlCzo7hQaGxWfsaUM8vKzw6lEjwUtkq X-Google-Smtp-Source: AGHT+IEpHqb45+dVx4WtccQ09P9O9tIKvqgQnzhLdc3gA3jyZ2lskMNvWXD6mN3uquhggb1SLoWfig== X-Received: by 2002:adf:b1da:0:b0:342:61ee:bee1 with SMTP id r26-20020adfb1da000000b0034261eebee1mr485769wra.23.1712302817549; Fri, 05 Apr 2024 00:40:17 -0700 (PDT) Received: from localhost.localdomain ([2a06:c701:737b:ef00:2bdf:f41a:ebd1:fb2c]) by smtp.gmail.com with ESMTPSA id l10-20020adfe58a000000b003434f526cb5sm1311643wrm.95.2024.04.05.00.40.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 00:40:17 -0700 (PDT) From: Shahar Avidar To: gregkh@linuxfoundation.org, hverkuil-cisco@xs4all.nl, andriy.shevchenko@linux.intel.com, robh@kernel.org, felixkimbu1@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3 6/7] staging: pi433: Add debugfs_remove in case of driver register fails. Date: Fri, 5 Apr 2024 10:39:59 +0300 Message-Id: <20240405074000.3481217-7-ikobh7@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240405074000.3481217-1-ikobh7@gmail.com> References: <20240405074000.3481217-1-ikobh7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" debugfs resources were never cleaned in case of failure to register driver. Fixes: 4ef027d5a367 ("staging: pi433: add debugfs interface") Reported-by Dan Carpenter Signed-off-by: Shahar Avidar Reported-by Dan Carpenter Reviewed-by: Dan Carpenter --- drivers/staging/pi433/pi433_if.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433= _if.c index b01ee145ff3c..77e37a5bd1a2 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -1415,6 +1415,7 @@ static int __init pi433_init(void) return 0; =20 unreg_class_and_remove_dbfs: + debugfs_remove(root_dir); class_unregister(&pi433_class); unreg_chrdev: unregister_chrdev(MAJOR(pi433_devt), pi433_spi_driver.driver.name); --=20 2.34.1 From nobody Thu Feb 12 14:45:32 2026 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D80F13C919 for ; Fri, 5 Apr 2024 07:40:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712302823; cv=none; b=sBE7O10L2Oo9ibP5RbJmqgt8G4AH3znx5A0jtEkMDWu8jbr+MjD8KUXEk098AI+GVV0NsRtIfVuweoDN4NsT+59033sjnsMVt7NBmB3qSW6AzXKBgjBWv0/HGvXsz7a4KQmlBpnJNHbCNQ2aDMeO7q8S66bm7LMLvhP90FnZIok= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712302823; c=relaxed/simple; bh=6A7E8mEhs3KXYwrM2uDEBEWNmZfL2jIWrfVNakhFg2Y=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=c6LPOztzwfTTwNuMBM5u11WS4XBEeRMYRqhM2+3u051eZuYH2PVa3DDsq+svsAQtiba3WKBg08dILlG11zN+AeRuzK5x0MDyER2gTlZslVy5cMnO+VKs8Q6KlQEtPMSADUaMFezyKQO8P31rws1bc2KPzfRMawqcjbpE89Jh1ls= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OtXa4uRa; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OtXa4uRa" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-516be63af88so2082173e87.0 for ; Fri, 05 Apr 2024 00:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712302819; x=1712907619; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ll9cx3RyF2mwcmQbJn6nm/vNnPUvqbUfuPvzuxeiac4=; b=OtXa4uRaxDPt5SD4fyLkyY+xCGNLTOqnps1guK6vJmXGhNhThXWsODXzfBxbMPtb+Y 4GGtIq+Qq148IguiL6Na0V+DYDd2Hhf9Q1XRnhVoKQl/p48FqEhIFtb4yZj/Ff+W9A58 KOcR0jekjEH5YM1Rfz1t9fvwrYISKaXHbY82ITP76HqmVh+Fet3FcjoSXhwybUltFubV 9jfwA2HkD8u3drrdwuSkD/OJpnWK7qMtXP9Wl5ONwBm9eSnEOAW7GO9D0g2TKdvN09gv YXAiDEQKTp5UkC2ggA2Im/fvAMhPxVwswX0ag/O73U4EPaz5MFhm80/1b8XJeXv/4vWR RgrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712302819; x=1712907619; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ll9cx3RyF2mwcmQbJn6nm/vNnPUvqbUfuPvzuxeiac4=; b=U+5/JJwp/z1PyDI760LbLPHOkdWhw48H2Z4WUUj4X18599p6foqDMq09u6VV8Yzahl r7RClcqHaCSgfjpX6AVDglAd/Tj4zWhc54Kncw5RWzrpfJ/r8JuzeKtDMoTohX4roTFc /OkS5KccP8ELkIpk1PryrYImeKurQsUI/V42RILXVtdbPPmVveahSmkW5f8ECeUx3EIj X9XZI5C2c+fs0Q7KnoW+FR2cRIsM1HWuHAaTGU0/ZgDoBlOokY2TuytZhvKEfnQ/wvz4 kygKdqrRTINvj2ixKsaEVBA7XNptYSsqRIcU/dAlL1XsSEDdP22tbt0/FHv5gHi6kaEz Ke3g== X-Forwarded-Encrypted: i=1; AJvYcCWZeXblVel8uj72aZe06kx/c9L6LHowbzhJhj9DH1QkD/gwmHqBxxEV+LvM/MoNLlx13nXo1i47+J03hpSv4U+6CBOrFS3SXqCR6Y07 X-Gm-Message-State: AOJu0Ywbb1PsS33cLtTzLf9Azgg9OgNdlQamSwsi0rP3ucRva6rF0vdF O3RqpKqkAluv0qg0g0KHVx52ESopxMKko7sm+BrDbmFpBB4bxMAe X-Google-Smtp-Source: AGHT+IFvXxRBKHpmPMp/cqVHJIstyDR+r0Bs5N44IFJVlWHFI8nUvyiKYx/SyYNlgH/fII+G4opQQg== X-Received: by 2002:ac2:550d:0:b0:516:a1ce:6a20 with SMTP id j13-20020ac2550d000000b00516a1ce6a20mr394762lfk.24.1712302819247; Fri, 05 Apr 2024 00:40:19 -0700 (PDT) Received: from localhost.localdomain ([2a06:c701:737b:ef00:2bdf:f41a:ebd1:fb2c]) by smtp.gmail.com with ESMTPSA id l10-20020adfe58a000000b003434f526cb5sm1311643wrm.95.2024.04.05.00.40.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 00:40:18 -0700 (PDT) From: Shahar Avidar To: gregkh@linuxfoundation.org, hverkuil-cisco@xs4all.nl, andriy.shevchenko@linux.intel.com, robh@kernel.org, felixkimbu1@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3 7/7] staging: pi433: Reorder pi433_exit cleanup calls. Date: Fri, 5 Apr 2024 10:40:00 +0300 Message-Id: <20240405074000.3481217-8-ikobh7@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240405074000.3481217-1-ikobh7@gmail.com> References: <20240405074000.3481217-1-ikobh7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" debugfs_remove was called out of order. Ensure pi433 init & exit have reverse function calls order. Signed-off-by: Shahar Avidar Reviewed-by: Dan Carpenter --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433= _if.c index 77e37a5bd1a2..67b945a41067 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -1427,9 +1427,9 @@ module_init(pi433_init); static void __exit pi433_exit(void) { spi_unregister_driver(&pi433_spi_driver); + debugfs_remove(root_dir); class_unregister(&pi433_class); unregister_chrdev(MAJOR(pi433_devt), pi433_spi_driver.driver.name); - debugfs_remove(root_dir); } module_exit(pi433_exit); =20 --=20 2.34.1