From nobody Sun Feb 8 17:21:06 2026 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2095.outbound.protection.outlook.com [40.107.247.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBBFBC13D; Fri, 5 Apr 2024 01:51:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.247.95 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712281899; cv=fail; b=BhinxiNIfHT8ndESTBSu8/MLSFlHK6WV4D9mT5hU2QmImE7QtQroZcr+HS1Uy6aMqOvZvZOGMVIhWJnpP2dFDjuaKyOavmlgEKpmjyykJw8SLlQ6BzR57uHpfK7MaafqRtjgVw7nu8kU7UCZubqjY92Ru3k7Ay+ns+3aUhWehSM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712281899; c=relaxed/simple; bh=t5HLy5gFexuRUd/gcXkLur0tNUBqrWNFLScENOV0ZWY=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=NBGc727nAM7UvWfYYX5nmQU30oVAIc0D89k7K5ycfsB73XDQCTM7iq5GJeH5CS0cchkNc365akHfPXD5ByZYfyNmXrLqzPmxXx3JBD7edH4B/uvAv5I0pK2iwsj0QKWM1x3GLsnsQbgLgP3II2+yzZEVNtGP1twuetNmYRJedkU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=bUd7P619; arc=fail smtp.client-ip=40.107.247.95 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="bUd7P619" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m3KKLuBU/RaM3j1zf9hUhmTnMcx8+fTiOr7CJv17Aj+SbG1Cu4XmhUKCBCwi9VNDCMneLPjZZPHHoSEFBthrMncClJuPJXxoEBaYriw8yv5lj580uZYDCXPIyUOHBM6Tdg3kiybBeEFrznFsSpblqmpFSoIVSCU7U9itBsHmeBjSJCBN77E08+OcMPjFcE3bPTomjN1HIdPHN5lgVS5UIvpmmpp1joro7PnwjawdTkedGlAi47nJtXLzKf+GKmoCIdnMpfEMfPB4CzJlqro9JDiLMOcmhYxAOpnvWkQJO8zVxKQ2JWDKR+ZIOWny1FsXWl7Utk8lyyhl9BdFGBpLcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DkhFzy347CReKh8Y/3De5x5m9e7u839I/9k6SdaIf8U=; b=WmN3efy4xMIp/fUeGsA5R+g+i9NLUl3pXL3Zchy6s7WEFNc5y86I1IAxm2xWHH8VxQBvqaKNtjss+t46HSCL4w/EebHzCXds0F9j+Fmrfjl/jNR6QpmKwRqdghAISpDJ7HRFDi9+wXtAkGxXRif+4WP7TrZvw9C0WE66QHRLpVfp87G8a5Q6P8OrJQf16pNACUlD7AhRAZu0C3fAOBJi6dvSgEmaoEV9cpWW7IHiWcvvDpVGIe9bjL1UYHjF9MQ77tZG/KDrZk4hcjZcA8YTnE8WQLXxUR0BI8039oA0aUHn+LREgWFmMuvbq8b9qKpGBkjJ1qTzDgqut/7bWPE3aA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DkhFzy347CReKh8Y/3De5x5m9e7u839I/9k6SdaIf8U=; b=bUd7P619XWnp3H7OB77VkVB8OjiOKtLehRwdwc7i7ObBojlmSrOn8fD4HC7nF+r7v3Li6Fo9F0JGYKulTHZOP7635PBPUu3X1fOt9sKeoc2jEPHd1uobkiZQPz0nN3ckPOicv2zJ+KWtilliMIezd33QiWN4Nn1VdajDVTZrmGA= Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AS1PR04MB9334.eurprd04.prod.outlook.com (2603:10a6:20b:4de::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 5 Apr 2024 01:51:34 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7386.037; Fri, 5 Apr 2024 01:51:34 +0000 From: "Peng Fan (OSS)" Date: Fri, 05 Apr 2024 09:59:32 +0800 Subject: [PATCH v8 1/4] firmware: arm_scmi: introduce helper get_max_msg_size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240405-pinctrl-scmi-v8-1-5fc8e33871bf@nxp.com> References: <20240405-pinctrl-scmi-v8-0-5fc8e33871bf@nxp.com> In-Reply-To: <20240405-pinctrl-scmi-v8-0-5fc8e33871bf@nxp.com> To: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Dan Carpenter Cc: Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1712282385; l=2653; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=dKDsMHnM+cuvfvX6K6tAU3ADCasBJe+OHaz6qBQ1Tuc=; b=OKFZQg9iNV1rPeKGiN9dUt7Lvl/bm1h4ZwOVkECy3ViF7GlUxLssVqnSRyB0Yha8FHSCNp3PX 7aAXJzxNv0yB+24h16cq7oABrZSWw+2KTCYLGeC9R/8NXU8yEFeo0fW X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR01CA0012.apcprd01.prod.exchangelabs.com (2603:1096:4:191::8) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AS1PR04MB9334:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: g9dfYGQpdcCOKQ8McC+8G15rjDNZ4jlFM9AOLx658oZd7XHdHopuO+jT3i+32LZww+7fdPw8me6KVOAf0gHM4549P+b/YtoHg/LfQOXozSUGugidZ1+uvi5hoJSP+4oz2x8zMYDSAexJ5QnhfbrVX7CEj1WfKToV3CzG5pL51dt7xk9khbN/vJHUoH7fAF0mpmGe8nuzSZ/W3ILvY04GZKdTuVauuBFGiNPISEbENVSd7pYfAnyg12hisPlxO4UJtbrnTxgTW0jg+JF3Tqz+2/zNfgGdeknhXvG1DCaj/DHqPY7QQx13BnsjHQSuFYmh6clDv+C5FOPur6HqdrTva/Yg1WaF+27U6K6mqNkfp5OiPOFynpY9vhn8yv/hfvrHHsumKzqYw0SnryzFLMTYXmOaI1M+Fgc7IMNiqSLjAV3HNeaMbQ+5o4TgfGL0x8ZFmYM/Kgy0Eh2PpKfbsId9p0xLcQKnssiN6hXV2VE54wpuhjhrHUjCrzh34sC/6w6q9DsK6t5XKbh03jWVDIZNjxfwbStIazuxHekfYQxs6rGShZUQdqsuNbwOIiIBZxTQjYivaHJV8YvwxJJYy+5ygfaTX4XKyzTSvOUqIzT36jCWDf6X15T2vI5iWYMYtvf9eKUXKw0BWERo/eNHGE+CypqtARB1p8cgBc1eaUXdW4khSJqip9KpO/YbbuOwlFtbvmo18J0IfZ0ZAKsOadsUxWrAiQGuYG/Cc99wfC+Q1B8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(366007)(7416005)(52116005)(376005)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUFtV01IZTRhRjJmNTBDTEhKcTJKbmFmUmp0YVg4d0JxRTNKK1B1ZHRXRlI1?= =?utf-8?B?VTN4RWxXVy9yR2FEZDBISFJvR1RGZWZKaFdDTGJ3QjMwalBXeDM0K1pXUmpi?= =?utf-8?B?N0ZKUGMwdUs3YjlCYUdiUUh5ZHhKTUEyUWdYOXRHNndSQlUyUmVBUjl2QnVI?= =?utf-8?B?SUJsL0NKWm5jU281czk3aTJqV3JhWHN6N3kyYW1vZG42SlFqVXEwSTFuL0tG?= =?utf-8?B?VXZaOGVOTTZMVTh2YkxydEJFNEVYd1hCQVRGRWtpckl4dzhaUFZXMjlBMlBw?= =?utf-8?B?TUNKS0pEZzF3amprUk9rTWhCM3BtSVptTktjWktuSlRyV2VHelZxVTN0ZFpU?= =?utf-8?B?NGxtR1JBSVlndFN5ajhicGthaTE2NmYyUDhYVStESzFNZXY2dWZqajVkVVJn?= =?utf-8?B?ZzlBRU0yQW1sc3Zyc3pMdjNHTkFQeW1YYmcyaFR1SGZlTTI2eFZDYkgzWUZi?= =?utf-8?B?Y05aN1MvcExMVXVtakVwWFdmS01xYklJd0JJMzJER2ZacUpVQmYvTTZVWnpF?= =?utf-8?B?RytrNU5peDlsRkl6TFFNOCtrSHdrNjJDbjBsZjRISU91NCtkeTNRbk5md0hh?= =?utf-8?B?N01oWUI4T3ZpelM1WklKajRMOXQrZ21uWWczSUdQV2t3Zm9nUTI4WGdVWlRv?= =?utf-8?B?U1ptcUx2VGY5VURYQkJIb2pOUnUzMHhEdm9kK0M2Rm4zTngzMFNCM284dHRE?= =?utf-8?B?aWlneUNsa1Q3SmwvMzRnVXNvU0cycHBXS29tV2wzMDNOV0pSakZkanlyd0FX?= =?utf-8?B?SWt0RkRrYjgzL3NXYm81cjVneGNSQU9sWVNDMUt2V1BodVNLbVJCSWJaV3Ji?= =?utf-8?B?Z25mcGNleDZhU2trM2w3djZtajdRNDRqN25tbVhON3d5RFZXWG96UURNOHYw?= =?utf-8?B?M2VkMXgrYUhHZDE1cGhQNXU3OFVwTXhKaXUybFlvWTVFTVdUT1B0YkRNZS9a?= =?utf-8?B?TWwzNHBUWUFFUVl0cGpLR2FrckllRlgycGpkc3AwamlXNHQzVVpKcFI1L3Bw?= =?utf-8?B?L0FjUHhva2N2Q3hUSVJWeUVHQUlCMVgyRDJGeTVKWkYzWlE2dTQraWNyNlpW?= =?utf-8?B?RGVzVytvMmFvclVmTDg3Zk13Tk9vYVpqN0hWRzFRSXRwN2h1bzVsQW9KOTFR?= =?utf-8?B?WHBaMm93NURTK2cwM1Y5ZVhBeDNSdlJGY1hhaTNtQXA3bjZLUnR3ZUNVS3JN?= =?utf-8?B?cjF5ZmpOMG5rQVgyVU0weHhXR3dGN1V2TjYybGVCeHltUFc1Q2lHQ2plQ0ZD?= =?utf-8?B?RlY1UElnTlBJVFFjcTR1RXRzVndyS1k0KzIxeGdJVjJHWTVaWnBBR1hyNlht?= =?utf-8?B?MlFlQnBSM0JGRVBmWi85b1hOWnVsc0ZzWU5HeXJ2SmwvZU0rRE52MkRkRDEw?= =?utf-8?B?R2h3SkNoRWtkYXVxdFR4a3VMQXVvYitOMUxJRGs2UEo3YTRlVEdOZ0E4d1M2?= =?utf-8?B?eGhuN0t5d0dmbzZFUWlSUFFwaElCL2hkaTlyM25ldEVZZE91b05NSHpCblIz?= =?utf-8?B?S2pOUm1YMHl0b1FtdUdjME50TEtURU1DZmJ0cERqZy83M2JRVlplc1JkWG1z?= =?utf-8?B?ZFBFUUJhbEZkM0RDZ1J6ak1ETS9oMGhBSW5NR3pQQmM1N2VBeUhhU2xnc015?= =?utf-8?B?MktQMlZsUVFMMm5jVkg5Ym1lYlRqV25KR2V1ekdEelhncTR6NWV3VHBTZzNo?= =?utf-8?B?bVRPN3pMV2g1cStTMnpaeW56a3dGekxRR0JTckNnN2Y0OWFvckVYT3dlQVJp?= =?utf-8?B?TGMxc2VnU1A2bmszRXNSelJzR2RNTm8zb0pwT2JDWS9zb2ZJb2xNaG01bis3?= =?utf-8?B?aWZiQkl1Y1FIU3M1ZGV4c3ZCTVR3aVBnNzJ0c3Byb1gwaWpLUk5tNEZOa1k0?= =?utf-8?B?UW1GUFhqQVVvbUV5ek5iOGN2eHJzRExwQmlCOVVHRDBYVkY0UG5SVnNwNzBt?= =?utf-8?B?aXlFQ0tvWm5zeGhlcjdwZUsvN3BEb2trSm85TnFPV3RiNnBldFNTbWN0R0s3?= =?utf-8?B?RTRvWVVkZDRDZTRFQU9PZ3NTV3ZJdXdiZ1NLTktRc3EzTjkwT2owQ200SUNk?= =?utf-8?B?TjJQcHZIWDRGS0Q1TWpveXBid0g1MFcvNlNpdG9aSXF2Z055Ylo5bTNDN01W?= =?utf-8?Q?brHAqQumnW+JOqzBhz2dIcApz?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b766d00-8ad2-49cf-80e7-08dc5512ec3b X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2024 01:51:34.2107 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lANtDZAk84Tkv0d9S2t+ox0JJHJbEHIoQ3+D1/HwqKlUj+o7/1s1RKyF7O+4Cr8AJXA3gxUAWS7zDtFJ7YK9pg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9334 From: Peng Fan When Agent sending data to SCMI server, the Agent driver could check the size to avoid protocol buffer overflow. So introduce the helper get_max_msg_size. Reviewed-by: Cristian Marussi Signed-off-by: Peng Fan Reviewed-by: Dhruva Gole --- drivers/firmware/arm_scmi/driver.c | 15 +++++++++++++++ drivers/firmware/arm_scmi/protocols.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi= /driver.c index 2709598f3008..415e6f510057 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -1488,6 +1488,20 @@ static int scmi_common_extended_name_get(const struc= t scmi_protocol_handle *ph, return ret; } =20 +/** + * scmi_common_get_max_msg_size - Get maximum message size + * @ph: A protocol handle reference. + * + * Return: Maximum message size for the current protocol. + */ +static int scmi_common_get_max_msg_size(const struct scmi_protocol_handle = *ph) +{ + const struct scmi_protocol_instance *pi =3D ph_to_pi(ph); + struct scmi_info *info =3D handle_to_scmi_info(pi->handle); + + return info->desc->max_msg_size; +} + /** * struct scmi_iterator - Iterator descriptor * @msg: A reference to the message TX buffer; filled by @prepare_message = with @@ -1799,6 +1813,7 @@ static int scmi_protocol_msg_check(const struct scmi_= protocol_handle *ph, =20 static const struct scmi_proto_helpers_ops helpers_ops =3D { .extended_name_get =3D scmi_common_extended_name_get, + .get_max_msg_size =3D scmi_common_get_max_msg_size, .iter_response_init =3D scmi_iterator_init, .iter_response_run =3D scmi_iterator_run, .protocol_msg_check =3D scmi_protocol_msg_check, diff --git a/drivers/firmware/arm_scmi/protocols.h b/drivers/firmware/arm_s= cmi/protocols.h index 317d3fb32676..3e91536a77a3 100644 --- a/drivers/firmware/arm_scmi/protocols.h +++ b/drivers/firmware/arm_scmi/protocols.h @@ -258,6 +258,7 @@ struct scmi_fc_info { * @fastchannel_init: A common helper used to initialize FC descriptors by * gathering FC descriptions from the SCMI platform server. * @fastchannel_db_ring: A common helper to ring a FC doorbell. + * @get_max_msg_size: A common helper to get the maximum message size. */ struct scmi_proto_helpers_ops { int (*extended_name_get)(const struct scmi_protocol_handle *ph, @@ -277,6 +278,7 @@ struct scmi_proto_helpers_ops { struct scmi_fc_db_info **p_db, u32 *rate_limit); void (*fastchannel_db_ring)(struct scmi_fc_db_info *db); + int (*get_max_msg_size)(const struct scmi_protocol_handle *ph); }; =20 /** --=20 2.37.1 From nobody Sun Feb 8 17:21:06 2026 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2107.outbound.protection.outlook.com [40.107.247.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9C57168B7; Fri, 5 Apr 2024 01:51:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.247.107 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712281903; cv=fail; b=qSlEBuUtalcGCCxQ8QYrhKTaAA5BMVbuV+29iaNMIsa452epfsuvM+9/b03+SPPZsCLOQE7L1/H3cPuuhhDED4lzNTKSgRI4Lf7jYtIX+3fdxWWRu6iRwohK50ULbKOw4i84BwDNe83BF5pjBTNRM+39g+j0X7JgC89YOyeceD8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712281903; c=relaxed/simple; bh=VyUgp1uqg2sd9efaIWkIGYr2e4EYKfjV9z7DdHViSYo=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=uanjRVhdXii0ojLBq8j6/n/ipRWY1gSgT1+J7Xb2hwalcNcwxkA+Dqq107G9r0ObQn7/SJhRdy7J4cUWvZ9Y6UEPMN0v/bb69woxZQmIpcNMjVo1jGn9548jYx8k2KKhUUlCOWvdFkD7VVyJZgvrbO9nbmEi5f/J2fu0nRaSNkE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=Z6mF+gr7; arc=fail smtp.client-ip=40.107.247.107 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="Z6mF+gr7" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LxKpsBf0zWtVP97or+M8KJAfgSxLkTt26IKCnXDdu1HY/a0JUBzt/OTO3Ggmza4a4vfKxb3pl279WNINIPJ9ZM2J7oRZ+BuydxfO8DnxBV3edfXFn5WzDDMpmrKc4EUbY7/ua0sN/7mVsadTYRRvxSDqsjWeoWUgK+zJiARbU8MHBuPopM3+IWEglf5rkYJlrDwQhfxyQukS8OZ3q+GcqsVyU6+daITA8bIUhfp5uKeRWPLW3gyqyZygaOIXSRxgVrEVMYDgxUQt1YBkdpKfYkAg4qbmbGTqxBbVPfGDrG5KnDdjaMfHI0/MO2kCeNAUFKdTF6tOQ+IHrS0p3dt0Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s/BzLovi5aKNOiOuw8s4YMGfV7RBPkidh8VfX3S2pYQ=; b=GDlMpZLsJJ3MZAi3PoTN6Udsa5cwOS4iCZE06htIl9Kg7zQNfPzh/uJEZhpLwCmOKtgRzdemwCO4ITA8ltQlZax+xgxazlqUBJfxBU9WlMeLdlmSNXzcofQrGTOoL6T2J9MMXdRA1vV3Xu07Q7ju1Twc/aBtSnSjEgCW+ydM2MQfvF3kzeHKIc5HgnNH1zZAEOT3XcvXW39r03YnOv4k/p844tt12YGwRQa+vaMHdy6Gw291J0mSDAyS0XqzlX2D1a4XPHtAf2QMpWCViE7U8KaRFMipdDJ9qUcMdZxfTKdyG9i6n2XPr/UjGS2VY0HPb6CvfoIera3/ahWy9OVM0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s/BzLovi5aKNOiOuw8s4YMGfV7RBPkidh8VfX3S2pYQ=; b=Z6mF+gr7BbXSr+H9yoNfUxdlplWIEpRY5Aq4ApNaNPY+t7ORnO4AanVjqKXGgiavhac/xuiSCI0bwxs2IYs3oO5PMeET9xNoc/3SWpNGu/oRCtns26wrHUPjiqcK04bB8WzlwlGECeMd0ZQ8DZuik+d8eYF/r7I6wx91t0azLFQ= Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AS1PR04MB9334.eurprd04.prod.outlook.com (2603:10a6:20b:4de::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 5 Apr 2024 01:51:38 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7386.037; Fri, 5 Apr 2024 01:51:38 +0000 From: "Peng Fan (OSS)" Date: Fri, 05 Apr 2024 09:59:33 +0800 Subject: [PATCH v8 2/4] dt-bindings: firmware: arm,scmi: support pinctrl protocol Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240405-pinctrl-scmi-v8-2-5fc8e33871bf@nxp.com> References: <20240405-pinctrl-scmi-v8-0-5fc8e33871bf@nxp.com> In-Reply-To: <20240405-pinctrl-scmi-v8-0-5fc8e33871bf@nxp.com> To: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Dan Carpenter Cc: Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1712282385; l=2362; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=1H2rME0+2KWUaw0j7tYsXFokSaYx/bEPhCjn1uDoVYo=; b=BUg2Cj4WROOGS5yaciuXQoewxdfbg74i5cVScjfGO+Sj5vomm0JEOhabackVE8ZtBVN2UbgQv PU3CwxUabP1DXjMNnwwj8+2nYHZNcbdJv4mld2rtsaL5vzAsVWC3xLe X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR01CA0012.apcprd01.prod.exchangelabs.com (2603:1096:4:191::8) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AS1PR04MB9334:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: So1+PPKJB5KIPLEJc9gt1uj6emVSWX1IrxMf//nOK/mDfmFEyWm0O3YXxpcvE5EnOobm2qYLBiPqoRQ3DoHge7UeHQGEV25Rp6qRfxrCnmNF6aSBwZhwnsfpfAxEL2YUti3e0qxqfj0N5yS7sOWzQMw2kr/JamkFzdZG1+QIRr1gJP0v9yIahNHKbnD5b5VgHu9PPWiHvFk+WZTQDwfknhR2bCUq5eBg6LdZXTAb2WLi0h3K9PyaSNqtPro1lk5/xLR00suH0xbOPVi3qj9vJArCP2Dwq4ysHOrS1RusjT0KtnSF2c3gXp2mSkdRiCqT19rMyXqcJ9mKBuIcN2G935EWRlCxC4Hr9WptbgsiVu70y6LQIr2e3i/ML4+7ZU2Hy/Kj3+7pL82nVGxAjJTDo/eYLHPc+BtIhG0Z1dTYEVcFIYxZrBxvCMoQqa22BOgdyRx2NWGXBy8QrCBZPFNIg5hCtD27+GvzIh2fivKSNGxB4MrhLRes3JmBvV40Fh28eOPvSjtwSqPJY4SX4+qtADsMJtllFGrLww7IfXjiBqqb1IdmHg0Rz4mqHo0tbVxvlXNpAH3bw19mIlQhYz7aHsmQmOq8UfP9DETP0kHfeF8ZBLMeEPp8Uaz572W/RmdnRXTiGdegTqMm3kj2nrGB3L2ehGYuOK/jFmodTCk+r2A32a4X+EOQWuzY0r4uboMJpXi98Vbcrj9IBj5kDIfDka0URgR4axQ94dQOBmNipBM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(366007)(7416005)(52116005)(376005)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHRhTWkxWHo5dnJoNzQzWG9yeStXdEk0V091dllyL2F1MVpWU0hVcy9abml5?= =?utf-8?B?bjYyK3hnWTFYL1hxdmZIL2ZlRmY1ZTZ0b3ZwOGczRWZ0cUp0b1pud0xEbUZ5?= =?utf-8?B?Nk1LaGZEYzI1TDBLZmpKbjdldFR3RXJpU09UZTNrKzZRNklLakVnOXBjNXNi?= =?utf-8?B?eThpSVlmazlHcmhJR3V4dStYSEhwVVpTY0pVdVlVUVhpd3NlalJKejdFN3RJ?= =?utf-8?B?bVk3dmQzM0dnZnU3UTlSK210ZTNqVkU0WnVmS0J4Nk9IbHNDdmlsVFNrbHoy?= =?utf-8?B?MkFPazc5b1JrNHBsRTNzTXk4Z1hZNFdpeEVtSHlaWU5oTkRuYWhqQmp2Szh1?= =?utf-8?B?SE9ITEl1SmMvRXMrUHFtWktJNnF3MHpMV1NPYXJ5Y0k4Mk44cjBzVVRyQUl4?= =?utf-8?B?Z3VUaEdraUR0Zm1WR1FuemxpaE9XZ0RJaXNZNnlCVnBjanFWQVBIL1dnZ2dn?= =?utf-8?B?QTFhQ3pHQ1RXVGYxaXBHMms4VjVCbXU1clRFZmEyQXRjV2FaN0NWN1RORTlp?= =?utf-8?B?QVVPYXdaVm9CVFhZRUEwbGI4Q2kxR0x5RGJRaGVPVFgzUmo1OW8vNDhyaVcz?= =?utf-8?B?T0x3dy9WYmhjRnZ5ZmpDbUk5SHUzRWI5a0o1TWtiSjZ4Z1p1UjhnSGtYNUdp?= =?utf-8?B?azAxSzJxQTAxMmUxVDB0WXg5MDZvcU1iZ0lLMGRqLzJCRmFVaTBsQWJVaWVr?= =?utf-8?B?YThlLzdRaHdKSXZ6Uk5IYVlWdjBnajJmL0hnV0RTaUJ6VWhRc1pxbktSRjJw?= =?utf-8?B?TEZZOUloZXh3cVBlTzZIaXN3RXFPaElRaE1takI4TnRwK1RwM2VZQjIxWmRI?= =?utf-8?B?UEQ4NlZZUTIzblVlT1BXREVXakxmVDJsVnBiMEpDZ0x3WXNXTjI0RVUyVW5S?= =?utf-8?B?cXlYeXZHY0M4M3Q0Ni9kQzVUMzUzMjFrWDJ1RHN6WTEzYm1BdXJVSXJ5bkYx?= =?utf-8?B?LzA4RFdjdnNYZGRJMjN4RG96TVEyLzJlZlBTVUpDTzM4MjgvQ1FEUTdJVVFz?= =?utf-8?B?aUtjd3RNNzU5QTJVZ3J6RHBENEY0b21RNHhLdENFSEtoZy9yZXd5ZnkvenR0?= =?utf-8?B?NVRtT1VMZXBhRUdhSGZJK1FlS0FWTXZCMHVocThyaVFETGVjcUV4dGdPOHov?= =?utf-8?B?VGM2V3FLZlZQZlFxUEpiVHd5emtMam1rZys1QWJpYkF3T0RieTU1RFo5bTky?= =?utf-8?B?ejRjVDlTcG9DdlJzckxXOCt3eTFvb3BrZWxHSzI4Ti8vd3hXUHROUUV0cHFu?= =?utf-8?B?NkdJM01ZRmpLMjFQQ3cyWVhMcEJ5eWNzRnNJUnJoK2tQamJJMzJYWDBoS3JQ?= =?utf-8?B?TGZZS3ZrQU9rM2o3SFY2Q0kwSlZUdVhrQ3diRHFHOXJjSHhneE1aSFVqZXFH?= =?utf-8?B?cmV4UHlUMDNXNzh6eG12Zk9OY0V6RW9iSis0cktvSVJhVjhxZncvVGpYd2M4?= =?utf-8?B?L0VvclV0V1FaTXF5eVYxb0gzZjl5alhjSUpkbEgwcEVBRXdFN21sTzAyazNS?= =?utf-8?B?Szd1bEVWUlduSjd0Ym5KMDk5UFRFaE1mZ3BsTk4vUVNpcW16UFZla0pqV3hk?= =?utf-8?B?dWxDRjdQcDBqT2RoaFZ1SFNONGVNUVZjejd0UW12bG8yNWx1TE5ZcTRMU1U4?= =?utf-8?B?YXBoeTJ1dlZiN1VsQ3JPZWJWSHFCbm4vZ29rQThrU1RoYVdzdjAvVXUyQlh4?= =?utf-8?B?SFpwNG1aZVFJNUc4cUJNRHpOYmRhdi9Rc1RsOUI3MzZVMGEwNCtsWTAvdjVz?= =?utf-8?B?OUtLVG1GNFZWeTZRUERzZjdwWGpMK0I1KzQ2WnhEcTlOdVFDd01KUkhyYTk0?= =?utf-8?B?dkoveGxPMzQzQ2VzeE1nSko4anBOd2w4VTBpUUVWTHU5bXJFek84NmM3ZjhD?= =?utf-8?B?N1VaUCtFcjdsT0VFdDIxMGpRYzhYdkMyTllyVy9FVzRpcCtXQm90OExvN21y?= =?utf-8?B?MGcrMXE2S2k4eENteDNRTjVzZkYwaDJVU2JCK0VONmVBbEQ2UW1iNjFneDFN?= =?utf-8?B?eGY0RE12VDZYR0pXMjJSWmZXSzBEV3N0Si9vMklFOTFhcEdHZERBSkhtMVRp?= =?utf-8?B?RW5xek5aYWUvNUhVTFlrV1F5K3M2ZGlqeHREeW8yR0FuTC9XaUsrbTNQRERZ?= =?utf-8?Q?EObz9CDINPLLNv+3ATuv/BsaG?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ec8c218-02d7-4604-1dba-08dc5512ee9d X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2024 01:51:38.1992 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UJ3b4LYDluYeInuQqhKy82ZqKige506KSpgIVjUSnaBUWmjQ/t26h6KUxbqrE9qI0XLItmqaxUfe6zf1ieF6LQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9334 From: Peng Fan Add SCMI v3.2 pinctrl protocol bindings and example. Reviewed-by: Rob Herring Reviewed-by: Linus Walleij Signed-off-by: Peng Fan Reviewed-by: Dhruva Gole --- .../devicetree/bindings/firmware/arm,scmi.yaml | 50 ++++++++++++++++++= ++++ 1 file changed, 50 insertions(+) diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Doc= umentation/devicetree/bindings/firmware/arm,scmi.yaml index 4591523b51a0..e9d3f043c4ed 100644 --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml @@ -247,6 +247,37 @@ properties: reg: const: 0x18 =20 + protocol@19: + type: object + allOf: + - $ref: '#/$defs/protocol-node' + - $ref: /schemas/pinctrl/pinctrl.yaml + + unevaluatedProperties: false + + properties: + reg: + const: 0x19 + + patternProperties: + '-pins$': + type: object + allOf: + - $ref: /schemas/pinctrl/pincfg-node.yaml# + - $ref: /schemas/pinctrl/pinmux-node.yaml# + unevaluatedProperties: false + + description: + A pin multiplexing sub-node describes how to configure a + set of pins in some desired function. + A single sub-node may define several pin configurations. + This sub-node is using the default pinctrl bindings to configure + pin multiplexing and using SCMI protocol to apply a specified + configuration. + + required: + - reg + additionalProperties: false =20 $defs: @@ -401,6 +432,25 @@ examples: scmi_powercap: protocol@18 { reg =3D <0x18>; }; + + scmi_pinctrl: protocol@19 { + reg =3D <0x19>; + + i2c2-pins { + groups =3D "g_i2c2_a", "g_i2c2_b"; + function =3D "f_i2c2"; + }; + + mdio-pins { + groups =3D "g_avb_mdio"; + drive-strength =3D <24>; + }; + + keys_pins: keys-pins { + pins =3D "gpio_5_17", "gpio_5_20", "gpio_5_22", "gpio_= 2_1"; + bias-pull-up; + }; + }; }; }; =20 --=20 2.37.1 From nobody Sun Feb 8 17:21:06 2026 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2131.outbound.protection.outlook.com [40.107.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D49A817BDC; Fri, 5 Apr 2024 01:51:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.247.131 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712281908; cv=fail; b=M67FvNsQWSOLcJAgUfct/oE/2szL7DNT3TOaZQGO2Ch0rKy5YDNwkFOczGT7pzgZkFRMTP9ls92c1Xqi+Exx1NUzl3DV+Sm5MC04eSkTUXicTAXeFjoEFzhxV4F6aWmocjbhYlfqjg2ar/I6bw+1y4nE4QCv7BCXYzEvW1RYpWE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712281908; c=relaxed/simple; bh=OVUcqs3NXe9DqCRnk4OOcfi8n/ELkYkwdg7B5H7i050=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=khJrQT7lGIadC6MOi49O6m5eLwtAHElCklGNjINOQP8zt8BBoJVsvI7xyHnumFUp/EiHyZeVxRTzcLUQ+h88S8QLaM79fpQ3XJ06mlL0kmRePE5SISQzRMeRPyK95bwdjeVJKqIxWoJYJmcuLKNr+QqgEFALMwSjGRT2lkWVHsY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=aH8nyoub; arc=fail smtp.client-ip=40.107.247.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="aH8nyoub" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lA4vlFjDE488436ETYxlyAT1RCax7PmsBEKNBoRJQLC/Bi6lZOj5IkVx+b/Bk5JcNvUbmHfzF9RzpWwT6gBYJW4T+WfvVS1SNAXRtSmEeEjEcHJXEtlQj+1HUkQ99Cuf8ITR1rtJKDPLbwXERlDnZeThZ75nRTaEvMr2btSeC2Pk6jwnqAelBXasPeZCRKRb5QsFrzzXPtCw84ISwnkfWzdUA8uhnvUe84p/pRWb01qKgmhNmW+izveRfVI3H6o+40L6DJkXNiDN0lcAdViXg7LNqJwztAcLBGVkyMNq0k/ZtXzaCZz9+GgviCkn76OMkeAaFm40niRswcYmHxC4PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T+gf/HxSb3mYO0Kv1k4ovO2uwhjiZsrfA82adbv+lSQ=; b=hhTlpKkamSWb1Pj4EEPhUzwDFg0H4vSLNIYW51NpMuYPZad5nDp3BQVez6ff1w17v6odi5cEWfYT40csm4nc2lX2x1LozFIKmyqpKWtPGBO3o06sCVVzsisqF26LK/0UvKOro+Kf5FW8C+5VideFcnEc0dbGivvtcPBK5OIpVuMY1A3QKVA5R+9EY/wcllv/B/TraCremlIb84NpLVWo8prQXKR80+TyMo8SuKKyJbCo+eqKr0CBxPYyIitCwUqE23H/rHJGNuYoG/p4WoWq041CGIk9ypdxRSndDDLxvOAoYUcG1M3IAvvDNEx0tjixUqx+hm3DiVXG/oxEsh3Nbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T+gf/HxSb3mYO0Kv1k4ovO2uwhjiZsrfA82adbv+lSQ=; b=aH8nyoubFRo8lKMp1lHo9A/g6sRmjSMxzJM4zHOeP2VNQH27Hk/eNhsX+yZN/jku7m0HpKp5wj4M1HvRiAhzC7LOQlIqzNg7TrJnvbjCCa/V4O4pRUD/H6IyMDox1NIbtvxC6wBjw/qw4kEagXzHpvqCnmJdlQKTNs3E+PrbzUs= Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AS1PR04MB9334.eurprd04.prod.outlook.com (2603:10a6:20b:4de::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 5 Apr 2024 01:51:42 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7386.037; Fri, 5 Apr 2024 01:51:42 +0000 From: "Peng Fan (OSS)" Date: Fri, 05 Apr 2024 09:59:34 +0800 Subject: [PATCH v8 3/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240405-pinctrl-scmi-v8-3-5fc8e33871bf@nxp.com> References: <20240405-pinctrl-scmi-v8-0-5fc8e33871bf@nxp.com> In-Reply-To: <20240405-pinctrl-scmi-v8-0-5fc8e33871bf@nxp.com> To: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Dan Carpenter Cc: Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan , Oleksii Moisieiev X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1712282385; l=30412; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=66yyslbn31g3m2BveLmqG+nfctE+wEn4ra5Q9YPcQOQ=; b=wqKWdBtJuPbFmEjQ3aCOiEPZElTaxtxGbMN8T+FJLsQASvtLhL4wbVJGoW3Jk6ko0tRzxM5RB kH1wz8qjeuRCUYL4ja74aHvlMRpb9p96nXgj0HKJ+Gwy1SWGAvVLhrq X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR01CA0012.apcprd01.prod.exchangelabs.com (2603:1096:4:191::8) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AS1PR04MB9334:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hVtWOI7fqf9YA/AF4BN8xL9d6jMoMg51lXHwdkwl3o2w4N8IZ6TZ5F7YbD3Ey+CzUaBfLdzcFL9OYl3fNeNoBvcUhlNwirQLje480mkm5y6ILhXqa43OiwYXt2mhtY23IllfD/9OPWi7q+HsYJaFnTrQDHyqcOknBvdmHdrq9ZT2Wi6SbcoMg8pf45EfMf1JV5en/Xl4l7+rQIJDlb14Dv58qx9U6Hy+cjhZvnOYFtdwyzxNR4sJtZEI5OPQY+kqYGBI07Zao82wtiG35x67MhblkF8ixea7VJy/78OLlQ0caIqrw+Aqj0RbvK+CRQNU/CJOcq2HcKRAjPjxxqyFu9KR+7ch3WTBF9EnlLK19ucezeTgshSQIJdNNlgUv8mvuUu4NUW/ddITGjXn8jLRn0lFX+kKUpW9DGTY52OVtrMfzn1QPoXT06f1nePc8shc6sZWQ19BbFeUv0ArIoZUHkS0E2PZZOE2wTJ4ij4ViVhHfaDrre6HYRR47mchpsRn0FK1oG80GfAQ1Wd2XVzhOlSTE3IrP+b8z77nfEdKT9Sz2nH8jdnrnwhOsL/6uxc3h0vCMUcXKEqZJJffyM/x9lyvAMvgQcJdkp2v+uZiaxEa4WaK6kiR+MDf/QRLm7R8jlqoJDQ3ssL+K2zWWxOFAIM3zmvkgHBKmXFL7J9/vtWEqRlEwIYx6wDB0JFWN+/ksIRAVcuC6UPkYPA4x8mchzGUjrr0LJWPJpic6tGWcWE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(366007)(7416005)(52116005)(376005)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bllxMFJmdlYrQzNoU0d4RHZ5bzBPTDREQTVJQ3NFYkYwVmdOY2gyQmtnV1hp?= =?utf-8?B?VVRGUXJ6T2Fscld6MGZrRjBseHplczZvR0crdkc3U1QzcW1jbllWcnk0RzM2?= =?utf-8?B?WUtQNHR6cEJUeEhDVkhGaGZiSm12eVFLSVU3NG4rREF4WHlEclc4cXphSjlX?= =?utf-8?B?NlBkbUd2azFDVUNWWXFIRndDOVZQTTdZdXU3K3FFR0dWME0rYW1KMFBycE94?= =?utf-8?B?TjZ4aDNoS2Q4TG5sWXVmRmJPWGQvbVM3YlZyV01rbUQvTGJNRlh4UHdSQnJx?= =?utf-8?B?QVNhZjVxaDRTY3M5eXJPVVl6L3hTQ2h0RzA0ZUJ0ZWJBM2EyVWovZlhlS1FV?= =?utf-8?B?MmZOdi94WE5iSllVUmZxbkdZeEJ1SVdlRDVzREx0cWJFMHJIV2Q3alVxNGhh?= =?utf-8?B?Z0NaUGYrL0hoaVM5ajk5K1hwSmlNZ2dYQklTZEMzTS9TZ1c3SWF5V1pkWE1J?= =?utf-8?B?TUs3TENmRHdYeWNybnBIVXo2a2dYNlR5S1RyL1ljZHdGQ25kVURERlpNR3BG?= =?utf-8?B?UkgrYTI5dGs2MUc5dGZEV0s2cC9IeEcxUEZiTExuejVIcGY3em40d3N2OERU?= =?utf-8?B?c00zRUhFeENoejdvVkthR0xTdUxUbXpPZnE5a1hpSDRxTkM1OE1xT3lxZ2ph?= =?utf-8?B?RUY3d3JDOWZyakkyQS81WFM3UkJSZk9tc2dVOFNTZFVLMjQrKzJjNUlJekZX?= =?utf-8?B?bWl1ZytmS2k2R3dTUWVVSStweDFXcHNoN0twc3NQQ0VIWk9HNHU0dng4WEVP?= =?utf-8?B?NHpRL3FrOWpKd2VXbk91RG5KdXBiVWlURnZaTW13aHY4OXBEYk1zUERzbEVw?= =?utf-8?B?SkE1bGNrY2VFRkl2OVdyVjFnbzZLb3hxb21vQmMwcERRdEwrRTc1djdtRE1U?= =?utf-8?B?ckpnSExGWXBQWVFhanJFRytIbE84My9jVzc2UlptSnlnNXFjVWwrVXFRU1Bv?= =?utf-8?B?S05xam9XY0prRGlHYmVFYWllT0R2TnZkbG0yd21nbSt4NkFrc2VTSW1HMnFP?= =?utf-8?B?N2pUcWEyYnh1d3lkTUZlZHcybGs3UU50RTRHNFNTL1NrRGRra1J2bEJVZytO?= =?utf-8?B?MEs1aytJNzhnTDVyekl0SW51NzdFd0cyNDdSUEZtbGp5MWRVWTdzQTJmcW03?= =?utf-8?B?d0lUbVNMV1NPSVFqYkw2SzhMWVZSbGZjL0ZHYjRIaDQ3YnQwTkkrUFo0NlNa?= =?utf-8?B?UmFvc3VvYlluUzcybXN6SUpCN3ZiT2tVOUV2QVZFRVJpQ0ZjUitBcUVkTFZS?= =?utf-8?B?SVFXeG0vTGhjbWlxY2cyV2RuTGd3bW1KTGZXWGl3QVdJTUd2b2Q5QlRKd2Zo?= =?utf-8?B?eDlPRmRzSEdjTjROUFFsZjN4cHNvbEV1Mm56SFpuekNZVVRweDZaSzc3ZG8x?= =?utf-8?B?ZjByOEtjNzVWNlUrMkloRXQrbXVBYTFwZHJ5ZDJ0ZUlmTW1HbUxCVE10bXVa?= =?utf-8?B?MGQyY0RVMmtSbXBNaUVlZ0lwYzAyV25hZGFUYlIrMmFYYnAxeUdOR2lVZVpv?= =?utf-8?B?NDVURDIvbTRhSDZmdm9xNHRRUVJGMmVBWllPVWpmRjZZUFZGQWFKOGJzSjdz?= =?utf-8?B?RldDVjRMcnVMbFVjc3JBdVJVVk44TTFlWXp5TTBMY1A5REJOZ2dhOHNFZkQ1?= =?utf-8?B?YmJNcE03cFZxYi9zVm5CK1hLWXpYUlJnS2s4SEZEQ3JJVDRMRlUvYzFYQ2lX?= =?utf-8?B?STAxTFFWeHRlZXZnZFA0eVVHUDU0NVNlbm1Nc0pzaVk1U3Y2OVNma0hkVUJl?= =?utf-8?B?RjFOK3BKam4wNlNaRnZmQkNEU3Y2RVhtbXQ0bWJhbkRsR0VKN0dwM0JJS0sr?= =?utf-8?B?Y0RiNWpGL3ZIbWJDNjN0ZHE4a3FhMkl4MU9TZWl2UVl5N3dSbWtOMlltU0ZN?= =?utf-8?B?ZklvUitRZHB3OEJzTGhZbjkzdXNmUTVMRFpES2JNUXRaTE8wTHY1SVp1OG0y?= =?utf-8?B?YXBad0s4M1g5bkhoUWk0RmdmbCs3djRjRlB5aWsxN29RekVodHlydlJpU3NK?= =?utf-8?B?NkVHdTZubTZqYWYwa3hKVE15bHR6aVdOVzZPdUFpMXpzditGUytrZWVKZlF1?= =?utf-8?B?MjI3NW81NmpLYjhYNWsyMDdaenZIU2IrcUlpZTcvWHI0TGVuRCsxaGUvRUN2?= =?utf-8?Q?AiTRDdpW0yqUyRDbrefQ/DLVh?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a4dc718-ca4f-4675-61f7-08dc5512f132 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2024 01:51:42.5328 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yLXUAKqr9KIZri8HwVU5j55lZUUbf2625N09TNL7BQB6NjoHZBrr1eMr06mBsRHD5VxxQSVSkL7cCWOcux/6ag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9334 From: Peng Fan Add basic implementation of the SCMI v3.2 pincontrol protocol. Co-developed-by: Oleksii Moisieiev Signed-off-by: Oleksii Moisieiev Co-developed-by: Cristian Marussi Signed-off-by: Cristian Marussi Signed-off-by: Peng Fan --- drivers/firmware/arm_scmi/Makefile | 3 +- drivers/firmware/arm_scmi/driver.c | 2 + drivers/firmware/arm_scmi/pinctrl.c | 916 ++++++++++++++++++++++++++++++= ++++ drivers/firmware/arm_scmi/protocols.h | 1 + include/linux/scmi_protocol.h | 84 ++++ 5 files changed, 1005 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/arm_scmi/Makefile b/drivers/firmware/arm_scmi= /Makefile index a7bc4796519c..fd59f58ce8a2 100644 --- a/drivers/firmware/arm_scmi/Makefile +++ b/drivers/firmware/arm_scmi/Makefile @@ -10,7 +10,8 @@ scmi-transport-$(CONFIG_ARM_SCMI_TRANSPORT_SMC) +=3D smc.o scmi-transport-$(CONFIG_ARM_SCMI_HAVE_MSG) +=3D msg.o scmi-transport-$(CONFIG_ARM_SCMI_TRANSPORT_VIRTIO) +=3D virtio.o scmi-transport-$(CONFIG_ARM_SCMI_TRANSPORT_OPTEE) +=3D optee.o -scmi-protocols-y =3D base.o clock.o perf.o power.o reset.o sensors.o syste= m.o voltage.o powercap.o +scmi-protocols-y :=3D base.o clock.o perf.o power.o reset.o sensors.o syst= em.o voltage.o powercap.o +scmi-protocols-y +=3D pinctrl.o scmi-module-objs :=3D $(scmi-driver-y) $(scmi-protocols-y) $(scmi-transpor= t-y) =20 obj-$(CONFIG_ARM_SCMI_PROTOCOL) +=3D scmi-core.o diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi= /driver.c index 415e6f510057..ac2d4b19727c 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -3142,6 +3142,7 @@ static int __init scmi_driver_init(void) scmi_voltage_register(); scmi_system_register(); scmi_powercap_register(); + scmi_pinctrl_register(); =20 return platform_driver_register(&scmi_driver); } @@ -3159,6 +3160,7 @@ static void __exit scmi_driver_exit(void) scmi_voltage_unregister(); scmi_system_unregister(); scmi_powercap_unregister(); + scmi_pinctrl_unregister(); =20 scmi_transports_exit(); =20 diff --git a/drivers/firmware/arm_scmi/pinctrl.c b/drivers/firmware/arm_scm= i/pinctrl.c new file mode 100644 index 000000000000..a2a7f880d6a3 --- /dev/null +++ b/drivers/firmware/arm_scmi/pinctrl.c @@ -0,0 +1,916 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * System Control and Management Interface (SCMI) Pinctrl Protocol + * + * Copyright (C) 2024 EPAM + * Copyright 2024 NXP + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "common.h" +#include "protocols.h" + +/* Updated only after ALL the mandatory features for that version are merg= ed */ +#define SCMI_PROTOCOL_SUPPORTED_VERSION 0x10000 + +#define GET_GROUPS_NR(x) le32_get_bits((x), GENMASK(31, 16)) +#define GET_PINS_NR(x) le32_get_bits((x), GENMASK(15, 0)) +#define GET_FUNCTIONS_NR(x) le32_get_bits((x), GENMASK(15, 0)) + +#define EXT_NAME_FLAG(x) le32_get_bits((x), BIT(31)) +#define NUM_ELEMS(x) le32_get_bits((x), GENMASK(15, 0)) + +#define REMAINING(x) le32_get_bits((x), GENMASK(31, 16)) +#define RETURNED(x) le32_get_bits((x), GENMASK(11, 0)) + +#define CONFIG_FLAG_MASK GENMASK(19, 18) +#define SELECTOR_MASK GENMASK(17, 16) +#define SKIP_CONFIGS_MASK GENMASK(15, 8) +#define CONFIG_TYPE_MASK GENMASK(7, 0) + +enum scmi_pinctrl_protocol_cmd { + PINCTRL_ATTRIBUTES =3D 0x3, + PINCTRL_LIST_ASSOCIATIONS =3D 0x4, + PINCTRL_SETTINGS_GET =3D 0x5, + PINCTRL_SETTINGS_CONFIGURE =3D 0x6, + PINCTRL_REQUEST =3D 0x7, + PINCTRL_RELEASE =3D 0x8, + PINCTRL_NAME_GET =3D 0x9, + PINCTRL_SET_PERMISSIONS =3D 0xa, +}; + +struct scmi_msg_settings_conf { + __le32 identifier; + __le32 function_id; + __le32 attributes; + __le32 configs[]; +}; + +struct scmi_msg_settings_get { + __le32 identifier; + __le32 attributes; +}; + +struct scmi_resp_settings_get { + __le32 function_selected; + __le32 num_configs; + __le32 configs[]; +}; + +struct scmi_msg_pinctrl_protocol_attributes { + __le32 attributes_low; + __le32 attributes_high; +}; + +struct scmi_msg_pinctrl_attributes { + __le32 identifier; + __le32 flags; +}; + +struct scmi_resp_pinctrl_attributes { + __le32 attributes; + u8 name[SCMI_SHORT_NAME_MAX_SIZE]; +}; + +struct scmi_msg_pinctrl_list_assoc { + __le32 identifier; + __le32 flags; + __le32 index; +}; + +struct scmi_resp_pinctrl_list_assoc { + __le32 flags; + __le16 array[]; +}; + +struct scmi_msg_request { + __le32 identifier; + __le32 flags; +}; + +struct scmi_group_info { + char name[SCMI_MAX_STR_SIZE]; + bool present; + u32 *group_pins; + u32 nr_pins; +}; + +struct scmi_function_info { + char name[SCMI_MAX_STR_SIZE]; + bool present; + u32 *groups; + u32 nr_groups; +}; + +struct scmi_pin_info { + char name[SCMI_MAX_STR_SIZE]; + bool present; +}; + +struct scmi_pinctrl_info { + u32 version; + int nr_groups; + int nr_functions; + int nr_pins; + struct scmi_group_info *groups; + struct scmi_function_info *functions; + struct scmi_pin_info *pins; +}; + +static int scmi_pinctrl_attributes_get(const struct scmi_protocol_handle *= ph, + struct scmi_pinctrl_info *pi) +{ + int ret; + struct scmi_xfer *t; + struct scmi_msg_pinctrl_protocol_attributes *attr; + + ret =3D ph->xops->xfer_get_init(ph, PROTOCOL_ATTRIBUTES, 0, sizeof(*attr)= , &t); + if (ret) + return ret; + + attr =3D t->rx.buf; + + ret =3D ph->xops->do_xfer(ph, t); + if (!ret) { + pi->nr_functions =3D GET_FUNCTIONS_NR(attr->attributes_high); + pi->nr_groups =3D GET_GROUPS_NR(attr->attributes_low); + pi->nr_pins =3D GET_PINS_NR(attr->attributes_low); + if (pi->nr_pins =3D=3D 0) { + dev_warn(ph->dev, "returned zero pins\n"); + ret =3D -EINVAL; + } + } + + ph->xops->xfer_put(ph, t); + return ret; +} + +static int scmi_pinctrl_count_get(const struct scmi_protocol_handle *ph, + enum scmi_pinctrl_selector_type type) +{ + struct scmi_pinctrl_info *pi =3D ph->get_priv(ph); + + switch (type) { + case PIN_TYPE: + return pi->nr_pins; + case GROUP_TYPE: + return pi->nr_groups; + case FUNCTION_TYPE: + return pi->nr_functions; + default: + return -EINVAL; + } +} + +static int scmi_pinctrl_validate_id(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type) +{ + int value; + + value =3D scmi_pinctrl_count_get(ph, type); + if (value < 0) + return value; + + if (selector >=3D value || value =3D=3D 0) + return -EINVAL; + + return 0; +} + +static int scmi_pinctrl_attributes(const struct scmi_protocol_handle *ph, + enum scmi_pinctrl_selector_type type, + u32 selector, char *name, + u32 *n_elems) +{ + int ret; + struct scmi_xfer *t; + struct scmi_msg_pinctrl_attributes *tx; + struct scmi_resp_pinctrl_attributes *rx; + bool ext_name_flag; + + if (!name) + return -EINVAL; + + ret =3D scmi_pinctrl_validate_id(ph, selector, type); + if (ret) + return ret; + + ret =3D ph->xops->xfer_get_init(ph, PINCTRL_ATTRIBUTES, sizeof(*tx), + sizeof(*rx), &t); + if (ret) + return ret; + + tx =3D t->tx.buf; + rx =3D t->rx.buf; + tx->identifier =3D cpu_to_le32(selector); + tx->flags =3D cpu_to_le32(type); + + ret =3D ph->xops->do_xfer(ph, t); + if (!ret) { + if (n_elems) + *n_elems =3D NUM_ELEMS(rx->attributes); + + strscpy(name, rx->name, SCMI_SHORT_NAME_MAX_SIZE); + + ext_name_flag =3D !!EXT_NAME_FLAG(rx->attributes); + } + + ph->xops->xfer_put(ph, t); + + if (ret) + return ret; + /* + * If supported overwrite short name with the extended one; + * on error just carry on and use already provided short name. + */ + if (ext_name_flag) + ret =3D ph->hops->extended_name_get(ph, PINCTRL_NAME_GET, + selector, (u32 *)&type, name, + SCMI_MAX_STR_SIZE); + return ret; +} + +struct scmi_pinctrl_ipriv { + u32 selector; + enum scmi_pinctrl_selector_type type; + u32 *array; +}; + +static void iter_pinctrl_assoc_prepare_message(void *message, + u32 desc_index, + const void *priv) +{ + struct scmi_msg_pinctrl_list_assoc *msg =3D message; + const struct scmi_pinctrl_ipriv *p =3D priv; + + msg->identifier =3D cpu_to_le32(p->selector); + msg->flags =3D cpu_to_le32(p->type); + msg->index =3D cpu_to_le32(desc_index); +} + +static int iter_pinctrl_assoc_update_state(struct scmi_iterator_state *st, + const void *response, void *priv) +{ + const struct scmi_resp_pinctrl_list_assoc *r =3D response; + + st->num_returned =3D RETURNED(r->flags); + st->num_remaining =3D REMAINING(r->flags); + + return 0; +} + +static int +iter_pinctrl_assoc_process_response(const struct scmi_protocol_handle *ph, + const void *response, + struct scmi_iterator_state *st, void *priv) +{ + const struct scmi_resp_pinctrl_list_assoc *r =3D response; + struct scmi_pinctrl_ipriv *p =3D priv; + + p->array[st->desc_index + st->loop_idx] =3D + le16_to_cpu(r->array[st->loop_idx]); + + return 0; +} + +static int scmi_pinctrl_list_associations(const struct scmi_protocol_handl= e *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + u16 size, u32 *array) +{ + int ret; + void *iter; + struct scmi_iterator_ops ops =3D { + .prepare_message =3D iter_pinctrl_assoc_prepare_message, + .update_state =3D iter_pinctrl_assoc_update_state, + .process_response =3D iter_pinctrl_assoc_process_response, + }; + struct scmi_pinctrl_ipriv ipriv =3D { + .selector =3D selector, + .type =3D type, + .array =3D array, + }; + + if (!array || !size || type =3D=3D PIN_TYPE) + return -EINVAL; + + ret =3D scmi_pinctrl_validate_id(ph, selector, type); + if (ret) + return ret; + + iter =3D ph->hops->iter_response_init(ph, &ops, size, + PINCTRL_LIST_ASSOCIATIONS, + sizeof(struct scmi_msg_pinctrl_list_assoc), + &ipriv); + if (IS_ERR(iter)) + return PTR_ERR(iter); + + return ph->hops->iter_response_run(iter); +} + +struct scmi_settings_get_ipriv { + u32 selector; + enum scmi_pinctrl_selector_type type; + bool get_all; + unsigned int *nr_configs; + enum scmi_pinctrl_conf_type *config_types; + u32 *config_values; +}; + +static void +iter_pinctrl_settings_get_prepare_message(void *message, u32 desc_index, + const void *priv) +{ + struct scmi_msg_settings_get *msg =3D message; + const struct scmi_settings_get_ipriv *p =3D priv; + u32 attributes; + + attributes =3D FIELD_PREP(SELECTOR_MASK, p->type); + + if (p->get_all) { + attributes |=3D FIELD_PREP(CONFIG_FLAG_MASK, 1) | + FIELD_PREP(SKIP_CONFIGS_MASK, desc_index); + } else { + attributes |=3D FIELD_PREP(CONFIG_TYPE_MASK, p->config_types[0]); + } + + msg->attributes =3D cpu_to_le32(attributes); + msg->identifier =3D cpu_to_le32(p->selector); +} + +static int +iter_pinctrl_settings_get_update_state(struct scmi_iterator_state *st, + const void *response, void *priv) +{ + const struct scmi_resp_settings_get *r =3D response; + struct scmi_settings_get_ipriv *p =3D priv; + + if (p->get_all) { + st->num_returned =3D le32_get_bits(r->num_configs, GENMASK(7, 0)); + st->num_remaining =3D le32_get_bits(r->num_configs, GENMASK(31, 24)); + } else { + st->num_returned =3D 1; + st->num_remaining =3D 0; + } + + return 0; +} + +static int +iter_pinctrl_settings_get_process_response(const struct scmi_protocol_hand= le *ph, + const void *response, + struct scmi_iterator_state *st, + void *priv) +{ + const struct scmi_resp_settings_get *r =3D response; + struct scmi_settings_get_ipriv *p =3D priv; + u32 type =3D le32_get_bits(r->configs[st->loop_idx * 2], GENMASK(7, 0)); + u32 val =3D le32_to_cpu(r->configs[st->loop_idx * 2 + 1]); + + if (p->get_all) { + p->config_types[st->desc_index + st->loop_idx] =3D type; + } else { + if (p->config_types[0] !=3D type) + return -EINVAL; + } + + p->config_values[st->desc_index + st->loop_idx] =3D val; + ++*p->nr_configs; + + return 0; +} + +static int +scmi_pinctrl_settings_get(const struct scmi_protocol_handle *ph, u32 selec= tor, + enum scmi_pinctrl_selector_type type, + unsigned int *nr_configs, + enum scmi_pinctrl_conf_type *config_types, + u32 *config_values) +{ + int ret; + void *iter; + unsigned int max_configs =3D *nr_configs; + struct scmi_iterator_ops ops =3D { + .prepare_message =3D iter_pinctrl_settings_get_prepare_message, + .update_state =3D iter_pinctrl_settings_get_update_state, + .process_response =3D iter_pinctrl_settings_get_process_response, + }; + struct scmi_settings_get_ipriv ipriv =3D { + .selector =3D selector, + .type =3D type, + .get_all =3D (max_configs > 1), + .nr_configs =3D nr_configs, + .config_types =3D config_types, + .config_values =3D config_values, + }; + + if (!config_types || !config_values || type =3D=3D FUNCTION_TYPE) + return -EINVAL; + + ret =3D scmi_pinctrl_validate_id(ph, selector, type); + if (ret) + return ret; + + /* Prepare to count returned configs */ + *nr_configs =3D 0; + iter =3D ph->hops->iter_response_init(ph, &ops, max_configs, + PINCTRL_SETTINGS_GET, + sizeof(struct scmi_msg_settings_get), + &ipriv); + if (IS_ERR(iter)) + return PTR_ERR(iter); + + return ph->hops->iter_response_run(iter); +} + +static int scmi_pinctrl_settings_get_one(const struct scmi_protocol_handle= *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + enum scmi_pinctrl_conf_type config_type, + u32 *config_value) +{ + unsigned int nr_configs =3D 1; + + return scmi_pinctrl_settings_get(ph, selector, type, &nr_configs, + &config_type, config_value); +} + +static int scmi_pinctrl_settings_get_all(const struct scmi_protocol_handle= *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + unsigned int *nr_configs, + enum scmi_pinctrl_conf_type *config_types, + u32 *config_values) +{ + if (!nr_configs || *nr_configs =3D=3D 0) + return -EINVAL; + + return scmi_pinctrl_settings_get(ph, selector, type, nr_configs, + config_types, config_values); +} + +static int +scmi_pinctrl_settings_conf(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + u32 nr_configs, + enum scmi_pinctrl_conf_type *config_type, + u32 *config_value) +{ + struct scmi_xfer *t; + struct scmi_msg_settings_conf *tx; + u32 attributes; + int ret, i; + u32 configs_in_chunk, conf_num =3D 0; + u32 chunk; + int max_msg_size =3D ph->hops->get_max_msg_size(ph); + + if (!config_type || !config_value || type =3D=3D FUNCTION_TYPE) + return -EINVAL; + + ret =3D scmi_pinctrl_validate_id(ph, selector, type); + if (ret) + return ret; + + configs_in_chunk =3D (max_msg_size - sizeof(*tx)) / (sizeof(__le32) * 2); + while (conf_num < nr_configs) { + chunk =3D (nr_configs - conf_num > configs_in_chunk) ? + configs_in_chunk : nr_configs - conf_num; + + ret =3D ph->xops->xfer_get_init(ph, PINCTRL_SETTINGS_CONFIGURE, + sizeof(*tx) + + chunk * 2 * sizeof(__le32), 0, &t); + if (ret) + break; + + tx =3D t->tx.buf; + tx->identifier =3D cpu_to_le32(selector); + tx->function_id =3D cpu_to_le32(0xFFFFFFFF); + attributes =3D FIELD_PREP(GENMASK(1, 0), type) | + FIELD_PREP(GENMASK(9, 2), chunk); + tx->attributes =3D cpu_to_le32(attributes); + + for (i =3D 0; i < chunk; i++) { + tx->configs[i * 2] =3D + cpu_to_le32(config_type[conf_num + i]); + tx->configs[i * 2 + 1] =3D + cpu_to_le32(config_value[conf_num + i]); + } + + ret =3D ph->xops->do_xfer(ph, t); + + ph->xops->xfer_put(ph, t); + + if (ret) + break; + + conf_num +=3D chunk; + } + + return ret; +} + +static int scmi_pinctrl_function_select(const struct scmi_protocol_handle = *ph, + u32 group, + enum scmi_pinctrl_selector_type type, + u32 function_id) +{ + int ret; + struct scmi_xfer *t; + struct scmi_msg_settings_conf *tx; + u32 attributes; + + ret =3D scmi_pinctrl_validate_id(ph, group, type); + if (ret) + return ret; + + ret =3D ph->xops->xfer_get_init(ph, PINCTRL_SETTINGS_CONFIGURE, + sizeof(*tx), 0, &t); + if (ret) + return ret; + + tx =3D t->tx.buf; + tx->identifier =3D cpu_to_le32(group); + tx->function_id =3D cpu_to_le32(function_id); + attributes =3D FIELD_PREP(GENMASK(1, 0), type) | BIT(10); + tx->attributes =3D cpu_to_le32(attributes); + + ret =3D ph->xops->do_xfer(ph, t); + ph->xops->xfer_put(ph, t); + + return ret; +} + +static int scmi_pinctrl_request_free(const struct scmi_protocol_handle *ph, + u32 identifier, + enum scmi_pinctrl_selector_type type, + enum scmi_pinctrl_protocol_cmd cmd) +{ + int ret; + struct scmi_xfer *t; + struct scmi_msg_request *tx; + + if (type =3D=3D FUNCTION_TYPE) + return -EINVAL; + + if (cmd !=3D PINCTRL_REQUEST && cmd !=3D PINCTRL_RELEASE) + return -EINVAL; + + ret =3D scmi_pinctrl_validate_id(ph, identifier, type); + if (ret) + return ret; + + ret =3D ph->xops->xfer_get_init(ph, cmd, sizeof(*tx), 0, &t); + if (ret) + return ret; + + tx =3D t->tx.buf; + tx->identifier =3D cpu_to_le32(identifier); + tx->flags =3D cpu_to_le32(type); + + ret =3D ph->xops->do_xfer(ph, t); + ph->xops->xfer_put(ph, t); + + return ret; +} + +static int scmi_pinctrl_pin_request(const struct scmi_protocol_handle *ph, + u32 pin) +{ + return scmi_pinctrl_request_free(ph, pin, PIN_TYPE, PINCTRL_REQUEST); +} + +static int scmi_pinctrl_pin_free(const struct scmi_protocol_handle *ph, u3= 2 pin) +{ + return scmi_pinctrl_request_free(ph, pin, PIN_TYPE, PINCTRL_RELEASE); +} + +static int scmi_pinctrl_get_group_info(const struct scmi_protocol_handle *= ph, + u32 selector, + struct scmi_group_info *group) +{ + int ret; + + ret =3D scmi_pinctrl_attributes(ph, GROUP_TYPE, selector, group->name, + &group->nr_pins); + if (ret) + return ret; + + if (!group->nr_pins) { + dev_err(ph->dev, "Group %d has 0 elements", selector); + return -ENODATA; + } + + group->group_pins =3D kmalloc_array(group->nr_pins, + sizeof(*group->group_pins), + GFP_KERNEL); + if (!group->group_pins) + return -ENOMEM; + + ret =3D scmi_pinctrl_list_associations(ph, selector, GROUP_TYPE, + group->nr_pins, group->group_pins); + if (ret) { + kfree(group->group_pins); + return ret; + } + + group->present =3D true; + return 0; +} + +static int scmi_pinctrl_get_group_name(const struct scmi_protocol_handle *= ph, + u32 selector, const char **name) +{ + struct scmi_pinctrl_info *pi =3D ph->get_priv(ph); + + if (!name) + return -EINVAL; + + if (selector >=3D pi->nr_groups || pi->nr_groups =3D=3D 0) + return -EINVAL; + + if (!pi->groups[selector].present) { + int ret; + + ret =3D scmi_pinctrl_get_group_info(ph, selector, + &pi->groups[selector]); + if (ret) + return ret; + } + + *name =3D pi->groups[selector].name; + + return 0; +} + +static int scmi_pinctrl_group_pins_get(const struct scmi_protocol_handle *= ph, + u32 selector, const u32 **pins, + u32 *nr_pins) +{ + struct scmi_pinctrl_info *pi =3D ph->get_priv(ph); + + if (!pins || !nr_pins) + return -EINVAL; + + if (selector >=3D pi->nr_groups || pi->nr_groups =3D=3D 0) + return -EINVAL; + + if (!pi->groups[selector].present) { + int ret; + + ret =3D scmi_pinctrl_get_group_info(ph, selector, + &pi->groups[selector]); + if (ret) + return ret; + } + + *pins =3D pi->groups[selector].group_pins; + *nr_pins =3D pi->groups[selector].nr_pins; + + return 0; +} + +static int scmi_pinctrl_get_function_info(const struct scmi_protocol_handl= e *ph, + u32 selector, + struct scmi_function_info *func) +{ + int ret; + + ret =3D scmi_pinctrl_attributes(ph, FUNCTION_TYPE, selector, func->name, + &func->nr_groups); + if (ret) + return ret; + + if (!func->nr_groups) { + dev_err(ph->dev, "Function %d has 0 elements", selector); + return -ENODATA; + } + + func->groups =3D kmalloc_array(func->nr_groups, sizeof(*func->groups), + GFP_KERNEL); + if (!func->groups) + return -ENOMEM; + + ret =3D scmi_pinctrl_list_associations(ph, selector, FUNCTION_TYPE, + func->nr_groups, func->groups); + if (ret) { + kfree(func->groups); + return ret; + } + + func->present =3D true; + return 0; +} + +static int scmi_pinctrl_get_function_name(const struct scmi_protocol_handl= e *ph, + u32 selector, const char **name) +{ + struct scmi_pinctrl_info *pi =3D ph->get_priv(ph); + + if (!name) + return -EINVAL; + + if (selector >=3D pi->nr_functions || pi->nr_functions =3D=3D 0) + return -EINVAL; + + if (!pi->functions[selector].present) { + int ret; + + ret =3D scmi_pinctrl_get_function_info(ph, selector, + &pi->functions[selector]); + if (ret) + return ret; + } + + *name =3D pi->functions[selector].name; + return 0; +} + +static int +scmi_pinctrl_function_groups_get(const struct scmi_protocol_handle *ph, + u32 selector, u32 *nr_groups, + const u32 **groups) +{ + struct scmi_pinctrl_info *pi =3D ph->get_priv(ph); + + if (!groups || !nr_groups) + return -EINVAL; + + if (selector >=3D pi->nr_functions || pi->nr_functions =3D=3D 0) + return -EINVAL; + + if (!pi->functions[selector].present) { + int ret; + + ret =3D scmi_pinctrl_get_function_info(ph, selector, + &pi->functions[selector]); + if (ret) + return ret; + } + + *groups =3D pi->functions[selector].groups; + *nr_groups =3D pi->functions[selector].nr_groups; + + return 0; +} + +static int scmi_pinctrl_mux_set(const struct scmi_protocol_handle *ph, + u32 selector, u32 group) +{ + return scmi_pinctrl_function_select(ph, group, GROUP_TYPE, selector); +} + +static int scmi_pinctrl_get_pin_info(const struct scmi_protocol_handle *ph, + u32 selector, struct scmi_pin_info *pin) +{ + int ret; + + if (!pin) + return -EINVAL; + + ret =3D scmi_pinctrl_attributes(ph, PIN_TYPE, selector, pin->name, NULL); + if (ret) + return ret; + + pin->present =3D true; + return 0; +} + +static int scmi_pinctrl_get_pin_name(const struct scmi_protocol_handle *ph, + u32 selector, const char **name) +{ + struct scmi_pinctrl_info *pi =3D ph->get_priv(ph); + + if (!name) + return -EINVAL; + + if (selector >=3D pi->nr_pins) + return -EINVAL; + + if (!pi->pins[selector].present) { + int ret; + + ret =3D scmi_pinctrl_get_pin_info(ph, selector, &pi->pins[selector]); + if (ret) + return ret; + } + + *name =3D pi->pins[selector].name; + + return 0; +} + +static int scmi_pinctrl_name_get(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + const char **name) +{ + switch (type) { + case PIN_TYPE: + return scmi_pinctrl_get_pin_name(ph, selector, name); + case GROUP_TYPE: + return scmi_pinctrl_get_group_name(ph, selector, name); + case FUNCTION_TYPE: + return scmi_pinctrl_get_function_name(ph, selector, name); + default: + return -EINVAL; + } +} + +static const struct scmi_pinctrl_proto_ops pinctrl_proto_ops =3D { + .count_get =3D scmi_pinctrl_count_get, + .name_get =3D scmi_pinctrl_name_get, + .group_pins_get =3D scmi_pinctrl_group_pins_get, + .function_groups_get =3D scmi_pinctrl_function_groups_get, + .mux_set =3D scmi_pinctrl_mux_set, + .settings_get_one =3D scmi_pinctrl_settings_get_one, + .settings_get_all =3D scmi_pinctrl_settings_get_all, + .settings_conf =3D scmi_pinctrl_settings_conf, + .pin_request =3D scmi_pinctrl_pin_request, + .pin_free =3D scmi_pinctrl_pin_free, +}; + +static int scmi_pinctrl_protocol_init(const struct scmi_protocol_handle *p= h) +{ + int ret; + u32 version; + struct scmi_pinctrl_info *pinfo; + + ret =3D ph->xops->version_get(ph, &version); + if (ret) + return ret; + + dev_dbg(ph->dev, "Pinctrl Version %d.%d\n", + PROTOCOL_REV_MAJOR(version), PROTOCOL_REV_MINOR(version)); + + pinfo =3D devm_kzalloc(ph->dev, sizeof(*pinfo), GFP_KERNEL); + if (!pinfo) + return -ENOMEM; + + ret =3D scmi_pinctrl_attributes_get(ph, pinfo); + if (ret) + return ret; + + pinfo->pins =3D devm_kcalloc(ph->dev, pinfo->nr_pins, + sizeof(*pinfo->pins), GFP_KERNEL); + if (!pinfo->pins) + return -ENOMEM; + + pinfo->groups =3D devm_kcalloc(ph->dev, pinfo->nr_groups, + sizeof(*pinfo->groups), GFP_KERNEL); + if (!pinfo->groups) + return -ENOMEM; + + pinfo->functions =3D devm_kcalloc(ph->dev, pinfo->nr_functions, + sizeof(*pinfo->functions), GFP_KERNEL); + if (!pinfo->functions) + return -ENOMEM; + + pinfo->version =3D version; + + return ph->set_priv(ph, pinfo, version); +} + +static int scmi_pinctrl_protocol_deinit(const struct scmi_protocol_handle = *ph) +{ + int i; + struct scmi_pinctrl_info *pi =3D ph->get_priv(ph); + + /* Free groups_pins allocated in scmi_pinctrl_get_group_info */ + for (i =3D 0; i < pi->nr_groups; i++) { + if (pi->groups[i].present) { + kfree(pi->groups[i].group_pins); + pi->groups[i].present =3D false; + } + } + + /* Free groups allocated in scmi_pinctrl_get_function_info */ + for (i =3D 0; i < pi->nr_functions; i++) { + if (pi->functions[i].present) { + kfree(pi->functions[i].groups); + pi->functions[i].present =3D false; + } + } + + return 0; +} + +static const struct scmi_protocol scmi_pinctrl =3D { + .id =3D SCMI_PROTOCOL_PINCTRL, + .owner =3D THIS_MODULE, + .instance_init =3D &scmi_pinctrl_protocol_init, + .instance_deinit =3D &scmi_pinctrl_protocol_deinit, + .ops =3D &pinctrl_proto_ops, + .supported_version =3D SCMI_PROTOCOL_SUPPORTED_VERSION, +}; +DEFINE_SCMI_PROTOCOL_REGISTER_UNREGISTER(pinctrl, scmi_pinctrl) diff --git a/drivers/firmware/arm_scmi/protocols.h b/drivers/firmware/arm_s= cmi/protocols.h index 3e91536a77a3..c02cbfd2bb03 100644 --- a/drivers/firmware/arm_scmi/protocols.h +++ b/drivers/firmware/arm_scmi/protocols.h @@ -355,6 +355,7 @@ void __exit scmi_##name##_unregister(void) \ DECLARE_SCMI_REGISTER_UNREGISTER(base); DECLARE_SCMI_REGISTER_UNREGISTER(clock); DECLARE_SCMI_REGISTER_UNREGISTER(perf); +DECLARE_SCMI_REGISTER_UNREGISTER(pinctrl); DECLARE_SCMI_REGISTER_UNREGISTER(power); DECLARE_SCMI_REGISTER_UNREGISTER(reset); DECLARE_SCMI_REGISTER_UNREGISTER(sensors); diff --git a/include/linux/scmi_protocol.h b/include/linux/scmi_protocol.h index b807141acc14..5e75578706ce 100644 --- a/include/linux/scmi_protocol.h +++ b/include/linux/scmi_protocol.h @@ -737,6 +737,89 @@ struct scmi_powercap_proto_ops { u32 *power_thresh_high); }; =20 +enum scmi_pinctrl_selector_type { + PIN_TYPE =3D 0, + GROUP_TYPE, + FUNCTION_TYPE, +}; + +enum scmi_pinctrl_conf_type { + SCMI_PIN_DEFAULT =3D 0, + SCMI_PIN_BIAS_BUS_HOLD =3D 1, + SCMI_PIN_BIAS_DISABLE =3D 2, + SCMI_PIN_BIAS_HIGH_IMPEDANCE =3D 3, + SCMI_PIN_BIAS_PULL_UP =3D 4, + SCMI_PIN_BIAS_PULL_DEFAULT =3D 5, + SCMI_PIN_BIAS_PULL_DOWN =3D 6, + SCMI_PIN_DRIVE_OPEN_DRAIN =3D 7, + SCMI_PIN_DRIVE_OPEN_SOURCE =3D 8, + SCMI_PIN_DRIVE_PUSH_PULL =3D 9, + SCMI_PIN_DRIVE_STRENGTH =3D 10, + SCMI_PIN_INPUT_DEBOUNCE =3D 11, + SCMI_PIN_INPUT_MODE =3D 12, + SCMI_PIN_PULL_MODE =3D 13, + SCMI_PIN_INPUT_VALUE =3D 14, + SCMI_PIN_INPUT_SCHMITT =3D 15, + SCMI_PIN_LOW_POWER_MODE =3D 16, + SCMI_PIN_OUTPUT_MODE =3D 17, + SCMI_PIN_OUTPUT_VALUE =3D 18, + SCMI_PIN_POWER_SOURCE =3D 19, + SCMI_PIN_SLEW_RATE =3D 20, + SCMI_PIN_OEM_START =3D 192, + SCMI_PIN_OEM_END =3D 255, +}; + +/** + * struct scmi_pinctrl_proto_ops - represents the various operations provi= ded + * by SCMI Pinctrl Protocol + * + * @count_get: returns count of the registered elements in given type + * @name_get: returns name by index of given type + * @group_pins_get: returns the set of pins, assigned to the specified gro= up + * @function_groups_get: returns the set of groups, assigned to the specif= ied + * function + * @mux_set: set muxing function for groups of pins + * @settings_get_one: returns one configuration parameter for pin or group + * specified by config_type + * @settings_get_all: returns all configuration parameters for pin or group + * @settings_conf: sets the configuration parameter for pin or group + * @pin_request: aquire pin before selecting mux setting + * @pin_free: frees pin, acquired by request_pin call + */ +struct scmi_pinctrl_proto_ops { + int (*count_get)(const struct scmi_protocol_handle *ph, + enum scmi_pinctrl_selector_type type); + int (*name_get)(const struct scmi_protocol_handle *ph, u32 selector, + enum scmi_pinctrl_selector_type type, + const char **name); + int (*group_pins_get)(const struct scmi_protocol_handle *ph, + u32 selector, const unsigned int **pins, + unsigned int *nr_pins); + int (*function_groups_get)(const struct scmi_protocol_handle *ph, + u32 selector, unsigned int *nr_groups, + const unsigned int **groups); + int (*mux_set)(const struct scmi_protocol_handle *ph, u32 selector, + u32 group); + int (*settings_get_one)(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + enum scmi_pinctrl_conf_type config_type, + u32 *config_value); + int (*settings_get_all)(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + unsigned int *nr_configs, + enum scmi_pinctrl_conf_type *config_types, + u32 *config_values); + int (*settings_conf)(const struct scmi_protocol_handle *ph, + u32 selector, enum scmi_pinctrl_selector_type type, + unsigned int nr_configs, + enum scmi_pinctrl_conf_type *config_type, + u32 *config_value); + int (*pin_request)(const struct scmi_protocol_handle *ph, u32 pin); + int (*pin_free)(const struct scmi_protocol_handle *ph, u32 pin); +}; + /** * struct scmi_notify_ops - represents notifications' operations provided= by * SCMI core @@ -844,6 +927,7 @@ enum scmi_std_protocol { SCMI_PROTOCOL_RESET =3D 0x16, SCMI_PROTOCOL_VOLTAGE =3D 0x17, SCMI_PROTOCOL_POWERCAP =3D 0x18, + SCMI_PROTOCOL_PINCTRL =3D 0x19, }; =20 enum scmi_system_events { --=20 2.37.1 From nobody Sun Feb 8 17:21:06 2026 Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2131.outbound.protection.outlook.com [40.107.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B379E574; Fri, 5 Apr 2024 01:51:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.247.131 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712281911; cv=fail; b=Ifq1hRI9WfeRfb6ygE8hGrHwyqj1A16BvAJl+yxJtHzfAq8rqfSrGvMTkpOVpsHlYR6CCNi6Vuep7WxtiUCUwhemdyOHUZcFCAFH2HV+1XZ/HZnM0R+gVkoZ70HZ1ej6y7+GRhmpk5aofvha2WTDGQ4jLI0+xmipIaKVgTXwEU8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712281911; c=relaxed/simple; bh=1ttx/K+ylZQ/pr5TJ+cDOsVLuXyiYxZzI5tgqGW/sCA=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=hF6kNbEmwYS8/ewEHLHd84i4mYb5OTS7KG8YMevDiQrC5HEpiLXCqOn9Hy3ex5AykCB/eHwb5MZQUAYHKt5czdqUpRaXvVAXySd9Aua6NcJsDoiSJh2EsrSgsQo7kUJPrbspwMVdhM0x1dBeYOeXELCBeEsDekmNf2qBt32pvgk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=IkKhv8iN; arc=fail smtp.client-ip=40.107.247.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="IkKhv8iN" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hCBF/5QJY7FpawfVVAfJNFjHw+fE0u1R6BxsQ+eXWXRnBL2MFoA4bcTDT+dss2HQEwB5awhvhEFhaqsOrFFmI7IHEErvtcPb4uX/Snv1EBeKMWmxSf3wr9HfCtKAGVJXmj14qneVJxjBQN+WK90xrVxQhq9m9NpsLzx46ERIProjwvgzQ0cPEQyL/YJC85uHuZgCyVtXhvQ0X/wJ0AjvgI3rHmWBVP5Rwav8oXX1mO3j1SFTyxB0lfitSnpWpODjVFx9kaNOVSozb30AqSi335bgQCs3/hLgmPXnuPQB64PDaJOFccShAX9PsSiBCjMQ+08wJ7kEQswYLfIZBsYmdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UZpY0FB4CcuIWdsXFpbNhSUGvrVt0Nr/jyeCFpYOnlU=; b=eWTcZDeQHUweCZDq39zaQUpD+FJlO5o+hkgDx5Fu2g+n/yop0Wyvgb8vkhRy/Ve18zf51jZlq7w3wHDMVkmNCJWPmC01iwAij8BFzSxTH4P0hjZI4Vb8xYH27UXfcMPPik9z3HWNggljTbf/vRE4Q5iUx9fZzTaQekPIzX4kb9zSso32fEG2O1SdRiy80mSchEBho7tEPbqHjKlVU2UqyhLI2HtzPL2A6QLfS4gOUNWUKpzu0krWjtCCfouzDgp2hAIwJq/TbgmpIlOfqkt4Iay1RFWbB2+EY0D9Aj35CltvZlKQzpS/QJg6DIKmHbnWePPKXiBw6sjycBmR5s8Vvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UZpY0FB4CcuIWdsXFpbNhSUGvrVt0Nr/jyeCFpYOnlU=; b=IkKhv8iNwoI7+0Z0B61oZZjYYL1/S9Df6IWgIaJZLhio45vgFYsEaYnXVc51KQ/QWxdAi5WnceYGVPO5j5xWQ1b4Z/qTo4kvhzM8hFuAj3it6f4BlQ+WkbmveOrvwJAljxSPshipJstvjEjmPymE/XEMoOvSrDuqiGmorxTMttY= Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AS1PR04MB9334.eurprd04.prod.outlook.com (2603:10a6:20b:4de::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 5 Apr 2024 01:51:46 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7386.037; Fri, 5 Apr 2024 01:51:46 +0000 From: "Peng Fan (OSS)" Date: Fri, 05 Apr 2024 09:59:35 +0800 Subject: [PATCH v8 4/4] pinctrl: Implementation of the generic scmi-pinctrl driver Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240405-pinctrl-scmi-v8-4-5fc8e33871bf@nxp.com> References: <20240405-pinctrl-scmi-v8-0-5fc8e33871bf@nxp.com> In-Reply-To: <20240405-pinctrl-scmi-v8-0-5fc8e33871bf@nxp.com> To: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Dan Carpenter Cc: Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan , Oleksii Moisieiev X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1712282385; l=18244; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=AbjpOrl7yBEnYMIcYlspNvfej90dVHj0Zx/z0qnvcvQ=; b=ppGhd76dTZEbiyARreRonhXafGAg20CJ4XP2TdkrqCVpeuwmYv61D36/rCLAhxy3FBvOFNBA3 vnmrWFGfFmpCRqkJI+GOjQYTbIRMxUqwOCZxX0mvw8EJf7SM7hNW1A7 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR01CA0012.apcprd01.prod.exchangelabs.com (2603:1096:4:191::8) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AS1PR04MB9334:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oCkjkrW78NNUQeHAbYkoEh36bmn/Gc6Lc2Bm9sc23UEvlkBJ9J3AOR5Iw+c+0lyRweNAu05g+ihAjO9IoxeCL1MAWwrAtaryY8O3KdYqADe9wMz8DIZ4vd+ZRFjol+ICCcebRv0dqQIMJc8KQ+NjRgr/fT8gYK1o9vpaI44ne5Cv+r713RiVrH5Gn+7uIOF0j0lyYxHbAED3uEhmOkVN7/R8AAgvxWwFnVn6lDQ6WGII2lBom+KvPSy7wd/YARDJcIAiDYQhEDO1rlt4j2NCN1eM7cgNej+Ti3ckdKqlVF4VFUI0sqwVk2C0yeGXarcK9Ml4scO4Nl4ud2Lx1SmTKscaQz/xvxu14OHRq5Qmd8tstRp9bBPBEsF+17aWMGGtUxsekGnB9JzhfV7Y3mmHPwVRQw764BFzPqdRfD4+1iahaNpp4+X8weJTxaVnjl2Ewee6KvOpescdgPv16vFxVV3HfNyOR2FyiswzoBMk/m99uLOoZt7GN4s9daWmTvG1jG5FJ775cJVjs6I9orkwDyPeJfj/fV7DvJI2vdyyFgxVB4Ck16ikXg1et51AkHXpFihqkUdgfBeckTtcb+yXnreoV7TpwkbFZHjEiEM2foZhm/CXw6VNHsn4TiVpyWfzaTYROWk3E3WIttXqcsd/5XdGYGiZj8MI1kmLR5dk0EN0HIMod9wvvCH8oTbyUOvGp9nj4KMnS0J5M1J/R4taw1ceraoo2jzVb/F4LUH3AOg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(366007)(7416005)(52116005)(376005)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z1B2Q1hqRFhlSUVBOExPb1MvZHlDQ1FQZ0w3SDYwK29YcnVwNEl3M3VuaGtt?= =?utf-8?B?VjlVWjNCOSt0ODVtL010WkxrMmVjMGxuZ01VZFo2WlViZ2xrZ1hseGxoYTlE?= =?utf-8?B?LzdITWJiRVFKbitETnpxSjhhblkvRTd5STloWWsyaDhQcExEeUJGN2FSOU5N?= =?utf-8?B?QmlSaDVMK3FTNGZ5QXVuTlM3ZkNHMjVBVmY0bTBHVGNDU3BBTHVhWFM0ZVNi?= =?utf-8?B?VldmMkI1QTJKMVUwS0pXZzFJY3p2ZFphaGl3SDVXVklsYXFtVHdmVG1QZXgx?= =?utf-8?B?ZDRSaWN1VG50bVMxTFc4MGhIN2Zta0RaRlJHdkhCb2d6R09vSkFlTjQ4QVU0?= =?utf-8?B?SVF4S09CUTR5SUNaejdKbFl2cVIwYUhONHpkM0dndElkZGRXZzNBUWRPbDBC?= =?utf-8?B?R05SSk1nNFJZU2RjNHNEMlV6d292ejRQWVc0ckJ3WDJBbDgreVJMSU5vRDBy?= =?utf-8?B?RHNqRHRpdzZQbldSS2dpdGxmTHAwRGZFRDBiaEVNZEFORDRiRXNkOGdXMEFS?= =?utf-8?B?eXNKNlF2TmZJWTQ0MnJzNDV1bVBPNmFuTlgrZHFVT3kyN1ZEUWx1MVNlRmhU?= =?utf-8?B?YVBFOWI3VG1ubk1UdWk4L21GcktyZW5MTVJGdm41S2U1Y0NWWWJnVjBEdXhM?= =?utf-8?B?WWlkanBWTEJ3OS9mcXdHYnVxUk1mcDl2VkVQZ0ZKZURCTnhRVFdzWG9SZU5w?= =?utf-8?B?TS9pekxHd1JVbmg5U2JlUUtkMU5xb0ViZXAvM0tNR1pEdk5RQktqeE54bWV0?= =?utf-8?B?SEJkbmNRVmwwZDJvbGZaOTN0UGxXTXhZMncxalpySVBRUjNadWszOXpIS2dT?= =?utf-8?B?c3E3Tk9raWdRMXptenhFU01OL1RxaEZWdUlaZUdHeDFLZmF2S05rRWFRYlQ3?= =?utf-8?B?L3M4WWJybFhCWEo0Vytjc0ZnUkNPQVdkNmN6dW8xekc3ZW5rMzJhYWE2SmFm?= =?utf-8?B?NWZjNTNtMVYvZ01raE1kbDlNVlVaQTR0R3htSmhFM2lWR3FNbUJONm5Ha0ZQ?= =?utf-8?B?RUppc2VmakQrcC8rdzdtV01neG8yNFNqT0VLa1VRNlVWNmxLVms4NGdRSndx?= =?utf-8?B?R3FwYkxsYi9hbFBuSy9rVld1T1l6SDNkZkV4WDNuOHhxMUhPNGRmYTJOZlNs?= =?utf-8?B?T1l5UjVXOEJRMTRPaHhLZWZaRmlvSjlpK1NUZkNaU1FmaFpOSUYxSFRSS2gy?= =?utf-8?B?TlpYQk9PV2ZPRmxXU2RlU3cyblAzTG44U2ZKR1RWUU1FSVJMV0g1cHo5cGdR?= =?utf-8?B?Z2gvNUphKys4ZlVDQXYzNzVKa09OTEhuOTEzZVE2d1VJZFdNa0JaT0lTQUVw?= =?utf-8?B?cXFNSytzN3dGR25CWndEYjV6Y3hkdFQxeEF5ZW5xNEZPdnZUVUVzM25peURY?= =?utf-8?B?enJkVjNqQzF3QkR5WWd1TnRieEdiM3FxcGJLMGh4YTBWcHNidkczMzU4S2NF?= =?utf-8?B?bHorOEdtYmxCUjE5akMrSjBaMjF6dE45cEJqVHIxeVd3aWROTXFJd01TQXds?= =?utf-8?B?QW9LemFIZHdVTjlvd2NiTnBJeFgwdHRlZlVNRkZlNENKZm9VUndrcVNuNkhE?= =?utf-8?B?S2ExTEl0RGdMNi9KR3oycmZFZ21wWnB3WkRMbnF2WHc4MDR1L0NObWdIVi9C?= =?utf-8?B?dmtrelN1NHpHYlFjR2lsSnEySTNEK2VHRmp4TGU0K0F5VVhtZU9IRXluZWUx?= =?utf-8?B?U1FIM0VjbzJYbUlOelZoNHlZUmROK1oxeXVpNVM3d1ZQZERJZFVzdUZKR3Fm?= =?utf-8?B?OTk4V09rSmdFa1NNbWhpeE9RYjgyNWlqanJtc0t6Z212OWg4ZWRSOUZiTVVs?= =?utf-8?B?c21DRmsvdXF0N2dPRGRLdUhWZUx6QUg4OXZobmJGczhNeE53RkZ2QllUMDJX?= =?utf-8?B?LzhtOVdCUFVzbThHTzN4K2NpeVZQRW50ZzhxWlBVMm16aEZiRFRpREZURWx1?= =?utf-8?B?UVRhS0hOblZocTNTYitkREU3aXppNGp6MTJGOEJjTDQ5WkNKYWJ3VjVCQ1px?= =?utf-8?B?OW1qNkJiNjNRWVI0NFFLTnl0TmFrUEVraGpMY2k1TW9VT1J0KzdJUDBiVkhV?= =?utf-8?B?b2JWUFJIZmZyS3V1ZlZ4Z2o3d0ZwTTdMUWtoMnBWbytBZUlXYlBUY0JkdVNo?= =?utf-8?Q?ftfj1Tlz4PONcDAGzMr2i3DoM?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73bef76d-0b8b-4708-b218-08dc5512f3b6 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2024 01:51:46.8209 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w0MSOLuC7n7qalFSpMtYjkt1NeVI/0u+kUfyBbO9WduhCA2e6Luk4sZszMldsGlRcTqzup/v+HYkHMaOyn+41g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9334 From: Peng Fan scmi-pinctrl driver implements pinctrl driver interface and using SCMI protocol to redirect messages from pinctrl subsystem SDK to SCMI platform firmware, which does the changes in HW. Co-developed-by: Oleksii Moisieiev Signed-off-by: Oleksii Moisieiev Signed-off-by: Peng Fan --- MAINTAINERS | 1 + drivers/pinctrl/Kconfig | 11 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/pinctrl-scmi.c | 564 +++++++++++++++++++++++++++++++++++++= ++++ 4 files changed, 577 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4b511a55101c..d8270ac6651a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -21457,6 +21457,7 @@ F: drivers/cpufreq/sc[mp]i-cpufreq.c F: drivers/firmware/arm_scmi/ F: drivers/firmware/arm_scpi.c F: drivers/hwmon/scmi-hwmon.c +F: drivers/pinctrl/pinctrl-scmi.c F: drivers/pmdomain/arm/ F: drivers/powercap/arm_scmi_powercap.c F: drivers/regulator/scmi-regulator.c diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index d45657aa986a..4e6f65cf0e76 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -450,6 +450,17 @@ config PINCTRL_ROCKCHIP help This support pinctrl and GPIO driver for Rockchip SoCs. =20 +config PINCTRL_SCMI + tristate "Pinctrl driver using SCMI protocol interface" + depends on ARM_SCMI_PROTOCOL || COMPILE_TEST + select PINMUX + select GENERIC_PINCONF + help + This driver provides support for pinctrl which is controlled + by firmware that implements the SCMI interface. + It uses SCMI Message Protocol to interact with the + firmware providing all the pinctrl controls. + config PINCTRL_SINGLE tristate "One-register-per-pin type device tree based pinctrl driver" depends on OF diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile index 2152539b53d5..cc809669405a 100644 --- a/drivers/pinctrl/Makefile +++ b/drivers/pinctrl/Makefile @@ -45,6 +45,7 @@ obj-$(CONFIG_PINCTRL_PIC32) +=3D pinctrl-pic32.o obj-$(CONFIG_PINCTRL_PISTACHIO) +=3D pinctrl-pistachio.o obj-$(CONFIG_PINCTRL_RK805) +=3D pinctrl-rk805.o obj-$(CONFIG_PINCTRL_ROCKCHIP) +=3D pinctrl-rockchip.o +obj-$(CONFIG_PINCTRL_SCMI) +=3D pinctrl-scmi.o obj-$(CONFIG_PINCTRL_SINGLE) +=3D pinctrl-single.o obj-$(CONFIG_PINCTRL_ST) +=3D pinctrl-st.o obj-$(CONFIG_PINCTRL_STMFX) +=3D pinctrl-stmfx.o diff --git a/drivers/pinctrl/pinctrl-scmi.c b/drivers/pinctrl/pinctrl-scmi.c new file mode 100644 index 000000000000..0f55f000a679 --- /dev/null +++ b/drivers/pinctrl/pinctrl-scmi.c @@ -0,0 +1,564 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * System Control and Power Interface (SCMI) Protocol based pinctrl driver + * + * Copyright (C) 2024 EPAM + * Copyright 2024 NXP + */ + +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include + +#include "pinctrl-utils.h" +#include "core.h" +#include "pinconf.h" + +#define DRV_NAME "scmi-pinctrl" + +/* Define num configs, if not large than 4 use stack, else use kcalloc */ +#define SCMI_NUM_CONFIGS 4 + +static const struct scmi_pinctrl_proto_ops *pinctrl_ops; + +struct scmi_pinctrl { + struct device *dev; + struct scmi_protocol_handle *ph; + struct pinctrl_dev *pctldev; + struct pinctrl_desc pctl_desc; + struct pinfunction *functions; + unsigned int nr_functions; + struct pinctrl_pin_desc *pins; + unsigned int nr_pins; +}; + +static int pinctrl_scmi_get_groups_count(struct pinctrl_dev *pctldev) +{ + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->count_get(pmx->ph, GROUP_TYPE); +} + +static const char *pinctrl_scmi_get_group_name(struct pinctrl_dev *pctldev, + unsigned int selector) +{ + int ret; + const char *name; + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + + ret =3D pinctrl_ops->name_get(pmx->ph, selector, GROUP_TYPE, &name); + if (ret) { + dev_err(pmx->dev, "get name failed with err %d", ret); + return NULL; + } + + return name; +} + +static int pinctrl_scmi_get_group_pins(struct pinctrl_dev *pctldev, + unsigned int selector, + const unsigned int **pins, + unsigned int *num_pins) +{ + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->group_pins_get(pmx->ph, selector, pins, num_pins); +} + +static const struct pinctrl_ops pinctrl_scmi_pinctrl_ops =3D { + .get_groups_count =3D pinctrl_scmi_get_groups_count, + .get_group_name =3D pinctrl_scmi_get_group_name, + .get_group_pins =3D pinctrl_scmi_get_group_pins, +#ifdef CONFIG_OF + .dt_node_to_map =3D pinconf_generic_dt_node_to_map_all, + .dt_free_map =3D pinconf_generic_dt_free_map, +#endif +}; + +static int pinctrl_scmi_get_functions_count(struct pinctrl_dev *pctldev) +{ + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->count_get(pmx->ph, FUNCTION_TYPE); +} + +static const char *pinctrl_scmi_get_function_name(struct pinctrl_dev *pctl= dev, + unsigned int selector) +{ + int ret; + const char *name; + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + + ret =3D pinctrl_ops->name_get(pmx->ph, selector, FUNCTION_TYPE, &name); + if (ret) { + dev_err(pmx->dev, "get name failed with err %d", ret); + return NULL; + } + + return name; +} + +static int pinctrl_scmi_get_function_groups(struct pinctrl_dev *pctldev, + unsigned int selector, + const char * const **p_groups, + unsigned int * const p_num_groups) +{ + struct pinfunction *func; + const unsigned int *group_ids; + unsigned int num_groups; + const char **groups; + int ret, i; + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + + if (!p_groups || !p_num_groups) + return -EINVAL; + + if (selector >=3D pmx->nr_functions) + return -EINVAL; + + func =3D &pmx->functions[selector]; + if (func->ngroups) + goto done; + + ret =3D pinctrl_ops->function_groups_get(pmx->ph, selector, &num_groups, + &group_ids); + if (ret) { + dev_err(pmx->dev, "Unable to get function groups, err %d", ret); + return ret; + } + if (!num_groups) + return -EINVAL; + + groups =3D kcalloc(num_groups, sizeof(*groups), GFP_KERNEL); + if (!groups) + return -ENOMEM; + + for (i =3D 0; i < num_groups; i++) { + groups[i] =3D pinctrl_scmi_get_group_name(pctldev, group_ids[i]); + if (!groups[i]) { + ret =3D -EINVAL; + goto err_free; + } + } + + func->ngroups =3D num_groups; + func->groups =3D groups; +done: + *p_groups =3D func->groups; + *p_num_groups =3D func->ngroups; + + return 0; + +err_free: + kfree(groups); + + return ret; +} + +static int pinctrl_scmi_func_set_mux(struct pinctrl_dev *pctldev, + unsigned int selector, unsigned int group) +{ + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->mux_set(pmx->ph, selector, group); +} + +static int pinctrl_scmi_request(struct pinctrl_dev *pctldev, + unsigned int offset) +{ + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->pin_request(pmx->ph, offset); +} + +static int pinctrl_scmi_free(struct pinctrl_dev *pctldev, unsigned int off= set) +{ + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->pin_free(pmx->ph, offset); +} + +static const struct pinmux_ops pinctrl_scmi_pinmux_ops =3D { + .request =3D pinctrl_scmi_request, + .free =3D pinctrl_scmi_free, + .get_functions_count =3D pinctrl_scmi_get_functions_count, + .get_function_name =3D pinctrl_scmi_get_function_name, + .get_function_groups =3D pinctrl_scmi_get_function_groups, + .set_mux =3D pinctrl_scmi_func_set_mux, +}; + +static int pinctrl_scmi_map_pinconf_type(enum pin_config_param param, + enum scmi_pinctrl_conf_type *type) +{ + u32 arg =3D param; + + switch (arg) { + case PIN_CONFIG_BIAS_BUS_HOLD: + *type =3D SCMI_PIN_BIAS_BUS_HOLD; + break; + case PIN_CONFIG_BIAS_DISABLE: + *type =3D SCMI_PIN_BIAS_DISABLE; + break; + case PIN_CONFIG_BIAS_HIGH_IMPEDANCE: + *type =3D SCMI_PIN_BIAS_HIGH_IMPEDANCE; + break; + case PIN_CONFIG_BIAS_PULL_DOWN: + *type =3D SCMI_PIN_BIAS_PULL_DOWN; + break; + case PIN_CONFIG_BIAS_PULL_PIN_DEFAULT: + *type =3D SCMI_PIN_BIAS_PULL_DEFAULT; + break; + case PIN_CONFIG_BIAS_PULL_UP: + *type =3D SCMI_PIN_BIAS_PULL_UP; + break; + case PIN_CONFIG_DRIVE_OPEN_DRAIN: + *type =3D SCMI_PIN_DRIVE_OPEN_DRAIN; + break; + case PIN_CONFIG_DRIVE_OPEN_SOURCE: + *type =3D SCMI_PIN_DRIVE_OPEN_SOURCE; + break; + case PIN_CONFIG_DRIVE_PUSH_PULL: + *type =3D SCMI_PIN_DRIVE_PUSH_PULL; + break; + case PIN_CONFIG_DRIVE_STRENGTH: + *type =3D SCMI_PIN_DRIVE_STRENGTH; + break; + case PIN_CONFIG_DRIVE_STRENGTH_UA: + *type =3D SCMI_PIN_DRIVE_STRENGTH; + break; + case PIN_CONFIG_INPUT_DEBOUNCE: + *type =3D SCMI_PIN_INPUT_DEBOUNCE; + break; + case PIN_CONFIG_INPUT_ENABLE: + *type =3D SCMI_PIN_INPUT_MODE; + break; + case PIN_CONFIG_INPUT_SCHMITT: + *type =3D SCMI_PIN_INPUT_SCHMITT; + break; + case PIN_CONFIG_INPUT_SCHMITT_ENABLE: + *type =3D SCMI_PIN_INPUT_MODE; + break; + case PIN_CONFIG_MODE_LOW_POWER: + *type =3D SCMI_PIN_LOW_POWER_MODE; + break; + case PIN_CONFIG_OUTPUT: + *type =3D SCMI_PIN_OUTPUT_VALUE; + break; + case PIN_CONFIG_OUTPUT_ENABLE: + *type =3D SCMI_PIN_OUTPUT_MODE; + break; + case PIN_CONFIG_OUTPUT_IMPEDANCE_OHMS: + *type =3D SCMI_PIN_OUTPUT_VALUE; + break; + case PIN_CONFIG_POWER_SOURCE: + *type =3D SCMI_PIN_POWER_SOURCE; + break; + case PIN_CONFIG_SLEW_RATE: + *type =3D SCMI_PIN_SLEW_RATE; + break; + case SCMI_PIN_OEM_START ... SCMI_PIN_OEM_END: + *type =3D arg; + break; + default: + return -EINVAL; + } + + return 0; +} + +static int pinctrl_scmi_pinconf_get(struct pinctrl_dev *pctldev, + unsigned int pin, unsigned long *config) +{ + int ret; + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + enum pin_config_param config_type; + enum scmi_pinctrl_conf_type type; + u32 config_value; + + if (!config) + return -EINVAL; + + config_type =3D pinconf_to_config_param(*config); + + ret =3D pinctrl_scmi_map_pinconf_type(config_type, &type); + if (ret) + return ret; + + ret =3D pinctrl_ops->settings_get_one(pmx->ph, pin, PIN_TYPE, type, + &config_value); + if (ret) + return ret; + + *config =3D pinconf_to_config_packed(config_type, config_value); + + return 0; +} + +static int +pinctrl_scmi_alloc_configs(struct pinctrl_dev *pctldev, u32 num_configs, + u32 **p_config_value, + enum scmi_pinctrl_conf_type **p_config_type) +{ + if (num_configs <=3D SCMI_NUM_CONFIGS) + return 0; + + *p_config_value =3D kcalloc(num_configs, sizeof(**p_config_value), GFP_KE= RNEL); + if (!*p_config_value) + return -ENOMEM; + + *p_config_type =3D kcalloc(num_configs, sizeof(**p_config_type), GFP_KERN= EL); + if (!*p_config_type) { + kfree(*p_config_value); + return -ENOMEM; + } + + return 0; +} + +static void +pinctrl_scmi_free_configs(struct pinctrl_dev *pctldev, u32 num_configs, + u32 **p_config_value, + enum scmi_pinctrl_conf_type **p_config_type) +{ + if (num_configs <=3D SCMI_NUM_CONFIGS) + return; + + kfree(*p_config_value); + kfree(*p_config_type); +} + +static int pinctrl_scmi_pinconf_set(struct pinctrl_dev *pctldev, + unsigned int pin, + unsigned long *configs, + unsigned int num_configs) +{ + int i, ret; + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + enum scmi_pinctrl_conf_type config_type[SCMI_NUM_CONFIGS]; + u32 config_value[SCMI_NUM_CONFIGS]; + enum scmi_pinctrl_conf_type *p_config_type =3D config_type; + u32 *p_config_value =3D config_value; + enum pin_config_param param; + + if (!configs || !num_configs) + return -EINVAL; + + ret =3D pinctrl_scmi_alloc_configs(pctldev, num_configs, &p_config_type, + &p_config_value); + if (ret) + return ret; + + for (i =3D 0; i < num_configs; i++) { + param =3D pinconf_to_config_param(configs[i]); + ret =3D pinctrl_scmi_map_pinconf_type(param, &p_config_type[i]); + if (ret) { + dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); + goto free_config; + } + p_config_value[i] =3D pinconf_to_config_argument(configs[i]); + } + + ret =3D pinctrl_ops->settings_conf(pmx->ph, pin, PIN_TYPE, num_configs, + p_config_type, p_config_value); + if (ret) + dev_err(pmx->dev, "Error parsing config %d\n", ret); + +free_config: + pinctrl_scmi_free_configs(pctldev, num_configs, &p_config_type, + &p_config_value); + return ret; +} + +static int pinctrl_scmi_pinconf_group_set(struct pinctrl_dev *pctldev, + unsigned int group, + unsigned long *configs, + unsigned int num_configs) +{ + int i, ret; + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + enum scmi_pinctrl_conf_type config_type[SCMI_NUM_CONFIGS]; + u32 config_value[SCMI_NUM_CONFIGS]; + enum scmi_pinctrl_conf_type *p_config_type =3D config_type; + u32 *p_config_value =3D config_value; + enum pin_config_param param; + + if (!configs || !num_configs) + return -EINVAL; + + ret =3D pinctrl_scmi_alloc_configs(pctldev, num_configs, &p_config_type, + &p_config_value); + if (ret) + return ret; + + for (i =3D 0; i < num_configs; i++) { + param =3D pinconf_to_config_param(configs[i]); + ret =3D pinctrl_scmi_map_pinconf_type(param, &p_config_type[i]); + if (ret) { + dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); + goto free_config; + } + + p_config_value[i] =3D pinconf_to_config_argument(configs[i]); + } + + ret =3D pinctrl_ops->settings_conf(pmx->ph, group, GROUP_TYPE, + num_configs, p_config_type, + p_config_value); + if (ret) + dev_err(pmx->dev, "Error parsing config %d", ret); + +free_config: + pinctrl_scmi_free_configs(pctldev, num_configs, &p_config_type, + &p_config_value); + return ret; +}; + +static int pinctrl_scmi_pinconf_group_get(struct pinctrl_dev *pctldev, + unsigned int group, + unsigned long *config) +{ + int ret; + struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); + enum pin_config_param config_type; + enum scmi_pinctrl_conf_type type; + u32 config_value; + + if (!config) + return -EINVAL; + + config_type =3D pinconf_to_config_param(*config); + ret =3D pinctrl_scmi_map_pinconf_type(config_type, &type); + if (ret) { + dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); + return ret; + } + + ret =3D pinctrl_ops->settings_get_one(pmx->ph, group, GROUP_TYPE, type, + &config_value); + if (ret) + return ret; + + *config =3D pinconf_to_config_packed(config_type, config_value); + + return 0; +} + +static const struct pinconf_ops pinctrl_scmi_pinconf_ops =3D { + .is_generic =3D true, + .pin_config_get =3D pinctrl_scmi_pinconf_get, + .pin_config_set =3D pinctrl_scmi_pinconf_set, + .pin_config_group_set =3D pinctrl_scmi_pinconf_group_set, + .pin_config_group_get =3D pinctrl_scmi_pinconf_group_get, + .pin_config_config_dbg_show =3D pinconf_generic_dump_config, +}; + +static int pinctrl_scmi_get_pins(struct scmi_pinctrl *pmx, + struct pinctrl_desc *desc) +{ + struct pinctrl_pin_desc *pins; + unsigned int npins; + int ret, i; + + npins =3D pinctrl_ops->count_get(pmx->ph, PIN_TYPE); + /* + * npins will never be zero, the scmi pinctrl driver has bailed out + * if npins is zero. + */ + pins =3D devm_kmalloc_array(pmx->dev, npins, sizeof(*pins), GFP_KERNEL); + if (!pins) + return -ENOMEM; + + for (i =3D 0; i < npins; i++) { + pins[i].number =3D i; + /* + * The memory for name is handled by the scmi firmware driver, + * no need free here + */ + ret =3D pinctrl_ops->name_get(pmx->ph, i, PIN_TYPE, &pins[i].name); + if (ret) + return dev_err_probe(pmx->dev, ret, + "Can't get name for pin %d", i); + } + + desc->npins =3D npins; + desc->pins =3D pins; + dev_dbg(pmx->dev, "got pins %u", npins); + + return 0; +} + +static int scmi_pinctrl_probe(struct scmi_device *sdev) +{ + int ret; + struct device *dev =3D &sdev->dev; + struct scmi_pinctrl *pmx; + const struct scmi_handle *handle; + struct scmi_protocol_handle *ph; + + if (!sdev->handle) + return -EINVAL; + + handle =3D sdev->handle; + + pinctrl_ops =3D handle->devm_protocol_get(sdev, SCMI_PROTOCOL_PINCTRL, &p= h); + if (IS_ERR(pinctrl_ops)) + return PTR_ERR(pinctrl_ops); + + pmx =3D devm_kzalloc(dev, sizeof(*pmx), GFP_KERNEL); + if (!pmx) + return -ENOMEM; + + pmx->ph =3D ph; + + pmx->dev =3D dev; + pmx->pctl_desc.name =3D DRV_NAME; + pmx->pctl_desc.owner =3D THIS_MODULE; + pmx->pctl_desc.pctlops =3D &pinctrl_scmi_pinctrl_ops; + pmx->pctl_desc.pmxops =3D &pinctrl_scmi_pinmux_ops; + pmx->pctl_desc.confops =3D &pinctrl_scmi_pinconf_ops; + + ret =3D pinctrl_scmi_get_pins(pmx, &pmx->pctl_desc); + if (ret) + return ret; + + ret =3D devm_pinctrl_register_and_init(dev, &pmx->pctl_desc, pmx, + &pmx->pctldev); + if (ret) + return dev_err_probe(dev, ret, "Failed to register pinctrl\n"); + + pmx->nr_functions =3D pinctrl_scmi_get_functions_count(pmx->pctldev); + pmx->functions =3D devm_kcalloc(dev, pmx->nr_functions, + sizeof(*pmx->functions), GFP_KERNEL); + if (!pmx->functions) + return -ENOMEM; + + return pinctrl_enable(pmx->pctldev); +} + +static const struct scmi_device_id scmi_id_table[] =3D { + { SCMI_PROTOCOL_PINCTRL, "pinctrl" }, + { } +}; +MODULE_DEVICE_TABLE(scmi, scmi_id_table); + +static struct scmi_driver scmi_pinctrl_driver =3D { + .name =3D DRV_NAME, + .probe =3D scmi_pinctrl_probe, + .id_table =3D scmi_id_table, +}; +module_scmi_driver(scmi_pinctrl_driver); + +MODULE_AUTHOR("Oleksii Moisieiev "); +MODULE_AUTHOR("Peng Fan "); +MODULE_DESCRIPTION("ARM SCMI pin controller driver"); +MODULE_LICENSE("GPL"); --=20 2.37.1