From nobody Mon Feb 9 13:39:18 2026 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B3BB757FA for ; Thu, 4 Apr 2024 10:08:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712225293; cv=none; b=pARZo/NkAFq7gcv0kcT3Ak8tJmohsV4ui/KdehRqT2BRwBY3f4KMKWZOHNom4a7W71Bmwo50p0btvC9ux1Nc7jcng20Jlany3+nMAHuekdsLz4j2XQFK5JA+t6XEKlnXW8lsZEgiRmKo4hX7jgLbBZkldhSyq4WH1zEGAIQ/ERs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712225293; c=relaxed/simple; bh=xtfhuUTM99xHxoMeoYk5bzlIduxzhp/GTlxP2mkYgaY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ugcxyvkguKGlwLHbUIac6mdLjg852HEz9Ts3JBZymqfaZuF8kYM7chp0344fWCsTOQCmz2i3z9ZUtaxywzUneNztpxlAjDTPm8n5euj+Mq6cLUYNYJ4TovAeyheyBCQ4KiC1VBc8x7gMGLpOS6drOKlpP76Rt9JLMQXFrgJXwEU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bdP8f0jv; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bdP8f0jv" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-56e1baf0380so709297a12.3 for ; Thu, 04 Apr 2024 03:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712225289; x=1712830089; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Dp8USTzsG3ntp/LxWp9gHMeUcZJjL0z8l7/Rhp/dYWg=; b=bdP8f0jvBZzFFGLvxufeHDfpNSFBNDnFaZWURYpoV9OcBfvUkIDRiFF0qmCTIlVhbC xTkisHlyHE2pYA0J9w1TtP6HaFf6NH3Ih+ITuS+ewGnPFEtX7SELM+rFiXng0GT9MhRV 5CD/WXtSLDI/kzrP5H6pQd/K8UD9prWxY8qGBvpsQEqfFHO8u6YY93nYyxXPoMiG04gL enpR0CobxVw4/Ry5mD/yPqQcvvBmmDcKGiuPi4DVVgf9uP4nc0pSm2tUewVJvKi46qGX BPakQIUHDqazePcyZEu2muIjZ7y+m3r6/oBPXrhMOvhnj0KYwEi6Upe7RNnO7cLCHshV g3jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712225289; x=1712830089; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Dp8USTzsG3ntp/LxWp9gHMeUcZJjL0z8l7/Rhp/dYWg=; b=vlsMQ+mhkmEZPipiwf0eY7vdjmBQQdprajv1T5O2nXSdksSN7mprASAfcul1OC3PFR H3fEp67hPuK+dHvwzVGno69Z3xw+Vf+reY813FDrNIbIkSzL1foGVEdduZd1DeKbxX3E SZmzrt1twsYEqzUORnsEe1Pudz/oaDgEh1Wfr6tnaSpsn98va5K4vPDoVAZtFmqMuDr3 ktZWSSN8Hs0J0corH8/FCcNaLNLv+Qdl8byFh0IAGCVO/Le0/HtwP4OpxAVu77TRoTQv YWnewIJ5iwPjrmopmkhRwnwJq9IK3zDQbHtWcKbveASQUo0ke8E86mfwgKAKWPmLbblC yW6Q== X-Forwarded-Encrypted: i=1; AJvYcCUdrF+OTSu0P8yHU9WAWg200Wg3uQ6FfThqNojWwlzymStaVcdHlHns84+1LNiu4wx4JpQCXC6EtQHiihUW6Nt28G10CrHCW/NVxEz6 X-Gm-Message-State: AOJu0YyE7duseaCYhxwGFrLoBeqtGO2xq2An2viJUfN8Ru4kOrICL5n/ aBKA9H8rn6U/hCoDoVYcBfDjRdfIVxiJvqofYINSmfQUxc4QsOx0B2ASx7s3ItU= X-Google-Smtp-Source: AGHT+IHpY7DJnbfRwrN+pggOgCfH6syNZv4JzFQ7NFRdr6EFSZOLNeW3eQkAhrKYCeBUc5BBBg2YBA== X-Received: by 2002:a50:d4de:0:b0:56e:df1:534a with SMTP id e30-20020a50d4de000000b0056e0df1534amr1014440edj.42.1712225288726; Thu, 04 Apr 2024 03:08:08 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id ig10-20020a056402458a00b0056c0a668316sm1984219edb.3.2024.04.04.03.08.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 03:08:08 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 04 Apr 2024 13:07:59 +0300 Subject: [PATCH 1/6] drm/panel: visionox-rm69299: don't unregister DSI device Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240404-drop-panel-unregister-v1-1-9f56953c5fb9@linaro.org> References: <20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org> In-Reply-To: <20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org> To: Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Matthias Kaehlcke , Harigovindan P , Ritesh Kumar , Sumit Semwal Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=944; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=xtfhuUTM99xHxoMeoYk5bzlIduxzhp/GTlxP2mkYgaY=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmDnwFymsormB7E2rQzeFs0/IGcTvRxMiWf2O5A yUo7xUWQCKJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZg58BQAKCRCLPIo+Aiko 1TgJB/4z75ZXyRi0GestVgdCyBjlrKyuTdUKv5EevhWnh+aLaSOFY5w85Ts/sc4S/+3rDxvdwU2 CkN/oVbiKN54mlfRaS7cm0j6/4ZpwgfPkr9H/WmkWaCG5eC8HSr4z3U46sxjNJdaj3FuUW8ouk5 h04EnLDzSFxa+NJdOnAoFE/qEWblFiPDpVFKpw/ml2sjTU1HUObnzOLZtarfPdKnp10mk7Xmgte pwYLYkrAbrUp0xySxMlW7cfEQS6poi0IhoOj0tt7YLGHJq5j5Cp7x/HwHMfaFAyrayEdvlIXJMT TQ2msvq1B4rSIXl5Ein9MwCCBaktTd8fYP5gAedMvW3SnueF X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A The DSI device for the panel was registered by the DSI host, so it is an error to unregister it from the panel driver. Drop the call to mipi_dsi_device_unregister(). Fixes: c7f66d32dd43 ("drm/panel: add support for rm69299 visionox panel") Signed-off-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-visionox-rm69299.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu/d= rm/panel/panel-visionox-rm69299.c index 775144695283..b15ca56a09a7 100644 --- a/drivers/gpu/drm/panel/panel-visionox-rm69299.c +++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c @@ -253,8 +253,6 @@ static void visionox_rm69299_remove(struct mipi_dsi_dev= ice *dsi) struct visionox_rm69299 *ctx =3D mipi_dsi_get_drvdata(dsi); =20 mipi_dsi_detach(ctx->dsi); - mipi_dsi_device_unregister(ctx->dsi); - drm_panel_remove(&ctx->panel); } =20 --=20 2.39.2 From nobody Mon Feb 9 13:39:18 2026 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D951757FD for ; Thu, 4 Apr 2024 10:08:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712225293; cv=none; b=sx2O9N1A5QEDAcN/P8pQkm6Mg9jbzXgX3CUccotzb5sr9uvf3Hz2I0vTMYiqJmyNKz4QLsIGEThyv5GaqcOoCS7WgJzGMF/zXh/uqTZtfRlYZMHo/O0fYaRJL+nCv7mVKDwHVmHlubb1EnQb2WgvkepsAt1wzfs0rctHf8SFmxM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712225293; c=relaxed/simple; bh=KIPxE7WAFkz5qGRN5hVp/Vx45cUpVvzgjI6wREzKChI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=twOuS9BJtyvpDV6s7Snt/vmF9cBuNMooVn88S0qYEYTcLJieQg/PKCNZnp6694NrX/H1BiCvtNrYyGdHV4aXFi/9ZkCYytkAcGvWSgkTf+vxWmCGLSG8DmugShCNXWBqnnsPRgL1z6pzwuiCV5LEhBAlVN59RTlEpu+VFuQ2ahc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=NEhjYnRO; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NEhjYnRO" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a4e79d7d21dso52456266b.1 for ; Thu, 04 Apr 2024 03:08:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712225290; x=1712830090; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DOrh7Irjq4f+bzjvRmtdFPtj9HsVRJ5Kf8V2j16C7zQ=; b=NEhjYnROciz/IepXDfxlz/A23LWh14iXuHfhrwib3ovC8SglvN3HkQx+cFa3596rYD rITiJf46wWCfmBEtj3rMWEHEUVAmfR50/JAtc5DQn2L9cKy3yPsF/WRVXLjVGuNpjCQp IPW/7RQUP+KptOMfUTSLOCLmSAwZXliNRXkiRKJCR44crfhQGZITCJ+zRdI1uFU/l4mf gbNHvMBPU94b8Hb9nqtRNBNHJ6GeSv3uZjaGfKo8+lwneJJigwaSwivigNi021IXmRfs kjdzBF3TKZzUzMJYreujJfKwHArQC54XW1hPcAoRzEUTGQPVECs2A+oSJskGCz83/cVT kzIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712225290; x=1712830090; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DOrh7Irjq4f+bzjvRmtdFPtj9HsVRJ5Kf8V2j16C7zQ=; b=O5xxapu6pLqr2/1aYtMelrMfnBeJAxX/guhQTHRuIXk9QYqn382WJqYv66/BCRR3Dc qeMlGW5BGbe2sMepmOqHKuoJBimDg5MCggIR0l7HxRzu29O6VTKVi3A+LipdcyQ6qpMB XXGL7WblPwalV6tgwcmyyIrZ980Jatwhv9J7+WcpjuqB9b3MmfrtUm3ZGuZRN6tRMoWN AzQwnfw3eXn4c+LIi38nTnIL3rDI6Hs2QsvI9Ah87NazXEYuwWZEbHjEQ6tLYFT7DEOI jdoNl9LmW7M6mMHBlTOR2AVT6bQ345SlGfyQ2iEgKxmcxsoSBGGOZhFE22B7FjV/MkqT cFRQ== X-Forwarded-Encrypted: i=1; AJvYcCWSZpEgsX+c+jYn7hj4erL6jKLW46o/QggHtMH9hUDe9riM5cLlEm92BCU2PO+FY3mV39gpLQGCOxqE9Pld8ir58Fel60KyTMiQSieJ X-Gm-Message-State: AOJu0YxokIQVfwYujPmjeVlHzuVkK0Gr6CBbp08z8bmxNzSrmK+UmiK3 xEPPPnVQfPutvnkIKIKnds7D1O5UTzPydwe+T0laulIlEmIB/5KzjCeog5gT3ZY= X-Google-Smtp-Source: AGHT+IFFx0jNeXxS8p/PVfSfopzv8XenHyOICPv85lhOjQmeM3QgrFtbE28snmGj70mzNCw3CZotQw== X-Received: by 2002:a50:d596:0:b0:56e:a2f:34ef with SMTP id v22-20020a50d596000000b0056e0a2f34efmr1734540edi.11.1712225289818; Thu, 04 Apr 2024 03:08:09 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id ig10-20020a056402458a00b0056c0a668316sm1984219edb.3.2024.04.04.03.08.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 03:08:09 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 04 Apr 2024 13:08:00 +0300 Subject: [PATCH 2/6] drm/panel: novatek-nt36682e: don't unregister DSI device Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240404-drop-panel-unregister-v1-2-9f56953c5fb9@linaro.org> References: <20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org> In-Reply-To: <20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org> To: Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Matthias Kaehlcke , Harigovindan P , Ritesh Kumar , Sumit Semwal Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=947; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=KIPxE7WAFkz5qGRN5hVp/Vx45cUpVvzgjI6wREzKChI=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQxpfDSv7hI3TUjp563fNvq67k9crjWPPPcY5oismPevXW RaeJfuvk9GYhYGRi0FWTJHFp6Blasym5LAPO6bWwwxiZQKZwsDFKQATyWNk/x9rm9pqXJBosO34 jqepk9az65ZM2LRfYa1kTVNiU8W7L1HNBzW/LgzWmLGnjj9pT2qX7c5gy28JfsKTpuzbt2iX6fE ziszrD9ybVLOTK6HEPl/JIndJSFbX/0Jpy0U/7zD9yVG0Ojv7VWNr6GZZHXOV1BeZs/8IOTbU3C +2EJrkLJ0q5Cha23P75ZErlv0+mlZZ9gL2v7fNnfy72UEmx7D23auIedxlIcz/d19X01FsmP03g 51JwLvQzf9LSWfLnMb9rjOSFlhL7TqUzNVTPkVHXuDXV8v+5JfK7YlJUWGtrZ2Z7TEy1cJHxRRs kler227qOfFAuEN3of7uTXOP8xYqtVX937MrZYLLhAIA X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A The DSI device for the panel was registered by the DSI host, so it is an error to unregister it from the panel driver. Drop the call to mipi_dsi_device_unregister(). Fixes: ea4f9975625a ("drm/panel: Add support for Novatek NT36672E panel dri= ver") Signed-off-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-novatek-nt36672e.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672e.c b/drivers/gpu/d= rm/panel/panel-novatek-nt36672e.c index cb7406d74466..c39fe0fc5d69 100644 --- a/drivers/gpu/drm/panel/panel-novatek-nt36672e.c +++ b/drivers/gpu/drm/panel/panel-novatek-nt36672e.c @@ -614,8 +614,6 @@ static void nt36672e_panel_remove(struct mipi_dsi_devic= e *dsi) struct nt36672e_panel *ctx =3D mipi_dsi_get_drvdata(dsi); =20 mipi_dsi_detach(ctx->dsi); - mipi_dsi_device_unregister(ctx->dsi); - drm_panel_remove(&ctx->panel); } =20 --=20 2.39.2 From nobody Mon Feb 9 13:39:18 2026 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD08076028 for ; Thu, 4 Apr 2024 10:08:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712225295; cv=none; b=LOYHXrMTMN+24msHNQRXvRasd5xcLSmKpSmuVrgfopxMnfTJSzOC7OUTDksBBxOgLZmGfYANS8kvfOpzShXQI7VuCewiwvGkR3LIMYBMheNikkkiF1Owoye1l8d8j1Di6CqbBqOi7AWMCjwwkbdaIXOnMSAUqZwYiofVpaGlD5g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712225295; c=relaxed/simple; bh=rZ4pFCxBcKO4r0UopE2b8togAYR+akgCS3Rw6K0bDz4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=g4zdGrAk8hk5VzgtnaFJa98HjixiGlSsvfPJtFB1jAl5WkAvvfJ6mtVarqaO0djdVDqlCsGBdoekF98esIZP/bBeiHXkr0UM1WkWllkp9olL1yF+d3/iOXTgk7Ix335Xi2r9nbzTpAAa0WfJoUFRInelwX8JLhWkbVr4x8aoSJM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=XWeMi90m; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XWeMi90m" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-516bf5a145aso945833e87.1 for ; Thu, 04 Apr 2024 03:08:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712225291; x=1712830091; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BdIQoQEcKOWWU/GbrzKgWkHTMEPIUceBmA7aLedovAc=; b=XWeMi90m+ed65nbxWADoaW9lJdCkiajuqNdBBjCVI6pWMnluEkSbegu6qiMFyXxLRf O+QdmeK1PvkEbQVitNu3C2YbiA3BnL+NSxfOUAAaqnZH1nm1BbvMlBqMd1gJEwnLBxUO quVaYQYd49A4Epn68iqjwgl8WK309siMvqcEkBIZMp8QyOGBla3QOGc1fs0H1FDI6RWl 0vUpNqr22WKDjStSwjP8jZhnHJgQjCPZ402O8ursQH2g4dr8hVZTbVWM2NyQ6HOviE7i JmXMF1ihBBJsZiX6NTFa/tDfPBAwCY8MaMQJqNvp5AhSAC6154afzEHc8aLaRdIq201e Zj2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712225291; x=1712830091; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BdIQoQEcKOWWU/GbrzKgWkHTMEPIUceBmA7aLedovAc=; b=WaxHXpRu1FxB73k1j5+UHyMT+QElQ86PtcJAWMhAoasrHU2wikZTDZP9DGyYgjWaPn PS+wsCyucS6jFkjBc60eHFtnWW0R7x+xkKaxeOlDMXU0KOLbP49TKduv9Nwy6297DxNO +HIHxRNNFuWCIZPZOtnQVuqSdNwGUeMdZpPuFwfITxsFQ7ZKG5+3pwZfudm/orMd0Wv3 4TMo1TVDOJlq8usZ4ftPiUsTtsoG6TXuljTGsmz+LCWQnHsBk2P9uXUMRoz9aspOXFE7 b7RC+pW5DnRV3PTGyVm6xJTbCXyVnSdX3O2EXT1+nsMR7QWHe76EWujfrTi3IOtNxXk3 4zIg== X-Forwarded-Encrypted: i=1; AJvYcCWuVQ6suKeDFGQ7UN4fsQGsI4WpgDxSpAqVu07cOj0Mmmp9OPl+OEXxiLJq5Jfu70VvHUIenfFr1ETE77KDuXM8vPT4u8j64dAR1lWW X-Gm-Message-State: AOJu0YzbNDnDtAv6QwMtLuE8g+/rA2u/ltyaYAi3nfXIcL54CC5M1LDw g3FvNHAYWM6kCusI2Y0hiS0rwAa+4aSBKgEd44TPdFWuQSZ4h/Z43ROZGwx7gI0= X-Google-Smtp-Source: AGHT+IGVlQ33RJEgohTvVD0EMCqh4p4Buhi5vVkciZI4lYNhGCrK13DBduxsmLyc55fg2pHBdTILcg== X-Received: by 2002:a19:644f:0:b0:516:bfd7:de92 with SMTP id b15-20020a19644f000000b00516bfd7de92mr1308662lfj.43.1712225290902; Thu, 04 Apr 2024 03:08:10 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id ig10-20020a056402458a00b0056c0a668316sm1984219edb.3.2024.04.04.03.08.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 03:08:10 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 04 Apr 2024 13:08:01 +0300 Subject: [PATCH 3/6] drm/panel: novatek-nt36672e: stop setting register load before disable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240404-drop-panel-unregister-v1-3-9f56953c5fb9@linaro.org> References: <20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org> In-Reply-To: <20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org> To: Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Matthias Kaehlcke , Harigovindan P , Ritesh Kumar , Sumit Semwal Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1555; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=rZ4pFCxBcKO4r0UopE2b8togAYR+akgCS3Rw6K0bDz4=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmDnwFAm7x8NXoFqiIBscoezOHH9QYMPEReQDM6 baVaKAbFWeJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZg58BQAKCRCLPIo+Aiko 1ZRhB/0Umx3VwSsiurPyTfgDRGxeKFo9jV4d99djRhqqhRRDIYlh8kwO4kA/En/A9IdV0bOtlR9 /tdlRL1lMwq5S/Z/XcOzVee8BHb9ffUqX1dOuUuTltDlMQWoOaDrLarzWzFAT31SxJPISPS2/Ba t7yEsKdIiV9/+9QaSvG35b8LNMeiCtyFsBkaNJrbiKOOTsCDquPJgIy9tVHDlHRtqbJ+8CBaexn QgKfxEqZCuj1lh7PHG2SoHaV1GeK0QD7pl6DA6kosRxf9TFkCE/IgmeNJdL3msAFWJcfb2mAwKv O7iqZ6oMAWOYwSEiq6XRjNpjv5vzQFFlPs194hg5J4rHFlyG X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A It is pointless to set register load before disabling the register. This vote is going to be dropped as soon as the register is disabled. Drop these register_set_load calls. Signed-off-by: Dmitry Baryshkov Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-novatek-nt36672e.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672e.c b/drivers/gpu/d= rm/panel/panel-novatek-nt36672e.c index c39fe0fc5d69..9a870b9b6765 100644 --- a/drivers/gpu/drm/panel/panel-novatek-nt36672e.c +++ b/drivers/gpu/drm/panel/panel-novatek-nt36672e.c @@ -25,12 +25,6 @@ static const unsigned long regulator_enable_loads[] =3D { 100000, }; =20 -static const unsigned long regulator_disable_loads[] =3D { - 80, - 100, - 100, -}; - struct panel_desc { const struct drm_display_mode *display_mode; u32 width_mm; @@ -385,20 +379,9 @@ static int nt36672e_power_off(struct nt36672e_panel *c= tx) { struct mipi_dsi_device *dsi =3D ctx->dsi; int ret =3D 0; - int i; =20 gpiod_set_value(ctx->reset_gpio, 0); =20 - for (i =3D 0; i < ARRAY_SIZE(ctx->supplies); i++) { - ret =3D regulator_set_load(ctx->supplies[i].consumer, - regulator_disable_loads[i]); - if (ret) { - dev_err(&dsi->dev, "regulator set load failed for supply %s: %d\n", - ctx->supplies[i].supply, ret); - return ret; - } - } - ret =3D regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies); if (ret) dev_err(&dsi->dev, "regulator bulk disable failed: %d\n", ret); --=20 2.39.2 From nobody Mon Feb 9 13:39:18 2026 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F378D76408 for ; Thu, 4 Apr 2024 10:08:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712225295; cv=none; b=cBVYBhxje51sQpC0vRj769RnN6LEkQHyVHvfC2LKMiCJ5DUhs++bArDsPpsge3pTlYizLxpVB8yK8jtHeu0oTJo9V2/lipqfspdTp1kFd01RRfShycgYQrbqvONXxXRFmMm5oObokkRvCm46VgspwYLAnAYQ9qlpK1qeulfUY08= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712225295; c=relaxed/simple; bh=H9DTnvxOhLAsFMR7/zYzkTplDuaaTlPMoOsjC54VSys=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=E9euaUkXDqUnAZReDB1aGB+UAbBYYspto8Q8P4gIqbLNTN6iKx4Pmqtj5WqG+ahTEQ2IRgY3l1AIqtfKbelofl7/ThGVA1927BE2gXsnEr9v47ielGCe2lAr8ziZwIh3LxsLV9E49SZ8Q5uZPwsYgcFRze3YjEKfip/p8nBrbus= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=FGvV+553; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FGvV+553" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-56e1e6e1d01so567298a12.1 for ; Thu, 04 Apr 2024 03:08:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712225292; x=1712830092; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3iEJ/RqQGEQXC2ep2uq6icF6qECUCl++i3ec6IEoffE=; b=FGvV+5536Vr9GcNjfcNwLP7nguEgD9n27jEy4X/Z+IwIjxIqkZf5O7He8p1pLCe0im CeTHdVJ1UctmJA6EGpHA6lkSbO1ecPTfXjkm3RZrgfG/emgb2il8poDUjLJoim/EyU2G d3K7uezKjrhZJPJrNmAy4EhIlTp3Zi2ItIwS7wsVcQZZNpWXAgeCknoSAyCIMZyzmtS9 ZQAqQ5C3Nutv5kZ8ksOXcaVyo98Zei+AaKTcLrX1O+ISpA1Q/spdO9O7VSpghKn/kwN2 kPfEnAjFoWweOVOhIMjGKMCQrQswgiClN45hMs3TPrJeF6kK0mJrB6rcnLF0jts4gpZF P84A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712225292; x=1712830092; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3iEJ/RqQGEQXC2ep2uq6icF6qECUCl++i3ec6IEoffE=; b=WM4rTrh9F925OiGoDawqNeU8E0prcjiXKHdMTGXl21Ol/e3ATQ9MYI9jEiULA5ji/V +yrFfg2fGxWPVsXhEvUEadkH/hWxh+wk9itJMZp7oB5vJxydKGu+aBiCTzTH9uNn6q6F dOxrx3oBbVxdqHmSw/xdyq9uoYsnlBUDAgWQjaNBFb+aWtz1AmrgJraNCEpXORTHCmqP N/kClyzfd+Mj3dqzvSsff5BC1AsrCLOds9ODzW8z/B74JGREP2V9ynWuQF557TB8AirN Dv+tByDU7YR8euAiiw/jfjvmpzT6Lv+J/yHQ32pE9lZF0rKW6gKsXeyW8maNrIt9ZXQz B+vw== X-Forwarded-Encrypted: i=1; AJvYcCUVS9DuweZLDe/FboNKmY0dsNGbPPHfvTF9EUAKtqKNdd5R7keYa5ywrAFPOq/C4t1ncZvPt4/UlCpqL1IbeyxpxYWiY2eKA5ote+fj X-Gm-Message-State: AOJu0YzUTT8LHY2bN6JBgL20wGqIYftdV4/5lonq8JtE7ub5a5rqT3rN cFT75Brxd6TLxwYG77EAK5lMvxrIsLlk3Bp7Lu5WCKYREQy8+27K9NP/VXbp6ROp81Pw36eNCE3 W X-Google-Smtp-Source: AGHT+IE7uZg+Q8MxKj9wP0qIcOCX5VGa3Rs8Ms9OK8oC2SCWf7JhMx8FjKV08qwBA1+QirOE+lHo/Q== X-Received: by 2002:a50:9f22:0:b0:56b:a077:2eee with SMTP id b31-20020a509f22000000b0056ba0772eeemr1463352edf.4.1712225292236; Thu, 04 Apr 2024 03:08:12 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id ig10-20020a056402458a00b0056c0a668316sm1984219edb.3.2024.04.04.03.08.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 03:08:11 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 04 Apr 2024 13:08:02 +0300 Subject: [PATCH 4/6] drm/panel: novatek-nt36672e: stop calling regulator_set_load manually Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240404-drop-panel-unregister-v1-4-9f56953c5fb9@linaro.org> References: <20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org> In-Reply-To: <20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org> To: Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Matthias Kaehlcke , Harigovindan P , Ritesh Kumar , Sumit Semwal Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1608; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=H9DTnvxOhLAsFMR7/zYzkTplDuaaTlPMoOsjC54VSys=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmDnwGOSkOIwSEiA9PVDGHOoidJ+W9OPRJ8acpz nzm2l9u+zqJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZg58BgAKCRCLPIo+Aiko 1WMWB/96tYjo2hhtiGxIK0g/c0rr8Y2g8PIUfBaRQ5yKZE6bHjOHd5kpM6RTO95gR5cX2m37Vdz UdtHFCsw0p0GHa7VQMeJHwwmYGlyq5kRRXYAJWN/xffSJZXSFHO/7jf3lt6u+zTKuIjEdWP00GK 65z43VET+dmpitof8CNOty04Q0GD46F76Zivvy9YjMyNO3nH+EThYsPB92alpFXLqdZvkt7G3Ih IuydjRCHtNDxoaamGsLDzUPVrBVVmAEWWT2+dntfqtcB17zyb98nVkcdXqTpX6BDWWMuCqgzjbM YNdfJaHSbeOUe324ctffoZk9jtJan5O0VkntBwKi++N0l0Tg X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A Use .init_load_uA part of the bulk regulator API instead of calling register_set_load() manually. Signed-off-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-novatek-nt36672e.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672e.c b/drivers/gpu/d= rm/panel/panel-novatek-nt36672e.c index 9a870b9b6765..20b7bfe4aa12 100644 --- a/drivers/gpu/drm/panel/panel-novatek-nt36672e.c +++ b/drivers/gpu/drm/panel/panel-novatek-nt36672e.c @@ -343,17 +343,7 @@ static int nt36672e_1080x2408_60hz_init(struct mipi_ds= i_device *dsi) static int nt36672e_power_on(struct nt36672e_panel *ctx) { struct mipi_dsi_device *dsi =3D ctx->dsi; - int ret, i; - - for (i =3D 0; i < ARRAY_SIZE(ctx->supplies); i++) { - ret =3D regulator_set_load(ctx->supplies[i].consumer, - regulator_enable_loads[i]); - if (ret) { - dev_err(&dsi->dev, "regulator set load failed for supply %s: %d\n", - ctx->supplies[i].supply, ret); - return ret; - } - } + int ret; =20 ret =3D regulator_bulk_enable(ARRAY_SIZE(ctx->supplies), ctx->supplies); if (ret < 0) { @@ -550,8 +540,10 @@ static int nt36672e_panel_probe(struct mipi_dsi_device= *dsi) return -ENODEV; } =20 - for (i =3D 0; i < ARRAY_SIZE(ctx->supplies); i++) + for (i =3D 0; i < ARRAY_SIZE(ctx->supplies); i++) { ctx->supplies[i].supply =3D regulator_names[i]; + ctx->supplies[i].init_load_uA =3D regulator_enable_loads[i]; + } =20 ret =3D devm_regulator_bulk_get(dev, ARRAY_SIZE(ctx->supplies), ctx->supplies); --=20 2.39.2 From nobody Mon Feb 9 13:39:18 2026 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 717E57EEFE for ; Thu, 4 Apr 2024 10:08:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712225298; cv=none; b=KCf+xzMAUiZrZXHS+t3UBEF5Yq1TBXiptUS00IdI+2HbHYC6ZEpNRQpcbdyFFhbpeGwEgfzOWWTzDAbc8Q72wN8MsCKRuHpxPH+b7eyS85EaSMegLIK/GLkKR+bVBmBf0okqVdNX05ILc/oJiSpo6Lw0LhZcwOS0XyGrza57ZJk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712225298; c=relaxed/simple; bh=eCcqI9AuK/Z4GvlfkxunJCyaNrb4UqWmCkVQLFSw/nQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CxXFZlZQid5b8FKs5k8nm9KgJGvfzVBmUAUmpJ3nbC8gmP/6Asp8haS65fUfNdzRrUX4vbglaDOJGk4/eB1vSb+qpVU+Ge35SgiiZZlm8RW20wHPN1tH29s2Gde3w0XnJg+BmXd9N2HsenuJH4TA6BS4estiMMdCbgivUkz7LzQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rkGy/fNE; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rkGy/fNE" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-56bf63af770so421472a12.3 for ; Thu, 04 Apr 2024 03:08:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712225294; x=1712830094; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PPN+AHE8y2MkIJuM9pYz2Ll5VT40Ao0mKYYFM9ZEDlc=; b=rkGy/fNEhQnPQWD52y03jTdlR9AyZIu8+ALVFTGJiSImk52o/EeXDiWbtzwFrIW8r9 Oc1fipeS5A/7IdPuPDBJGjsCf29Ex23BOWbSlwicuC1Udd5Y4fie29TKQr/7L7ojLPsi FWttmxZqBSk9pSp+W9AJ9AQr0/u6VGn2lqfvDepwYAGImXb4nyfuu7fUkjx0uSApboku C9w/ulXlBMX5IDsqd+1wLpRyuZyLCSjakg9YF+ssnIoEYbU/ZyURrOxTuNpq+ZlAbcbI 5n35nblyjZ+s685yAkFId1LGu8EQ5evKyUhvXIprNB1SuD1a+PBpy2x2hq5w+V1uj9bO G3Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712225294; x=1712830094; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PPN+AHE8y2MkIJuM9pYz2Ll5VT40Ao0mKYYFM9ZEDlc=; b=mTWnWxuMGrSXedW408QmNI8ffmKWJQpjBE8+CFs/i6u2QtqegJU0o8i/5WslLBjTnU IW7KgMOvIPZc5xZ3T+ibmQyVXvbXEXs0N1Bptu4/d/dXb8Qej1zXc7Vktuwhr6AQ+kUl HMabVSHevSxIakRU06bziviF5v6UDgbCsraIWHnlUNU59Ho2zp01FotL7cYR66KRaH8R wPgq4/dy7P4IzIU/72yoZcDNodMPhiBv0ECZqdWuP6+7ZUrXnu1Ikg3ZdxC5TPgXia+y EZjR4VVg33kRRinE/qADSYb6ienAZi+l9tJHBLIZIIiYPVnqJSnz080my0j2IBcUoM/z bgvQ== X-Forwarded-Encrypted: i=1; AJvYcCUod42iS8mXxpovvo9gqechGlHX+Z/eKh6v2FnF3UaMVx3RD9sFlS2qpUBJctlqHVODyppPjt2FA+u7unD+nsu92aj5MuibZ8P3X6Xw X-Gm-Message-State: AOJu0YxwPsuQz3sadxwq6XiRl2VnGSoRwEaFOUS5jkS/kJxHPlpHzVKW Csy8PjSQJfJQNRG/RaH4/EZOe7ljG7pt15VWQK+nsHt+9nTh681oxd8Z+I2piF+5b59sitNZJ4T f X-Google-Smtp-Source: AGHT+IG+bzEJEONgFdA3wAMbc5bzkjLYvW9jbIlri8O2GdxrDMhypvw8vGmRretwMNzBqrsEp+LLtw== X-Received: by 2002:a50:9516:0:b0:56d:eb22:eaf2 with SMTP id u22-20020a509516000000b0056deb22eaf2mr1641222eda.21.1712225293709; Thu, 04 Apr 2024 03:08:13 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id ig10-20020a056402458a00b0056c0a668316sm1984219edb.3.2024.04.04.03.08.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 03:08:13 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 04 Apr 2024 13:08:03 +0300 Subject: [PATCH 5/6] drm/panel: novatek-nt36672a: stop calling regulator_set_load manually Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240404-drop-panel-unregister-v1-5-9f56953c5fb9@linaro.org> References: <20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org> In-Reply-To: <20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org> To: Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Matthias Kaehlcke , Harigovindan P , Ritesh Kumar , Sumit Semwal Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1557; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=eCcqI9AuK/Z4GvlfkxunJCyaNrb4UqWmCkVQLFSw/nQ=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmDnwGnnj+WYVJzPKl/9S+XC8FxF5CW7r/Do0cf 314BZ0pIASJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZg58BgAKCRCLPIo+Aiko 1VZVB/4z5IlE0BLotgSxrMP0zTg3pTxhrC760H1bsEoAEATmeiT5vkTHU3LD95tNz3V8GnPGFDF YrGEzRLYnT0SOGtCu8HEXePqHwzQJyr1Wo900PMx/JZj56s91T5ya+wqhW4mZwda5H0yQVU2rk8 l92jyhHDAuFtuL6Ey9S5DIR4w8zhC2C6GM/Pv6YBXS80WgqFUHMgjjzF3NM5FJCpxqgut29qpSs svgtDFYO5QNcRXro8ChmX0QRZNzX/tFAzKqf/kZtc5UEimqhbnM2eiQfdB8Os08R1FUioTI20em +CHMaTUzjjXXAjk+1ZwVOZizCsXDwF1x6pCj62qPSYbSBfFb X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A Use .init_load_uA part of the bulk regulator API instead of calling register_set_load() manually. Signed-off-by: Dmitry Baryshkov Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-novatek-nt36672a.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c b/drivers/gpu/d= rm/panel/panel-novatek-nt36672a.c index 33fb3d715e54..3886372415c2 100644 --- a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c +++ b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c @@ -605,21 +605,16 @@ static int nt36672a_panel_add(struct nt36672a_panel *= pinfo) struct device *dev =3D &pinfo->link->dev; int i, ret; =20 - for (i =3D 0; i < ARRAY_SIZE(pinfo->supplies); i++) + for (i =3D 0; i < ARRAY_SIZE(pinfo->supplies); i++) { pinfo->supplies[i].supply =3D nt36672a_regulator_names[i]; + pinfo->supplies[i].init_load_uA =3D nt36672a_regulator_enable_loads[i]; + } =20 ret =3D devm_regulator_bulk_get(dev, ARRAY_SIZE(pinfo->supplies), pinfo->supplies); if (ret < 0) return dev_err_probe(dev, ret, "failed to get regulators\n"); =20 - for (i =3D 0; i < ARRAY_SIZE(pinfo->supplies); i++) { - ret =3D regulator_set_load(pinfo->supplies[i].consumer, - nt36672a_regulator_enable_loads[i]); - if (ret) - return dev_err_probe(dev, ret, "failed to set regulator enable loads\n"= ); - } - pinfo->reset_gpio =3D devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); if (IS_ERR(pinfo->reset_gpio)) return dev_err_probe(dev, PTR_ERR(pinfo->reset_gpio), --=20 2.39.2 From nobody Mon Feb 9 13:39:18 2026 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 529647FBB6 for ; Thu, 4 Apr 2024 10:08:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712225298; cv=none; b=JZ9KNt6DHUagT14+wJpAGsEuMqmVkhFknPp9KHruDXhOQUqYGvVLkJ0Ko1S806tjRMCdQzJI05LG65HNa5sNZiq3f0NYyWt9yAoWMOHYNo5moM7++LJOngqcggssWOp1ltHoAd2Q8hjGbZ6ea8qzflWaPoNLNbzfHguO+T8Q1Zw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712225298; c=relaxed/simple; bh=irilOr1F66J72zSf/iZ/FxY1c7hsuCBIEPtG00CVG8k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JUej4wf3cTx6D7SKWOjpLAgEYi/BP7xTHyV8TaRLNy4m6CJUjFkU846QAOahNacmLT25jnN0ujreOCv2R5eKpBv39KiB8LBBjFeN4W2ZcEONMI6SaMwqrKGUeGFbTvSqOex+p2H7qgZHQ7/tAxFbWg6H4qg5eSwUG/tLHdES3xE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CLIyDXgC; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CLIyDXgC" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-56c5d05128dso900951a12.0 for ; Thu, 04 Apr 2024 03:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712225295; x=1712830095; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9gdreFmOsn9hnQ9/3et99EfVumTY2yhwD/QDrRRb3VQ=; b=CLIyDXgC85XIjzyJ6IHHDeQ6722QQjxl6N44zrZt5w1FUsLOYZG0V5jkMiaF0XPPBc 7UJJzxYiMv+iUaBP0iyIvbx1SFxwN77UhhCL4/81N/tpCjy6fuGdhUBUXoTA7lEjBPK+ JTzpp5RICvPgz31iy/2dHRcL3r73nfMe2xUBPwMEkqMJLzXUbQZQ0Ry7m9TtNpHmq2q5 3gCXXr82Zi5nb0ggYydVMS4rOKI5CjAZ0WLBr22vkIGeGUiVl6p0z7nKziQovLaaWEzO x8PKKOlo7GBmO29eINqK/1vLAL1VMNC10DDRnoVtkAd5e4nXLF/vfQ6fhxtLkj5dyjtx sX6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712225295; x=1712830095; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9gdreFmOsn9hnQ9/3et99EfVumTY2yhwD/QDrRRb3VQ=; b=VuQx5ApeRKzkBUV3/h6yg/v56hgd2IMqijy1VwXAeHefjiMsLzXhOEjMKdQR1JJFJs UL3/BcHZCN1xhPy64AfYKFP+2BfX8RovnGNQPQoEIoYwx48NDPDTHSkvev0fYl5lFUXX giukVeFFViBga+8gf/kAEzmX3HCGYenpI6wRGG7E+W1yqRqDofZud3vUaiU9MIA6lLvb gx6AKmb7wx15Rx5apwXJTIc5lIMHUHsT/GR08ZK+UaInF9ObuE1UMPREciYF20XuGQiM QIpCLe3h0wnVTh+Raas4tLAu9HgBEGn9YPifNW7wG5KxjXes1rAyNbEpq+w0th1zK3g+ WOpQ== X-Forwarded-Encrypted: i=1; AJvYcCX7kheZH2xFx8Irs05EuZSdMgFhMjN33XK4HqdMUflmPq7PG0LTe+krK08nGlY+wMFnlTxeVVqFrkm2Tz3Sxw9f/AZyDVXdv0SDLPPS X-Gm-Message-State: AOJu0YyEZZPPp3vScEpJ/L7qjOPDNZ8FRD49O+Xb3/0Cma1Z2ib2ZVf7 F+ahnR6dPDfXCiEC8UU/FWeU2Xv0APjI71D+VvdfkQjUPrRvR774UgNxAhH5FBU= X-Google-Smtp-Source: AGHT+IG6MIBoUnhn5kD8YkyWDaqubmu5zZw/UDEyEutc/LQNpwjh73npo2Rh0hXKgklGbZY1tDHrxg== X-Received: by 2002:a50:999a:0:b0:568:b622:f225 with SMTP id m26-20020a50999a000000b00568b622f225mr1367415edb.30.1712225294754; Thu, 04 Apr 2024 03:08:14 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id ig10-20020a056402458a00b0056c0a668316sm1984219edb.3.2024.04.04.03.08.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 03:08:14 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 04 Apr 2024 13:08:04 +0300 Subject: [PATCH 6/6] drm/panel: visionox-rm69299: stop calling regulator_set_load manually Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240404-drop-panel-unregister-v1-6-9f56953c5fb9@linaro.org> References: <20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org> In-Reply-To: <20240404-drop-panel-unregister-v1-0-9f56953c5fb9@linaro.org> To: Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Matthias Kaehlcke , Harigovindan P , Ritesh Kumar , Sumit Semwal Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1559; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=irilOr1F66J72zSf/iZ/FxY1c7hsuCBIEPtG00CVG8k=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmDnwGO0eQ0yN5Gyv9QpomFj0R6gyXZ+5rtNEtm IGQoU0uAEaJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZg58BgAKCRCLPIo+Aiko 1WYFCACn5db1y7XDZnwi8s8NKNDV0h88BTcuOpypH5tfLwAH0CVs/5d5b23X+DvXMpORhQEi1jY Dlh/F0h8AceX/ZhR04srs58R1l1cV18WdVKPKoWheb7OstyQjJweYXovPKwMHJ9oAgyIVfGWA2b ZkPVfk1YaWtNi7jLO44GU7J7TOMbi9Y6tHvkxgEb7LpRXi6KzxA5Vxn/hlitMipltv3Th8rHBbU k6h0ttkCAmQbWlJKlqYqcNOE615htx4ndaJ81GMF6rJ4I8/2/oiVwmjy5y3aLOLWsJ0Iurs02L+ MwsKQn0YXCDkU5gtyKKVeeXSmjgnvndGlJJ+gU7szKQ6+s6Q X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A Use .init_load_uA part of the bulk regulator API instead of calling register_set_load() manually. Signed-off-by: Dmitry Baryshkov Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-visionox-rm69299.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu/d= rm/panel/panel-visionox-rm69299.c index b15ca56a09a7..272490b9565b 100644 --- a/drivers/gpu/drm/panel/panel-visionox-rm69299.c +++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c @@ -197,7 +197,9 @@ static int visionox_rm69299_probe(struct mipi_dsi_devic= e *dsi) ctx->dsi =3D dsi; =20 ctx->supplies[0].supply =3D "vdda"; + ctx->supplies[0].init_load_uA =3D 32000; ctx->supplies[1].supply =3D "vdd3p3"; + ctx->supplies[1].init_load_uA =3D 13200; =20 ret =3D devm_regulator_bulk_get(ctx->panel.dev, ARRAY_SIZE(ctx->supplies), ctx->supplies); @@ -227,22 +229,8 @@ static int visionox_rm69299_probe(struct mipi_dsi_devi= ce *dsi) goto err_dsi_attach; } =20 - ret =3D regulator_set_load(ctx->supplies[0].consumer, 32000); - if (ret) { - dev_err(dev, "regulator set load failed for vdda supply ret =3D %d\n", r= et); - goto err_set_load; - } - - ret =3D regulator_set_load(ctx->supplies[1].consumer, 13200); - if (ret) { - dev_err(dev, "regulator set load failed for vdd3p3 supply ret =3D %d\n",= ret); - goto err_set_load; - } - return 0; =20 -err_set_load: - mipi_dsi_detach(dsi); err_dsi_attach: drm_panel_remove(&ctx->panel); return ret; --=20 2.39.2