From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDCE3139569 for ; Wed, 3 Apr 2024 08:07:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131663; cv=none; b=KPa0x/lrmY/IdWhwpr9IvHaVUwKhLr/PtNR03AKTCqaIh1R8CsKv1+jG0SVio4jz2Gtzb6y8h7TI/lGYElLKX1BUYNyqnOS9QtWgsvvpm6Cxm10DWo11beUzSOKGBFTbY0M2ypugvy7kwFYlesfP8RdnEQz1Z8iq5LqLqLoQvVQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131663; c=relaxed/simple; bh=DfgrdIQHoOxH+2TugFyR/+ff9D+Pn9X95ms+e4KOlOo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nV9D0liGRjQKRJApddDNRY9ccYROk5iShXMmUcFqQddbvBMBbtCY/uCu5BSD66zsrJjKIGfLFKJl2/W0OUDo4+yPyhvnixRQ16lD2AFS+VBTlwQXM1Q+BR4laQ3IbSwLr5utiA3Zdu97hCYMX2illWpnLlDvBzlgO4rAOj+dOLU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cvSPhldb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cvSPhldb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 951BCC43394; Wed, 3 Apr 2024 08:07:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131663; bh=DfgrdIQHoOxH+2TugFyR/+ff9D+Pn9X95ms+e4KOlOo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cvSPhldbzQ28ytw8g7KXAHbWMo76SFb4yERsC/I1lFWdR1BNpTRt8Tq6F39wtGTGF sGx5JswGoJMQmUaFaiUv3ObDX1+KLIKtUDSD3YQ72PQEuNXEDWpAXRnAPek4RE3gFk c1GbLt9ef7ZK8kkt7hLYPklbVqmnZbyc27QgskspyHof17Z/W9JpBs464et44/aaKI jDA6i2Zg6aIEW7xL0vdTPbiBFIlMHlYCnzjKoEaS1MmycqX7BDD8ZAC9/Ntfn9vXMR 8xAVyO7U9KINKcEGrzL/jMwW5DrMaV/MoW8gTP3iP1MNACqRSR51F83VTRy3Qk6Hwn rcI3LyP40at0Q== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Michael Ellerman , Alexander Graf , Stuart Yoder , Scott Wood Cc: Arnd Bergmann , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Rob Herring , linuxppc-dev@lists.ozlabs.org Subject: [PATCH 01/34] powerpc/fsl-soc: hide unused const variable Date: Wed, 3 Apr 2024 10:06:19 +0200 Message-Id: <20240403080702.3509288-2-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann vmpic_msi_feature is only used conditionally, which triggers a rare -Werror=3Dunused-const-variable=3D warning with gcc: arch/powerpc/sysdev/fsl_msi.c:567:37: error: 'vmpic_msi_feature' defined bu= t not used [-Werror=3Dunused-const-variable=3D] 567 | static const struct fsl_msi_feature vmpic_msi_feature =3D Hide this one in the same #ifdef as the reference so we can turn on the warning by default. Fixes: 305bcf26128e ("powerpc/fsl-soc: use CONFIG_EPAPR_PARAVIRT for hcalls= ") Signed-off-by: Arnd Bergmann Reviewed-by: Christophe Leroy --- arch/powerpc/sysdev/fsl_msi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/sysdev/fsl_msi.c b/arch/powerpc/sysdev/fsl_msi.c index 8e6c84df4ca1..e205135ae1fe 100644 --- a/arch/powerpc/sysdev/fsl_msi.c +++ b/arch/powerpc/sysdev/fsl_msi.c @@ -564,10 +564,12 @@ static const struct fsl_msi_feature ipic_msi_feature = =3D { .msiir_offset =3D 0x38, }; =20 +#ifdef CONFIG_EPAPR_PARAVIRT static const struct fsl_msi_feature vmpic_msi_feature =3D { .fsl_pic_ip =3D FSL_PIC_IP_VMPIC, .msiir_offset =3D 0, }; +#endif =20 static const struct of_device_id fsl_of_msi_ids[] =3D { { --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D314F81207; Wed, 3 Apr 2024 08:07:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131675; cv=none; b=ZglCYLtslRlE+2Zg203LJuq7kPaXF7cxxmUdtb3nbsxZWLk8PrwkalJNqlxYktQUKID3fKmKahDZdSLFHMajysd6QyEfFFE07ZDKC1+iLIdwMajJQ3x0VyfIpSvEtRJmfyO23oDMS40CA0T2+WCPn8br6qE5K4xsMrsO0C4/3TA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131675; c=relaxed/simple; bh=i2kwREvJagmflXYpUvDxkKnpylOun/MjosG4Ff0VeyU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=dsKjkbm8W2L8ag+vIIFvIMZAOpjJxruTd6LLy0ZWn8tjXFTQ0JHv1oQp51XLNWWobrzQPKA5V9sjeKOTyJvWr/PaPwT29GMCvU5j4nKf69gWIEO4kPJpYWE0PbR0g4MzL/XEGbrmJvYSEzZKrLhC9PhgijrBukFizJ0QC539H7M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iIwfgNho; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iIwfgNho" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C107C43330; Wed, 3 Apr 2024 08:07:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131673; bh=i2kwREvJagmflXYpUvDxkKnpylOun/MjosG4Ff0VeyU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iIwfgNhoK4uO99gGZSx/4AtuVr5J0+ILk77OBxquuSiIuRfxua0kwS5ZHLif5eNFK Xiwlt9yeTpBRhXGlXbXwwHy3FGxNmF/kbPC6bpAQPsWi5aLQEkG8jAiciY3TSvcEds 2x7mp557Sf6hrfOqNsybrYTk55PdyuFDHv74h9gxE7BH5qNt83P2kSCn6r+/pfGQwu Qz/sLLA3y28X6bUTadkVRMd7GFVGelJrLkmJWcf3N8rAqOfz0Vb+cTIotRUwSh69Rk G+bpOo4zdRzXll2Q7I3jBh8x0oqTjEqUM9/PS9zuRJn01ez5Rg0yvl6X2szE/sSueT jJPzh+CAjCubw== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Kees Cook , Andrew Morton Cc: Arnd Bergmann , Marco Elver , Andrey Konovalov , Andrey Ryabinin , Justin Stitt , kasan-dev@googlegroups.com, linux-hardening@vger.kernel.org Subject: [PATCH 02/34] ubsan: fix unused variable warning in test module Date: Wed, 3 Apr 2024 10:06:20 +0200 Message-Id: <20240403080702.3509288-3-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann This is one of the drivers with an unused variable that is marked 'const'. Adding a __used annotation here avoids the warning and lets us enable the option by default: lib/test_ubsan.c:137:28: error: unused variable 'skip_ubsan_array' [-Werror= ,-Wunused-const-variable] Fixes: 4a26f49b7b3d ("ubsan: expand tests and reporting") Signed-off-by: Arnd Bergmann --- lib/test_ubsan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/test_ubsan.c b/lib/test_ubsan.c index 276c12140ee2..c288df9372ed 100644 --- a/lib/test_ubsan.c +++ b/lib/test_ubsan.c @@ -134,7 +134,7 @@ static const test_ubsan_fp test_ubsan_array[] =3D { }; =20 /* Excluded because they Oops the module. */ -static const test_ubsan_fp skip_ubsan_array[] =3D { +static __used const test_ubsan_fp skip_ubsan_array[] =3D { test_ubsan_divrem_overflow, }; =20 --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 289CD82C76 for ; Wed, 3 Apr 2024 08:07:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131680; cv=none; b=uE49ILQ87C+d8Dd+Xoh2xyTBUf2vmAlBJJ0rf6jM6KbXTgk8/oGCHUk6AACWgqVwX4NGP+UVW5XCVmEMn6HvQg96lwGWh8saJbbW3XfzbsEpULHa3dvbmvFUCvGQSt5AQyhe1qJytrivcAYpbQoS0Lbx76Q3Cir+MiRNxB2Pmnc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131680; c=relaxed/simple; bh=+RZZEkb1FuJEVe5kPWRemc+Kjc4SmXvUOzkLd/XEDLw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=T3G0VKEgiHegotLctAld8LQB1Scuf1wXIonwUvJeHjrBcPvwn/3mPROTwKLb/OnWYxiHwFUkG1bnuvBGY91Nssm0LDCfYaZyp8yxgO2AP3DSpQDWHsPWW15StqdDjW22Ov/BJXAFgkzeiPzxJ1Z0e1bERjhuOSaieHqy0wHWoM4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UAlVLpOE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UAlVLpOE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16C2CC433C7; Wed, 3 Apr 2024 08:07:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131679; bh=+RZZEkb1FuJEVe5kPWRemc+Kjc4SmXvUOzkLd/XEDLw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UAlVLpOES8BpHSPX9xir8ZtWnkI77GoKSccDd8F6+Lk5tHErVvCS9G6JNPltXMnym rw6JRTNWTdPa5bZKdSJ0J85vD98lmiNtbSSQlOIX2sLHXEq5Sn2VUDYE3dYun2NXTX 69JmjTv/12GuEiqIxNPjAsBBfE3znOnNROub0nUFLF5j0n2ti8dQ1JmVenQn+YcJcn yACPEXgXsCS5/igxN4eicNYihVjW3GKeuNcp2rAc/hTetqC0CMP63kOVJKFP3f/iJv /TANOdMIz3qmKZX+lUUUhuDWVHO+koGyTXMsGF2dubT63flnfqpvQk4yUr36PZSPla cmPMc8C010LUw== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Alan Cox , Jason Hu , Greg Kroah-Hartman , Jin Qian Cc: Arnd Bergmann , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Subject: [PATCH 03/34] platform: goldfish: remove ACPI_PTR() annotations Date: Wed, 3 Apr 2024 10:06:21 +0200 Message-Id: <20240403080702.3509288-4-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann On platforms without ACPI support, this causes a W=3D1 warning from gcc when the driver is built-in: drivers/platform/goldfish/goldfish_pipe.c:925:36: warning: 'goldfish_pipe_a= cpi_match' defined but not used [-Wunused-const-variable=3D] 925 | static const struct acpi_device_id goldfish_pipe_acpi_match[] =3D { | ^~~~~~~~~~~~~~~~~~~~~~~~ There is no real harm in just keeping the small table around, so rather than adding more #ifdef checks, just reference it unconditionally to avoid the warning. Fixes: d62f324b0ac8 ("goldfish: Enable ACPI-based enumeration for android p= ipe") Signed-off-by: Arnd Bergmann Reviewed-by: Andy Shevchenko --- drivers/platform/goldfish/goldfish_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/g= oldfish/goldfish_pipe.c index 061aa9647c19..6a0a42887857 100644 --- a/drivers/platform/goldfish/goldfish_pipe.c +++ b/drivers/platform/goldfish/goldfish_pipe.c @@ -940,7 +940,7 @@ static struct platform_driver goldfish_pipe_driver =3D { .driver =3D { .name =3D "goldfish_pipe", .of_match_table =3D goldfish_pipe_of_match, - .acpi_match_table =3D ACPI_PTR(goldfish_pipe_acpi_match), + .acpi_match_table =3D goldfish_pipe_acpi_match, } }; =20 --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D81082C76; Wed, 3 Apr 2024 08:08:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131691; cv=none; b=mHybvi4QBenUL9DfiAVEr3dZghyB1UxnWd1IDTSp6rC3iQyEMNbD3pzhCQkJlplzGyV90mYl2YXAM315giJRn1J5w4qTQtRcYG1PgKSLGzRKY33tV5qy5JqgI2I6fDpQjJvhOIZ7c8YyINxJmq4CRGXF9l8zWF5pUfiWGrA+bps= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131691; c=relaxed/simple; bh=nBMKcbCHM6WSePIKZgnN+NmyDRmfcmwdi7Q6UrA4R0s=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QJJAzcHhKYzW8yQ8XH/5nDD3mshVRG4eK6x4SilGQt02nS+uoGH5CDjtxC28y1/9zN0quCd8v+hg4X+vXfZ6NAtkCjO7cAtrWYfhNRgr11v8v73nE/Tk+BPhCXGcO9dFyH5dFs2y0YDfPy2ufbw+W62DbplzURy3VUKpHg61Yms= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=k4jY7OjU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="k4jY7OjU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB065C433C7; Wed, 3 Apr 2024 08:08:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131691; bh=nBMKcbCHM6WSePIKZgnN+NmyDRmfcmwdi7Q6UrA4R0s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=k4jY7OjUHYSY173pVi7rXHQ/+qCdzAB94GAS0OIudJs8w1C5MNgJM5F/DWrpAsXbr +viQNaZ3Mx2NwGj2Gp9Udbo2+/Z6sdBJpSexHqFLT9J09VE/8sMJVROyWyfIjc4+0a DY1wWn54ExMb1B2r49X2T0djEZAhQbkykDGH+9Oiqku4LJxDq8R9UnqPDw4ZvB/ImD jmIq2XfMa0x+NRh57QyUE3qFSPP3T3NtiuG9u/em6ujBNDdR/VVQeWha5Ad+u49JdI syuhZlrYyG5MgcWtiVnX+sHvxOOrO+9e1Qa9eRXW66OIaFRDCpCYklDjECafr6LVna PDjNa9kHcKhsA== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Andi Shyti , Russell King , Holger Schurig Cc: Arnd Bergmann , Wolfram Sang , Linus Walleij , Geert Uytterhoeven , Heiko Stuebner , Yangtao Li , Robert Marko , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Liao Chang , Paul Cercueil , Rob Herring , linux-i2c@vger.kernel.org Subject: [PATCH 04/34] i2c: pxa: hide unused icr_bits[] variable Date: Wed, 3 Apr 2024 10:06:22 +0200 Message-Id: <20240403080702.3509288-5-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann The function using this is hidden in an #ifdef, so the variable needs the same one for a clean W=3D1 build: drivers/i2c/busses/i2c-pxa.c:327:26: error: 'icr_bits' defined but not used= [-Werror=3Dunused-const-variable=3D] Fixes: d6a7b5f84b5c ("[ARM] 4827/1: fix two warnings in drivers/i2c/busses/= i2c-pxa.c") Signed-off-by: Arnd Bergmann --- drivers/i2c/busses/i2c-pxa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c index 76f79b68cef8..888ca636f3f3 100644 --- a/drivers/i2c/busses/i2c-pxa.c +++ b/drivers/i2c/busses/i2c-pxa.c @@ -324,6 +324,7 @@ static void decode_ISR(unsigned int val) decode_bits(KERN_DEBUG "ISR", isr_bits, ARRAY_SIZE(isr_bits), val); } =20 +#ifdef CONFIG_I2C_PXA_SLAVE static const struct bits icr_bits[] =3D { PXA_BIT(ICR_START, "START", NULL), PXA_BIT(ICR_STOP, "STOP", NULL), @@ -342,7 +343,6 @@ static const struct bits icr_bits[] =3D { PXA_BIT(ICR_UR, "UR", "ur"), }; =20 -#ifdef CONFIG_I2C_PXA_SLAVE static void decode_ICR(unsigned int val) { decode_bits(KERN_DEBUG "ICR", icr_bits, ARRAY_SIZE(icr_bits), val); --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F7198060D; Wed, 3 Apr 2024 08:08:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131701; cv=none; b=uB4kCn74HUO7fl3YOzzyoSvhb9g4xuwDQ8CWeC1QtEhbjCLPWZgFxdv4rk2A2VF5CF5Nin4P3NlOVGed2B49nSptYKUseE86vbZ8bwPqwgT2Y+MP45TPj5UQxyUYNFLftTDGRAEAtpyYJyvwPTIVyLPG9I5R31UuFlQi+ubHpjs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131701; c=relaxed/simple; bh=lKYFOQA74WUrBNKESAlJ+e055R+fsTrHN/bgM387ZAQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=AJzvmH98dwSVvUePjqEKaj61G2RLSAflTspvoUU22F8AJx9xF9po4E5eOj2eKbpevzgSr98xNJ68By/s0bsML748M8xpUBpBKN0pOG4CG6hgwbh6+ZGI4nkffPoA+QgaLxYJXCBVfS09Hzk4P8Dne8v0wR/qpARsaS4LcC8VdCc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PT3MiuUU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PT3MiuUU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35AB5C433F1; Wed, 3 Apr 2024 08:08:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131700; bh=lKYFOQA74WUrBNKESAlJ+e055R+fsTrHN/bgM387ZAQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PT3MiuUUoRKbKfg8e79CuzUU5j8DeVThGzzSbXP7Tufl9ihYjw23nkR2j6Gd+bsfK PmiK96NULKtD+T4PKVP4quu4w6VnbNK3ZmBfRcH+I5gCpO9m3IWlsbsUt2oaf+oqV7 m0rMmCJvslOmatp2uk4KVRu9lK9+y9jAU1UbL+SuNFtnW0wdQpSAhg0vZiuTo+PPHc 1ytWDH+QHejAcipmgYlY8tOIVRARva9FTd1Q9quxbwpC68c3HQ+5UfXWkdcakGg41B evlQBxwb3xDk4fXhi8GcHRTntCZVcARhXa0mCemSvoT2kEXem8H5EGDhiGhBvSNjT0 p31fbxHliBgXg== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Arnd Bergmann , netdev@vger.kernel.org Subject: [PATCH 05/34] 3c515: remove unused 'mtu' variable Date: Wed, 3 Apr 2024 10:06:23 +0200 Message-Id: <20240403080702.3509288-6-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann This has never been used since the start of the git history. When building with W=3D1, the unused variable produces a gcc warning: drivers/net/ethernet/3com/3c515.c:35:18: error: 'mtu' defined but not used = [-Werror=3Dunused-const-variable=3D] Just remove it. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/3com/3c515.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/3com/3c515.c b/drivers/net/ethernet/3com/= 3c515.c index ba3e7aa1a28f..4725a8cfd695 100644 --- a/drivers/net/ethernet/3com/3c515.c +++ b/drivers/net/ethernet/3com/3c515.c @@ -31,9 +31,6 @@ Setting to > 1512 effectively disables this feature. */ static int rx_copybreak =3D 200; =20 -/* Allow setting MTU to a larger size, bypassing the normal ethernet setup= . */ -static const int mtu =3D 1500; - /* Maximum events (Rx packets, etc.) to handle at each interrupt. */ static int max_interrupt_work =3D 20; =20 --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47ACD823DF; Wed, 3 Apr 2024 08:08:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131712; cv=none; b=S48V1bhV10+i7NqaZpvu9nx4CTPU8/FzLEP0XRiIwIS0b+q8ZfU7D49T7/qLpjbFdSUikZIRRLCa/yE6KsLCW8jQfcVJliO3mUx84DyhcnAwPaGcoVGx6I9evQO1Hinifc7BD/67I1Fs3aU1tajk1R0QPdZ1V5tQPpoCcM84DKg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131712; c=relaxed/simple; bh=l8thGNKJJbETb0CvQ4KQ0CUGk7po5gBhYYwAGbPFY2A=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=H9FctXtTzcjzNiKIHsMqVuTU+DRBedbizp3VzJJSdAS2PJNgTIfqJvmeS9og7B9YmGN3FFemBZfQIHBUKEOX3Zq8VWOt0xq0pyotP0EJnxhBokmsA+sZkK5GfMHGK/51CXAFPgD7X1XwtoyoHfL4n/McXQJ0U+L9ugCqx90biNQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MND/xHM6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MND/xHM6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4245AC433C7; Wed, 3 Apr 2024 08:08:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131712; bh=l8thGNKJJbETb0CvQ4KQ0CUGk7po5gBhYYwAGbPFY2A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MND/xHM6qa2MiY9G7TJkiu2MvxTqZkG72ygQajBZtSk5mFy4ofP3WGbUTtdwp8qK1 UGLOouFC0JA6sgN3lgR6X1zdD3e+EjwLhuqnzPAn1lLtkxREZqOBYdz12TTokECuLE D0DZwJj0vWebcFS679BeDWzLOr8p4VEI1DNWcat81AK7BdJMSgYJWvHZz2nPdKCf2f 2ErVqjTKG647fLlxfy7JOGODAQWrLsByzOc2FlmGnzGm6lYNJ0fW16Sf+DZBxEsjl+ IXFdaCXcVAVMSR7l1/kjYCSAjOmDvnLCN5BzOKCvRFDx7x2lzvsz6eKHHWieOUMsUA lFZD2M2Ec4kqQ== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Steven Rostedt , Masami Hiramatsu , Oleg Nesterov Cc: Arnd Bergmann , Mathieu Desnoyers , Zheng Yejian , Kees Cook , Ajay Kaher , Jinjie Ruan , =?UTF-8?q?Cl=C3=A9ment=20L=C3=A9ger?= , Dan Carpenter , "Tzvetomir Stoyanov (VMware)" , linux-trace-kernel@vger.kernel.org Subject: [PATCH 06/34] tracing: hide unused ftrace_event_id_fops Date: Wed, 3 Apr 2024 10:06:24 +0200 Message-Id: <20240403080702.3509288-7-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann When CONFIG_PERF_EVENTS, a 'make W=3D1' build produces a warning about the unused ftrace_event_id_fops variable: kernel/trace/trace_events.c:2155:37: error: 'ftrace_event_id_fops' defined = but not used [-Werror=3Dunused-const-variable=3D] 2155 | static const struct file_operations ftrace_event_id_fops =3D { Hide this in the same #ifdef as the reference to it. Fixes: 620a30e97feb ("tracing: Don't pass file_operations array to event_cr= eate_dir()") Signed-off-by: Arnd Bergmann --- kernel/trace/trace_events.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index 7c364b87352e..52f75c36bbca 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c @@ -1670,6 +1670,7 @@ static int trace_format_open(struct inode *inode, str= uct file *file) return 0; } =20 +#ifdef CONFIG_PERF_EVENTS static ssize_t event_id_read(struct file *filp, char __user *ubuf, size_t cnt, loff_t *pp= os) { @@ -1684,6 +1685,7 @@ event_id_read(struct file *filp, char __user *ubuf, s= ize_t cnt, loff_t *ppos) =20 return simple_read_from_buffer(ubuf, cnt, ppos, buf, len); } +#endif =20 static ssize_t event_filter_read(struct file *filp, char __user *ubuf, size_t cnt, @@ -2152,10 +2154,12 @@ static const struct file_operations ftrace_event_fo= rmat_fops =3D { .release =3D seq_release, }; =20 +#ifdef CONFIG_PERF_EVENTS static const struct file_operations ftrace_event_id_fops =3D { .read =3D event_id_read, .llseek =3D default_llseek, }; +#endif =20 static const struct file_operations ftrace_event_filter_fops =3D { .open =3D tracing_open_file_tr, --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C513584FBA; Wed, 3 Apr 2024 08:08:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131719; cv=none; b=p/1m3M1E5RxwrtiIWG48aNV/sUEElzyBvpfCY2I6LQa4khjoZf8VyxdZqUhiuzvKCVciKprMTl0hK0hdKD0DKiH2usHsygxgtUS7qRzM4YQ8ZT47/wYIJUb57coNNx0avjSVsPkfF7Xl0kF/vxn+IV4yBeAN17RMY2ILTkO3qac= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131719; c=relaxed/simple; bh=3FgSuQ7tiSYGFrQ5YgtJKC7vrKzdmqUOX9CzJzQDHso=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PI37arfRXglia+LPQUTpcpxFo3RCZ2gZ5fqYTDsjfrgVFmsGSyBCiLFQegNIA+n5ohU7IQU3bJ1W5wCQvusb8lsyHVyWGp0CM2T/WkXYY1vxjYPbCLm5rXUDD83rqol9BF+VAPvCJBExKlG/lDq/XCeEt14uou3IjCuwwqopT+c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nxMBY/dL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nxMBY/dL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D1BBC433C7; Wed, 3 Apr 2024 08:08:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131719; bh=3FgSuQ7tiSYGFrQ5YgtJKC7vrKzdmqUOX9CzJzQDHso=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nxMBY/dLT6CayFR5A/KNDA9+vTisu7sftWa5Fvqb/eWp5hcNJVBZxE9PlPmmG0QXZ PMutL9J0QSHGMavbJbyARu2AUBjoIc+3iSnRqlG0axBXj/qfXEED6BpTlolCLYUMOj ezmb4Sd4u19bTzrzPZBjQ267Nwk8617FXcMyq6nCqmafQWbowELlaEoijdQv6RWuKJ ULjhPLhit5npJ+VXlpwMZ7Xdy6KT9Qph/ZBNCTOBM1xBHql8FNz7ybTgT3dzMFonXw T1Ga5mqfORgR30VA1C3RLnZnowT51tCaV2hczw1rvEgp7DBkjzev151PGQBnGvDbs3 QJ2+o6Xmk6guw== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Dmitry Torokhov , Maxime Coquelin , Alexandre Torgue Cc: Krzysztof Kozlowski , Arnd Bergmann , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH 07/34] Input: stmpe-ts - mark OF related data as maybe unused Date: Wed, 3 Apr 2024 10:06:25 +0200 Message-Id: <20240403080702.3509288-8-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Krzysztof Kozlowski When compile tested with W=3D1 on x86_64 with driver as built-in: stmpe-ts.c:371:34: error: unused variable 'stmpe_ts_ids' [-Werror,-Wunuse= d-const-variable] Signed-off-by: Krzysztof Kozlowski Signed-off-by: Arnd Bergmann --- drivers/input/touchscreen/stmpe-ts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscre= en/stmpe-ts.c index b204fdb2d22c..022b3e94266d 100644 --- a/drivers/input/touchscreen/stmpe-ts.c +++ b/drivers/input/touchscreen/stmpe-ts.c @@ -366,7 +366,7 @@ static struct platform_driver stmpe_ts_driver =3D { }; module_platform_driver(stmpe_ts_driver); =20 -static const struct of_device_id stmpe_ts_ids[] =3D { +static const struct of_device_id stmpe_ts_ids[] __maybe_unused =3D { { .compatible =3D "st,stmpe-ts", }, { }, }; --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B97DA839F7; Wed, 3 Apr 2024 08:08:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131726; cv=none; b=T2fHEObanKcY/TCei58VdxDb9WxOpL3fuea49phwh2K9ccgucmLnYLOGCbh1fonJSdEZ/pX6qHcE422EazH6jkzzDGxkWZlhoPoi68XJRzxgmcEs3U3EwVyowVSzy02LLIo+IoTR2bxxU/9AIhEUGzz9NfSxeYhJhHa3IWOVPLI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131726; c=relaxed/simple; bh=FdHqMqMo9sUCpqipxuKBSJYP0dDiQNo82fvPaq1PpTc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CJXR2LjZHxzQC6NZZ8hqT+omf+qy5YSfc43crrnRCL7dh6cPV97Knq9JrCeaVXUS+oFhMVuR6siMwSj1ulNCXk1HGlNBNyZe2FcBbIg1Xk0dmUHHgEi+h8uXJjFCReK8HkcolKoTh7CKLbBszFMTE2bE8mRkbPOcVimknyhZB0A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cr/P1UqD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cr/P1UqD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE870C433F1; Wed, 3 Apr 2024 08:08:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131726; bh=FdHqMqMo9sUCpqipxuKBSJYP0dDiQNo82fvPaq1PpTc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cr/P1UqDYRkzPKqWmBayNR3jsXD6jMn0kadZyFxqYE7IyvhZShvACgtnZHttX24IG r1JUFlP+XeTxLhjkf9rioOJNZDuspkIFHOuD9cjXIRhHsLmaiigk3Da/7Dui2ehupf nwl2kb0SRVwce6S20DGkI7cUjKWszmAY7dAiBNij74+qwVb7bS/ZkUweB77DTFIgbJ 3C0HVjZAaX13S9UvkBLXDa1GUYxy0hSgmFu3aU9eSzT+AnfaZhKidYmlZtxl1cueEw +Um7ksYhBu/qR2i+ILNCm8u5Mj993Z+Ln7r4uL+NW3t2VrrExsYg/XvJROJrSjLbDg hFlY7HeYvOqxg== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Dmitry Torokhov , Benjamin Tissoires Cc: Arnd Bergmann , =?UTF-8?q?Jos=C3=A9=20Pekkarinen?= , Raul Rangel , Jeffery Miller , linux-input@vger.kernel.org Subject: [PATCH 08/34] Input: synaptics: hide unused smbus_pnp_ids[] array Date: Wed, 3 Apr 2024 10:06:26 +0200 Message-Id: <20240403080702.3509288-9-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann When SMBUS is disabled, this is never referenced, causing a W=3D1 warning: drivers/input/mouse/synaptics.c:164:27: error: 'smbus_pnp_ids' defined but = not used [-Werror=3Dunused-const-variable=3D] Hide the array behind the same #ifdef as the code referencing it. Fixes: e839ffab0289 ("Input: synaptics - add support for Intertouch devices= ") Signed-off-by: Arnd Bergmann --- drivers/input/mouse/synaptics.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptic= s.c index 7a303a9d6bf7..bc22b75e64a7 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -161,6 +161,7 @@ static const char * const topbuttonpad_pnp_ids[] =3D { NULL }; =20 +#ifdef CONFIG_MOUSE_PS2_SYNAPTICS_SMBUS static const char * const smbus_pnp_ids[] =3D { /* all of the topbuttonpad_pnp_ids are valid, we just add some extras */ "LEN0048", /* X1 Carbon 3 */ @@ -195,6 +196,7 @@ static const char * const smbus_pnp_ids[] =3D { "SYN3257", /* HP Envy 13-ad105ng */ NULL }; +#endif =20 static const char * const forcepad_pnp_ids[] =3D { "SYN300D", --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07794811E7; Wed, 3 Apr 2024 08:08:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131740; cv=none; b=su4or7BFfNunVlPjnRn8cpg12Tqq/Kp+/8KTvNkDhdVUiyCDva6pQ3mhLXFCKRQthL12SoIZLFMmjpxiOcvbS0Ak/23rE45WFVI98bfgoe8lYglRNWIsgMBx1DSyWaVdr1mxkKspMm4dnO099N5Zhr1F/vE35B1mMRwILC9GSBQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131740; c=relaxed/simple; bh=X/fK2OdkpVR6C+bG/qhKxNGaMgR2KonaIsE01GrX9Sc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=k+XZO/EjtZ57sm7oiO1yaUcAVODPnAItn85++q+teZb5WuoLPBv9V/sF+6IN8VANn1YO91DsCZVnCCeBTNoi4iUp4KgU02QYWNhg3uBLpHcXFvdvtufww2kAGrRssWdfLSR032SJyVeExI1SYizxAXtMzkg2kwlfHPWRyx4h2mA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RZOnfFaY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RZOnfFaY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 964C3C433F1; Wed, 3 Apr 2024 08:08:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131739; bh=X/fK2OdkpVR6C+bG/qhKxNGaMgR2KonaIsE01GrX9Sc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RZOnfFaYvyXiyoYAQRLlANr35Zpb67OxxhuxvGgxH0VrCHjq9jozy+tKcGwZ38wAI AmeGN6klOXqXVhxuwSBHvAB9iA5NUHd9rWmK0kdrgn5fh0o1NHHzxcc+uTgllGiWcO fiG660QKYGH6pb3EHVtygPAX39MWImnmPPVVRMuTOob3WxhwMc/zxAs++zzQ/cNSBb JQ/nCyXAqVcTpUiJPOLNEroGe4ynv08QPavclC9sOyG3JQ/LIv8AnMy7AXzJWFjRtv gDpEnzBZfmZyIyRQXqO5vD03+/sbIPmYkVh9yiagXSR4Y5oiY6ba4FUeiLVE5N4wUN x7ynm0mD+c8+g== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Sebastian Reichel , Anda-Maria Nicolae , Krzysztof Kozlowski Cc: Arnd Bergmann , David Lechner , Rob Herring , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , linux-pm@vger.kernel.org Subject: [PATCH 09/34] power: rt9455: hide unused rt9455_boost_voltage_values Date: Wed, 3 Apr 2024 10:06:27 +0200 Message-Id: <20240403080702.3509288-10-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann The rt9455_boost_voltage_values[] array is only used when USB PHY support is enabled, causing a W=3D1 warning otherwise: drivers/power/supply/rt9455_charger.c:200:18: error: 'rt9455_boost_voltage_= values' defined but not used [-Werror=3Dunused-const-variable=3D] Enclose the definition in the same #ifdef as the references to it. Fixes: e86d69dd786e ("power_supply: Add support for Richtek RT9455 battery = charger") Signed-off-by: Arnd Bergmann --- drivers/power/supply/rt9455_charger.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/power/supply/rt9455_charger.c b/drivers/power/supply/r= t9455_charger.c index c345a77f9f78..e4dbacd50a43 100644 --- a/drivers/power/supply/rt9455_charger.c +++ b/drivers/power/supply/rt9455_charger.c @@ -192,6 +192,7 @@ static const int rt9455_voreg_values[] =3D { 4450000, 4450000, 4450000, 4450000, 4450000, 4450000, 4450000, 4450000 }; =20 +#if IS_ENABLED(CONFIG_USB_PHY) /* * When the charger is in boost mode, REG02[7:2] represent boost output * voltage. @@ -207,6 +208,7 @@ static const int rt9455_boost_voltage_values[] =3D { 5600000, 5600000, 5600000, 5600000, 5600000, 5600000, 5600000, 5600000, 5600000, 5600000, 5600000, 5600000, 5600000, 5600000, 5600000, 5600000, }; +#endif =20 /* REG07[3:0] (VMREG) in uV */ static const int rt9455_vmreg_values[] =3D { --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFDB66BB2F; Wed, 3 Apr 2024 08:09:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131749; cv=none; b=jVDxWVWOH+jYdDJZ+ekBjMGYGy7FDkOUJf/GwAC/VihjFeEzvmJqZ+fLENe34FZrd1b5G70JgCx2ZQeOte7wl7p+Z57oiN27HrvGaB382H0Yk8IFHUf119BQHJobQUokwtbVXH6Iu1Gdok6b52cx1bdfgDov/UTJ/NeB3qZ3gX4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131749; c=relaxed/simple; bh=6hTjKP6WBOCL/0dZJm2MA9w9IJCqbMQSjTLYDwQEjY4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=q94EUFAr37AjyeGxkF9KkbZHnC23tOCqrWIu1Hc2X+bIOs1l4iGl0ZeQNnpPb++VeY6MA44lbX0BFFw9jTCQ4NQi1ohVmBHub5jlSSv+pPPsr1PlJBAQrX9QZuVRLdb7vdVBfWc6ekMN1KeqUp4gfnfX7HdmWtsZzYnU055Al+c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=l/8zCn6N; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="l/8zCn6N" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4667CC433C7; Wed, 3 Apr 2024 08:09:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131748; bh=6hTjKP6WBOCL/0dZJm2MA9w9IJCqbMQSjTLYDwQEjY4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l/8zCn6NLbDyqzej6+yt2TFIWP7PIg7HiHXdCQJTFoDO4X3FezNWc74lPih5w58/b 4SHUoSGfn3/vxivbPxIElkwdeoq/D/yQabS63yJmL6JjCYomj+IqJ3DFZENlZ3TUoa rhZV2Pyvjd8OPOwzsYl/LdBV1F7oyyNXlGRJFLZGV2wt5XYnmRW1Up41u4ssWjuPb3 /tp3IdroXWZozQkG2q99BzZ84oIGuVuHWgl3SeB8uTqTmwLmPaYdZMOtyawfZiuHLv RwBJzDy4Lvwbm11hITuga07fsnbMW3ksH+f5fhy9szvFEMoA7d2dH6ANDpkRERrh44 pkPXTIlCQDMhQ== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Ard Biesheuvel , Javier Martinez Canillas , Randy Dunlap , Daniel Vetter Cc: Arnd Bergmann , Ilias Apalodimas , "Kirill A. Shutemov" , Tom Lendacky , "Borislav Petkov (AMD)" , Masahisa Kojima , "Rafael J. Wysocki" , Rob Herring , Saravana Kannan , Greg Kroah-Hartman , linux-efi@vger.kernel.org Subject: [PATCH 10/34] efi: sysfb: don't build when EFI is disabled Date: Wed, 3 Apr 2024 10:06:28 +0200 Message-Id: <20240403080702.3509288-11-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann With 'make W=3D1', there is a warning when EFI is turned off but sysfb_efi still gets built: drivers/firmware/efi/sysfb_efi.c:188:35: error: unused variable 'efifb_dmi_= system_table' [-Werror,-Wunused-const-variable] static const struct dmi_system_id efifb_dmi_system_table[] __initconst =3D { ^ drivers/firmware/efi/sysfb_efi.c:238:35: error: unused variable 'efifb_dmi_= swap_width_height' [-Werror,-Wunused-const-variable] static const struct dmi_system_id efifb_dmi_swap_width_height[] __initconst= =3D { ^ drivers/firmware/efi/sysfb_efi.c:297:28: error: unused function 'find_pci_o= verlap_node' [-Werror,-Wunused-function] static struct device_node *find_pci_overlap_node(void) There was an earlier patch to address the duplicate function definitions, b= ut that missed how we should not be building this file in the first place. Fixes: 15d27b15de96 ("efi: sysfb_efi: fix build when EFI is not set") Signed-off-by: Arnd Bergmann Acked-by: Ard Biesheuvel Acked-by: Javier Martinez Canillas --- drivers/firmware/efi/Makefile | 3 ++- drivers/firmware/efi/sysfb_efi.c | 2 -- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/efi/Makefile b/drivers/firmware/efi/Makefile index a2d0009560d0..3baf80d8cf81 100644 --- a/drivers/firmware/efi/Makefile +++ b/drivers/firmware/efi/Makefile @@ -30,7 +30,8 @@ obj-$(CONFIG_EFI_RCI2_TABLE) +=3D rci2-table.o obj-$(CONFIG_EFI_EMBEDDED_FIRMWARE) +=3D embedded-firmware.o obj-$(CONFIG_LOAD_UEFI_KEYS) +=3D mokvar-table.o =20 -obj-$(CONFIG_SYSFB) +=3D sysfb_efi.o +sysfb-$(CONFIG_SYSFB) +=3D sysfb_efi.o +obj-$(CONFIG_EFI) +=3D $(sysfb-y) =20 arm-obj-$(CONFIG_EFI) :=3D efi-init.o arm-runtime.o obj-$(CONFIG_ARM) +=3D $(arm-obj-y) diff --git a/drivers/firmware/efi/sysfb_efi.c b/drivers/firmware/efi/sysfb_= efi.c index cc807ed35aed..a8c982475f6b 100644 --- a/drivers/firmware/efi/sysfb_efi.c +++ b/drivers/firmware/efi/sysfb_efi.c @@ -346,7 +346,6 @@ static const struct fwnode_operations efifb_fwnode_ops = =3D { .add_links =3D efifb_add_links, }; =20 -#ifdef CONFIG_EFI static struct fwnode_handle efifb_fwnode; =20 __init void sysfb_apply_efi_quirks(void) @@ -372,4 +371,3 @@ __init void sysfb_set_efifb_fwnode(struct platform_devi= ce *pd) pd->dev.fwnode =3D &efifb_fwnode; } } -#endif --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B39B126F37; Wed, 3 Apr 2024 08:09:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131755; cv=none; b=TRkwSB3bdhaBgrN6tHfZIS3OElV9f+vqBUTJcRfqdlQVnwiEJgpwqt0M/Zc6d06JTDqiHPoXK+9ugLlKlLBet+Nn2iZOEFZlqQHxJePkKaovXZYOmwHVDLDGeR863fZ3n2frj0E82dfWIB8AHu1xihmPXwqjQCCbZ+AduCLb00g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131755; c=relaxed/simple; bh=1sDt+GFLOqYMSNPiXKXTrVCa07EMAL7XEpWDHoi1E8E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZzxZ2rosO4i1QAkKN2PRb+04PXmzOSf1e5iDcl8nIKtH8B8580UqNkwV/jE346wfEgDKS7b0+r0gGz5Cs5jSQiq29KOcElGr5jRmzPFA4iCnBwhB1cFU5DSeZM4f57dDsaaMPH9v+fwDMgsZbKF4diJO/paPzmKug/KX0TGY1no= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dtN/IBEm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dtN/IBEm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3E18C433F1; Wed, 3 Apr 2024 08:09:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131755; bh=1sDt+GFLOqYMSNPiXKXTrVCa07EMAL7XEpWDHoi1E8E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dtN/IBEmKR0kEELjtE64b9uYo33VFmQOEro53HsVUA5Tyk7u0mWyol3wogPq9Fmcv DxV3tU7nrmvfPvlj1OMmFtaCqVnVCouebduRKnGB+rXPui7AqMcmxAlWWfkTFJfirI auVbOPJriA8k8ROu4MVheOykXM0g4lnjLBQST2LgW9QYYV3A5c3x/Gz8mdkpeYt+n8 RGiU0WI+IX7osDfLOUYBnXgzMbyWd3pNOdwlKEOTYA+bXo/jriPzeSppwnYI7iKQJ6 NYh2trfpcwzr7tZKY2pwMaSjYYwagNaYOMKWGyjoTSqAWdF/OV7Re79mSjPGWXGe99 1qB6PyGHlcjMw== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Tero Kristo , Michael Turquette , Stephen Boyd Cc: Arnd Bergmann , linux-omap@vger.kernel.org, linux-clk@vger.kernel.org Subject: [PATCH 11/34] clk: ti: dpll: fix incorrect #ifdef checks Date: Wed, 3 Apr 2024 10:06:29 +0200 Message-Id: <20240403080702.3509288-12-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann Building with W=3D1 shows warnings about unused const variables like this o= ne: drivers/clk/ti/dpll.c:99:29: error: unused variable 'omap3_dpll_core_ck_ops= ' [-Werror,-Wunused-const-variable] static const struct clk_ops omap3_dpll_core_ck_ops =3D {}; The problem is that the #ifdef checks for some of the structures in this file have gone out of sync with the code referencing them. Update these to match the current usage. Signed-off-by: Arnd Bergmann Reviewed-by: Tony Lindgren --- drivers/clk/ti/dpll.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/clk/ti/dpll.c b/drivers/clk/ti/dpll.c index 403ec81f561b..3386bd1903df 100644 --- a/drivers/clk/ti/dpll.c +++ b/drivers/clk/ti/dpll.c @@ -34,8 +34,6 @@ static const struct clk_ops dpll_m4xen_ck_ops =3D { .save_context =3D &omap3_core_dpll_save_context, .restore_context =3D &omap3_core_dpll_restore_context, }; -#else -static const struct clk_ops dpll_m4xen_ck_ops =3D {}; #endif =20 #if defined(CONFIG_ARCH_OMAP3) || defined(CONFIG_ARCH_OMAP4) || \ @@ -95,11 +93,7 @@ static const struct clk_ops omap3_dpll_core_ck_ops =3D { .recalc_rate =3D &omap3_dpll_recalc, .round_rate =3D &omap2_dpll_round_rate, }; -#else -static const struct clk_ops omap3_dpll_core_ck_ops =3D {}; -#endif =20 -#ifdef CONFIG_ARCH_OMAP3 static const struct clk_ops omap3_dpll_ck_ops =3D { .enable =3D &omap3_noncore_dpll_enable, .disable =3D &omap3_noncore_dpll_disable, @@ -137,9 +131,13 @@ static const struct clk_ops omap3_dpll_per_ck_ops =3D { }; #endif =20 +#if defined(CONFIG_ARCH_OMAP4) || defined(CONFIG_SOC_OMAP5) || \ + defined(CONFIG_SOC_DRA7XX) || defined(CONFIG_SOC_AM33XX) || \ + defined(CONFIG_SOC_AM43XX) static const struct clk_ops dpll_x2_ck_ops =3D { .recalc_rate =3D &omap3_clkoutx2_recalc, }; +#endif =20 /** * _register_dpll - low level registration of a DPLL clock --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FFB686AC2 for ; Wed, 3 Apr 2024 08:09:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131764; cv=none; b=AHsT+HaMbToD/1PdCajXF0S+XmXjzgj0RN6QSDW/4W8vn6THmFwgjyPQhzKxqV/LaW1j90ZQ/KBHJN3XAioxgsoawtiknsOBjGWP1ijlD4UVBj85+Ljb9EaQYUrSHHn96IecQukT++lNjoQSocx+u5SP22OLL1QnPlLHWm//7GQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131764; c=relaxed/simple; bh=QeEJdvI21yAX1pv6uUc4i2mUyj5I2+1g2fdUe9NpeWc=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YF/nV49qTWmUhcBS4VvJ0dYgq19O1SNSOdYalDGDRekRrrS7Cpjm4i1o5QNPZv91M+Dkbyy+LdqwvDkLcwjVmQlsCg/AwT6dWsppLgFMvd4J9krE5VLwKboTs4HQlEMAqjWKKS15l4J36Wf+PlT2xc6u/u3B5n3fRN8f2lxFY1E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eMtmPVFm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eMtmPVFm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 601FCC433F1; Wed, 3 Apr 2024 08:09:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131763; bh=QeEJdvI21yAX1pv6uUc4i2mUyj5I2+1g2fdUe9NpeWc=; h=From:To:Subject:Date:In-Reply-To:References:From; b=eMtmPVFmPizrqsBphoKu1/BzEzjGFayQ7UB8noWwp1J76h7pCtjvjsUc4u68NlEII fFxdk9JIHpnJ9a+MBe8gitYe1aV4pXYgUPzat0Vi9V7GbEGP1W+4y6JQcw13YeymzV gp4KwHKcAp2UZR8R4Cw3QqA7HCWnDfhPuutixGkurExu1HdUXGcDUyBoN5wRLc74MW iw6vHOAW1lA8qbWMsbSmXatDN1ZsI4B1yhIMmZ2VFxlUEFE8/YMKn3kczPMxVets5M ZJv+8QYKN2cPYciQhSdtqx199BYJ3D2NWTnIFbu6ltNx8E7nruUNjBy7iTkvb300/u 0AhtPE0vGDaYQ== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Jiri Kosina , Arnd Bergmann , Greg Kroah-Hartman , Ralf Baechle Subject: [PATCH 12/34] apm-emulation: hide an unused variable Date: Wed, 3 Apr 2024 10:06:30 +0200 Message-Id: <20240403080702.3509288-13-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann The driver_version variable is only used inside of an #ifdef block, which leads to a W=3D1 warning: drivers/char/apm-emulation.c:144:19: error: 'driver_version' defined but no= t used [-Werror=3Dunused-const-variable=3D] Move this into the function using it. Fixes: 7726942fb15e ("[APM] Add shared version of APM emulation") Signed-off-by: Arnd Bergmann --- drivers/char/apm-emulation.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/char/apm-emulation.c b/drivers/char/apm-emulation.c index e795390b070f..53ce352f7197 100644 --- a/drivers/char/apm-emulation.c +++ b/drivers/char/apm-emulation.c @@ -141,9 +141,6 @@ static struct apm_queue kapmd_queue; =20 static DEFINE_MUTEX(state_lock); =20 -static const char driver_version[] =3D "1.13"; /* no spaces */ - - =20 /* * Compatibility cruft until the IPAQ people move over to the new @@ -435,6 +432,8 @@ static struct miscdevice apm_device =3D { */ static int proc_apm_show(struct seq_file *m, void *v) { + static const char driver_version[] =3D "1.13"; /* no spaces */ + struct apm_power_info info; char *units; =20 --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E924F8665A; Wed, 3 Apr 2024 08:09:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131773; cv=none; b=m4vpxnpDL7Ah/XwEJfNfooYyiUJsE2mE7dYSTc80QEa3cLUHc65jfIp5HFIq4LIa5b/1vbfWyhjEMcwMlm6B3m/hFm58mkRnIsjpa3KIaPpILL1WW3aWn2Qyss7dWACSJuI6k4CRjFLOhvyr9Gzxmvt8rzMFaa1EE4TGA0J4By4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131773; c=relaxed/simple; bh=FvIlBe77Yoh0MKWjYe9xoZT/FkLcQ+ILm2wyKc5MkhQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=I0xPPTxlTsXeCUKfKcLdjKlC6ajNnwqmpTBMmufLl4xI9VBxb5rQxkX8AswTBhBw+UkLyxFZCw7t9ZQpLqs8/TZ0enlCFZlFOd6AB5zJkawwes+pdjuYbPaomG6xpo8USudqklxpDzeeCSEQJyskIhlcw6uKIxq/Tb8xt12kV6g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RnbFzmjd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RnbFzmjd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B11AC43390; Wed, 3 Apr 2024 08:09:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131772; bh=FvIlBe77Yoh0MKWjYe9xoZT/FkLcQ+ILm2wyKc5MkhQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RnbFzmjdcQ30Sndx9lkziwpkmrab2NP+OVJvBb2yaxEFNr9FpWviNtIg1gorVVRei L70xsTLYzUCRe/lTrqA6icZWxYwqnUjd8HsI+E6FgfnFdYdwr6KlyJy3q2qWqJspTc 6jtYazoHB15Jahe4kdRKCzoOBEZljXCEQpr6hgTGdDOb0nsr3dgwh89azelMWhpb40 8qamJntci6zOE9vaHJu36X3BMs21LbZggER3B94qvzbaTDIgr0Vx/Ogiep25DnHlQA IJgIW+fS9xHPA3zozHqv6BbLZp69J7CsEoL2dDqLBABIasOTWDAtABcvctQaTTUzaz sDNsDcobDonKA== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Helge Deller , Arnd Bergmann , Bartlomiej Zolnierkiewicz Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 13/34] sisfb: hide unused variables Date: Wed, 3 Apr 2024 10:06:31 +0200 Message-Id: <20240403080702.3509288-14-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann Building with W=3D1 shows that a couple of variables in this driver are only used in certain configurations: drivers/video/fbdev/sis/init301.c:239:28: error: 'SiS_Part2CLVX_6' defined = but not used [-Werror=3Dunused-const-variable=3D] 239 | static const unsigned char SiS_Part2CLVX_6[] =3D { /* 1080i */ | ^~~~~~~~~~~~~~~ drivers/video/fbdev/sis/init301.c:230:28: error: 'SiS_Part2CLVX_5' defined = but not used [-Werror=3Dunused-const-variable=3D] 230 | static const unsigned char SiS_Part2CLVX_5[] =3D { /* 750p */ | ^~~~~~~~~~~~~~~ drivers/video/fbdev/sis/init301.c:211:28: error: 'SiS_Part2CLVX_4' defined = but not used [-Werror=3Dunused-const-variable=3D] 211 | static const unsigned char SiS_Part2CLVX_4[] =3D { /* PAL */ | ^~~~~~~~~~~~~~~ drivers/video/fbdev/sis/init301.c:192:28: error: 'SiS_Part2CLVX_3' defined = but not used [-Werror=3Dunused-const-variable=3D] 192 | static const unsigned char SiS_Part2CLVX_3[] =3D { /* NTSC, 525i, = 525p */ | ^~~~~~~~~~~~~~~ drivers/video/fbdev/sis/init301.c:184:28: error: 'SiS_Part2CLVX_2' defined = but not used [-Werror=3Dunused-const-variable=3D] 184 | static const unsigned char SiS_Part2CLVX_2[] =3D { | ^~~~~~~~~~~~~~~ drivers/video/fbdev/sis/init301.c:176:28: error: 'SiS_Part2CLVX_1' defined = but not used [-Werror=3Dunused-const-variable=3D] 176 | static const unsigned char SiS_Part2CLVX_1[] =3D { | ^~~~~~~~~~~~~~~ This started showing up after the definitions were moved into the source file from the header, which was not flagged by the compiler. Move the definition into the appropriate #ifdef block that already exists next to them. Fixes: 5908986ef348 ("video: fbdev: sis: avoid mismatched prototypes") Signed-off-by: Arnd Bergmann --- drivers/video/fbdev/sis/init301.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/sis/init301.c b/drivers/video/fbdev/sis/in= it301.c index a8fb41f1a258..09329072004f 100644 --- a/drivers/video/fbdev/sis/init301.c +++ b/drivers/video/fbdev/sis/init301.c @@ -172,7 +172,7 @@ static const unsigned char SiS_HiTVGroup3_2[] =3D { }; =20 /* 301C / 302ELV extended Part2 TV registers (4 tap scaler) */ - +#ifdef CONFIG_FB_SIS_315 static const unsigned char SiS_Part2CLVX_1[] =3D { 0x00,0x00, 0x00,0x20,0x00,0x00,0x7F,0x20,0x02,0x7F,0x7D,0x20,0x04,0x7F,0x7D,0x1F,= 0x06,0x7E, @@ -245,7 +245,6 @@ static const unsigned char SiS_Part2CLVX_6[] =3D { /*= 1080i */ 0xFF,0xFF, }; =20 -#ifdef CONFIG_FB_SIS_315 /* 661 et al LCD data structure (2.03.00) */ static const unsigned char SiS_LCDStruct661[] =3D { /* 1024x768 */ --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C70E98665A; Wed, 3 Apr 2024 08:09:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131782; cv=none; b=X5zNDYJCZEYQ0B6J4UoO71pfdzQLfDMYoQM35Gc33nxdvi+J7+Ks1RC2icT15tCWdRCgEQ+iDwjiIMv/FYkup2JFvXuAK7lnF4kDt59c5Q6LM0LdGZhSnPzKETsD7xAVjIEjeLnL+90LcH0/W+JDKgbBskQU82JYcuIMUJpabAw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131782; c=relaxed/simple; bh=7qsqH0LOymzYXB4GWBeD5Wb7ADrWcz+eYFLQOtLMhn0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=fohUacLglUdTTtHLaxI4JVEx+zPZzQzCmUWkpipUl7FtBGqY5eAo9MmrAQLJHBD6tfnL46pm3ywhSKQnPbL3HxQH4FmPqC1+8JoIwaOIkV/6UuwAnAIf9+6MuV5W/7ksZ7OBNW0YjmZ/4owjAjvZqaICrl3LHYHOFr1TgQyUWSs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QrlzbiVz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QrlzbiVz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3C06C433F1; Wed, 3 Apr 2024 08:09:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131782; bh=7qsqH0LOymzYXB4GWBeD5Wb7ADrWcz+eYFLQOtLMhn0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QrlzbiVz8QbmfIib4J3OYU4BOIrOjhCsy7HJjYd3nq1yYbaY+QP/p9/1g8S0EMgrW 9XdWtqndlfwLVhoRp2IULI0sKLRt1fHzqVhrBXG6/TW/3yvBf8ZIqMPEN5jteWUE7r f7Du+JzXpzdXLydduMpaARcakzrnsWpVk9HbLsEXOCSc1ORaEPo/dcrQ4+5MAUnbhm Cf7Fiiwa6icGeeYse5sLPeCUrnsevCa2UNW5BKkk0wFywIW6ib9G3d2A8k6KwxrLts Hv0FxdSYJaDXVcPRysoRQfkKQ7zDki7ab8oWVo0s7J7aONZamdGy2612a6usR1rHPD NIfIOouT+oi+g== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Christoph Hellwig , Marek Szyprowski , Arnd Bergmann , Kyungmin Park , Michal Nazarewicz Cc: Robin Murphy , Yajun Deng , Binglei Wang , Anshuman Khandual , Andrew Morton , Zhenhua Huang , iommu@lists.linux.dev Subject: [PATCH 14/34] dma/congiguous: avoid warning about unused size_bytes Date: Wed, 3 Apr 2024 10:06:32 +0200 Message-Id: <20240403080702.3509288-15-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann When building with W=3D1, this variable is unused for configs with CONFIG_CMA_SIZE_SEL_PERCENTAGE=3Dy: kernel/dma/contiguous.c:67:26: error: 'size_bytes' defined but not used [-W= error=3Dunused-const-variable=3D] Mark it as __maybe_unused to avoid the warning without adding more ifdef checks to this file. Fixes: c64be2bb1c6e ("drivers: add Contiguous Memory Allocator") Signed-off-by: Arnd Bergmann --- kernel/dma/contiguous.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/dma/contiguous.c b/kernel/dma/contiguous.c index 055da410ac71..c53f4f633f7f 100644 --- a/kernel/dma/contiguous.c +++ b/kernel/dma/contiguous.c @@ -64,7 +64,7 @@ struct cma *dma_contiguous_default_area; * Users, who want to set the size of global CMA area for their system * should use cma=3D kernel parameter. */ -static const phys_addr_t size_bytes __initconst =3D +static const phys_addr_t size_bytes __initconst __maybe_unused =3D (phys_addr_t)CMA_SIZE_MBYTES * SZ_1M; static phys_addr_t size_cmdline __initdata =3D -1; static phys_addr_t base_cmdline __initdata; --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EAB284FD3; Wed, 3 Apr 2024 08:09:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131790; cv=none; b=NVYh7StEqjNwYsKP0TNXJM30g0OGXyKrRD0QeAMVlxl5CCk6Aw87IODcJK9r6HYx5MyeLqV/T71Ns9FugOTLDQGQfPzliwXCYg7Dy7a3bf9Ordtmma1WcuYh8BrhwLcEeh968vNWnFh3m3pz2DmgYepjRNciSnScWIH1itwnV6c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131790; c=relaxed/simple; bh=N9B1/h+N2wjlrIeRE4YeleUmB2UVWiJzUOQ8atEllXM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=plnsXOlJru8BH6kNsRuiZvPTeAbQiTxM8f63kuWgA7wfBg7qpoi6bASBsiJdg+nuZhW6pNBx5/lEy22l25bwUNN8Qy9y1G4eT/YGhj7z7QxoW7lvoNUZDTwr2We1hVe+E1EJsLO3UYaC5RVyuto651YuSl7ujj6ftbZoyZ0hpJ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vEQ6K0nu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vEQ6K0nu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1CCEC433F1; Wed, 3 Apr 2024 08:09:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131789; bh=N9B1/h+N2wjlrIeRE4YeleUmB2UVWiJzUOQ8atEllXM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vEQ6K0nuV/TLSHTv+lYRcs9uzwwB7Vyiys8pqRAkURJ9CAAZUj11k4ze3eDZWJtrD jBC7aB5dxl8mNgNiB8Pl/lYX86x7PL4LDi1fJznmbt0yv055Nno54zfIctKCbiJPkR 3r8tWetmuYV1lEl3GGi3dVlPIAh0lCt7h+wY+gMwdI+k9/PHa5OhHWiVj/7X0GdvfE 1VB0IIuSE8DIhV/npVSr4uTJCuGfbnlyf+0RWEPyR7o93bducZo0/5Vk0UJ9ZxgcsQ uE9E79RpRN6J5G1jHrKUNpfTuq8FPC6cE9fwh4BJXbPsu5lPjiAWk3Ceq3g8SEET0T NADHAJOAl8EbQ== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Pavel Machek , Lee Jones Cc: Arnd Bergmann , linux-leds@vger.kernel.org Subject: [PATCH 15/34] leds: apu: remove duplicate DMI lookup data Date: Wed, 3 Apr 2024 10:06:33 +0200 Message-Id: <20240403080702.3509288-16-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann Building with W=3D1 shows a warning about an unused dmi_system_id table: drivers/leds/leds-apu.c:85:35: error: 'apu_led_dmi_table' defined but not u= sed [-Werror=3Dunused-const-variable=3D] 85 | static const struct dmi_system_id apu_led_dmi_table[] __initconst = =3D { Since the current version doesn't even do anything about the different implementations but only checks the type of system, just drop the custom lookup logic and call dmi_check_system() using the table itself. Signed-off-by: Arnd Bergmann --- drivers/leds/leds-apu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/leds/leds-apu.c b/drivers/leds/leds-apu.c index c409b80c236d..1c116aaa9b6e 100644 --- a/drivers/leds/leds-apu.c +++ b/drivers/leds/leds-apu.c @@ -181,8 +181,7 @@ static int __init apu_led_init(void) struct platform_device *pdev; int err; =20 - if (!(dmi_match(DMI_SYS_VENDOR, "PC Engines") && - (dmi_match(DMI_PRODUCT_NAME, "APU") || dmi_match(DMI_PRODUCT_NAME, = "apu1")))) { + if (!dmi_check_system(apu_led_dmi_table)) { pr_err("No PC Engines APUv1 board detected. For APUv2,3 support, enable = CONFIG_PCENGINES_APU2\n"); return -ENODEV; } --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1EF91272C0; Wed, 3 Apr 2024 08:09:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131800; cv=none; b=CBltegfnWOjPxbtGN/ycuT93XE81F8XBRu7aaGoQmMT3wDFXV9cNrVAH2H8Du95Lsp5UvPs5ZytG9AKcMPgMnLUynql+6o62t/RwtlW8q3xv4syNX7MqP/nxtS1Jl1GR3ei/czGrI5n0oZPRiMvs1u3zr4RB01IKUzVF0NQ3DrQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131800; c=relaxed/simple; bh=pX6dYyDPlq8hzzGWYPenFWRCC5RcIISkFIbgpQbdAic=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=RUJYNYuiFsQhY9ER+aZ/AYNUV5cPB0puJ4a6VKowCqrJB9nIRDNKfB21ESMCMYx0CPB6ATSKrTBrEpurnZaioSws7RPJk6RmxmI4ibrL9s7P3hTArKBkDZGlgjtuKj+Ja7jCtysio4w8Z9iUbUetJTrFQ4ZQp1HlixqKkFI0bSk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PPo1hZbH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PPo1hZbH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BDC3C433F1; Wed, 3 Apr 2024 08:09:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131799; bh=pX6dYyDPlq8hzzGWYPenFWRCC5RcIISkFIbgpQbdAic=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PPo1hZbHq1OpuLsc+XNRFuEVSBFO6Rg1j5p54Ljrc1DIZRdU00w+JzXqBAN5oR7sv 2r8JjHioIIiG7s34QrVMlnAOW4YJ3h5WjcpBFMW6Xy0tEycOcCgsCm0EUgTer2XPuI UzAgPhvABQpHeDKIoDqQRXUoaf60SJZB3OVs3eXhwTDbFKYQK/vcn+r9C5pO58DKj0 nF+IMOoUiVvhaKQfhlUj00v9j1ZIyd3Uu8RKFFrC//bgjOuRjf3nphvEBKyFYnjThK JJjI42L6HpHSHGNKZQdRsSi1Ny5jcIF32hE8AmREWRfmM/SPffGCiJEMfvRxDJpxay 3f16whpPww5qA== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron Cc: Arnd Bergmann , linux-iio@vger.kernel.org Subject: [PATCH 16/34] iio: ad5755: hook up of_device_id lookup to platform driver Date: Wed, 3 Apr 2024 10:06:34 +0200 Message-Id: <20240403080702.3509288-17-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann When the driver is built-in, 'make W=3D1' warns about an unused ID table: drivers/iio/dac/ad5755.c:866:34: error: 'ad5755_of_match' defined but not u= sed [-Werror=3Dunused-const-variable=3D] 866 | static const struct of_device_id ad5755_of_match[] =3D { While the data is duplicated in the spi_device_id, it's common to use the actual OF compatible strings in the driver. Since there are no in-tree users of plain platform devices, the spi_device_id table could actually be dropped entirely with this. Signed-off-by: Arnd Bergmann Reviewed-by: Andy Shevchenko --- drivers/iio/dac/ad5755.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c index 404865e35460..5c1e7f428c25 100644 --- a/drivers/iio/dac/ad5755.c +++ b/drivers/iio/dac/ad5755.c @@ -876,6 +876,7 @@ MODULE_DEVICE_TABLE(of, ad5755_of_match); static struct spi_driver ad5755_driver =3D { .driver =3D { .name =3D "ad5755", + .of_match_table =3D ad5755_of_match, }, .probe =3D ad5755_probe, .id_table =3D ad5755_id, --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52F806EB5A; Wed, 3 Apr 2024 08:10:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131810; cv=none; b=u59flcTFd2Ao5W86Azb2aAbN9eWH8wEsKV6RMo2TdSAZ/e3O3iA0SiWWtzhoZaBsXQ7aOtUarPlLkBYks0QLkCUj6JKEBt+jMzn+3jKxa1zyPMPTTE62+5oMKcAMAj/5DJ63EoYfIOB/wHIfD80TVODqRw7tM8CoQpHaFgRJCkQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131810; c=relaxed/simple; bh=YUxw+JSGkdgbd3oVvBLP3CDDX0jDK0CN6nzZN82wE/Q=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=b2sLcPCdWyyNcJzFO7HyFiwdk8Rfy2seCjqAm5EqbvkX5NcVxrc1CggJvPPPbIFNaSWGxZyuZvOx5KIlXfcxa5xk/0aehtU9aNENd7E9ttaq/QKMCD2bmaCPco/AMrpx931AIW31Wp5hzTFUGJ27/9uKKlr/FpImdvCGFMEVFPM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QxNDM2If; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QxNDM2If" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60198C433C7; Wed, 3 Apr 2024 08:10:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131809; bh=YUxw+JSGkdgbd3oVvBLP3CDDX0jDK0CN6nzZN82wE/Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QxNDM2IfgT/4LkCcNfSjOYfKZDCIRGle4NjtwhZAuoqhvWzogfXiRev/PqTRZhzDh k1vHDrkUkJeg913HGLd1qMPO3mkyUBeXasBYHJuAOrJt7hmMZpUx6xtnLKbB/wDAXf Cw+C1mKhcgvIrsfrRrF8t/RQ2fAz2r1hPIcs2l66EZI5HcfklM5F3QTYka7ATJtwTg kwzQHrn1JbnF67VZPrHr/RA8GOOJts3+KlUBRw3bDql0tKsoOS3MQSyexR+7wxMcHy pq+Vlmfro/x/aSUqT2H4tHU5Xvxuo7QXtj6Ir0PvOveBI96WjN8bXSV0M+yxOhuS43 bmPGJLUttko+w== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Vaibhav Hiremath , Johan Hovold , Alex Elder , Greg Kroah-Hartman , Viresh Kumar Cc: Arnd Bergmann , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Luca Ceresoli , Rob Herring , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev Subject: [PATCH 17/34] greybus: arche-ctrl: move device table to its right location Date: Wed, 3 Apr 2024 10:06:35 +0200 Message-Id: <20240403080702.3509288-18-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann The arche-ctrl has two platform drivers and three of_device_id tables, but one table is only used for the the module loader, while the other two seem to be associated with their drivers. This leads to a W=3D1 warning when the driver is built-in: drivers/staging/greybus/arche-platform.c:623:34: error: 'arche_combined_id'= defined but not used [-Werror=3Dunused-const-variable=3D] 623 | static const struct of_device_id arche_combined_id[] =3D { Drop the extra table and register both tables that are actually used as the ones for the module loader instead. Fixes: 7b62b61c752a ("greybus: arche-ctrl: Don't expose driver internals to= arche-platform driver") Signed-off-by: Arnd Bergmann Reviewed-by: Alex Elder --- drivers/staging/greybus/arche-apb-ctrl.c | 1 + drivers/staging/greybus/arche-platform.c | 9 +-------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/staging/gre= ybus/arche-apb-ctrl.c index 8541995008da..aa6f266b62a1 100644 --- a/drivers/staging/greybus/arche-apb-ctrl.c +++ b/drivers/staging/greybus/arche-apb-ctrl.c @@ -466,6 +466,7 @@ static const struct of_device_id arche_apb_ctrl_of_matc= h[] =3D { { .compatible =3D "usbffff,2", }, { }, }; +MODULE_DEVICE_TABLE(of, arche_apb_ctrl_of_match); =20 static struct platform_driver arche_apb_ctrl_device_driver =3D { .probe =3D arche_apb_ctrl_probe, diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/gre= ybus/arche-platform.c index 891b75327d7f..b33977ccd527 100644 --- a/drivers/staging/greybus/arche-platform.c +++ b/drivers/staging/greybus/arche-platform.c @@ -619,14 +619,7 @@ static const struct of_device_id arche_platform_of_mat= ch[] =3D { { .compatible =3D "google,arche-platform", }, { }, }; - -static const struct of_device_id arche_combined_id[] =3D { - /* Use PID/VID of SVC device */ - { .compatible =3D "google,arche-platform", }, - { .compatible =3D "usbffff,2", }, - { }, -}; -MODULE_DEVICE_TABLE(of, arche_combined_id); +MODULE_DEVICE_TABLE(of, arche_platform_of_match); =20 static struct platform_driver arche_platform_device_driver =3D { .probe =3D arche_platform_probe, --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AC353E48E for ; Wed, 3 Apr 2024 08:10:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131818; cv=none; b=CaFlmEljzYHqDMKp8SanOArXHMRTMXx5Re2YNRjEPFmwr6Bg6vxY1+5d+eVGnpgOuoG9Rcypdc3vQho4XrSNOUI3j/Y7KDIppZ+uBkUIZHcrMeJTEgIFq4MJCj7oGNxBOsviSH3Rk0kC1MGnJaBfTIksLED7nebOLLayRsbqCNI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131818; c=relaxed/simple; bh=uzjOp0xr2MZStRulQupRQ+qP+V7YCJngXfY+4GCdPKU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=hpzZXvCjHbke76Jq4QfHDsG40n9x8+wmU+vYXwunmJ9znILJjXruTWW/x0qGZv6YVX6IUyRrgq15mvlDZmsMBLM/UJCLxkZpYyGrzQw/rWweeo/g2tXNAdRFp5dOuM0F6GPhDA302mqouD0huBro0IQPk+csj3d3a9FteTFsb2g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aduusoJp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aduusoJp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82E9FC433F1; Wed, 3 Apr 2024 08:10:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131818; bh=uzjOp0xr2MZStRulQupRQ+qP+V7YCJngXfY+4GCdPKU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aduusoJpFvmeo2xsPOKjpWaqWGcBrHBvvddO8Le6Ar23DmTL7t5YQDWDgzTZseKxm swaPV5HbHXgZtMbAVjuKdbGsmjnDLXubGoUAewJeZU7WKpCdDELcOW5bfs8VW0Sdhs eFs15OsS/B7w7v3M5oe7vDJfnmzqZ5VipT1QYdREN9dWfKY4CF42sAueDZFp/eLbRM 3AQ3BAqGiDs/1m1wJydFD6qSa/5xnF5UH/GLfKmg2DLh2WOyk+/ahRFxK33pugDrSU aUvumLZKGMWy0PI/g9gR3cEC73dvtMDbnI2O6fOEE3rtcA9azcrlWf0QXdX+Fj7Ike zglWpD+swPxRw== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Andrew Morton , Palmer Dabbelt Cc: Arnd Bergmann , Christophe Leroy , Dave Hansen , Noah Goldstein , Charlie Jenkins Subject: [PATCH 18/34] lib: checksum: hide unused expected_csum_ipv6_magic[] Date: Wed, 3 Apr 2024 10:06:36 +0200 Message-Id: <20240403080702.3509288-19-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann When CONFIG_NET is disabled, an extra warning shows up for this unused variable: lib/checksum_kunit.c:218:18: error: 'expected_csum_ipv6_magic' defined but = not used [-Werror=3Dunused-const-variable=3D] Hide it under the same #ifdef as the reference to it. Fixes: f24a70106dc1 ("lib: checksum: Fix build with CONFIG_NET=3Dn") Signed-off-by: Arnd Bergmann --- lib/checksum_kunit.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/checksum_kunit.c b/lib/checksum_kunit.c index bf70850035c7..80dd1e1b71ba 100644 --- a/lib/checksum_kunit.c +++ b/lib/checksum_kunit.c @@ -215,6 +215,7 @@ static const u32 init_sums_no_overflow[] =3D { 0xffff0000, 0xfffffffb, }; =20 +#ifdef CONFIG_NET static const u16 expected_csum_ipv6_magic[] =3D { 0x18d4, 0x3085, 0x2e4b, 0xd9f4, 0xbdc8, 0x78f, 0x1034, 0x8422, 0x6fc0, 0xd2f6, 0xbeb5, 0x9d3, 0x7e2a, 0x312e, 0x778e, 0xc1bb, 0x7cf2, 0x9d1e, @@ -240,6 +241,7 @@ static const u16 expected_csum_ipv6_magic[] =3D { 0x99aa, 0xb06b, 0xee19, 0xcc2c, 0xf34c, 0x7c49, 0xdac3, 0xa71e, 0xc988, 0x3845, 0x1014 }; +#endif =20 static const u16 expected_fast_csum[] =3D { 0xda83, 0x45da, 0x4f46, 0x4e4f, 0x34e, 0xe902, 0xa5e9, 0x87a5, 0x7187, --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21B326EB69; Wed, 3 Apr 2024 08:10:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131826; cv=none; b=uAI5pkgGucJoTX5nNzfuQOcxWKILrj4k4kpAQsLTLfh3Qn6yy5RKrLOLNTQ4zASL+fYUSl/LZRsYhKOtQZsa6yNoXCQycWwHfVP2wS+k5lEkVhGWZj+FghdKBDa9oxZY71vwePq4UERrXJCeyCVexaWWhrHqY+y1v2mVyI0Hfe0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131826; c=relaxed/simple; bh=WiucSDfey+Rb6VSKODVbCb1E0/6xwr83CCZttDwFyxE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UcmutEs423l2Vin/I7nPIeQEab+Yzrxn+cAB6hAJPpDA3KxKrpI55t21tTZr+wGQEm0PmN1jAaLwdo/VjcO1X7BYwn9pYccUJ+u5p/gCcobtTvXQZHjijZqTT+QXhiQBH8CURQTuGMC7SXMH5mWOezvAHoyWn8UXFr/SRIol4uo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Tz7ILvZD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Tz7ILvZD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85028C433C7; Wed, 3 Apr 2024 08:10:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131826; bh=WiucSDfey+Rb6VSKODVbCb1E0/6xwr83CCZttDwFyxE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Tz7ILvZDBSKlkXfydHLWZoo0LaYg/BPPpzBh4G9ExyldItTq+LggHRx356xDCgMgs iqDoFL52fC3ArfKjtL+Vn1yGtnlmb5hHMYUmXMo2xyMgRBqx6dMPka4uxyOyQMVMDs SzjXYwqzpShMZxzH6dbOaqLv7vU8odUsBvkPNXvalCCxRYeuH/uFF0A9kxdWhCgXlk g6wY/Pxa4Gh0HKTYvtJUC/hpHcO11BQUc9QnP1b6Ie+P6LGcX6IiRjpqdwS2UCWH+H F76jLFqc3FaCDhY55Pd6zfq88o0iXYgQuXpt2qgQYQXPznmM/FwvG52D4AmIm1sAWk LXB2BVTileS+A== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , NeilBrown , "J. Bruce Fields" Cc: Arnd Bergmann , Olga Kornievskaia , Dai Ngo , Tom Talpey , linux-nfs@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 19/34] sunrpc: suppress warnings for unused procfs functions Date: Wed, 3 Apr 2024 10:06:37 +0200 Message-Id: <20240403080702.3509288-20-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann There is a warning about unused variables when building with W=3D1 and no p= rocfs: net/sunrpc/cache.c:1660:30: error: 'cache_flush_proc_ops' defined but not u= sed [-Werror=3Dunused-const-variable=3D] 1660 | static const struct proc_ops cache_flush_proc_ops =3D { | ^~~~~~~~~~~~~~~~~~~~ net/sunrpc/cache.c:1622:30: error: 'content_proc_ops' defined but not used = [-Werror=3Dunused-const-variable=3D] 1622 | static const struct proc_ops content_proc_ops =3D { | ^~~~~~~~~~~~~~~~ net/sunrpc/cache.c:1598:30: error: 'cache_channel_proc_ops' defined but not= used [-Werror=3Dunused-const-variable=3D] 1598 | static const struct proc_ops cache_channel_proc_ops =3D { | ^~~~~~~~~~~~~~~~~~~~~~ These are used inside of an #ifdef, so replacing that with an IS_ENABLED() check lets the compiler see how they are used while still dropping them during dead code elimination. Fixes: dbf847ecb631 ("knfsd: allow cache_register to return error on failur= e") Signed-off-by: Arnd Bergmann Acked-by: Chuck Lever Reviewed-by: Jeff Layton --- net/sunrpc/cache.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c index 95ff74706104..ab3a57965dc0 100644 --- a/net/sunrpc/cache.c +++ b/net/sunrpc/cache.c @@ -1673,12 +1673,14 @@ static void remove_cache_proc_entries(struct cache_= detail *cd) } } =20 -#ifdef CONFIG_PROC_FS static int create_cache_proc_entries(struct cache_detail *cd, struct net *= net) { struct proc_dir_entry *p; struct sunrpc_net *sn; =20 + if (!IS_ENABLED(CONFIG_PROC_FS)) + return 0; + sn =3D net_generic(net, sunrpc_net_id); cd->procfs =3D proc_mkdir(cd->name, sn->proc_net_rpc); if (cd->procfs =3D=3D NULL) @@ -1706,12 +1708,6 @@ static int create_cache_proc_entries(struct cache_de= tail *cd, struct net *net) remove_cache_proc_entries(cd); return -ENOMEM; } -#else /* CONFIG_PROC_FS */ -static int create_cache_proc_entries(struct cache_detail *cd, struct net *= net) -{ - return 0; -} -#endif =20 void __init cache_initialize(void) { --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5664D12CDBE for ; Wed, 3 Apr 2024 08:10:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131832; cv=none; b=UhQgzWXpZ4RlNXgwxxaxA8Nw3Y54flO57XDiA+e86qJbpnJgVkaOpsO0Iy4Kyk2NmAb5I+D4nGTmZtTJY2EHvAu5Swu2dEJrfNr3n1K52j+O9D6k+H2onH+opYVNgv+FATf9vpMvvbl4WvP8ueW9EZL2cKdWvpfcHjQpLl2xWLI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131832; c=relaxed/simple; bh=aLO3cxXiffx87dLimQWP9nA/rRLONji1XWCMwWSXdsc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CSmZRJEq0GHBk6GHD7n+P4vApCyXriD+4Qnr1NkAe5FRIYSB/WjVDwvwgtnMXf/AQ/G/AMrRPsvhgBathSbCFrRXSAw8VeeUv9OJas530iQgfv3DZRrqAaAwVEIyqXzrNQeKhYXZAvR2mXGh7y371MknFRehkyXg4h5Hh8aSgx8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fgWmibZ6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fgWmibZ6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26808C433C7; Wed, 3 Apr 2024 08:10:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131832; bh=aLO3cxXiffx87dLimQWP9nA/rRLONji1XWCMwWSXdsc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fgWmibZ6ZAVyuwPXz7ayvE1R1QNNlcfOUDLR7RUCRl0XeoGld8MZrtOsneRgqCvjI Pe0Z/Cbyb3JW9+vRkOe2I3CGsOuqpNWLyRBo6VIcbfNtyJZ0gCDBMp31N7MXysszE1 PD95/YvlKZHk2W1dz5qN78Yc2aCfBqIiXavL2wPZWRuVBJSvN3m5R+3RCX3ODTOvUS uWi6PmVLQD40onTbamtFKxQqMVlD5ZnvGZUryfFr4KoKPfq3aaQflBGWHRqp3pqJdM 9y7Yek9xIG7sHXiWynUBLYqM3ma77Uhl+0/rqjW9HKZ6m6StdvWIcP9n8Q59RnhGCZ Sw+HBscTqSJJQ== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Ian Abbott , H Hartley Sweeten Cc: Arnd Bergmann Subject: [PATCH 20/34] comedi: ni_atmio: avoid warning for unused device_ids[] table Date: Wed, 3 Apr 2024 10:06:38 +0200 Message-Id: <20240403080702.3509288-21-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann When the driver is built-in, it produces a W=3D1 warning: drivers/comedi/drivers/ni_atmio.c:209:35: error: 'device_ids' defined but n= ot used [-Werror=3Dunused-const-variable=3D] 209 | static const struct pnp_device_id device_ids[] =3D { The actual probe() function has a different way of identifying the hardware, so just mark this one as __maybe_unused so it can be dropped when built-in. Signed-off-by: Arnd Bergmann --- drivers/comedi/drivers/ni_atmio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/comedi/drivers/ni_atmio.c b/drivers/comedi/drivers/ni_= atmio.c index 8876a1d24c56..09dece0994c2 100644 --- a/drivers/comedi/drivers/ni_atmio.c +++ b/drivers/comedi/drivers/ni_atmio.c @@ -206,7 +206,7 @@ static const int ni_irqpin[] =3D { =20 #include "ni_mio_common.c" =20 -static const struct pnp_device_id device_ids[] =3D { +static const struct pnp_device_id __maybe_unused device_ids[] =3D { {.id =3D "NIC1900", .driver_data =3D 0}, {.id =3D "NIC2400", .driver_data =3D 0}, {.id =3D "NIC2500", .driver_data =3D 0}, --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8288C6BFB1; Wed, 3 Apr 2024 08:10:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131841; cv=none; b=aE8hRn8oxiMLgHCYrPKkYRfZtkc5/wK7F0ad+hDjec/lfSezzzeZ7s5tlOS+BGjVlqhhiyUAG+jRt3Zdn6A/eULcPciezlWWr7tFf/XuoNlXv1i2ubRKpV8DUhTt52++MOzzAQIb2H/ICcHcpBz6/Eexw+zRKchITl4zFDYzI9g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131841; c=relaxed/simple; bh=scbLLLDqtrB9TaspkSSOEEh23gE81TK8M2IdXp0yn2s=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=HU8O+S0Vc/UjwVto2Q9AQasaJtSqes4fODfai2mxiPJBzehbm39iLefXORHthlwXIdR0M0ZFWFow2pQHYHOhAox/txK2e1zWjyLG/gR7IhSHqCRNecw7JGtMUidye4XvgjeZn2E1bn9kmtqaFVRSd8HV5ZjAmhqHRyvSu1C+Jf4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=h2tCLqZ2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="h2tCLqZ2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC647C433C7; Wed, 3 Apr 2024 08:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131841; bh=scbLLLDqtrB9TaspkSSOEEh23gE81TK8M2IdXp0yn2s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h2tCLqZ2Mkwj4qfJTjl79pz7c0Tt3i5UN6ga1h8uC00fXrcBHxHzGGRhT6HqpvSgr IoIWUE80Zo58Or0oBB/b+muUKZUu6HVnTIEIaIXZ0FIGnB2GxRLmeKff0PN5g67z+2 zIYFmkhntrN2+arCH1D8e+p3riteZk2wwdjmZhVLgl/Pxya+dssrpLbeREiqj+z8wQ ns4ftkDpvpz/uiMNnWkTsaboZ944P5MfndEcfTnCEvjvYIC+Zag+v69V1RbekmcjgI gcI0yXQWXBt5IhEPBs8ntNzeIOwMgJhTDbU/uxkTjItRkMuf7d3WwgabKyGK1JFiFw INEG+PwSnHLeg== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Stanislaw Gruszka , Kalle Valo Cc: Arnd Bergmann , linux-wireless@vger.kernel.org Subject: [PATCH 21/34] iwlegacy: don't warn for unused variables with DEBUG_FS=n Date: Wed, 3 Apr 2024 10:06:39 +0200 Message-Id: <20240403080702.3509288-22-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann The reference to il_rate_mcs is inside of an #ifdef, causing a W=3D1 warnin= g: drivers/net/wireless/intel/iwlegacy/4965-rs.c:189:38: error: unused variabl= e 'il_rate_mcs' [-Werror,-Wunused-const-variable] static const struct il_rate_mcs_info il_rate_mcs[RATE_COUNT] =3D { Replace the #ifdef with a PTR_IF() for better compile time analysis. The dead code will still get eliminated, but the warning goes away. Signed-off-by: Arnd Bergmann --- drivers/net/wireless/intel/iwlegacy/4965-rs.c | 15 ++------------- drivers/net/wireless/intel/iwlegacy/common.h | 2 -- 2 files changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/net/wireless/intel/iwlegacy/4965-rs.c b/drivers/net/wi= reless/intel/iwlegacy/4965-rs.c index 718efb1aa1b0..1aa2cee5d131 100644 --- a/drivers/net/wireless/intel/iwlegacy/4965-rs.c +++ b/drivers/net/wireless/intel/iwlegacy/4965-rs.c @@ -132,15 +132,8 @@ static void il4965_rs_fill_link_cmd(struct il_priv *il, static void il4965_rs_stay_in_table(struct il_lq_sta *lq_sta, bool force_search); =20 -#ifdef CONFIG_MAC80211_DEBUGFS static void il4965_rs_dbgfs_set_mcs(struct il_lq_sta *lq_sta, u32 *rate_n_flags, int idx); -#else -static void -il4965_rs_dbgfs_set_mcs(struct il_lq_sta *lq_sta, u32 * rate_n_flags, int = idx) -{ -} -#endif =20 /* * The following tables contain the expected throughput metrics for all ra= tes @@ -2495,8 +2488,6 @@ il4965_rs_free_sta(void *il_r, struct ieee80211_sta *= sta, void *il_sta) D_RATE("leave\n"); } =20 -#ifdef CONFIG_MAC80211_DEBUGFS - static void il4965_rs_dbgfs_set_mcs(struct il_lq_sta *lq_sta, u32 * rate_n_flags, int = idx) { @@ -2758,7 +2749,6 @@ il4965_rs_add_debugfs(void *il, void *il_sta, struct = dentry *dir) debugfs_create_u8("tx_agg_tid_enable", 0600, dir, &lq_sta->tx_agg_tid_en); } -#endif =20 /* * Initialization of rate scaling information is done by driver after @@ -2781,9 +2771,8 @@ static const struct rate_control_ops rs_4965_ops =3D { .free =3D il4965_rs_free, .alloc_sta =3D il4965_rs_alloc_sta, .free_sta =3D il4965_rs_free_sta, -#ifdef CONFIG_MAC80211_DEBUGFS - .add_sta_debugfs =3D il4965_rs_add_debugfs, -#endif + .add_sta_debugfs =3D PTR_IF(IS_ENABLED(CONFIG_DEBUG_FS), + il4965_rs_add_debugfs), }; =20 int diff --git a/drivers/net/wireless/intel/iwlegacy/common.h b/drivers/net/wir= eless/intel/iwlegacy/common.h index 69687fcf963f..b9f1daf0901b 100644 --- a/drivers/net/wireless/intel/iwlegacy/common.h +++ b/drivers/net/wireless/intel/iwlegacy/common.h @@ -2804,9 +2804,7 @@ struct il_lq_sta { struct il_scale_tbl_info lq_info[LQ_SIZE]; /* "active", "search" */ struct il_traffic_load load[TID_MAX_LOAD_COUNT]; u8 tx_agg_tid_en; -#ifdef CONFIG_MAC80211_DEBUGFS u32 dbg_fixed_rate; -#endif struct il_priv *drv; =20 /* used to be in sta_info */ --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 288FE13E8AB for ; Wed, 3 Apr 2024 08:10:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131858; cv=none; b=Eui4NkO8kh5T7qS4iOgnSyeFZnf3+/i04uKzglexSWmVMqMTNe3q/sSJzJU49C17M3yfbaLxhqGx1+C8T9botyBsgSpuCDLiZjwuTATtn57m2ZaE6uu7ZYrWwi06E6pdGwL9P9HXugdOVQFWe8mDDsudJyHdgcxw2t2I5Pu9TBQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131858; c=relaxed/simple; bh=SG0i7m/Qv+Wgr/oIlICWhiX3c3WYeQZoUHuUuYHJ3Mg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PA3R2gdS+CkRohezoq91eSXg0SwWr1Didbx89U9Px43Xt06o+eVMls/+KSeYMXF8pHFDiNVE+L3AeFINiPOCmAs53G0CSljfhegyF+9YVdhqcEROvwswdIMj+R6w7Be4QKR1rdhyCVwtb/ylMkoMBeE9XZtmmoomezZ77CFe2tE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NJRQk4h6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NJRQk4h6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A31ECC433F1; Wed, 3 Apr 2024 08:10:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131858; bh=SG0i7m/Qv+Wgr/oIlICWhiX3c3WYeQZoUHuUuYHJ3Mg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NJRQk4h6DbL0PRCv2v9sEcKs42xqNz/dxm75KgThlyRajdVuR078RQ02O7Izdo+ZZ LnK2cN6v+mPmgcHePdMATB3uWETGSzCoSJz5BBh+gbBFtlrzLAOtVzoTK9cKPTD3VX xoglKUzgdJlNV7lO9y0aBfZDI24awPTqxjbDGUnUTcOZxsNcWxCNIyZ+UqDVyYvmJO RYoSNwxAs2MVFI6FRMnpM6OyUArbDkXu+BieEVf366sDxQluFmBuH+PruUunNsQ9nZ NRi1r/PQPL/Svp9zyGT2Mai3oHNv3/DVU/reCWO2S9NvNWzVWNBW42fOs6BC3OmsjV h5Uy2eh2EdNIA== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , "James Qian Wang (Arm Technology China)" Cc: Arnd Bergmann , Rob Herring , dri-devel@lists.freedesktop.org Subject: [PATCH 22/34] drm/komeda: don't warn for unused debugfs files Date: Wed, 3 Apr 2024 10:06:40 +0200 Message-Id: <20240403080702.3509288-23-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann With debugfs disabled, the komeda_register debugfs file is unused: drivers/gpu/drm/arm/display/komeda/komeda_dev.c:44:1: error: unused variabl= e 'komeda_register_fops' [-Werror,-Wunused-const-variable] DEFINE_SHOW_ATTRIBUTE(komeda_register); The komeda_debugfs_init() function already has a call to debugfs_initialize= d() that ends up eliminating the file as dead code, so just drop the #ifdef to get rid of the warning. Fixes: 576832681891 ("arm/komeda: Compile komeda_debugfs_init() only if CON= FIG_DEBUG_FS is enabled") Fixes: 7d3cfb70a604 ("drm/komeda: Add debugfs node "register" for register = dump") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/= drm/arm/display/komeda/komeda_dev.c index 14ee79becacb..5ba62e637a61 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c @@ -12,10 +12,8 @@ #include #include #include -#ifdef CONFIG_DEBUG_FS #include #include -#endif =20 #include =20 @@ -43,7 +41,6 @@ static int komeda_register_show(struct seq_file *sf, void= *x) =20 DEFINE_SHOW_ATTRIBUTE(komeda_register); =20 -#ifdef CONFIG_DEBUG_FS static void komeda_debugfs_init(struct komeda_dev *mdev) { if (!debugfs_initialized()) @@ -55,7 +52,6 @@ static void komeda_debugfs_init(struct komeda_dev *mdev) debugfs_create_x16("err_verbosity", 0664, mdev->debugfs_root, &mdev->err_verbosity); } -#endif =20 static ssize_t core_id_show(struct device *dev, struct device_attribute *attr, char *buf) @@ -265,9 +261,7 @@ struct komeda_dev *komeda_dev_create(struct device *dev) =20 mdev->err_verbosity =3D KOMEDA_DEV_PRINT_ERR_EVENTS; =20 -#ifdef CONFIG_DEBUG_FS komeda_debugfs_init(mdev); -#endif =20 return mdev; =20 @@ -286,9 +280,7 @@ void komeda_dev_destroy(struct komeda_dev *mdev) =20 sysfs_remove_group(&dev->kobj, &komeda_sysfs_attr_group); =20 -#ifdef CONFIG_DEBUG_FS debugfs_remove_recursive(mdev->debugfs_root); -#endif =20 if (mdev->aclk) clk_prepare_enable(mdev->aclk); --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB05413F425; Wed, 3 Apr 2024 08:11:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131865; cv=none; b=Lknr5SAy5IBDZYaz7k3mhYeGWqBdz4uP9wTv1RKQBHYYoU1tPbN3KYY7hK9f7+RTJM6ImZp7cwOIldz2WXDmnAn2ZOkx6geyE5k8qU2AtH55HeKtrg3wPMtWDnaT6rpzVoljj8qAjWx1aluyUQKWKcYNSLCd7dYRKU3/INHwgd4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131865; c=relaxed/simple; bh=OaBdwzPyJFIVi5jKFEkNH3EGbx1qZe7R5hLgRTGjY10=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FwPPEnQU9zn8JWchAgJiK7yd7v995zwC5an1nO86GxoJfFCz8KpfyIfRc3A2paY5I8dYATlNvvMYynmy5bvp7TkoTqs/yNfYkPRJXZjNIrrwh+LedqtrEBRw/URa2cmsJMVgVP1cf/kVTtll42sEqC4TPQ5NIqVyO5EtPo6TCLo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dieCWAWH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dieCWAWH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15AACC433C7; Wed, 3 Apr 2024 08:11:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131865; bh=OaBdwzPyJFIVi5jKFEkNH3EGbx1qZe7R5hLgRTGjY10=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dieCWAWH/t+S3gm1titmmfw34OmJo5p9YVMk9/1Uormtij8W8tceyOmrivytapWsX EWDdidDv0ySuc5gEaYhSAPgVLRs2ay5OrkdfzCCqlCb+/ozQCPOBUcyo5Gj8SmAiE+ v69JV3/J0lM/b/yPxxg1aL/52EHjl/ZvZjJKBR03fOfubxUAs/w38qjIVYjbCxSl7D LWM6F9ubJa83zsL/POmMM5MzLOSqHbsmkub6gk323IGZdTBd0uQ+rBmBgVKUuiGidF H5FfNUMRix2ROhta0ylKMDpDda+GsOGdVHaZpiJNo80zxMoscMhJlYyNSIvfAIAM6a /w68aScpztvDQ== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Bjorn Andersson , Konrad Dybcio , Maximilian Luz , Johan Hovold Cc: Arnd Bergmann , Bartosz Golaszewski , Krzysztof Kozlowski , Kathiravan Thirumoorthy , Guru Das Srinagesh , Robert Marko , linux-arm-msm@vger.kernel.org Subject: [PATCH 23/34] firmware: qcom_scm: mark qcom_scm_qseecom_allowlist as __maybe_unused Date: Wed, 3 Apr 2024 10:06:41 +0200 Message-Id: <20240403080702.3509288-24-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann When CONFIG_OF is disabled, there is no reference to this variable: drivers/firmware/qcom/qcom_scm.c:1655:34: error: unused variable 'qcom_scm_= qseecom_allowlist' [-Werror,-Wunused-const-variable] static const struct of_device_id qcom_scm_qseecom_allowlist[] =3D { Mark it as __maybe_unused to hide this warning. Fixes: 00b1248606ba ("firmware: qcom_scm: Add support for Qualcomm Secure E= xecution Environment SCM interface") Signed-off-by: Arnd Bergmann --- drivers/firmware/qcom/qcom_scm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_= scm.c index 49ddbcab0680..81c15aeff934 100644 --- a/drivers/firmware/qcom/qcom_scm.c +++ b/drivers/firmware/qcom/qcom_scm.c @@ -1652,7 +1652,7 @@ EXPORT_SYMBOL_GPL(qcom_scm_qseecom_app_send); * We do not yet support re-entrant calls via the qseecom interface. To pr= event + any potential issues with this, only allow validated machines for now. */ -static const struct of_device_id qcom_scm_qseecom_allowlist[] =3D { +static const struct of_device_id qcom_scm_qseecom_allowlist[] __maybe_unus= ed =3D { { .compatible =3D "lenovo,thinkpad-x13s", }, { } }; --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC61C13F425; Wed, 3 Apr 2024 08:11:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131874; cv=none; b=U5bLDp4cAZWyckf5VobunivZfpKWoMrpN+XbecG3hyJFcnkbBJ64L1rHnIZijIhMzV+qb3X9WkeIuObGOICw80iYeQk/RwMgIhF9w9iL9jXXpgmGsO8XPUwqJKWxqWHu/GrK8nOoVWD1ZEs6dMqJTfBaanGMTppEz+hoqyYBBJE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131874; c=relaxed/simple; bh=76Xr54el70ulr/k/75H8vH6vpKWaADYSBbvRqxqkFes=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=HXR5mecq3xCzPcjLec/ui1oAOTdPI+po8ZpnBXF9Bkgj2pSpwKJx/xoJuSXPg5fmJLBd6GunRzeqOe03kvKYQxIuxOP6hwwNbZKxMxSWO+aMRh9P6+R7nSrOftMhKyosem5VHfp6AiQcbvX6wSsgswxXIBrq4n/USeGZCuhyoZE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FWv8o1wp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FWv8o1wp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0B06C433C7; Wed, 3 Apr 2024 08:11:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131873; bh=76Xr54el70ulr/k/75H8vH6vpKWaADYSBbvRqxqkFes=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FWv8o1wpk5CWOhTbZ+We/eBhRTQU2fOMPfrRiTyWHTfl/uKhv1Pgg6IEfoFtigE2G sVwmX8e+2XuUC0TULUzTfrjpk9oAm2+Mer2itkYt+5u5B8Ci2PqAuLJoIQ/D938/yi BtYtN2+p5vaUpLMAlgLQx3aaYs75HPsAs3V0WlcSWPwY1ulxe4iQg0yZv+t5+CtD8Q 72F9j2M45Tcoh1eSjGgdUIii9R5KwCHdWOhYKh2pY2yaAsEpsVPJnLldyA7p13BqAU vaCgiYHsZVoWe/nWy5MFTAmx/FpVfMcVlGIuMUi2dzhGn/rm9Kyo2M79jiO5PHn28S N1CPxhmkwHxRQ== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Tom Lendacky , John Allen , Herbert Xu , "David S. Miller" Cc: Arnd Bergmann , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , linux-crypto@vger.kernel.org Subject: [PATCH 24/34] crypto: ccp - drop platform ifdef checks Date: Wed, 3 Apr 2024 10:06:42 +0200 Message-Id: <20240403080702.3509288-25-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann When both ACPI and OF are disabled, the dev_vdata variable is unused: drivers/crypto/ccp/sp-platform.c:33:34: error: unused variable 'dev_vdata' = [-Werror,-Wunused-const-variable] This is not a useful configuration, and there is not much point in saving a few bytes when only one of the two is enabled, so just remove all these ifdef checks and rely on of_match_node() and acpi_match_device() returning NULL when these subsystems are disabled. Fixes: 6c5063434098 ("crypto: ccp - Add ACPI support") Signed-off-by: Arnd Bergmann Acked-by: Tom Lendacky --- drivers/crypto/ccp/sp-platform.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/crypto/ccp/sp-platform.c b/drivers/crypto/ccp/sp-platf= orm.c index 473301237760..ff6ceb4feee0 100644 --- a/drivers/crypto/ccp/sp-platform.c +++ b/drivers/crypto/ccp/sp-platform.c @@ -39,44 +39,38 @@ static const struct sp_dev_vdata dev_vdata[] =3D { }, }; =20 -#ifdef CONFIG_ACPI static const struct acpi_device_id sp_acpi_match[] =3D { { "AMDI0C00", (kernel_ulong_t)&dev_vdata[0] }, { }, }; MODULE_DEVICE_TABLE(acpi, sp_acpi_match); -#endif =20 -#ifdef CONFIG_OF static const struct of_device_id sp_of_match[] =3D { { .compatible =3D "amd,ccp-seattle-v1a", .data =3D (const void *)&dev_vdata[0] }, { }, }; MODULE_DEVICE_TABLE(of, sp_of_match); -#endif =20 static struct sp_dev_vdata *sp_get_of_version(struct platform_device *pdev) { -#ifdef CONFIG_OF const struct of_device_id *match; =20 match =3D of_match_node(sp_of_match, pdev->dev.of_node); if (match && match->data) return (struct sp_dev_vdata *)match->data; -#endif + return NULL; } =20 static struct sp_dev_vdata *sp_get_acpi_version(struct platform_device *pd= ev) { -#ifdef CONFIG_ACPI const struct acpi_device_id *match; =20 match =3D acpi_match_device(sp_acpi_match, &pdev->dev); if (match && match->driver_data) return (struct sp_dev_vdata *)match->driver_data; -#endif + return NULL; } =20 @@ -212,12 +206,8 @@ static int sp_platform_resume(struct platform_device *= pdev) static struct platform_driver sp_platform_driver =3D { .driver =3D { .name =3D "ccp", -#ifdef CONFIG_ACPI .acpi_match_table =3D sp_acpi_match, -#endif -#ifdef CONFIG_OF .of_match_table =3D sp_of_match, -#endif }, .probe =3D sp_platform_probe, .remove_new =3D sp_platform_remove, --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B00F13FD7E; Wed, 3 Apr 2024 08:11:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131881; cv=none; b=tzMb6HW6q+vRMHyyypMM7q7AtxV0/igkzveFSR+oX+ZgtNdzQ2bzOR+UGSfKbUH9qhxQgz27N8JSwKhpzD2c/OAcOzQqZ/UuqjG66RU359x1C+u9oEasLGq3hIiP3t4KKldZxbCSA+rFHS0rjtldY4qONBuxOu3TF5MMG67Fip0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131881; c=relaxed/simple; bh=0liwis3knuJplIlsLI48oLG63cRfb9QsB+onh6JK9F0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qd+fXwYgisTj935RvDXOzJQifb+k24in4rC1nl6zvRQo10Dlt4UvCI92zL1C0jg0nWw5ztUflz7XbOgVLTlN6Q0YNn1ejlvau4RNGUsW4RQQGjTMhoYg2fPemLv8J41FChR4m4ANBIAEP8weOD3q6Aayysp74SoEkFL+UFsOqiQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KA2BvgOZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KA2BvgOZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CCDDC433C7; Wed, 3 Apr 2024 08:11:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131880; bh=0liwis3knuJplIlsLI48oLG63cRfb9QsB+onh6JK9F0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KA2BvgOZ0aKADiJYSLZEt38u+ZxvwcPS5kbp9hKULRkrMO30PMZkChHNsikGdAPSZ a4fT2buKxH39mNkm+K3hGG6YhApMU1tf+Pk3MYGngKqYCXkbjwETYFG3pPDdEI7Bym lqTXztk2Y495V4EqJQ7TXXN37sIsRumgW3wyA/ao2JjdJrIBQZGY6qQSiZIKewOWyN pvaPlJVASLhLMBJ3MyWl8GmjN7Yip72P137ky2jfTjB7xkl1KNNIT/HACG9tRlkrSy gMlm/mD5ZJZ3bR7bhh/pL+K9zNAbDXUHqGwzAiZMqu8MuPRlw5AB/jnm3O50fdvmPZ DvRo3K+1oIfdw== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Greg Kroah-Hartman Cc: Arnd Bergmann , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Aaro Koskinen , linux-usb@vger.kernel.org Subject: [PATCH 25/34] usb: gadget: omap_udc: remove unused variable Date: Wed, 3 Apr 2024 10:06:43 +0200 Message-Id: <20240403080702.3509288-26-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann The driver_desc variable is only used in some configurations: drivers/usb/gadget/udc/omap_udc.c:113:19: error: unused variable 'driver_de= sc' [-Werror,-Wunused-const-variable] Since there is only ever one user of it, just open-code the string in place and remove the global variable and the macro behind it. This also helps grep for the MODULE_DESCRIPTION string. Signed-off-by: Arnd Bergmann Acked-by: Aaro Koskinen --- drivers/usb/gadget/udc/omap_udc.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/usb/gadget/udc/omap_udc.c b/drivers/usb/gadget/udc/oma= p_udc.c index f90eeecf27de..e13b8ec8ef8a 100644 --- a/drivers/usb/gadget/udc/omap_udc.c +++ b/drivers/usb/gadget/udc/omap_udc.c @@ -56,7 +56,6 @@ /* ISO too */ #define USE_ISO =20 -#define DRIVER_DESC "OMAP UDC driver" #define DRIVER_VERSION "4 October 2004" =20 #define OMAP_DMA_USB_W2FC_TX0 29 @@ -110,7 +109,6 @@ MODULE_PARM_DESC(use_dma, "enable/disable DMA"); =20 =20 static const char driver_name[] =3D "omap_udc"; -static const char driver_desc[] =3D DRIVER_DESC; =20 /*------------------------------------------------------------------------= -*/ =20 @@ -2299,13 +2297,11 @@ static int proc_udc_show(struct seq_file *s, void *= _) =20 spin_lock_irqsave(&udc->lock, flags); =20 - seq_printf(s, "%s, version: " DRIVER_VERSION + seq_printf(s, "OMAP UDC driver, version: " DRIVER_VERSION #ifdef USE_ISO " (iso)" #endif - "%s\n", - driver_desc, - use_dma ? " (dma)" : ""); + "%s\n", use_dma ? " (dma)" : ""); =20 tmp =3D omap_readw(UDC_REV) & 0xff; seq_printf(s, @@ -2994,6 +2990,6 @@ static struct platform_driver udc_driver =3D { =20 module_platform_driver(udc_driver); =20 -MODULE_DESCRIPTION(DRIVER_DESC); +MODULE_DESCRIPTION("OMAP UDC driver"); MODULE_LICENSE("GPL"); MODULE_ALIAS("platform:omap_udc"); --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C53FE6BFC2; Wed, 3 Apr 2024 08:11:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131893; cv=none; b=TIRx1sJQazHniDOMl2lxRw5oTJFmMyk587p0yrTV66M3Y6+00HWY4XTiDMJHrzbn8IedR7ouXL7ESS4zNY7qad7jstP2+sQNr1qbStOeyNhUCeA8enpfsbdvvG5BUhwec6cIZyZ7CHqr94Y3HzdT3j8ZyDs+Cg6R2XxV4TC6i0o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131893; c=relaxed/simple; bh=SH31gyLQOUjbQcsB8HrfJNW22dR7OQWuGrhgZCjvHU8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PXLgbXcXWJo5jR87y6N+M2qaHg5837eymDKdFOTlbfxnuU9ta3S8G/JYl26xecN2iYLoL56NdYFASS9hQfB0WiCwL+PQRnxA7CQkKvWK44lI9Zp3asY4F/7hdQv+k3c14Mh5fvzXuEGtXv+s8M15uzTB8h2d+5Pt9K3ImTsvBy4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FidQLK6g; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FidQLK6g" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD697C433F1; Wed, 3 Apr 2024 08:11:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131893; bh=SH31gyLQOUjbQcsB8HrfJNW22dR7OQWuGrhgZCjvHU8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FidQLK6gJYLaHmLSbMmJq7Apfm2CmmsGY0w8vFJ9AUgB5Uvdf+QMvV5PQKVWqQAsm UDMd2GxCQgrKO2Y4/qnJXh1w61ipZJlUbr0wgYopmxLFUXvny2uvMjnn/JGYWwXtIj M07HB74PU7sW9slUtYd/dghQLUoDL0ycxWajmLD3jCfbjHh8rUfLLB6pQbseX/wRgC cfIg9+Xx3szTAegVMFufdxt8Cj6BvbFapg8ir/FoHKNqqZmtd2bIDnZoh2EGuj+K0q OLpDs6Gn5QRKlNWmZt/Zg9ZIlPjf4h0g0l0adlbszBXPhIovybmrJFgeeYLiy/60LI B1j3vM0Uy+ung== From: Arnd Bergmann To: linux-kernel@vger.kernel.org Cc: Arnd Bergmann , Karsten Keil , Kees Cook , Justin Stitt , netdev@vger.kernel.org Subject: [PATCH 26/34] isdn: kcapi: don't build unused procfs code Date: Wed, 3 Apr 2024 10:06:44 +0200 Message-Id: <20240403080702.3509288-27-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann The procfs file is completely unused without CONFIG_PROC_FS but causes a compile time warning: drivers/isdn/capi/kcapi_proc.c:97:36: error: unused variable 'seq_controlle= r_ops' [-Werror,-Wunused-const-variable] static const struct seq_operations seq_controller_ops =3D { drivers/isdn/capi/kcapi_proc.c:104:36: error: unused variable 'seq_contrsta= ts_ops' [-Werror,-Wunused-const-variable] drivers/isdn/capi/kcapi_proc.c:179:36: error: unused variable 'seq_applicat= ions_ops' [-Werror,-Wunused-const-variable] drivers/isdn/capi/kcapi_proc.c:186:36: error: unused variable 'seq_applstat= s_ops' [-Werror,-Wunused-const-variable] Remove the file from the build in that config and make the calls into it conditional instead. Signed-off-by: Arnd Bergmann --- drivers/isdn/capi/Makefile | 3 ++- drivers/isdn/capi/kcapi.c | 7 +++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/isdn/capi/Makefile b/drivers/isdn/capi/Makefile index 352217ebabd8..4fd3a4d7133f 100644 --- a/drivers/isdn/capi/Makefile +++ b/drivers/isdn/capi/Makefile @@ -2,4 +2,5 @@ # Makefile for the CAPI subsystem used by BT_CMTP =20 obj-$(CONFIG_BT_CMTP) +=3D kernelcapi.o -kernelcapi-y :=3D kcapi.o capiutil.o capi.o kcapi_proc.o +kernelcapi-y :=3D kcapi.o capiutil.o capi.o +kernelcapi-$(CONFIG_PROC_FS) +=3D kcapi_proc.o diff --git a/drivers/isdn/capi/kcapi.c b/drivers/isdn/capi/kcapi.c index 136ba9fe55e0..c5d13bdc239b 100644 --- a/drivers/isdn/capi/kcapi.c +++ b/drivers/isdn/capi/kcapi.c @@ -917,13 +917,16 @@ int __init kcapi_init(void) return err; } =20 - kcapi_proc_init(); + if (IS_ENABLED(CONFIG_PROC_FS)) + kcapi_proc_init(); + return 0; } =20 void kcapi_exit(void) { - kcapi_proc_exit(); + if (IS_ENABLED(CONFIG_PROC_FS)) + kcapi_proc_exit(); =20 cdebug_exit(); destroy_workqueue(kcapi_wq); --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDC66130E57; Wed, 3 Apr 2024 08:11:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131901; cv=none; b=sp5Oipb80YDszH2ZRXtc0uh2Q9G0HwK01HDPt0zsQkP4xj9IwL0FuRhrJRkfn+dWhCvQQ6WN/w/gZ1bRTQ91ET9iwGAZhM8TS9rAvkynGPDmJK6RSvWBCABWtfv7M6J6wjEjakgKOL4uEAOfssh0LXnBsWFaIKhQ07EbbXiP/5k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131901; c=relaxed/simple; bh=fyLsfheaYKd+miTluYtO6pZInxaScKj0VFWPZBAzIGU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=I7prl7BFknCBKZz8DbSj/F5A912jKeYR9w7A+fLuDqpOHuJehT5rlpJhHEkjGJxyIJqx5LsprpnZ1ZCuzsS5u4IX7uEAj4byv1zZyfVUF0JmBM9My1wI4vr9U4OJFoCuLQ7TuI7P/BCr1RZHXVDeaSQCIfCcgQN0A3WMPjU9KDY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=teWmzofe; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="teWmzofe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50F61C43394; Wed, 3 Apr 2024 08:11:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131901; bh=fyLsfheaYKd+miTluYtO6pZInxaScKj0VFWPZBAzIGU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=teWmzofeqXsUSch/4hPcGgnIlL6++wfUzQ/aMHOB3ZobnXVoCyIFMH8yWP4rzUokd xLHRM1L+/MiUYpL7DQQVPR7XkVbV9kMCMHnpy8Cj4l2xVWozoKXSLAqaTIxyEaMqVu EFPVTEOgbvbzyTUoXlUtlL7C8Jvaj1izyxbLpiQj6A4yxmINwf8iKC2T2wuvry1vtP nFZo0zH9L/02AafTcmX5QnfdGueRXcpp8f3zLVcl/76FdJzrZLyHvCvxC4z4AD6eqN eQO7QleLc9udoJHnA8A29Y3x99qUELYditqPz05YQO00SyZKqk+Ik07N3V6+qntm+i 5qGlasuqMK4Hw== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Srinivas Pandruvada , Len Brown , "Rafael J. Wysocki" , Viresh Kumar Cc: Arnd Bergmann , Doug Smythies , Zhenguo Yao , Tero Kristo , "Jiri Slaby (SUSE)" , linux-pm@vger.kernel.org Subject: [PATCH 27/34] cpufreq: intel_pstate: hide unused intel_pstate_cpu_oob_ids[] Date: Wed, 3 Apr 2024 10:06:45 +0200 Message-Id: <20240403080702.3509288-28-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann The reference to this variable is hidden in an #ifdef: drivers/cpufreq/intel_pstate.c:2440:32: error: 'intel_pstate_cpu_oob_ids' d= efined but not used [-Werror=3Dunused-const-variable=3D] Use the same check around the definition. Signed-off-by: Arnd Bergmann --- drivers/cpufreq/intel_pstate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index dbbf299f4219..29ce9edc6f68 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c @@ -2437,6 +2437,7 @@ static const struct x86_cpu_id intel_pstate_cpu_ids[]= =3D { }; MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids); =20 +#ifdef CONFIG_ACPI static const struct x86_cpu_id intel_pstate_cpu_oob_ids[] __initconst =3D { X86_MATCH(BROADWELL_D, core_funcs), X86_MATCH(BROADWELL_X, core_funcs), @@ -2445,6 +2446,7 @@ static const struct x86_cpu_id intel_pstate_cpu_oob_i= ds[] __initconst =3D { X86_MATCH(SAPPHIRERAPIDS_X, core_funcs), {} }; +#endif =20 static const struct x86_cpu_id intel_pstate_cpu_ee_disable_ids[] =3D { X86_MATCH(KABYLAKE, core_funcs), --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF5F26FB80; Wed, 3 Apr 2024 08:11:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131910; cv=none; b=jPUUd16TyBqAPwi8LQPGqna8DBVYatdKW2q9/WmS8c4aNO7FjnBuKHf3KhMVJ5enmzwgghkKvJEInitUxFi9sLeqpsxi/VlvOqRRrWu8MVz1fv5yjOq9AVWmhvjHhCTfjEvUBgaweqrDSNEXlMccXlZYUEJ1v8WYfYsrmD47gfk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131910; c=relaxed/simple; bh=yJ2PAYn/BqgcesEAALoWnwKCP+9vQcY4vqPA3T6h0Fw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VQzzWP7DqWM8ErEg4h9xB9ZFX/p1mNq+xsH2dOBUiAu+bnP6HUeF4v9aPHQN2WwNipk0RoBye8eUAgGnWRWJfgE7FF4sWfEvITCMBGBSXbF8mvDECl/IsJQYiSq+DXtLlPePsVzDDhyx1gw+c/eVRCBJRJGQBqlrNZ9j5FLf0nw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kLElWixn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kLElWixn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FBC2C433C7; Wed, 3 Apr 2024 08:11:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131910; bh=yJ2PAYn/BqgcesEAALoWnwKCP+9vQcY4vqPA3T6h0Fw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kLElWixnuR6/r1TXlNW/C+kLhE4L3gwqjZqwBNB1iRvPKzM2ER7g+4niBeEOANZPJ lmmB7HNzp9Le5vlirfPPW7CRaTNmoWBc1263uW1C00fKh1e6g5UIFWWJIRVcPsnC2o kI7IXPUJ4BjGKD9hgARGtjLuW7Lzqf6UWsHz17AoMXRJUwaee993g73UWXtQ7fyWKM hQs4LlHUuM1bhfbn9Y7YibuU+N8vvA+aLy7bx/pjP1pO/IUIGiMtdkXWCnC7/LKOTk qiDxN3Gd2qWratpGIxHsSKjgZilvv8E3adxlwRmqq5yyZgcmiNeszjJCpV9oGqb65j N4yILxOWBTbBA== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Shyam Sundar S K , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Arnd Bergmann , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Rob Herring , netdev@vger.kernel.org Subject: [PATCH 28/34] net: xgbe: remove extraneous #ifdef checks Date: Wed, 3 Apr 2024 10:06:46 +0200 Message-Id: <20240403080702.3509288-29-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann When both ACPI and OF are disabled, xgbe_v1 is unused and causes a W=3D1 warning: drivers/net/ethernet/amd/xgbe/xgbe-platform.c:533:39: error: unused variabl= e 'xgbe_v1' [-Werror,-Wunused-const-variable] static const struct xgbe_version_data xgbe_v1 =3D { There is no real point in trying to save a few bytes for the match tables, so just make them always visible. Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/amd/xgbe/xgbe-platform.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-platform.c b/drivers/net/et= hernet/amd/xgbe/xgbe-platform.c index 9131020d06af..7912b3b45148 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-platform.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-platform.c @@ -538,7 +538,6 @@ static const struct xgbe_version_data xgbe_v1 =3D { .tx_tstamp_workaround =3D 1, }; =20 -#ifdef CONFIG_ACPI static const struct acpi_device_id xgbe_acpi_match[] =3D { { .id =3D "AMDI8001", .driver_data =3D (kernel_ulong_t)&xgbe_v1 }, @@ -546,9 +545,7 @@ static const struct acpi_device_id xgbe_acpi_match[] = =3D { }; =20 MODULE_DEVICE_TABLE(acpi, xgbe_acpi_match); -#endif =20 -#ifdef CONFIG_OF static const struct of_device_id xgbe_of_match[] =3D { { .compatible =3D "amd,xgbe-seattle-v1a", .data =3D &xgbe_v1 }, @@ -556,7 +553,6 @@ static const struct of_device_id xgbe_of_match[] =3D { }; =20 MODULE_DEVICE_TABLE(of, xgbe_of_match); -#endif =20 static SIMPLE_DEV_PM_OPS(xgbe_platform_pm_ops, xgbe_platform_suspend, xgbe_platform_resume); @@ -564,12 +560,8 @@ static SIMPLE_DEV_PM_OPS(xgbe_platform_pm_ops, static struct platform_driver xgbe_driver =3D { .driver =3D { .name =3D XGBE_DRV_NAME, -#ifdef CONFIG_ACPI .acpi_match_table =3D xgbe_acpi_match, -#endif -#ifdef CONFIG_OF .of_match_table =3D xgbe_of_match, -#endif .pm =3D &xgbe_platform_pm_ops, }, .probe =3D xgbe_platform_probe, --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5508B13329B; Wed, 3 Apr 2024 08:11:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131918; cv=none; b=TjgzEulotaOgTrXX5jeQ+nN321nImyoN7ffmUSTcraBCfE6sn07m4KoRGA2udEwTFxhThHpu49upJhkrGNpKtbMBbu+gEom9oCGGrt7RtX+1C3DFrsU28hwvw78WDYNdGi2WUoBdj2863ax1aEFbrLQgCYD35UiJ7fMtXiOY1aY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131918; c=relaxed/simple; bh=eTAXLTfSMqPzmGg1LsuyAG1Zp31dv3Dky44SOxHYxuE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cvz0JBAf2Uo0koZcHoKM74VyVdZFIb408kxpe9ooDm/G4d+umxuMJxdgYohIxSVimq6AYqov/0hGecGOsvQwFeQpW8jxqjy8KEGaSF37WeXH7ELre6JdT5+O+QGF8SA9aga6vq8G+UybWHEz+nN18G5/wVPAo39YDciWkZaWkO8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aWrRnUv4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aWrRnUv4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F0ADC433C7; Wed, 3 Apr 2024 08:11:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131918; bh=eTAXLTfSMqPzmGg1LsuyAG1Zp31dv3Dky44SOxHYxuE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aWrRnUv4lYXxKle69MNfRfBQK7ESJOlsoX3+1O6jaAa58kXkx/76YpEzDKxB4A0Kp HYpcT/Kz5LFT66zC94llHyVuTtej8K5hH8XeTdVyHAhvHCAydmsJRkTVMZpmKNQAGp ayrMPDNVedGE1y5Bs39aIdNRSYstABuoExbqWsoiVBOxvFLHgKuFAdOwbpRWgeHtt5 mLfyGf3RfYEvyUmLaYJM0ly9RhDoMwCSyJW3C60zerG9frwgZ6tHYBM3JbDcue/FsO wgC4Flt/z8UE7l/iJBMLwf+swLeJIPB8K90gVjaJ8Ex9yFl265ysKntswFJjsdEzK7 XhXWqQlQ65q6g== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Markuss Broks , Dmitry Torokhov , Karel Balej Cc: Arnd Bergmann , =?UTF-8?q?Duje=20Mihanovi=C4=87?= , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , linux-input@vger.kernel.org Subject: [PATCH 29/34] Input: imagis - remove incorrect ifdef checks Date: Wed, 3 Apr 2024 10:06:47 +0200 Message-Id: <20240403080702.3509288-30-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann When CONFIG_OF is disabled, three variables become unused: drivers/input/touchscreen/imagis.c:391:39: error: unused variable 'imagis_3= 032c_data' [-Werror,-Wunused-const-variable] drivers/input/touchscreen/imagis.c:399:39: error: unused variable 'imagis_3= 038b_data' [-Werror,-Wunused-const-variable] drivers/input/touchscreen/imagis.c:407:39: error: unused variable 'imagis_3= 038c_data' [-Werror,-Wunused-const-variable] There is no real point in building this driver without CONFIG_OF, so just remove the #ifdef checks and just always build this to avoids the warnings. Fixes: 10ad7d7a428f ("input/touchscreen: imagis: Add support for Imagis IST= 3038B") Signed-off-by: Arnd Bergmann --- drivers/input/touchscreen/imagis.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/input/touchscreen/imagis.c b/drivers/input/touchscreen= /imagis.c index 074dd6c342ec..d09b10f77a19 100644 --- a/drivers/input/touchscreen/imagis.c +++ b/drivers/input/touchscreen/imagis.c @@ -411,7 +411,6 @@ static const struct imagis_properties imagis_3038c_data= =3D { .whoami_val =3D IST3038C_WHOAMI, }; =20 -#ifdef CONFIG_OF static const struct of_device_id imagis_of_match[] =3D { { .compatible =3D "imagis,ist3032c", .data =3D &imagis_3032c_data }, { .compatible =3D "imagis,ist3038b", .data =3D &imagis_3038b_data }, @@ -419,13 +418,12 @@ static const struct of_device_id imagis_of_match[] = =3D { { }, }; MODULE_DEVICE_TABLE(of, imagis_of_match); -#endif =20 static struct i2c_driver imagis_ts_driver =3D { .driver =3D { .name =3D "imagis-touchscreen", .pm =3D pm_sleep_ptr(&imagis_pm_ops), - .of_match_table =3D of_match_ptr(imagis_of_match), + .of_match_table =3D imagis_of_match, }, .probe =3D imagis_probe, }; --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 289896FE0A; Wed, 3 Apr 2024 08:12:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131930; cv=none; b=WnzPsbCTxnBkY5HT+ybPVm/UWxsh82qa6XRCguWXGlN5D1JcWaY+63pF91JaW28y30y+bn1729JAqBd1WnmsMSSeJGFKir9XlO2s0fVtza3/COkI1zXRWgHMmVgfbP4i+EGu3U7q5rjhDU0hTGB9bl0/MrVJ3BGhs3Ybrj6KXlA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131930; c=relaxed/simple; bh=52e1Ac39U71liESsFrSjezSk4ZT9m1vPZPh5VYUBnRc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=A7SMnPjGG1U1BiujacU06+erruG2SKvm+QrnIgg/Z5JhZI68G68CdZtRTwqmHH8tH/V/j7rMzAr+AQRZ9G9TujIqgOhbsu/4vh/tIWAmf5HWYcHh1qGwgLnDZ/FKxGEzOstUtK/UE94WafPhQWoHqgbfmVMDxL4R5x+ahsnGUds= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sBb1RJYo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sBb1RJYo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0DEEC433F1; Wed, 3 Apr 2024 08:12:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131930; bh=52e1Ac39U71liESsFrSjezSk4ZT9m1vPZPh5VYUBnRc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sBb1RJYoR9VON/ie8xfuzugs666kkvQHoadEHobYWvOq+CDHvYKaMZ7g+DE0vjM4W e3bQ6ek/kFPpvSRJQhKBHj2VH5syEl4r0BikNhoeX1WrRaQ6rbT3EMCfv5d9YYuMv5 OISlqn3gt6/qn5XR+eTLI36T1gQDNemNJhCiHdI6ur7BRAa6uhuiftt6poJmMYcqj3 LNZmCrIAh4S9rU2j3z3EhnIBAtK2X0lPDXcHe9QJfvyWQTccR90Ta6VPP2ebyRf4Fl zpwdQl3hmHK4pfVxXKyoY9sAfB/+gVAD1VmYbwI0LbxLJzLt2cQo07Pzq/TmpfLbH7 PznqRuMaBJtpQ== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Damien Le Moal , Niklas Cassel , Saeed Bishara Cc: Arnd Bergmann , Ma Ke , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Sergey Shtylyov , Christophe JAILLET , Jeff Garzik , linux-ide@vger.kernel.org Subject: [PATCH 30/34] sata: mv: drop unnecessary #ifdef checks Date: Wed, 3 Apr 2024 10:06:48 +0200 Message-Id: <20240403080702.3509288-31-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann Building with W=3D1 shows a warning for an unused variable when CONFIG_PCI is diabled: drivers/ata/sata_mv.c:790:35: error: unused variable 'mv_pci_tbl' [-Werror,= -Wunused-const-variable] static const struct pci_device_id mv_pci_tbl[] =3D { Move the table into the same block that containsn the pci_driver definition. Fixes: 7bb3c5290ca0 ("sata_mv: Remove PCI dependency") Signed-off-by: Arnd Bergmann --- drivers/ata/sata_mv.c | 64 +++++++++++++++++++++---------------------- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index e82786c63fbd..697063890f5d 100644 --- a/drivers/ata/sata_mv.c +++ b/drivers/ata/sata_mv.c @@ -787,37 +787,6 @@ static const struct ata_port_info mv_port_info[] =3D { }, }; =20 -static const struct pci_device_id mv_pci_tbl[] =3D { - { PCI_VDEVICE(MARVELL, 0x5040), chip_504x }, - { PCI_VDEVICE(MARVELL, 0x5041), chip_504x }, - { PCI_VDEVICE(MARVELL, 0x5080), chip_5080 }, - { PCI_VDEVICE(MARVELL, 0x5081), chip_508x }, - /* RocketRAID 1720/174x have different identifiers */ - { PCI_VDEVICE(TTI, 0x1720), chip_6042 }, - { PCI_VDEVICE(TTI, 0x1740), chip_6042 }, - { PCI_VDEVICE(TTI, 0x1742), chip_6042 }, - - { PCI_VDEVICE(MARVELL, 0x6040), chip_604x }, - { PCI_VDEVICE(MARVELL, 0x6041), chip_604x }, - { PCI_VDEVICE(MARVELL, 0x6042), chip_6042 }, - { PCI_VDEVICE(MARVELL, 0x6080), chip_608x }, - { PCI_VDEVICE(MARVELL, 0x6081), chip_608x }, - - { PCI_VDEVICE(ADAPTEC2, 0x0241), chip_604x }, - - /* Adaptec 1430SA */ - { PCI_VDEVICE(ADAPTEC2, 0x0243), chip_7042 }, - - /* Marvell 7042 support */ - { PCI_VDEVICE(MARVELL, 0x7042), chip_7042 }, - - /* Highpoint RocketRAID PCIe series */ - { PCI_VDEVICE(TTI, 0x2300), chip_7042 }, - { PCI_VDEVICE(TTI, 0x2310), chip_7042 }, - - { } /* terminate list */ -}; - static const struct mv_hw_ops mv5xxx_ops =3D { .phy_errata =3D mv5_phy_errata, .enable_leds =3D mv5_enable_leds, @@ -4303,6 +4272,37 @@ static int mv_pci_init_one(struct pci_dev *pdev, static int mv_pci_device_resume(struct pci_dev *pdev); #endif =20 +static const struct pci_device_id mv_pci_tbl[] =3D { + { PCI_VDEVICE(MARVELL, 0x5040), chip_504x }, + { PCI_VDEVICE(MARVELL, 0x5041), chip_504x }, + { PCI_VDEVICE(MARVELL, 0x5080), chip_5080 }, + { PCI_VDEVICE(MARVELL, 0x5081), chip_508x }, + /* RocketRAID 1720/174x have different identifiers */ + { PCI_VDEVICE(TTI, 0x1720), chip_6042 }, + { PCI_VDEVICE(TTI, 0x1740), chip_6042 }, + { PCI_VDEVICE(TTI, 0x1742), chip_6042 }, + + { PCI_VDEVICE(MARVELL, 0x6040), chip_604x }, + { PCI_VDEVICE(MARVELL, 0x6041), chip_604x }, + { PCI_VDEVICE(MARVELL, 0x6042), chip_6042 }, + { PCI_VDEVICE(MARVELL, 0x6080), chip_608x }, + { PCI_VDEVICE(MARVELL, 0x6081), chip_608x }, + + { PCI_VDEVICE(ADAPTEC2, 0x0241), chip_604x }, + + /* Adaptec 1430SA */ + { PCI_VDEVICE(ADAPTEC2, 0x0243), chip_7042 }, + + /* Marvell 7042 support */ + { PCI_VDEVICE(MARVELL, 0x7042), chip_7042 }, + + /* Highpoint RocketRAID PCIe series */ + { PCI_VDEVICE(TTI, 0x2300), chip_7042 }, + { PCI_VDEVICE(TTI, 0x2310), chip_7042 }, + + { } /* terminate list */ +}; + =20 static struct pci_driver mv_pci_driver =3D { .name =3D DRV_NAME, @@ -4315,6 +4315,7 @@ static struct pci_driver mv_pci_driver =3D { #endif =20 }; +MODULE_DEVICE_TABLE(pci, mv_pci_tbl); =20 /** * mv_print_info - Dump key info to kernel log for perusal. @@ -4487,7 +4488,6 @@ static void __exit mv_exit(void) MODULE_AUTHOR("Brett Russ"); MODULE_DESCRIPTION("SCSI low-level driver for Marvell SATA controllers"); MODULE_LICENSE("GPL v2"); -MODULE_DEVICE_TABLE(pci, mv_pci_tbl); MODULE_VERSION(DRV_VERSION); MODULE_ALIAS("platform:" DRV_NAME); =20 --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8E685D8EB; Wed, 3 Apr 2024 08:13:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131982; cv=none; b=Jop4eVgEw8TwDolDOPlr179vUVKk7+KrcNJ/wM4Lbmuy9aOAEEVyy6M5mYi9j/NJBMOnRhOlPXoDQ9n+qNwj2DX8b6qGxhxBwRvFVYPFD0c6f7jMIcachO9uivBxxU2CCUfXGbwxDWUEGFCiekoQd1ygw1Ek7tITOFhe6iTwy2A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712131982; c=relaxed/simple; bh=s7PKCgenwuMtIpkuH0lS5FpL9JoQE1cUgYCVfEquDcE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=H9oN3D0/ArWPixfTUvLksd4Ld8a2mG3/PKW04CfYx5i3oKEUnKk5nXhueURAEhyKCnpyxbS3uqaaIi4LDAlkE8MAhuFnctRB+6qi/wcD1/oViN2c43VqFHbC+F9qSykIgYZKS0pGAC4VlecWGDhgcWL/ISm6tTgDIrb5MmF3HYI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rOePu4Gv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rOePu4Gv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A7A0C433F1; Wed, 3 Apr 2024 08:12:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712131981; bh=s7PKCgenwuMtIpkuH0lS5FpL9JoQE1cUgYCVfEquDcE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rOePu4Gvd7V3cltnm48rPPfQ5ofmjX+GDSCSetysHutysgHNuJEoCnupPctS10Bsx hqL8FluMuszm1Ww6kb2h9ndFt365zDSvm6q8QOk8LfTZwHcp0TTPbaVrlYNfKzSw44 1HmQwSAT6JhsiowgaDGcCaCcN9Lqe74+k6UwvwN2vvCBl2r4ITMuQq5eC9xknbHo18 Hyl3qSWl0EnJ36XlcsH7dgjLTWiKdg3Onx0lbmBzqIb4hEtGcFA/lYHz0hbWMK4PJq bzXtcLMqXrxY3tCTLsDSVBCkO0fbJbEv3ftmza4uIhbkbREWWxom0wMjjHtPFDcx4I DTrsllQrFjW/A== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Mark Brown , Neil Armstrong , Kevin Hilman , Heiko Stuebner , Andi Shyti , Krzysztof Kozlowski Cc: Arnd Bergmann , Jerome Brunet , Martin Blumenstingl , Alim Akhtar , Li Zetao , Jonathan Cameron , Rob Herring , Yang Yingliang , Andy Shevchenko , Luis de Arquer , Tudor Ambarus , Sam Protsenko , Peter Griffin , Jaewon Kim , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH 31/34] spi: remove incorrect of_match_ptr annotations Date: Wed, 3 Apr 2024 10:06:49 +0200 Message-Id: <20240403080702.3509288-32-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann When building with CONFIG_OF disabled but W=3D1 extra warnings enabled, a couple of driver cause a warning about an unused ID table: drivers/spi/spi-armada-3700.c:806:34: error: unused variable 'a3700_spi_dt_= ids' [-Werror,-Wunused-const-variable] drivers/spi/spi-orion.c:614:34: error: unused variable 'orion_spi_of_match_= table' [-Werror,-Wunused-const-variable] drivers/spi/spi-pic32-sqi.c:673:34: error: unused variable 'pic32_sqi_of_id= s' [-Werror,-Wunused-const-variable] drivers/spi/spi-pic32.c:850:34: error: unused variable 'pic32_spi_of_match'= [-Werror,-Wunused-const-variable] drivers/spi/spi-rockchip.c:1020:34: error: unused variable 'rockchip_spi_dt= _match' [-Werror,-Wunused-const-variable] drivers/spi/spi-s3c64xx.c:1642:34: error: unused variable 's3c64xx_spi_dt_m= atch' [-Werror,-Wunused-const-variable] drivers/spi/spi-st-ssc4.c:439:34: error: unused variable 'stm_spi_match' [-= Werror,-Wunused-const-variable] These appear to all be copied from the same original driver, so fix them at= the same time by removing the unnecessary of_match_ptr() annotation. As far as I can tell, all these drivers are only actually used on configurations that have CONFIG_OF enabled. Signed-off-by: Arnd Bergmann Reviewed-by: Andy Shevchenko --- drivers/spi/spi-armada-3700.c | 2 +- drivers/spi/spi-img-spfi.c | 2 +- drivers/spi/spi-meson-spicc.c | 2 +- drivers/spi/spi-meson-spifc.c | 2 +- drivers/spi/spi-orion.c | 2 +- drivers/spi/spi-pic32-sqi.c | 2 +- drivers/spi/spi-pic32.c | 2 +- drivers/spi/spi-rockchip.c | 2 +- drivers/spi/spi-s3c64xx.c | 2 +- drivers/spi/spi-st-ssc4.c | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/spi/spi-armada-3700.c b/drivers/spi/spi-armada-3700.c index 3c9ed412932f..2fc2e7c0daf2 100644 --- a/drivers/spi/spi-armada-3700.c +++ b/drivers/spi/spi-armada-3700.c @@ -902,7 +902,7 @@ static int a3700_spi_probe(struct platform_device *pdev) static struct platform_driver a3700_spi_driver =3D { .driver =3D { .name =3D DRIVER_NAME, - .of_match_table =3D of_match_ptr(a3700_spi_dt_ids), + .of_match_table =3D a3700_spi_dt_ids, }, .probe =3D a3700_spi_probe, }; diff --git a/drivers/spi/spi-img-spfi.c b/drivers/spi/spi-img-spfi.c index d8360f94d3b7..0d7f89301f8d 100644 --- a/drivers/spi/spi-img-spfi.c +++ b/drivers/spi/spi-img-spfi.c @@ -753,7 +753,7 @@ static struct platform_driver img_spfi_driver =3D { .driver =3D { .name =3D "img-spfi", .pm =3D &img_spfi_pm_ops, - .of_match_table =3D of_match_ptr(img_spfi_of_match), + .of_match_table =3D img_spfi_of_match, }, .probe =3D img_spfi_probe, .remove_new =3D img_spfi_remove, diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c index fc75492e50ff..4189d4434e37 100644 --- a/drivers/spi/spi-meson-spicc.c +++ b/drivers/spi/spi-meson-spicc.c @@ -946,7 +946,7 @@ static struct platform_driver meson_spicc_driver =3D { .remove_new =3D meson_spicc_remove, .driver =3D { .name =3D "meson-spicc", - .of_match_table =3D of_match_ptr(meson_spicc_of_match), + .of_match_table =3D meson_spicc_of_match, }, }; =20 diff --git a/drivers/spi/spi-meson-spifc.c b/drivers/spi/spi-meson-spifc.c index fd8b26dd4a79..0c39d59d0af8 100644 --- a/drivers/spi/spi-meson-spifc.c +++ b/drivers/spi/spi-meson-spifc.c @@ -432,7 +432,7 @@ static struct platform_driver meson_spifc_driver =3D { .remove_new =3D meson_spifc_remove, .driver =3D { .name =3D "meson-spifc", - .of_match_table =3D of_match_ptr(meson_spifc_dt_match), + .of_match_table =3D meson_spifc_dt_match, .pm =3D &meson_spifc_pm_ops, }, }; diff --git a/drivers/spi/spi-orion.c b/drivers/spi/spi-orion.c index eee9ff4bfa5b..a0029e8dc0be 100644 --- a/drivers/spi/spi-orion.c +++ b/drivers/spi/spi-orion.c @@ -843,7 +843,7 @@ static struct platform_driver orion_spi_driver =3D { .driver =3D { .name =3D DRIVER_NAME, .pm =3D &orion_spi_pm_ops, - .of_match_table =3D of_match_ptr(orion_spi_of_match_table), + .of_match_table =3D orion_spi_of_match_table, }, .probe =3D orion_spi_probe, .remove_new =3D orion_spi_remove, diff --git a/drivers/spi/spi-pic32-sqi.c b/drivers/spi/spi-pic32-sqi.c index 3f1e5b27776b..458c1a8d5719 100644 --- a/drivers/spi/spi-pic32-sqi.c +++ b/drivers/spi/spi-pic32-sqi.c @@ -679,7 +679,7 @@ MODULE_DEVICE_TABLE(of, pic32_sqi_of_ids); static struct platform_driver pic32_sqi_driver =3D { .driver =3D { .name =3D "sqi-pic32", - .of_match_table =3D of_match_ptr(pic32_sqi_of_ids), + .of_match_table =3D pic32_sqi_of_ids, }, .probe =3D pic32_sqi_probe, .remove_new =3D pic32_sqi_remove, diff --git a/drivers/spi/spi-pic32.c b/drivers/spi/spi-pic32.c index 709edb70ad7d..e8bd32c1fc7c 100644 --- a/drivers/spi/spi-pic32.c +++ b/drivers/spi/spi-pic32.c @@ -856,7 +856,7 @@ MODULE_DEVICE_TABLE(of, pic32_spi_of_match); static struct platform_driver pic32_spi_driver =3D { .driver =3D { .name =3D "spi-pic32", - .of_match_table =3D of_match_ptr(pic32_spi_of_match), + .of_match_table =3D pic32_spi_of_match, }, .probe =3D pic32_spi_probe, .remove_new =3D pic32_spi_remove, diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c index e1ecd96c7858..4dbb5127a9e5 100644 --- a/drivers/spi/spi-rockchip.c +++ b/drivers/spi/spi-rockchip.c @@ -1042,7 +1042,7 @@ static struct platform_driver rockchip_spi_driver =3D= { .driver =3D { .name =3D DRIVER_NAME, .pm =3D &rockchip_spi_pm, - .of_match_table =3D of_match_ptr(rockchip_spi_dt_match), + .of_match_table =3D rockchip_spi_dt_match, }, .probe =3D rockchip_spi_probe, .remove_new =3D rockchip_spi_remove, diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index f726d8670428..dbb89f6cb3dd 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1677,7 +1677,7 @@ static struct platform_driver s3c64xx_spi_driver =3D { .driver =3D { .name =3D "s3c64xx-spi", .pm =3D &s3c64xx_spi_pm, - .of_match_table =3D of_match_ptr(s3c64xx_spi_dt_match), + .of_match_table =3D s3c64xx_spi_dt_match, }, .probe =3D s3c64xx_spi_probe, .remove_new =3D s3c64xx_spi_remove, diff --git a/drivers/spi/spi-st-ssc4.c b/drivers/spi/spi-st-ssc4.c index e064025e2fd6..6d288497c500 100644 --- a/drivers/spi/spi-st-ssc4.c +++ b/drivers/spi/spi-st-ssc4.c @@ -446,7 +446,7 @@ static struct platform_driver spi_st_driver =3D { .driver =3D { .name =3D "spi-st", .pm =3D &spi_st_pm, - .of_match_table =3D of_match_ptr(stm_spi_match), + .of_match_table =3D stm_spi_match, }, .probe =3D spi_st_probe, .remove_new =3D spi_st_remove, --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7ECA5C61C; Wed, 3 Apr 2024 08:13:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712132001; cv=none; b=I/S5wx1DU0QNv0acmmBaht+efjhutOaBBvC/MqWiiGx3TfFW1zcpK8eVrcwTmcRu15WC/Kt2PpgyAo//bmG60DsjsWXVB/ClNSK8qa/q6M/tkez2vCf0LkSmnMos+0yQjabfZj/OTA1pxashDo87n8g/drg5t34TqgpOaqhPntM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712132001; c=relaxed/simple; bh=cHRmsqunH9hP/qtXbd35N4JkMuQoGtu0x3hJ4tAgdrY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=mDOtYeAq4SKBvWonitmtqvd7rnFfKFv4jHqVO+hi24byVjhsAAxeyvZkvg9w/0F4tIThyxZlTQbDBO2CX5D2w6Fpvmr1gLTzaKQtTiBjPhZmG8WXPYTMM9yim15xRxF7gJaEOmIAh0PRDKf+Zx0XyDPCDrOVnBMWa9tZ0HSdet0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mL4FfJyz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mL4FfJyz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95395C433C7; Wed, 3 Apr 2024 08:13:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712132000; bh=cHRmsqunH9hP/qtXbd35N4JkMuQoGtu0x3hJ4tAgdrY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mL4FfJyzLl9gsq+QwjOIrerxmGhTo6GDqw+UdiO+FN1TNPbQ1HU4hUHSq50YrgXyO hXHcEM4a1AfR/UMk2OlDEdOtkZ7hLM16HAr75p42zC3E/fZmTMFFvDziVxgFQIRCfO 0qPx53oM278y1D0ZnnomrHkf/8qt46zlW41rrmspumuSLR/CwOXBD8PAekA0tR4SV5 n6RyEQgcFzrrp4y18VqL/jxAFRC0t2QR05D1FAIqEsfiAca752UIyw7Aktq+IPx3TC n1oRUic3ZgN8V1orOq8yfxAiWatGMFmTrfPdsjirFu3CT0SmC51Inan5tHzb3m4Wdy OZORH7MZL3gMw== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Claudiu Beznea , Nicolas Ferre , Alexandre Belloni , Oder Chiou , Srinivas Kandagatla , Banajit Goswami , Sylwester Nawrocki Cc: Arnd Bergmann , Alper Nebi Yasak , Kuninori Morimoto , Akihiko Odaki , Linus Walleij , Yinchuan Guo , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Rob Herring , AngeloGioacchino Del Regno , Krzysztof Kozlowski , linux-sound@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 32/34] ASoC: remove incorrect of_match_ptr/ACPI_PTR annotations Date: Wed, 3 Apr 2024 10:06:50 +0200 Message-Id: <20240403080702.3509288-33-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann When building with CONFIG_OF and/or CONFIG_ACPI disabled but W=3D1 extra warnings enabled, a lot of driver cause a warning about an unused ID table: sound/soc/atmel/sam9x5_wm8731.c:187:34: error: unused variable 'sam9x5_wm87= 31_of_match' [-Werror,-Wunused-const-variable] sound/soc/codecs/rt5514-spi.c:496:34: error: unused variable 'rt5514_of_mat= ch' [-Werror,-Wunused-const-variable] sound/soc/samsung/aries_wm8994.c:524:34: error: unused variable 'samsung_wm= 8994_of_match' [-Werror,-Wunused-const-variable] The fix is always to just remove the of_match_ptr() and ACPI_PTR() wrappers that remove the reference, rather than adding another #ifdef just for build testing for a configuration that doesn't matter in practice. Signed-off-by: Arnd Bergmann Reviewed-by: Andy Shevchenko --- sound/soc/amd/acp3x-rt5682-max9836.c | 2 +- sound/soc/atmel/sam9x5_wm8731.c | 2 +- sound/soc/codecs/rt5514-spi.c | 2 +- sound/soc/qcom/lpass-sc7280.c | 2 +- sound/soc/samsung/aries_wm8994.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/soc/amd/acp3x-rt5682-max9836.c b/sound/soc/amd/acp3x-rt5= 682-max9836.c index d6cdb6d9fdd6..ffc105759994 100644 --- a/sound/soc/amd/acp3x-rt5682-max9836.c +++ b/sound/soc/amd/acp3x-rt5682-max9836.c @@ -543,7 +543,7 @@ MODULE_DEVICE_TABLE(acpi, acp3x_audio_acpi_match); static struct platform_driver acp3x_audio =3D { .driver =3D { .name =3D "acp3x-alc5682-max98357", - .acpi_match_table =3D ACPI_PTR(acp3x_audio_acpi_match), + .acpi_match_table =3D acp3x_audio_acpi_match, .pm =3D &snd_soc_pm_ops, }, .probe =3D acp3x_probe, diff --git a/sound/soc/atmel/sam9x5_wm8731.c b/sound/soc/atmel/sam9x5_wm873= 1.c index d1c1f370a9cd..95c8c37478a3 100644 --- a/sound/soc/atmel/sam9x5_wm8731.c +++ b/sound/soc/atmel/sam9x5_wm8731.c @@ -193,7 +193,7 @@ MODULE_DEVICE_TABLE(of, sam9x5_wm8731_of_match); static struct platform_driver sam9x5_wm8731_driver =3D { .driver =3D { .name =3D DRV_NAME, - .of_match_table =3D of_match_ptr(sam9x5_wm8731_of_match), + .of_match_table =3D sam9x5_wm8731_of_match, }, .probe =3D sam9x5_wm8731_driver_probe, .remove_new =3D sam9x5_wm8731_driver_remove, diff --git a/sound/soc/codecs/rt5514-spi.c b/sound/soc/codecs/rt5514-spi.c index f475c8cfadae..da397db8d7d5 100644 --- a/sound/soc/codecs/rt5514-spi.c +++ b/sound/soc/codecs/rt5514-spi.c @@ -503,7 +503,7 @@ static struct spi_driver rt5514_spi_driver =3D { .driver =3D { .name =3D "rt5514", .pm =3D &rt5514_pm_ops, - .of_match_table =3D of_match_ptr(rt5514_of_match), + .of_match_table =3D rt5514_of_match, }, .probe =3D rt5514_spi_probe, }; diff --git a/sound/soc/qcom/lpass-sc7280.c b/sound/soc/qcom/lpass-sc7280.c index 47c622327a8d..c91620128fd4 100644 --- a/sound/soc/qcom/lpass-sc7280.c +++ b/sound/soc/qcom/lpass-sc7280.c @@ -441,7 +441,7 @@ MODULE_DEVICE_TABLE(of, sc7280_lpass_cpu_device_id); static struct platform_driver sc7280_lpass_cpu_platform_driver =3D { .driver =3D { .name =3D "sc7280-lpass-cpu", - .of_match_table =3D of_match_ptr(sc7280_lpass_cpu_device_id), + .of_match_table =3D sc7280_lpass_cpu_device_id, .pm =3D &sc7280_lpass_pm_ops, }, .probe =3D asoc_qcom_lpass_cpu_platform_probe, diff --git a/sound/soc/samsung/aries_wm8994.c b/sound/soc/samsung/aries_wm8= 994.c index a548ac33dd94..9f7318c4ee33 100644 --- a/sound/soc/samsung/aries_wm8994.c +++ b/sound/soc/samsung/aries_wm8994.c @@ -689,7 +689,7 @@ static int aries_audio_probe(struct platform_device *pd= ev) static struct platform_driver aries_audio_driver =3D { .driver =3D { .name =3D "aries-audio-wm8994", - .of_match_table =3D of_match_ptr(samsung_wm8994_of_match), + .of_match_table =3D samsung_wm8994_of_match, .pm =3D &snd_soc_pm_ops, }, .probe =3D aries_audio_probe, --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72BBF6EB69; Wed, 3 Apr 2024 08:15:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712132110; cv=none; b=cKM0lAb/YbKmpM02PmdE8w/7dalS1Znbs3B2jhsyDmFmBWOmJayTAdhJS/AR/0L767DKnXAA88++HVry0H1XlL22zwBeZlqTKL1qTgNUXltAbTgMumMT/bU013W3oDYXR2KSmlkXRZdEPAD4cLqHckabDu4hWbYdkGpoYzcbjaI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712132110; c=relaxed/simple; bh=RuQRkHrQ9e3cp/Msr4bhBQotSNWJFjViuqNekUfGnHE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=A1XIq0QqLjiYe+2Pqd8hkejyTFFblv8pu8eNshjYZmWIxvh0BTO7yqwXkWBeEGPHOp8KBgBlm9sKd4HrNOYBc5mJdnB2A0vdODUkfnFO9mLsl+d9oFlTB6U0SJvDmkk4N7YqNln2XJ6hitN9as/OvDBmRgPPS1fnuDx1f3pZmAQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ItNhRIO2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ItNhRIO2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E04A9C43390; Wed, 3 Apr 2024 08:14:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712132110; bh=RuQRkHrQ9e3cp/Msr4bhBQotSNWJFjViuqNekUfGnHE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ItNhRIO25oVeA7GZkONi09iRrqNBHIydMSlFqXa22rbvpiOpF/t/5Zf0w1AP3mFo6 O9Kzb/WTl2tJ4EjZFPzTm2IN46cCsU5xufjehvrzvGRB9VCVUMJdCeHMMTkG8eBTV9 dpUfvhvhuL3MZ/Uvri9wE8FnVBM2zaSwt65z3teAtgNRm3atfXoTM1/I9dwIfXnw2m alDJkBocPoMKNGLVXN/wV7I9YT+4kmwrbOi0i+R+rIyddSYM2A45JFA2o2y4jA6NBq bdE1Ox/06zB7V1Qdugd0BsqMEj2MWn2Gg5AGnI/kD7I2blxByZ82zuDr76AyDfCX7s FY1DVZoMH/odg== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Corey Minyard , Peter Huewe , Jarkko Sakkinen , Vinod Koul , Moritz Fischer , Wu Hao , Xu Yilun , Jiri Kosina , Benjamin Tissoires , Michael Hennerich , Peter Rosin , Dmitry Torokhov , Iyappan Subramanian , Keyur Chudgar , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Yisen Zhuang , Salil Mehta , Tony Lindgren , Liam Girdwood , Mark Brown , Alexandre Belloni , Xiang Chen , "James E.J. Bottomley" , "Martin K. Petersen" , Greg Kroah-Hartman , Russell King , Jiri Slaby , Jacky Huang , Shan-Chun Hung Cc: Arnd Bergmann , Jason Gunthorpe , Tom Rix , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Randy Dunlap , Rob Herring , Linus Walleij , openipmi-developer@lists.sourceforge.net, linux-integrity@vger.kernel.org, dmaengine@vger.kernel.org, linux-fpga@vger.kernel.org, linux-input@vger.kernel.org, linux-i2c@vger.kernel.org, netdev@vger.kernel.org, linux-omap@vger.kernel.org, linux-rtc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-staging@lists.linux.dev, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 33/34] drivers: remove incorrect of_match_ptr/ACPI_PTR annotations Date: Wed, 3 Apr 2024 10:06:51 +0200 Message-Id: <20240403080702.3509288-34-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann When building with CONFIG_OF and/or CONFIG_ACPI disabled but W=3D1 extra warnings enabled, a lot of driver cause a warning about an unused ID table: drivers/char/tpm/tpm_ftpm_tee.c:356:34: error: unused variable 'of_ftpm_tee= _ids' [-Werror,-Wunused-const-variable] drivers/dma/img-mdc-dma.c:863:34: error: unused variable 'mdc_dma_of_match'= [-Werror,-Wunused-const-variable] drivers/fpga/versal-fpga.c:62:34: error: unused variable 'versal_fpga_of_ma= tch' [-Werror,-Wunused-const-variable] drivers/i2c/muxes/i2c-mux-ltc4306.c:200:34: error: unused variable 'ltc4306= _of_match' [-Werror,-Wunused-const-variable] drivers/i2c/muxes/i2c-mux-reg.c:242:34: error: unused variable 'i2c_mux_reg= _of_match' [-Werror,-Wunused-const-variable] drivers/memory/pl353-smc.c:62:34: error: unused variable 'pl353_smc_support= ed_children' [-Werror,-Wunused-const-variable] drivers/regulator/pbias-regulator.c:136:34: error: unused variable 'pbias_o= f_match' [-Werror,-Wunused-const-variable] drivers/regulator/twl-regulator.c:552:34: error: unused variable 'twl_of_ma= tch' [-Werror,-Wunused-const-variable] drivers/regulator/twl6030-regulator.c:645:34: error: unused variable 'twl_o= f_match' [-Werror,-Wunused-const-variable] drivers/scsi/hisi_sas/hisi_sas_v2_hw.c:3635:36: error: unused variable 'sas= _v2_acpi_match' [-Werror,-Wunused-const-variable] drivers/staging/pi433/pi433_if.c:1359:34: error: unused variable 'pi433_dt_= ids' [-Werror,-Wunused-const-variable] drivers/tty/serial/amba-pl011.c:2945:34: error: unused variable 'sbsa_uart_= of_match' [-Werror,-Wunused-const-variable] The fix is always to just remove the of_match_ptr() and ACPI_PTR() wrappers that remove the reference, rather than adding another #ifdef just for build testing for a configuration that doesn't matter in practice. I considered splitting up the large patch into per subsystem patches, but s= ince it's really just the same thing everywhere it feels better to do it all at = once. Signed-off-by: Arnd Bergmann Acked-by: Corey Minyard Acked-by: Greg Kroah-Hartman Acked-by: Peter Rosin Acked-by: Xu Yilun Reviewed-by: Andy Shevchenko Reviewed-by: Jarkko Sakkinen --- drivers/char/ipmi/ipmb_dev_int.c | 2 +- drivers/char/tpm/tpm_ftpm_tee.c | 2 +- drivers/dma/img-mdc-dma.c | 2 +- drivers/fpga/versal-fpga.c | 2 +- drivers/hid/hid-google-hammer.c | 6 ++---- drivers/i2c/muxes/i2c-mux-ltc4306.c | 2 +- drivers/i2c/muxes/i2c-mux-reg.c | 2 +- drivers/input/touchscreen/wdt87xx_i2c.c | 2 +- drivers/mux/adg792a.c | 2 +- drivers/net/ethernet/apm/xgene-v2/main.c | 2 +- drivers/net/ethernet/hisilicon/hns_mdio.c | 2 +- drivers/regulator/pbias-regulator.c | 2 +- drivers/regulator/twl-regulator.c | 2 +- drivers/regulator/twl6030-regulator.c | 2 +- drivers/rtc/rtc-fsl-ftm-alarm.c | 2 +- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 2 +- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 2 +- drivers/staging/pi433/pi433_if.c | 2 +- drivers/tty/serial/amba-pl011.c | 6 +++--- drivers/tty/serial/ma35d1_serial.c | 2 +- 20 files changed, 23 insertions(+), 25 deletions(-) diff --git a/drivers/char/ipmi/ipmb_dev_int.c b/drivers/char/ipmi/ipmb_dev_= int.c index 49100845fcb7..5e7bfc7c26e2 100644 --- a/drivers/char/ipmi/ipmb_dev_int.c +++ b/drivers/char/ipmi/ipmb_dev_int.c @@ -364,7 +364,7 @@ MODULE_DEVICE_TABLE(acpi, acpi_ipmb_id); static struct i2c_driver ipmb_driver =3D { .driver =3D { .name =3D "ipmb-dev", - .acpi_match_table =3D ACPI_PTR(acpi_ipmb_id), + .acpi_match_table =3D acpi_ipmb_id, }, .probe =3D ipmb_probe, .remove =3D ipmb_remove, diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_te= e.c index 2ea4882251cf..0c453f3f928d 100644 --- a/drivers/char/tpm/tpm_ftpm_tee.c +++ b/drivers/char/tpm/tpm_ftpm_tee.c @@ -362,7 +362,7 @@ MODULE_DEVICE_TABLE(of, of_ftpm_tee_ids); static struct platform_driver ftpm_tee_plat_driver =3D { .driver =3D { .name =3D "ftpm-tee", - .of_match_table =3D of_match_ptr(of_ftpm_tee_ids), + .of_match_table =3D of_ftpm_tee_ids, }, .shutdown =3D ftpm_plat_tee_shutdown, .probe =3D ftpm_plat_tee_probe, diff --git a/drivers/dma/img-mdc-dma.c b/drivers/dma/img-mdc-dma.c index 0532dd2640dc..6931c8a65415 100644 --- a/drivers/dma/img-mdc-dma.c +++ b/drivers/dma/img-mdc-dma.c @@ -1073,7 +1073,7 @@ static struct platform_driver mdc_dma_driver =3D { .driver =3D { .name =3D "img-mdc-dma", .pm =3D &img_mdc_pm_ops, - .of_match_table =3D of_match_ptr(mdc_dma_of_match), + .of_match_table =3D mdc_dma_of_match, }, .probe =3D mdc_dma_probe, .remove_new =3D mdc_dma_remove, diff --git a/drivers/fpga/versal-fpga.c b/drivers/fpga/versal-fpga.c index 3710e8f01be2..e6189106c468 100644 --- a/drivers/fpga/versal-fpga.c +++ b/drivers/fpga/versal-fpga.c @@ -69,7 +69,7 @@ static struct platform_driver versal_fpga_driver =3D { .probe =3D versal_fpga_probe, .driver =3D { .name =3D "versal_fpga_manager", - .of_match_table =3D of_match_ptr(versal_fpga_of_match), + .of_match_table =3D versal_fpga_of_match, }, }; module_platform_driver(versal_fpga_driver); diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hamme= r.c index c6bdb9c4ef3e..886cc5748b7d 100644 --- a/drivers/hid/hid-google-hammer.c +++ b/drivers/hid/hid-google-hammer.c @@ -275,21 +275,19 @@ static const struct acpi_device_id cbas_ec_acpi_ids[]= =3D { }; MODULE_DEVICE_TABLE(acpi, cbas_ec_acpi_ids); =20 -#ifdef CONFIG_OF static const struct of_device_id cbas_ec_of_match[] =3D { { .compatible =3D "google,cros-cbas" }, { }, }; MODULE_DEVICE_TABLE(of, cbas_ec_of_match); -#endif =20 static struct platform_driver cbas_ec_driver =3D { .probe =3D cbas_ec_probe, .remove =3D cbas_ec_remove, .driver =3D { .name =3D "cbas_ec", - .acpi_match_table =3D ACPI_PTR(cbas_ec_acpi_ids), - .of_match_table =3D of_match_ptr(cbas_ec_of_match), + .acpi_match_table =3D cbas_ec_acpi_ids, + .of_match_table =3D cbas_ec_of_match, .pm =3D &cbas_ec_pm_ops, }, }; diff --git a/drivers/i2c/muxes/i2c-mux-ltc4306.c b/drivers/i2c/muxes/i2c-mu= x-ltc4306.c index 23766d853e76..c6d70788161a 100644 --- a/drivers/i2c/muxes/i2c-mux-ltc4306.c +++ b/drivers/i2c/muxes/i2c-mux-ltc4306.c @@ -303,7 +303,7 @@ static void ltc4306_remove(struct i2c_client *client) static struct i2c_driver ltc4306_driver =3D { .driver =3D { .name =3D "ltc4306", - .of_match_table =3D of_match_ptr(ltc4306_of_match), + .of_match_table =3D ltc4306_of_match, }, .probe =3D ltc4306_probe, .remove =3D ltc4306_remove, diff --git a/drivers/i2c/muxes/i2c-mux-reg.c b/drivers/i2c/muxes/i2c-mux-re= g.c index 8489971babd3..0f1b39964743 100644 --- a/drivers/i2c/muxes/i2c-mux-reg.c +++ b/drivers/i2c/muxes/i2c-mux-reg.c @@ -250,7 +250,7 @@ static struct platform_driver i2c_mux_reg_driver =3D { .remove_new =3D i2c_mux_reg_remove, .driver =3D { .name =3D "i2c-mux-reg", - .of_match_table =3D of_match_ptr(i2c_mux_reg_of_match), + .of_match_table =3D i2c_mux_reg_of_match, }, }; =20 diff --git a/drivers/input/touchscreen/wdt87xx_i2c.c b/drivers/input/touchs= creen/wdt87xx_i2c.c index 32c7be54434c..9f3a4092e47c 100644 --- a/drivers/input/touchscreen/wdt87xx_i2c.c +++ b/drivers/input/touchscreen/wdt87xx_i2c.c @@ -1166,7 +1166,7 @@ static struct i2c_driver wdt87xx_driver =3D { .name =3D WDT87XX_NAME, .dev_groups =3D wdt87xx_groups, .pm =3D pm_sleep_ptr(&wdt87xx_pm_ops), - .acpi_match_table =3D ACPI_PTR(wdt87xx_acpi_id), + .acpi_match_table =3D wdt87xx_acpi_id, }, }; module_i2c_driver(wdt87xx_driver); diff --git a/drivers/mux/adg792a.c b/drivers/mux/adg792a.c index 4da5aecb9fc6..a5afe29e3cf1 100644 --- a/drivers/mux/adg792a.c +++ b/drivers/mux/adg792a.c @@ -141,7 +141,7 @@ MODULE_DEVICE_TABLE(of, adg792a_of_match); static struct i2c_driver adg792a_driver =3D { .driver =3D { .name =3D "adg792a", - .of_match_table =3D of_match_ptr(adg792a_of_match), + .of_match_table =3D adg792a_of_match, }, .probe =3D adg792a_probe, .id_table =3D adg792a_id, diff --git a/drivers/net/ethernet/apm/xgene-v2/main.c b/drivers/net/etherne= t/apm/xgene-v2/main.c index 9e90c2381491..64370057ba3d 100644 --- a/drivers/net/ethernet/apm/xgene-v2/main.c +++ b/drivers/net/ethernet/apm/xgene-v2/main.c @@ -731,7 +731,7 @@ MODULE_DEVICE_TABLE(acpi, xge_acpi_match); static struct platform_driver xge_driver =3D { .driver =3D { .name =3D "xgene-enet-v2", - .acpi_match_table =3D ACPI_PTR(xge_acpi_match), + .acpi_match_table =3D xge_acpi_match, }, .probe =3D xge_probe, .remove_new =3D xge_remove, diff --git a/drivers/net/ethernet/hisilicon/hns_mdio.c b/drivers/net/ethern= et/hisilicon/hns_mdio.c index ed73707176c1..f8caf59bd759 100644 --- a/drivers/net/ethernet/hisilicon/hns_mdio.c +++ b/drivers/net/ethernet/hisilicon/hns_mdio.c @@ -639,7 +639,7 @@ static struct platform_driver hns_mdio_driver =3D { .driver =3D { .name =3D MDIO_DRV_NAME, .of_match_table =3D hns_mdio_match, - .acpi_match_table =3D ACPI_PTR(hns_mdio_acpi_match), + .acpi_match_table =3D hns_mdio_acpi_match, }, }; =20 diff --git a/drivers/regulator/pbias-regulator.c b/drivers/regulator/pbias-= regulator.c index cd5a0d7e4455..2eeb99e7b850 100644 --- a/drivers/regulator/pbias-regulator.c +++ b/drivers/regulator/pbias-regulator.c @@ -231,7 +231,7 @@ static struct platform_driver pbias_regulator_driver = =3D { .driver =3D { .name =3D "pbias-regulator", .probe_type =3D PROBE_PREFER_ASYNCHRONOUS, - .of_match_table =3D of_match_ptr(pbias_of_match), + .of_match_table =3D pbias_of_match, }, }; =20 diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regu= lator.c index 5bacfcebf59a..4ed91e88e1eb 100644 --- a/drivers/regulator/twl-regulator.c +++ b/drivers/regulator/twl-regulator.c @@ -656,7 +656,7 @@ static struct platform_driver twlreg_driver =3D { .driver =3D { .name =3D "twl4030_reg", .probe_type =3D PROBE_PREFER_ASYNCHRONOUS, - .of_match_table =3D of_match_ptr(twl_of_match), + .of_match_table =3D twl_of_match, }, }; =20 diff --git a/drivers/regulator/twl6030-regulator.c b/drivers/regulator/twl6= 030-regulator.c index 6eed0f6e0adb..8a84048a66d7 100644 --- a/drivers/regulator/twl6030-regulator.c +++ b/drivers/regulator/twl6030-regulator.c @@ -765,7 +765,7 @@ static struct platform_driver twlreg_driver =3D { .driver =3D { .name =3D "twl6030_reg", .probe_type =3D PROBE_PREFER_ASYNCHRONOUS, - .of_match_table =3D of_match_ptr(twl_of_match), + .of_match_table =3D twl_of_match, }, }; =20 diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c b/drivers/rtc/rtc-fsl-ftm-alar= m.c index a72c4ad0cec6..12da7d36e520 100644 --- a/drivers/rtc/rtc-fsl-ftm-alarm.c +++ b/drivers/rtc/rtc-fsl-ftm-alarm.c @@ -320,7 +320,7 @@ static struct platform_driver ftm_rtc_driver =3D { .driver =3D { .name =3D "ftm-alarm", .of_match_table =3D ftm_rtc_match, - .acpi_match_table =3D ACPI_PTR(ftm_imx_acpi_ids), + .acpi_match_table =3D ftm_imx_acpi_ids, }, }; =20 diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas= /hisi_sas_v1_hw.c index 161feae3acab..c6f313c9605b 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c +++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c @@ -1788,7 +1788,7 @@ static struct platform_driver hisi_sas_v1_driver =3D { .driver =3D { .name =3D DRV_NAME, .of_match_table =3D sas_v1_of_match, - .acpi_match_table =3D ACPI_PTR(sas_v1_acpi_match), + .acpi_match_table =3D sas_v1_acpi_match, }, }; =20 diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas= /hisi_sas_v2_hw.c index d89e97e8f5c2..ce3b5e1680f5 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c +++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c @@ -3635,7 +3635,7 @@ static struct platform_driver hisi_sas_v2_driver =3D { .driver =3D { .name =3D DRV_NAME, .of_match_table =3D sas_v2_of_match, - .acpi_match_table =3D ACPI_PTR(sas_v2_acpi_match), + .acpi_match_table =3D sas_v2_acpi_match, }, }; =20 diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433= _if.c index 81de98c0245a..30fd6da3e8d8 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -1367,7 +1367,7 @@ static struct spi_driver pi433_spi_driver =3D { .driver =3D { .name =3D "pi433", .owner =3D THIS_MODULE, - .of_match_table =3D of_match_ptr(pi433_dt_ids), + .of_match_table =3D pi433_dt_ids, }, .probe =3D pi433_probe, .remove =3D pi433_remove, diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl01= 1.c index 2fa3fb30dc6c..dd1d1a2cc5f5 100644 --- a/drivers/tty/serial/amba-pl011.c +++ b/drivers/tty/serial/amba-pl011.c @@ -2948,7 +2948,7 @@ static const struct of_device_id sbsa_uart_of_match[]= =3D { }; MODULE_DEVICE_TABLE(of, sbsa_uart_of_match); =20 -static const struct acpi_device_id __maybe_unused sbsa_uart_acpi_match[] = =3D { +static const struct acpi_device_id sbsa_uart_acpi_match[] =3D { { "ARMH0011", 0 }, { "ARMHB000", 0 }, {}, @@ -2961,8 +2961,8 @@ static struct platform_driver arm_sbsa_uart_platform_= driver =3D { .driver =3D { .name =3D "sbsa-uart", .pm =3D &pl011_dev_pm_ops, - .of_match_table =3D of_match_ptr(sbsa_uart_of_match), - .acpi_match_table =3D ACPI_PTR(sbsa_uart_acpi_match), + .of_match_table =3D sbsa_uart_of_match, + .acpi_match_table =3D sbsa_uart_acpi_match, .suppress_bind_attrs =3D IS_BUILTIN(CONFIG_SERIAL_AMBA_PL011), }, }; diff --git a/drivers/tty/serial/ma35d1_serial.c b/drivers/tty/serial/ma35d1= _serial.c index 19f0a305cc43..e326d0fb06b2 100644 --- a/drivers/tty/serial/ma35d1_serial.c +++ b/drivers/tty/serial/ma35d1_serial.c @@ -798,7 +798,7 @@ static struct platform_driver ma35d1serial_driver =3D { .resume =3D ma35d1serial_resume, .driver =3D { .name =3D "ma35d1-uart", - .of_match_table =3D of_match_ptr(ma35d1_serial_of_match), + .of_match_table =3D ma35d1_serial_of_match, }, }; =20 --=20 2.39.2 From nobody Mon Feb 9 07:19:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 026C4134CC6; Wed, 3 Apr 2024 08:15:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712132128; cv=none; b=aEhwbigHNZzh/ucKRjvSjNbFZFkMFsVySZpZhBS32BMKOHpxZYB2Lod9kGh+BqqHaislFRsrCdlcz2Xw5wPGKLVuEmpZwfWRVP67WzcRPvVeFIJYtg/BhRh0gAEtmGmpYC4e8z0ci6fDrV349lYvh3Ja3i1Lcv+u6gEUhVVM9sM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712132128; c=relaxed/simple; bh=JOPsom47Sc136qgfvRV59X06uzcHOevejbHhq+F/jfU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QkudiykhLEZyoEkxbln8tPH5U80V/RAUPjvgfAx7MPDLuQ8b2iDmb02pWbgn/tfi9Jzwz0gT89xXjUN+WkWDEIx/30ZOLQeRGd9zmAeb4svDinL71AUQZ/lBxhpJh79QVGKRsurQo8Ywp76EvlQaBb/xbY5dxzCLq2Ru8gQlSzI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KSSdA1OQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KSSdA1OQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1494AC433F1; Wed, 3 Apr 2024 08:15:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712132127; bh=JOPsom47Sc136qgfvRV59X06uzcHOevejbHhq+F/jfU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KSSdA1OQaL+eEA0Z0TUh0zRo4zDqXBC37Yr9QTJIMtim6w0ykg4OHiXGl/dCToq4D p4vPulBWpALmObpWNkckM9RlQnLF/d6UiwsIhemLeA6wTN91gzBnpYNtIbWsYe9i9+ /IunC4Bf6a974R7AyCRxTz+8fngyK0QuoMJyjAT0oPTjy9RHpyDYW2o///6RBRFCfj FXmwk/MeXGNSZ3sdgtsUMOr2YyWshEg43YNk7W4+PZ9Hvv4IPwNQwf/3NjqeSv6vF8 wkBqQ1ieK2IrYV7/lTlSOhNlugFs10d/7liI6zi1t2OKexThTT5BxiWro5VPV5HIRi rk/2tG9fULdnA== From: Arnd Bergmann To: linux-kernel@vger.kernel.org, Masahiro Yamada Cc: Arnd Bergmann , Nathan Chancellor , Nicolas Schier , linux-kbuild@vger.kernel.org Subject: [PATCH 34/34] kbuild: always enable -Wunused-const-variable Date: Wed, 3 Apr 2024 10:06:52 +0200 Message-Id: <20240403080702.3509288-35-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403080702.3509288-1-arnd@kernel.org> References: <20240403080702.3509288-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann The last such warnings are fixed now, so the option can be enabled by defau= lt. Signed-off-by: Arnd Bergmann --- scripts/Makefile.extrawarn | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn index 24d29e477644..a534aba0b97a 100644 --- a/scripts/Makefile.extrawarn +++ b/scripts/Makefile.extrawarn @@ -96,7 +96,6 @@ else # Some diagnostics enabled by default are noisy. # Suppress them by using -Wno... except for W=3D1. KBUILD_CFLAGS +=3D $(call cc-disable-warning, unused-but-set-variable) -KBUILD_CFLAGS +=3D $(call cc-disable-warning, unused-const-variable) KBUILD_CFLAGS +=3D $(call cc-disable-warning, packed-not-aligned) KBUILD_CFLAGS +=3D $(call cc-disable-warning, format-overflow) ifdef CONFIG_CC_IS_GCC --=20 2.39.2