From nobody Mon Feb 9 07:38:17 2026 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7B3C44C87; Wed, 3 Apr 2024 04:44:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712119452; cv=none; b=l6IWM6fjy01hvh4J3F4SU15tELZy47x3jP8gwc9OWwfZxxcq39WNTZ0NfH27aTJUxy7qPQG0aNE5LO5fPm/aYqlVUwoM82+a871Zu6PNnq7+vMR2PXWvxw6Sl+pfDeCFup9/7YSUQcHa6fu29f/OVEZE650eBRy4D7AktEzGN7Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712119452; c=relaxed/simple; bh=aqF52sujDWfRwrckSXNe99REklOfjIvASLLtnHl7Keg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=fXe89cGN9JGWEXfUUnBEv6NN0rIp3cf0Qx1CR2baxdx6X1z8YORbZ/Jgzg9R9uYFcICSbw7nbkRIG/moP8lrW+OY5ymwxwnluEdV/anqSXQ/27GSH1J0degc0ruRr2DVaqQSUHpVsNvLb0Kj1kstvyXAASU+rKu8Sgo0o1CbPnA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost (unknown [124.16.138.129]) by APP-01 (Coremail) with SMTP id qwCowAD3O8y23Axm18AqAQ--.8452S2; Wed, 03 Apr 2024 12:36:06 +0800 (CST) From: Chen Ni To: linus.walleij@linaro.org, dlemoal@kernel.org, cassel@kernel.org Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Chen Ni Subject: [PATCH v2] ata: sata_gemini: Add check for clk_enable Date: Wed, 3 Apr 2024 04:33:49 +0000 Message-Id: <20240403043349.3623961-1-nichen@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowAD3O8y23Axm18AqAQ--.8452S2 X-Coremail-Antispam: 1UD129KBjvdXoW7GF4DJF4ruF1kZFykGw18AFb_yoW3CFb_C3 W7Xrna9ryYgr4UG3W7Xr13ZFy0kw4vvrn3uas2grZxt345Zr4kJrWjv3s8Ar1DWr18WF9I ya15J3s0kryfCjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbcxFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVWxJr 0_GcWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_JrI_JrylYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc2xSY4AK67AK6r45 MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr 0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0E wIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJV W8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAI cVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7VUjX4S5UUUUU== X-CM-SenderInfo: xqlfxv3q6l2u1dvotugofq/ Content-Type: text/plain; charset="utf-8" The call to clk_enable() in gemini_sata_start_bridge() can fail. Add a check to detect such failure. Signed-off-by: Chen Ni --- Changelog: v1 -> v2: 1. Simplify commit message --- drivers/ata/sata_gemini.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/ata/sata_gemini.c b/drivers/ata/sata_gemini.c index 400b22ee99c3..4c270999ba3c 100644 --- a/drivers/ata/sata_gemini.c +++ b/drivers/ata/sata_gemini.c @@ -200,7 +200,10 @@ int gemini_sata_start_bridge(struct sata_gemini *sg, u= nsigned int bridge) pclk =3D sg->sata0_pclk; else pclk =3D sg->sata1_pclk; - clk_enable(pclk); + ret =3D clk_enable(pclk); + if (ret) + return ret; + msleep(10); =20 /* Do not keep clocking a bridge that is not online */ --=20 2.25.1