From nobody Sun Feb 8 09:37:45 2026 Received: from mail2.andi.de1.cc (vmd64148.contaboserver.net [161.97.139.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03D62627E8; Tue, 2 Apr 2024 11:17:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=161.97.139.27 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712056640; cv=none; b=AU8xoP4D0LDk8TVmceMMRzjky7BIB9ORVk17UUzTs09jYzBiDuG3HuG6odG8dMRheQTO70vDlM44HAjgNZ6OkdUQkTlitwpyuteDZmaOmTwOZTswcYx1IrY4SJ9d0z6yfu0k8hs6oIMJIRUuiMma1mlTLDdh99ZwZaoCupQmU3g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712056640; c=relaxed/simple; bh=WDvr8oUzIY615IYKFFDaDoBBU9YupDLybvVcIxw84Wc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=r6kH7VlKISuQEcgiliI88IVZn1ixtiAk50wqATlvfBsYNSIiHs8bwpP8kLlglhvVD0xBteHtyLiDXQmqKNd9QRcwABt50SoPEfLzMWTI5tJLkDapWocxAFRHBgo8WXNHJ5jR96UNdT0KL9HdvHv2qTTy9gOvJV97nz0X0sisZt0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kemnade.info; spf=pass smtp.mailfrom=kemnade.info; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b=FjjTtpK+; arc=none smtp.client-ip=161.97.139.27 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kemnade.info Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kemnade.info Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b="FjjTtpK+" Received: from mail.andi.de1.cc ([2a02:c205:3004:2154::1]) by mail2.andi.de1.cc with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rrc8d-003kpB-0M; Tue, 02 Apr 2024 13:17:11 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20220719; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=vv126PhSztFkrcdCy/6OCfsPMqKAQOQ3JJmexhOQoA8=; b=FjjTtpK+rXHIt0ifGJ6x+2MR7m sGpnho0ds55jAC0PpEyE9B1xoh1/jcXiiac3VuIdTVLs1mQSsMScDSs/fBbSngYJc21IbwvUjYVXK nKNZ9elS7I+RUNUsWG08a0Mz3yGaZZBxHoGwLO4mLLELYeMMgp6oNWbl6Xga8XaV3vvru8KfnaGkh PxM4X/TVVejxgv4F9ZKWPpDZ1RHq5EiQSYT7mJawm8cMDYJJ6rioYp6vlSsYZ8Bh50Ix/H+w8AAFS hpIq+lZxQ3ph+mePixKZ/Wtj7ZH9Cdx5tQXrhw/FC+uyRb3hmxZsaMcwXmPB/WgM1rf/XaVoJv1x+ caFPSSjg==; Received: from p2003010777026a001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:107:7702:6a00:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rrc8b-000IAG-2P; Tue, 02 Apr 2024 13:17:10 +0200 Received: from andi by aktux with local (Exim 4.96) (envelope-from ) id 1rrc8b-0024WC-1z; Tue, 02 Apr 2024 13:17:09 +0200 From: Andreas Kemnade To: lee@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, mazziesaccount@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andreas Kemnade , Krzysztof Kozlowski Subject: [PATCH v3 1/2] dt-bindings: mfd: Add ROHM BD71828 system-power-controller property Date: Tue, 2 Apr 2024 13:16:59 +0200 Message-Id: <20240402111700.494004-2-andreas@kemnade.info> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240402111700.494004-1-andreas@kemnade.info> References: <20240402111700.494004-1-andreas@kemnade.info> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As the PMIC can power off the system, add the corresponding property. Signed-off-by: Andreas Kemnade Acked-by: Krzysztof Kozlowski Acked-by: Matti Vaittinen --- Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml b= /Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml index 11089aa89ec6..0b62f854bf6b 100644 --- a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml @@ -73,6 +73,8 @@ properties: used to mark the pins which should not be configured for GPIO. Pleas= e see the ../gpio/gpio.txt for more information. =20 + system-power-controller: true + required: - compatible - reg --=20 2.39.2 From nobody Sun Feb 8 09:37:45 2026 Received: from mail2.andi.de1.cc (vmd64148.contaboserver.net [161.97.139.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 959E35A104; Tue, 2 Apr 2024 11:17:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=161.97.139.27 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712056641; cv=none; b=WDnNtL6T3co7i9O4jFvlsUZtvAWZ/lu5zy/JKjBG2wnTRDSvK+QwBQTznrKyIhYtCuJueiHa4eQwzlFEDKcGBBL/SZYwcSUE+FQVppJRAhaMOVn4Dewwx+qpkBXtWD70exicFruPi9LIqOUPEvRK0rffJbebDyOvwln8qKKkQdk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712056641; c=relaxed/simple; bh=VdzlGO2dazYEGxZXvq8YoZL7jFRa9MHPBGcA2CCVUDI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rUgbS3xkdTsi+RBL07z2G80apHa+WxGZwrob9yTyzSewI4cU+pFX730FAV38uknCTMBraX+HbOU0iiNcD9M1GrHTqYZzvlw9IVrKDu6zaC8sQGYcXmeedHGGyNLMDZCpOD1TX4oEKiUWAfbPjBOdFgqYNKNdP/20nI1omUVqUCI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kemnade.info; spf=pass smtp.mailfrom=kemnade.info; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b=YYTQahLB; arc=none smtp.client-ip=161.97.139.27 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kemnade.info Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kemnade.info Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b="YYTQahLB" Received: from mail.andi.de1.cc ([2a02:c205:3004:2154::1]) by mail2.andi.de1.cc with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rrc8d-003kpH-2l; Tue, 02 Apr 2024 13:17:11 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20220719; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=vex+9P2NxDOJXQQ0gKcOir6ALkPn8rxaOxG2WX61EBQ=; b=YYTQahLBZq5SfTqfuLaiNu6YY/ ZMp3clmi+vUmO7K0/ijIMfDu/BRT5HTefwocmoxCCCHiI1IUqKXYDWRQyNZopihN5MPnSJ12I97Bd I6JY2zBrYZ07RDrn+Rj0u2x06RRgWvdiBCUv9y03b270miP6mY/i+oTxYGWD2rYpkcGOFlFIFElf3 3WMjfBoj2eSJhGPx10aXBOYxxnwuLGu2GRM+bBCi9WauVvs8bYundD80k3SPx9D4L1fls5ezdqsuD mGrHHW+MbBUqfmBGEkoxsWSc1FXBlzSfYf6ihtl0vZP9ytKaKHeGuzQ/1PRBbn4syrHzkCTLDIlGd G8XHzpjg==; Received: from p2003010777026a001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:107:7702:6a00:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rrc8c-000IAQ-0Z; Tue, 02 Apr 2024 13:17:10 +0200 Received: from andi by aktux with local (Exim 4.96) (envelope-from ) id 1rrc8c-0024WH-05; Tue, 02 Apr 2024 13:17:10 +0200 From: Andreas Kemnade To: lee@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, mazziesaccount@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andreas Kemnade Subject: [PATCH v3 2/2] mfd: rohm-bd71828: Add power off functionality Date: Tue, 2 Apr 2024 13:17:00 +0200 Message-Id: <20240402111700.494004-3-andreas@kemnade.info> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240402111700.494004-1-andreas@kemnade.info> References: <20240402111700.494004-1-andreas@kemnade.info> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Since the chip can power off the system, add the corresponding functionality. Based on https://github.com/kobolabs/Kobo-Reader/raw/master/hw/imx6sll-clar= a2e/kernel.tar.bz2 Signed-off-by: Andreas Kemnade Acked-by: Matti Vaittinen --- drivers/mfd/rohm-bd71828.c | 36 +++++++++++++++++++++++++++++++- include/linux/mfd/rohm-bd71828.h | 3 +++ 2 files changed, 38 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/rohm-bd71828.c b/drivers/mfd/rohm-bd71828.c index 594718f7e8e1..4a1fa8a0d76a 100644 --- a/drivers/mfd/rohm-bd71828.c +++ b/drivers/mfd/rohm-bd71828.c @@ -464,6 +464,27 @@ static int set_clk_mode(struct device *dev, struct reg= map *regmap, OUT32K_MODE_CMOS); } =20 +static struct i2c_client *bd71828_dev; +static void bd71828_power_off(void) +{ + while (true) { + s32 val; + + /* We are not allowed to sleep, so do not use regmap involving mutexes h= ere. */ + val =3D i2c_smbus_read_byte_data(bd71828_dev, BD71828_REG_PS_CTRL_1); + if (val >=3D 0) + i2c_smbus_write_byte_data(bd71828_dev, + BD71828_REG_PS_CTRL_1, + BD71828_MASK_STATE_HBNT | (u8)val); + mdelay(500); + } +} + +static void bd71828_remove_poweroff(void *data) +{ + pm_power_off =3D NULL; +} + static int bd71828_i2c_probe(struct i2c_client *i2c) { struct regmap_irq_chip_data *irq_data; @@ -542,7 +563,20 @@ static int bd71828_i2c_probe(struct i2c_client *i2c) ret =3D devm_mfd_add_devices(&i2c->dev, PLATFORM_DEVID_AUTO, mfd, cells, NULL, 0, regmap_irq_get_domain(irq_data)); if (ret) - dev_err_probe(&i2c->dev, ret, "Failed to create subdevices\n"); + return dev_err_probe(&i2c->dev, ret, "Failed to create subdevices\n"); + + if (of_device_is_system_power_controller(i2c->dev.of_node) && + chip_type =3D=3D ROHM_CHIP_TYPE_BD71828) { + if (!pm_power_off) { + bd71828_dev =3D i2c; + pm_power_off =3D bd71828_power_off; + ret =3D devm_add_action_or_reset(&i2c->dev, + bd71828_remove_poweroff, + NULL); + } else { + dev_warn(&i2c->dev, "Poweroff callback already assigned\n"); + } + } =20 return ret; } diff --git a/include/linux/mfd/rohm-bd71828.h b/include/linux/mfd/rohm-bd71= 828.h index 3b5f3a7db4bd..9776fde1262d 100644 --- a/include/linux/mfd/rohm-bd71828.h +++ b/include/linux/mfd/rohm-bd71828.h @@ -4,6 +4,7 @@ #ifndef __LINUX_MFD_BD71828_H__ #define __LINUX_MFD_BD71828_H__ =20 +#include #include #include =20 @@ -41,6 +42,8 @@ enum { #define BD71828_REG_PS_CTRL_2 0x05 #define BD71828_REG_PS_CTRL_3 0x06 =20 +#define BD71828_MASK_STATE_HBNT BIT(1) + //#define BD71828_REG_SWRESET 0x06 #define BD71828_MASK_RUN_LVL_CTRL 0x30 =20 --=20 2.39.2