From nobody Mon Feb 9 15:08:50 2026 Received: from mail.nfschina.com (unknown [42.101.60.195]) by smtp.subspace.kernel.org (Postfix) with SMTP id DAFD74C96; Tue, 2 Apr 2024 03:13:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=42.101.60.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712027638; cv=none; b=XLLd7hKRfLM1apSDiWOrmhZ8QV4LZecg5NfCCfr7NBuNf6F+TfYJ5CWoI1SRCeKPzpaW2V24yQZM00vmSjIssD89eGz6ScfMlR1OWkMWChZ3nmKogGL2j8IOFQVu2DsBwJ1ON3LYrnMmg1AVB+KJof/Z0a169On1hR6l2M+LssQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712027638; c=relaxed/simple; bh=TgYN3txUafwhIZ8qTVKumny2VJLU8Z0/5tALw0JaLnI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=V+oeyGAxUX4+rgUumkL9zgA/sxlVIQGCQSug/M0vx0sa8ppQPnE8dcNPd4zMD5kYr4sACFiSWmzOfCX8/zp3Q5ETtnzR3YBosHrpcaTvRTZFYXdQryNItzISqCeRVZL6N3bITDQqpNYXwqOhYN6hbPwiBs9HIt6O0mrbjAxkZNM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nfschina.com; spf=pass smtp.mailfrom=nfschina.com; arc=none smtp.client-ip=42.101.60.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nfschina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nfschina.com Received: from localhost.localdomain (unknown [219.141.250.2]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPA id 82E386088D5DA; Tue, 2 Apr 2024 11:13:51 +0800 (CST) X-MD-Sfrom: kunyu@nfschina.com X-MD-SrcIP: 219.141.250.2 From: Li kunyu To: tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Li kunyu Subject: [PATCH] =?UTF-8?q?ext4:=20extents:=20Remove=20unnecessary=20?= =?UTF-8?q?=E2=80=980=E2=80=99=20values=20from=20err?= Date: Tue, 2 Apr 2024 11:13:42 +0800 Message-Id: <20240402031342.32884-1-kunyu@nfschina.com> X-Mailer: git-send-email 2.18.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" err is assigned first, so it does not need to initialize the assignment. Signed-off-by: Li kunyu --- fs/ext4/extents.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index caace8c3fd3c1..f3cb570951a7e 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -1403,7 +1403,7 @@ static int ext4_ext_create_new_leaf(handle_t *handle,= struct inode *inode, { struct ext4_ext_path *path =3D *ppath; struct ext4_ext_path *curp; - int depth, i, err =3D 0; + int depth, i, err; =20 repeat: i =3D depth =3D ext_depth(inode); @@ -1709,7 +1709,7 @@ static int ext4_ext_correct_indexes(handle_t *handle,= struct inode *inode, int depth =3D ext_depth(inode); struct ext4_extent *ex; __le32 border; - int k, err =3D 0; + int k, err; =20 eh =3D path[depth].p_hdr; ex =3D path[depth].p_ext; @@ -2569,7 +2569,7 @@ ext4_ext_rm_leaf(handle_t *handle, struct inode *inod= e, ext4_lblk_t start, ext4_lblk_t end) { struct ext4_sb_info *sbi =3D EXT4_SB(inode->i_sb); - int err =3D 0, correct_index =3D 0; + int err, correct_index =3D 0; int depth =3D ext_depth(inode), credits, revoke_credits; struct ext4_extent_header *eh; ext4_lblk_t a, b; @@ -2794,7 +2794,7 @@ int ext4_ext_remove_space(struct inode *inode, ext4_l= blk_t start, struct ext4_ext_path *path =3D NULL; struct partial_cluster partial; handle_t *handle; - int i =3D 0, err =3D 0; + int i =3D 0, err; =20 partial.pclu =3D 0; partial.lblk =3D 0; @@ -3162,7 +3162,7 @@ static int ext4_split_extent_at(handle_t *handle, struct ext4_extent *ex, newex, orig_ex, zero_ex; struct ext4_extent *ex2 =3D NULL; unsigned int ee_len, depth; - int err =3D 0; + int err; =20 BUG_ON((split_flag & (EXT4_EXT_DATA_VALID1 | EXT4_EXT_DATA_VALID2)) =3D= =3D (EXT4_EXT_DATA_VALID1 | EXT4_EXT_DATA_VALID2)); @@ -3403,7 +3403,7 @@ static int ext4_ext_convert_to_initialized(handle_t *= handle, ext4_lblk_t ee_block, eof_block; unsigned int ee_len, depth, map_len =3D map->m_len; int allocated =3D 0, max_zeroout =3D 0; - int err =3D 0; + int err; int split_flag =3D EXT4_EXT_DATA_VALID2; =20 ext_debug(inode, "logical block %llu, max_blocks %u\n", @@ -3698,7 +3698,7 @@ static int ext4_convert_unwritten_extents_endio(handl= e_t *handle, ext4_lblk_t ee_block; unsigned int ee_len; int depth; - int err =3D 0; + int err; =20 depth =3D ext_depth(inode); ex =3D path[depth].p_ext; @@ -3761,7 +3761,7 @@ convert_initialized_extent(handle_t *handle, struct i= node *inode, ext4_lblk_t ee_block; unsigned int ee_len; int depth; - int err =3D 0; + int err; =20 /* * Make sure that the extent is no bigger than we support with @@ -4418,7 +4418,7 @@ int ext4_ext_truncate(handle_t *handle, struct inode = *inode) { struct super_block *sb =3D inode->i_sb; ext4_lblk_t last_block; - int err =3D 0; + int err; =20 /* * TODO: optimization is possible here. --=20 2.18.2