From nobody Mon Feb 9 12:28:52 2026 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7758D132C38 for ; Tue, 2 Apr 2024 17:07:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712077636; cv=none; b=OHV80hnn6HFCDSyDApwXX3rLnDgsqaB7o52gYZX2YWDmw2W0VqP6XzaC+QpocKhqWMuXkzlPZVLaju2QtEHNQahkOdeguRWECCJLTLYbClOFHbr/QzKBTu4zL/MbdbAw6+q5uY7N4Tue/0T7TVcW6MgoXSyBSLOD97y55jm2C/U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712077636; c=relaxed/simple; bh=ejmSEr+ZHoU5wnJwcbG/1U4o9s3XeOrkLnjOGLvJUFs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NKGybOouErKc1gSzUSdXgtfChgJBiFB87qa94IXymgW48JR0W1B2IOd+b8TGGtU8BIzo6ng5Jw1BBQ+U1OIKImGT3M0zEhOyI3Sjd6fF1hHnyr1EPNkE5vovev8et4grS8OGax8Vos6d7YRzHJaTPnKiV+rXgKzaTiJcm6MMAs8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=MtlVgSy7; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MtlVgSy7" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-513d717269fso6466957e87.0 for ; Tue, 02 Apr 2024 10:07:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712077633; x=1712682433; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dumrdNqn3JF7d5ovI58YhJ6DvrUhsKO8CpryfKF1GQ4=; b=MtlVgSy79Ny0ToWMg/c5x2jKEQ6mnAcZ32Ffj59NF1zIRGdiyEmxohVnX7A7IhIaGZ 70SHaWEQ5atgg4OJ9vc8BcSKOBb6Dl2L8u150MFGY6rYWV1/TcoQmOYZrmSMAtWCuU0y B9VjNA/EnWFD3FapYoxM1wXbGpsuNR5i0hB+2YOD+Ma9erTb2WqPyLmRVAzW8S4d+elH sK8y5JGkitZ1Rn5chhLk6r64UbOZPoxlDo5XEqp9ppnElXlAq9C9kY2PBV4HdkUZgP8Y AP1inMINJaMSoAKKB+Uk/dQxEYGU2ef/hJHtbhBglqUnftjdQZiIf6xy8c1PL8/RljDb ZStg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712077633; x=1712682433; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dumrdNqn3JF7d5ovI58YhJ6DvrUhsKO8CpryfKF1GQ4=; b=ZOooOI0yBHAPsFa3ySH7sq/DvQ9M+CN94kBV1Lb3ziXvLiM9hWRiJkzimy2E7m9l6/ Gup34k7j6RqOFCJeY63K61b6pdqV3QxsywdsxXxPEx1ENy80BiI/3lCm6hUPNS4Gv2eR tarvFNLuRsSF1ANh/463kGOSQaFDhD9WDFlye/hDCzzWl8ZgmbXAixfJn/DIWY6EagbA epJsxKUoLXDUgMObxqc5EltrGwMQXqmacCe/674Q0aIRgpdQak51uAzI7l4kYNr4W27w x0w15Lyd6ZuUm2ztuY8ibFAdi6DlfU7+dAQquxpGwpnhgoxToPoxZX4qjpH6WtdzPJ8i MXoQ== X-Forwarded-Encrypted: i=1; AJvYcCWIhBl4znMsLx6IfqMeLXgcocHdzV6tR1Jb42dJY1SKEXOcEbTsi8bvomeCmzWCMHngBKuzQQnJE3Fg5+IxlesFn1h1sPn4s8XqYbzk X-Gm-Message-State: AOJu0Yxx6Kk+8yfPsfv1Yq2zkUpMtVqfaxaLj1E4WuoeySIRLU0Rn2I+ EQAfu8J2MQ9YJ6D6raSQH7ARQA1vDl2+pZS6Oq5sqol7MTFvZxyk0dqcD38XPmE= X-Google-Smtp-Source: AGHT+IH3LKUsswPAmj67uOpsid2F9krDfs/O9BSSs9cp+RSDJODfoiCwo9O2MoqGi0ibFWMRTVqNew== X-Received: by 2002:a19:5e11:0:b0:515:d3e4:7d9f with SMTP id s17-20020a195e11000000b00515d3e47d9fmr7130874lfb.21.1712077632657; Tue, 02 Apr 2024 10:07:12 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id e12-20020ac2546c000000b00515cc53c5b3sm1603486lfn.125.2024.04.02.10.07.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 10:07:12 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 02 Apr 2024 20:07:06 +0300 Subject: [PATCH 1/2] soc: qcom: pmic_glink: don't traverse clients list without a lock Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240402-pmic-glink-fix-clients-v1-1-885440b81c65@linaro.org> References: <20240402-pmic-glink-fix-clients-v1-0-885440b81c65@linaro.org> In-Reply-To: <20240402-pmic-glink-fix-clients-v1-0-885440b81c65@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=973; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=ejmSEr+ZHoU5wnJwcbG/1U4o9s3XeOrkLnjOGLvJUFs=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQxqPtd2tWzcXdWQpx9kYimw3bOCJvNvIUmu4vPgBY8WRa A53falORmMWBkYuBlkxRRafgpapMZuSwz7smFoPM4iVCWQKAxenAEzkhhn7L+YJzPULfv7lK4xZ n97Qb5H+kF3tcolJrf/P+p87ZjAFHLIQt+7/3dNxn0XgxJSeSS8Kt+oLfJEK/C4eM+vLmaUbPt6 Smr+5IXLpuouuf7fXJ0r0bU6WE+X0fZJUx14se+9h46eryxaoFnKIeTubmUessfS1X35fu+XjOq nlq2xUy5JfHd/gy9HxIf+gemt15KNtC2SMX7qoRataiJoleF4ss62stjlR/rOgIZdPPE45UuVZm f+F3yZGz1MM2w8vMgu6rNnz74vNrfLooyomenYO2ot/MmZ/fJ1Sv+yqT+FSmayvu3MKDwZXVjzR 0K5WsLJMeX5m35eTWe/TmevPmXeHXNfvt9OOLsy9dxsA X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A Take the client_lock before traversing the clients list at the pmic_glink_state_notify_clients() function. This is required to keep the list traversal safe from concurrent modification. Fixes: 58ef4ece1e41 ("soc: qcom: pmic_glink: Introduce base PMIC GLINK driv= er") Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/pmic_glink.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c index f913e9bd57ed..c999358771b3 100644 --- a/drivers/soc/qcom/pmic_glink.c +++ b/drivers/soc/qcom/pmic_glink.c @@ -168,8 +168,10 @@ static void pmic_glink_state_notify_clients(struct pmi= c_glink *pg) } =20 if (new_state !=3D pg->client_state) { + mutex_lock(&pg->client_lock); list_for_each_entry(client, &pg->clients, node) client->pdr_notify(client->priv, new_state); + mutex_unlock(&pg->client_lock); pg->client_state =3D new_state; } } --=20 2.39.2 From nobody Mon Feb 9 12:28:52 2026 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D09A415990C for ; Tue, 2 Apr 2024 17:07:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712077637; cv=none; b=EEGtjLtXEOzInIxh4rUfxcu/fhOz7YTzzT1hr3yeCh+f5fJ9Vw3CWpv4aXGKJMrrqASZt8YGxprvUkEnpjOHccnZClmWiPK7txFhSHYUKcpkQf6xwBlmFdrcQgKt2In1i5SWBbQDl1LqDNmKnDONRmX0HmwOOtLtjbLN/2GI1lY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712077637; c=relaxed/simple; bh=T6Qd+L04mZkzAyR5GBc7ooVeXexQ2iHz4W9MFLmMCFM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=I2mDduEgqnypbAs/waMnqprpcbU3/vRbWGXdO9nVng+AxkzN9GYB189C0vKfoc0FHo1Ot4BqV0txanpl3d3JRDFQcrTpXGUIFe+xWOK4LXeh1zHXBUt1Wey72JyWOWf/o4kjc9c9so1D8CqWU2U1EhXU9WEcWKTIoUlkNhHmNhM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wLYxvwIJ; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wLYxvwIJ" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-516a0b7f864so2346052e87.1 for ; Tue, 02 Apr 2024 10:07:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712077634; x=1712682434; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aqJOpvbyBmvtqRsTmffyDJDkg5th9P0RJAbEDy92BsU=; b=wLYxvwIJkFK3S3KAe8zRVy9A8MwzbHZhc7V2RFuTJDzmqPtyzhdXbCC+7MGyssKE8I xVFPj6KjlCo/dgO8Wi1ScF4X5sKavfwyKanxeoZ35/5BRnY56avLPXp7IXa7+E2X73vC 611I5wBRb5RDhsjUgt6ARR2IAWMBqs2X7XaGOq/dOA2XjznSSFk5zxeA9x0fCK3+tgOX r/OOtkZrGKbTJXlMVqsHK+Bs7GeBDOpYMhJsM/n2eHTtxUG0J+2rfqFSxiYC5PWYOjbd uLnVvKEKcpBF6MmUjO/2vRb1lFRzBK1BtQ6GG14YF4vh41TbXPdG8oGAhWWaZVeIzMyI 7F4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712077634; x=1712682434; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aqJOpvbyBmvtqRsTmffyDJDkg5th9P0RJAbEDy92BsU=; b=EkHA9L4Bgg7g86czwkh/ghg0/MlK/PxveyyPNP+ojDlWoLg6Vr8m0RrGsqeIx2ZD50 u4esciQfViOrG1nErl0CJcHx2OGWmMdW/8lgm2Feeq/UpJKJ5c/NiivDA5pV6xVgTIHC Ej8wcviZxsc6e0d/R/cciNTamoZXz5t7HN6jSrVp9AkD3zeR1auwKjVm6BCRGWhP194I fas/Bt5xPsFBgkMAfuDUV/nEcs3BctGc12zRqsiGRIK5keJgtndw2qrLMUhO2k1PD7Qm m42hcXS8jmsECmCF9bGZ1KisD4OQs/lyRdwaDtpjAZY3JUSkj6u2bC6K6e4E0O2ahAxH IC7Q== X-Forwarded-Encrypted: i=1; AJvYcCVgy//JpNOfj1ZzruonGJPPDbMJEM+/A3y+2RrPOlpz9oLMfnUMNUPUllXhLHOD+XffJd1BC3k0sCpBQOg+tFWfxqsrzd33qCLj03Ik X-Gm-Message-State: AOJu0YywuSZZQq0LXv/KEWpST/RnfClprbcnLFgFs4rY//DA0G0RPFMT Cq9frA/qmy+WJNSoX/yyTGSodaUSBzLpCfrYhNVcGF6/GQox9Vc/ioFUDkUQqZ4= X-Google-Smtp-Source: AGHT+IGEzKzBvoZKifA5mTHxjS7sZ0A+KJr8ySt3TpZcg7TdUU/snRiCggX94wNVAlzdKg1AwIYp5A== X-Received: by 2002:ac2:4841:0:b0:515:7686:2609 with SMTP id 1-20020ac24841000000b0051576862609mr7622350lfy.18.1712077634152; Tue, 02 Apr 2024 10:07:14 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id e12-20020ac2546c000000b00515cc53c5b3sm1603486lfn.125.2024.04.02.10.07.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 10:07:12 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 02 Apr 2024 20:07:07 +0300 Subject: [PATCH 2/2] soc: qcom: pmic_glink: notify clients about the current state Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240402-pmic-glink-fix-clients-v1-2-885440b81c65@linaro.org> References: <20240402-pmic-glink-fix-clients-v1-0-885440b81c65@linaro.org> In-Reply-To: <20240402-pmic-glink-fix-clients-v1-0-885440b81c65@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1084; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=T6Qd+L04mZkzAyR5GBc7ooVeXexQ2iHz4W9MFLmMCFM=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQxqPtZ0/d3ny957716MSL3ZOe7PGkulvxy1FV66vddI31 i5SMP3RyWjMwsDIxSArpsjiU9AyNWZTctiHHVPrYQaxMoFMYeDiFICJ8E3iYNjo8L03a9VJU+6N G9IP800Ru67Var4t7txN8wq1aeFTNk2W3Tn7/qOlVi53X8fZskYpH78jFO3656ywVmSZmIxaeZr uGp+lHbc8ivPPXjnyRdeH89V5DcfLeV/8FG/r7txrL6ZX4fpS+9+U+AevYxUXMuuf2JCyI/2Dlk jQwZZbZ5efMfCcX/ji+P1NqiVZWjdVSnlvN389mWfccDuwVFBlwl/+RrbKg3piJzfcKU9dwTmvP pylSOh9WUNB1C3xDvtTWUK3qiM/1ru+rdtU/0c6+Wq3rWKrktSqpzOn1QR1R1he6LyRdrHlzfM2 dta4EInEvSyN5WWPHEJafxfnMX/l3GV+Ws5eWyYp8PwxAA== X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A In case the client is registered after the pmic-glink recived a response from the Protection Domain mapper, it is going to miss the notification about the state. Notify clients about the current state upon registration. Fixes: 58ef4ece1e41 ("soc: qcom: pmic_glink: Introduce base PMIC GLINK driv= er") Signed-off-by: Dmitry Baryshkov Reviewed-by: Andrew Halaney --- drivers/soc/qcom/pmic_glink.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/soc/qcom/pmic_glink.c b/drivers/soc/qcom/pmic_glink.c index c999358771b3..089cdfb1c9d1 100644 --- a/drivers/soc/qcom/pmic_glink.c +++ b/drivers/soc/qcom/pmic_glink.c @@ -83,9 +83,14 @@ struct pmic_glink_client *devm_pmic_glink_register_clien= t(struct device *dev, client->pdr_notify =3D pdr; client->priv =3D priv; =20 + mutex_lock(&pg->state_lock); mutex_lock(&pg->client_lock); + list_add(&client->node, &pg->clients); + client->pdr_notify(client->priv, pg->client_state); + mutex_unlock(&pg->client_lock); + mutex_unlock(&pg->state_lock); =20 devres_add(dev, client); =20 --=20 2.39.2