From nobody Thu Feb 12 03:00:57 2026 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2091.outbound.protection.outlook.com [40.107.14.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E274D56450; Mon, 1 Apr 2024 22:25:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.14.91 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712010344; cv=fail; b=rplbh4hPiAJhRboN0Or9VXNDdS+hV9QtnxPzLm2lbNShbqAkcfk3uee8VHKWc3+2oRkRLz87vmynHEGXdKyXFU8eBhMOExQFBrJLrAbBlc8cea2w/xhlCykZCn9QALTLdJRfwDFi53FqVtT0x/Rh39iMOx/ZFTaCsASFXjjHrBU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712010344; c=relaxed/simple; bh=x/POWQ0U8GrRyPnu2nIcIHKAzPh8JAVtPHA132rEFXk=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=K5RWccmyFd/fqmSIweWO8zs2ZutbSZ8UZ9szeFcnK6AgmZB9yU02Mb0m6xhG9KkUEEHmyCkONsYXVa3DEYORwc6pQqBAFLUIWCkifCkIdaAkzytoFLkEev35yn1mSyM/6z1dqNl4s30acFpyeiEIIoK9g7AwzeFbLR8wnowDsx4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=TMaUFGRf; arc=fail smtp.client-ip=40.107.14.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="TMaUFGRf" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RPsT9cS8Fx5z5udGF4N4FbvCCNV0FQg1oNDE8r7yxDJFp7GV6tqbkpipL+3alJ/ZM/0XBKbik2Thl2gqg9nk21rEMtZnIVZC+5Zfeu2N8/vmF0nU6Ujb7WqP9csTASH6MLct9wtgyx51DvDsgSR0IVa1GzHotGovPA7Qnh+k3vMyhLvqJoW/5G6dAA9hRWSOiTgQ960xS23S+tZM9ZiDrqF10cvsHgNVotzJXXWIlXmycdBbeI0XEXI249rAVH2fR7qor3LIQdfAUdiMIaDLiFmPwiHHYrYJ0MuYyzB+Ntv7ITdiAXj5Xk1eBJTDxXsIddbR+3zf/V1Z9aTfxM1bVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R53HfYRzJhX3GkT5gsG/BDOMnsWSRBgL276IoWfmll8=; b=l5AeCaLsa0Fpke3lI61oz8WJnnm/oAkzo3lV4AuNxq0dZYOUVf8fSAr6pyWPv8YFBLM9xYjLjpPwpKNXwiGR9zujlxKD/fOrRly/XXvqUuQAiyZBMiJhJwXW7OCjxvrbcFxGVri0WUkvNu2NSyPv8QrxQgwGoLWuxRRRANi7Y7zYVFZfyQlQsQimULfyK/7GzpGvhcjhiMtfNi2wX2jlUS8gtT7nQbddTzdiXyMCNHu++mV8u4Mpmqovl1Pb8YDiKZTddw6/vRJvtaf1/Ok/oWvCTB7SjOhwbdkEoNg1MklEGhq6OWk8QDraYtIy8mhTD3lHh/QCdefb+TQBzWH5hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R53HfYRzJhX3GkT5gsG/BDOMnsWSRBgL276IoWfmll8=; b=TMaUFGRfrGeQqmN8ln3q/TkfLIr8SO2T1eMERVhXxkAXqfcz8mFxqzV1FC8V+9o0usuWCau/oV9EBpUDL2ArvAy8l8ZYrdFN2ZIMPpSZuRuhw5yMBdLgsf9LUxU3THG1NqkeqKU9EyYUBDeoWOMdo5CrWEFS1N1vle6Yr3xwGhs= Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by GVXPR04MB9976.eurprd04.prod.outlook.com (2603:10a6:150:117::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Mon, 1 Apr 2024 22:25:39 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6%3]) with mapi id 15.20.7409.042; Mon, 1 Apr 2024 22:25:39 +0000 From: Frank Li Date: Mon, 01 Apr 2024 18:25:03 -0400 Subject: [PATCH 1/7] arm64: dts: imx8-ss-lsio: fix pwm lpcg indices Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240401-dts_fix-v1-1-8c51ce52d411@nxp.com> References: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> In-Reply-To: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Marcel Ziswiler , Philippe Schenker , Max Krummenacher , Alexander Stein , Joakim Zhang Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li , stable@vger.kernel.org X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1712010330; l=3222; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=x/POWQ0U8GrRyPnu2nIcIHKAzPh8JAVtPHA132rEFXk=; b=AzmAY3DZfuLNjebMscfEXDcTc747tITTcwb6PKjovwlB6FEUmTl9R8dcnDfxoj1uscznH/Fu3 R17n9BWyN5TA6ZTNPqO0B6Z1Bst+MGGaVWpcC1h/MO3vFW9imQTizVG X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR05CA0011.namprd05.prod.outlook.com (2603:10b6:a03:33b::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|GVXPR04MB9976:EE_ X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1FQiqhhMhNjpN1Q7lqAjrgR3hiUJw/S8LXIw0EbbABOMJQzSehEdjm0TNkzyMiAUoSarPJcTKPiH+dA+qrSjp6a3IIdhN37Y90DAiuFzHEc41c/EtwBetirk2BdDo37jpaop9SeYhUoqToDqtGibS33IJJb4XkC0XKty1nXJQgX0U+cp7/az1RUMvoIhl/nHSzfzalvtvUKBwcvwHFTunsxVD3qhDt0WBE/26vuvt6S+KL9ruTt0YvFRDqgOWrIOD89zLkN6sS1cq1cD9di/UhOk8zKdfUBXVbgbhgOHfvwaEjcgNrQK732l29yFN4o1lSDUqJTQ8Z08HYlu39MEydJ4YKF4wytupT36W8BDjJCfPtVqDRKh73OROqLqIWHY9vIa+APxrGT1APrpafIz4ba8kLYs23TUvCNupolvP9FS4drmCSwK3ulfPf/ntui+1CRhKFHaUOwKj+X5fziI0YHWIr8k5QqpT/5jG3w2j37ASiQiRAFMA1wQegEiY/UBVBHEA8cwbJVJnyvPDg+9lx5FxXq1GvXcWZjQneb0WQwg7RvsI9IIIHJCgomh7Z1SQ6UuSj1WcWEhYbIdtKFZn+U8nBCc3fmiScK6aKLFNSEvOWX8pp0UwtVVgZ9MelatKSW1A5bPf2wP2/HIep3jyd+FE1gGvzzgaPWxt2D3w+xWLKWN4pYhXsRRUvUslTLQix6wgq2g0vwhHVkckGGQFJDfAeYzS6SKXvJRUWQSDjs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(52116005)(1800799015)(7416005)(366007)(921011)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZXhBc1BqdjBudmhPUUtDbVRyU1BabVhRenJFNlBMN0FvV3YwSEFrR2lFZ0Q1?= =?utf-8?B?Zm4rdGRPM1pjVHZnQWg4Z3hjVVNRWDFESHp6VlRldFVxaHNOYXh3ZklaRUtJ?= =?utf-8?B?WElJUU00NWEzc1pickdQT0xmWHNvajdic050eDg2Q016VTkvakVhWVNMZU9Y?= =?utf-8?B?a3A5aXhTRGxRclFwS3FvdjNHTkgvLzQzTklEK3Nqd3FRcXJXZnM5SEF4Wmh3?= =?utf-8?B?MGxpS2FSMlpUT1VEQXNDV0NZbHgyMy8raWlXSjczQUpsRWIzdzVOYWRaV01a?= =?utf-8?B?OWVvaDhrb0F0RENLcE5EUXRvM050S1h5Z2NOeUFiRFhCOUI3bmx4aHNHZlht?= =?utf-8?B?czREL2lzL0pHTVpLUmNvRlF2Z1lvVHhiaHJFRzhyZlB3NWhYZUovTnoyT1Zl?= =?utf-8?B?dVU4WElFalR1WkI0MHZiOVltSWdqSFJQWC9Qc3V6QmRsSTdUREZVMTd5Uks3?= =?utf-8?B?VGlVcUpHQVE5WXduWGNEUjhoOTZSU09zbkxhQ3lYSjVrUkJyWGNSYU5JYkV5?= =?utf-8?B?SlVBUUFIRHlxZWZNYWVRTFF2VUpOei9EdG1wdjAwVlQ1WklES3BLT3Z0UHE0?= =?utf-8?B?S282NncyeFppVi96Wmd2b2VVY2tiZWFWTjVtaEFaUEYwd0owR2ZsQVlpZnRh?= =?utf-8?B?NmxIRHI1M0txVXRXOGJtdFRBYXA5U2VHMG9CcVFsQzI3eHMrNFVYTjVveVNS?= =?utf-8?B?eko3VURJM0hLMHhRQ3hPWU5FNlFkRkdQODRvMWFpL0JHajZIamVic0JZWEhS?= =?utf-8?B?SHZGU1l0ZUpPQSthM1BIMDlZOCtUZ3hXclRMcE5JbG9VUnpsSzNONUphL05E?= =?utf-8?B?RzFOdGh0YW1GQzhuQkw4L1ZtL0x6ai9YcFpqcmJhUUdxRW9QVHBpZWJOZU1U?= =?utf-8?B?elZSRlpQd3pYdUdlaXB2cU9TeG9RVWtWZmhXZlRhenBkR3JrUFRCdGtKckw1?= =?utf-8?B?dmZXeHNUbW8yVUNsUW1KM1M3c2FGVnFORWRlaHEySHgvZGszcE91Y2FoSU8z?= =?utf-8?B?aUttekFySHFNNGwzZVJIbkVSSmp0b2V4ZlN4UTUzbkR2dkNmekhGL2JXSEhz?= =?utf-8?B?UmhhNm5kT01OY3VveUZGTXo2eUdTZC9xYWU0cWhjcVVzS0g5dmFGOUJ3cSt0?= =?utf-8?B?MFdRUHo2anNuRVYvTkhidSs3Z2JmMkNENzZNVE9QWGxoYStMRllOakp6QXFw?= =?utf-8?B?ZWdyeENDbE9qRTc3VHh2SjBCbXd4a2lBYURDRTVDTVJzWjg5L2NLZ0UwK2FQ?= =?utf-8?B?anBETWdyMXZ5c2h6RVRYd0J1NldNN3pTZ1U3WmZWakFKQlUzZHcxRFVSbFZz?= =?utf-8?B?N2V5SHhNSXlYRU1OMFI3aFQydkdqTkVQVkNNT1dzTWJpL25DZWZoS3I3OFVt?= =?utf-8?B?Qk40aEN6Z2tvdlg3T3IwYXdXZ1BNZXk3ZWdiTHNwUm44K1h6Rk8xMHVHTENE?= =?utf-8?B?MnhmdGcreE52czRMcUpBVW1RZVFoeTQyU1g4WEZzVFRVR0dYaW5pTVFHTEZV?= =?utf-8?B?cVhSSmVlcFRMdnE2MlA4TUM0ek55RkYzRDE2dGRyYnlzblFkUTdvcnhYbUdL?= =?utf-8?B?NHBDRnp3NGlXTWIzMlN1b1B5bGZEVitDbFBTNk9iUlJsMUJUTDZuUDN6UU1J?= =?utf-8?B?bmZkc213YWNrYTRFbkdiNlBoZ2JpUWg2V3V5ZFZzSmdseFlJRXQzSjJJOTZQ?= =?utf-8?B?dWF3RXlQdmRTb2VXcWNrSXdWWjVxVWtjaHpBbHpUZFEvSW0wWWIvK1djcGo4?= =?utf-8?B?OW5zMkt2UnpSMDZyeENZREt6T2RReWJSWk4vVFhxdUxBNGdMZU9xc082eHBz?= =?utf-8?B?azhrWEt0MndGOVc3bHhzNG1Vak5PdHI5WUcrei9jR3lxSldiWmVzc2FpSzkx?= =?utf-8?B?d0pxM3puc2FQOW81cWhGVWRpcU1DUFdSOCtiUnNLV3pacFY3Z0NtSkpoZWR2?= =?utf-8?B?SGNYdGZqS05nTE1hcithWGVzb3pwWm9tOXNpUUU5NExBNXNqRzN2K3RnUFFj?= =?utf-8?B?TU84VTRQY2dIczZqVm9JYkJ6QWlrRmdBMG4ra2F2d1NOc0YvcGdMcGFNMlNK?= =?utf-8?B?NW9tRGE1WHdoekhqdE90V0RQVys1REVqZFY4dWJkS0RuZXFwM2VGVXJLaWtK?= =?utf-8?Q?o4SA=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea7c370d-2f9c-4679-e919-08dc529aa8e1 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 22:25:39.2519 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3iEz77DGTp4TIsNJ9TenXo8PBYZXuJDf1aIpALEPTLFd039q8Z5+9NrbBUbKZZWdFwJmnIEb2mcNPOdHrKDFEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9976 lpcg's arg0 should use clock indices instead of index. pwm0_lpcg: clock-controller@5d400000 { ... // Col1 Col2 clocks =3D <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>, // 0 0 <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>, // 1 1 <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>, // 2 4 <&lsio_bus_clk>, // 3 5 <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>; // 4 6 clock-indices =3D , , , , ; }; Col1: index, which exited dts try to get. Col2: actual index in lpcg driver. pwm1 { .... clocks =3D <&pwm1_lpcg 4>, <&pwm1_lpcg 1>; ^^ ^^ should be: clocks =3D <&pwm1_lpcg IMX_LPCG_CLK_6>, <&pwm1_lpcg IMX_LPCG_CLK_1>; }; Arg0 is divided by 4 in lpcg driver, so index 0 and 1 will be get by pwm driver, which are same as IMX_LPCG_CLK_6 and IMX_LPCG_CLK_1. Even it can work, but code logic is wrong. Fixed it by use correct indices. Cc: stable@vger.kernel.org Fixes: 23fa99b205ea ("arm64: dts: freescale: imx8-ss-lsio: add support for = lsio_pwm0-3") Signed-off-by: Frank Li --- arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi b/arch/arm64/b= oot/dts/freescale/imx8-ss-lsio.dtsi index 7e510b21bbac5..764c1a08e3b11 100644 --- a/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi @@ -25,8 +25,8 @@ lsio_pwm0: pwm@5d000000 { compatible =3D "fsl,imx27-pwm"; reg =3D <0x5d000000 0x10000>; clock-names =3D "ipg", "per"; - clocks =3D <&pwm0_lpcg 4>, - <&pwm0_lpcg 1>; + clocks =3D <&pwm0_lpcg IMX_LPCG_CLK_6>, + <&pwm0_lpcg IMX_LPCG_CLK_1>; assigned-clocks =3D <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>; assigned-clock-rates =3D <24000000>; #pwm-cells =3D <3>; @@ -38,8 +38,8 @@ lsio_pwm1: pwm@5d010000 { compatible =3D "fsl,imx27-pwm"; reg =3D <0x5d010000 0x10000>; clock-names =3D "ipg", "per"; - clocks =3D <&pwm1_lpcg 4>, - <&pwm1_lpcg 1>; + clocks =3D <&pwm1_lpcg IMX_LPCG_CLK_6>, + <&pwm1_lpcg IMX_LPCG_CLK_1>; assigned-clocks =3D <&clk IMX_SC_R_PWM_1 IMX_SC_PM_CLK_PER>; assigned-clock-rates =3D <24000000>; #pwm-cells =3D <3>; @@ -51,8 +51,8 @@ lsio_pwm2: pwm@5d020000 { compatible =3D "fsl,imx27-pwm"; reg =3D <0x5d020000 0x10000>; clock-names =3D "ipg", "per"; - clocks =3D <&pwm2_lpcg 4>, - <&pwm2_lpcg 1>; + clocks =3D <&pwm2_lpcg IMX_LPCG_CLK_6>, + <&pwm2_lpcg IMX_LPCG_CLK_1>; assigned-clocks =3D <&clk IMX_SC_R_PWM_2 IMX_SC_PM_CLK_PER>; assigned-clock-rates =3D <24000000>; #pwm-cells =3D <3>; @@ -64,8 +64,8 @@ lsio_pwm3: pwm@5d030000 { compatible =3D "fsl,imx27-pwm"; reg =3D <0x5d030000 0x10000>; clock-names =3D "ipg", "per"; - clocks =3D <&pwm3_lpcg 4>, - <&pwm3_lpcg 1>; + clocks =3D <&pwm3_lpcg IMX_LPCG_CLK_6>, + <&pwm3_lpcg IMX_LPCG_CLK_1>; assigned-clocks =3D <&clk IMX_SC_R_PWM_3 IMX_SC_PM_CLK_PER>; assigned-clock-rates =3D <24000000>; #pwm-cells =3D <3>; --=20 2.34.1 From nobody Thu Feb 12 03:00:57 2026 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2130.outbound.protection.outlook.com [40.107.14.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75EF856B95; Mon, 1 Apr 2024 22:25:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.14.130 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712010348; cv=fail; b=dKIS+X5paEInoGKRookkv3Rzfkef2kpk7cLjGfylCVEUtoIRT+/xvjIDU1eqid0MghqSigd2ZISwM30ewe+3pw/Mpg8sHb2snO9LZsRNqqTWSDj5O+1UglzzEkgFrSBeU6KenWYT4QA9idzeTHkPtUmPFj70QuOJ9WTfiWog7iw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712010348; c=relaxed/simple; bh=15tZk+yX7OFHAMdf72JNYEbxz/+Meras9AxnabVdvAw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=f5dEgU0EDcE2YMYxA9hgMGesQAg0x3BmejLAOV/xW3fGggVe3py02vlUstP7+NsI5pXIo+T6ov9ehIx0ljJhNr0UIMeOpsbIevTv2uRXp/z7i5C4wK39VUCmiBT6cTCBOgNja5ZYfLHcTHRMjXLpRKUIKzIVcdtBbU+OVdC7uvo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=clrY7cnk; arc=fail smtp.client-ip=40.107.14.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="clrY7cnk" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NWKF4lM7YH/GDXAmLB0v2/uyahBCswE5oQJUKlirWtrS+Uob176NMFR/bMsTPPxNlIC4TLj3RGoubxNNTMXrCbMz/Bl2UIOXs6ej0IBqltTMRqlwdT3ol72N8QjnUYj4vq4yb+v+wE+NtwpNXOLtusrZrVFkFMvGVyWXnqeVhvc/ZvqKZGT0l+NcOfcSXbBev+LzwntiLQyZ6WQjkAaO8K6Ww5JF+uL/oI2lb5NnkObT6dL4ywvboSOB/xjioGKPkzvpojJWr72/Y4H+5O2v6D2Da5N6H2kwDjFYKApC8jkGPBlpFxbrIp2nu9bUdteYDCfkFPWNcWzQ5Sfr388scQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sgeaJ4Pw2vjEI+nYH49zTPm+XjL910/96N1mkwiyItk=; b=V1FLe+0UpTdfG9SSz9pjjyLizMDbSclP74r8biq1AxXoV5D+teZ0Kn8F0XVyJBuJkUWU2bzXhR6X8ilRj7WjIqtmFo7uOjghmP77LAMwtteVC2NbaOGgl/tLEmLlP7jzMWVSE88f6LEhGSnWBPaVzIJRHg5rPmI6vBjT70ND7r4P43DTIu1LWvgd5pU3BnIerFAziDJ8FxeNqNTK3d7qv7pYMZce2OvM43CrPzIjEvumTDuE5b5qh1EFYtWxGXNUBhT3cDJTFBkJDTvdpAOsf4S2X1+yNlOuqPwUav0J1ZklCTgmvM66kBLT/U3WFiu7BRXdKQDR4OCMs+dT3695Cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sgeaJ4Pw2vjEI+nYH49zTPm+XjL910/96N1mkwiyItk=; b=clrY7cnkjFvUKlDvu4R37AP9lMIexL9SwJBHiXA5ie9LwtjgFhVl3LjwOLXiRJTnh4tl5I/PqnGfVm5/U9jF4X0uUDvYC+sEoC8QABYytn8w12ZejZIU9ACitu//19qtavbul0WcQ9rnUHvSwQ8POq3Z7taG9begfnvA+0zbzCM= Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by GVXPR04MB9976.eurprd04.prod.outlook.com (2603:10a6:150:117::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Mon, 1 Apr 2024 22:25:43 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6%3]) with mapi id 15.20.7409.042; Mon, 1 Apr 2024 22:25:43 +0000 From: Frank Li Date: Mon, 01 Apr 2024 18:25:04 -0400 Subject: [PATCH 2/7] arm64: dts: imx8-ss-conn: fix usb lpcg indices Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240401-dts_fix-v1-2-8c51ce52d411@nxp.com> References: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> In-Reply-To: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Marcel Ziswiler , Philippe Schenker , Max Krummenacher , Alexander Stein , Joakim Zhang Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li , stable@vger.kernel.org X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1712010330; l=1863; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=15tZk+yX7OFHAMdf72JNYEbxz/+Meras9AxnabVdvAw=; b=8Ouh/fd9586+6wrzrlVRY+YjTbuep81ZZLENa6lkxlhVT8LNXOPq7Us8UceoO+XnMGjamC4Lu WxXfOTQ2zU8DH3SQ9bnwdZNBWbxwSaDjlzomq11vC3xYln6TWWFULF6 X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR05CA0011.namprd05.prod.outlook.com (2603:10b6:a03:33b::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|GVXPR04MB9976:EE_ X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y/TM3YozDBRbNPvNo+jzzzmY6NtzPGBq8S8/zuC8yCBS5QXb7qitqL8wyfNTz/LH3Pq5Sya98CEr4y6z1w7c532KjmI2KGY1UTCFM1QnalfkwUksNMUxE17Ry/a4kEMvvPpu7HESIOiOPgymxgOnoPGfcaS6SDMvc+9Px6yB69NP6pGzd7h41wU6xD9lOEfWXcJm+7/D4KbVyKP8I4Zm60coC393Lb4FxaA1I46wIOm3Xt4Kwc3w2VYeuPBkSJkyPFaer/Yk13dDrjZTL6XNIP0achtv89cnOCqg2PaixugRb4V87mv9yNrH7giMoYUknFKkVeBjx/mjXEGeWXsKUXg9nvgIuAlzNFeY4dtTu5kVB+iRyMbkMZOkBhjkaTiYCxNCw8+jCTkLNNvbejFQrVeu3ZD0E1ImUvFOBmOHoH6fcG6rvoU5KWOhkpz9tUPgUzlXM6u8EUqsRl7nWeuZmcK9kgbJor6adzKwEO3A3Rm4y+KpwBL4vjUaW2Sn++lr0g4PJIWACBRAGgqG3JkHoQoNEeoWcS5awesbwXiwVp8P9hg+gt10HRrFWYbkqrOtmBG8urYR+93sDCZ/QXyHJT0udNn6usmaQWW/0gWrBPF/k7/M3JMj9AZOn89g7M1tLQt/Mu5Wk5WCiMtAPxaERL5FJJ2pp3iaj+/dSR1AP2E81bUNUZa9QuXLgPmx5l8JoJ4MlFolChgwi1agOHY9TXesx2Wyno+USZ6/x734rjQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(52116005)(1800799015)(7416005)(366007)(921011)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2p5M2tCVkZZMitiZjNvMXdadFJNR3pySUwwcjNlVnAvZ1puamVFWkdtUXo5?= =?utf-8?B?UEUwMGV0ekZMMDlaVlpNQUo3b0NXUUNHYWRoMWtBaXM1UFBDMWdVS1FaYkNE?= =?utf-8?B?dnNzaW5XUFNRb09yVjBuRWxCUU1PZzcydytsV0xKMTliNzVORGg4K0h1SmFP?= =?utf-8?B?ejZZRTlCcnk0RExYMnJqMGFTZmdrblhxVEd0allQTWx0ckF3N1dwbDVlaHdm?= =?utf-8?B?RXpjdFhKei8rL201M3JJdmxYVnFWNlM4OWZaWHEySDZ1bGlIcU9id3ROa1Q5?= =?utf-8?B?TzZXNUlGUm51U1ZQZDhYR2RKRk5RQ3pxSTdmb2VEWk56RTE0MWVoNEQ4cTlY?= =?utf-8?B?RTlQSExvRUk2a2d6eVF6anIySFl2UUdkZERienRzOExNWDlDVkdTQmhTUGpL?= =?utf-8?B?bE1sQkhiREJOcEM3ZDBUbHBwS0huRXVwL3p1S2V2eGgxb2J3U2lsU2N3bVBM?= =?utf-8?B?NGdGM1NPQWtjSGY0S25Xdk5MMXBwSHlzOXgrallscklicUo4MmkyQTFzM0hZ?= =?utf-8?B?YTdPRStFNmlMa0F1N2JvUGVlVWJ3a1RiUnNyc21xbnptUnpycVJkQWwyd2pK?= =?utf-8?B?K1grZTlsUFZqWnJtV3ErTHhJZFBDNEZtQ3FBa2pNN3BnbmpNZW1wTmFBdFZP?= =?utf-8?B?QlpEOCtiZ2RkYVE3ZEZRc2hRWkVOTU56VXp0cVdxWHhPTFhzOUFlTlVjZkRp?= =?utf-8?B?RjEwalJzVStkZjAzb3lUSUtUZ1ZYQThGaXBjMUV4eENEK2taM1REWXRuNkQz?= =?utf-8?B?Vy9vTmhXcnNaM3RnaGE5TEFGWGo3NEo3U3UxTEozODBGR21kenJQNklhN2NL?= =?utf-8?B?SUVBTTFpTWREVCtERVVrcDFPVmt0clFMQ1FRSTJGZWZQdzZrZnFiaCt4b2Vy?= =?utf-8?B?bmVSa2RTekpkWU5zNUI3N3JMRWRBTmo0aHp3dGJEdWhVZlJEaUpKdkV2R01H?= =?utf-8?B?Qk9hcDFLMGJmNENuZzQ5bEFmTXYvSzlUTU5TMWx5L0I4THRiekxwWXNzMHR0?= =?utf-8?B?TkJFM2JybzBpVzhJd3JtTTNPTUZkYnJ0TCtCTVUwc1dLS1pwQUp1aVF0SXdF?= =?utf-8?B?eXVOSDEzbEtlNFlubFpzdU1kQTNCS3RienA3dDVVbERpMFErck5oZTEvaFd5?= =?utf-8?B?SnpJZW1QYkszN0NHYWZ2Smo1NkhyQS9kcU1HcGhGbDN3SmVaVHVmRGMybXly?= =?utf-8?B?Q2RqdCs3T3VIY0Jvd1hkRUFsRXVkYlZYdXRCOWRJN3A1YmNjMlpycXdNVitR?= =?utf-8?B?Vmc4TVNyZk5pSGtkYXROV2Zob3hFVERZZE1Za1JRd0QvTUk3TkcwME1VK0FH?= =?utf-8?B?SjIyZHhLVzFCVzNKT0lad2ZyVFNNdUMrVFp6c2hWaXVIcHNPREJBTm03UFVy?= =?utf-8?B?aWRQWElEZFNPVmswU1FGVlNPL2pIMWZhazRQc0FQK1NOcVljQUt6azZXRWRh?= =?utf-8?B?Z2phYVMwY3dubFErQWZvZ1NyblRxMnpYalVjQURiOG1taU1qOFJFUmpRdDls?= =?utf-8?B?MGtkd2ttQXFpTFJoaFVvV3B0U2lsSE5laEkwN2JCU05GVnBLSDVkNkhka2tw?= =?utf-8?B?eHVpWm9PeXgwb05NYUY2SFZKZy96ZjZIei80TDBqRC9wNTZ2SkIwUHhhdVBp?= =?utf-8?B?Y2luQ2VxN3JOYWU5MmhSZlZuOEk5SGIyT1VDdnM2bDlSNVQrQ2pXSEp3dDV0?= =?utf-8?B?ZzgzaEtWNHlhb1gxeS9tb3lXdVB0aFVGNmRudndhd2dyOXBGcFdRTG9PTUFo?= =?utf-8?B?L3V3aVQvbjJDZ3BNTldqbE1peG1zYUp6Q1dRMTZrK3BrdkdLcmNrbGlHeDZP?= =?utf-8?B?b3lLU3VHNkdhRXNkQ0tTT0dQdTlxSUlHQnZXYjJ0SC82dnJyMVNjZXJ6VlVw?= =?utf-8?B?QXJOUjlTeXQ2L2dwWG1YNUZLMHoyN0pQNThpall2a2pGQitSbkRmdkZueWNF?= =?utf-8?B?ZWFrV1ZZR3YwWFRxcldIN3hrK0t1VVM3VzlyTzU4ZnZQbVE0Uk9XYmNoT3k5?= =?utf-8?B?VkRWbW01d09rRlpLWHVGUTk1L2h1b0dESVFZQWovNmRLZnBSTkQvcVoxQjE4?= =?utf-8?B?TFM3YnhvRnpRRWVWUWd4ekZ2YjBXWkt4RU5CYTNMdkRLVG5SYmhtU0Q3KzRw?= =?utf-8?Q?yKZM=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 947c0415-54bc-4302-e2a8-08dc529aab67 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 22:25:43.4909 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JEO0tk8PdJKL/3zAaBCsbZmukXMvnFvp/utTHmB2XDDrS4TU+sWKFGywzCb2KoMBARVC6tCfnCgeodgiB92opQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9976 usb2_lpcg: clock-controller@5b270000 { ... Col1 Col2 clocks =3D <&conn_ahb_clk>, <&conn_ipg_clk>; // 0 6 clock-indices =3D , ; // 0 7 ... }; Col1: index, which exited dts try to get. Col2: actual index in lpcg driver. usbotg1: usb@5b0d0000 { ... clocks =3D <&usb2_lpcg 0>; ^^ Should be: clocks =3D <&usb2_lpcg IMX_LPCG_CLK_6>; }; usbphy1: usbphy@5b100000 { clocks =3D <&usb2_lpcg 1>; ^^ SHould be: clocks =3D <&usb2_lpcg IMX_LPCG_CLK_7>; }; Arg0 is divided by 4 in lpcg driver. So lpcg will do dummy enable. Fix it by use correct clock indices. Cc: stable@vger.kernel.org Fixes: 8065fc937f0f ("arm64: dts: imx8dxl: add usb1 and usb2 support") Signed-off-by: Frank Li --- arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi b/arch/arm64/b= oot/dts/freescale/imx8-ss-conn.dtsi index 3c42240e78e24..d862d2285d208 100644 --- a/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-ss-conn.dtsi @@ -41,7 +41,7 @@ usbotg1: usb@5b0d0000 { interrupts =3D ; fsl,usbphy =3D <&usbphy1>; fsl,usbmisc =3D <&usbmisc1 0>; - clocks =3D <&usb2_lpcg 0>; + clocks =3D <&usb2_lpcg IMX_LPCG_CLK_6>; ahb-burst-config =3D <0x0>; tx-burst-size-dword =3D <0x10>; rx-burst-size-dword =3D <0x10>; @@ -58,7 +58,7 @@ usbmisc1: usbmisc@5b0d0200 { usbphy1: usbphy@5b100000 { compatible =3D "fsl,imx7ulp-usbphy"; reg =3D <0x5b100000 0x1000>; - clocks =3D <&usb2_lpcg 1>; + clocks =3D <&usb2_lpcg IMX_LPCG_CLK_7>; power-domains =3D <&pd IMX_SC_R_USB_0_PHY>; status =3D "disabled"; }; --=20 2.34.1 From nobody Thu Feb 12 03:00:57 2026 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2133.outbound.protection.outlook.com [40.107.14.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C369857323; Mon, 1 Apr 2024 22:25:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.14.133 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712010352; cv=fail; b=Eh14bzUCTjptmT9J+IaXzWeJdBmbR24p4T7J+EBa9A6cTWAeKyqKeDz9z9fH5EIxy6IsGS6WCh1sLxP1faEM3z97uD8Uoj79WdHdJk+nwbFSONhnnErNGwInE9GA2X7DrKyeI6JPM0TL6UL8NISB/hraXq7nXxFVRRFzXMyiX6k= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712010352; c=relaxed/simple; bh=UihqGtMDMPc/QTYsaIIsW7589SZYMUiu0ZudQvYpP9Q=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=rfguldNciMQXqyJyakwIr5BkBre+4AnkGBJcpTiPCOPPuWvUzOSk9AMdoSftK7nsHZ4kNssqallAHPITcL+t/oafMnt9QQ8Umxq6Y6HEbQwGx9Dk8yjdCa/iOuNnXVSLeV3gCn4cxd4AU1WPFx0yzg+W/stqDe2/B4iAqND14GM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=VZgiGF49; arc=fail smtp.client-ip=40.107.14.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="VZgiGF49" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lDgGdRn1HMsiTTTj8E7OdH7Riulkvzgt5gZGRR7+qUztA8w4Cfar1GoC5IG3UGope/GEZ4RnpdggEBT/LQsrQ6X3WsX/ZCRiE8XJmfPi7RPnFZzRbarGxOwldDcTm+LnsIcPFWu2xWZb1UgP4bu/zAtmYxR168D/bCCK9JwEK2/Z89K8K0qMuU7lQ5sauMt4fH+1m6D78y7LbyEs/msvaDee+hSd16JxzE/DbVsSe8G4ZgfrBJMFqcrH7n2WusZ5LFWcBOGk+3WZc7k81LLhIIV4ixPANCDiIQnCg09s8J4NgtLiT7Py9e9yOCm00o9I490GV3nbHzXiWfqnXQ508w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LMwZ5jtaKe4vgTwB20lnrfZVoLaEbOpy3ozujeu8LN8=; b=HzWbv+IxVAGXBSe+BRCWgrNGAGUjy5sW1UY9f2+F8v7OM8zbWRwseUfsrOsQvoGraBu9si7rq+jDI54MhD16w8s+dCyrJUA0uf4sQ/nPEUWazj6130mWMobnB6VOhPnVJLggIB1/E80xyleL3ErrkZLIheu4anhOCU7+RWJfWfkrZQ1w0V2fBavNmd5jOcm2yP+hsODs8L5f2OEI6prcUySCS6NXoodGv6y5JSwaYJSb8AwlqyNfJzK4MQotq+DZUGpPj9DevYCJMaBxc9srsQXUWjO5Q7f0fQjLGYRIrDt8foObyCFBku0a7xqGhJWkb92KdQ1WfzB1M9exf9v1GA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LMwZ5jtaKe4vgTwB20lnrfZVoLaEbOpy3ozujeu8LN8=; b=VZgiGF49QJospzQ3B9wOfnk1eYSVPUX1jsbh67910X+5wWOERer3T4Xlvsm14NOYWNgR38EMpGyQjO4RpncOZgQnsNoPGYVpyR/PtW5aMHZupGw1nECYCP2zORzQSsfnT8cyfFZUD9uCDegI4cP29u1aKgu9t/YzvOY4UFJG54c= Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by GVXPR04MB9976.eurprd04.prod.outlook.com (2603:10a6:150:117::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Mon, 1 Apr 2024 22:25:47 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6%3]) with mapi id 15.20.7409.042; Mon, 1 Apr 2024 22:25:47 +0000 From: Frank Li Date: Mon, 01 Apr 2024 18:25:05 -0400 Subject: [PATCH 3/7] arm64: dts: imx8-ss-dma: fix spi lpcg indices Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240401-dts_fix-v1-3-8c51ce52d411@nxp.com> References: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> In-Reply-To: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Marcel Ziswiler , Philippe Schenker , Max Krummenacher , Alexander Stein , Joakim Zhang Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li , stable@vger.kernel.org X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1712010330; l=2937; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=UihqGtMDMPc/QTYsaIIsW7589SZYMUiu0ZudQvYpP9Q=; b=gt32yUq15b5dZZW4A18ogLVWndfXVLzqvL0434OACcLvL8QQ16zyuS2OinnKwVnlzTOqoE2r0 o0qr1iXHPHxC/740w4QeGwg9i/7uiOfS+XNv4jEyczqLirZYF4IXe7c X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR05CA0011.namprd05.prod.outlook.com (2603:10b6:a03:33b::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|GVXPR04MB9976:EE_ X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Faz9Tg+pZUa1ApB9TZaUOG5eVzRimxAtVPrRL0sdLDi0qBlvwd4OxFg7+ADe5kcJ9eXWlTUX4PColdpsYtFN0AhG5Mkz/4Lk39YlFV1xe/uErqdTt6sbqq6a7VvOpFea/XZOPuyrpim8fv6U+oUTDyc/Qa2q72nwENsmwj0dQxn3CXikweL3CspdfmQb2sWsFDoIVKzS6nw+Bi2ObewWkwoMuPadigZbAawW8HqgYIVhfl6olv0sIigKNhjisQdabCP3pSu0XvgY2fTobkBApXj+EkFVtrUxP+mOoXXNF1FGqXKmx9uOctb/lLFyJkcn+xY7UHxvPWwn2F1lo3wpmFSX+xgxrQi0x68BpMW6x6kwEFCNvGEg/hURifIf0jaH9NQCi/wQGimAlqZc1sBHi0b0ZixeqHgg4IW1FOOVZ3JqwH8kFtE4ZJyAtIDbBgRzANYPJEc9l45zRwulZ3p+i2CbujQtY5t/rWtW/W/GGlrb6mL6ccLpbVTcaoBkpkYrtgzrom/2y56o07BXjGDL9ETw5zg5o2CvaOg5EACLnU+tp7f/kD2BBiuDdscLS3kOESHThf3Jl/PaSA6S/tbwsBFBm7nrYvZB/2n7UxR2oTYfaWeX7HXSb2O1SQJ85s1XX9RXTmCF4Jn+kU1DNRwfHHgKa4gjWgkXrTyw6oRLcZ+EXAhO3HzHAJ7ilduIy6marVyKcZsO3XSN8Rjv+feoV3MTtu1GzneLeJ6lF+wC0mM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(52116005)(1800799015)(7416005)(366007)(921011)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qkk2M0hKL1I4NDdCQlBVSksyaFBOT29WemlTM0xGdklWdlNqcFlPTFZ5d3Rq?= =?utf-8?B?VTV1aDN5ZTBqRHNrSWxXL0J5R01RZ1NmSDFneDQ5bkNyUmR1NlROK3JlV0FL?= =?utf-8?B?Vk5KaUZuWjA5WjFSZkw3aEdhMUhNS1pyVzl5WGxnSDU0ZFVwRXZDL1Y3WHVF?= =?utf-8?B?UmRxb2dPTVpTeGtkL05HMW4rY2E5bzRWWEFsQUtrc1hpbmJBbXZYbDZENFdS?= =?utf-8?B?Mlc1REVPZ2czMVc0TUhWNXRQd0xvVVI4VjRSTjc2ZnV3WnZaSXJSU1FleWJY?= =?utf-8?B?NWhObGVQQkcrNGthT0pWVFFBd25OdzZjYjhKMjFDdjdTMDVJU29PNXZ0QXo5?= =?utf-8?B?MUtwdU9SR05LRGpvOUkwUVRHN0FjYWI3MS94cjlPUVY4MThzaUo5ckhRN0xU?= =?utf-8?B?OXZsT3lmbi9Ycmt2cEVKb2xncEFtNHd0YUNUdXo0dFBzWGtuMGU5L2ZKMTg4?= =?utf-8?B?QWhPeUJOMTl1KzEzaC9DYTlvcW5SNHY2Z0htTG5KNGtrL1A4VXNYL2NRZDYz?= =?utf-8?B?NDJrQjhEMlVmaHFhNzE3alJmQlV6Zll1SmJEeXlKcE5XSlNhR0tEN2ZpWFZG?= =?utf-8?B?Mkp5SGJWQTFRc1RrT2Vjc1hnbk9pYmdKcXFoUzV5L3NhTTljQW9ITmJpZHJh?= =?utf-8?B?Z3l1Nm1mOGt0dzFNdUU5TSt6amtORHNXNWxUUDk2c3hXMi8xZGNQaVMvd3cz?= =?utf-8?B?TjYrcFRvQWxsSDFNK0dodHptbEtheTZ5dWNUN2llSzdmM05OMmgrOHI1UmFU?= =?utf-8?B?U2F3cjl2NE5OaUFWWS9wSjBhODI5ci9oRDBHY1dObVE3MGlkY01hYWFVQ3JV?= =?utf-8?B?MnZPa05VSHRSZ2ZwdmNFL2E3T2VjVlROMkVPNUVMdjNXc1hqaGpSYW1LNloz?= =?utf-8?B?blQ5K0diNTZHa2tvbnZBTkNyM0dtOE9vNTZqTXdmdzdZZzU1L3dCSlBWL2Fq?= =?utf-8?B?TFBMS3V2WGNybnFGbXl5dWI2dmkvQW5ja3BxMGlxZUh5RTM1RTc4SlVPUEsx?= =?utf-8?B?VHEyYnIxWTViSVRCNDN6OXBZWDZ0bVdIWFo5R0VSMVJ6OFN2eDR4QjdFQWV5?= =?utf-8?B?L1ZKV3FMYUZNVlZyNWdmTzNDTUppSklXZjdJU0hPckg1cmtlL2E2TEVRWjRi?= =?utf-8?B?TnR3RUxPSXpYVDBGejR3RytmMHlkY3lacDk1Q3FtSHJIVDNrNjdvTGNSRWVN?= =?utf-8?B?MmxMNUZTMG1JbHlQMUkvZWNDOTVtQko1ejZ2VFJmTFBjdDVSeUN0dGpmcHZp?= =?utf-8?B?bHRqSjlwaTBuVitDVDFOWmlGWlhYZHBtZXNvcnJweHRjSGNYL2JQQ2FkTTl4?= =?utf-8?B?Mjd0MXBHRUVFWGU5Nk83T1RqWnZFSmxtekpXUWhuaFdkQVIvTjZSQS90Ym5T?= =?utf-8?B?Rzc1ZEN6bERxeHFZLzlBZHhrZjJ6V3hzNFJqa0pkNkFPSngwRDYxR0F6Z0tC?= =?utf-8?B?NzZ3NDhBNHpXRVdIVlo0QzV0M2QrUEYwR1RVYXlPZWV5TlVSZ3ZaOTNyKzgz?= =?utf-8?B?STFKM1ZvbXNZYlZmZ0gxZ21TNVlJQUV5SUUwbndSdy81TnBKZk5jVHZKU3R0?= =?utf-8?B?SFpMNy85cmFXcU1aQzg4Z21ZSHdUaUltdVZnWVhzV2JvTEVBM0tLeHFtM1pj?= =?utf-8?B?UEM4ajJmVmI1MDNvSkk2UW8vclpGM0duTFJyeTd0aW9KeG9DRUFhY0xXS25G?= =?utf-8?B?d2ZMaHJqNmgyclhhbmV1V1M1OS9YY0hBSlpGRjdkWXEwK1FRWUhUam9TMWlX?= =?utf-8?B?UzlmSVQxRUQ0eG1NaXZsc0ljbDNzc0ttYVhVTCs2R2RLbWpreTBtdnVxcm1U?= =?utf-8?B?eDVERUZ2VDRCaE9HbmlTQUVYUlNUMDBWcDFBa2JxZWM0Vy9zSzhyalVFQnVC?= =?utf-8?B?NzNJNkhUWkpOclVLQnlldzN1Z2RUWU03MStyODl1cTZhWTBoblhXdnZabG05?= =?utf-8?B?YlRPb0U4em5vbzdlMjRLUkp0bno2VkRWektXdkFjaUZOVThZV1NmQURtTEZF?= =?utf-8?B?ZURYamd4ajhrS2RnY0xXS1lYUVh0NkF6dWo5L0thRkgvaStxdUhBTVVrZXEr?= =?utf-8?B?V3lzbmFyZ3FOaTRyUG91bEZicU1yemFRTkNLdUEwSFdPRkVNakliUnloa1A5?= =?utf-8?Q?TiG4=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d5b979a-3e07-4e94-860e-08dc529aadf4 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 22:25:47.7573 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cxD8Wm8S8mzkrTk4WEuCFKBM2JYkZxmNYDRzAXGkf7mZbzTIUa9PZhOfpobB8/o7BVHIMnnEd63yJC2zS0b5Xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9976 spi0_lpcg: clock-controller@5a400000 { ... Col0 Col1 clocks =3D <&clk IMX_SC_R_SPI_0 IMX_SC_PM_CLK_PER>,// 0 1 <&dma_ipg_clk>; // 1 4 clock-indices =3D , ; }; Col1: index, which exited dts try to get. Col2: actual index in lpcg driver. lpspi0: spi@5a000000 { ... clocks =3D <&spi0_lpcg 0>, <&spi0_lpcg 1>; ^ ^ Should be: clocks =3D <&spi0_lpcg IMX_LPCG_CLK_0>, <&spi0_lpcg IMX_LPCG_CLK_4>; }; Arg0 is divided by 4 in lpcg driver. <&spi0_lpcg 0> and <&spi0_lpcg 1> are IMX_SC_PM_CLK_PER. Although code can work, code logic is wrong. It should use IMX_LPCG_CLK_0 and IMX_LPCG_CLK_4 for lpcg arg0. Cc: stable@vger.kernel.org Fixes: c4098885e790 ("arm64: dts: imx8dxl: add lpspi support") Signed-off-by: Frank Li --- arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/bo= ot/dts/freescale/imx8-ss-dma.dtsi index b0bb77150adcc..a124d6598406d 100644 --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi @@ -27,8 +27,8 @@ lpspi0: spi@5a000000 { #size-cells =3D <0>; interrupts =3D ; interrupt-parent =3D <&gic>; - clocks =3D <&spi0_lpcg 0>, - <&spi0_lpcg 1>; + clocks =3D <&spi0_lpcg IMX_LPCG_CLK_0>, + <&spi0_lpcg IMX_LPCG_CLK_4>; clock-names =3D "per", "ipg"; assigned-clocks =3D <&clk IMX_SC_R_SPI_0 IMX_SC_PM_CLK_PER>; assigned-clock-rates =3D <60000000>; @@ -43,8 +43,8 @@ lpspi1: spi@5a010000 { #size-cells =3D <0>; interrupts =3D ; interrupt-parent =3D <&gic>; - clocks =3D <&spi1_lpcg 0>, - <&spi1_lpcg 1>; + clocks =3D <&spi1_lpcg IMX_LPCG_CLK_0>, + <&spi1_lpcg IMX_LPCG_CLK_4>; clock-names =3D "per", "ipg"; assigned-clocks =3D <&clk IMX_SC_R_SPI_1 IMX_SC_PM_CLK_PER>; assigned-clock-rates =3D <60000000>; @@ -59,8 +59,8 @@ lpspi2: spi@5a020000 { #size-cells =3D <0>; interrupts =3D ; interrupt-parent =3D <&gic>; - clocks =3D <&spi2_lpcg 0>, - <&spi2_lpcg 1>; + clocks =3D <&spi2_lpcg IMX_LPCG_CLK_0>, + <&spi2_lpcg IMX_LPCG_CLK_4>; clock-names =3D "per", "ipg"; assigned-clocks =3D <&clk IMX_SC_R_SPI_2 IMX_SC_PM_CLK_PER>; assigned-clock-rates =3D <60000000>; @@ -75,8 +75,8 @@ lpspi3: spi@5a030000 { #size-cells =3D <0>; interrupts =3D ; interrupt-parent =3D <&gic>; - clocks =3D <&spi3_lpcg 0>, - <&spi3_lpcg 1>; + clocks =3D <&spi3_lpcg IMX_LPCG_CLK_0>, + <&spi3_lpcg IMX_LPCG_CLK_4>; clock-names =3D "per", "ipg"; assigned-clocks =3D <&clk IMX_SC_R_SPI_3 IMX_SC_PM_CLK_PER>; assigned-clock-rates =3D <60000000>; --=20 2.34.1 From nobody Thu Feb 12 03:00:57 2026 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2107.outbound.protection.outlook.com [40.107.14.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C488656754; Mon, 1 Apr 2024 22:25:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.14.107 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712010356; cv=fail; b=lnaZkEEFRc9ZdeX4RLr1KxJ/5d4OxnuRSWwuUJLC6hG+HC5YrRnBjfOWH0oHzb2t270BhItP8/RShwrIDi1pT0jzVLpmlpZuE4bC6YJ6SAWuUIgGz1dmopy0GREQ7uz1gQyCiNF1uFkBlyCDCseauJuDgeSE/voKCT+CEIIdEeA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712010356; c=relaxed/simple; bh=fdsoDcgdp2uhQaS8/tOFn5VfeICbpQvKk3TSdwKDGp4=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=MwH4hZ7Y3Q1FgxECd+7SadX/j/yVsWubZm7FpsesoNATRv4IyQb4ynarm/ed+KzrMhG/cm1OZQraduAcRvdci8+mdqWOQm/k0UKvJKDQ3sm8xCGxPlCTXjBfMUoiliplcKOPpYnu103C5PoBp8rSvLO2clBiaL6f9i2Q2sby0K8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=CRIAky0O; arc=fail smtp.client-ip=40.107.14.107 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="CRIAky0O" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B8UopdBYQsXS8w2/0xFZ9BBDmYW4JBbF+i33Hn9n92a0wQ3cPbgyH7RJ1aKEo0Ek/Kc0/6Ct4pCSBt3csoGHE473+z/+DTlaykTd8dV14Kp5LATRt5NSaSwmWfDA0Ly5ExfJltIxlcg9Pj8dFCI2IHrHyW3Ggck6Mm5UOZFhC4eGPLCMu1+h5KyAn5+hMLUnbpjRyJrW8w2UEw8mihKBElPNZGeNe0ndPkehP7XqahG24iAB2Nd/6BWz3FmVzgVL9ASpYSX7cqxFC6nVh20HMeFHtkT01nqO4k91HL7Gin0Bc71TRqhpl0kUwEseB7mrENJZPv25kQnhubjbn7lBlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=82v2SoKhMzQ7onXLz6M6U1dv/j+k4JRrE+7GSWRTOk8=; b=GR2OoS1ddW5gH2D9XW0Vi2VNyxCZCW9+HWYLMpXecBM6IETsmqhAybgmbzKIhnbLBRiqqW7DytJik4tTnkzdvnTkERoFwkMb/YfByDRCTaOtlJq6vE4mYreiH8dWiW549wZai/s4lzFiUoZV0hTs0dYk6RboPawFOPWCCNuLr+zoP+NVVHQmvMDtqy2IUsrh/vIJvi3ZUbW5QBHmI7M+hlYxeMplk8kUpNcnn3YH2xuSY13gsy1pvEzH2wMNfgpu7xsYQddxmUGU1I8uK9ZO/fEiYmayaujQqdt99j1trEOcW/LaheX8MOOHWTDTsZrsPzNHcvnz4l+f4PybgKcaHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=82v2SoKhMzQ7onXLz6M6U1dv/j+k4JRrE+7GSWRTOk8=; b=CRIAky0Ovh9T+VmQa7+abDuBC84tyztsOzoCWMkFps9K+9O4TP0WUctvgKGCjdAz3nf6GipA7ET8DhBZmJXCdm71IzK1+GYhTDjBAZIEPKGHBeHYXRLZMDWIj2MCIcG5EqkszrxgKWcbn/oSJLy7lIjo+57IXbummYUE+ogRjv8= Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by GVXPR04MB9976.eurprd04.prod.outlook.com (2603:10a6:150:117::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Mon, 1 Apr 2024 22:25:52 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6%3]) with mapi id 15.20.7409.042; Mon, 1 Apr 2024 22:25:52 +0000 From: Frank Li Date: Mon, 01 Apr 2024 18:25:06 -0400 Subject: [PATCH 4/7] arm64: dts: imx8-ss-dma: fix pwm lpcg indices Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240401-dts_fix-v1-4-8c51ce52d411@nxp.com> References: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> In-Reply-To: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Marcel Ziswiler , Philippe Schenker , Max Krummenacher , Alexander Stein , Joakim Zhang Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li , stable@vger.kernel.org X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1712010330; l=1745; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=fdsoDcgdp2uhQaS8/tOFn5VfeICbpQvKk3TSdwKDGp4=; b=Hh3oHxBHwLYgBiYlmxkonIQ2s0FE32klh2UftURC2duBM/QoEZKeS/irbACu2GxSeH9yqGfw0 2bTkFJb5AfXBRpA6yxmOrZN7SZZ1kjxCf0hOkK3LWlYp9nrWlz5CTLI X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR05CA0011.namprd05.prod.outlook.com (2603:10b6:a03:33b::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|GVXPR04MB9976:EE_ X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fye7lKqJHORFe6N9XfLjlIOVK9GX7EkUHar5+h4AzMCQ1Fn8yrtAW2XtP0kIkYS1Sdq8wBAqo7wqAZuYsRcd2FQWQya9oYXmbpqiKgfi8+n2RdTFK/psnbVG1lR3mXPt7Wls5yiJ+jn4y7lIyAS+1CeCFr3dFGAPrwSU8EGk8LuRQt0vqpGkUcUlPo3IuSAzV4WGwXdh9YBWAV5qCjVsVPyfljincGdLmGF6qdEktdAc84yJoMadUD5onyOLj/YBB/xHfswnslELGbasKsRjYQ6K+lnhPRdB3gAtjru9TM4vKvh+fX1ASfs9XWqjK2oOdqXQ4dqWs4zDkdRzl2tPTJJWG9rctoNuiPUabdlP1nIzqdlmXsEpfu00EoCZXiRaHzWS/w7ko6O2bvkNdlT0rkUMuMSFIyLjAlk5K576lk6cIvYPuCOhYJZI0bclXrfpjVo87ha/Qw3pYJJdo7M5r/NF+fD1sui3KGgzgf4DNZCXN6Xfx5Z3ZHv4I9PC9ckOzGYjUAhfJo435x+kPMbxKkcYy1/bPy8WV5nEmnbxP6TVuJRH81kdwpTTvr4nhkJggpnMyTPqyWG0Cm0YZuqLIcLGr8mVfNTyJ7eiEt50vEfHZQ0NUbyqtkStWgyKfAgTk27Jqq62yJoXx3pbjsPyma44sBY+ButjVTFJjtP20GnHdmBp5SI5rcVTF0n4uPFN7KNLwDBAK1d4XxtLtdVqbHgXDumVy+bjoezR34zdgEk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(52116005)(1800799015)(7416005)(366007)(921011)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SGd2MnN6ZmRuNm1WaVNwMmlKT0JEZXJFdDZPRnZqK3hsVlV6Y3U2MWR0dHRC?= =?utf-8?B?MCtnbW94THJTUHZjeklZVTE5dUU4bHBURjBPd1BnOUxWNmdUaTZiZUdDWlpS?= =?utf-8?B?T0UyMklxWFplbW9QVVdueW5HeVYxVDdQc296Umo4UW10OW9LUEpwTjNhMFYx?= =?utf-8?B?YzFJZmVKdUR4Qk9BeFFnYU9QQTFscEhmODlOZTZNZkRIT0k3Vk05ZnBPVCtB?= =?utf-8?B?RC8vbzhQOFh4ZEpaM3gzdEFCQ0VwZm5RWmpMOWZJOFlDN09nZmlNUG1VcXVR?= =?utf-8?B?L3ZWM3BKcis2aU5NSEFKYXRvelFmVkVJaERSY2E5bnFmLzlmelZmemx1MEdR?= =?utf-8?B?ejZXUExTRFZINkF3eHFCWTZKNUZEYnBQRnJOSm01TmEyQXpRdmQ2UVUzSGpY?= =?utf-8?B?VDFPTkVYMkUzU2pTb2xkOGtvNFJiY2dXVTR6Q2pKWnNzR2JkbUhSRzlpR0JN?= =?utf-8?B?YW9zV3R5b3hHaGlHMFRnNWxNbk00WDRZYW1HVHdOWFJaWk1lU1lCaWIwUk9N?= =?utf-8?B?UUFXSEYrVzNzNkpRSjd5ZmVGS1JldmNTRmQ3YWdjMVJGZ1AzSUJScU5ualY0?= =?utf-8?B?cUVwSlVMVjU3NEo5d0szcnRYeWtDcFVFalNqbGtYSmg5aThNUGI2Uk1Hc1hG?= =?utf-8?B?R3hhVW1XdUZGeG40dFlBand6OGlDQzAybkpwZFQyRG5McmhwWTdXem8vU1lE?= =?utf-8?B?MzJLa1J6aE50UDRRVHcxQ0V4Uzk5NzM2MDRoZnB5NXAxTDRQV1VSeGdEd3J6?= =?utf-8?B?bG1SNHF0a1VaR1d3SHladUp2c2toVUE5MEdNK2tHbWpOenozTm1hS1RPT3Zi?= =?utf-8?B?YTY2Z3ZVVEJINjBaa0p4RCs1Vm14dEJydDM0K0l0MktHc1JGWFBURnhZZk5C?= =?utf-8?B?eEczUDdhYjhiM2FySWNDUkgzWGg3NVBFWWNYd3UrRXA5USs1emc0T2dXeGFK?= =?utf-8?B?U0J3d1p1aVJQU0NuYXRUaEVtV3U3NHpQN2NjVEU0STVXam92ZFZ6YmVrSXJv?= =?utf-8?B?YkVoNis2SkVETklKbFBQYldwbnFjdkdFckE1MTFqNlYzQktYSGdnNmwycW1M?= =?utf-8?B?ZisvSXVUWFNWd2tYa2FNM0hXRVNlczBTZHp0OEtMRFVqVG1URVJMQTZSc1p2?= =?utf-8?B?bzBJY2lvZEFsTVgzZE9ZcnJERlFQY2NySHBoZENYMHBzWENkT3ZrcGR3aVJO?= =?utf-8?B?dXl4RGJhMHI2STk3c01seXpkK05ydkVoeXU3Ync5VitYTllOVHh2SVNDQ0xV?= =?utf-8?B?eWMyaklPTzFLc2tzRTNJQzhHUmZlS0hMNkp4eThMZlRaQSt6L29Fc2pRajRI?= =?utf-8?B?L0lFQVVZTE9vYzNPVGRpV0pvbnYrVW15MVVPeEoyOXd0SW1sK01uR0F3elBR?= =?utf-8?B?SkNGQWY0VDlmSkY2WVZpeWdnU1pDOFNpOGlLOE5zb1ltanlZMXlPUWdTd0x3?= =?utf-8?B?SXhqeS9aS1NZNTRFeEx6SEtqQTFaeWovMU4rNWVzKzRtMnpUbTNGZ0FWeXhC?= =?utf-8?B?UzZUSWFxUlpHbDhmNExsY014L1cvUFRTdEM2ZXExSHdlbUh3NUVjVUxoZXNI?= =?utf-8?B?ckJLUkcvYnpld21kQjlqdFBSMmpFa3d3YlY0cDJESy9kTUthL2toakFKRHU5?= =?utf-8?B?QTFuQXkrVTY0bkVnTi9zL3gyMmZxSmVqWUkwZDUrbi9WSGR5TEVoZ3hXbWdr?= =?utf-8?B?Q211ZWs5ZWhnWXBNZU1JQ2N5bTlFMEF4YWkxcjl0Tnp6TFZKTEVXR2tYVExp?= =?utf-8?B?SGNrdWpqY2xNdHlWRW4zUmpnMzZybytLY2prSEVCbHMxTW1QN0srTjY4M0xN?= =?utf-8?B?ejVUYnVsNFhEZGtQUWptVnZucjNZOStqSFlPZ05mUFY3M0dJQnZJTnBYUHVu?= =?utf-8?B?N21FRGdaKzBMajBiT2NSTDlNbkVuWFZuWUxqOVp1aHpRaWZwMjFPYk5sQ3V0?= =?utf-8?B?SktNbkkxUFZ1L0pSVFFkcmxCd3VXb0Y2TWV3c2E2QWlhVkFFdEZ4eW9yUThV?= =?utf-8?B?VjlIOTdlQ08vbjFHMUEzSTZXT1kxRzEyWkpzV001cE8xNU81UnJjRmhRcFJO?= =?utf-8?B?OUxvK25OOUlsTjAycVcrQzVxTTcrWEJEd3ZFQVVXVXhTTXc4bHIrMkNWMytN?= =?utf-8?Q?pQ0w=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10a7e5bd-1707-4ca6-bf32-08dc529ab078 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 22:25:51.9808 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UsRmB/Wna8OXWVmxaQrB4n1JaqRTbZDbVpLJ6rPIWUz7CV7YODLhuwUuFZHT1IZUiNShfGA9oJ6ZZ2snFmNXYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9976 adma_pwm_lpcg: clock-controller@5a590000 { ... col1 col2 clocks =3D <&clk IMX_SC_R_LCD_0_PWM_0 IMX_SC_PM_CLK_PER>,// 0 0 <&dma_ipg_clk>; // 1 4 clock-indices =3D , ; ... }; Col1: index, which exited dts try to get. Col2: actual index in lpcg driver. adma_pwm: pwm@5a190000 { ... clocks =3D <&adma_pwm_lpcg 1>, <&adma_pwm_lpcg 0>; ^^ ^^ Should be clocks =3D <&adma_pwm_lpcg IMX_LPCG_CLK_4>, <&adma_pwm_lpcg IMX_LPCG_CLK_0>; }; Arg0 will be divided by 4 in lcpg driver, so pwm will get IMX_SC_PM_CLK_PER by <&adma_pwm_lpcg 1>, <&adma_pwm_lpcg 0>. Although function can work, code logic is wrong. Fix it by use correct indices. Cc: stable@vger.kernel.org Fixes: f1d6a6b991ef ("arm64: dts: imx8qxp: add adma_pwm in adma") Signed-off-by: Frank Li --- arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/bo= ot/dts/freescale/imx8-ss-dma.dtsi index a124d6598406d..d4637037ba1b6 100644 --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi @@ -144,8 +144,8 @@ adma_pwm: pwm@5a190000 { compatible =3D "fsl,imx8qxp-pwm", "fsl,imx27-pwm"; reg =3D <0x5a190000 0x1000>; interrupts =3D ; - clocks =3D <&adma_pwm_lpcg 1>, - <&adma_pwm_lpcg 0>; + clocks =3D <&adma_pwm_lpcg IMX_LPCG_CLK_4>, + <&adma_pwm_lpcg IMX_LPCG_CLK_0>; clock-names =3D "ipg", "per"; assigned-clocks =3D <&clk IMX_SC_R_LCD_0_PWM_0 IMX_SC_PM_CLK_PER>; assigned-clock-rates =3D <24000000>; --=20 2.34.1 From nobody Thu Feb 12 03:00:57 2026 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2109.outbound.protection.outlook.com [40.107.14.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21CCA58217; Mon, 1 Apr 2024 22:25:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.14.109 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712010360; cv=fail; b=JF1irCrhA9W/Zw20ngBsA7jt2+N3tQXFc8vA+Y3LL/sR5MeKhdaVdU9IckM7MnZAKh3HNu4TS0F4aNC5ew/SzsNOQruFZ/OkGLx+mhq0uMaVeIvJrTeYUOhMEozQGDUeqHdKbYXz9WnpBPvZGjR4FvsZ5ApuU+TY3s+C1liyaX4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712010360; c=relaxed/simple; bh=PqFKqzOaCh+9X9gmH8adyKHBMmo89yE+D+WZJtUo004=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=WCqZ68cIMTRUuM9F9BB9+tirvsgqAyNGph9suBYnWMkMq0bhlBolpRKviFQ8ij/lCzZh/JB4Sb2qOtr8PzG7+DboXEMHvmGBbbiiwM3knRzKTz9K5tSlrY6RkIbB2SkjTcwFL76m5Yk6SWv2T7rLCxtkEjRWdEJn4/BeznMi/3o= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=MVkI2rh4; arc=fail smtp.client-ip=40.107.14.109 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="MVkI2rh4" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=myBrHfXm2GBI4QEPng40/pJ8G9E2PUy6kRFIwk4dX2HakHNjeUk9no212Cgg6U2kPg38BiwuHeSaFaCDLWApVWns9pfSClhnMcS0fbgcnN0k49LxY1x3lNmKanbx/jcuh6Cko/CjT/BBicIermky/36AwJ8xdIs5BjhEGqwZ33z+wbX3d69ZxH95UBN7cjl0YFlC0KgzHwH6NoXNsWJP3A7NPSZwJNh35CUfrNaXsfLKtvkDpfTDOMDoV1ch7yhb7OU8lTcQkWC123uJAiM6m72MKdGfZhqUFR4WFpY6LrrkxZjcAolFp25nnSenMKXbdg/d43yIr5g/9t0JfrFJMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QT3E7dpZi48J1VSrcWmHxpkF+vwdFoPc2vglBlfmOSE=; b=kJizs2C/+44RGKCKvbWMb2fsi6xIIHDqGW7l/DyZj3AjE0QZrwGONMcirhvwpP2t5AgzHnvv7K0iwa/mI+US5I+i9UUWBQBCJ4NLl6I2WWuv4BjGXb9vlanJYSrZBgMp+K5pYwGFwysF/hBcjLSKd8NDcxj4Eo47T4mQA0wlx+GxORsJhEUlIRYgYCYpKulP7WUh+UwxI+Xn+GSa84jDZHYEUxj1DbB5yN07G/4Z8lBeorOqDHOzrmTCZudw+sm4MMs0gtt2h3FHsDa1FfhqNqpplurB1OWODbFAmEh5E941THcrG0mu1oEXhiWVcy7BCdyIwUmaU/6ZSll8/FY2KA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QT3E7dpZi48J1VSrcWmHxpkF+vwdFoPc2vglBlfmOSE=; b=MVkI2rh4rLTg3oC4dFQPLwtRr7qMFUj26VYvPJYSYGHZC/RpstP2m4R/rfyfuSdKg/nusziV+LYwQuUAUc4Q56qM/uv4i5aKkHNyaU9NuftpnsdcmRTYAtaCZXIaCf2qvuB86sSIDR2vDoJXwQoES2Ek3CikBpSGJ6PmmeDM2Jc= Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by GVXPR04MB9976.eurprd04.prod.outlook.com (2603:10a6:150:117::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Mon, 1 Apr 2024 22:25:56 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6%3]) with mapi id 15.20.7409.042; Mon, 1 Apr 2024 22:25:56 +0000 From: Frank Li Date: Mon, 01 Apr 2024 18:25:07 -0400 Subject: [PATCH 5/7] arm64: dts: imx8-ss-dma: fix adc lpcg indices Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240401-dts_fix-v1-5-8c51ce52d411@nxp.com> References: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> In-Reply-To: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Marcel Ziswiler , Philippe Schenker , Max Krummenacher , Alexander Stein , Joakim Zhang Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li , stable@vger.kernel.org X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1712010330; l=2028; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=PqFKqzOaCh+9X9gmH8adyKHBMmo89yE+D+WZJtUo004=; b=3HrnBKewz9QWbC9cMMt4OcuPLW46GVDiuX2FoB41ZgOv9JFkveV7BwHN9mTXY2XCxC4OYuRsV 1oI0111dVdlCiPZ/xPhQta0xdFC6HfR0p5uu2HzkzpyZrT8hGDpIAeD X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR05CA0011.namprd05.prod.outlook.com (2603:10b6:a03:33b::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|GVXPR04MB9976:EE_ X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0kl/BZQXYSQjfZehZYZQYFbKCzTxExmh6otv39/LwM5B6fdYN+zaI+GvJmtN/xz2HGFeHm1quSxpxuNHY069UgvG+QYNuciKQ+w7re+Sj0pVksfRTSn9QfNRbqFRiKwHleE5rBcsFE6XJwQ50eJI3QSP15kLD3c3Yg5s0dYHBRw+3TOQr2fvv7GiXoNvGv3Pla/5tM62SdvnINNJqxdFhjM6slTxT1DzNASx7aABRWgK9X+K1Z0aDKmIlAcYAGCsqL1UmUD3ruGO/m/ERNQgXgdegAvUFe4l3ENPi7aW38rxV7+Sch6KAIbu1Ss1zGh18KxGr0sv9GgZG19Iv21uKOtzLmST/76KTJy1iBOBPLUfNVob+TKxeXE9DwiCWoMdjpiYjzEwU3O9O6DE+wAVlsLNovPx+uuhcYfLVbM7Modkj1i8DvwGRyN/E+aU/2pnH0HnZ52K5S/HxAfg5Co1u4CbQcA9KNtolIK1k+cT1YuMFafp0o6EOwU1KMe9lSgTXls1nxcsQmGzIpQQNrv0mkfnEUaWAB15wpxVbDhNn/8VZ2kw2+TNNEQqH1g7wV+edNjjNGvYxk+zPkl4qFqsMgG3NiN6tStlRuYVc2OArqs87ZcWSdPvqJ3IhCfSnyXCoJ1t8+px9lerihpRsyedLte2ce8RNPPz7ivJgSDP2Da6RYPUT9y21yE1Kxov6lS0GgBX6SivA7Q/Tst6l6CKOZICVdK6foif/A1putPnLzQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(52116005)(1800799015)(7416005)(366007)(921011)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OVE1NWNCZnMzTUJYZlV6bHpieVY1NnV0RjBzUjlqcVdSdVNNcEdHZ090Um1T?= =?utf-8?B?MTdXb2YrRlI4UWhOZUFCblJjK2lSSStUaHplWjBwbWZtZU5wVXRXSkJlNkV2?= =?utf-8?B?TjRPNkNCRWFQNVRhNGQzOFVudC9OVG5IcnpwdWQvdm8vUkFjSllKTnZISTlV?= =?utf-8?B?dXB3MlVCRzdTdEoxbmtjWWpvYll6TitjaXBFdjdublk3UnhjL1ErazJiVS80?= =?utf-8?B?OGFncmwzdElPcWF1T24rVVJLQzViL0xzV2xNM0FHajdjdldIUXl0RE1QR1d5?= =?utf-8?B?dG1Xc3duS3BYUHh3cEZCZ25JbzJlWGxjd0Jxd2liNU1DWDVsNVpUZE43bk13?= =?utf-8?B?WHFLRGZ0ZHVEbWNwdjNYalg2aGZKNGxGL2wxQ2UrajllWEFCcmgwcmc4N0dM?= =?utf-8?B?Z1o0MmJHb2FsZU5waXBOU2dOa1lRVXpiVm8xMDBUWnRLMlpHMEJiOUw2ZEUw?= =?utf-8?B?N1pveEo5UWNqUEc1c083UVpyMW84YXJnY1Y3L3Y3WnczcTN2QzYwNjdSNitB?= =?utf-8?B?RGRUZmZVcnRKTkw2MDFzVW1ndUo0eWVHdjlUb2QzRWlnL1YvTTM2bkUwb2Vj?= =?utf-8?B?Rld2YitZN2NUcDBsRE5nUmQ2UWIvMXZyU05hQkw3b2NNZGNnUTlVSkxFYWJ0?= =?utf-8?B?K3pwWnVqMk9IeCtHVGZyWDRlc2NKUTJvdE5pZzEzTjgrZm9BOVJNaldENkZI?= =?utf-8?B?cW0xcXVMSmV3c3hvdklXTzZBOTAyLzgyeUxvVjBudG51UFl2RFdldW5vQWto?= =?utf-8?B?cE9abW0zSHlWcmxIM3Bhblg3VkxIYkV6NWh0VUtnWDdrZVFuWWM1dENYdGp5?= =?utf-8?B?dG9weXc2dnZvTTdjM1JqYjdrenlCeXFHS1JMaS9FalJLMTFiMGxMSmVhY0oy?= =?utf-8?B?TSs2ZWhMZTdPeVk0bEVicDBaQ2ZoQmFzbUY4aW5oWFBGUlJPMFRHSEhpNEtB?= =?utf-8?B?L2I5TDRSd1pFYjhDd0hXMDlKWWUvR0RURXZhQ2RWWTZUbmhJNHg5ek5HMG5W?= =?utf-8?B?Z09nTHR3K3BwOEhJYU1vU0YxdHNIRDRXenFhSXlSamlNNlVnTzVmeG1aTXY5?= =?utf-8?B?SS9DRTF0UWFPMGI5ZXAyQlRoVDA5M29WZ0tISkpiSkVjM3Vkdk9OUXdJOUJa?= =?utf-8?B?RE1oWDhCZWJCOVdjNXpHWmpNNTNZL1FPZWpIaS9BcmpmN01adVRvNGhsaEJ4?= =?utf-8?B?Wlo1SGpibDhteC9PQU8rZVJsV1FqbEFRNkkyRFFxTjFWUXpGRk5yMlM0NXFx?= =?utf-8?B?UjdJdUpiYS9NQmwvRmE5QTNWbzkvTUNTZ2ZoaVI5UVNsVFBTVVlTSi9ZYWFu?= =?utf-8?B?NmNRS1pnMmdoSDZ4ZmVpcEp0ZlVlZW41ZzgwNDJ5T3FCZS9GMXg5SnV3S1JY?= =?utf-8?B?YVVjcVphUkoxRFJHai8zMEJlaU5sSVhiWjh1blFZQkEramFwcTNWNUd2d3JU?= =?utf-8?B?OWRtMGErUG1WeDllb083OEZjdGZCeVc5RXYwTlNSOVRRVDdxK3N5WThSUW53?= =?utf-8?B?WlhkUGNZZXNUcG1iKzhrbVhXN1Q0cnRUQ2NFN00zeW8yUzR1eW41ODk1b3cy?= =?utf-8?B?ME56d0srQ0dPRU1haVVmN3ZyTnpWZllBejU0WWRuLy8yR0FRNkVSeWJnYVNr?= =?utf-8?B?cE5IS0hDcGRzeXEwVXE0RDIvcnp2QklFWklPb2N1R1RyaG1jOEpxblVDZFJB?= =?utf-8?B?d0syOGZoVXdwY3ZXd0dMR25pQzlrMUZWYnRXdDFiYlNOZy94S1RVbDJ3alpi?= =?utf-8?B?QjMrc1NXaGpnbC8wTSszU0ZtNjhaLzQ3ZVhOdllibUdEdFNZdk9HRTk1bHBO?= =?utf-8?B?WTdDbXp6VTBJN3VHTFpWYkhWWkVPTE1jaEhxbFZSbTJVaFZyZUplRVUxTi9r?= =?utf-8?B?c2pEd3YyQXA4QkdrTUJaUzREQUZmeWZEM0NJQXByejVTRHhFV1AzalZFSUtK?= =?utf-8?B?OGUxa3c4QUJuMTlucXg4N09NZFA4NVdhYmJYazk0dnFROXlDR1VtU2FrWGxN?= =?utf-8?B?YmtjaUJrRm9TQ21DS2tkeXg4QXBOblB3WjlFTy9PMWtVL2lWYjh3SHEybWVJ?= =?utf-8?B?MUV6OWtnSUoxWmlPYlJ5UTlaMVdKdHp6K2wwN2pMbjhHVDNpWDU5OVc3eEM5?= =?utf-8?Q?LxXE=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8779785-9b18-4049-331c-08dc529ab302 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 22:25:56.2297 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bb60hX+l6TU5Ok/39CUa+2ZiRGVNaHdRGjdozkr8NWzivTMQYzQlbgfLmTtXi71mCC+BjmZfwgxhExyH4cKDzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9976 adc0_lpcg: clock-controller@5ac80000 { ... Col1 Col2 clocks =3D <&clk IMX_SC_R_ADC_0 IMX_SC_PM_CLK_PER>, // 0 0 <&dma_ipg_clk>; // 1 4 clock-indices =3D , ; }; Col1: index, which exited dts try to get. Col2: actual index in lpcg driver. adc0: adc@5a880000 { clocks =3D <&adc0_lpcg 0>, <&adc0_lpcg 1>; ^^ ^^ clocks =3D <&adc0_lpcg IMX_LPCG_CLK_0>, <&adc0_lpcg IMX_LPCG_CLK_4>; Arg0 is divided by 4 in lpcg driver. So adc get IMX_SC_PM_CLK_PER by <&adc0_lpcg 0>, <&adc0_lpcg 1>. Although function can work, code logic is wrong. Fix it by using correct indices. Cc: stable@vger.kernel.org Fixes: 1db044b25d2e ("arm64: dts: imx8dxl: add adc0 support") Signed-off-by: Frank Li --- arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/bo= ot/dts/freescale/imx8-ss-dma.dtsi index d4637037ba1b6..77ba2dd6847b4 100644 --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi @@ -377,8 +377,8 @@ adc0: adc@5a880000 { reg =3D <0x5a880000 0x10000>; interrupts =3D ; interrupt-parent =3D <&gic>; - clocks =3D <&adc0_lpcg 0>, - <&adc0_lpcg 1>; + clocks =3D <&adc0_lpcg IMX_LPCG_CLK_0>, + <&adc0_lpcg IMX_LPCG_CLK_4>; clock-names =3D "per", "ipg"; assigned-clocks =3D <&clk IMX_SC_R_ADC_0 IMX_SC_PM_CLK_PER>; assigned-clock-rates =3D <24000000>; @@ -392,8 +392,8 @@ adc1: adc@5a890000 { reg =3D <0x5a890000 0x10000>; interrupts =3D ; interrupt-parent =3D <&gic>; - clocks =3D <&adc1_lpcg 0>, - <&adc1_lpcg 1>; + clocks =3D <&adc1_lpcg IMX_LPCG_CLK_0>, + <&adc1_lpcg IMX_LPCG_CLK_4>; clock-names =3D "per", "ipg"; assigned-clocks =3D <&clk IMX_SC_R_ADC_1 IMX_SC_PM_CLK_PER>; assigned-clock-rates =3D <24000000>; --=20 2.34.1 From nobody Thu Feb 12 03:00:57 2026 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2090.outbound.protection.outlook.com [40.107.14.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBF3E58AAF; Mon, 1 Apr 2024 22:26:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.14.90 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712010365; cv=fail; b=IiFMC61FX3jm/Yb135l8hEvuwziOFl1JIZFlxRtrgxmxkqEbhRViJMi8Kva7zk4NlGrePg32ltQzelD8QkXiIExsMvoTKeaSg9ZCSoCFUzP5EJx2yoR8bVRgsOrxmYhd0DhNJ5kwzC3/Dp44CEqFTpjkjLqSx5fO9or8gGAnjAY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712010365; c=relaxed/simple; bh=eO6HQ4nQkUGETGGZsuLNurR+PbulGpVNdui39aXhUCA=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=lZtO/AaXvzJvixzWCcPfgT+qYKic0pTNsm4+o48sGzCFu7J4M6IIIreXoVnFcHIfhU5IdN2UW2Uj074EGNEOKX8KSjbl/xULKld38TgKSnEPDYHMrvQcZhRTRHsE96sCmj56Azud6OaMvONot0n/VrKi+VvcMFBJWXyzr6PFhZQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=c91ltZ2L; arc=fail smtp.client-ip=40.107.14.90 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="c91ltZ2L" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=khnd2/zGCiPNDa8VcDCnz7a2ToWFc9ucxi2CWYCnnhwoEgzs4woskilkyc2s7uQ1wS5C+90ZvePVi7Qi9kPvgn0uPnxIZrCyHOxd/Yddn08ZTGBZULNZd79/ZMTi1R+SUWZ8kdxwhVIOjuN7O+uqV8z4E9eSEKfNZZKYlBh8N2K0dAfvQCVt81dxEBSsIq/A1EpiqqO57wmiEFrO67EH5f4LOC0Ps5UpuVokHIH4mDSko/36RkoR9apOnjBWBDgshXmcYQbsaNC3oTvTmXwQVAVpPPcEeN4dPbZcpfv6slCQ2aV32PgdbpPBZD4ylU5i+WBpX2EXEd5eoiaGGbwMxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KbfiNiMfF5H3qFP3XuQFZABx3PHhYvzTsVrISPYMpMM=; b=AnYaNDXnx13oi7819Po3FXGIDRE5No/Afnc0JBeHN8/GjPGBLasxkHbxwBMWw2xWOjRfOldIEb15wVVuH+qWXMCTYyhQ38LgL4nk2+pa8Hs2wLTm3ceXEq9K6nS54TSmj3V2vKBdxJYxfo2/vvB991fjAo4hbd+AwCAlK6UCcgV7LDOqzf5imbV6we3lR0KQi3E3T8wLLlHN76q4piyDJhlZs/oTdq8thyi2AQmAzQ9GS6Wk3FUP+rNz63vn9E4FSTMhEfT8zHV04gDBVOZBCPtQss8cUEuJIlp/IiYkoT5O2QeAdwdXhhSmQXnYj1rJRFDcOM8blGbNqzLVdwLz+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KbfiNiMfF5H3qFP3XuQFZABx3PHhYvzTsVrISPYMpMM=; b=c91ltZ2LI01blfZVkZqNrlcH9COHXAR+oL0d7KGTf2JX0I4UsV2PCaqsyKYG5F+SDbuoRo+IDxpkT8D3EZQEGJgyMoJ1Y+ZI3hfjqZ8Kek7Qll0yX1gJIfDJ0KCgvywXKIkjLYFEMOL5bFDvzvnVeCdQhJr1gAeJ9lHwUfDDo/M= Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by GVXPR04MB9976.eurprd04.prod.outlook.com (2603:10a6:150:117::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Mon, 1 Apr 2024 22:26:00 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6%3]) with mapi id 15.20.7409.042; Mon, 1 Apr 2024 22:26:00 +0000 From: Frank Li Date: Mon, 01 Apr 2024 18:25:08 -0400 Subject: [PATCH 6/7] arm64: dts: imx8-ss-dma: fix can lpcg indices Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240401-dts_fix-v1-6-8c51ce52d411@nxp.com> References: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> In-Reply-To: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Marcel Ziswiler , Philippe Schenker , Max Krummenacher , Alexander Stein , Joakim Zhang Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li , stable@vger.kernel.org X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1712010330; l=2525; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=eO6HQ4nQkUGETGGZsuLNurR+PbulGpVNdui39aXhUCA=; b=zq02e6hO7o7sOd+iifS90EBTE0PozjY776Qcwp0fDEJE0JG5wcKtl6yJHY6rfVcBwVJA2mQj2 xpAjUTUNd3mBDyCoLoZMMSUc1zK7SLTXxFvmK25fJQtC04PM9miL4bN X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR05CA0011.namprd05.prod.outlook.com (2603:10b6:a03:33b::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|GVXPR04MB9976:EE_ X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dL9FGh+/dH6crvq1A5b/sxHvZFwQjNGqwsMJgtYM91jMV5oO6G024UHzE/WYm9RZ7tQHykH4Ig6N7xgEHUtidPoHlqtSr19JivppzcqzATD7cy4MxrPTC9q+F3OSO68HWsXHH0Q57S6Ryf+91mTxtDuL3aqJHD2WE22z2HmPWTuSoSWnWTUiQXoPSQdt1lBXTE7kRXYEEkRBfwYAt0xb6WfAgEeSpU1c63jRCyNqvVYkrokugVlmFV8z5QhOcoSTxp6ApeOkZN7r8tQh4y/9rAxY4+vne3tfbHwkNjZV5fT4RvI2DuB5GOyFI/qunx1EOGzuq+OsqQhOLseIJRKYAeaTarcOZVukAtkcaUhJnyzD5UvmUMKOJ7yZ9T4ktVvizgI4PBG+CHuBcGE7JYFWoXKUYJ/pi6aUPOzqNrSwmshU5+Vvic7cm/ASsXOPGzw6M9pg6ebHWZ/epsI1qz0fbZKRuvU5Su2rTfE9hThPP0czdWkaKJG/ChhtH6qYWj19mPlQeWkE7gu5VBG6tqU5XXror7cRelsqeMbCEWkvlv0XjFkIt7bZQkIT9cGLO96vRGKLHX6yJOVrJd/8dYh3hkLmNDJb3A4KXxvM5iM3Bv7x+Rhy20hmRuqoeDFh5Wno+C6E/XhN+E3f1T6H/jbHDmuJKcihT5B+BHao2+YUHBFKYXukUTJjnDkGnfR2RLgVM9VHWO4vPOdfd+4rlWAVN4lN6B5rXdHw5KQ0eJCDL3A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(52116005)(1800799015)(7416005)(366007)(921011)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VkZDL212TlM0S3EvTkpENkY4Tzh2S1pvb1p2Q0FNUGFSdzJaLzB1SDM1ek0r?= =?utf-8?B?Q0hLWU9QVkx5ODB6Y2dYaVp5UXc5UXFEVHMrU0lZbWZqdkwrMEoxUnh5Z2ZP?= =?utf-8?B?Vk5CVU9oc3RWNXZtY3diQjZKZkJVbWlyUFgwN1JmUjBDRTg0Q2RhaUxTc295?= =?utf-8?B?TlhMdXp6cjJ5TUcvdnhCbjVaVE80eVVBeTBrMWVYYzZ6QlRSV2xNVW5CQXhL?= =?utf-8?B?Z3JDbDVwK1g3WlpkMy9XS3BmRlNKdy9LdUZGbmdiSHR5c3dQblRvOTNTa1Vh?= =?utf-8?B?ak5YNkMyUlQrbFBMWjJBSThsRUNrR0hVUnBEVmJxMklsN1NqS1RrbUZxZHRy?= =?utf-8?B?WllmaFBqNnM0TGROTmFaakNnVEJCT3ZYRndkakFSSFZYQWFWUTErNFA5WDkr?= =?utf-8?B?NnZKeHV1VHNQRXFiZURuZzgvQTlpdzZOZVQ4aE1NYWJRQkIyYlpwYk5YeWFz?= =?utf-8?B?ZFVDczJLQjkzVER4OTM1U3hGaWFjZEladzVFM0dRWW5remg4UEVFNDVMZHFW?= =?utf-8?B?dmlhOU9iaEk3RnljNGxnMUdFZlYwbnhhTmpySmZ4b2lIamJBcEE0TnAvZkU2?= =?utf-8?B?ZnErQ1ZTN3U1T25WN25LZVZKY3E2ckV5bnRFRUQyaWlwUWRnR1BVem9YbmFl?= =?utf-8?B?UHY5YjlzalhaWmEyTk01VHhZT3NyYkNMNExXdDA0RFQ3WmhtejVPa3dUZ2hy?= =?utf-8?B?YjlMa1NVTWdsd0dha29EMEZIQVZSL1o1ODYwbXBCQXRDVUJFYWloeUs2NnZk?= =?utf-8?B?bVNhakw0d0JEVGJUZXdrckRXMkJkbGRZbGRsQk1JNDF2ck40WEw1Rzl3azlm?= =?utf-8?B?eHNuMGZtVjcxaEV3QVJvRnFicDRNUTNSQWV5Q0U4ZmZ1SmZEWmF4OUFhZEt1?= =?utf-8?B?TlN4L0M4ZFFLR04yQnhHN2pkMHNrc0JzbFJxeDhtQk5jczVLZER4MzlMblNO?= =?utf-8?B?ZXBzY3pLMnE3cDBqbDlQRVg0N1Z1bFpac0ZITlVWclNySlp0NXhubDJ6WlFB?= =?utf-8?B?bWJvU3crK1AvaUhMMnFFbWtYNEg4UGFxYUtSUVdVNDc2REpWSUpWbktNMGR0?= =?utf-8?B?R2N0dWorYzdXcFIwSi9LRlZHR2hDZUxGN1p2UjAxY2dMYUFrS04yaFplUXF3?= =?utf-8?B?WE1tb2VzRURJNGw3MDdTT0Vid0lHTWNUSGlLbW1rWEd5Y2JzMGN2REducHJ0?= =?utf-8?B?aTVTdXdPOEg5K3A2WmFkT2JjSG1RSUlFNVA5K05pNzRqOUpQR0YxUUZ2Qkdl?= =?utf-8?B?WXpBczgrS3p0YjdwRzVVTVprbXdtQ2pmbzUzK3lweWU1TW5nNHZmcWp4dHRk?= =?utf-8?B?VW5MZGdjK01SM2lLaWVwT3F6akFka29sanNQSEg0UkVqY0wraEU4OFVGM1I0?= =?utf-8?B?QUNKMzFuSkordlZhNVQvT0RWNzRlYjF6eitDdUJvNkVqU0NyRFRZY2Rlem5n?= =?utf-8?B?Z09kYnZWUGdsOHBNQlBuTXJkbUo1K2tTMEd2L1lneG92MWFjSnhRMGI4aUxl?= =?utf-8?B?UFo2WnNJRVRPR1IvUWFuQVVySWhOcXVsZ3ZFRkRLUXQ4czBaQUVTN25DR3VS?= =?utf-8?B?VlV2cHhuVTBpcGdINFdHNVl3U2FxTUN5d2Z5MTBRbGs2VHZFcDBCN0hhTFBx?= =?utf-8?B?OGRTRStkcCtyT2k3eDl5MHhFd3p3Qmw0bStSR0VDczBpZDB6YmZ6MlFzR0Rq?= =?utf-8?B?c3NXQTBYUzBRcGxOVTdQTnJFQzJNOHpuWmtNSWtueFRRWFpmTVM1b2s5REJh?= =?utf-8?B?cG9pQVUxSGYyRU9DMmJlNCtuN0N3VmUrNFd4Z0dDandKbld0RVlGSEtONzF4?= =?utf-8?B?eGJld09WeWh3QkEvUllTU09pVVZqb09ubktROEJ6NkZlaGxPWkkxSSthSFZp?= =?utf-8?B?K1Vwd0IrWEJNK25kWGJEeVdwZHBxTTdrcmlBRitHSFVJVkJMc3FWb2ZjUmN0?= =?utf-8?B?VFpQVmw4dHlHaTY4WW5LS3R4WkxueWxIL3VtTlRIa0tLaG01M0JDL1RVQnNo?= =?utf-8?B?N2JoTXRFbHVNNUw5eXdicWhqMWtWOG0vS080aVNxZXRtRkVQUHVJMXR6NGxR?= =?utf-8?B?allaVGpGOUo4T0tpZDRqSWJESS9XZU5Da2RKSXpaZFFRNmtrQ0dCQ0hubjV1?= =?utf-8?Q?wU1g=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e20618cd-2734-4a38-cd40-08dc529ab585 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 22:26:00.4359 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YTCo1qOAsCofITJigvj+FC1Q5LGTcbLBcYqDG83GO5/8ZSPfDvQKMguB/lp7c/MLYah20aismRIShL+zxxdM4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9976 can0_lpcg: clock-controller@5acd0000 { ... Col1 Col2 clocks =3D <&clk IMX_SC_R_CAN_0 IMX_SC_PM_CLK_PER>, // 0 0 <&dma_ipg_clk>, // 1 4 <&dma_ipg_clk>; // 2 5 clock-indices =3D , , ; } Col1: index, which exited dts try to get. Col2: actual index in lpcg driver. flexcan1: can@5a8d0000 { clocks =3D <&can0_lpcg 1>, <&can0_lpcg 0>; ^^ ^^ Should be: clocks =3D <&can0_lpcg IMX_LPCG_CLK_4>, <&can0_lpcg IMX_LPCG_CLK_0>; }; Arg0 is divided by 4 in lpcg driver. flexcan driver get IMX_SC_PM_CLK_PER by <&can0_lpcg 1> and <&can0_lpcg 0>. Although function can work, code logic is wrong. Fix it by using correct clock indices. Cc: stable@vger.kernel.org Fixes: 5e7d5b023e03 ("arm64: dts: imx8qxp: add flexcan in adma") Signed-off-by: Frank Li --- arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/bo= ot/dts/freescale/imx8-ss-dma.dtsi index 77ba2dd6847b4..67b3c7573233a 100644 --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi @@ -406,8 +406,8 @@ flexcan1: can@5a8d0000 { reg =3D <0x5a8d0000 0x10000>; interrupts =3D ; interrupt-parent =3D <&gic>; - clocks =3D <&can0_lpcg 1>, - <&can0_lpcg 0>; + clocks =3D <&can0_lpcg IMX_LPCG_CLK_4>, + <&can0_lpcg IMX_LPCG_CLK_0>; clock-names =3D "ipg", "per"; assigned-clocks =3D <&clk IMX_SC_R_CAN_0 IMX_SC_PM_CLK_PER>; assigned-clock-rates =3D <40000000>; @@ -427,8 +427,8 @@ flexcan2: can@5a8e0000 { * CAN1 shares CAN0's clock and to enable CAN0's clock it * has to be powered on. */ - clocks =3D <&can0_lpcg 1>, - <&can0_lpcg 0>; + clocks =3D <&can0_lpcg IMX_LPCG_CLK_4>, + <&can0_lpcg IMX_LPCG_CLK_0>; clock-names =3D "ipg", "per"; assigned-clocks =3D <&clk IMX_SC_R_CAN_0 IMX_SC_PM_CLK_PER>; assigned-clock-rates =3D <40000000>; @@ -448,8 +448,8 @@ flexcan3: can@5a8f0000 { * CAN2 shares CAN0's clock and to enable CAN0's clock it * has to be powered on. */ - clocks =3D <&can0_lpcg 1>, - <&can0_lpcg 0>; + clocks =3D <&can0_lpcg IMX_LPCG_CLK_4>, + <&can0_lpcg IMX_LPCG_CLK_0>; clock-names =3D "ipg", "per"; assigned-clocks =3D <&clk IMX_SC_R_CAN_0 IMX_SC_PM_CLK_PER>; assigned-clock-rates =3D <40000000>; --=20 2.34.1 From nobody Thu Feb 12 03:00:57 2026 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2114.outbound.protection.outlook.com [40.107.14.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B51D256B8B; Mon, 1 Apr 2024 22:26:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.14.114 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712010369; cv=fail; b=QMskZ8X1Ec+R8Ugi5gk3lhRxEaV491f5dwii6g7ctx42e3SbEec+Bgcp39nSNtluJEPyaUz5o/x1YCbTHrdBYXLMVco6Pz3/ricDSJzofBKaC7HGyY+3OtbjXALg+03MS62GUL9hKyNQLgyucAB9PPAlkGa9vRwEPfT3QF04ei0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712010369; c=relaxed/simple; bh=+Xl/NBxQeZ+jWNsmzYScwfNZfXWDsmCFIP/CHujTKh0=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=O/aojNSLlHKqrLW4mTnQbdl407vYkVs+LeCvlr5mQp0XwC1TaGzHSZPXZjmSz3/kiLdLQMkch9AsCVzvv+4pV+kfw7n9NDYgKxC6ch1kNu+InQ+uLKF5bwbjRj0zQ5hatC2/UPjFF6dp2q/Dr9HDD3TTMwE6Qpga3QZwSmBzg1c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=jyM0q79A; arc=fail smtp.client-ip=40.107.14.114 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="jyM0q79A" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hNCw8eZRs+vOhF7XldOUm+Ez18cQgsbxulVah/kaBrpoBgLMQ0NdfN/dAssw6v8g1lSBKLW+qMxgIcMBznl7ZJ4CFtfSKRZ4hhforSGGC/orPi2H2HkBHfL/DTKmNFxyrgh8fudwBCNm+qdx95Kiyw38oS77M6Yt/a1egRsPz1eztj8PLUENbljt6mJu5a87HMZkl6lNK0TBI9GKreZaExGIpWWNzF2XNCjU+pmLWlN4JR+3UA7jWsSwrZ7rcckVh8dXQgTdzLf27ONxRknTN3PFvCCNqQp56+5cVNbtBdvbiq5HCcs4XAa3ue5G/oZy7qpqrpChPZCtIuSMG21uXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4iBT8217c0X3M9h9xFyhs2PbHWFfGpPCyfNWe94VNDA=; b=jwXciYrLVi9VE3Qj62aKTMIfvHLO7XrNqEu2qNTMPpuGIEyQ2gHerrR+4V/GaDr0HEDbSovhkOLefjgi64EDfYHlfoIteKvtLdB+XYhL1U78INOfY1sWKEj1mHYDngB3jMBbXEstGvdKGB7kotjJdEtlfdDUobhOUlNEaQ8eq62NQMdcsDTnnYYlnQMvUr/COqtxYLp8U3prWhD+xSIh0bGIpQi2EJjppjjvjTu1hjGDnX0jkERtMxl6ZCJLt1xWP88VqF7pq5TpE0rSrsGnrDeUy6IWI8fk31nmhfTO8Y1JDF8ylgjHWmCfDLOXGfg+6ODq4q1MK2YOSD/+9W7zEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4iBT8217c0X3M9h9xFyhs2PbHWFfGpPCyfNWe94VNDA=; b=jyM0q79AKd2hJS9BPqss3/Ymr/neZUQfYeQ8Up0Y91lGy/hiewwAE2dW+LEpOXbUAxJ5COfVuquEmJ8c3ZhRNZ/IHWx/L1tZtT8lr5aGWNGHM42quZO+F1gPCqgbjcBczNNYaek/vTRXA7BDeDCP+/4YgLtWoVofNKM/hwF3dSs= Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by GVXPR04MB9976.eurprd04.prod.outlook.com (2603:10a6:150:117::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Mon, 1 Apr 2024 22:26:04 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6%3]) with mapi id 15.20.7409.042; Mon, 1 Apr 2024 22:26:04 +0000 From: Frank Li Date: Mon, 01 Apr 2024 18:25:09 -0400 Subject: [PATCH 7/7] arm64: dts: imx8qm-ss-dma: fix can lpcg indices Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240401-dts_fix-v1-7-8c51ce52d411@nxp.com> References: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> In-Reply-To: <20240401-dts_fix-v1-0-8c51ce52d411@nxp.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Marcel Ziswiler , Philippe Schenker , Max Krummenacher , Alexander Stein , Joakim Zhang Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frank Li , stable@vger.kernel.org X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1712010330; l=1806; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=+Xl/NBxQeZ+jWNsmzYScwfNZfXWDsmCFIP/CHujTKh0=; b=jrIm5jsGkc0UB3hDjH5SJrKt3ZkK3KaUPw0E8aTe75F36K2+JuUiRFlOJQFNHfseu1aQxp+3V S7cMTAFNQSeA4viqwky/LgPwXC0ky+eSTW3p1aqlcTqXKyb74pJW+E0 X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR05CA0011.namprd05.prod.outlook.com (2603:10b6:a03:33b::16) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|GVXPR04MB9976:EE_ X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VLE83ChOaVZNM4zd7moPMCF2IsFqRRgSiZDRfvJpx0+yKTCv5rA35O0wz34haNXM28edcooyVOPd8+fhMzkOogrqVYO1tr/KdscZAgdUXh7LIvIaQNCugI4sg61W7h8XHKP4dwOcrN9OQphtJ1cG49H+zSpoq8VCIZBfyMnwaPtJUem6txrC8J/7Efvll/96JuQF8iYSJyl0VJ89nL7YlZ2iW+8mXXd171PRwabTgpiQQbX/6l6GvykSnyP7hTLBK02R0QL9twDMemJxiv7R2JvgEi2l8pAZN5BeOtDqllyRRCCVU1HarELwkwlZc25H+fqHBnfklhWDHIAh9AGAD0f2BkkEeoeQuP4ykmcwvWnSF3//Jnt9tCzoXFqlMdR+sUSXJfaWIGdKvAFIopnSA54U5FV0Rqu6GFnA1u1PgPfroOi5luwtdGVqAjCOBasBmm1oTPMCvEKHoGJTtJEvPXLBiW+xeA/HLl4ZYO+SgEwjhvTi0UhAV2yMAE89cjIKfo1Kbmplctrqpehlo7ySKzwEoRVY9UM+OKUjYnmsfF34SlIQJAUnFKPUrJBRrHG3AuUbdg2ayuuIN83p50EwBdjt2gtQo2BhjT9XObfK37UBaDypw/BGExInJ4XE1vzwRFjOI5SfQKT8d5do8u7HAWUWydcp1N1lQEJmCPvPoo2KtK7EUMd7Sn79MhiEmk6s1zXibHPgiM8CHay3cya9OkrS9wLpZ2+wz/F8lRhYw0o= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(52116005)(1800799015)(7416005)(366007)(921011)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VzBPczNVRE5CQkFZZzdSOHpGN3dWaWVwdzkrd0VjajBZRGp6c244SXVveUVh?= =?utf-8?B?andLUzNqbkg1RkoxK1VKR3h1c09ZT1NwNkJpdGM2Z3R1bk9TQlFmOVo0SFhY?= =?utf-8?B?WG9Ea0M2bXdQdXg0UXVzVU1XQTloaUNGbGZxT3cvRDY1VVhzK1FvRE5EUmdX?= =?utf-8?B?SWprRnVMTitmZTVNV3l1elE1aGRKSFVpNkdFMUMwdTFTUzMyb3c0U2gwbEtS?= =?utf-8?B?c1FaVldzUE1uVG5VL2NCWmtLUHdBRGdUQ1NrUnRXeVFVS2E3aHQwdXNBSnRr?= =?utf-8?B?TmxybytNVEFSYmdnSS85NUowRGp5YWIzTkFPVHBKOG8vK2R1cStlMitXcVFo?= =?utf-8?B?Wm9oek9VOHU4SG56M1lJclQ4NU1MSFVlcy9ZU1JmbFMxQ2M1V2lKLzJZQkRL?= =?utf-8?B?UlU2UGxYVlVKTk9VRUo2Rm5ZcUpOYTFtdlFOb0svZ0xtd2FabzBwN3N5OXVs?= =?utf-8?B?MWRQVmVmektnMExUUi96dy9JemEzdE04K2h1dG9oWG4xZXNvV2xLVkVyZ1Ix?= =?utf-8?B?VlptNVdYelE3THVnVExuUWZwOXVtcWZxdk1YWllEclAxczk0WS9KNHU0SXB5?= =?utf-8?B?RUZmMmpGR0IrUWdldmhBcmNuSVJvemdnNDJJUDdqM0Nla0h3amJzRHhSZUhw?= =?utf-8?B?Umd2eDZEMXI0MWlOWDIxUjFFRFhFNjhEV1NWbkZ2VkoyeXI2MG1HaGhrUWtj?= =?utf-8?B?dGdnQVlFQzh5dEJzVTNmUUxxR05VSGlMZ1R6WXpsZHNvVU96SnBjYUVKcUpF?= =?utf-8?B?NVlrdDRTYTNmZC9qQjhhVWVxTjFydThpYnVkdVpReGZPazBQaXhyZVRGbVkv?= =?utf-8?B?U3Z6RHdRTk0zSER4YkZpb0x5Nys0U1FtLyt3enVpZFlZSXNDTjNxUHYxVnQw?= =?utf-8?B?TUV3d2t4eHN5TFlrNXJ3WnF1S29hOGcwUXRSSWtqd2d5VU9WZTFvNHgydi9W?= =?utf-8?B?K3NXL01sMnFLeGJOVXNqbnhENGU5cytRUTRWOUFpZmJnZWt2MjVYbE8vZGp1?= =?utf-8?B?cXdEOURzZFR6SlFhNU83c1F0VUdWV043UUx3Wnc5dkJ6N0FpejJvc21GOXJE?= =?utf-8?B?QitpUFA1UzQ0c1AvZnFSeCs2VDdzLzN1d2FaNlpnWWdpRkhCcEVTVHAxR0Vw?= =?utf-8?B?ZjA5T3RiMEZqNUwvTEZpWERuRUFSd0g4d29QRW4yWHpPRFFmZXVSRjM1UmxZ?= =?utf-8?B?WHNvVjhNeTJmNzd0NGMrYTF4enFxZENiMHVRbHhyWjVZZU5mcEdrWmlKL0xl?= =?utf-8?B?bGlDUjZPYTFNWElBdGxlSkZ3Mm9hMzJ0QzJLbDFjS1VVeW55VVdkb2ZyQlBH?= =?utf-8?B?ZkZCUUlxakNyR3N0T2RlYTNtdThhUUZUN0RlWnpIMVkwczYzSk82SFRra25S?= =?utf-8?B?VWJnWTZrRjc0dHJjcTg4WC9BblBkOUFESnVjcXJtZmpRblE5djF0NU8vNnlY?= =?utf-8?B?QVczdUxjS3lsYXNMSm1yaXVLMklVeVJPTTZCbG5ZYTFqZ044Tys1N1V4QVkr?= =?utf-8?B?ZDNzVVRwOXVpOUQ2NVZCRUhWdXhwVmFYMXZVNjlRNTdLaDJDaFJncWRyT2o3?= =?utf-8?B?S0RpUEUxcFdGK3RRbkhQRFZUdzRsZmQvMUdSVE93STZjUDAwdyt3ZXlwL1ov?= =?utf-8?B?MURtcEx5L3NKdWJhV3ZKdDBONWNRb0o0RFE1THRrV0tLeGYreVQxU050Nk0x?= =?utf-8?B?S2oxajFiZkZ3THB0aDU5a1lZaE8xVmFmVmVaUjEzZGhhUldQNzFEV1pGMGRB?= =?utf-8?B?dE01ME1KZXY0MzFzODloaGx6bCtvRXZoU2IzcjMzY2JzaHZYVnJjMERzd0Rt?= =?utf-8?B?VjJ4RlgxWEgwYkkxa0psT3pscVdxZjlMdWE2Wm5BNS9xZGRBOG1Fd29hMmlO?= =?utf-8?B?aG1lenRFTDVVZDJ4ZzR3bjhRWnhtKzl6SVFSVk1UYkx1RWx1aklVOFgyK0Fj?= =?utf-8?B?UDNhYWhjMS8yQWJFVlhyVFk1M1RwZG51KzdxOFJ0d1JVbTludE5UNkJZQUdx?= =?utf-8?B?TjN1UmZOM3g5OEFIeVlHdlh2bklDWFdndTZSbWtTbXZnVWJVZFlsOVBpamda?= =?utf-8?B?MXIrVlNhdkNwVEMxWkowdnNUNy91WjNVVm8wUUxUNCt4RDF0UHZoZWx5VExF?= =?utf-8?Q?gRNg=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 629f2247-8373-4336-4f63-08dc529ab80b X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2024 22:26:04.6719 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4tTfeiYsc3EM64dZdMXgZiT2Fv0pVYGCqRIplyq27Z8FoSjZlB52uA0T5X7X1dnx//W34a+bz0IeXHcBKj4kdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9976 can1_lpcg: clock-controller@5ace0000 { ... Col1 Col2 clocks =3D <&clk IMX_SC_R_CAN_1 IMX_SC_PM_CLK_PER>,// 0 0 <&dma_ipg_clk>, // 1 4 <&dma_ipg_clk>; // 2 5 clock-indices =3D , , ; }; Col1: index, which exited dts try to get. Col2: actual index in lpcg driver &flexcan2 { clocks =3D <&can1_lpcg 1>, <&can1_lpcg 0>; ^^ ^^ Should be: clocks =3D <&can1_lpcg IMX_LPCG_CLK_4>, <&can1_lpcg IMX_LPCG_CLK_0>; }; Arg0 is divided by 4 in lpcg driver. So flexcan get IMX_SC_PM_CLK_PER by <&can1_lpcg 1> and <&can1_lpcg 0>. Although function work, code logic is wrong. Fix it by using correct clock indices. Cc: stable@vger.kernel.org Fixes: be85831de020 ("arm64: dts: imx8qm: add can node in devicetree") Signed-off-by: Frank Li --- arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi b/arch/arm64/= boot/dts/freescale/imx8qm-ss-dma.dtsi index 69cb8676732ea..475702947afff 100644 --- a/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi @@ -112,15 +112,15 @@ &flexcan1 { }; =20 &flexcan2 { - clocks =3D <&can1_lpcg 1>, - <&can1_lpcg 0>; + clocks =3D <&can1_lpcg IMX_LPCG_CLK_4>, + <&can1_lpcg IMX_LPCG_CLK_0>; assigned-clocks =3D <&clk IMX_SC_R_CAN_1 IMX_SC_PM_CLK_PER>; fsl,clk-source =3D /bits/ 8 <1>; }; =20 &flexcan3 { - clocks =3D <&can2_lpcg 1>, - <&can2_lpcg 0>; + clocks =3D <&can2_lpcg IMX_LPCG_CLK_4>, + <&can2_lpcg IMX_LPCG_CLK_0>; assigned-clocks =3D <&clk IMX_SC_R_CAN_2 IMX_SC_PM_CLK_PER>; fsl,clk-source =3D /bits/ 8 <1>; }; --=20 2.34.1