From nobody Mon Feb 9 16:34:45 2026 Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 251B110E3 for ; Sun, 31 Mar 2024 03:01:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.166.238 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711854078; cv=none; b=ZUwSh5gDYM1iCDjy/3YCTp11WB92ck5M57IeFGhZW1Wp9DtHwmUzF0nwDS9a+UjWeiMxaj8ued+UHrgl9oLUyr0Sfps7IVy4umtce8QL8a+QOcLx+bccOJWoKdLlijbxLU4qkvquidlB4NsPTbYod8h28iLVW5F2yzuO/1PqUr0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711854078; c=relaxed/simple; bh=KhXvF+KAdr/td4fs1u9s6Yt+uWESzDKG4g2Pe6ecijE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=R5+yhEaNh8ADLcHXuwnv1NVNwS3V0x/gZg9T4iu5aHAMWRpr7qlgPXpPbpwePQvX4xgA658BJ45/FHQKdl/lt4A0MURVQHyGhS+VXn3snf0agUH1FPU5xYb3IP64SBRZR37tjiz7NUvfnJAExN3uoSd/iFt5H9PguCW22cyO6l8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com; spf=pass smtp.mailfrom=windriver.com; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b=gwfOb1zE; arc=none smtp.client-ip=205.220.166.238 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=windriver.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b="gwfOb1zE" Received: from pps.filterd (m0250810.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 42V2ErU9022442; Sat, 30 Mar 2024 19:19:49 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= PPS06212021; bh=WVlSUo49HtpAFry+bBylUU9Uqkodhn8z8Pc9shjqA/4=; b= gwfOb1zEbPwsYph/XKE+HxCVPc6biFJuwXO1NJvv0XW4Xaqz2qxqJJ8qLhKeySL1 k/g+bwYNXBqO2UsKzK/vOlEh1X747O3Cw791Yq9EUB5FK3cyqvc/3waZ3ekQTLGL 2zxR29OuCmU2SGnwr7Z7JtlE1510xuRh2mlLKfCe1i4RGhSX0E866vwn0/h012ue UoBMqQW+OrdKI5eAv4MGcE8Cdfe/pZ2WdP5Mk6DB/IIFC+26LeM0SdK+zkO6ogSk fSo2DlV7aNyUxPN9YBwL1k7aoF5tMa1cytc7fhrJRJT1G3LFpyAHPko7Ze4HxaYz QtzIDYpXGkTfiPQEGFVr3g== Received: from ala-exchng01.corp.ad.wrs.com (ala-exchng01.wrs.com [147.11.82.252]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 3x6e10gm3s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Sat, 30 Mar 2024 19:19:49 -0700 (PDT) Received: from ala-exchng01.corp.ad.wrs.com (147.11.82.252) by ala-exchng01.corp.ad.wrs.com (147.11.82.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Sat, 30 Mar 2024 19:19:38 -0700 Received: from pek-lpd-ccm5.wrs.com (147.11.1.11) by ala-exchng01.corp.ad.wrs.com (147.11.82.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37 via Frontend Transport; Sat, 30 Mar 2024 19:19:36 -0700 From: To: , , , , , , , <42.hyeyoo@gmail.com> CC: , , Subject: [PATCH 1/4] mm/slub: remove the check of !kmem_cache_has_cpu_partial() Date: Sun, 31 Mar 2024 10:19:23 +0800 Message-ID: <20240331021926.2732572-2-xiongwei.song@windriver.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20240331021926.2732572-1-xiongwei.song@windriver.com> References: <20240331021926.2732572-1-xiongwei.song@windriver.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: 1uqYCL0NLvDL19Ws2dkU89gAZ7AjMDv1 X-Proofpoint-GUID: 1uqYCL0NLvDL19Ws2dkU89gAZ7AjMDv1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-31_01,2024-03-28_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 adultscore=0 clxscore=1015 phishscore=0 priorityscore=1501 suspectscore=0 mlxscore=0 mlxlogscore=999 malwarescore=0 bulkscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2403210001 definitions=main-2403310017 Content-Type: text/plain; charset="utf-8" From: Xiongwei Song The check of !kmem_cache_has_cpu_partial(s) with CONFIG_SLUB_CPU_PARTIAL enabled here is always false. We have known the result by calling kmem_cacke_debug(). Here we can remove it. Signed-off-by: Xiongwei Song --- mm/slub.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 1bb2a93cf7b6..059922044a4f 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2610,8 +2610,7 @@ static struct slab *get_partial_node(struct kmem_cach= e *s, partial_slabs++; } #ifdef CONFIG_SLUB_CPU_PARTIAL - if (!kmem_cache_has_cpu_partial(s) - || partial_slabs > s->cpu_partial_slabs / 2) + if (partial_slabs > s->cpu_partial_slabs / 2) break; #else break; --=20 2.27.0 From nobody Mon Feb 9 16:34:45 2026 Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1680E611B for ; Sun, 31 Mar 2024 03:05:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.166.238 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711854306; cv=none; b=XC6jv7vteRZwCwf2SUWKdqV7Lpzv7dQdrnunih8ChX3uy8GfluruD7ESKa18HbOhT+nfJrc3u3R8j9VR01EjCoosyCvLubuDhpGZ+pqpvFh8iPPffOYyeTgKuxQiMftllOBxB/Kko08k8/srusLLjMFWhwuNfYa1wWkWwRMKGWM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711854306; c=relaxed/simple; bh=fwLFyQuSH1gL8p6WaXgbRYKSM1p4Sx+SaEHfEfPX4XI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=c6vvdGMFi8bbw75kx1vexXCpwgfOdS2F1bWYVZSQ5AqANvqOY/b0JYSJAsjhAuZ9SrlsCFm7M64jTZ226KsIe0z9M4e7Pza1aGFybFmkHzlNis4caMf7f0rX5u/n9I2J1v3ngdbGagcg/u/wCKH1+uzNsnhuu1FgI30ZIz4R/Qo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com; spf=pass smtp.mailfrom=windriver.com; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b=evi5XKC2; arc=none smtp.client-ip=205.220.166.238 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=windriver.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b="evi5XKC2" Received: from pps.filterd (m0250810.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 42V2ErUA022442; Sat, 30 Mar 2024 19:19:49 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= PPS06212021; bh=6dTBj4eAePEk7EZjLkudl8wd/noflYo3XXpEzzrtWEQ=; b= evi5XKC23wD3nJcSTkMWrx+SEmKoxdC2+aHFehlWCsfxi7BG+pEc3+q9cw/brZDR l5t5ys3LgGnS7AjW4EBPojNbp6WbR2zztVQm+nOUzi9D3DtmM+AoC2XXYoW45aYN SD1fWkXiJGi5csyth6AzoWWR0R8SjIOUXouqUSY9TCy54RplOT2noUEPfAsQhl66 JxYYGoCdFS9GsHAfx3j5vhtWdTT16k345tlgQN1aQ2EeFDRQAASJ9Bodm8feRzlB 4igfZd1Ewyz0blMOSyQfhMM0B6+IAHGxpkCw9Eb5fb75wC9mBLrvDk9ThWWb6yBK Dg2oJqVM6YUvJ/ilz2zXow== Received: from ala-exchng01.corp.ad.wrs.com (ala-exchng01.wrs.com [147.11.82.252]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 3x6e10gm3s-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Sat, 30 Mar 2024 19:19:49 -0700 (PDT) Received: from ala-exchng01.corp.ad.wrs.com (147.11.82.252) by ala-exchng01.corp.ad.wrs.com (147.11.82.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Sat, 30 Mar 2024 19:19:41 -0700 Received: from pek-lpd-ccm5.wrs.com (147.11.1.11) by ala-exchng01.corp.ad.wrs.com (147.11.82.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37 via Frontend Transport; Sat, 30 Mar 2024 19:19:39 -0700 From: To: , , , , , , , <42.hyeyoo@gmail.com> CC: , , Subject: [PATCH 2/4] mm/slub: add slub_get_cpu_partial() helper Date: Sun, 31 Mar 2024 10:19:24 +0800 Message-ID: <20240331021926.2732572-3-xiongwei.song@windriver.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20240331021926.2732572-1-xiongwei.song@windriver.com> References: <20240331021926.2732572-1-xiongwei.song@windriver.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: OyBtIUl3wnHYanDd12DLcgj5PDGeGo_z X-Proofpoint-GUID: OyBtIUl3wnHYanDd12DLcgj5PDGeGo_z X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-31_01,2024-03-28_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 adultscore=0 clxscore=1015 phishscore=0 priorityscore=1501 suspectscore=0 mlxscore=0 mlxlogscore=999 malwarescore=0 bulkscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2403210001 definitions=main-2403310017 Content-Type: text/plain; charset="utf-8" From: Xiongwei Song Add slub_get_cpu_partial() and dummy function to help improve get_partial_node(). It can prevent compile error when accessing cpu_partial_slabs with CONFIG_SLUB_CPU_PARTIAL disabled. Signed-off-by: Xiongwei Song --- mm/slub.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/mm/slub.c b/mm/slub.c index 059922044a4f..590cc953895d 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -604,11 +604,21 @@ static void slub_set_cpu_partial(struct kmem_cache *s= , unsigned int nr_objects) nr_slabs =3D DIV_ROUND_UP(nr_objects * 2, oo_objects(s->oo)); s->cpu_partial_slabs =3D nr_slabs; } + +static inline unsigned int slub_get_cpu_partial(struct kmem_cache *s) +{ + return s->cpu_partial_slabs; +} #else static inline void slub_set_cpu_partial(struct kmem_cache *s, unsigned int nr_objects) { } + +static inline unsigned int slub_get_cpu_partial(struct kmem_cache *s) +{ + return 0; +} #endif /* CONFIG_SLUB_CPU_PARTIAL */ =20 /* --=20 2.27.0 From nobody Mon Feb 9 16:34:45 2026 Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D7A910E3 for ; Sun, 31 Mar 2024 02:51:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.166.238 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711853468; cv=none; b=S29mWpT0WAluwrCFYOg2SUL7rg20CutUt89aiDpgComxQoavtVcTuj4X2QCC6dtyy/n6wpDXcEEDmgd9lXtZhcfTYHOjxkMaPeRZ3ghlNU98niJEya0Wlf04vyFVu2/51CwgNOiBkxnpLH/R1q6q8c24ep8uLbwXHysUPqUkcGg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711853468; c=relaxed/simple; bh=BxD8Njt7gNZ1cuGYp6dNqZIZLAXLDATufHYVay932/A=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Z2E5oHSL/jIMzSIdFV3OKfpqnj1iLZQcIgIcv2vRLcsGLFAGMEv4GGW1ZGfR60hIPVoHbhiTZLF10E217tx4V05hPe6TZ2XZyUznioWriGHsb/RY6pwsCUZdwwPUDbDQyyMkrwiXQtYqkTlZyEhdqRcGa+ZvTK2KgR5CN5nk8Ek= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com; spf=pass smtp.mailfrom=windriver.com; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b=sSAxXW/v; arc=none smtp.client-ip=205.220.166.238 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=windriver.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b="sSAxXW/v" Received: from pps.filterd (m0250810.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 42V2ErUB022442; Sat, 30 Mar 2024 19:19:50 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= PPS06212021; bh=2+C0G4UMINVUvGYbirPlCl5FdouMdwjB+cfew6a5HSU=; b= sSAxXW/vj4FqFQfKPs3OceQDoGWqXNT7bQyhdW4uLTQlGimBtrWTjytPKSxvHgGh xniDw9B7CwYkFhvofNo8KXUT17xWwCREDsr+K4OaRV9e/JhncU1YUU4K2JrRdlGK 8NigrGt9fmFh6oNH5yVjftVou64QX6jAiIrKOzjB2ZXb2laK0qlcVxSNVnPfDOWM n69Xf4M+A3HZDaTEsd7gGPTiFae9vKY32tkBjQEhL+wmlfSPq2uISk4k6V1xN9rW NYkfKgwnSKh+EJ/rdCgTR4wxJYVQ0PCSm24Y3kscBEdrXFXVduwlPLGzd8+gq6gR jj6YdQzqbQbnlrSuS9roxw== Received: from ala-exchng01.corp.ad.wrs.com (ala-exchng01.wrs.com [147.11.82.252]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 3x6e10gm3s-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Sat, 30 Mar 2024 19:19:49 -0700 (PDT) Received: from ala-exchng01.corp.ad.wrs.com (147.11.82.252) by ala-exchng01.corp.ad.wrs.com (147.11.82.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Sat, 30 Mar 2024 19:19:44 -0700 Received: from pek-lpd-ccm5.wrs.com (147.11.1.11) by ala-exchng01.corp.ad.wrs.com (147.11.82.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37 via Frontend Transport; Sat, 30 Mar 2024 19:19:42 -0700 From: To: , , , , , , , <42.hyeyoo@gmail.com> CC: , , Subject: [PATCH 3/4] mm/slub: simplify get_partial_node() Date: Sun, 31 Mar 2024 10:19:25 +0800 Message-ID: <20240331021926.2732572-4-xiongwei.song@windriver.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20240331021926.2732572-1-xiongwei.song@windriver.com> References: <20240331021926.2732572-1-xiongwei.song@windriver.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: axzpVre-xU6I8oY8XQ3o9V6gU5HlFFCK X-Proofpoint-GUID: axzpVre-xU6I8oY8XQ3o9V6gU5HlFFCK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-31_01,2024-03-28_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 adultscore=0 clxscore=1015 phishscore=0 priorityscore=1501 suspectscore=0 mlxscore=0 mlxlogscore=999 malwarescore=0 bulkscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2403210001 definitions=main-2403310017 Content-Type: text/plain; charset="utf-8" From: Xiongwei Song The break conditions can be more readable and simple. We can check if we need to fill cpu partial after getting the first partial slab. If kmem_cache_has_cpu_partial() returns true, we fill cpu partial from next iteration, or break up the loop. Then we can remove the preprocessor condition of CONFIG_SLUB_CPU_PARTIAL. Use dummy slub_get_cpu_partial() to make compiler silent. Signed-off-by: Xiongwei Song --- mm/slub.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 590cc953895d..ec91c7435d4e 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2614,18 +2614,20 @@ static struct slab *get_partial_node(struct kmem_ca= che *s, if (!partial) { partial =3D slab; stat(s, ALLOC_FROM_PARTIAL); - } else { - put_cpu_partial(s, slab, 0); - stat(s, CPU_PARTIAL_NODE); - partial_slabs++; + + /* Fill cpu partial if needed from next iteration, or break */ + if (kmem_cache_has_cpu_partial(s)) + continue; + else + break; } -#ifdef CONFIG_SLUB_CPU_PARTIAL - if (partial_slabs > s->cpu_partial_slabs / 2) - break; -#else - break; -#endif =20 + put_cpu_partial(s, slab, 0); + stat(s, CPU_PARTIAL_NODE); + partial_slabs++; + + if (partial_slabs > slub_get_cpu_partial(s) / 2) + break; } spin_unlock_irqrestore(&n->list_lock, flags); return partial; --=20 2.27.0 From nobody Mon Feb 9 16:34:45 2026 Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B826D613C for ; Sun, 31 Mar 2024 03:05:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.166.238 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711854308; cv=none; b=SIYoug9PQruq94kkK0uJW9SKrsQvW373/9o+ZnW/WOTVfjXpIPL7FxfQxG75lVkbYhwjLuMXKWnDSY/Wb3djhxpgcvBrYjBZWdPkuK4rfn7R+iT+RAPEkMC6G17+uiYwYdpfHIiZp8om3Oxp2uOP30zBI7T+H1xuWNMWWxdcJzM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711854308; c=relaxed/simple; bh=9asL1uGTADUAnVvJmQ3LOM4Kjgl5Ou5eedmWn7dJca8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mBdyTPR2sXkuCgTWIvF68JdOovv3GP3Z0wi9B10psykjnMrxoAiOlX05KCSE9AC71XEIqn/ctU9MLgCew8w54UnzE4pW4w56Mw9N+Dub7pFSqPoEv9sPCt8ts79nwDfoDMoAGJJb2jBJjeGMo1CZUnLCrBEqxrZ7Vu0czYljvqc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com; spf=pass smtp.mailfrom=windriver.com; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b=fdSAbWLB; arc=none smtp.client-ip=205.220.166.238 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=windriver.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b="fdSAbWLB" Received: from pps.filterd (m0250810.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 42V2ErUC022442; Sat, 30 Mar 2024 19:19:50 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= PPS06212021; bh=V/altOOb2D0h8LSKAVzpQh2XXjBbKxhhn3XS09HYYOI=; b= fdSAbWLBSS+chg9YVlYO/ndpwwt3aYThZnj5yegqrOhb0gx5vXUDkxIWMe9WbAzs hhWOsPLzs6BoptriCZSyWplzaJChIBv+c8+LeO/DqbHtBhLgzrJXaAfuYW/MDDzB dyf2zdyqosSdUGnfZjOpomBbPwlxotD0hRY5XAWsSZIlwSHDBPAErQdkl+i5umrX csDOzLjyAGGZbv1l7ZtzpsBr+BREaKPTDbrdqCnhxEGH5SZvtTnqPOkLepo+clNF jUj5r7nFhVD55nZaUzuz2qgEKEzRy6Re48QsagQxAKustc8RNHkKa4YAj/uoFyc3 /bkgFPzFGEWVV5XVq/XFKQ== Received: from ala-exchng01.corp.ad.wrs.com (ala-exchng01.wrs.com [147.11.82.252]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 3x6e10gm3s-4 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Sat, 30 Mar 2024 19:19:50 -0700 (PDT) Received: from ala-exchng01.corp.ad.wrs.com (147.11.82.252) by ala-exchng01.corp.ad.wrs.com (147.11.82.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Sat, 30 Mar 2024 19:19:48 -0700 Received: from pek-lpd-ccm5.wrs.com (147.11.1.11) by ala-exchng01.corp.ad.wrs.com (147.11.82.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37 via Frontend Transport; Sat, 30 Mar 2024 19:19:45 -0700 From: To: , , , , , , , <42.hyeyoo@gmail.com> CC: , , Subject: [PATCH 4/4] mm/slub: don't read slab->cpu_partial_slabs directly Date: Sun, 31 Mar 2024 10:19:26 +0800 Message-ID: <20240331021926.2732572-5-xiongwei.song@windriver.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20240331021926.2732572-1-xiongwei.song@windriver.com> References: <20240331021926.2732572-1-xiongwei.song@windriver.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: B21bMmEqcagipPqRJ5Q2eJLVqbbmONO5 X-Proofpoint-GUID: B21bMmEqcagipPqRJ5Q2eJLVqbbmONO5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-31_01,2024-03-28_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 adultscore=0 clxscore=1015 phishscore=0 priorityscore=1501 suspectscore=0 mlxscore=0 mlxlogscore=920 malwarescore=0 bulkscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2403210001 definitions=main-2403310017 Content-Type: text/plain; charset="utf-8" From: Xiongwei Song We can use slub_get_cpu_partial() to read cpu_partial_slabs. Signed-off-by: Xiongwei Song --- mm/slub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/slub.c b/mm/slub.c index ec91c7435d4e..47ea06d6feae 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2966,7 +2966,7 @@ static void put_cpu_partial(struct kmem_cache *s, str= uct slab *slab, int drain) oldslab =3D this_cpu_read(s->cpu_slab->partial); =20 if (oldslab) { - if (drain && oldslab->slabs >=3D s->cpu_partial_slabs) { + if (drain && oldslab->slabs >=3D slub_get_cpu_partial(s)) { /* * Partial array is full. Move the existing set to the * per node partial list. Postpone the actual unfreezing --=20 2.27.0