From nobody Sun Feb 8 07:22:26 2026 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 783B458127 for ; Fri, 29 Mar 2024 16:04:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711728247; cv=none; b=n/c4UK2CSNnV/SbFMfrqCxqBrKzJF3EkDMrHB+YsEE7ZJGGPz47pXyQtiHRwwXJjcFyK7bc0vqEKhr05dVACQea4gCQoDWTvZvcYueOlAKriBx8MjYiCfSHK75Ktcc+CaCck6nDpH0AaEgSVWioszeotbommUqbYLiZYoKv6eho= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711728247; c=relaxed/simple; bh=wFy2ocajmQzl18h5nhYUNHbZaRyAmobqSM9VgYVPkIo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IPM2R8WzDnSFFT4Jo9lvvsQ+UMUldDn/l3Q0bwJtg2wOIKprBQU7pt3kSZ7lEi5YspvTGgPMT4MbrGldB9FBuscjwBMirYU+ybXnsM8Uc/OFbDCie21vvytDR8uawtYFyUJplR0vw3Y+wucYN9uK8G9Ggz9OUlOfQkbqrqqIQ7o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=toblux.com; spf=none smtp.mailfrom=toblux.com; dkim=pass (2048-bit key) header.d=toblux-com.20230601.gappssmtp.com header.i=@toblux-com.20230601.gappssmtp.com header.b=QbAWB6oM; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=toblux.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=toblux.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=toblux-com.20230601.gappssmtp.com header.i=@toblux-com.20230601.gappssmtp.com header.b="QbAWB6oM" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a46f0da1b4fso271993066b.2 for ; Fri, 29 Mar 2024 09:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toblux-com.20230601.gappssmtp.com; s=20230601; t=1711728243; x=1712333043; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sS8wc5N06+O63hK3jDZunVFBSBF3m9X5f2cGi7eyqww=; b=QbAWB6oM3Se3vRG4kNWCwFOczHTIvaE/TTPXO00Pgzj9MNQ7q3cPmUs+Yuk6JQ1mzp FFTLJoG9xeCqhlIoNccQxB1hSZ7DZ2Kk3zLV1ir6ikUBD2Ze6S2FnDl1tramR1VhqZSo kvQIp68ATLg0/st/aQ0PHq8/sFcK7sWxLv2GYO71kEdE/Vj6QpqUW2KoVSctF8sieAid Mhn4AW1NUg9CZI1hBn3uLhIzMe+s7ddtk8y+WljRn0u5gm+Spc5pOEVZMRlX3qiZcxdQ 0FtYIo5unlYLxV47k4GJqT+P/7qIr49zIZNvv+QtcgEFrxE8IOrCeXWv9GkVvoIxhav2 A1oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711728243; x=1712333043; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sS8wc5N06+O63hK3jDZunVFBSBF3m9X5f2cGi7eyqww=; b=EBUT2ZnMHlbgDGg+/HomXE79ZrxjUHXnu1+64ppRxX9Lm2ImbjIIsF6S22cDIoXto5 I06t8futm7EPKAjiJNlpU8b5Jk1LrrvRmI+vY1QUe+X/0jhMm8KSh9pEB/bp1/6WsZ2b Gr0UMULwltMx9vafbH5iUdvIiRYIYL8diEbmlvG3trN/Gtwi4lOIWRiiW1SgnRCSBv7E AEHH6nkD+6WTnYgsDD4HtJ6zj8i2EojMUClvO5qgaF9shMZKqfN2J88c9XL7HqfpBVPO OYIPAICwpCll5iwT3OmzMds1BlfUAjAxaU3a0s4fileywjL5fEqDFbQHo+KLi45iuuU/ etyg== X-Gm-Message-State: AOJu0YygdBRUxJHO8/BcoLwF5uyYu8XDsR2MPh8XDLy1no0F7PCxIWtt eklzgHjNaDJipcy3+hiL7THCAQIfXnk2S2i2ZFuIhCzEue2mUNGGjIGTKbz1Bnw= X-Google-Smtp-Source: AGHT+IFnI2YKOOVkagxP/BUc7At9KYFILXTu7yGhat+OGyeCg6hF2QqfF4se7FCbeLkXd5P1YXlv+Q== X-Received: by 2002:a17:906:69c8:b0:a4d:f58b:9e9b with SMTP id g8-20020a17090669c800b00a4df58b9e9bmr1629316ejs.25.1711728242840; Fri, 29 Mar 2024 09:04:02 -0700 (PDT) Received: from fedora.fritz.box (aftr-82-135-80-212.dynamic.mnet-online.de. [82.135.80.212]) by smtp.gmail.com with ESMTPSA id bf9-20020a170907098900b00a4e3fda23f5sm386088ejc.165.2024.03.29.09.04.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 09:04:02 -0700 (PDT) From: Thorsten Blum To: thorsten.blum@toblux.com Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, mhiramat@kernel.org, rostedt@goodmis.org Subject: [RESEND PATCH v2] tracing: Improve performance by using do_div() Date: Fri, 29 Mar 2024 17:02:30 +0100 Message-ID: <20240329160229.4874-2-thorsten.blum@toblux.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240320215537.71034-5-thorsten.blum@toblux.com> References: <20240320215537.71034-5-thorsten.blum@toblux.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Partially revert commit d6cb38e10810 ("tracing: Use div64_u64() instead of do_div()") and use do_div() again to utilize its faster 64-by-32 division compared to the 64-by-64 division done by div64_u64(). Explicitly cast the divisor bm_cnt to u32 to prevent a Coccinelle warning reported by do_div.cocci. The warning was removed with commit d6cb38e10810 ("tracing: Use div64_u64() instead of do_div()"). Using the faster 64-by-32 division and casting bm_cnt to u32 is safe because we return early from trace_do_benchmark() if bm_cnt > UINT_MAX. This approach is already used twice in trace_do_benchmark() when calculating the standard deviation: do_div(stddev, (u32)bm_cnt); do_div(stddev, (u32)bm_cnt - 1); Signed-off-by: Thorsten Blum --- Changes in v2: - Update patch with latest changes from master - Update patch title and description --- kernel/trace/trace_benchmark.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_benchmark.c b/kernel/trace/trace_benchmark.c index 811b08439406..e19c32f2a938 100644 --- a/kernel/trace/trace_benchmark.c +++ b/kernel/trace/trace_benchmark.c @@ -104,7 +104,7 @@ static void trace_do_benchmark(void) stddev =3D 0; =20 delta =3D bm_total; - delta =3D div64_u64(delta, bm_cnt); + do_div(delta, (u32)bm_cnt); avg =3D delta; =20 if (stddev > 0) { --=20 2.44.0