From nobody Wed Feb 11 22:28:39 2026 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2100.outbound.protection.outlook.com [40.107.236.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90A3917C77 for ; Fri, 29 Mar 2024 01:32:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.100 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711675967; cv=fail; b=i1ayD55VCh7vjWiz4J1sMq9s0ObWtxS6QwheMJDgrA85BaAHvGkIDMwr1NjiGHLDhirtGT/xWQCWQ+A+ajCmYH6AAOHrERTTob37u9jkdqQFaktxxtswV/2/NMiSHmOpStvfyqlhL4kJ63XifTsE8t/mJBa46LaJF+5xXqBLxu4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711675967; c=relaxed/simple; bh=7RRmFGzpvFlygvoZ0JvQWBzV6vREGdaNwrEtBV3h74Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=orVFUDRy2Srg2AAeTyZqtweahb6pEEphs4UnjJpn/eL/uYs+D/qYOoNP6aTkWiz0mqcgNnrp2HEltWIVx0dbzUK9IbYS+44HsO2dLAw0bbu6JoGuFBKuyHuBJsHmi6GH5cUzKYzTeWUWQix1SvCrqCJgx93fzZQuC1dSG0f/p3k= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com; spf=pass smtp.mailfrom=os.amperecomputing.com; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b=Ivk9n8G5; arc=fail smtp.client-ip=40.107.236.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b="Ivk9n8G5" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aAJcmHcgbTCPDOI3eJIiQwk0CYvoV/DEJI5MvWkJOPj6mHb17jnQ9X0Z2f6t1e5RB5TqKZreujrIvy2D/+AJCa3qRk4GwUE35GZvpSSygYYKercueyhaUPdGYsDuxfFw455gYA/WPh8gZ2z4ZVH4iCQR1JqKNSx3quuW7uIcS8x/nF3FE5Td0EhpUyUoikk6H6m+aQct9ZevUOzfp06XUnxVua717caQ8m0P6FbnOOIPO9UGoeLNAtzzb0U+exwtXR2lhgSJCYnbyOxGoVGW/hB48r2qpaad/r0J/AiE18h5L3cOHY1CukhC7NpaKgiWEYOrWzkMR2tusGHWSdGiUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ll5JW0l5WfxPWTGpRYxt/P9NbQPRIrY/boPHLZaVqVo=; b=cBQ+TYsPbK1cqW3EZN5qzxr7t4q/hrTwFExq84Ez0e0UtYj2m27UE0x3JEby8OesXwvHvIcrGPeF9ksCvqFG6GkDwrc4r1nm0M7AANx/eQ5/ymwxjCFISNoi7YePSZDBCDGNpzI0XS6iK2SqJiKoiDB0WNXkor0HEe0nsBW1d0m55omUipc/NCqhxNKvqU+mubazRLb49brE/V5MUjwQg8S8oRl3bteTJfNA+s2mY8kj+LH1TZ45Viv9hKVeE/2BK3wkHYUJDGPnseJNGTXWEzVilfMbOUvPq1POS+dGKRQDEwKpBPIcIiSIrd5pZ8+YkC5PW4nWyIxXqXOJVRNhww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ll5JW0l5WfxPWTGpRYxt/P9NbQPRIrY/boPHLZaVqVo=; b=Ivk9n8G5DknRULFYr/8inYvXnh8n97r4VMnVZg1WGDHUgjE0K/LwBzprHibv6wnXqSgaazNJyQhv9lHXtoZov1QwKmm099roZqAgz1yM6mOP3bH1TcUxh0ryw9xeOuyGcWzXnwER/otN60ycDIeKhhPFtBFa9K9vXQwA6bMnyt0= Received: from BL0PR01MB4226.prod.exchangelabs.com (2603:10b6:208:49::30) by DS7PR01MB7878.prod.exchangelabs.com (2603:10b6:8:81::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.32; Fri, 29 Mar 2024 01:32:42 +0000 Received: from BL0PR01MB4226.prod.exchangelabs.com ([fe80::12be:916:b914:8b26]) by BL0PR01MB4226.prod.exchangelabs.com ([fe80::12be:916:b914:8b26%7]) with mapi id 15.20.7409.038; Fri, 29 Mar 2024 01:32:42 +0000 From: Ilkka Koskinen To: Robin Murphy , Will Deacon Cc: Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jing Zhang , Ilkka Koskinen Subject: [PATCH v3 1/2] perf/arm-cmn: Decouple wp_config registers from filter group number Date: Thu, 28 Mar 2024 18:32:14 -0700 Message-ID: <20240329013215.169345-2-ilkka@os.amperecomputing.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240329013215.169345-1-ilkka@os.amperecomputing.com> References: <20240329013215.169345-1-ilkka@os.amperecomputing.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: CH0PR13CA0008.namprd13.prod.outlook.com (2603:10b6:610:b1::13) To BL0PR01MB4226.prod.exchangelabs.com (2603:10b6:208:49::30) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR01MB4226:EE_|DS7PR01MB7878:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aGQauRpTEm1LBxllEfx3pd+g0M26WFOQFqZKAUurhFIk1Cgjz5l9aYl+NO+yl3oEAHm6vmPv51QTMB06IOFhocnjQ+cRDweaZUs/gG8vcN6PEuGZcJshLRriX/HvSS404IYG2PoIEZ+/vNbrTNl3qJxCJPtGsTQMKPMXHDub0Xpty9okko0I1VsbhUpB4squYgnSwMZzIG+qBXA86BaNXWk/TWXnuOJPrked0FfUj9GPoPch8iMDSVQXhFQppshBCJ7EDAyM64mnAQtpWJuMLMwV/xUprUGjeSp44iFH29ASUbQ2WD0rgN+KJIOdxEPPhzhhVhLkAu4+EiezuDwtElPLVs5Ry8/EDwQSVJuygiBdTi9EmS9VCb2O4uf8MckV5GgHpjZ0oQ2zyzEcQuRl/21YhqoPhKe0t0OFIXL+hSC/30RYKSGuzRlglYyqCtqup1FTmmnPi38KE1RJttpklDlb/zxp5wq4hIR1L+B5prM47Z02YKDgNmOdP8gPJFqHkAvQ3d0vHzYAtE74Rj5kixla1vH/9c6mQm8aAY7McmLR5ym4CRlKdNjgBtMXFA3s3WU4owjj44aOFzfVkEgXnQvgzFqACGJmBVv6G47pvKLglH1w4Kl7mmeOwzo9BdvbDfbMZWN6RAeMZesloiyw/Yg4Uz7ejArjmHO4FC2x9M/AB7pmEc63L1FfrVmzmjxPeWEU9KThYoYE+b27kjEwie2ub+oxE0oaZatqztHz3VQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR01MB4226.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015)(52116005)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UV7b3EwDusVmGdHQ1lZqFdXb75TfpfU0cS4P6uVaBGJQ+XNE2LM8gPkwSu9E?= =?us-ascii?Q?9kkVom+TKA0kbs+jY9KINf8ezNXjZXXHtqAZwCye2T+JtQ26d7GJYwgDpHeH?= =?us-ascii?Q?6gGzuVOvA7UN1lVqJnjlxEP+2cBQEsdXE7lqNZeUhxeT/36Dp0eefb0oHfVV?= =?us-ascii?Q?cLJeQuYJhjZuVaC4jBDtfSpNkpflYAYMmbIqDQoFT2AJAkT7TuZnvKnhQMZV?= =?us-ascii?Q?szNemuoKcqJ20xnqTZhirHSr0tpMFdveuasCBiiy7WlbIgQrLZTBHRVIQkeG?= =?us-ascii?Q?IWQ6v9kQG7hYSMkNHscdC6xsvpFCv3GcslXYyYfVNbsguE++KgKyZrHrbqNh?= =?us-ascii?Q?V0mbBHjMqrtT/rG7eJusSVHeawdozykAhECJ508ciiXlVizAp+VcUePDgiXB?= =?us-ascii?Q?sDGG4LbzMBSvt9rvq2X2POg5ZAlprp2veRD0DfYszSnSGSOFe09Ir94NCTZJ?= =?us-ascii?Q?TZ7n6bOnek60EjWQamwgFI+ournCedjZn3KTJfBUhoCeDYLMC+ZaXmk6nNT+?= =?us-ascii?Q?ORfgAPmdo2cBdOPJghWYn4fOz4VojdDDmNC/6ZiNEmUO+C0KejeDyN+Napv9?= =?us-ascii?Q?9B0c2yU+LohsMaKRGK/gGBEUqrSgbDsT2+tjwDTO6ndQxo4k9VJkvIbKjdhn?= =?us-ascii?Q?F0meh+luzSbjVdfWDuEhoEuEGeFUmdVgV2CT3cEmoejFuMlv8Msyi/aiC303?= =?us-ascii?Q?M1IQ1NoxsfKe2H+wAN6Sby+5YhnvNUrdGmzMo3iEgPbxpa1j36/Vd3kvTCXq?= =?us-ascii?Q?AQca9tOHMSf9dVg/6aGFaR6ub+neFCVdJeND0TqcBSIalOcqbfSeAPt0suf/?= =?us-ascii?Q?Q6sewT29+VQhe2DtaE6lTMpznOGRGQ+qtGR95ACWfwLM8krZkxBv+9AYoYGm?= =?us-ascii?Q?wTqlpcmUsQ+L2bHe7DjbGtDYceQA1M0OEO0XFvXiVS3zPou8bmM8rRc81SzO?= =?us-ascii?Q?k67v3HI/pea0oL4Sc6mvJR/jWZtX2WSDjZi7k8D/pRbrwkU5wr8/EDeLrvgH?= =?us-ascii?Q?MkTd+BTxk8S1tVwBoIW2TUUBGpVDJwwrT5DbUuJ3HgEhBoonSSkJer4V/MUK?= =?us-ascii?Q?hM6Yfn6RayKVbhyAOCyfLmtb4hzEPEyBr3tTxpaH23hjSKqy+pfs6bItseuE?= =?us-ascii?Q?4ojU0gOxA+WzbR3SzCrWVCxDP7ONfSvsQDGEfM1WIwk7+mKB0qAlaMzVECet?= =?us-ascii?Q?L8FbqYLcijOnUxIvDO77EIhCOBOcNUkmPIses++w+8Vg3AHOJ66zfbv660Jw?= =?us-ascii?Q?m15XHKyHZKyCVupA+XuiqlukYtvpydbnj2NYY4c/eV6VIwYzHpoKDEG5Wl6E?= =?us-ascii?Q?sX1mtFLtjvM0/xBIXrcRpTpjTeDCsgzXRRZ3EQKPHrwM7zK1xY2IJjdrBP8X?= =?us-ascii?Q?6nodbrWhYZD1hViqUeLwRTmpOwq5P0/ZltRwaclXo7Kkzbb4QPvBLchkKSFO?= =?us-ascii?Q?lyYFqXGtFOeFhUTknhYgjdsdiPyY23lpiVXfBnbkuFLB8scicbXMlDFw/UQd?= =?us-ascii?Q?5DzF5AONM25/VmdbWHIHoiiCcClbLjTU1xprbxuYWyBE6nmh5csAMvxMFulM?= =?us-ascii?Q?9sFChxn58uT9UMp7IYgMzZaMw1ToPP2hRLXkDKKuDhL/iBT0wwQRKXiCWa6D?= =?us-ascii?Q?NOw98R9QZubMSdYp78DKLtc=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3fd1745-5458-4607-08b2-08dc4f902111 X-MS-Exchange-CrossTenant-AuthSource: BL0PR01MB4226.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2024 01:32:42.9339 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K+8mXnNzUquQXjpdYIbRBrGGQfhY1Px9efsIi90APIXWKmfq0bvS5A7Qz3hwW2YBBOb/3EJd1R+mN26BjPx0278621CKPkoI8JsZpcGFU+4SkVoSUaotr1nH0rPNShOf X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR01MB7878 Content-Type: text/plain; charset="utf-8" Previously, wp_config0/2 registers were used for primary match group and wp_config1/3 registers for secondary match group. In order to support tertiary match group, this patch decouples the registers and the groups. Signed-off-by: Ilkka Koskinen --- drivers/perf/arm-cmn.c | 97 ++++++++++++++++++++++++++++++++++-------- 1 file changed, 80 insertions(+), 17 deletions(-) diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c index 7ef9c7e4836b..9f4a82861faa 100644 --- a/drivers/perf/arm-cmn.c +++ b/drivers/perf/arm-cmn.c @@ -590,6 +590,13 @@ struct arm_cmn_hw_event { s8 dtc_idx[CMN_MAX_DTCS]; u8 num_dns; u8 dtm_offset; + + /* + * WP config registers are divided to UP and DOWN events. We need to + * keep to track only one of them. + */ + DECLARE_BITMAP(wp_idx, CMN_MAX_XPS); + bool wide_sel; enum cmn_filter_select filter_sel; }; @@ -617,6 +624,17 @@ static unsigned int arm_cmn_get_index(u64 x[], unsigne= d int pos) return (x[pos / 32] >> ((pos % 32) * 2)) & 3; } =20 +static void arm_cmn_set_wp_idx(unsigned long *wp_idx, unsigned int pos, bo= ol val) +{ + if (val) + set_bit(pos, wp_idx); +} + +static unsigned int arm_cmn_get_wp_idx(unsigned long *wp_idx, unsigned int= pos) +{ + return test_bit(pos, wp_idx); +} + struct arm_cmn_event_attr { struct device_attribute attr; enum cmn_model model; @@ -1336,9 +1354,34 @@ static const struct attribute_group *arm_cmn_attr_gr= oups[] =3D { NULL }; =20 -static int arm_cmn_wp_idx(struct perf_event *event) +static int arm_cmn_find_free_wp_idx(struct arm_cmn_dtm *dtm, + struct perf_event *event) +{ + int wp_idx =3D CMN_EVENT_EVENTID(event); + + if (dtm->wp_event[wp_idx] >=3D 0) + if (dtm->wp_event[++wp_idx] >=3D 0) + return -ENOSPC; + + return wp_idx; +} + +static int arm_cmn_get_assigned_wp_idx(struct perf_event *event, + struct arm_cmn_hw_event *hw, + unsigned int pos) { - return CMN_EVENT_EVENTID(event) + CMN_EVENT_WP_GRP(event); + return CMN_EVENT_EVENTID(event) + arm_cmn_get_wp_idx(hw->wp_idx, pos); +} + +static void arm_cmn_claim_wp_idx(struct arm_cmn_dtm *dtm, + struct perf_event *event, + unsigned int dtc, int wp_idx, + unsigned int pos) +{ + struct arm_cmn_hw_event *hw =3D to_cmn_hw(event); + + dtm->wp_event[wp_idx] =3D hw->dtc_idx[dtc]; + arm_cmn_set_wp_idx(hw->wp_idx, pos, wp_idx - CMN_EVENT_EVENTID(event)); } =20 static u32 arm_cmn_wp_config(struct perf_event *event) @@ -1520,12 +1563,12 @@ static void arm_cmn_event_start(struct perf_event *= event, int flags) writeq_relaxed(CMN_CC_INIT, cmn->dtc[i].base + CMN_DT_PMCCNTR); cmn->dtc[i].cc_active =3D true; } else if (type =3D=3D CMN_TYPE_WP) { - int wp_idx =3D arm_cmn_wp_idx(event); u64 val =3D CMN_EVENT_WP_VAL(event); u64 mask =3D CMN_EVENT_WP_MASK(event); =20 for_each_hw_dn(hw, dn, i) { void __iomem *base =3D dn->pmu_base + CMN_DTM_OFFSET(hw->dtm_offset); + int wp_idx =3D arm_cmn_get_assigned_wp_idx(event, hw, i); =20 writeq_relaxed(val, base + CMN_DTM_WPn_VAL(wp_idx)); writeq_relaxed(mask, base + CMN_DTM_WPn_MASK(wp_idx)); @@ -1550,10 +1593,9 @@ static void arm_cmn_event_stop(struct perf_event *ev= ent, int flags) i =3D hw->dtc_idx[0]; cmn->dtc[i].cc_active =3D false; } else if (type =3D=3D CMN_TYPE_WP) { - int wp_idx =3D arm_cmn_wp_idx(event); - for_each_hw_dn(hw, dn, i) { void __iomem *base =3D dn->pmu_base + CMN_DTM_OFFSET(hw->dtm_offset); + int wp_idx =3D arm_cmn_get_assigned_wp_idx(event, hw, i); =20 writeq_relaxed(0, base + CMN_DTM_WPn_MASK(wp_idx)); writeq_relaxed(~0ULL, base + CMN_DTM_WPn_VAL(wp_idx)); @@ -1571,10 +1613,23 @@ struct arm_cmn_val { u8 dtm_count[CMN_MAX_DTMS]; u8 occupid[CMN_MAX_DTMS][SEL_MAX]; u8 wp[CMN_MAX_DTMS][4]; + u8 wp_combine[CMN_MAX_DTMS][2]; int dtc_count[CMN_MAX_DTCS]; bool cycles; }; =20 +static int arm_cmn_val_find_free_wp_config(struct perf_event *event, + struct arm_cmn_val *val, int dtm) +{ + int wp_idx =3D CMN_EVENT_EVENTID(event); + + if (val->wp[dtm][wp_idx]) + if (val->wp[dtm][++wp_idx]) + return -ENOSPC; + + return wp_idx; +} + static void arm_cmn_val_add_event(struct arm_cmn *cmn, struct arm_cmn_val = *val, struct perf_event *event) { @@ -1606,8 +1661,9 @@ static void arm_cmn_val_add_event(struct arm_cmn *cmn= , struct arm_cmn_val *val, if (type !=3D CMN_TYPE_WP) continue; =20 - wp_idx =3D arm_cmn_wp_idx(event); - val->wp[dtm][wp_idx] =3D CMN_EVENT_WP_COMBINE(event) + 1; + wp_idx =3D arm_cmn_val_find_free_wp_config(event, val, dtm); + val->wp[dtm][wp_idx] =3D 1; + val->wp_combine[dtm][wp_idx >> 1] +=3D !!CMN_EVENT_WP_COMBINE(event); } } =20 @@ -1631,6 +1687,7 @@ static int arm_cmn_validate_group(struct arm_cmn *cmn= , struct perf_event *event) return -ENOMEM; =20 arm_cmn_val_add_event(cmn, val, leader); + for_each_sibling_event(sibling, leader) arm_cmn_val_add_event(cmn, val, sibling); =20 @@ -1645,7 +1702,7 @@ static int arm_cmn_validate_group(struct arm_cmn *cmn= , struct perf_event *event) goto done; =20 for_each_hw_dn(hw, dn, i) { - int wp_idx, wp_cmb, dtm =3D dn->dtm, sel =3D hw->filter_sel; + int wp_idx, dtm =3D dn->dtm, sel =3D hw->filter_sel; =20 if (val->dtm_count[dtm] =3D=3D CMN_DTM_NUM_COUNTERS) goto done; @@ -1657,12 +1714,12 @@ static int arm_cmn_validate_group(struct arm_cmn *c= mn, struct perf_event *event) if (type !=3D CMN_TYPE_WP) continue; =20 - wp_idx =3D arm_cmn_wp_idx(event); - if (val->wp[dtm][wp_idx]) + wp_idx =3D arm_cmn_val_find_free_wp_config(event, val, dtm); + if (wp_idx < 0) goto done; =20 - wp_cmb =3D val->wp[dtm][wp_idx ^ 1]; - if (wp_cmb && wp_cmb !=3D CMN_EVENT_WP_COMBINE(event) + 1) + if (wp_idx & 1 && + val->wp_combine[dtm][wp_idx >> 1] !=3D !!CMN_EVENT_WP_COMBINE(event)) goto done; } =20 @@ -1773,8 +1830,11 @@ static void arm_cmn_event_clear(struct arm_cmn *cmn,= struct perf_event *event, struct arm_cmn_dtm *dtm =3D &cmn->dtms[hw->dn[i].dtm] + hw->dtm_offset; unsigned int dtm_idx =3D arm_cmn_get_index(hw->dtm_idx, i); =20 - if (type =3D=3D CMN_TYPE_WP) - dtm->wp_event[arm_cmn_wp_idx(event)] =3D -1; + if (type =3D=3D CMN_TYPE_WP) { + int wp_idx =3D arm_cmn_get_assigned_wp_idx(event, hw, i); + + dtm->wp_event[wp_idx] =3D -1; + } =20 if (hw->filter_sel > SEL_NONE) hw->dn[i].occupid[hw->filter_sel].count--; @@ -1783,6 +1843,7 @@ static void arm_cmn_event_clear(struct arm_cmn *cmn, = struct perf_event *event, writel_relaxed(dtm->pmu_config_low, dtm->base + CMN_DTM_PMU_CONFIG); } memset(hw->dtm_idx, 0, sizeof(hw->dtm_idx)); + memset(hw->wp_idx, 0, sizeof(hw->wp_idx)); =20 for_each_hw_dtc_idx(hw, j, idx) cmn->dtc[j].counters[idx] =3D NULL; @@ -1836,10 +1897,11 @@ static int arm_cmn_event_add(struct perf_event *eve= nt, int flags) if (type =3D=3D CMN_TYPE_XP) { input_sel =3D CMN__PMEVCNT0_INPUT_SEL_XP + dtm_idx; } else if (type =3D=3D CMN_TYPE_WP) { - int tmp, wp_idx =3D arm_cmn_wp_idx(event); + int tmp, wp_idx; u32 cfg =3D arm_cmn_wp_config(event); =20 - if (dtm->wp_event[wp_idx] >=3D 0) + wp_idx =3D arm_cmn_find_free_wp_idx(dtm, event); + if (wp_idx < 0) goto free_dtms; =20 tmp =3D dtm->wp_event[wp_idx ^ 1]; @@ -1848,7 +1910,8 @@ static int arm_cmn_event_add(struct perf_event *event= , int flags) goto free_dtms; =20 input_sel =3D CMN__PMEVCNT0_INPUT_SEL_WP + wp_idx; - dtm->wp_event[wp_idx] =3D hw->dtc_idx[d]; + + arm_cmn_claim_wp_idx(dtm, event, d, wp_idx, i); writel_relaxed(cfg, dtm->base + CMN_DTM_WPn_CONFIG(wp_idx)); } else { struct arm_cmn_nodeid nid =3D arm_cmn_nid(cmn, dn->id); --=20 2.43.0 From nobody Wed Feb 11 22:28:39 2026 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2099.outbound.protection.outlook.com [40.107.220.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13BFA1DFF5 for ; Fri, 29 Mar 2024 01:32:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.220.99 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711675971; cv=fail; b=nApMBFLdeJnd3wAN516NPmQ0x2GSufXebRZmNFYNu/P8SS0as5e1c2gWhfpDA5alby20JuVXvpkWQOFK7sYOZPlKpBigodIU8qfkb/PqJFXmlLzk64iFzHMIPQuSr6CzhbezN6HI1t62KCAAJlVZbmIj3ATqJftoNObFGlSoFH4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711675971; c=relaxed/simple; bh=K+6iYsBxWcbDDXlEpUnzGsArqhTfVz0NnuJHaUAi87o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=JabZ1tkmo2/R0IxjXwyB2lIam6h5c9rvgfJ/WLjQIOPH82s9l/JFbWW1pcf5FC5Db4oe2m5CFWH0ZOsjKeowq9/cnldrIFuPXAZGOy+O09FFJPf2HiiACfwVy4BDV0XeKSY0WEcsx2QhCxDvkHswgseZcixX+j8BGFemYifrdnA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com; spf=pass smtp.mailfrom=os.amperecomputing.com; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b=JLWKVD+z; arc=fail smtp.client-ip=40.107.220.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b="JLWKVD+z" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GqITA1LouALJWQmaMV0ViwNFD5ljTXS++aaPmdcyeF15KIoPa81icz77QQ4dTRjA2KTH3eCtv/G9vS1Vg9xyywxFS6glX9QnhAGoc1DJ24Zx5/JKCN3duv0KQLhdtpAXdYuC45oWYsUMG1iUDzaQ1RWEJ3yjdTbiE9+ZkpbJ9PcyEOzwyfM1O+h3NhLGSnBS5g67wmzNZlrh8FfFgWXi/LANGL/UazuWbCRlDaJkdUyWX6W45mLBhm2JtujUPLRrdMHoL1/N5eJC39cZWrsHW9muk7TDk0lzTlhJNd5R69lMq5lpWpPMb/UieFp41vsAReh8W5Cwi67DhkHflgb6bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yIlgrDq++UMPhf1VB0EHtOXrFD9q9CvhESCm85k9EgE=; b=KdvXTooXWV1mpeG8zSwSTj4PJxjEwYR3PEi3bagSyJWodAqjRRwptXDEcdEd2yyHG5GY1gU+HacLbbTmccJGPQhqpua5sQA7CDEZcAdFN2xbnl3ANUzlxq2OB9b8z8jx6AdnBWrFa8OsjELGu5eAH7otJnZKvcwmRk9BPTocViP8w6ldikWeu7zRRUHH3KK8w3YACUkMSkR5keZtjjEvqdZf6Y3zOx1JYAzxUlkCtvPs4bbWjW7/GnbD1KaJKf32LrQkDD+N15kEMYBPwS+Q4iOtVH6gtSIKzFMu+kEUuqEcUx4DQ82f7enIWXZyFl2IZAT4TteZJyhXi0UFK4mudA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yIlgrDq++UMPhf1VB0EHtOXrFD9q9CvhESCm85k9EgE=; b=JLWKVD+zcZWtpKY6+tAzTfA8mYyw6P/qGcDTG08anUzDwaHBCQLvLedm+VNJ1jK5ODRCaHrfUR8PapK4ALDoJgbc3EYNScDqQejVEeJtyRgAlIritTzOGAjTFXVW5OFSS5/0lnOKtMAfQFg8nFDkECXk9day8EQEIFHtGdYV3HI= Received: from BL0PR01MB4226.prod.exchangelabs.com (2603:10b6:208:49::30) by DS7PR01MB7878.prod.exchangelabs.com (2603:10b6:8:81::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.32; Fri, 29 Mar 2024 01:32:48 +0000 Received: from BL0PR01MB4226.prod.exchangelabs.com ([fe80::12be:916:b914:8b26]) by BL0PR01MB4226.prod.exchangelabs.com ([fe80::12be:916:b914:8b26%7]) with mapi id 15.20.7409.038; Fri, 29 Mar 2024 01:32:47 +0000 From: Ilkka Koskinen To: Robin Murphy , Will Deacon Cc: Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jing Zhang , Ilkka Koskinen Subject: [PATCH v3 2/2] perf/arm-cmn: Enable support for tertiary match group Date: Thu, 28 Mar 2024 18:32:15 -0700 Message-ID: <20240329013215.169345-3-ilkka@os.amperecomputing.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240329013215.169345-1-ilkka@os.amperecomputing.com> References: <20240329013215.169345-1-ilkka@os.amperecomputing.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: CH0PR13CA0008.namprd13.prod.outlook.com (2603:10b6:610:b1::13) To BL0PR01MB4226.prod.exchangelabs.com (2603:10b6:208:49::30) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR01MB4226:EE_|DS7PR01MB7878:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SbG9qLf69RV3Fnf4b+OGbXFBCzBb7MIom/4VY0Zaa8TF6eVblRVeXaZVScbTKq8CIYxIMONmJ3vtRJGbUUhQC/y+KkDWHdqcCbU1ILGMRQ7w5XR1gk5WKe6EitvOFBp3G/FoSZhP1fp54huO2AIHfXM43qjlb2lHWzTQNdbjGOAc5T0FAU5H+sBiXL+7UEIGqdZZcQvSouXT3w+8TVKCjwWn1zBMy5v7MRO1lQS6SktVISkvA6l2n6t7KzqUvVM5HHSEgu0de0UCeyBKNmC1p2XyDzcC2Q3+rWZkpPTbWevRPniVXGtq0uIUwHJfnxnbDuMrwfpgtig7j4aqQF4hBz0ypg7AoQp0BDiDM1MVb/PMOCqKc/TjtiT6m7EznhhSbotfqgx8dyEw7S0Hb7d2tnTf5etDoDo2fZygGKSgUepKJk0HReiafJYC1MYLF6Uk1hAzb/t+4rR6z89tmv3mPM/Dyp3jl4AQH/6tePQGux+eAbeeKCZgvChBvuekc3fsRzjCoVttQ0JDjm8zjPRnfqu/zssXgvS2GOf3MGH2qNyOZ4BqtD0JxPdSHDonSKiV2J4ZMmE1tTgd9y8QE740yEPDXfEIbDuteIPhiF8IzwITd1AwcIZKnrXZX7pyJ6XoRZ194F/MRsotI44O8/OZurkFYDwjpwAsQtG5IFgFo0AZrT8xG4FJ3JYt3WKv4EYtiEt/RFX7pu84Imk+sHryXkaW4UcrHxdc5ICTkepx1OQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR01MB4226.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015)(52116005)(38350700005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vxYU38GydlZDKK9eTTbvg+mPbf07/ZwL4A0OjJP+Vt3f4PbgKgbJ03Pl3YfT?= =?us-ascii?Q?al3YVJ/GPVkjWL8DJM+vPqJO59l06l8f/ZFau4D9ZiKYjtCAqGPRKgDXYjJj?= =?us-ascii?Q?9ULb7CD9lBSGzYBQ1sQ7y/OR0qX6L5vxK6nO4jkjcQIF9BMt/MP9rDs20hbY?= =?us-ascii?Q?h2jHR2KVBCt8XEhYgGFck3v5/AMshoXDwEEm1ZdQ7YweetrazvF0LG6Up+lU?= =?us-ascii?Q?a3wciOksdSyn1ZCnnA427Anvh6/c4rgrEjpsurMgobSobDkUHkxnmjRbY2fR?= =?us-ascii?Q?ObUXltZnrYDRJAFLcrKkwVpRVoFqukta3OQ00u/n79Zqo5zbNKHZxnL9zm3f?= =?us-ascii?Q?am16yOBQEVDpuAwa8g0CmHy64tOXro+HGl6OM+zNiXv+rLbrubnpZwqH4xvA?= =?us-ascii?Q?JQafqkKUz5V+/+AInxLqaFg5Llf0AY9e0XrauhqsGEVqOUMHl5X7dfYoKCqU?= =?us-ascii?Q?ShRWyXWFYPXZ2fP3sxZcXUAV6fatObZ8AUipw2iUSxRUZZ8IxCc7bcSD3RNe?= =?us-ascii?Q?Ghw+0IbczEzxowvlvp/+5eAnVlgdcoDbKRM/EM6TCyDB42QiMPVM3NBz3s8d?= =?us-ascii?Q?1EQMqj2GdcF6FNE9tmpYJC8HXPiNvslh/GQa7470y5ZIsakCGnoiM4rPo7kf?= =?us-ascii?Q?CCw9zhb/k4hrmCL1++GHg/Vl9aCaXRPMLRGMW/shHliUkfE/kZbvp/bP6CFb?= =?us-ascii?Q?YKpCzlJMpAHA6px4FTlnAKJJx5TwLNa/hZlmNCYN+JIgqHJ0qVaisDjT9UWp?= =?us-ascii?Q?vwRdJ9uHZ+9hAGhIY7md3OR4sWV6LIqYH+qq5546QrCAXfYGRrQeMDYJZ1xo?= =?us-ascii?Q?0+NGhKqZsAJGSCGapZC1AXzYZtRS7vn2qsdSxM4cFggr2e+raPhWCnovwN7i?= =?us-ascii?Q?dE8ZeTm1N7NMVKnBpSY31NXl4S/WWkQ0Ruy+uHCRFgWOsgLCkOB/T9XhIHdI?= =?us-ascii?Q?bk3EN1vtbye/BrdTKHtqDCjRb8Ftqm86MM2sDXTrqsE6fKJJaAO3p2mt63qS?= =?us-ascii?Q?XH9qIhsLqwt87B3mC+KP1K66aTUqGJe5VZfp9Y1DF4RtgREH1Yl4A63TVV3Y?= =?us-ascii?Q?eFgvlvtc5U6zkjRfpPJNckWV5ygoDrHh5C16+QCj1TaLVu8Uv6y2lSYWcL+7?= =?us-ascii?Q?iCfsboexJkC/S8XAdxqknfq0fGYVN2p9mkpUg8FamN9u3Nz7WzTR0KjaY0Dj?= =?us-ascii?Q?CP6nitAFROUmkQv2aU3uuz69MvDDZFbh6THGJFMa3d/gZzXEYgSy1JNVT/+6?= =?us-ascii?Q?69nLTJFsmJG1L4gkkvqIWYyPJkAYXFb1m9/6buNEoT3V715ETxjEAp2UBPSt?= =?us-ascii?Q?xidK5zDy6qDJVFivdFmjOJY+bhCsAYtKJ3iOkpIpuSF1iuIXJwQmei0S/WzZ?= =?us-ascii?Q?6YhyebJJgP6TSRbYYcM9EVYi4lxtP3fmfb+liG+yUuVFMhd53wMp5vQQrRmf?= =?us-ascii?Q?CrKtXrAMBVfwmoywkaza/I1DPWxOqUndkTe4CwzaW00KbXtki+RNxZArvq8Y?= =?us-ascii?Q?hkn1iFjkznlkOZ1ktFHASA4tiuUK+cG+5t7lV3Fvax41cq8QjtEnTZM5KoeF?= =?us-ascii?Q?9SrgHppR0i5m04GBUy5dwiJYpbnrDIDxvIGp6hAf1Lzk6RpuddgX6j1WRs0K?= =?us-ascii?Q?SSeaPKiABz4UMePKboiJtBQ=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9bf73bd7-063d-4b83-a274-08dc4f9023b5 X-MS-Exchange-CrossTenant-AuthSource: BL0PR01MB4226.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2024 01:32:47.6464 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R0lKLplhGi/g1nPtOodfCYXCNQJSENvHtDEfowBHtIz4tptaSRNEoAgRDlyB64UJ5e2cMp620RB1FVZ+/98jZoaXYqHPcJiF76FBsliF2wceTXEU4lEdimXRhHRwoOOv X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR01MB7878 Content-Type: text/plain; charset="utf-8" Add support for tertiary match group. Signed-off-by: Ilkka Koskinen --- drivers/perf/arm-cmn.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c index 9f4a82861faa..3d7db1254753 100644 --- a/drivers/perf/arm-cmn.c +++ b/drivers/perf/arm-cmn.c @@ -174,9 +174,8 @@ #define CMN_CONFIG_WP_COMBINE GENMASK_ULL(30, 27) #define CMN_CONFIG_WP_DEV_SEL GENMASK_ULL(50, 48) #define CMN_CONFIG_WP_CHN_SEL GENMASK_ULL(55, 51) -/* Note that we don't yet support the tertiary match group on newer IPs */ -#define CMN_CONFIG_WP_GRP BIT_ULL(56) -#define CMN_CONFIG_WP_EXCLUSIVE BIT_ULL(57) +#define CMN_CONFIG_WP_GRP GENMASK_ULL(57, 56) +#define CMN_CONFIG_WP_EXCLUSIVE BIT_ULL(58) #define CMN_CONFIG1_WP_VAL GENMASK_ULL(63, 0) #define CMN_CONFIG2_WP_MASK GENMASK_ULL(63, 0) =20 @@ -1384,7 +1383,7 @@ static void arm_cmn_claim_wp_idx(struct arm_cmn_dtm *= dtm, arm_cmn_set_wp_idx(hw->wp_idx, pos, wp_idx - CMN_EVENT_EVENTID(event)); } =20 -static u32 arm_cmn_wp_config(struct perf_event *event) +static u32 arm_cmn_wp_config(struct perf_event *event, int wp_idx) { u32 config; u32 dev =3D CMN_EVENT_WP_DEV_SEL(event); @@ -1394,6 +1393,10 @@ static u32 arm_cmn_wp_config(struct perf_event *even= t) u32 combine =3D CMN_EVENT_WP_COMBINE(event); bool is_cmn600 =3D to_cmn(event->pmu)->part =3D=3D PART_CMN600; =20 + /* CMN-600 supports only primary and secondary matching groups */ + if (is_cmn600) + grp &=3D 1; + config =3D FIELD_PREP(CMN_DTM_WPn_CONFIG_WP_DEV_SEL, dev) | FIELD_PREP(CMN_DTM_WPn_CONFIG_WP_CHN_SEL, chn) | FIELD_PREP(CMN_DTM_WPn_CONFIG_WP_GRP, grp) | @@ -1401,7 +1404,9 @@ static u32 arm_cmn_wp_config(struct perf_event *event) if (exc) config |=3D is_cmn600 ? CMN600_WPn_CONFIG_WP_EXCLUSIVE : CMN_DTM_WPn_CONFIG_WP_EXCLUSIVE; - if (combine && !grp) + + /* wp_combine is available only on WP0 and WP2 */ + if (combine && !(wp_idx & 0x1)) config |=3D is_cmn600 ? CMN600_WPn_CONFIG_WP_COMBINE : CMN_DTM_WPn_CONFIG_WP_COMBINE; return config; @@ -1898,12 +1903,14 @@ static int arm_cmn_event_add(struct perf_event *eve= nt, int flags) input_sel =3D CMN__PMEVCNT0_INPUT_SEL_XP + dtm_idx; } else if (type =3D=3D CMN_TYPE_WP) { int tmp, wp_idx; - u32 cfg =3D arm_cmn_wp_config(event); + u32 cfg; =20 wp_idx =3D arm_cmn_find_free_wp_idx(dtm, event); if (wp_idx < 0) goto free_dtms; =20 + cfg =3D arm_cmn_wp_config(event, wp_idx); + tmp =3D dtm->wp_event[wp_idx ^ 1]; if (tmp >=3D 0 && CMN_EVENT_WP_COMBINE(event) !=3D CMN_EVENT_WP_COMBINE(cmn->dtc[d].counters[tmp])) --=20 2.43.0