From nobody Mon Feb 9 03:46:58 2026 Received: from forward100b.mail.yandex.net (forward100b.mail.yandex.net [178.154.239.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9B0E12F59C; Thu, 28 Mar 2024 15:00:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.154.239.147 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711638050; cv=none; b=MG+WVrEv/OySqbpaGcf1Dz79evrAgfX/ysL0wsBqRc/cF0HRCcp5xx3vo4X/IgB0KgeoIvyaGKQz7DXT9jy3xSDPKMzEty16ohQVvJUL55OzXefABtJL7hS5XAALJ49ZsZizZqBW1ziuNeRPrE8YIefrLzqaS7uY0vktM7a4XIY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711638050; c=relaxed/simple; bh=RPApgADsKlI29chKvdFy7O12Bng/LmzDghTbECdn9Sg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=hO6h4aJEtPPkDNIPDl9nNuRfcL1kuRz8V0jiguTj/5jWgmOpm8bVVAF3qoqJsYDsejPe81K7WUuLKIhf0jlc+qI8v0zcFvbq2VRxnAx6uI/YKCVLbG7pVFhG/U7bZyzYbyfbJHPH5spsG4Tvx9vvTxsn7NgqyWqoySuIoeDwWLQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=yandex.ru; spf=pass smtp.mailfrom=yandex.ru; dkim=pass (1024-bit key) header.d=yandex.ru header.i=@yandex.ru header.b=FdWvpB8g; arc=none smtp.client-ip=178.154.239.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=yandex.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=yandex.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=yandex.ru header.i=@yandex.ru header.b="FdWvpB8g" Received: from mail-nwsmtp-smtp-production-main-44.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-44.sas.yp-c.yandex.net [IPv6:2a02:6b8:c24:a33:0:640:d837:0]) by forward100b.mail.yandex.net (Yandex) with ESMTPS id 4A4E260B30; Thu, 28 Mar 2024 18:00:44 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-44.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id W0PPosAetiE0-QIB3q1ZZ; Thu, 28 Mar 2024 18:00:43 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1711638043; bh=EhuReZ9ZlrI84XoRVD7915LFMz58XbYYesStZiY24qI=; h=Message-Id:Date:Cc:Subject:To:From; b=FdWvpB8gA8a2Kh3dRx5zF7roYDfXz6QoaoH/oQ0RRs7FnSwQeF1fLGnilBQrD1I7/ 62j/erUwvTIPDN9sIx603VpSAooEQe1p6AKzOXKYQi9rAXN6/AFyBqnEckY54Pqira l+5ufyhOxqPesjMjr0QIHxbSoIeuu7uxsQ62kwUs= Authentication-Results: mail-nwsmtp-smtp-production-main-44.sas.yp-c.yandex.net; dkim=pass header.i=@yandex.ru From: Mikhail Ukhin To: Jens Axboe Cc: Mikhail Ukhin , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Damien Le Moal , Niklas Cassel , Pavel Koshutin , Artem Sadovnikov , Mikhail Ivanov Subject: [PATCH 5.10/5.15] ata: libata-scsi: check cdb length for VARIABLE_LENGTH_CMD commands Date: Thu, 28 Mar 2024 18:00:26 +0300 Message-Id: <20240328150026.9129-1-mish.uxin2012@yandex.ru> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fuzzing of 5.10 stable branch reports a slab-out-of-bounds error in ata_scsi_pass_thru. The error is fixed in 5.18 by commit ce70fd9a551a ("scsi: core: Remove the cmd field from struct scsi_request"). Backporting this commit would require significant changes to the code so it is bettter to use a simple fix for that particular error. The problem is that the length of the received SCSI command is not validated if scsi_op =3D=3D VARIABLE_LENGTH_CMD. It can lead to out-of-boun= ds reading if the user sends a request with SCSI command of length less than 32. Found by Linux Verification Center (linuxtesting.org) with Syzkaller. Signed-off-by: Artem Sadovnikov Signed-off-by: Mikhail Ivanov --- drivers/ata/libata-scsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index dfa090ccd21c..77589e911d3d 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -4065,6 +4065,9 @@ int __ata_scsi_queuecmd(struct scsi_cmnd *scmd, struc= t ata_device *dev) =20 if (unlikely(!scmd->cmd_len)) goto bad_cdb_len; + + if (scsi_op =3D=3D VARIABLE_LENGTH_CMD && scmd->cmd_len < 32) + goto bad_cdb_len; =20 if (dev->class =3D=3D ATA_DEV_ATA || dev->class =3D=3D ATA_DEV_ZAC) { if (unlikely(scmd->cmd_len > dev->cdb_len)) --=20 2.25.1