From nobody Wed Feb 11 16:13:49 2026 Received: from mail.nfschina.com (unknown [42.101.60.195]) by smtp.subspace.kernel.org (Postfix) with SMTP id E4E59620; Thu, 28 Mar 2024 02:07:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=42.101.60.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711591669; cv=none; b=Z8TveiXRFuO864qwNTZNL6ZuXnjPBLvua8/lyGtloofPzshwp8KU5RbLFGPCFxHilCAnKfm28fb/S9LXlu80j0OpwrpHlUv4lQUsMi+dqCwPlc+PoivVWkTzpmute0R+MWREvUquZqxtMBbtzlP5eHTdc1hOrYqilOcNmU1e2Bw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711591669; c=relaxed/simple; bh=W59iAixxKMRITZtWi4r4Zv1UlK9ER3507kDtvYW941c=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=W4M2w+ThUCs1EsZtxKxJU+drB4etTDpAgD8LGnVSuwFBZRab19CFsVsD/AXsCMaRYCE4swruZAzoT3AFdZ+/MLmYyb5zVXsfjBPmGEjIKwHeDaK+BVzzqCBs0KJVxpYHxV23qnexhN0NBvPqSeyXy6bPk/HcJYtyZ+nWlrK7dBg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nfschina.com; spf=pass smtp.mailfrom=nfschina.com; arc=none smtp.client-ip=42.101.60.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nfschina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nfschina.com Received: from localhost.localdomain (unknown [180.167.10.98]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPSA id 0D325609FFAF1; Thu, 28 Mar 2024 10:07:42 +0800 (CST) X-MD-Sfrom: suhui@nfschina.com X-MD-SrcIP: 180.167.10.98 From: Su Hui To: sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com, hkelam@marvell.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, nathan@kernel.org, ndesaulniers@google.com, morbo@google.com, justinstitt@google.com Cc: Su Hui , dan.carpenter@linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, kernel-janitors@vger.kernel.org Subject: [PATCH net-next v3] octeontx2-pf: remove unused variables req_hdr and rsp_hdr Date: Thu, 28 Mar 2024 10:07:24 +0800 Message-Id: <20240328020723.4071539-1-suhui@nfschina.com> X-Mailer: git-send-email 2.30.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Clang static checker(scan-buid): drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c:503:2: warning: Value stored to 'rsp_hdr' is never read [deadcode.DeadStores] Remove these unused variables to save some space. Signed-off-by: Su Hui Reviewed-by: Simon Horman --- v3: - using net-next in subject - split the v2 patchset into individual patches v2: - add "net" in subject drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers= /net/ethernet/marvell/octeontx2/nic/otx2_pf.c index 3f46d5e0fb2e..637b05c79c42 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c @@ -450,7 +450,6 @@ static void otx2_pfvf_mbox_handler(struct work_struct *= work) struct mbox_msghdr *msg =3D NULL; int offset, vf_idx, id, err; struct otx2_mbox_dev *mdev; - struct mbox_hdr *req_hdr; struct otx2_mbox *mbox; struct mbox *vf_mbox; struct otx2_nic *pf; @@ -461,9 +460,8 @@ static void otx2_pfvf_mbox_handler(struct work_struct *= work) =20 mbox =3D &pf->mbox_pfvf[0].mbox; mdev =3D &mbox->dev[vf_idx]; - req_hdr =3D (struct mbox_hdr *)(mdev->mbase + mbox->rx_start); =20 - offset =3D ALIGN(sizeof(*req_hdr), MBOX_MSG_ALIGN); + offset =3D ALIGN(sizeof(struct mbox_hdr), MBOX_MSG_ALIGN); =20 for (id =3D 0; id < vf_mbox->num_msgs; id++) { msg =3D (struct mbox_msghdr *)(mdev->mbase + mbox->rx_start + @@ -494,7 +492,6 @@ static void otx2_pfvf_mbox_up_handler(struct work_struc= t *work) struct otx2_nic *pf =3D vf_mbox->pfvf; struct otx2_mbox_dev *mdev; int offset, id, vf_idx =3D 0; - struct mbox_hdr *rsp_hdr; struct mbox_msghdr *msg; struct otx2_mbox *mbox; =20 @@ -502,8 +499,7 @@ static void otx2_pfvf_mbox_up_handler(struct work_struc= t *work) mbox =3D &pf->mbox_pfvf[0].mbox_up; mdev =3D &mbox->dev[vf_idx]; =20 - rsp_hdr =3D (struct mbox_hdr *)(mdev->mbase + mbox->rx_start); - offset =3D mbox->rx_start + ALIGN(sizeof(*rsp_hdr), MBOX_MSG_ALIGN); + offset =3D mbox->rx_start + ALIGN(sizeof(struct mbox_hdr), MBOX_MSG_ALIGN= ); =20 for (id =3D 0; id < vf_mbox->up_num_msgs; id++) { msg =3D mdev->mbase + offset; --=20 2.30.2