From nobody Sat Feb 7 19:41:12 2026 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFBB21509AE for ; Wed, 27 Mar 2024 19:10:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711566616; cv=none; b=JBf74F4mT7LBz+cuEm3brqEH6bOQOgjJZZKX3RTe3K5DTA1iYKBzwDR7DUkCqAHxEqg5z+5Hgsl91V+XniwyHboJheF5jYdSmgbkPL7Ugu8FfL7x5rsRJRRiaIpAetyoLc1uIZwSQv472LDvSmPvmSMW6Fi8cHqzYviZkmkhL+Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711566616; c=relaxed/simple; bh=2ZKwNze6O6FHYLv0ZmDp5vBMzHN4+fjn61h42zC6U0k=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gCdcZTneqMFCji23ZCD60gL8vssVJfpA4VDOp3Oy7dT7D9Fv2dvT1IrDXM0HS3NUi9QpehZfN0nj4KJjVxwHL6s6lfCXbWegVnaqAgYW5oD42JHbEQBE8Ym2B9Rn8rrVdV/iXJCOjWxgA2Swt5DSt8IvsvQog8EnAG9ucAfeK74= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Xz3fHk96; arc=none smtp.client-ip=209.85.219.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xz3fHk96" Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-696315c9da5so1277346d6.2 for ; Wed, 27 Mar 2024 12:10:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711566614; x=1712171414; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=x2mei3j/lcrSSTisR+Uqzrn/InZyJ99Sff97ygb+XVk=; b=Xz3fHk96bZxyMAT7iBYRvgZSve/pjKRvNqOenJO90WBv9AB79m3L0FDtM2ypWbgUrh KNW1JTs17qJj4Hp9wBADLcedAe1PwgqQPgHBEM74zBMXlTwZ65Q2WVG/8ZKnRdLAoRSx 5D0sjsents1LvQu04mBQX+iCLKQIbg+qAtiuugP9sHQsQLgc56LSZW2sua+TcAu6Vcx1 apgV/nQH23UJra+zxaMhU0uFxNEFMH5sSE7wU2sHt9MxlHL5ODF8Q67iNa7iBHOZUQJb PBA+TAgVcVYhL5Nj+A7yBB3E6gVO6Kgr9ULSGNjhKzKdeHehdtPnNe6zdhAK3zQnyTTj vUUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711566614; x=1712171414; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x2mei3j/lcrSSTisR+Uqzrn/InZyJ99Sff97ygb+XVk=; b=GbJ6QcIJO0JYMOMbW0r8qt/Bxvfoll4OGgSBmekCOk0LJReK2jdR0DCEIF11TJ9TOh eJUwdhT0mblEiiSH6tMio9QE8wGKkhOQn+SpUY3Mu+KVhfEZI1938QQlJYonh282G/wZ 1QxpOoM8PpCGU5CSE0vO6F9iQgfdyXNjqyluUd9iUD6GXrjHSVfoixIq/heDdaxKeGXE aaGMdffYGo7c+v8gNdCeg1NHzaaGX4ThFJTtosIt2hqs0pHN/SbujGN0m6O8a2b18ahG z0kTZpJLJ9o+00q5odh2bnkh+cnVbhJzvAkK0CNdOABijkse7xTV/ZoQ4yK8UD5AXhSD 1jig== X-Forwarded-Encrypted: i=1; AJvYcCURLXOr0ocGi6aFCDZEsomEMn3PcPBnHbVREJP6oh4GgFQdYci7w11WbVrlE97wVerg+ANOVa3LNn3rdxMFn3VAIf4FECDEhHXj19DO X-Gm-Message-State: AOJu0Yx+KJjMmXEjLkuSbgI1X1iWaBA4vFGJO4UITYWOuGbcM6Yayqq+ vuPXNZo9iKELtQOkmEEUcv/xBxh/nZpo+66+KYUp87kdDfm3QV87OryURiQJ X-Google-Smtp-Source: AGHT+IE7DncV9RK/Fz3ApyzCE9YenBkZ2tRm5kS5LFTI0MF4BpFfqfBtyqdxgHF+2EsItosROiEsuA== X-Received: by 2002:a05:6214:5287:b0:696:77a8:9135 with SMTP id kj7-20020a056214528700b0069677a89135mr515196qvb.32.1711566613832; Wed, 27 Mar 2024 12:10:13 -0700 (PDT) Received: from YOGA.local ([2a06:c701:736b:f200:f38a:32d3:e6f6:959]) by smtp.gmail.com with ESMTPSA id 10-20020a05621420ea00b00696a1f5dd18sm1784789qvk.116.2024.03.27.12.10.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 12:10:13 -0700 (PDT) From: Shahar Avidar To: gregkh@linuxfoundation.org, elder@linaro.org, andriy.shevchenko@linux.intel.com, robh@kernel.org, parthiban.veerasooran@microchip.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/3] staging: pi433: Use headers in appropriate files. Date: Wed, 27 Mar 2024 21:10:02 +0200 Message-Id: <20240327191004.619748-2-ikobh7@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240327191004.619748-1-ikobh7@gmail.com> References: <20240327191004.619748-1-ikobh7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Ensure rf69.c directly includes rf69_enum.h. Move rf69_registers.h from header to the relevant source file. Reviewed-by: Andy Shevchenko Signed-off-by: Shahar Avidar --- v2->v3: Restore Reviewed-by tag. drivers/staging/pi433/pi433_if.c | 1 + drivers/staging/pi433/rf69.c | 1 + drivers/staging/pi433/rf69.h | 1 - 3 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433= _if.c index 81de98c0245a..0c12b31c4642 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -45,6 +45,7 @@ =20 #include "pi433_if.h" #include "rf69.h" +#include "rf69_registers.h" =20 #define N_PI433_MINORS BIT(MINORBITS) /*32*/ /* ... up to 256 */ #define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */ diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index 5a1c362badb6..bf802f097310 100644 --- a/drivers/staging/pi433/rf69.c +++ b/drivers/staging/pi433/rf69.c @@ -11,6 +11,7 @@ #include =20 #include "rf69.h" +#include "rf69_enum.h" #include "rf69_registers.h" =20 #define F_OSC (32 * HZ_PER_MHZ) diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h index 76f0f9896a52..dd6fa8af9b9c 100644 --- a/drivers/staging/pi433/rf69.h +++ b/drivers/staging/pi433/rf69.h @@ -9,7 +9,6 @@ #define RF69_H =20 #include "rf69_enum.h" -#include "rf69_registers.h" =20 #define FIFO_SIZE 66 /* bytes */ =20 --=20 2.34.1 From nobody Sat Feb 7 19:41:12 2026 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E720015217E for ; Wed, 27 Mar 2024 19:10:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711566618; cv=none; b=m1k//QjVvdF3xD4eQz3oO/6OM7szj+702GFcglfDntiaUwhZuJMhmznXmH6L7uQt6lg18/8G8PXNy20Uc6wXi2FIJ95h+1ViacQ5qdmcMXLkJd4lvU6Y2V91kG8C5tCdIFOoGldequV0f+KzOb+3GJWF5M256yIVTvxzcxIQa64= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711566618; c=relaxed/simple; bh=2P53dqZLCQDgClrPxw8cwYgJMflZz0YJKHxb+dxtGz4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YmKpqk2lFjHSuOa/6u3Y4ndvsG0Wb98nk3mdtgEmBWf2TZTBm+gHp5+vlhIuqwNizW7K5NhEmsxLGYDtKyiNNvmHnOj4iyQjPjgA8TTgwUowfWuthSCtzdAN+qw7LBDrLqf/bQr0Yb4cBYNbwZ3USX61zkdeMHrhVfLqUWyuY54= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Yh1Vm78d; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yh1Vm78d" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-78a3bccc420so7207085a.1 for ; Wed, 27 Mar 2024 12:10:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711566616; x=1712171416; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+OJvFLyFknhUDss3UMv5MZgT0NYrVcq8IA8NPybvW4I=; b=Yh1Vm78dmyp73VkevfaG+nYGvtESO6LIEovemiUzn4Qrii+PwCxfqokJYPz/Sw+SJV 2hb3xWJ3Hc1cUnAh0SW+OVp+SIWRpetQY10D5Sqm74mAKRwCl8hXH7f8wIwkoBPOZJc+ OcJ7YvS9QT9Np+3tt0ImLpYS0yxxmXSMEg7lsxa/FRd9cCn3BAn4xp1jtP17LZZ5bK/r 5zS6cv6/IlQw+6rtdsIPPGYDnK7a+76fGM9wM8Qo7k1JTK+t0hobvBHiIwqSUxuY5k1H e/i9bo58FFl1CmpCnyfqxC4zlz/BWVgdXF6AS1+y5mGSFZKtiGZPeJUkhFSE2zYtCV2f XKOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711566616; x=1712171416; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+OJvFLyFknhUDss3UMv5MZgT0NYrVcq8IA8NPybvW4I=; b=AU/J1maoLa7W0xOtaqGp2d9sB2tCnkGasOYV+QpYws0Dx0MZjIxUCuoRDV/jrwjTLD 1aniE4cLqtREL2+iLDzFjfU5VG4Cfdfu2WIOv+YoZR1izQZ8Uq8MXuwN3Gv40s19gnvR 2NA6+EW6rzLnxweqJxbsyjlXMx8DeTFGX9ldc2dC4mQToA/qFT4agFWGrTTWFLwEKM0i c0FGk6UxlryvajvRZOuzB2KCJ37g6To1rdz/Bjk5VKOks5B7QymjDFlBb1oX+LyKv7sk 8uxJ10fCCkMPgeOYIq9K8XknQ5+mXBp3ozH2+hhn0GRrz/cJ9Itvt6LepIOSsNhXShRw hOHg== X-Forwarded-Encrypted: i=1; AJvYcCUEhmFurhVqAQ2EIqgtK4sEs63Yz7EW3cxFAeBDVe0ayYc4Fk7Poj8JTWibBJR/avbYSWP3u4ndGV0cxBoZxBJ9drMK3cbiYg4tttHB X-Gm-Message-State: AOJu0Yyar21IcNsFJDbsWUZ57L7Dpeq78SmAvXJHAjG5Nda6l8pLVXaF eiSIjelzWYQ37ogTd5C8fa/NNEQqQss6yNyg/k7AKurS/FOP6IJMgmzLt3V8 X-Google-Smtp-Source: AGHT+IGiE1RuN1c9CUcRzRJsXLn7mb71lrh5W4dd3z2jLlJLq3px/AkdtBHo967VE8WV3ZXbJkMCPQ== X-Received: by 2002:a0c:ea25:0:b0:690:a800:8ffa with SMTP id t5-20020a0cea25000000b00690a8008ffamr541916qvp.31.1711566615922; Wed, 27 Mar 2024 12:10:15 -0700 (PDT) Received: from YOGA.local ([2a06:c701:736b:f200:f38a:32d3:e6f6:959]) by smtp.gmail.com with ESMTPSA id 10-20020a05621420ea00b00696a1f5dd18sm1784789qvk.116.2024.03.27.12.10.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 12:10:15 -0700 (PDT) From: Shahar Avidar To: gregkh@linuxfoundation.org, elder@linaro.org, andriy.shevchenko@linux.intel.com, robh@kernel.org, parthiban.veerasooran@microchip.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/3] staging: pi433: Remove an inaccurate comment. Date: Wed, 27 Mar 2024 21:10:03 +0200 Message-Id: <20240327191004.619748-3-ikobh7@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240327191004.619748-1-ikobh7@gmail.com> References: <20240327191004.619748-1-ikobh7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The comment specified the wrong number represented by the macro. Signed-off-by: Shahar Avidar --- v1->v2: Undo macro change. Remove comment instead. drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433= _if.c index 0c12b31c4642..ec9f07a4f769 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -47,7 +47,7 @@ #include "rf69.h" #include "rf69_registers.h" =20 -#define N_PI433_MINORS BIT(MINORBITS) /*32*/ /* ... up to 256 */ +#define N_PI433_MINORS BIT(MINORBITS) #define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */ #define MSG_FIFO_SIZE 65536 /* 65536 =3D 2^16 */ #define FIFO_THRESHOLD 15 /* bytes */ --=20 2.34.1 From nobody Sat Feb 7 19:41:12 2026 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF83F152501 for ; Wed, 27 Mar 2024 19:10:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711566620; cv=none; b=t9azNi6clozTiZ8Hg2aWMZPvT0+0RBfOmd3u/aqxgaRU9lQIKnafy9CR5FiWWENp/b6QWu+SFVTJLAB/Rseol+ihPI3Z1v4Najwxk2YB1B2Qh055UdBm5a/CTmxm4O2Zu7WMhvCVz7ZHHWR5WfLW2sPtZJJzqNn/cc6o1PKkzRs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711566620; c=relaxed/simple; bh=MTdEjm1D0/qfOUg6cYn6umc0lnlr1h8xueLvXHiRnPA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=IX5S6oqkz+ia7+tunasPKfaRqgBsOc2WHwBfGIa1u1n9Yrf2ok9CpSvZcvj/dr5i72OwlzKHbKZ0QAZtUhfo9iz0RzwtH7SZnAzg1QOeC/jaz7t+5iLL7Sdtfo6Z0OGpGXycD9vR4rgWmZqkj3V36Hat/BUZMITkzXt4MhzGMiE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Hu0HaW/Y; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Hu0HaW/Y" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-78a3ca01301so6861785a.1 for ; Wed, 27 Mar 2024 12:10:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711566618; x=1712171418; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y/twuRh0ETjmablTSqJuv3fOjHccwwgmOmFpCl7pqqQ=; b=Hu0HaW/YEAcjKf1tfTIZ3AcrjLa8qIjIcVNLfwaueuhidr4P8R8x+NDdF24OHUPlbC 0wFrYzmXAl/diqMeqskshkjG/lNJqTM01RobvD0ucuboCCIco50+glgrb+7MvpmdkTJQ rP/wxFNYUgx7/vWFXTCympTxBK9RJc/WOLjK1SlCGOSx2Li+0uEGB3B3BzQa7V3qZWOm b4KBBh/Bz8ZP4Epxlw62l5fzpa0GBkxldin4SOkibz+tQNYrKbr0A2WLK8VO9YyfRwp4 GJe/v94OnfUDcmHDkI7S61iWLfeqkSoJ9X/UEBsEXZfQMuVeXQHPV8a3gUhkC67BCJv7 sGXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711566618; x=1712171418; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y/twuRh0ETjmablTSqJuv3fOjHccwwgmOmFpCl7pqqQ=; b=Wtl7bs1yfM0K+nGBpwxywknn+7PujJu7wugao2MZRiFPj6mepa3A+taD2peMxfuvyP LVmpPhZkq58OdQTXviCo7V08/iBj7Y1PF5TqBjqiKkjNtKV3PeqxsUnd7KaA51sBJmAQ avPEC1YPUliy2tiPXX+dZosReRLYhca2rXdxOJBeOep+25imgspCZGYoM5TPFN6xjs8E SnfnczGfX5C/W6SxkyuP2c+RDKjOwQ2yplweXXiuoABiwtYXp2uuA7RxEliz6Np0ZUEx bQEgiBiv/Gn+3hKPIHVvo/d+EnrBBd3mOI5UzC3cDuGofXsHGLrxYFWkpcRLtgeGvNqc nVlw== X-Forwarded-Encrypted: i=1; AJvYcCXymdh4XS3WIS+OHWGx/C/0hzIYa74EBwSgSgiPFzfFGFW66ie1U29EWN0GhsIVmoIrsJi9w2TQ4ZNOfuMImHl0v7LdQgtzVlM9ROIV X-Gm-Message-State: AOJu0YxYHA0HmMCr4qP8WzXqQ4sqDvGokUeDJ1JtBekAuS3D5f684bi8 DWUpvPgv9vsPUmLa4d7Bf8fRLbXwyZpCzzHgOQqHMA8RWKkPuP+x X-Google-Smtp-Source: AGHT+IE7JAxxL25TeM7aqNrXRdLtjlqymQo3Q6QG0/xIfJgEB8sxYSZxlmv0Xnp5rIHt2GSzSS0xnA== X-Received: by 2002:a05:6214:4c09:b0:696:b2a9:a2ae with SMTP id qh9-20020a0562144c0900b00696b2a9a2aemr475829qvb.6.1711566617988; Wed, 27 Mar 2024 12:10:17 -0700 (PDT) Received: from YOGA.local ([2a06:c701:736b:f200:f38a:32d3:e6f6:959]) by smtp.gmail.com with ESMTPSA id 10-20020a05621420ea00b00696a1f5dd18sm1784789qvk.116.2024.03.27.12.10.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 12:10:17 -0700 (PDT) From: Shahar Avidar To: gregkh@linuxfoundation.org, elder@linaro.org, andriy.shevchenko@linux.intel.com, robh@kernel.org, parthiban.veerasooran@microchip.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3 3/3] staging: pi433: Make use of spi mode macro instead of magic number. Date: Wed, 27 Mar 2024 21:10:04 +0200 Message-Id: <20240327191004.619748-4-ikobh7@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240327191004.619748-1-ikobh7@gmail.com> References: <20240327191004.619748-1-ikobh7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use SPI_MODE_0 to setup spi mode. Reviewed-by: Andy Shevchenko Signed-off-by: Shahar Avidar --- v2->v3: Restore Reviewed-by tag. =20 drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433= _if.c index ec9f07a4f769..8c513ac62156 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -1164,7 +1164,7 @@ static int pi433_probe(struct spi_device *spi) struct dentry *entry; =20 /* setup spi parameters */ - spi->mode =3D 0x00; + spi->mode =3D SPI_MODE_0; spi->bits_per_word =3D 8; /* * spi->max_speed_hz =3D 10000000; --=20 2.34.1