From nobody Mon Feb 9 05:38:45 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90D1C131732 for ; Wed, 27 Mar 2024 15:48:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711554501; cv=none; b=VS1lmQlJ/i4tfEhm422EukChvRV4GSWJtr1VlaFZRLzXFFoI74Yx/MoW+b/4FxL+AjaTSuwdb+WSS8VHoPFozYWJgtLR4XZZ1LPb2z6Aai4CywpmQb8h598rwzjGMKljSAfvtoM6oxQSdAS0xWwaHg1QQF0wpYjY5RLAEYKx1+k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711554501; c=relaxed/simple; bh=kxw8lEOeXnx/duF9z7ST9TT/zC6EoGrvtJe8oJFI1B0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=F1hOieLV/PYxIiL5qF3GJFnV8DCni4bXu3QpWkc1wsHSVNFUCk+VYDWS9k72ggM1bcmUBp4qkqzKNLY4V8t4ZBJj7+rMsAFOtm7J9HjDE+jT1FrduRfNzoRR4LulFK2R16f40bUAVpmzxTml4pBtlbxIE3Nb2ZEPnFbbnLRcOIs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Sr1y1Cuu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Sr1y1Cuu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A95BC433C7; Wed, 27 Mar 2024 15:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711554501; bh=kxw8lEOeXnx/duF9z7ST9TT/zC6EoGrvtJe8oJFI1B0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Sr1y1Cuu9f/Se064mDUn1HaCUkTnbO9IBcwOnhO4s3a/Mlvj19hhrxttE8kNOJA1i zW0nSCuYqRkkblNx79/0IToZ+uYKPrVtK/RsRTGET65JvBUlbnBr+xnURpFy6E9uEO Jsc+HyY1Qqo4OpmJ5FHxS0LBgybRWxjAhhIC2DbLn+PzW/Mry+jN1z3i0/FuRNrs0A T0BNpgtrWjidXAsNZVrDC5m0wr0xCw1IWoUuwrYkFCsnQe19gwecezPAQgkZcYdkCK Jl7Orhrx+qfMJ4Tv93a6bLdHSbX/8kFx+KwKZCKZ40GSm5YwG8T0gWZ6tGf2kVX46Y V+Yf/i5ucujfA== From: Jisheng Zhang To: Paul Walmsley , Palmer Dabbelt , Albert Ou , Daniel Lezcano , Thomas Gleixner Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] clocksource/drivers/timer-riscv: Add set_state_oneshot_stopped Date: Wed, 27 Mar 2024 23:35:00 +0800 Message-ID: <20240327153502.2133-2-jszhang@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240327153502.2133-1-jszhang@kernel.org> References: <20240327153502.2133-1-jszhang@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" To avoid spurious timer interrupts when KTIME_MAX is used, we need to configure set_state_oneshot_stopped(). Although implementing this is optional, it still affects things like power management for the extra timer interrupt. Check commit 8fff52fd5093 ("clockevents: Introduce CLOCK_EVT_STATE_ONESHOT_STOPPED state") for more information. Signed-off-by: Jisheng Zhang --- drivers/clocksource/timer-riscv.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/clocksource/timer-riscv.c b/drivers/clocksource/timer-= riscv.c index 48ce50c5f5e6..e661fc037337 100644 --- a/drivers/clocksource/timer-riscv.c +++ b/drivers/clocksource/timer-riscv.c @@ -69,11 +69,12 @@ static int riscv_clock_shutdown(struct clock_event_devi= ce *evt) =20 static unsigned int riscv_clock_event_irq; static DEFINE_PER_CPU(struct clock_event_device, riscv_clock_event) =3D { - .name =3D "riscv_timer_clockevent", - .features =3D CLOCK_EVT_FEAT_ONESHOT, - .rating =3D 100, - .set_next_event =3D riscv_clock_next_event, - .set_state_shutdown =3D riscv_clock_shutdown, + .name =3D "riscv_timer_clockevent", + .features =3D CLOCK_EVT_FEAT_ONESHOT, + .rating =3D 100, + .set_next_event =3D riscv_clock_next_event, + .set_state_shutdown =3D riscv_clock_shutdown, + .set_state_oneshot_stopped =3D riscv_clock_shutdown, }; =20 /* --=20 2.43.0 From nobody Mon Feb 9 05:38:45 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14496131E3E for ; Wed, 27 Mar 2024 15:48:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711554504; cv=none; b=Xb28kA8aiPnfzGgCEEHELjYbOr2kxfIPFneXjHDqp5HmNSIoPzx1jsndjBXD8hrzDbqu9/GXmrPHmr4bL5tkjsG6F+PGC5oEPaSwqxkWY/OgYhRMmlFlu4AdO8OKrMKxklPV0Zct0oz7KBajYsiFLwF5X1E4/sOWbGDGtjeW8JQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711554504; c=relaxed/simple; bh=Nw3gMFJ/F/poxLbQzgT93Y2Pv42axzvi9HneGeq24nc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=U18ZXFUJali/4RC5e4e4281FkIBVRxQXXUo01zO2kipN3wof/asAvYMN/nxf7u5jpp1mEUcYaKjE/nYGO7BguE8NCuOBTw2o78zzLxKrzctLjG1/Iz5DqHCTg/qswiTRw8MB5/t+FyU+vcojpgVUaS+BLG0k31iBa0xR04PEEzc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=R3vctCY4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="R3vctCY4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1735C433B1; Wed, 27 Mar 2024 15:48:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711554503; bh=Nw3gMFJ/F/poxLbQzgT93Y2Pv42axzvi9HneGeq24nc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R3vctCY4JRAjYtkAQ9qoJRjfijrTnXvrV+n2Bi6grrTy1C/hCrBQNQG75kqU5pou4 7HdzjXIGxIkOXUPUHLVfmemuWs0TkX99r1f1H1fj0v4Uw1DEX5qdpI0vkB0B24c4K4 Wi4eRQG1SFM+SfTggRlSwzW35E9NbQ/cmsn5JRCyFBavzMNy7Wmbv3EVj8+re/UTf9 P5FaRh5UZ5/zqd3g9RdGF7P8DNji083zB77mImuMUIuYHmg9bVzS3QN4FPvoHPMYiw e8hxkUty/1x8LVKowUWEyj73DMCRqsZXOrWL/MRc0NYyDMqS9vv5N49fliBRdZg4wu 74mtVZw54zisg== From: Jisheng Zhang To: Paul Walmsley , Palmer Dabbelt , Albert Ou , Daniel Lezcano , Thomas Gleixner Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] clocksource/drivers/timer-clint: Add set_state_shutdown Date: Wed, 27 Mar 2024 23:35:01 +0800 Message-ID: <20240327153502.2133-3-jszhang@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240327153502.2133-1-jszhang@kernel.org> References: <20240327153502.2133-1-jszhang@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add clocksource detach/shutdown callback to disable RISC-V timer interrupt = when switching out clockevent from clint timer to another timer. Signed-off-by: Jisheng Zhang --- drivers/clocksource/timer-clint.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/clocksource/timer-clint.c b/drivers/clocksource/timer-= clint.c index 09fd292eb83d..56cf6c672e6d 100644 --- a/drivers/clocksource/timer-clint.c +++ b/drivers/clocksource/timer-clint.c @@ -119,11 +119,21 @@ static int clint_clock_next_event(unsigned long delta, return 0; } =20 +static int clint_clock_shutdown(struct clock_event_device *evt) +{ + void __iomem *r =3D clint_timer_cmp + + cpuid_to_hartid_map(smp_processor_id()); + + writeq_relaxed(ULONG_MAX, r); + return 0; +} + static DEFINE_PER_CPU(struct clock_event_device, clint_clock_event) =3D { - .name =3D "clint_clockevent", - .features =3D CLOCK_EVT_FEAT_ONESHOT, - .rating =3D 100, - .set_next_event =3D clint_clock_next_event, + .name =3D "clint_clockevent", + .features =3D CLOCK_EVT_FEAT_ONESHOT, + .rating =3D 100, + .set_next_event =3D clint_clock_next_event, + .set_state_shutdown =3D clint_clock_shutdown, }; =20 static int clint_timer_starting_cpu(unsigned int cpu) --=20 2.43.0 From nobody Mon Feb 9 05:38:45 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E45F1327FC for ; Wed, 27 Mar 2024 15:48:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711554506; cv=none; b=mr4/aYVb2Jj51wkLmFfHkLDYEwSuBRbVQL+EpqCSPYqYJ58UgFpuLuPHNbpKfHZ2dGQ964tE5xx0JNbm0ojvQPqmyx8tLXj+b+ifXPSQ88aErSvXKBJNYFINHU+REKdKVCprCRQCZR5sLspv+XNHJW6E7sULbQGWZviuM/bR6w4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711554506; c=relaxed/simple; bh=G8Du/nKE3EQGqBI4paXDN1AIdNVl4glAliWu+H6P45c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=s8GrVma+9ZlVg7+CztTI4+kpsChSFvIZYAh0sXQMDSwRHO3sHKkw7VowYrrrP56+7Zh1gcrPhymfLOCwd+KEO0iYqFKFQZuPqz03DSbqzGMfW0vmy86XaF/Xx4TugFAH/rJ1VSCLG4f6kVRochJ54MjUqQhPS7rscrYs4SWD7M0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rJaykR9+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rJaykR9+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16D24C433F1; Wed, 27 Mar 2024 15:48:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711554505; bh=G8Du/nKE3EQGqBI4paXDN1AIdNVl4glAliWu+H6P45c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rJaykR9+OUNmZr8FxTeTlU3uWMWDqdwYbp3icdv9jf2Q6hJMBgQDEBGpikt5hRtAf 6La3dI3Nq+RMa6s+5yvwewnzw/JWkIbLhukmqq88cKYBgWA56MFnJxYJhIzMCCsrT2 tdnL14om1dRM4/C9RQxh1xS4SJzqci0pX/fYmssovPrdEpAZMqbn7/lp2XLV1/dygo EysNPjAnNgZK+erhl7WXhr0hfGBWQCY+0wU14BCX9wAa3Y4YXsYbJ/pLBU+c6/WDy1 /xyzq1sIy9qXQAFVpd4QGDCQC3F/7gyOAzQzskObCZ25XfFaGsPFxoSm6YPYymed7k Blh/EcdKYg7og== From: Jisheng Zhang To: Paul Walmsley , Palmer Dabbelt , Albert Ou , Daniel Lezcano , Thomas Gleixner Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] clocksource/drivers/timer-clint: Add set_state_oneshot_stopped Date: Wed, 27 Mar 2024 23:35:02 +0800 Message-ID: <20240327153502.2133-4-jszhang@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240327153502.2133-1-jszhang@kernel.org> References: <20240327153502.2133-1-jszhang@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" To avoid spurious timer interrupts when KTIME_MAX is used, we need to configure set_state_oneshot_stopped(). Although implementing this is optional, it still affects things like power management for the extra timer interrupt. Check commit 8fff52fd5093 ("clockevents: Introduce CLOCK_EVT_STATE_ONESHOT_STOPPED state") for more information. Signed-off-by: Jisheng Zhang --- drivers/clocksource/timer-clint.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clocksource/timer-clint.c b/drivers/clocksource/timer-= clint.c index 56cf6c672e6d..f5c04520d6b1 100644 --- a/drivers/clocksource/timer-clint.c +++ b/drivers/clocksource/timer-clint.c @@ -134,6 +134,7 @@ static DEFINE_PER_CPU(struct clock_event_device, clint_= clock_event) =3D { .rating =3D 100, .set_next_event =3D clint_clock_next_event, .set_state_shutdown =3D clint_clock_shutdown, + .set_state_oneshot_stopped =3D clint_clock_shutdown, }; =20 static int clint_timer_starting_cpu(unsigned int cpu) --=20 2.43.0