From nobody Sat Feb 28 00:52:44 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D77FC18C9E6; Wed, 27 Mar 2024 12:26:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711542407; cv=none; b=gTQdKe6azmPvdTkEQuPevrJl1Njg0HiaWnHkAkMR3X9TD3mBzcmizQYgEI3WPyrPaurFfWifCvx6ZZH6zaUNUigFWGT5UQu47tgde5GkcIW6Njlb3FqioxdsyItQePVs5tIXO14FIc/VLbHsEo0KNBG4K9ARpBpmaFfXbgGwQYg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711542407; c=relaxed/simple; bh=tmi0DDv8RYhN8hfyp5ZBxPv/BlQAcv524yEMtzi6NfY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TMmyPW3GN9nvYminsrw0VRKodg2Zg5wr7UoYjG7Ld/XXZNdEJ1NTxxnVbEvcP0QVcDdTehhc6l3xnqVcXm5fm8HMXlJhDDyiXOYHvPn1CXtAXkrlSEYx3HCu493Nq467A83QqPje6xHhvy0PN1k4g31l4vDbKTSGoFa7Ra8E27s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WskRsreO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WskRsreO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8903DC433F1; Wed, 27 Mar 2024 12:26:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711542407; bh=tmi0DDv8RYhN8hfyp5ZBxPv/BlQAcv524yEMtzi6NfY=; h=From:To:Cc:Subject:Date:From; b=WskRsreOiWQPpEDnWHb5MEtxSfwQLqtyeGzOsFPWlRcxhh+0gPNfK+FOd/xiZam5y h+Co3bde+5YrWv2873GbEJgHRn4yLoAYBoVYrSt8IgG7biMrBa45Yqy9D0vBRXNTGF Xw0qfFkx8r9/JJWKCApk0Dov6dm56vqbKqDLOLJ7t7+cdRslszwUyqp94P82yWtPLZ UpYNZoQCHwJ3l+YB0o17SHodvPnU/1RtV+DpVKxJF/gzRv4AYDMq2hNWppqD4iKkWj DZxYkqgTdi2XDCH/ySwjRrqhpOvxjLrcZXX1R2XfDXCP29vVyd/sMCSH9Mqwp3Lr7K jtG+gc6UTHrRQ== From: Sasha Levin To: stable@vger.kernel.org, srinivasan.shanmugam@amd.com Cc: Aurabindo Pillai , Rodrigo Siqueira , Hamza Mahfooz , Wenjing Liu , Qingqing Zhuo , Alex Deucher , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: FAILED: Patch "drm/amd/display: Fix late derefrence 'dsc' check in 'link_set_dsc_pps_packet()'" failed to apply to 4.19-stable tree Date: Wed, 27 Mar 2024 08:26:45 -0400 Message-ID: <20240327122645.2841343-1-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Hint: ignore X-stable: review Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The patch below does not apply to the 4.19-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . Thanks, Sasha Reviewed-by: Aurabindo Pillai ------------------ original commit in Linus's tree ------------------ From 166225e79ccc3d02c4c46e1b3c09d03eb91473ca Mon Sep 17 00:00:00 2001 From: Srinivasan Shanmugam Date: Wed, 10 Jan 2024 20:58:35 +0530 Subject: [PATCH] drm/amd/display: Fix late derefrence 'dsc' check in 'link_set_dsc_pps_packet()' In link_set_dsc_pps_packet(), 'struct display_stream_compressor *dsc' was dereferenced in a DC_LOGGER_INIT(dsc->ctx->logger); before the 'dsc' NULL pointer check. Fixes the below: drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dpms.c:905 link_set_dsc_= pps_packet() warn: variable dereferenced before check 'dsc' (see line 903) Cc: stable@vger.kernel.org Cc: Aurabindo Pillai Cc: Rodrigo Siqueira Cc: Hamza Mahfooz Cc: Wenjing Liu Cc: Qingqing Zhuo Signed-off-by: Srinivasan Shanmugam Reviewed-by: Aurabindo Pillai Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/link/link_dpms.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/link/link_dpms.c b/drivers/gpu/= drm/amd/display/dc/link/link_dpms.c index 3de148004c066..3cbfbf8d107e9 100644 --- a/drivers/gpu/drm/amd/display/dc/link/link_dpms.c +++ b/drivers/gpu/drm/amd/display/dc/link/link_dpms.c @@ -900,11 +900,15 @@ bool link_set_dsc_pps_packet(struct pipe_ctx *pipe_ct= x, bool enable, bool immedi { struct display_stream_compressor *dsc =3D pipe_ctx->stream_res.dsc; struct dc_stream_state *stream =3D pipe_ctx->stream; - DC_LOGGER_INIT(dsc->ctx->logger); =20 - if (!pipe_ctx->stream->timing.flags.DSC || !dsc) + if (!pipe_ctx->stream->timing.flags.DSC) return false; =20 + if (!dsc) + return false; + + DC_LOGGER_INIT(dsc->ctx->logger); + if (enable) { struct dsc_config dsc_cfg; uint8_t dsc_packed_pps[128]; --=20 2.43.0