From nobody Sun Feb 8 03:58:05 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34B0B1769E4; Wed, 27 Mar 2024 12:23:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711542185; cv=none; b=b+sECShQp8AV86pUiNzSuGcRi+29xF9nnaMKV5qImfu42Y1nwXZYWWW/4RHbOmF0/PcFPyPt2DGZ875hU0TTTsVxeLus/IUuYjPU4MirPgQeYx0n9gLUhy3qXNFzG678eGJUCB3i7NnX0peYys0wWfybX24lgi1y9iv9MsZJkGw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711542185; c=relaxed/simple; bh=84FNmoY1r/F2HImjdFYwNrrP3bg60XCorcGszewfxGQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HXUyJa54h6r/6r0O4xQdHNsdm5bXw+mHPv1CyRIaPMaGCf5r+QZ9QsLjcd/yszRwWNGB5XouoWeft+myqu55wiM7OUhWBnjF3z3NIWP2b0ljR5nBDG9NLhvGNTD0Dorsb9D4KGEfZLVDo0SnJoL6aKtnGdOR3lIugj9qV7+uRjA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uPz+bMHX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uPz+bMHX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09DF2C433F1; Wed, 27 Mar 2024 12:23:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711542184; bh=84FNmoY1r/F2HImjdFYwNrrP3bg60XCorcGszewfxGQ=; h=From:To:Cc:Subject:Date:From; b=uPz+bMHXQlSsJd/B0XtwbAobpO/vLWlruhh6ypSZqyH/wbAw1nLk0IJjJqFumIZne f0jrDPbWp4TFiu1FfVYS6P1ttOFDL2fs97ZsxvQPjio4Y+NicGRlcAnG9FISPnqXsf OpDhUO9kTzQeDj/LE2QtB8Knu0o+pQ1eIWhOPR+t+Mhp0q/VfPyVhons83nGCfUzt5 2XY6MIm1TktxlRjZSpUgpESrLqxfMWo15iCWvhUq5F8dbb1bODU1nUOZYk8IvPew9O OGSNMMD1IANXy2x8711Nk4STsZzvPXsZtwvYNMmix3qkqJoxie/JUm/9G3QjbOt0a2 GFy6Op4p1dPYA== From: Sasha Levin To: stable@vger.kernel.org, mmakassikis@freebox.fr Cc: Namjae Jeon , Steve French , linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: FAILED: Patch "ksmbd: replace generic_fillattr with vfs_getattr" failed to apply to 5.4-stable tree Date: Wed, 27 Mar 2024 08:23:02 -0400 Message-ID: <20240327122303.2838171-1-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Hint: ignore X-stable: review Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The patch below does not apply to the 5.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . Thanks, Sasha Acked-by: Namjae Jeon ------------------ original commit in Linus's tree ------------------ From 5614c8c487f6af627614dd2efca038e4afe0c6d7 Mon Sep 17 00:00:00 2001 From: Marios Makassikis Date: Thu, 22 Feb 2024 10:58:19 +0100 Subject: [PATCH] ksmbd: replace generic_fillattr with vfs_getattr generic_fillattr should not be used outside of ->getattr implementations. Use vfs_getattr instead, and adapt functions to return an error code to the caller. Cc: stable@vger.kernel.org Signed-off-by: Marios Makassikis Acked-by: Namjae Jeon Signed-off-by: Steve French --- fs/smb/server/smb2pdu.c | 170 ++++++++++++++++++++++++------------- fs/smb/server/smb_common.c | 11 ++- fs/smb/server/vfs.c | 12 ++- 3 files changed, 127 insertions(+), 66 deletions(-) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index 0c97d3c860726..f6cc5d2730ffb 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -3828,11 +3828,16 @@ static int process_query_dir_entries(struct smb2_qu= ery_dir_private *priv) } =20 ksmbd_kstat.kstat =3D &kstat; - if (priv->info_level !=3D FILE_NAMES_INFORMATION) - ksmbd_vfs_fill_dentry_attrs(priv->work, - idmap, - dent, - &ksmbd_kstat); + if (priv->info_level !=3D FILE_NAMES_INFORMATION) { + rc =3D ksmbd_vfs_fill_dentry_attrs(priv->work, + idmap, + dent, + &ksmbd_kstat); + if (rc) { + dput(dent); + continue; + } + } =20 rc =3D smb2_populate_readdir_entry(priv->work->conn, priv->info_level, @@ -4480,6 +4485,7 @@ static int get_file_basic_info(struct smb2_query_info= _rsp *rsp, struct smb2_file_basic_info *basic_info; struct kstat stat; u64 time; + int ret; =20 if (!(fp->daccess & FILE_READ_ATTRIBUTES_LE)) { pr_err("no right to read the attributes : 0x%x\n", @@ -4487,9 +4493,12 @@ static int get_file_basic_info(struct smb2_query_inf= o_rsp *rsp, return -EACCES; } =20 + ret =3D vfs_getattr(&fp->filp->f_path, &stat, STATX_BASIC_STATS, + AT_STATX_SYNC_AS_STAT); + if (ret) + return ret; + basic_info =3D (struct smb2_file_basic_info *)rsp->Buffer; - generic_fillattr(file_mnt_idmap(fp->filp), STATX_BASIC_STATS, - file_inode(fp->filp), &stat); basic_info->CreationTime =3D cpu_to_le64(fp->create_time); time =3D ksmbd_UnixTimeToNT(stat.atime); basic_info->LastAccessTime =3D cpu_to_le64(time); @@ -4504,27 +4513,31 @@ static int get_file_basic_info(struct smb2_query_in= fo_rsp *rsp, return 0; } =20 -static void get_file_standard_info(struct smb2_query_info_rsp *rsp, - struct ksmbd_file *fp, void *rsp_org) +static int get_file_standard_info(struct smb2_query_info_rsp *rsp, + struct ksmbd_file *fp, void *rsp_org) { struct smb2_file_standard_info *sinfo; unsigned int delete_pending; - struct inode *inode; struct kstat stat; + int ret; =20 - inode =3D file_inode(fp->filp); - generic_fillattr(file_mnt_idmap(fp->filp), STATX_BASIC_STATS, inode, &sta= t); + ret =3D vfs_getattr(&fp->filp->f_path, &stat, STATX_BASIC_STATS, + AT_STATX_SYNC_AS_STAT); + if (ret) + return ret; =20 sinfo =3D (struct smb2_file_standard_info *)rsp->Buffer; delete_pending =3D ksmbd_inode_pending_delete(fp); =20 - sinfo->AllocationSize =3D cpu_to_le64(inode->i_blocks << 9); + sinfo->AllocationSize =3D cpu_to_le64(stat.blocks << 9); sinfo->EndOfFile =3D S_ISDIR(stat.mode) ? 0 : cpu_to_le64(stat.size); sinfo->NumberOfLinks =3D cpu_to_le32(get_nlink(&stat) - delete_pending); sinfo->DeletePending =3D delete_pending; sinfo->Directory =3D S_ISDIR(stat.mode) ? 1 : 0; rsp->OutputBufferLength =3D cpu_to_le32(sizeof(struct smb2_file_standard_info)); + + return 0; } =20 static void get_file_alignment_info(struct smb2_query_info_rsp *rsp, @@ -4546,11 +4559,11 @@ static int get_file_all_info(struct ksmbd_work *wor= k, struct ksmbd_conn *conn =3D work->conn; struct smb2_file_all_info *file_info; unsigned int delete_pending; - struct inode *inode; struct kstat stat; int conv_len; char *filename; u64 time; + int ret; =20 if (!(fp->daccess & FILE_READ_ATTRIBUTES_LE)) { ksmbd_debug(SMB, "no right to read the attributes : 0x%x\n", @@ -4562,8 +4575,10 @@ static int get_file_all_info(struct ksmbd_work *work, if (IS_ERR(filename)) return PTR_ERR(filename); =20 - inode =3D file_inode(fp->filp); - generic_fillattr(file_mnt_idmap(fp->filp), STATX_BASIC_STATS, inode, &sta= t); + ret =3D vfs_getattr(&fp->filp->f_path, &stat, STATX_BASIC_STATS, + AT_STATX_SYNC_AS_STAT); + if (ret) + return ret; =20 ksmbd_debug(SMB, "filename =3D %s\n", filename); delete_pending =3D ksmbd_inode_pending_delete(fp); @@ -4579,7 +4594,7 @@ static int get_file_all_info(struct ksmbd_work *work, file_info->Attributes =3D fp->f_ci->m_fattr; file_info->Pad1 =3D 0; file_info->AllocationSize =3D - cpu_to_le64(inode->i_blocks << 9); + cpu_to_le64(stat.blocks << 9); file_info->EndOfFile =3D S_ISDIR(stat.mode) ? 0 : cpu_to_le64(stat.size); file_info->NumberOfLinks =3D cpu_to_le32(get_nlink(&stat) - delete_pending); @@ -4623,10 +4638,10 @@ static void get_file_alternate_info(struct ksmbd_wo= rk *work, cpu_to_le32(sizeof(struct smb2_file_alt_name_info) + conv_len); } =20 -static void get_file_stream_info(struct ksmbd_work *work, - struct smb2_query_info_rsp *rsp, - struct ksmbd_file *fp, - void *rsp_org) +static int get_file_stream_info(struct ksmbd_work *work, + struct smb2_query_info_rsp *rsp, + struct ksmbd_file *fp, + void *rsp_org) { struct ksmbd_conn *conn =3D work->conn; struct smb2_file_stream_info *file_info; @@ -4637,9 +4652,13 @@ static void get_file_stream_info(struct ksmbd_work *= work, int nbytes =3D 0, streamlen, stream_name_len, next, idx =3D 0; int buf_free_len; struct smb2_query_info_req *req =3D ksmbd_req_buf_next(work); + int ret; + + ret =3D vfs_getattr(&fp->filp->f_path, &stat, STATX_BASIC_STATS, + AT_STATX_SYNC_AS_STAT); + if (ret) + return ret; =20 - generic_fillattr(file_mnt_idmap(fp->filp), STATX_BASIC_STATS, - file_inode(fp->filp), &stat); file_info =3D (struct smb2_file_stream_info *)rsp->Buffer; =20 buf_free_len =3D @@ -4720,29 +4739,37 @@ static void get_file_stream_info(struct ksmbd_work = *work, kvfree(xattr_list); =20 rsp->OutputBufferLength =3D cpu_to_le32(nbytes); + + return 0; } =20 -static void get_file_internal_info(struct smb2_query_info_rsp *rsp, - struct ksmbd_file *fp, void *rsp_org) +static int get_file_internal_info(struct smb2_query_info_rsp *rsp, + struct ksmbd_file *fp, void *rsp_org) { struct smb2_file_internal_info *file_info; struct kstat stat; + int ret; + + ret =3D vfs_getattr(&fp->filp->f_path, &stat, STATX_BASIC_STATS, + AT_STATX_SYNC_AS_STAT); + if (ret) + return ret; =20 - generic_fillattr(file_mnt_idmap(fp->filp), STATX_BASIC_STATS, - file_inode(fp->filp), &stat); file_info =3D (struct smb2_file_internal_info *)rsp->Buffer; file_info->IndexNumber =3D cpu_to_le64(stat.ino); rsp->OutputBufferLength =3D cpu_to_le32(sizeof(struct smb2_file_internal_info)); + + return 0; } =20 static int get_file_network_open_info(struct smb2_query_info_rsp *rsp, struct ksmbd_file *fp, void *rsp_org) { struct smb2_file_ntwrk_info *file_info; - struct inode *inode; struct kstat stat; u64 time; + int ret; =20 if (!(fp->daccess & FILE_READ_ATTRIBUTES_LE)) { pr_err("no right to read the attributes : 0x%x\n", @@ -4750,10 +4777,12 @@ static int get_file_network_open_info(struct smb2_q= uery_info_rsp *rsp, return -EACCES; } =20 - file_info =3D (struct smb2_file_ntwrk_info *)rsp->Buffer; + ret =3D vfs_getattr(&fp->filp->f_path, &stat, STATX_BASIC_STATS, + AT_STATX_SYNC_AS_STAT); + if (ret) + return ret; =20 - inode =3D file_inode(fp->filp); - generic_fillattr(file_mnt_idmap(fp->filp), STATX_BASIC_STATS, inode, &sta= t); + file_info =3D (struct smb2_file_ntwrk_info *)rsp->Buffer; =20 file_info->CreationTime =3D cpu_to_le64(fp->create_time); time =3D ksmbd_UnixTimeToNT(stat.atime); @@ -4763,8 +4792,7 @@ static int get_file_network_open_info(struct smb2_que= ry_info_rsp *rsp, time =3D ksmbd_UnixTimeToNT(stat.ctime); file_info->ChangeTime =3D cpu_to_le64(time); file_info->Attributes =3D fp->f_ci->m_fattr; - file_info->AllocationSize =3D - cpu_to_le64(inode->i_blocks << 9); + file_info->AllocationSize =3D cpu_to_le64(stat.blocks << 9); file_info->EndOfFile =3D S_ISDIR(stat.mode) ? 0 : cpu_to_le64(stat.size); file_info->Reserved =3D cpu_to_le32(0); rsp->OutputBufferLength =3D @@ -4804,14 +4832,17 @@ static void get_file_mode_info(struct smb2_query_in= fo_rsp *rsp, cpu_to_le32(sizeof(struct smb2_file_mode_info)); } =20 -static void get_file_compression_info(struct smb2_query_info_rsp *rsp, - struct ksmbd_file *fp, void *rsp_org) +static int get_file_compression_info(struct smb2_query_info_rsp *rsp, + struct ksmbd_file *fp, void *rsp_org) { struct smb2_file_comp_info *file_info; struct kstat stat; + int ret; =20 - generic_fillattr(file_mnt_idmap(fp->filp), STATX_BASIC_STATS, - file_inode(fp->filp), &stat); + ret =3D vfs_getattr(&fp->filp->f_path, &stat, STATX_BASIC_STATS, + AT_STATX_SYNC_AS_STAT); + if (ret) + return ret; =20 file_info =3D (struct smb2_file_comp_info *)rsp->Buffer; file_info->CompressedFileSize =3D cpu_to_le64(stat.blocks << 9); @@ -4823,6 +4854,8 @@ static void get_file_compression_info(struct smb2_que= ry_info_rsp *rsp, =20 rsp->OutputBufferLength =3D cpu_to_le32(sizeof(struct smb2_file_comp_info)); + + return 0; } =20 static int get_file_attribute_tag_info(struct smb2_query_info_rsp *rsp, @@ -4844,7 +4877,7 @@ static int get_file_attribute_tag_info(struct smb2_qu= ery_info_rsp *rsp, return 0; } =20 -static void find_file_posix_info(struct smb2_query_info_rsp *rsp, +static int find_file_posix_info(struct smb2_query_info_rsp *rsp, struct ksmbd_file *fp, void *rsp_org) { struct smb311_posix_qinfo *file_info; @@ -4852,24 +4885,31 @@ static void find_file_posix_info(struct smb2_query_= info_rsp *rsp, struct mnt_idmap *idmap =3D file_mnt_idmap(fp->filp); vfsuid_t vfsuid =3D i_uid_into_vfsuid(idmap, inode); vfsgid_t vfsgid =3D i_gid_into_vfsgid(idmap, inode); + struct kstat stat; u64 time; int out_buf_len =3D sizeof(struct smb311_posix_qinfo) + 32; + int ret; + + ret =3D vfs_getattr(&fp->filp->f_path, &stat, STATX_BASIC_STATS, + AT_STATX_SYNC_AS_STAT); + if (ret) + return ret; =20 file_info =3D (struct smb311_posix_qinfo *)rsp->Buffer; file_info->CreationTime =3D cpu_to_le64(fp->create_time); - time =3D ksmbd_UnixTimeToNT(inode_get_atime(inode)); + time =3D ksmbd_UnixTimeToNT(stat.atime); file_info->LastAccessTime =3D cpu_to_le64(time); - time =3D ksmbd_UnixTimeToNT(inode_get_mtime(inode)); + time =3D ksmbd_UnixTimeToNT(stat.mtime); file_info->LastWriteTime =3D cpu_to_le64(time); - time =3D ksmbd_UnixTimeToNT(inode_get_ctime(inode)); + time =3D ksmbd_UnixTimeToNT(stat.ctime); file_info->ChangeTime =3D cpu_to_le64(time); file_info->DosAttributes =3D fp->f_ci->m_fattr; - file_info->Inode =3D cpu_to_le64(inode->i_ino); - file_info->EndOfFile =3D cpu_to_le64(inode->i_size); - file_info->AllocationSize =3D cpu_to_le64(inode->i_blocks << 9); - file_info->HardLinks =3D cpu_to_le32(inode->i_nlink); - file_info->Mode =3D cpu_to_le32(inode->i_mode & 0777); - file_info->DeviceId =3D cpu_to_le32(inode->i_rdev); + file_info->Inode =3D cpu_to_le64(stat.ino); + file_info->EndOfFile =3D cpu_to_le64(stat.size); + file_info->AllocationSize =3D cpu_to_le64(stat.blocks << 9); + file_info->HardLinks =3D cpu_to_le32(stat.nlink); + file_info->Mode =3D cpu_to_le32(stat.mode & 0777); + file_info->DeviceId =3D cpu_to_le32(stat.rdev); =20 /* * Sids(32) contain two sids(Domain sid(16), UNIX group sid(16)). @@ -4882,6 +4922,8 @@ static void find_file_posix_info(struct smb2_query_in= fo_rsp *rsp, SIDUNIX_GROUP, (struct smb_sid *)&file_info->Sids[16]); =20 rsp->OutputBufferLength =3D cpu_to_le32(out_buf_len); + + return 0; } =20 static int smb2_get_info_file(struct ksmbd_work *work, @@ -4930,7 +4972,7 @@ static int smb2_get_info_file(struct ksmbd_work *work, break; =20 case FILE_STANDARD_INFORMATION: - get_file_standard_info(rsp, fp, work->response_buf); + rc =3D get_file_standard_info(rsp, fp, work->response_buf); break; =20 case FILE_ALIGNMENT_INFORMATION: @@ -4946,11 +4988,11 @@ static int smb2_get_info_file(struct ksmbd_work *wo= rk, break; =20 case FILE_STREAM_INFORMATION: - get_file_stream_info(work, rsp, fp, work->response_buf); + rc =3D get_file_stream_info(work, rsp, fp, work->response_buf); break; =20 case FILE_INTERNAL_INFORMATION: - get_file_internal_info(rsp, fp, work->response_buf); + rc =3D get_file_internal_info(rsp, fp, work->response_buf); break; =20 case FILE_NETWORK_OPEN_INFORMATION: @@ -4974,7 +5016,7 @@ static int smb2_get_info_file(struct ksmbd_work *work, break; =20 case FILE_COMPRESSION_INFORMATION: - get_file_compression_info(rsp, fp, work->response_buf); + rc =3D get_file_compression_info(rsp, fp, work->response_buf); break; =20 case FILE_ATTRIBUTE_TAG_INFORMATION: @@ -4985,7 +5027,7 @@ static int smb2_get_info_file(struct ksmbd_work *work, pr_err("client doesn't negotiate with SMB3.1.1 POSIX Extensions\n"); rc =3D -EOPNOTSUPP; } else { - find_file_posix_info(rsp, fp, work->response_buf); + rc =3D find_file_posix_info(rsp, fp, work->response_buf); } break; default: @@ -5398,7 +5440,6 @@ int smb2_close(struct ksmbd_work *work) struct smb2_close_rsp *rsp; struct ksmbd_conn *conn =3D work->conn; struct ksmbd_file *fp; - struct inode *inode; u64 time; int err =3D 0; =20 @@ -5453,24 +5494,33 @@ int smb2_close(struct ksmbd_work *work) rsp->Reserved =3D 0; =20 if (req->Flags =3D=3D SMB2_CLOSE_FLAG_POSTQUERY_ATTRIB) { + struct kstat stat; + int ret; + fp =3D ksmbd_lookup_fd_fast(work, volatile_id); if (!fp) { err =3D -ENOENT; goto out; } =20 - inode =3D file_inode(fp->filp); + ret =3D vfs_getattr(&fp->filp->f_path, &stat, STATX_BASIC_STATS, + AT_STATX_SYNC_AS_STAT); + if (ret) { + ksmbd_fd_put(work, fp); + goto out; + } + rsp->Flags =3D SMB2_CLOSE_FLAG_POSTQUERY_ATTRIB; - rsp->AllocationSize =3D S_ISDIR(inode->i_mode) ? 0 : - cpu_to_le64(inode->i_blocks << 9); - rsp->EndOfFile =3D cpu_to_le64(inode->i_size); + rsp->AllocationSize =3D S_ISDIR(stat.mode) ? 0 : + cpu_to_le64(stat.blocks << 9); + rsp->EndOfFile =3D cpu_to_le64(stat.size); rsp->Attributes =3D fp->f_ci->m_fattr; rsp->CreationTime =3D cpu_to_le64(fp->create_time); - time =3D ksmbd_UnixTimeToNT(inode_get_atime(inode)); + time =3D ksmbd_UnixTimeToNT(stat.atime); rsp->LastAccessTime =3D cpu_to_le64(time); - time =3D ksmbd_UnixTimeToNT(inode_get_mtime(inode)); + time =3D ksmbd_UnixTimeToNT(stat.mtime); rsp->LastWriteTime =3D cpu_to_le64(time); - time =3D ksmbd_UnixTimeToNT(inode_get_ctime(inode)); + time =3D ksmbd_UnixTimeToNT(stat.ctime); rsp->ChangeTime =3D cpu_to_le64(time); ksmbd_fd_put(work, fp); } else { diff --git a/fs/smb/server/smb_common.c b/fs/smb/server/smb_common.c index 7c98bf699772f..fcaf373cc0080 100644 --- a/fs/smb/server/smb_common.c +++ b/fs/smb/server/smb_common.c @@ -457,10 +457,13 @@ int ksmbd_populate_dot_dotdot_entries(struct ksmbd_wo= rk *work, int info_level, } =20 ksmbd_kstat.kstat =3D &kstat; - ksmbd_vfs_fill_dentry_attrs(work, - idmap, - dentry, - &ksmbd_kstat); + rc =3D ksmbd_vfs_fill_dentry_attrs(work, + idmap, + dentry, + &ksmbd_kstat); + if (rc) + break; + rc =3D fn(conn, info_level, d_info, &ksmbd_kstat); if (rc) break; diff --git a/fs/smb/server/vfs.c b/fs/smb/server/vfs.c index a6961bfe3e139..2e992fadeaa7d 100644 --- a/fs/smb/server/vfs.c +++ b/fs/smb/server/vfs.c @@ -1682,11 +1682,19 @@ int ksmbd_vfs_fill_dentry_attrs(struct ksmbd_work *= work, struct dentry *dentry, struct ksmbd_kstat *ksmbd_kstat) { + struct ksmbd_share_config *share_conf =3D work->tcon->share_conf; u64 time; int rc; + struct path path =3D { + .mnt =3D share_conf->vfs_path.mnt, + .dentry =3D dentry, + }; =20 - generic_fillattr(idmap, STATX_BASIC_STATS, d_inode(dentry), - ksmbd_kstat->kstat); + rc =3D vfs_getattr(&path, ksmbd_kstat->kstat, + STATX_BASIC_STATS | STATX_BTIME, + AT_STATX_SYNC_AS_STAT); + if (rc) + return rc; =20 time =3D ksmbd_UnixTimeToNT(ksmbd_kstat->kstat->ctime); ksmbd_kstat->create_time =3D time; --=20 2.43.0