From nobody Sat Feb 7 10:08:10 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F3CD1CF92 for ; Wed, 27 Mar 2024 02:41:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711507286; cv=none; b=olsRr+6OpPc79TgPBMqjZt7/eHTUw/H+e5AXLcrNLtDnBCEzuE7unO3/FUvKPY1KMN3LCMSJ3QYP82OxUcSqSG3AyVX5My/L5a1mN/f1Dl7tnkfm9x17aKLbESnlwsXxjdaAdeW4YjMpPIVGXAgbqVhS1BoPbYOTJzv9hI//i9s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711507286; c=relaxed/simple; bh=QHEFYyJ0ZlpC9va2tA5qgb0s5US0vAP7cmBdzlyHBPc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ETx7Ymm/jnnBEvynASOIH8msnjtPIJeuaRou4TqdkhXo1HOw/FwW9zmUcfLf9JS9gn1DuyklNhCEKC5f2lXC3f49aYiFuzPEq7HX+15qgI0TOs4vft2/lZeNgpQFsz2DB+DNmLPh829Hpn4tBGROIUEDO1PBsIpOF/H1APm2lfM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=h9IxAVQa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="h9IxAVQa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2885BC433C7; Wed, 27 Mar 2024 02:41:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711507286; bh=QHEFYyJ0ZlpC9va2tA5qgb0s5US0vAP7cmBdzlyHBPc=; h=From:To:Cc:Subject:Date:From; b=h9IxAVQa2oQhabHEkXkOcYtPUK21b/6G1Rfh8FAV0eI1h6CBRQKvHFlwYh3GtP0lv HgnR7yzaN1QFOmydw81Xy/m749TVemFMyLLbVm/+r/YXVhR18+G05yWVexbgoIMsJs 9JwrCMthQgq3MOGOTqVo4uKpoUuq8Vg9am7ps46Z9RQHqoR9L8zRZkFS+EppllT2Sl cwiPS6SBxekUwWum/z0J7xxnodtf9NOe1vUDNDSrhHKILcZLTiXX8Gs0Wawi5e/i+Y vM57XDJpeVtp0ncfpMRh/fqqEGgJyIZYr0A1B1Eg+hY/Vn8ifkyoJBbsT6tSitaJfs DX7/PpdbQh3hQ== From: alexs@kernel.org To: Josh Poimboeuf , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)), "H. Peter Anvin" , linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)) Cc: linux-kernel@vger.kernel.org, Alex Shi Subject: [PATCH v3] x86/dumpstack: uniform die messages prompt Date: Wed, 27 Mar 2024 10:44:19 +0800 Message-ID: <20240327024419.471433-1-alexs@kernel.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Alex Shi panic() has a uniform prompt, like "Kernel panic - not syncing:". That's easy to indicate a panic there. But die() message doesn't have. We died thousands machine with very different reasons weekly. w/o a prompt in dmesg, it's hard to write scripts to collect and anaylis the die reasons. That makes admins' life pretty hard. A uniform die() prompt like "Oops:" could save some hair for admins. Signed-off-by: Alex Shi To: linux-kernel@vger.kernel.org To: "H. Peter Anvin" To: x86@kernel.org To: Dave Hansen To: Borislav Petkov To: Ingo Molnar To: Thomas Gleixner To: Peter Zijlstra To: Josh Poimboeuf --- arch/x86/kernel/dumpstack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c index f18ca44c904b..e1358ef80b59 100644 --- a/arch/x86/kernel/dumpstack.c +++ b/arch/x86/kernel/dumpstack.c @@ -405,8 +405,8 @@ static void __die_header(const char *str, struct pt_reg= s *regs, long err) pr =3D IS_ENABLED(CONFIG_PREEMPT_RT) ? " PREEMPT_RT" : " PREEMPT"; =20 printk(KERN_DEFAULT - "%s: %04lx [#%d]%s%s%s%s%s\n", str, err & 0xffff, ++die_counter, - pr, + "Oops: %s: %04lx [#%d]%s%s%s%s%s\n", str, err & 0xffff, + ++die_counter, pr, IS_ENABLED(CONFIG_SMP) ? " SMP" : "", debug_pagealloc_enabled() ? " DEBUG_PAGEALLOC" : "", IS_ENABLED(CONFIG_KASAN) ? " KASAN" : "", --=20 2.43.0