From nobody Mon Feb 9 01:45:13 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60C8513E036; Tue, 26 Mar 2024 22:38:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711492732; cv=none; b=oG+JQAi0bhdPJ2GP3XBJtliQsksNKRuAvXP9xdErTvbPZ3LgXmyrtI4CrBydmwRVhLLx/+lQ6E79CzTzkNRKL70XBHFqtzupAfYEpLFYivbzM45uMIwNqChA2n2C42R9L3oCZ05YdTtIqAanOUw7+LvlgLvVE/1Chm+7P4qJcgE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711492732; c=relaxed/simple; bh=4nCC9JNEj51O9TISVBwQcV6lR14jShr/2PiFrxb4DMw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Swv6qZiHkC65EjdYJJuma0hmDwwM2bnW/qKjvpsHWU8i9/tkc4a/E3hPTXW15c+7Qv3d7x0yAkfw3XSXGTaIvTIwnonG6uz41vyfOaWk2RLlCoA3uaiycf9TO95EmwU3zaMBjRpKE7hjyHYz/Z5BTQgjNmm49Xg8DTJIyFb2QIQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=k/LUR/oq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="k/LUR/oq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47888C43141; Tue, 26 Mar 2024 22:38:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711492731; bh=4nCC9JNEj51O9TISVBwQcV6lR14jShr/2PiFrxb4DMw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=k/LUR/oqbtEkuUoncQuFcPdUw5/uxbCSh0bFFQnRKFjigKDiszTEbBDb+qjLiZXXp 2SwD3bE1AvuzrVMBo2KWNyixEB9LpC/El3pI5AU0Gni7TaYhbmbkpPK3ilagc692dK i6EI0Zs+1acBigkxU+CS/RAg+An/og+Hcl5bpq8Z01Qzy8xFI3c/tLRuUcwSICwWK/ +6Rkfp8kFmUSJSQjg6xnx123kva6GTdzpJnGOrpu7mC3Ub9DKIO9YOnVFz6ElxnQJb a6DOD91Va4VJijxQ/SBALRYhysYeYYZ7X5QeDgscMrS/Exg1a4vXEVYXtpscmsm4+X d5mED56x4rujw== From: Arnd Bergmann To: llvm@lists.linux.dev, Helge Deller , Laurent Pinchart Cc: Arnd Bergmann , Thomas Zimmermann , Javier Martinez Canillas , Geert Uytterhoeven , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Laurent Pinchart , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/9] fbdev: shmobile: fix snprintf truncation Date: Tue, 26 Mar 2024 23:38:00 +0100 Message-Id: <20240326223825.4084412-2-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240326223825.4084412-1-arnd@kernel.org> References: <20240326223825.4084412-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann The name of the overlay does not fit into the fixed-length field: drivers/video/fbdev/sh_mobile_lcdcfb.c:1577:2: error: 'snprintf' will alway= s be truncated; specified size is 16, but format string expands to at least= 25 Make it short enough by changing the string. Fixes: c5deac3c9b22 ("fbdev: sh_mobile_lcdc: Implement overlays support") Signed-off-by: Arnd Bergmann Reviewed-by: Laurent Pinchart --- drivers/video/fbdev/sh_mobile_lcdcfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/s= h_mobile_lcdcfb.c index eb2297b37504..d35d2cf99998 100644 --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c @@ -1575,7 +1575,7 @@ sh_mobile_lcdc_overlay_fb_init(struct sh_mobile_lcdc_= overlay *ovl) */ info->fix =3D sh_mobile_lcdc_overlay_fix; snprintf(info->fix.id, sizeof(info->fix.id), - "SH Mobile LCDC Overlay %u", ovl->index); + "SHMobile ovl %u", ovl->index); info->fix.smem_start =3D ovl->dma_handle; info->fix.smem_len =3D ovl->fb_size; info->fix.line_length =3D ovl->pitch; --=20 2.39.2 From nobody Mon Feb 9 01:45:13 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D91F13DDD1; Tue, 26 Mar 2024 22:39:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711492762; cv=none; b=FHYj4h6/i7WOKhArQy1D46faoc1vXg3BxSAx5GvAM31JKBbJ1SACpnt0aS8Wwt1y+HzHPkW56tP+jd46u4jAuK92twUGC05p8UwCdZW2mRIn8CtLeJf8x0U+SV+d0tB7Gw/TSvgq9iFWza2KJ6vdsX+9k87o2SpP3X24Wi1GTZU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711492762; c=relaxed/simple; bh=KeyNCZskP6/b1M7OoexAF78T4p7x0+NMkepYQTejfAs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=R+DwFPLz8/N/YbHpK7GsSotFK8aBeH+dVlGB+obaKAnxo0BsCwM/gtcRrHgtaT55Sx9YI6BCjoQ9m8HAvbBg/aFDCwAg6nz/Nq4aqhkOrEgqdnDGSDLrzwt0Q1gDQEoucaT6rET96eVnCmOMsgLvVjiYxVyP+Mn2aLogv8FfmSk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nUkPCOXw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nUkPCOXw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71FCCC433F1; Tue, 26 Mar 2024 22:39:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711492762; bh=KeyNCZskP6/b1M7OoexAF78T4p7x0+NMkepYQTejfAs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nUkPCOXw+m5dqLk95Et2hTWpRql228gXeu8f+g16q/hj+saAwDtlMyNW4nQsKg0uX uETZmJRUz04kFjXnWd6W6R71BSc8mkPb2IheQs1CmSdeBBbbe/n4vD2rj0QdFMLbat 8nrxaQORCAEzyEdi/qJkvRTjb+nalTS/yJYn0BT+m23og1RLtxP67iJ/eq8Jmk3drz hpl+H88S0+HhCx/NRHckYmvJ5ja+NMBvGik3LgZ30BQlsrYIjOym+Ve1NWmGxISm6H kyZfezpARfHQ7tCCQuFrkZIT0abEeJqADaFJswMq3U8ES5bVtnnp4K4tH2fYoGBMI2 oUYIkuTMnNyMw== From: Arnd Bergmann To: llvm@lists.linux.dev, Claudiu Manoil , Vladimir Oltean Cc: Arnd Bergmann , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Simon Horman , Ferenc Fejes , Wei Fang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH 2/9] enetc: avoid truncating error message Date: Tue, 26 Mar 2024 23:38:01 +0100 Message-Id: <20240326223825.4084412-3-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240326223825.4084412-1-arnd@kernel.org> References: <20240326223825.4084412-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann As clang points out, the error message in enetc_setup_xdp_prog() still does not fit in the buffer and will be truncated: drivers/net/ethernet/freescale/enetc/enetc.c:2771:3: error: 'snprintf' will= always be truncated; specified size is 80, but format string expands to at= least 87 [-Werror,-Wformat-truncation] Replace it with an even shorter message that should fit. Fixes: f968c56417f0 ("net: enetc: shorten enetc_setup_xdp_prog() error mess= age to fit NETLINK_MAX_FMTMSG_LEN") Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/freescale/enetc/enetc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/eth= ernet/freescale/enetc/enetc.c index 9f07f4947b63..5c45f42232d3 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc.c +++ b/drivers/net/ethernet/freescale/enetc/enetc.c @@ -2769,7 +2769,7 @@ static int enetc_setup_xdp_prog(struct net_device *nd= ev, struct bpf_prog *prog, if (priv->min_num_stack_tx_queues + num_xdp_tx_queues > priv->num_tx_rings) { NL_SET_ERR_MSG_FMT_MOD(extack, - "Reserving %d XDP TXQs does not leave a minimum of %d for stack= (total %d)", + "Reserving %d XDP TXQs leaves under %d for stack (total %d)", num_xdp_tx_queues, priv->min_num_stack_tx_queues, priv->num_tx_rings); --=20 2.39.2 From nobody Mon Feb 9 01:45:13 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B451313D8B2; Tue, 26 Mar 2024 22:39:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711492783; cv=none; b=qYuqV3xWW3HXGh34Nfm04xZaUGTPJdTls2k/x81fGWzdVUeHUvfO6aBpsl7Ryo9KF5wwUWQSs82ubWCW4dsY5NFv/OVjOSiilOIfSv9qFyu2E40XZ+GvatMfp6+nhlu0W3gLzcttyqdsQTRiznac/Y1ZHiNTTW88tB8vA+Hpecw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711492783; c=relaxed/simple; bh=F1tdxK6zhURX1XJa26Hj4NTFjwVssRlwDIPa82U+7Bs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GXu9h8AZaPMalcE7gbRiN5vT29EMNfItd/n0SZrTrFq1q0D8822jtBIG7jibmmNVQRhD/uelmHQV25OWMIguVC7iqW1npZk4aQxCLUtfu5wfyg8lq1LUSvMhCWxTDhhYdBMnMWaeJW9D7+ru/IrDWIrNPSIHeNvZeBo2cfFdd9k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tmbfHnWP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tmbfHnWP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE7F5C433C7; Tue, 26 Mar 2024 22:39:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711492783; bh=F1tdxK6zhURX1XJa26Hj4NTFjwVssRlwDIPa82U+7Bs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tmbfHnWPYV61Wv5iJoz7qdwrUEHhqEB2TZlr+P4RRDVAYgR6Nr/hl2wuXKgNBL69l T7Xxg4TYS4ANY2Ynz3yB2yl8CwY+YBN811GkOiH+8PnxmYpSj4YxykOrWs2v0PBxhH KbDjYSxvhYF/hxF5hmZ/9vbIUKqV6GZlnmxDMeLWYHBeQaFo5zhuV4ufReW5oXHLRs iSRCp7D4mUt9ukgZ4RHoZoQiHmTokGfajcZaKawN5oJ8Pq9+A56JIheUGJDhLLSAGR xlMuJniJZpuZvgowiLjFneTAqJ7NlJVshD7RJjwSUGPuUfKKYOvyKZ/IwC6whf469l MijLyYiwgnU5Q== From: Arnd Bergmann To: llvm@lists.linux.dev, Ariel Elior , Manish Chopra Cc: Arnd Bergmann , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Simon Horman , Konstantin Khorenko , Sudarsana Reddy Kalluru , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/9] qed: avoid truncating work queue length Date: Tue, 26 Mar 2024 23:38:02 +0100 Message-Id: <20240326223825.4084412-4-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240326223825.4084412-1-arnd@kernel.org> References: <20240326223825.4084412-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann clang complains that the temporary string for the name passed into alloc_workqueue() is too short for its contents: drivers/net/ethernet/qlogic/qed/qed_main.c:1218:3: error: 'snprintf' will a= lways be truncated; specified size is 16, but format string expands to at l= east 18 [-Werror,-Wformat-truncation] There is no need for a temporary buffer, and the actual name of a workqueue is 32 bytes (WQ_NAME_LEN), so just use the interface as intended to avoid the truncation. Fixes: 59ccf86fe69a ("qed: Add driver infrastucture for handling mfw reques= ts.") Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/qlogic/qed/qed_main.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ether= net/qlogic/qed/qed_main.c index c278f8893042..8159b4c315b5 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_main.c +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c @@ -1206,7 +1206,6 @@ static void qed_slowpath_task(struct work_struct *wor= k) static int qed_slowpath_wq_start(struct qed_dev *cdev) { struct qed_hwfn *hwfn; - char name[NAME_SIZE]; int i; =20 if (IS_VF(cdev)) @@ -1215,11 +1214,11 @@ static int qed_slowpath_wq_start(struct qed_dev *cd= ev) for_each_hwfn(cdev, i) { hwfn =3D &cdev->hwfns[i]; =20 - snprintf(name, NAME_SIZE, "slowpath-%02x:%02x.%02x", - cdev->pdev->bus->number, - PCI_SLOT(cdev->pdev->devfn), hwfn->abs_pf_id); + hwfn->slowpath_wq =3D alloc_workqueue("slowpath-%02x:%02x.%02x", + 0, 0, cdev->pdev->bus->number, + PCI_SLOT(cdev->pdev->devfn), + hwfn->abs_pf_id); =20 - hwfn->slowpath_wq =3D alloc_workqueue(name, 0, 0); if (!hwfn->slowpath_wq) { DP_NOTICE(hwfn, "Cannot create slowpath workqueue\n"); return -ENOMEM; --=20 2.39.2 From nobody Mon Feb 9 01:45:13 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C67A813E021; Tue, 26 Mar 2024 22:40:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711492800; cv=none; b=IyaCnX9AkTqakZF12f4/QEArm1V2DnqShkP2km+dS33QG7LEyuzUxWN9yq646Km8Z0Yhvr7sp5a+oNWD79iHDn9iXBZKvJE6z6OGQBTTMRX7RpKn3Wm8sjicQyV1LiretduXldE4JvPDQ1ATNkyz09N6l9zg7bCx/ssyOmkb5pk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711492800; c=relaxed/simple; bh=lulGfl/VARvXl3v+IQINE9T8HFeaXr5b7miTjpnKPBo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=aYRPBKlR55ue5TLUGjnBVE1jxa7Xv+6WEU0CLEF+ZGlOhYtE72gnzoDt9gD8LxRJ2H0iiUNi4roFk1zDEjknDyfOLUOKPKS11KXimBwiRg6lcQkx2Vk7B7iWXYtFLvlzs67ktYLIUsVUiW9gGLYEpXljbvrLPj2bG8m6sl+SLac= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=niUVsVHK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="niUVsVHK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71FEBC433C7; Tue, 26 Mar 2024 22:39:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711492800; bh=lulGfl/VARvXl3v+IQINE9T8HFeaXr5b7miTjpnKPBo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=niUVsVHKc3NZHc+8bduQh4f+aNkZPxgGbbD/cp6isZmq1TLeongbEUIco/kjnVt4w vrcNPIFu1AXIefydV9FNMA85yIawUajQw4k+GVHqaRrM7sLk34fxC8PhMqn8zjPjon Rvl0Yo4kcCNjUZ9dH+6oF++f+v39DMtxPzVXQfgmjT045TQ9zYUPXioxybMsAynosm NrWCVpBujF9x8mXOInpLI1ROZ3A+ALXRjiJE0QikPWDETejt3OrZ5Xl6+UGQ3Dy6GX Juc0uFFkx6qC3xK5BAjJBHy5fiq2zDKL3B6YNW+SF514M+hngUaYRuaQ1LmV9WSQdK E6vkxMGcrXDBg== From: Arnd Bergmann To: llvm@lists.linux.dev, Saeed Mahameed , Leon Romanovsky Cc: Arnd Bergmann , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Vlad Buslov , Roi Dayan , Maor Dickman , Gal Pressman , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/9] mlx5: avoid truncating error message Date: Tue, 26 Mar 2024 23:38:03 +0100 Message-Id: <20240326223825.4084412-5-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240326223825.4084412-1-arnd@kernel.org> References: <20240326223825.4084412-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann clang warns that one error message is too long for its destination buffer: drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c:1876:4: error: 'snprin= tf' will always be truncated; specified size is 80, but format string expan= ds to at least 94 [-Werror,-Wformat-truncation-non-kprintf] Reword it to be a bit shorter so it always fits. Fixes: 70f0302b3f20 ("net/mlx5: Bridge, implement mdb offload") Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c b/drivers= /net/ethernet/mellanox/mlx5/core/esw/bridge.c index 1b9bc32efd6f..c5ea1d1d2b03 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c @@ -1874,7 +1874,7 @@ int mlx5_esw_bridge_port_mdb_add(struct net_device *d= ev, u16 vport_num, u16 esw_ "Failed to lookup bridge port vlan metadata to create MDB (MAC=3D%pM,= vid=3D%u,vport=3D%u)\n", addr, vid, vport_num); NL_SET_ERR_MSG_FMT_MOD(extack, - "Failed to lookup bridge port vlan metadata to create MDB (MAC= =3D%pM,vid=3D%u,vport=3D%u)\n", + "Failed to lookup vlan metadata for MDB (MAC=3D%pM,vid=3D%u,vp= ort=3D%u)\n", addr, vid, vport_num); return -EINVAL; } --=20 2.39.2 From nobody Mon Feb 9 01:45:13 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 381B713DDAA; Tue, 26 Mar 2024 22:40:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711492838; cv=none; b=h00sRcB+x1aOEqwFhPyEqnKnjZG8Ygs6JFGUkyrSs5JiQlb65KyXQWZ/e8jiGmZHLl+rBw1xMpkZBGqM9d8nm434ZMcseA1aWKtDrg4qHFAfbMnDtBt3e3vsWBjZjRKLWfc6m0J64c5XGzcS6bKG4RyYNh15FCYJYOo9S6tFbUs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711492838; c=relaxed/simple; bh=DvdOaxXySSb88hE1tdZLq/K7+rtZJ/+uDHjNaQDuU0M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Jvr5W81AGEkxwkYEVdxJOP8MbhmPr2qJLTcrDNn9BXwKlrPGEcxQEuDtTw73c1Z+6eEtQMng1kU7Dn55gyhN2PAX/XQQMTP8pRofRr3jl5/z6tWtYCa4o1mH5EVuGcGKTuk+BqcfTATlsKhRkMMdLu15JwI0mitO2vxEZJNLbhg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p5j6UdWx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p5j6UdWx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08F56C433C7; Tue, 26 Mar 2024 22:40:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711492837; bh=DvdOaxXySSb88hE1tdZLq/K7+rtZJ/+uDHjNaQDuU0M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p5j6UdWxGLPCw8MD1MG7G52pz4jf9eUDs/fFAPZ0nSxoBq4yXx+Or5Lgn1xXUeElp +cj8i69kiAsbFcByaE6X3MwtRtceTT9Edu4WzpCWxVfQyKIQliXEXJ9jaPuhdPt1EO hPTTraFVvOo4PuszlnUsVbUVQUggXvzt/b36cPf3IquLaD83kojbUDODfNp+wT8Qnk rI2SfYkMFrUIaTNggJBf3zCEFOjGEO3szpfqF7F/VaaNyAUHWaDczx4OxbnERjzweR DJEEn+vReYcCj0bTRNiF21fVJnOstGn5xp5kbalE8IMqei4+oKEuSso3nQa0xJ0jNL NVn1p1MByEg6w== From: Arnd Bergmann To: llvm@lists.linux.dev, Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Maximilian Luz , Nathan Chancellor Cc: Arnd Bergmann , Nick Desaulniers , Bill Wendling , Justin Stitt , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Andy Shevchenko , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/9] surface3_power: avoid format string truncation warning Date: Tue, 26 Mar 2024 23:38:04 +0100 Message-Id: <20240326223825.4084412-6-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240326223825.4084412-1-arnd@kernel.org> References: <20240326223825.4084412-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann clang warns about printing a pair of escaped strings into a buffer that is too short: drivers/platform/surface/surface3_power.c:248:3: error: 'snprintf' will alw= ays be truncated; specified size is 10, but format string expands to at lea= st 12 [-Werror,-Wformat-truncation-non-kprintf] 248 | snprintf(bix->serial, ARRAY_SIZE(bix->serial), "%3p= E%6pE", buf + 7, buf); | ^ Change the format string two print two less bytes so it always fits. The st= ring is still truncated, so there is no change in behavior, but the compiler no longer warns about it. Fixes: 85f7582cd484 ("platform/surface: Move Surface 3 Power OpRegion drive= r to platform/surface") Signed-off-by: Arnd Bergmann --- Not entirely sure about this one, as I've never used escaped strings, and don't know if gcc is correct to warn here, or if the kernel defines it differently from the standard. --- drivers/platform/surface/surface3_power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/surface/surface3_power.c b/drivers/platform/s= urface/surface3_power.c index 4c0f92562a79..72f904761fde 100644 --- a/drivers/platform/surface/surface3_power.c +++ b/drivers/platform/surface/surface3_power.c @@ -245,7 +245,7 @@ static int mshw0011_bix(struct mshw0011_data *cdata, st= ruct bix *bix) dev_err(&client->dev, "Error reading serial no: %d\n", ret); return ret; } else { - snprintf(bix->serial, ARRAY_SIZE(bix->serial), "%3pE%6pE", buf + 7, buf); + snprintf(bix->serial, ARRAY_SIZE(bix->serial), "%3pE%4pE", buf + 7, buf); } =20 /* get cycle count */ --=20 2.39.2 From nobody Mon Feb 9 01:45:13 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00F4F13E6C5; Tue, 26 Mar 2024 22:40:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711492848; cv=none; b=PKUMKEA/x6cnLaO28xanJeC67cSQVZ40BZm4jn8hAPhu4Jct+3+vOQhiIqyNCBOs8URRC+AW3woSLTIIC4pHNyGoSuTD4TYuVDpLAfAS99HFM0g/zPF8U3WMA+G3A70PirolyheqPHEu+WeGQXz9w3kMQclymBiju6Ys/h/5enw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711492848; c=relaxed/simple; bh=iaotj1iZQ8IOaXKa3sSgBb9LPDG2URR87VML4Asl6ZI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VRBQknGcCgMEFY9pIY0qQhRKpUQp6Zx9//KkxlzYPt3oq+eiRaqcX4YW+9zS4Ue3ulJ5UzwnWJ4M6TJqPgU2409PRVDq/y5ZgK0ZbHNJGuOcwBjyrRPgIrQE+sgcnglOQgPMANLckm/au5Hso3ETLCFRguZzG/V4wLC+KNAYyTI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ODHnADV8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ODHnADV8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 897A9C433F1; Tue, 26 Mar 2024 22:40:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711492847; bh=iaotj1iZQ8IOaXKa3sSgBb9LPDG2URR87VML4Asl6ZI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ODHnADV8jbM1W2YmWlXbh+RY49mjLG3aluEG3tx+tMw+PQaTBk0E3Hn/ulcUNVdjw McUs8XBCAaX4PJeU7h+HtO5xr4XRyefi+bwFim4AgFaCvLpW4Z7RJyDojCYHnvUt2J s/D4ZNnNLr53uFEBh9q6QnsfcKbagk4CBO4zgit+qyqm5GI+xP3OFxeWeqcU5FsWvV U/h9UcDRN7Pwx/qFtLEkg2VRhcCqxik7J2ZQE3RM8ylDYnhepyIVgqzH4sojgBViDl I1VP9IkpTDXqdRvimcukslPS5JX7UKbWx09jD8NbcVDtswEQbCbfKx1IZCkQKhOTX8 Z4bWASyfJpaXw== From: Arnd Bergmann To: llvm@lists.linux.dev, Dmitry Torokhov , Nathan Chancellor Cc: Arnd Bergmann , Nick Desaulniers , Bill Wendling , Justin Stitt , ye xingchen , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 6/9] Input: IMS: fix printf string overflow Date: Tue, 26 Mar 2024 23:38:05 +0100 Message-Id: <20240326223825.4084412-7-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240326223825.4084412-1-arnd@kernel.org> References: <20240326223825.4084412-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann clang warns about a string overflow in this driver drivers/input/misc/ims-pcu.c:1802:2: error: 'snprintf' will always be trunc= ated; specified size is 10, but format string expands to at least 12 [-Werr= or,-Wformat-truncation] drivers/input/misc/ims-pcu.c:1814:2: error: 'snprintf' will always be trunc= ated; specified size is 10, but format string expands to at least 12 [-Werr= or,-Wformat-truncation] Make the buffer a little longer to ensure it always fits. Fixes: 628329d52474 ("Input: add IMS Passenger Control Unit driver") Signed-off-by: Arnd Bergmann --- drivers/input/misc/ims-pcu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c index 6e8cc28debd9..80d16c92a08b 100644 --- a/drivers/input/misc/ims-pcu.c +++ b/drivers/input/misc/ims-pcu.c @@ -42,8 +42,8 @@ struct ims_pcu_backlight { #define IMS_PCU_PART_NUMBER_LEN 15 #define IMS_PCU_SERIAL_NUMBER_LEN 8 #define IMS_PCU_DOM_LEN 8 -#define IMS_PCU_FW_VERSION_LEN (9 + 1) -#define IMS_PCU_BL_VERSION_LEN (9 + 1) +#define IMS_PCU_FW_VERSION_LEN 16 +#define IMS_PCU_BL_VERSION_LEN 16 #define IMS_PCU_BL_RESET_REASON_LEN (2 + 1) =20 #define IMS_PCU_PCU_B_DEVICE_ID 5 --=20 2.39.2 From nobody Mon Feb 9 01:45:13 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2598113E8B1; Tue, 26 Mar 2024 22:41:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711492863; cv=none; b=NglonPSZUhmJasQqAmSjxpZKqKDtlNR7/gR/hl+TOV1OjV0hnSUfL7cq1LmVxmxQmqfV7vVENyPLpYPPKVVJBEncwJq+RjXT3YKGgUwIhH08GJByYog1hFwqrV7AFxqIJUqhedvvlOcboLOBmVAGp1v4z8+8EzkvmVaAbN+mpMM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711492863; c=relaxed/simple; bh=6TL/XYClRKFhuMXHi313KECyg4EV2GY5zSWVL7+tLGg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=THVvTA0Ih/Z4P5dc8Xhfxhqmk3o0y3MlQCOdAaqmD4wK9bHKvFbIjxKiL++EGNnSeuDetyygGCM/ZV2/1DWdzP1mKpn2iKVe63/7Crexf3Dr1xEir7ZUiCVaTyhWcAVOQSMP+gGfMuP2O5zRAG/Gy4zn5jGEYQRtaCR7FrVG9wo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ds06LGvP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ds06LGvP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96523C433F1; Tue, 26 Mar 2024 22:41:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711492863; bh=6TL/XYClRKFhuMXHi313KECyg4EV2GY5zSWVL7+tLGg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ds06LGvPd0l5RyCqb2XiZaemnyLBs7bntJWrcE60bd+e+5O1j618Bs5AN5pwQYxJx +283FYQcjVlCmDxzYOTgFn1rQPMlRcae2Y3CyhyoFU9hsdsLCOzJXb5khUoM2xv8rh vk07jEb4jHFQP0OUU28CdxwlNZw5mi0pf+gY46qDsDeeKNzGZjZsGsPm9xX2obyxmZ 9DIxU7gT1623GFxIg+5+mM3k8KlUKcR7lVVsfbB58t2vKI6af8ISvFmxE9hcJavJEU MK0nDJL894ramgqgz2ODdI/AbbQWQTC+XNPcGObZ/NP1R2tZqtV9kthus38o+3jJgD L8XXjEpouITTA== From: Arnd Bergmann To: llvm@lists.linux.dev, Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" Cc: Arnd Bergmann , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 7/9] scsi: mylex: fix sysfs buffer lengths Date: Tue, 26 Mar 2024 23:38:06 +0100 Message-Id: <20240326223825.4084412-8-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240326223825.4084412-1-arnd@kernel.org> References: <20240326223825.4084412-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann The myrb and myrs drivers use an odd way of implementing their sysfs files, calling snprintf() with a fixed length of 32 bytes to print into a page sized buffer. One of the strings is actually longer than 32 bytes, which clang can warn about: drivers/scsi/myrb.c:1906:10: error: 'snprintf' will always be truncated; sp= ecified size is 32, but format string expands to at least 34 [-Werror,-Wfor= mat-truncation] drivers/scsi/myrs.c:1089:10: error: 'snprintf' will always be truncated; sp= ecified size is 32, but format string expands to at least 34 [-Werror,-Wfor= mat-truncation] These could all be plain sprintf() without a length as the buffer is always long enough. On the other hand, sysfs files should not be overly long either, so just double the length to make sure the longest strings don't get truncated here. Fixes: 77266186397c ("scsi: myrs: Add Mylex RAID controller (SCSI interface= )") Fixes: 081ff398c56c ("scsi: myrb: Add Mylex RAID controller (block interfac= e)") Signed-off-by: Arnd Bergmann Reviewed-by: Hannes Reinecke --- drivers/scsi/myrb.c | 20 ++++++++++---------- drivers/scsi/myrs.c | 24 ++++++++++++------------ 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/scsi/myrb.c b/drivers/scsi/myrb.c index ca2e932dd9b7..f684eb5e0489 100644 --- a/drivers/scsi/myrb.c +++ b/drivers/scsi/myrb.c @@ -1775,9 +1775,9 @@ static ssize_t raid_state_show(struct device *dev, =20 name =3D myrb_devstate_name(ldev_info->state); if (name) - ret =3D snprintf(buf, 32, "%s\n", name); + ret =3D snprintf(buf, 64, "%s\n", name); else - ret =3D snprintf(buf, 32, "Invalid (%02X)\n", + ret =3D snprintf(buf, 64, "Invalid (%02X)\n", ldev_info->state); } else { struct myrb_pdev_state *pdev_info =3D sdev->hostdata; @@ -1796,9 +1796,9 @@ static ssize_t raid_state_show(struct device *dev, else name =3D myrb_devstate_name(pdev_info->state); if (name) - ret =3D snprintf(buf, 32, "%s\n", name); + ret =3D snprintf(buf, 64, "%s\n", name); else - ret =3D snprintf(buf, 32, "Invalid (%02X)\n", + ret =3D snprintf(buf, 64, "Invalid (%02X)\n", pdev_info->state); } return ret; @@ -1886,11 +1886,11 @@ static ssize_t raid_level_show(struct device *dev, =20 name =3D myrb_raidlevel_name(ldev_info->raid_level); if (!name) - return snprintf(buf, 32, "Invalid (%02X)\n", + return snprintf(buf, 64, "Invalid (%02X)\n", ldev_info->state); - return snprintf(buf, 32, "%s\n", name); + return snprintf(buf, 64, "%s\n", name); } - return snprintf(buf, 32, "Physical Drive\n"); + return snprintf(buf, 64, "Physical Drive\n"); } static DEVICE_ATTR_RO(raid_level); =20 @@ -1903,15 +1903,15 @@ static ssize_t rebuild_show(struct device *dev, unsigned char status; =20 if (sdev->channel < myrb_logical_channel(sdev->host)) - return snprintf(buf, 32, "physical device - not rebuilding\n"); + return snprintf(buf, 64, "physical device - not rebuilding\n"); =20 status =3D myrb_get_rbld_progress(cb, &rbld_buf); =20 if (rbld_buf.ldev_num !=3D sdev->id || status !=3D MYRB_STATUS_SUCCESS) - return snprintf(buf, 32, "not rebuilding\n"); + return snprintf(buf, 64, "not rebuilding\n"); =20 - return snprintf(buf, 32, "rebuilding block %u of %u\n", + return snprintf(buf, 64, "rebuilding block %u of %u\n", rbld_buf.ldev_size - rbld_buf.blocks_left, rbld_buf.ldev_size); } diff --git a/drivers/scsi/myrs.c b/drivers/scsi/myrs.c index a1eec65a9713..e824be9d9bbb 100644 --- a/drivers/scsi/myrs.c +++ b/drivers/scsi/myrs.c @@ -947,9 +947,9 @@ static ssize_t raid_state_show(struct device *dev, =20 name =3D myrs_devstate_name(ldev_info->dev_state); if (name) - ret =3D snprintf(buf, 32, "%s\n", name); + ret =3D snprintf(buf, 64, "%s\n", name); else - ret =3D snprintf(buf, 32, "Invalid (%02X)\n", + ret =3D snprintf(buf, 64, "Invalid (%02X)\n", ldev_info->dev_state); } else { struct myrs_pdev_info *pdev_info; @@ -958,9 +958,9 @@ static ssize_t raid_state_show(struct device *dev, pdev_info =3D sdev->hostdata; name =3D myrs_devstate_name(pdev_info->dev_state); if (name) - ret =3D snprintf(buf, 32, "%s\n", name); + ret =3D snprintf(buf, 64, "%s\n", name); else - ret =3D snprintf(buf, 32, "Invalid (%02X)\n", + ret =3D snprintf(buf, 64, "Invalid (%02X)\n", pdev_info->dev_state); } return ret; @@ -1066,13 +1066,13 @@ static ssize_t raid_level_show(struct device *dev, ldev_info =3D sdev->hostdata; name =3D myrs_raid_level_name(ldev_info->raid_level); if (!name) - return snprintf(buf, 32, "Invalid (%02X)\n", + return snprintf(buf, 64, "Invalid (%02X)\n", ldev_info->dev_state); =20 } else name =3D myrs_raid_level_name(MYRS_RAID_PHYSICAL); =20 - return snprintf(buf, 32, "%s\n", name); + return snprintf(buf, 64, "%s\n", name); } static DEVICE_ATTR_RO(raid_level); =20 @@ -1086,7 +1086,7 @@ static ssize_t rebuild_show(struct device *dev, unsigned char status; =20 if (sdev->channel < cs->ctlr_info->physchan_present) - return snprintf(buf, 32, "physical device - not rebuilding\n"); + return snprintf(buf, 64, "physical device - not rebuilding\n"); =20 ldev_info =3D sdev->hostdata; ldev_num =3D ldev_info->ldev_num; @@ -1098,11 +1098,11 @@ static ssize_t rebuild_show(struct device *dev, return -EIO; } if (ldev_info->rbld_active) { - return snprintf(buf, 32, "rebuilding block %zu of %zu\n", + return snprintf(buf, 64, "rebuilding block %zu of %zu\n", (size_t)ldev_info->rbld_lba, (size_t)ldev_info->cfg_devsize); } else - return snprintf(buf, 32, "not rebuilding\n"); + return snprintf(buf, 64, "not rebuilding\n"); } =20 static ssize_t rebuild_store(struct device *dev, @@ -1190,7 +1190,7 @@ static ssize_t consistency_check_show(struct device *= dev, unsigned short ldev_num; =20 if (sdev->channel < cs->ctlr_info->physchan_present) - return snprintf(buf, 32, "physical device - not checking\n"); + return snprintf(buf, 64, "physical device - not checking\n"); =20 ldev_info =3D sdev->hostdata; if (!ldev_info) @@ -1198,11 +1198,11 @@ static ssize_t consistency_check_show(struct device= *dev, ldev_num =3D ldev_info->ldev_num; myrs_get_ldev_info(cs, ldev_num, ldev_info); if (ldev_info->cc_active) - return snprintf(buf, 32, "checking block %zu of %zu\n", + return snprintf(buf, 64, "checking block %zu of %zu\n", (size_t)ldev_info->cc_lba, (size_t)ldev_info->cfg_devsize); else - return snprintf(buf, 32, "not checking\n"); + return snprintf(buf, 64, "not checking\n"); } =20 static ssize_t consistency_check_store(struct device *dev, --=20 2.39.2 From nobody Mon Feb 9 01:45:13 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6225813E028; Tue, 26 Mar 2024 22:41:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711492874; cv=none; b=isajWuSbmGMVvJV25wyB6vdZJX/Hi537+VyQKcrTgEhpHNKDQnqbFr2JCR04BIpzrHHDMBb3/j2tqwrcqxJ9xSwndyKqpYC8l568QoFm/b+7tqQVn/OTUtZqfdy83kTmcl0Ck1Azi/A8+YpR1ghOXaNTXra7kD78dShwaxA2DsI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711492874; c=relaxed/simple; bh=fE8YQ0ldH4jAPvC8YbW24he4IxhcXj1g5OmwhFjAj+g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GLOPxDeMUFjWS4XdW8RmxFtfGyNbL1W0DQ/BjOh7ffpdJ2IZ9z2y8brxPXZGEX+SGkVym8WYKmg8TCPTaDqt9gFTg3mP4gx55xg+wjc0xam1gLKPQcwyfXesG/UQEhtM1bND5JQ2cH7R2NwKPwpsQTVH96JdHmtU9M2mZEB1MhU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ICJtMX3p; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ICJtMX3p" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A94DC433F1; Tue, 26 Mar 2024 22:41:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711492873; bh=fE8YQ0ldH4jAPvC8YbW24he4IxhcXj1g5OmwhFjAj+g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ICJtMX3pCuiusynEfe3bAP6Lspz0zcyuLbBOka+EOsCaOFZME4FZ4QIKrK/MZdJmq Ctvnh5OIwUz+4zf2REjGVM2wdtuYwLoVkURryHKORb15fiwpv0FTQMJtESTGs4TGQ9 M95cMSdR9qm2j/ow8DdkaA96bSW6B+j3pXIETUi2N1JbBiGG6nS+FatuULN7WX9ApY OEQW8S0LDu+tihl3F/LXp4MYlPtjNGctBOW8AUwWSRImiBVjqWYm1AiepC0fk/OF4a ICeRLsN9MuXhJv/PBCigSpwkmoq065lOs3WVMt19zKcKFsi3X/clDOsIaByQv9Gr8K a1f7cxjjNEj7Q== From: Arnd Bergmann To: llvm@lists.linux.dev, Johannes Berg , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Rob Herring Cc: Arnd Bergmann , Nick Desaulniers , Bill Wendling , Justin Stitt , Jakub Kicinski , Dawei Li , linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 8/9] ALSA: aoa: avoid false-positive format truncation warning Date: Tue, 26 Mar 2024 23:38:07 +0100 Message-Id: <20240326223825.4084412-9-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240326223825.4084412-1-arnd@kernel.org> References: <20240326223825.4084412-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann clang warns about what it interprets as a truncated snprintf: sound/aoa/soundbus/i2sbus/core.c:171:6: error: 'snprintf' will always be tr= uncated; specified size is 6, but format string expands to at least 7 [-Wer= ror,-Wformat-truncation-non-kprintf] The actual problem here is that it does not understand the special %pOFn format string and assumes that it is a pointer followed by the string "OFn", which would indeed not fit. Slightly increasing the size of the buffer to its natural alignment avoids the warning, as it is now long enough for the correct and the incorrect interprations. Fixes: b917d58dcfaa ("ALSA: aoa: Convert to using %pOFn instead of device_n= ode.name") Signed-off-by: Arnd Bergmann --- sound/aoa/soundbus/i2sbus/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/aoa/soundbus/i2sbus/core.c b/sound/aoa/soundbus/i2sbus/c= ore.c index b8ff5cccd0c8..5431d2c49421 100644 --- a/sound/aoa/soundbus/i2sbus/core.c +++ b/sound/aoa/soundbus/i2sbus/core.c @@ -158,7 +158,7 @@ static int i2sbus_add_dev(struct macio_dev *macio, struct device_node *child, *sound =3D NULL; struct resource *r; int i, layout =3D 0, rlen, ok =3D force; - char node_name[6]; + char node_name[8]; static const char *rnames[] =3D { "i2sbus: %pOFn (control)", "i2sbus: %pOFn (tx)", "i2sbus: %pOFn (rx)" }; --=20 2.39.2 From nobody Mon Feb 9 01:45:13 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B3B713E3E0; Tue, 26 Mar 2024 22:41:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711492882; cv=none; b=DFiahEEvWs3ILjgq0IwFsCc6y7Vm4pZpEnBe5hW8SoMThkSDUrDJm+Y1NDH8VbGQ5TQe7+TgO1Sz2h8KhrxeYRm3LHukQ4GEQt2JC1/kXSUyFDRgWCsEQ3cW4HGTRs3NdmFP8CjBAcEh5w5INQdsNHW+FNaHmQRkCrfr8Zs/aZ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711492882; c=relaxed/simple; bh=BHHE3ORH5YV5tg3gu2Rwntqjj9sCTM2b4pqOaKJSHJY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=J9OjHCNf1BghRpiixFHXrhf+KwfYSUOEXUXPrr8QxMI14mgKjOFnTTX2lIef+X+ZjTCHyROitPZldZXDzgzMY8qPRwWCHGHS7v5vBzVh4rAALuWLNZyfVNBl4eAH1HZnhf0dY70ewZHleCEYwQUgY/3orWaUEFYFmXM/rLXav0o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=I9fQ35pf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="I9fQ35pf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC3ACC433F1; Tue, 26 Mar 2024 22:41:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711492882; bh=BHHE3ORH5YV5tg3gu2Rwntqjj9sCTM2b4pqOaKJSHJY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I9fQ35pfMxFLBIfKGlKWnIJLrE+vSgKdW74QfNRyDBLX6zoZHWGKVsZ8zj1v+qzZK rsLWOzLlnUi5DaQklbuXHCpM5y0uJjQxvHn5/T/6VJ6J8xgK1/RrRIrgnrWN+lOu0q N8zMbU0hFv6oUX9Cfk88+RKSpzoAiOghhFlD7FKuSLToHcxMhj9KWhU0svyn+aelMZ 0bWpVVcfJiB3uN8W9awWRVLdx5Miroq5QcVs5em8UwxVAsGc0OKvjz2z5J0NuWXcNg eNF89gZ0xcrrQxrUJN6mjmZQXscXYbiYmna7+oI9bWmsqzerPv16CzS6AA0aG3qobf ek85NmEPOEF+Q== From: Arnd Bergmann To: llvm@lists.linux.dev, Masahiro Yamada , Nathan Chancellor Cc: Arnd Bergmann , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 9/9] kbuild: enable -Wformat-truncation on clang Date: Tue, 26 Mar 2024 23:38:08 +0100 Message-Id: <20240326223825.4084412-10-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240326223825.4084412-1-arnd@kernel.org> References: <20240326223825.4084412-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann This warning option still produces output on gcc but is now clean when building with clang, so enable it conditionally on the compiler for now. As far as I can tell, the remaining warnings with gcc are the result of analysing the code more deeply across inlining, while clang only does this within a function. Signed-off-by: Arnd Bergmann --- scripts/Makefile.extrawarn | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn index bff6c686df7c..aa1c716c4812 100644 --- a/scripts/Makefile.extrawarn +++ b/scripts/Makefile.extrawarn @@ -99,7 +99,9 @@ KBUILD_CFLAGS +=3D $(call cc-disable-warning, unused-but-= set-variable) KBUILD_CFLAGS +=3D $(call cc-disable-warning, unused-const-variable) KBUILD_CFLAGS +=3D $(call cc-disable-warning, packed-not-aligned) KBUILD_CFLAGS +=3D $(call cc-disable-warning, format-overflow) +ifdef CONFIG_CC_IS_GCC KBUILD_CFLAGS +=3D $(call cc-disable-warning, format-truncation) +endif KBUILD_CFLAGS +=3D $(call cc-disable-warning, stringop-truncation) =20 KBUILD_CFLAGS +=3D -Wno-override-init # alias for -Wno-initializer-overrid= es in clang --=20 2.39.2