From nobody Sun Feb 8 06:33:52 2026 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D33D129A6B for ; Tue, 26 Mar 2024 18:45:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711478757; cv=none; b=UchqZrJ07vg6xMzynjFVOTB3PC+Vtr4KTd1bzcDEL3ouI72UES0wA3f+BN2S4q2DDGEHt6jlHyPJHdfz8+UNlpD12MBQovS0pNtXaiIV4ryoNh1XmaCqbjptzx8oYi100PGRilg5I5apZQBJHPx7Ea5p5kF+SEIlwvbfL053AqE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711478757; c=relaxed/simple; bh=3NbIzqycd8xlypIi2qwc6u8vg1yB79by9UZm2rl/1PQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=M0XG/LVMuMDcA2ASnn/L6E1SVlAbMdtkdv2MZD45IEpll1Z2GTDkJRhab+NHfYNsu3WnutOZBo3Gy/dn5CuQ8A+4j85cxLD55oDxX3/WbNz/wbClrQjx5EfIz+hq1EBVoI7fuibIOPY7xD0AsapQKrCpskoPKOS/prp2m6/Cjpc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fbFPNoPB; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fbFPNoPB" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-513d23be0b6so6991377e87.0 for ; Tue, 26 Mar 2024 11:45:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711478753; x=1712083553; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FaewesxWwXF9SrBXj45sOscWiVNowam2VIxNVohVdmE=; b=fbFPNoPB4PIUvpH+af6m0udg8aZcKMR3Eo+tTbeFhDxqg1+DL9TMytTgUVp9Rr12PV wnDduDDsXP2nre7jfPJtTn0VQEFSKECzBQpPkfnyzoPWMHqgYO6bSG1NAWfbH9QdpPQI 406ZW5G7KtfF319akZiTpP81ihYSBv/7G8bgYn3MGvLk3KbllSQXYhbAfkYI+Iv8MkNZ PEuSOvMiF/jJF5Drlf4DZs9sA3KfSC9z01GUaumLVahC9yUML3gJSv/IbjfUMaNerKt7 MEhAaGLSyp5Gng95fBpvGK8m4VISzINcS3xHurzaDAOAMqBTOkjPrFPcEb+92FQMhzHh LUGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711478753; x=1712083553; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FaewesxWwXF9SrBXj45sOscWiVNowam2VIxNVohVdmE=; b=rYyKN+87IcyfgyalDtkxF4ykTg1XvFcfAKFWqz/W+hcmx3M4yjG1axp83D0igM7QY1 roug9H/yDGb0jQFqEcYg/SARVasOaOTH0Gyw8kFiBmqncXbatRAOowSjZXSeNO/k41Me siBFV+QgfPDVzGm6+o0/X+pzUNOL2ib3trJwlRksKP5hz3qsKe34Fquy5YFGPpej8qbd GG3w/+RrL9w/aC/0iY1sAjm50Q7bIiZQFm9A+n40W1n3ox2lJ4960OGm3MXKs3/i9SrZ uBXmit8RJjZFKfBt3ulHewgWKhvIvUFgprJsrH2mWuLaZQSBgmkrR8Udsk3/kHM4bok3 cQ1A== X-Gm-Message-State: AOJu0Yy/AncV6arqUe02OOTnIFhcdSaNNevTq5NcbYGMZzYr5WWVC60i Ig1dG6D4CipHXaTgu4Xo0AyBiOHWHmCPt51DG53aeO7WEpw1JZ5bt6nNjMP1 X-Google-Smtp-Source: AGHT+IEKaji2mkFAStyPQyPTfeOptFG+b5kG0FSe/18W2hU9ZFdWuxTEUoduwNOhrBUXf485wO4w4A== X-Received: by 2002:ac2:5b87:0:b0:515:9313:572f with SMTP id o7-20020ac25b87000000b005159313572fmr8981273lfn.8.1711478753187; Tue, 26 Mar 2024 11:45:53 -0700 (PDT) Received: from localhost.localdomain (109-252-14-191.nat.spd-mgts.ru. [109.252.14.191]) by smtp.gmail.com with ESMTPSA id v20-20020ac25594000000b00513e6c170cdsm1580523lfg.254.2024.03.26.11.45.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 11:45:52 -0700 (PDT) From: Maxim Moskalets X-Google-Original-From: Maxim Moskalets To: linux-kernel@vger.kernel.org Cc: maximmosk4@gmail.com, Maxim Moskalets Subject: [PATCH 1/8] bpf: replace seq_puts by seq_putc Date: Tue, 26 Mar 2024 21:45:49 +0300 Message-Id: <20240326184549.8555-1-Maxim.Moskalets@kaspersky.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240326184514.8478-1-Maxim.Moskalets@kaspersky.com> References: <20240326184514.8478-1-Maxim.Moskalets@kaspersky.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using seq_putc for single characters is faster and more appropriate than seq_puts, since only one character is passed and there is no need to use a more powerful and less fast function. Signed-off-by: Maxim Moskalets --- kernel/bpf/arraymap.c | 6 +++--- kernel/bpf/bpf_struct_ops.c | 2 +- kernel/bpf/hashtab.c | 4 ++-- kernel/bpf/local_storage.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/kernel/bpf/arraymap.c b/kernel/bpf/arraymap.c index 13358675ff2e..d45bffe49dea 100644 --- a/kernel/bpf/arraymap.c +++ b/kernel/bpf/arraymap.c @@ -457,7 +457,7 @@ static void array_map_seq_show_elem(struct bpf_map *map= , void *key, if (map->btf_key_type_id) seq_printf(m, "%u: ", *(u32 *)key); btf_type_seq_show(map->btf, map->btf_value_type_id, value, m); - seq_puts(m, "\n"); + seq_putc(m, '\n'); =20 rcu_read_unlock(); } @@ -478,7 +478,7 @@ static void percpu_array_map_seq_show_elem(struct bpf_m= ap *map, void *key, seq_printf(m, "\tcpu%d: ", cpu); btf_type_seq_show(map->btf, map->btf_value_type_id, per_cpu_ptr(pptr, cpu), m); - seq_puts(m, "\n"); + seq_putc(m, '\n'); } seq_puts(m, "}\n"); =20 @@ -955,7 +955,7 @@ static void prog_array_map_seq_show_elem(struct bpf_map= *map, void *key, prog_id =3D prog_fd_array_sys_lookup_elem(ptr); btf_type_seq_show(map->btf, map->btf_value_type_id, &prog_id, m); - seq_puts(m, "\n"); + seq_putc(m, '\n'); } } =20 diff --git a/kernel/bpf/bpf_struct_ops.c b/kernel/bpf/bpf_struct_ops.c index 43356faaa057..bf94043f0975 100644 --- a/kernel/bpf/bpf_struct_ops.c +++ b/kernel/bpf/bpf_struct_ops.c @@ -833,7 +833,7 @@ static void bpf_struct_ops_map_seq_show_elem(struct bpf= _map *map, void *key, btf_type_seq_show(st_map->btf, map->btf_vmlinux_value_type_id, value, m); - seq_puts(m, "\n"); + seq_putc(m, '\n'); } =20 kfree(value); diff --git a/kernel/bpf/hashtab.c b/kernel/bpf/hashtab.c index 3a088a5349bc..db5105275545 100644 --- a/kernel/bpf/hashtab.c +++ b/kernel/bpf/hashtab.c @@ -1577,7 +1577,7 @@ static void htab_map_seq_show_elem(struct bpf_map *ma= p, void *key, btf_type_seq_show(map->btf, map->btf_key_type_id, key, m); seq_puts(m, ": "); btf_type_seq_show(map->btf, map->btf_value_type_id, value, m); - seq_puts(m, "\n"); + seq_putc(m, '\n'); =20 rcu_read_unlock(); } @@ -2421,7 +2421,7 @@ static void htab_percpu_map_seq_show_elem(struct bpf_= map *map, void *key, seq_printf(m, "\tcpu%d: ", cpu); btf_type_seq_show(map->btf, map->btf_value_type_id, per_cpu_ptr(pptr, cpu), m); - seq_puts(m, "\n"); + seq_putc(m, '\n'); } seq_puts(m, "}\n"); =20 diff --git a/kernel/bpf/local_storage.c b/kernel/bpf/local_storage.c index a04f505aefe9..3969eb0382af 100644 --- a/kernel/bpf/local_storage.c +++ b/kernel/bpf/local_storage.c @@ -431,7 +431,7 @@ static void cgroup_storage_seq_show_elem(struct bpf_map= *map, void *key, seq_puts(m, ": "); btf_type_seq_show(map->btf, map->btf_value_type_id, &READ_ONCE(storage->buf)->data[0], m); - seq_puts(m, "\n"); + seq_putc(m, '\n'); } else { seq_puts(m, ": {\n"); for_each_possible_cpu(cpu) { @@ -439,7 +439,7 @@ static void cgroup_storage_seq_show_elem(struct bpf_map= *map, void *key, btf_type_seq_show(map->btf, map->btf_value_type_id, per_cpu_ptr(storage->percpu_buf, cpu), m); - seq_puts(m, "\n"); + seq_putc(m, '\n'); } seq_puts(m, "}\n"); } --=20 2.39.2 From nobody Sun Feb 8 06:33:52 2026 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8433913C9D6 for ; Tue, 26 Mar 2024 18:46:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711478767; cv=none; b=h8rTmCx/2/8lUh+UEJhyKXTYK1EmPl2Mc5PDl6LGpFBhOKxDGNJqCSCpK68A9ZD0w6QXPRgT7vGWwT70cNa2zmhnwIqE3+aR2+yIcaIdHCYMaN8isdcLfRHbJTnBPOZ3z3PKnJtJjqSkFBFZqbQjDnDkyUbUqf8+o0QaYhX96J0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711478767; c=relaxed/simple; bh=kCyQ979AVJ0xdrSEgkcxGjUENL4xlQ2T9QgRwAx/dLw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lEOrkSXgijd4UMJkeb1BqWIMgSiyIgp7SsBs6weOqW6D0BnWJ1OIOTANtd4wbQ4ky3VKNm/cUqIINyZr7Y+pNxnkrsmnEr58l3NG3t8MKlWhVikVcql4UDeDjfWdDCg8+i5SfTADS41pVlZSoX898CJDuXCG9vdBkhWCJyOBiIU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TYMAHjHt; arc=none smtp.client-ip=209.85.208.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TYMAHjHt" Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2d4a8bddc21so78612901fa.0 for ; Tue, 26 Mar 2024 11:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711478763; x=1712083563; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8ldBOgjbepYPciYaLHBtp2xoQsBifAEwo23Ufds/fgw=; b=TYMAHjHtxdFicsSC76judKvGehkf5KyjfNY7CLHkTC8ylsBWJ7vBh2j/aF/N7E/QIa oOVWF6HWLXGs8E1ZKyQ9OZCvoncn8HZrQ7uvozUJ6PFkb+8YZ8ABI8Bv5zIPoKkqMf+I k0hbA/BJTNsPIO2Tr2J+7iMGp+nhdxGZZhwmMJuMbfKVZYQlLcRZhMM1psc7SF9UyOdK +fKESwrY2mGCOaGw9cbRCycj6JcC/BEFIr5eKF+0DhSngAYVU54w4Xz8L/25fHy+acxs C95NputAVBBwEui9Cnd4Q/6JtJ4FplSKXEGUSlMT0f0Pw2m05zQpyzp0sAM7O+OFLn+w 4Ncg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711478763; x=1712083563; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8ldBOgjbepYPciYaLHBtp2xoQsBifAEwo23Ufds/fgw=; b=OM0eL7dLwhdgIM/Yqnzoyv1Nqx2fxIH+N4cROOjgQmPcVKk0QZb4QDwN7VHXSdqlHr /4l6MMUsabsGRX2oZcILw01hm4GwkLE38CJzp4nLWkXXIUlgqtgr179zVAjh/Rme0By7 IWu5IaXatlLlWW4s35x9WIYruFmi/8mQp403lmgw86u1oYVsmPf0rKPvfMzoU2Kq0j3Z YUxHQowSdJcaOkWOr6inIwzcuua+obsOGaGAWsQTopJLeNizRRfGguC/BYGCyizTl55M 3HOGsZbt5IHSP8W1vliqT5N1JYAp3OhlqnJKH4ImMUwpDCYNabWwHV8JzWgOGVyiLkxe IYPA== X-Gm-Message-State: AOJu0YzP6VQWCQTuac0I2culs/8DqPGlW8EJb2ju7mHvYJZkPdJKh+6G 3bwOl+wFkFdoti202WHZVkoV3q7ZgmRNa/nIgUAQdigvZXfORaXEyLNUiWad X-Google-Smtp-Source: AGHT+IHistzYneoiKIftyZzW4I3+XZL2PkZbDqJAVmOmB2N8m6xuD2IiTNtdXa2at08zOw5IndFWpA== X-Received: by 2002:a2e:a309:0:b0:2d4:9936:a45c with SMTP id l9-20020a2ea309000000b002d49936a45cmr337861lje.41.1711478763187; Tue, 26 Mar 2024 11:46:03 -0700 (PDT) Received: from localhost.localdomain (109-252-14-191.nat.spd-mgts.ru. [109.252.14.191]) by smtp.gmail.com with ESMTPSA id u2-20020a2e2e02000000b002d69b9a6513sm1855621lju.48.2024.03.26.11.46.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 11:46:02 -0700 (PDT) From: Maxim Moskalets X-Google-Original-From: Maxim Moskalets To: linux-kernel@vger.kernel.org Cc: maximmosk4@gmail.com, Maxim Moskalets Subject: [PATCH 2/8] cgroup: replace seq_puts by seq_putc Date: Tue, 26 Mar 2024 21:45:58 +0300 Message-Id: <20240326184558.8583-1-Maxim.Moskalets@kaspersky.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240326184514.8478-1-Maxim.Moskalets@kaspersky.com> References: <20240326184514.8478-1-Maxim.Moskalets@kaspersky.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using seq_putc for single characters is faster and more appropriate than seq_puts, since only one character is passed and there is no need to use a more powerful and less fast function. Signed-off-by: Maxim Moskalets --- kernel/cgroup/cgroup.c | 2 +- kernel/cgroup/debug.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index a66c088c851c..011db8474d69 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -6300,7 +6300,7 @@ int proc_cgroup_show(struct seq_file *m, struct pid_n= amespace *ns, =20 seq_puts(m, buf); } else { - seq_puts(m, "/"); + seq_putc(m, '/'); } =20 if (cgroup_on_dfl(cgrp) && cgroup_is_dead(cgrp)) diff --git a/kernel/cgroup/debug.c b/kernel/cgroup/debug.c index 80aa3f027ac3..d18f7dcb4def 100644 --- a/kernel/cgroup/debug.c +++ b/kernel/cgroup/debug.c @@ -55,7 +55,7 @@ static int current_css_set_read(struct seq_file *seq, voi= d *v) seq_printf(seq, "css_set %pK %d", cset, refcnt); if (refcnt > cset->nr_tasks) seq_printf(seq, " +%d", refcnt - cset->nr_tasks); - seq_puts(seq, "\n"); + seq_putc(seq, '\n'); =20 /* * Print the css'es stored in the current css_set. @@ -159,7 +159,7 @@ static int cgroup_css_links_read(struct seq_file *seq, = void *v) extra_refs +=3D extra; } } - seq_puts(seq, "\n"); + seq_putc(seq, '\n'); =20 list_for_each_entry(task, &cset->tasks, cg_list) { if (count++ <=3D MAX_TASKS_SHOWN_PER_CSS) @@ -189,7 +189,7 @@ static int cgroup_css_links_read(struct seq_file *seq, = void *v) if (!dead_cnt && !extra_refs && !threaded_csets) return 0; =20 - seq_puts(seq, "\n"); + seq_putc(seq, '\n'); if (threaded_csets) seq_printf(seq, "threaded css_sets =3D %d\n", threaded_csets); if (extra_refs) --=20 2.39.2 From nobody Sun Feb 8 06:33:52 2026 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CDD213C3D8 for ; Tue, 26 Mar 2024 18:46:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711478812; cv=none; b=tYuBbZCDiayLkWvlh3HMC4RqYIyNFqzFMU/QfPbx3UAtKjNixk4hqQK3G21RJLdqJHVVfMJuydqd5LB3vmab9yfJbiCgU8RmX5D4OPNqR/tq/CF2RtteNQsNiljf1WjWtn+quw9nqeKX27v/rE2N4a/0PHvXxmnq/oZPqIxAA9A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711478812; c=relaxed/simple; bh=eigWPBre8ix82nCP/Se0x1ZtUOlbqBmM58WYT9wWDE4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=TYXz/8Qgddy4BAgBTFr5kQ67I4jxyx3ftyk/f4+IMKkfAh/IdBO0hOuhwLbTLLLA3tE+roMSGP6gdE26FLbgTXWDiD/SHOyjXcC7zFce3d03LmjTRaqVdDUr1ZeqDop9mww+gmln/0k6yUHKxFy49K9Cee1SnVogy6IcWDKJutM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NsWXhVwE; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NsWXhVwE" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-513dd2d2415so6291004e87.3 for ; Tue, 26 Mar 2024 11:46:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711478808; x=1712083608; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KM+j7SWnIc800SZqJLO3ijmaBxmx9VNT9BzC59XFSoI=; b=NsWXhVwE96fTwQVwtycgChzbbvlpxmVXns7gugto8cbccGlrSkOFfKq5spkhZY/E51 pqUww/K+sEWbn9GQNhAU143JlF+fEl91E9gSgBTa6tn5Rk/UrnDstJtuUwll/5Nsxmwk hOuUNw0N9+5qqDPCNSrdEUN1OirpF1vdHhqLXF6D5OYp34zE1TbJEL4j8T6PJ+qLcDuR /NEAeO0Bot1c3qsBLFe+bp7/OjF5/JfRCYyyylD5Bq8IoKCK+Lg0FFswAp25ibN3Qyl+ vmGxdbSaJH77uaSamwJ92EganDr8DInFy6lDPZVgCV1rSsM0wNhLSI9MKKpeXltwy7gq GM0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711478808; x=1712083608; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KM+j7SWnIc800SZqJLO3ijmaBxmx9VNT9BzC59XFSoI=; b=od72CxkpN33Q4GwoHXHnJ4AxFY2EfrpHcHleQm74gzFFXiIpMsbm5eGhHLvpyl2wbT bfcMhdyOOsX/EbZU7g2CHQe0yq6zLtkN18EzdOEeSCOSdnxCxJEn0a8qtCwIAITmhH4C bjQhm0nyi0rdj09SQXSfmklFitUvI48pfI3I7rsW4UMk4qqkIzwLThBpSjl389RmKN8i Qp4hiVewMUADRQWI7P8fUnIhJW5vi1dHS6W/1UBpOgTllgLgQBK10RxcVAQDbWUXTjaT J67GbyD6lZvXHRX/h5YvIbS90cvTcQChj1o6uOm2LWc33WjCQyjfy//6RRBsWJdm0s+/ KlQA== X-Gm-Message-State: AOJu0YwBf44JIxPZ0Pg76MtLfWWNVfMiAOOo5mA1hNJn+18W3PIsHrdj kYBdWFwAb5PhLHPBP/EQm4PKV2mHRF1FrZckVfW6kyrfn1ZMf0DmbPHzR8iI X-Google-Smtp-Source: AGHT+IFelxkhcKFmmp7/mixbeup+BHJs6rctqQe4xIiikQNiFfR1ZoYCRp5HFfZoPeX7UfpQeSfXmg== X-Received: by 2002:ac2:44d5:0:b0:513:c876:c80a with SMTP id d21-20020ac244d5000000b00513c876c80amr296837lfm.34.1711478808027; Tue, 26 Mar 2024 11:46:48 -0700 (PDT) Received: from localhost.localdomain (109-252-14-191.nat.spd-mgts.ru. [109.252.14.191]) by smtp.gmail.com with ESMTPSA id s17-20020a197711000000b00513c928de7bsm1614113lfc.59.2024.03.26.11.46.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 11:46:47 -0700 (PDT) From: Maxim Moskalets X-Google-Original-From: Maxim Moskalets To: linux-kernel@vger.kernel.org Cc: maximmosk4@gmail.com, Maxim Moskalets Subject: [PATCH 3/8] trace: replace seq_puts by seq_putc Date: Tue, 26 Mar 2024 21:46:45 +0300 Message-Id: <20240326184645.8660-1-Maxim.Moskalets@kaspersky.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240326184514.8478-1-Maxim.Moskalets@kaspersky.com> References: <20240326184514.8478-1-Maxim.Moskalets@kaspersky.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using seq_putc for single characters is faster and more appropriate than seq_puts, since only one character is passed and there is no need to use a more powerful and less fast function. Signed-off-by: Maxim Moskalets --- kernel/trace/trace_events_hist.c | 26 +++++++++++++------------- kernel/trace/trace_events_user.c | 8 ++++---- kernel/trace/trace_hwlat.c | 4 ++-- 3 files changed, 19 insertions(+), 19 deletions(-) diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_h= ist.c index 6ece1308d36a..5992278cbfb5 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -4898,14 +4898,14 @@ static void print_action_spec(struct seq_file *m, for (i =3D 0; i < hist_data->n_save_vars; i++) { seq_printf(m, "%s", hist_data->save_vars[i]->var->var.name); if (i < hist_data->n_save_vars - 1) - seq_puts(m, ","); + seq_putc(m, ','); } } else if (data->action =3D=3D ACTION_TRACE) { if (data->use_trace_keyword) seq_printf(m, "%s", data->synth_event_name); for (i =3D 0; i < data->n_params; i++) { if (i || data->use_trace_keyword) - seq_puts(m, ","); + seq_putc(m, ','); seq_printf(m, "%s", data->params[i]); } } @@ -4924,7 +4924,7 @@ static void print_track_data_spec(struct seq_file *m, =20 print_action_spec(m, hist_data, data); =20 - seq_puts(m, ")"); + seq_putc(m, ')'); } =20 static void print_onmatch_spec(struct seq_file *m, @@ -4938,7 +4938,7 @@ static void print_onmatch_spec(struct seq_file *m, =20 print_action_spec(m, hist_data, data); =20 - seq_puts(m, ")"); + seq_putc(m, ')'); } =20 static bool actions_match(struct hist_trigger_data *hist_data, @@ -5413,9 +5413,9 @@ static void hist_trigger_print_key(struct seq_file *m, } =20 if (!multiline) - seq_puts(m, " "); + seq_putc(m, ' '); =20 - seq_puts(m, "}"); + seq_putc(m, '}'); } =20 /* Get the 100 times of the percentage of @val in @total */ @@ -5511,13 +5511,13 @@ static void hist_trigger_entry_print(struct seq_fil= e *m, if (flags & HIST_FIELD_FL_VAR || flags & HIST_FIELD_FL_EXPR) continue; =20 - seq_puts(m, " "); + seq_putc(m, ' '); hist_trigger_print_val(m, i, field_name, flags, stats, elt); } =20 print_actions(m, hist_data, elt); =20 - seq_puts(m, "\n"); + seq_putc(m, '\n'); } =20 static int print_entries(struct seq_file *m, @@ -5971,7 +5971,7 @@ static int event_hist_trigger_print(struct seq_file *= m, field =3D hist_data->fields[i]; =20 if (i > hist_data->n_vals) - seq_puts(m, ","); + seq_putc(m, ','); =20 if (field->flags & HIST_FIELD_FL_STACKTRACE) { if (field->field) @@ -5997,7 +5997,7 @@ static int event_hist_trigger_print(struct seq_file *= m, seq_puts(m, "hitcount"); } else { if (show_val) - seq_puts(m, ","); + seq_putc(m, ','); hist_field_print(m, field); } show_val =3D true; @@ -6006,14 +6006,14 @@ static int event_hist_trigger_print(struct seq_file= *m, if (have_var) { unsigned int n =3D 0; =20 - seq_puts(m, ":"); + seq_putc(m, ':'); =20 for_each_hist_val_field(i, hist_data) { field =3D hist_data->fields[i]; =20 if (field->flags & HIST_FIELD_FL_VAR) { if (n++) - seq_puts(m, ","); + seq_putc(m, ','); hist_field_print(m, field); } } @@ -6035,7 +6035,7 @@ static int event_hist_trigger_print(struct seq_file *= m, return -EINVAL; =20 if (i > 0) - seq_puts(m, ","); + seq_putc(m, ','); =20 if (idx =3D=3D HITCOUNT_IDX) seq_puts(m, "hitcount"); diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_u= ser.c index 70d428c394b6..762f8b4667ca 100644 --- a/kernel/trace/trace_events_user.c +++ b/kernel/trace/trace_events_user.c @@ -1823,7 +1823,7 @@ static int user_event_show(struct seq_file *m, struct= dyn_event *ev) =20 list_for_each_entry_reverse(field, head, link) { if (depth =3D=3D 0) - seq_puts(m, " "); + seq_putc(m, ' '); else seq_puts(m, "; "); =20 @@ -1835,7 +1835,7 @@ static int user_event_show(struct seq_file *m, struct= dyn_event *ev) depth++; } =20 - seq_puts(m, "\n"); + seq_putc(m, '\n'); =20 return 0; } @@ -2733,13 +2733,13 @@ static int user_seq_show(struct seq_file *m, void *= p) busy++; } =20 - seq_puts(m, "\n"); + seq_putc(m, '\n'); active++; } =20 mutex_unlock(&group->reg_mutex); =20 - seq_puts(m, "\n"); + seq_putc(m, '\n'); seq_printf(m, "Active: %d\n", active); seq_printf(m, "Busy: %d\n", busy); =20 diff --git a/kernel/trace/trace_hwlat.c b/kernel/trace/trace_hwlat.c index b791524a6536..874a81cf9bb7 100644 --- a/kernel/trace/trace_hwlat.c +++ b/kernel/trace/trace_hwlat.c @@ -636,14 +636,14 @@ static int s_mode_show(struct seq_file *s, void *v) seq_printf(s, "%s", thread_mode_str[mode]); =20 if (mode < MODE_MAX - 1) /* if mode is any but last */ - seq_puts(s, " "); + seq_putc(s, ' '); =20 return 0; } =20 static void s_mode_stop(struct seq_file *s, void *v) { - seq_puts(s, "\n"); + seq_putc(s, '\n'); mutex_unlock(&hwlat_data.lock); } =20 --=20 2.39.2 From nobody Sun Feb 8 06:33:52 2026 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 854A6482EE for ; Tue, 26 Mar 2024 18:46:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711478821; cv=none; b=GTR19wS7QPJ7nnEsF1runpua12UKw0VYUDX4NQzBszgCqqJOjOtnOGcuQ6KjEG95aYzE6aFSGwltmqN6wW8dm/8dKq9c+FVrHE9bWTJSY0AJg7JMrj1/zXm3aYkpb9Q5g4D2mhJ/41lOo8FSQjO1BiLp78uAtnbi3YE8LK2NFk0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711478821; c=relaxed/simple; bh=SVQDdIo+IQ0WeadhhI20wUD7VZOzgjNjnHROGjPd/bI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=OYeYTXz8kfM+Eb4jsX5h+Ixbo/ofe7BxjDY4Nrscw60e9oeBssdGharZF4pVEw1jSaFrvtrzPpqmY8pI4wArv5GY9LCR21oRGKfn/NaFLm581BKxO5cqwHwV0f2VfcsFSkB+q9yQhKlFW9v3gvA/fMKe1KfD0/MRGDTPG8AxD7c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Swt4ChCf; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Swt4ChCf" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2d6ee81bc87so8755741fa.1 for ; Tue, 26 Mar 2024 11:46:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711478817; x=1712083617; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=V+BNSxC+7kws2aQYyfMaC/PZOxk6eYvHPt4+RUgE5vU=; b=Swt4ChCf/3jZb4dFixOWc1jV1n5bVEcl+Z91We8hWwowput8u1rMp/YSn1B/h0/rgC bGsqGwFxMbSmIoBoHuFNKhK1NgOBin1ro9PWPLLybRC7Q4I8DLXC3Jpon+eqeVFqU9zG RduJ15AT18z7WfuUqa+QwHYJ+D7UCH0Z5IxU4LdBonTLWpHPTh675VdH8JW/2Hpbp7UR 9rsshkM7xzk/5U3mufjpuRwFWlH/wMabw20iW525Ry3lEKJAQ37EmpEsTfyjREmhHtWH aLfgFl0YQl09g3XnT9lLr6ANTlbT/fK4TaqDBwsR9N2QYm3w31j4tvN0gRC47VJsgwYB dsPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711478817; x=1712083617; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V+BNSxC+7kws2aQYyfMaC/PZOxk6eYvHPt4+RUgE5vU=; b=N6HNnZV28GZOF5PCBSxJNNmt1Q1fIqyKXElIjQD0xh6JlbhwZuffK3g0nc9FgbRKmO c02LHvnOluEuozIxFWqRsJNnw3vdGQnxdPOvTQe565IHDsnYIfbghQoFXir5VO2KHWw8 dfmQKbMrkadvgj5vv0KSac35dFXloA6S7cz3uLBd3PRi5Fpak9tz4c6V3Lo7hQTi3MRi 4V5xF0lBMXY9pdBDqZDVlUlaTOXNmoNFHYc+xsXrQDMC8384JMZ22qYiMUr+po4RP3EH exdHur+Efn4YnoOmaFVdZ8BVun+r2ZTBO6KdS3bCyCYH+RwBXHWB9sYldDXafJKgkgJG EMjQ== X-Gm-Message-State: AOJu0YxY57R0+y7DQAKgVLY9JGcGWBIKCGYAHXrT9hbHv6OviDueexOe pfUMLf/BtLDrJ6MWqHkxbPTYRbVgktPDFcu0HKl1Xt5W5I8Byisr/+/0E5eT X-Google-Smtp-Source: AGHT+IEPwWE/NBhqg0BPrapibCjhQfoyOUUhqKZZnlaMOf/9xEDo46Cjv/+WyDv/o8gXvStyRfelXQ== X-Received: by 2002:a05:651c:2106:b0:2d4:92ea:21de with SMTP id a6-20020a05651c210600b002d492ea21demr422330ljq.0.1711478817291; Tue, 26 Mar 2024 11:46:57 -0700 (PDT) Received: from localhost.localdomain (109-252-14-191.nat.spd-mgts.ru. [109.252.14.191]) by smtp.gmail.com with ESMTPSA id u4-20020a2e91c4000000b002d6ef7199a0sm173447ljg.113.2024.03.26.11.46.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 11:46:56 -0700 (PDT) From: Maxim Moskalets X-Google-Original-From: Maxim Moskalets To: linux-kernel@vger.kernel.org Cc: maximmosk4@gmail.com, Maxim Moskalets Subject: [PATCH 4/8] module: replace seq_puts by seq_putc Date: Tue, 26 Mar 2024 21:46:54 +0300 Message-Id: <20240326184654.8700-1-Maxim.Moskalets@kaspersky.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240326184514.8478-1-Maxim.Moskalets@kaspersky.com> References: <20240326184514.8478-1-Maxim.Moskalets@kaspersky.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using seq_putc for single characters is faster and more appropriate than seq_puts, since only one character is passed and there is no need to use a more powerful and less fast function. Signed-off-by: Maxim Moskalets --- kernel/module/procfs.c | 4 ++-- kernel/module/tracking.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/module/procfs.c b/kernel/module/procfs.c index 0a4841e88adb..dc91d3dba8f3 100644 --- a/kernel/module/procfs.c +++ b/kernel/module/procfs.c @@ -35,7 +35,7 @@ static inline void print_unload_info(struct seq_file *m, = struct module *mod) } =20 if (!printed_something) - seq_puts(m, "-"); + seq_putc(m, '-'); } #else /* !CONFIG_MODULE_UNLOAD */ static inline void print_unload_info(struct seq_file *m, struct module *mo= d) @@ -99,7 +99,7 @@ static int m_show(struct seq_file *m, void *p) if (mod->taints) seq_printf(m, " %s", module_flags(mod, buf, true)); =20 - seq_puts(m, "\n"); + seq_putc(m, '\n'); return 0; } =20 diff --git a/kernel/module/tracking.c b/kernel/module/tracking.c index 16742d1c630c..dcc4dc4c7501 100644 --- a/kernel/module/tracking.c +++ b/kernel/module/tracking.c @@ -95,7 +95,7 @@ static int unloaded_tainted_modules_seq_show(struct seq_f= ile *m, void *p) buf[l++] =3D '\0'; =20 seq_printf(m, "%s (%s) %llu", mod_taint->name, buf, mod_taint->count); - seq_puts(m, "\n"); + seq_putc(m, '\n'); =20 return 0; } --=20 2.39.2 From nobody Sun Feb 8 06:33:52 2026 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 931EE13CC75 for ; Tue, 26 Mar 2024 18:47:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711478829; cv=none; b=k+buwH0/tm1IcRVRDALqQ2rsJ90V8O/wn9eJXRcP2d9b4bxZoYdixXnzsI8SfRwctxjHS+CXKrqeRFNevTsth+VMV9MsvQ+eSEQBveAosVy3WwPb0oGZLh+edZoHo7nWeLoG1zaZhq3AzNmlhftA39i42Dly9Dkjw2CzcHNayYc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711478829; c=relaxed/simple; bh=T8dQDg721TMeOxVX+4bCSMO1oVhUAaIGWnDcDr+ZAG8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qpcMt9cOV22k9iumgHC2Xi06YIfYxLn69j9F37SvczYY3QbVQZuJIupHrJKG92g0wCz9P2hJcKJRimaiiWyAP+GCqNEZDs5p5qX3cfo2w3F3XoLRRZq7huq88cnKBS0o2KZ9F66FKJBWHEXwrdlLqbtJmGvlpL2JX1qW7A5yKxc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cQMK5M0j; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cQMK5M0j" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-515a86daf09so4000933e87.3 for ; Tue, 26 Mar 2024 11:47:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711478825; x=1712083625; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DZ+eJwDoGKUGIZxflpcMnwv/9sVegxaxVgL5v55tN+g=; b=cQMK5M0jGSl10K9i4YA4DSFXTuDUQr/fe7kiQo5YOBLa1NCCHHSEJyqsc//wv8OoHp t1ZQTuXWkM4rJJxh5Hay/xmuXei+W4qZRQamI+KBjJvmmdAm9T1DGa/GPfxpwVu/2Fl/ 8bT9A0jx0gFrikClVYmwM2CnMlLOzu9W22cH5V9eyFCCRph+X+1BRxAjOrYIFIPnQbpK 880U9fZV78u8JwjUqR3BDo2oRlhAeknyRdQNKlfCW8qKqvYACuF7rlZSXRLKmQSfS+Vl gZpdq1Uts1mT1Nj+GTXYgEtAYTS0i4rgHBHA3dc3qadpc9FQ5IknSvnnwXgH9cpuI7Vn ENzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711478825; x=1712083625; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DZ+eJwDoGKUGIZxflpcMnwv/9sVegxaxVgL5v55tN+g=; b=smAvMiCehTlOZ/lwG/SnZJnjeR2gPQtAd0dOlt9GRBCOfjP5knBwWHPFG1jbf/f/y0 Xwfe2KBU5M8j07ogcg6g6RajE3pPu5JnT08hzS0p0t3+Z7wnsmHLapGxMsa1VoIEPfJO UecOFW+VLbbaWyGynr65nfAy/VeXL/fhLfxlVh5yv1nFdJDl2oI+pW8iLej/xdTKm2aW 4EKCnS0SBQCyxqM8oRVjj4OdSXoc6eJgmW8nEpPh/tTuAToERSjMWBNC8Of75frP4CEw TBwohX+9t2raOCelOxNVMctRbdU8HftmReCEZe8C62GtNiYNadK0a1Q4LA1454GcmJ3O 1MHg== X-Gm-Message-State: AOJu0YzrB4W4K/H4OyCTtjnUXTzWMkCkyxii74R0GrSwOf9WBdDWNsEW r3rWZ2DED/At3ZZeePso4JVsTv5Qy2B0EYvt7j1q3wQ6mwm9xe0NAthyQr0a X-Google-Smtp-Source: AGHT+IG0UR4ZxalYUP3/BGhC3ydzBVAx8ZbJv+hJuW20soqYkAUdt+i/vabzYxhkausLup9ufaY2ZA== X-Received: by 2002:a19:2d17:0:b0:513:e27c:78f0 with SMTP id k23-20020a192d17000000b00513e27c78f0mr7501017lfj.46.1711478825321; Tue, 26 Mar 2024 11:47:05 -0700 (PDT) Received: from localhost.localdomain (109-252-14-191.nat.spd-mgts.ru. [109.252.14.191]) by smtp.gmail.com with ESMTPSA id h10-20020ac2596a000000b00513d24f1d38sm1586371lfp.172.2024.03.26.11.47.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 11:47:04 -0700 (PDT) From: Maxim Moskalets X-Google-Original-From: Maxim Moskalets To: linux-kernel@vger.kernel.org Cc: maximmosk4@gmail.com, Maxim Moskalets Subject: [PATCH 5/8] sched: replace seq_puts by seq_putc Date: Tue, 26 Mar 2024 21:47:02 +0300 Message-Id: <20240326184702.8768-1-Maxim.Moskalets@kaspersky.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240326184514.8478-1-Maxim.Moskalets@kaspersky.com> References: <20240326184514.8478-1-Maxim.Moskalets@kaspersky.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using seq_putc for single characters is faster and more appropriate than seq_puts, since only one character is passed and there is no need to use a more powerful and less fast function. Signed-off-by: Maxim Moskalets --- kernel/sched/cpuacct.c | 4 ++-- kernel/sched/debug.c | 14 +++++++------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/kernel/sched/cpuacct.c b/kernel/sched/cpuacct.c index 0de9dda09949..0c1ce2e1c89b 100644 --- a/kernel/sched/cpuacct.c +++ b/kernel/sched/cpuacct.c @@ -245,14 +245,14 @@ static int cpuacct_all_seq_show(struct seq_file *m, v= oid *V) seq_puts(m, "cpu"); for (index =3D 0; index < CPUACCT_STAT_NSTATS; index++) seq_printf(m, " %s", cpuacct_stat_desc[index]); - seq_puts(m, "\n"); + seq_putc(m, '\n'); =20 for_each_possible_cpu(cpu) { seq_printf(m, "%d", cpu); for (index =3D 0; index < CPUACCT_STAT_NSTATS; index++) seq_printf(m, " %llu", cpuacct_cpuusage_read(ca, cpu, index)); - seq_puts(m, "\n"); + seq_putc(m, '\n'); } return 0; } diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c index 8d5d98a5834d..03d78cff66e3 100644 --- a/kernel/sched/debug.c +++ b/kernel/sched/debug.c @@ -62,7 +62,7 @@ static int sched_feat_show(struct seq_file *m, void *v) seq_puts(m, "NO_"); seq_printf(m, "%s ", sched_feat_names[i]); } - seq_puts(m, "\n"); + seq_putc(m, '\n'); =20 return 0; } @@ -251,15 +251,15 @@ static int sched_dynamic_show(struct seq_file *m, voi= d *v) =20 for (i =3D 0; i < ARRAY_SIZE(preempt_modes); i++) { if (preempt_dynamic_mode =3D=3D i) - seq_puts(m, "("); + seq_putc(m, '('); seq_puts(m, preempt_modes[i]); if (preempt_dynamic_mode =3D=3D i) - seq_puts(m, ")"); + seq_putc(m, ')'); =20 - seq_puts(m, " "); + seq_putc(m, ' '); } =20 - seq_puts(m, "\n"); + seq_putc(m, '\n'); return 0; } =20 @@ -389,9 +389,9 @@ static int sd_flags_show(struct seq_file *m, void *v) =20 for_each_set_bit(idx, &flags, __SD_FLAG_CNT) { seq_puts(m, sd_flag_debug[idx].name); - seq_puts(m, " "); + seq_putc(m, ' '); } - seq_puts(m, "\n"); + seq_putc(m, '\n'); =20 return 0; } --=20 2.39.2 From nobody Sun Feb 8 06:33:52 2026 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE7B513CFA0 for ; Tue, 26 Mar 2024 18:47:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711478837; cv=none; b=RZbm9tpJ9o1ZZLVqtzMUZGMygDSFMDPDvSKnIT3UpTmPJIQcFzlBOrLbdJsea66TEEm4E18ys3qWFBobQeX3mi2mpIVD59cjq88J88ns3JTTQdAeJ/CKefv2fAHTZEDZ8945LZ7oQ5tUyC52TAjuVHrSIAei0HRk9c4vLLy+hJM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711478837; c=relaxed/simple; bh=qJq0cSG6/Z2CaYD7aH9kWyOyMhGjPxTKdVQgOaB8aU4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QpKkxBr6bIbhDMpY2yLp1+YcIW4SRENd3l/oBQIDKCPMDhK3rs82KhMqbcyQYTjJENIX0tww9iP/SBmyWtOiwaNAi0bt1H5qjI5c529GECuISzDQNaTx1KfP9qzg2CVjSVogAPrrOhtySPJsJw//J9i3o3z3P0W583wXjXsiNFU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YUknMdlJ; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YUknMdlJ" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5101cd91017so6926441e87.2 for ; Tue, 26 Mar 2024 11:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711478833; x=1712083633; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VycL5qDrPHCDWWbHqXExQCkFHxLflz/cf4MtnxAQLPE=; b=YUknMdlJYzRpnMfixv93oT0M6Lgd6wxErkSu9vJ+dcc3ZS6pTxp0HREqyQjfTumst0 R843qcROEMUvce+I1Ix3N82Z1KZLST+Bp14e7O+/grfsSjBP62jdlvRMUy7fyx29YV0b R0o+QvNFHUwF9Koe3SCcfNVRIM8K5ynbip7Y47XaK4IjGh+UKMsHsyAGoAHAeHHqfXYn iZRxvyZpCuM0Zko4dGfvkJTPqgZWgvIsrmfYl83fMRnMdpuIktK20LorJqbPaCv2K1y4 HolBQvZP/10apWcISRTepF6wqVooeQT75NeVEE9DEPsVpTGFzf4cjyaCRQ/AJ8jMq1zU S4hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711478833; x=1712083633; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VycL5qDrPHCDWWbHqXExQCkFHxLflz/cf4MtnxAQLPE=; b=d0psBC8AFUgFyhH0bRD6gda5KHOloHXqI/8bb/nn1JdFVfE0P0aSZldHLIO3WjTpXv jelI+lFBoyKVr6mndjlZCnky9MIRqRsF2SSADtAI+3M+EVGUvmSyvBvZGpiy/IoQV9Zo mD34pbREdmb9NI8owNrwF2g0tQtU0w2AKn+bRbtPDBzsI+6HTwl22GamXeGaCs7NPaQn fhff2YjqZyMalkS3Gv3DYU/FPPwpGHHy8PnWHosDraLk9wU1K+LRfWclAHqluA6yfhiK TtyeVnSyE1pAwX9W17Azmj5vdGSWQDB5yiZeBGfPfFZUw+Lgl/HCNahivlrCF7sZ3o/8 chvQ== X-Gm-Message-State: AOJu0YyJknuUvu564NB8zzFirjj3nWZQ5qQcWCsnBM8FvcT8neuo6Cvf FHcYrfOAgEErlFsbE2ZJwPBFS9WBQCmdCGrQa4OyHBo1Ka3yrhlqlx1WlY2H X-Google-Smtp-Source: AGHT+IF5J7Ksbagb52c2AWvuyqGKYpcRR+4uDFGY23w4k3s/FSuJLokWRE9iE9uJg2YSIfdloe1UQg== X-Received: by 2002:a19:6a0e:0:b0:513:dba5:ac67 with SMTP id u14-20020a196a0e000000b00513dba5ac67mr1666249lfu.32.1711478833471; Tue, 26 Mar 2024 11:47:13 -0700 (PDT) Received: from localhost.localdomain (109-252-14-191.nat.spd-mgts.ru. [109.252.14.191]) by smtp.gmail.com with ESMTPSA id i12-20020a0565123e0c00b00515acc50f71sm890424lfv.260.2024.03.26.11.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 11:47:13 -0700 (PDT) From: Maxim Moskalets X-Google-Original-From: Maxim Moskalets To: linux-kernel@vger.kernel.org Cc: maximmosk4@gmail.com, Maxim Moskalets Subject: [PATCH 6/8] locking: replace seq_puts by seq_putc Date: Tue, 26 Mar 2024 21:47:10 +0300 Message-Id: <20240326184710.8799-1-Maxim.Moskalets@kaspersky.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240326184514.8478-1-Maxim.Moskalets@kaspersky.com> References: <20240326184514.8478-1-Maxim.Moskalets@kaspersky.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using seq_putc for single characters is faster and more appropriate than seq_puts, since only one character is passed and there is no need to use a more powerful and less fast function. Signed-off-by: Maxim Moskalets --- kernel/locking/lockdep_proc.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/kernel/locking/lockdep_proc.c b/kernel/locking/lockdep_proc.c index e2bfb1db589d..4612d1c4f45e 100644 --- a/kernel/locking/lockdep_proc.c +++ b/kernel/locking/lockdep_proc.c @@ -101,17 +101,17 @@ static int l_show(struct seq_file *m, void *v) =20 seq_printf(m, ": "); print_name(m, class); - seq_puts(m, "\n"); + seq_putc(m, '\n'); =20 if (IS_ENABLED(CONFIG_PROVE_LOCKING)) { list_for_each_entry(entry, &class->locks_after, entry) { if (entry->distance =3D=3D 1) { seq_printf(m, " -> [%p] ", entry->class->key); print_name(m, entry->class); - seq_puts(m, "\n"); + seq_putc(m, '\n'); } } - seq_puts(m, "\n"); + seq_putc(m, '\n'); } =20 return 0; @@ -175,9 +175,9 @@ static int lc_show(struct seq_file *m, void *v) =20 seq_printf(m, "[%p] ", class->key); print_name(m, class); - seq_puts(m, "\n"); + seq_putc(m, '\n'); } - seq_puts(m, "\n"); + seq_putc(m, '\n'); =20 return 0; } @@ -379,7 +379,7 @@ static int lockdep_stats_show(struct seq_file *m, void = *v) /* * Zapped classes and lockdep data buffers reuse statistics. */ - seq_puts(m, "\n"); + seq_putc(m, '\n'); seq_printf(m, " zapped classes: %11lu\n", nr_zapped_classes); #ifdef CONFIG_PROVE_LOCKING @@ -422,10 +422,10 @@ static void seq_line(struct seq_file *m, char c, int = offset, int length) int i; =20 for (i =3D 0; i < offset; i++) - seq_puts(m, " "); + seq_putc(m, ' '); for (i =3D 0; i < length; i++) seq_printf(m, "%c", c); - seq_puts(m, "\n"); + seq_putc(m, '\n'); } =20 static void snprint_time(char *buf, size_t bufsiz, s64 nr) @@ -512,7 +512,7 @@ static void seq_stats(struct seq_file *m, struct lock_s= tat_data *data) seq_lock_time(m, &stats->write_waittime); seq_printf(m, " %14lu ", stats->bounces[bounce_acquired_write]); seq_lock_time(m, &stats->write_holdtime); - seq_puts(m, "\n"); + seq_putc(m, '\n'); } =20 if (stats->read_holdtime.nr) { @@ -521,7 +521,7 @@ static void seq_stats(struct seq_file *m, struct lock_s= tat_data *data) seq_lock_time(m, &stats->read_waittime); seq_printf(m, " %14lu ", stats->bounces[bounce_acquired_read]); seq_lock_time(m, &stats->read_holdtime); - seq_puts(m, "\n"); + seq_putc(m, '\n'); } =20 if (stats->read_waittime.nr + stats->write_waittime.nr =3D=3D 0) @@ -561,9 +561,9 @@ static void seq_stats(struct seq_file *m, struct lock_s= tat_data *data) ip, (void *)class->contending_point[i]); } if (i) { - seq_puts(m, "\n"); + seq_putc(m, '\n'); seq_line(m, '.', 0, 40 + 1 + 12 * (14 + 1)); - seq_puts(m, "\n"); + seq_putc(m, '\n'); } } =20 --=20 2.39.2 From nobody Sun Feb 8 06:33:52 2026 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDBDA13D24B for ; Tue, 26 Mar 2024 18:47:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711478846; cv=none; b=dIZI/bPLcsQVEDsXAJKhwNxN3StfYCwCL55xlz2IGQmpmTdYLWXhsMxnEZsR1L+R8tCFUPthjMdOTnHW4G+mC1iMJm8e1g5n0m5D/I2f7Jx05q4Bty6kER39D17RVSJXsMUoqUVtnxxcBcbgVqInOAr4t+7Rw+I2ikjYJKV8tTY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711478846; c=relaxed/simple; bh=Tj05ZjgtZ/hOdwZ88gRi5GLXab0H1IMeyOGQoh5qkOk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ShZivsrglLhLZnqEp5kKjdPIX4kq3vRQjZzkC4KA+LXCHlbTU6Im8myxQNmLDvwhZH7sJxqUADDbjRR1wqu5irM650oL2wmgvel7I46hmTehexw1GvAoYzEQLeiIMA34I+PhU5uZvPyAEEr70ev/uWmDwKI4PgEyEi1caKJnbA4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Py2Du6yx; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Py2Du6yx" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-513d599dbabso7644208e87.1 for ; Tue, 26 Mar 2024 11:47:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711478842; x=1712083642; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NEktcFN4Tkz83zUX0ZQwuJWARcDRCH7/MENDIuUrEqI=; b=Py2Du6yx4ErO5cjGjFAf1xLzIG+dHw84oJ31u5RiJJbGvFf29ciQiuaCd33diDu+lJ 0MyNE2SsEOd/Tsv+TgLfxzoykFOMAKn8eSUm1vlpipXJ0VVw9N8YSrA6YO5Bfdm8ohR6 r/+7TVLryJ59rBXzSSpm226GMIGAqJizHrCTnIIoD0F45F+UKIlo39dHPxqanDg5UjSG 4dfMr7t4hdQn/KRzQG50X+80j8fJnvjiRLwjZcPstELHnyk1RiNG8KgWuiRSvJ02hvmV H5nyweDJfaHx3vSmjIl2eIC7/by5C/kclSyncvge2lV7Nt8PxTj6POri793s2unhRJzf a8xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711478842; x=1712083642; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NEktcFN4Tkz83zUX0ZQwuJWARcDRCH7/MENDIuUrEqI=; b=tMc/BEY+1CAxTBRXFxIT9ndnc54QcwWgiGe75qF07YW+pfUe6mCaGPuRRAmKllDkpL ywTpLpQmiWF2KfFtkUIdS9a+zYgj7nS7YXySC/O4umezMBiBMgSARh9bX5s1AjNWimMl LyszUTuEcxHpqWqQ/M4DnUb9fUWL5XH58T3qQRa32MS/f9Yh6JVyQudP9fXzD9Lxh4M2 k6QhGzhCHBhPF/dTaduF1rc9aDIJfz90mWxn0I66QB9RMC6rrX7fgARREAfWAlx0xltJ 1rULaiRdf7ybuA3fE9OL0ayrEHsm3Z0uS0+U6ugwIZ1APERkF1PB1Fy4xynRCQyXu3Ng wkSg== X-Gm-Message-State: AOJu0YybzcGdwMMPByg0hcCetEGN+cjyKzo9izWGDJvXVCQKcLd59FuC VCsUb9kOOP6Y5/ffL7jFKZePb2aK9uRQTg2D+cGO0ezFvouac6ZwpoPrN5aU X-Google-Smtp-Source: AGHT+IG1N8/J5GmyJjMCjb4ypOts/sOnJFOBvc3zeI/yn9bwxMSuQPfrXk1SLH2HWJvcN0WLJG/z4w== X-Received: by 2002:a05:6512:220d:b0:513:d1cd:b902 with SMTP id h13-20020a056512220d00b00513d1cdb902mr9234380lfu.32.1711478842382; Tue, 26 Mar 2024 11:47:22 -0700 (PDT) Received: from localhost.localdomain (109-252-14-191.nat.spd-mgts.ru. [109.252.14.191]) by smtp.gmail.com with ESMTPSA id m7-20020a056512014700b00515bb9de721sm122379lfo.76.2024.03.26.11.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 11:47:22 -0700 (PDT) From: Maxim Moskalets X-Google-Original-From: Maxim Moskalets To: linux-kernel@vger.kernel.org Cc: maximmosk4@gmail.com, Maxim Moskalets Subject: [PATCH 7/8] time: replace seq_puts by seq_putc Date: Tue, 26 Mar 2024 21:47:18 +0300 Message-Id: <20240326184718.8828-1-Maxim.Moskalets@kaspersky.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240326184514.8478-1-Maxim.Moskalets@kaspersky.com> References: <20240326184514.8478-1-Maxim.Moskalets@kaspersky.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using seq_putc for single characters is faster and more appropriate than seq_puts, since only one character is passed and there is no need to use a more powerful and less fast function. Signed-off-by: Maxim Moskalets --- kernel/time/test_udelay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/time/test_udelay.c b/kernel/time/test_udelay.c index 20d5df631570..82fe239c3184 100644 --- a/kernel/time/test_udelay.c +++ b/kernel/time/test_udelay.c @@ -59,7 +59,7 @@ static int udelay_test_single(struct seq_file *s, int use= cs, uint32_t iters) (usecs * 1000) - allowed_error_ns, min, avg, max); if (fail_count) seq_printf(s, " FAIL=3D%d", fail_count); - seq_puts(s, "\n"); + seq_putc(s, '\n'); =20 return 0; } --=20 2.39.2 From nobody Sun Feb 8 06:33:52 2026 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 360BC13CC57 for ; Tue, 26 Mar 2024 18:47:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711478855; cv=none; b=AJk0pmAwmEBz0PxA5Y8PaA/jRsHXu6nb4fJewNXYXJGVzehaUzeH3DelO716y6bTNQmpbGbpba9LzOcWfiDryNOO7mBgvumRYMAXhdU+S1tqMD6Ow86AMuyryaGJFhTNjpX+cMp5GEAOE2BKmkSittaC1FKaUz7P10VUm0w11/k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711478855; c=relaxed/simple; bh=2t+HSzUts0lI6uWkIeviONst3D9MJ2COv0YlBAQl66Q=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=hUuNMB3yPUmXIA/lnjJM0cIuv3uXfbFvXLlES7pfhVZU00nRv9MElASXcqUTCIxycRhZ07LAkxu6PoSu94uQlLFvRvtsg1WVfkjuraKai5G+RZKFPVheFkofuXp5k0H+nDKGcanFXa0NF658vxYJ6z1HVSK2f5j0OWJDtccWrK8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EB8V3YYh; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EB8V3YYh" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5157af37806so7003819e87.0 for ; Tue, 26 Mar 2024 11:47:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711478851; x=1712083651; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1nhxx724yaPCU1qTaAWx0rFWTQnMWYRyaiWZKelBeQM=; b=EB8V3YYhzYj+6n924K4ERBgZNrhzY2HIHFTtXwEPZh4sOcNAwVEQrsn6ZklD8v1N1N NvTsKRcDLDj1FG20rIf3SOY3lsrEWgAxBpq6swL+BbzKRunwySoIVNw6FehhBXMDMrMj W4TfY+m7WubF+EvvZURkxbb5Y7ZFpNIQlXddRfjQ9VaVsd5giAP8StXfWh52GaNKfnX4 KY8tiw4EjTHAej1uZvRN4odLiuJ3InlWJfmaUxlOZQfZCXUeUdLEoTONIgZj9mOMhVEX s55X2e4PGizL4YfMlJskDLlCT74Cx+xZzx8WpaFJL1eEVtwKB1Qm1BdGSXrnF+u+GewI DEog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711478851; x=1712083651; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1nhxx724yaPCU1qTaAWx0rFWTQnMWYRyaiWZKelBeQM=; b=dmsTCtGc8nqpVEklX+JmqQ6wRwDsImkEH/QaP7AeA5F8DnwL24TKqibYQi6Qydte0i 0x1HRysYTJgJ41ciRJBF/LvVO0j9obKCVhvj8DF4+w+cfRTdVauDDB4lz0BgLnXlu0xE Jt6qvT3J7DM5RqPdp4h9rIKpIVbQW0Vw4UISVMoeOOuhXBqFqrqslSuGiJoHc11pgmmY sbJoCu2oB14/oP9R6JqtjuGGRezcMmRByWymEQ0R9sflHoi6Ph6Ws9kR4LBUuH/pkJn2 6vzVOfnpZmUmftgchXoDUCdKWJ6aofKKynsj7OQpyZpiJMVCG6ckAMQb/dRV2id5qmda kjvA== X-Gm-Message-State: AOJu0Yy3pL05xkBzJoojMIPNwpwWKXQ198TgwFZ7FtRfhw0EILdPPS48 mjjoDBp1w7WFiOGHwBU69FnZ1wRn83KXKVHa4d+ujAg8dGOtJn9fPg7US6iq X-Google-Smtp-Source: AGHT+IEUiTuE7u76o63pf4XH4Aj5Sk7oCIXNDwZwyz5yefVdtlv3zt9t7+rwk3K6KVq/fbKy8pjXwA== X-Received: by 2002:a19:e05e:0:b0:513:cd70:8d90 with SMTP id g30-20020a19e05e000000b00513cd708d90mr2526296lfj.42.1711478850869; Tue, 26 Mar 2024 11:47:30 -0700 (PDT) Received: from localhost.localdomain (109-252-14-191.nat.spd-mgts.ru. [109.252.14.191]) by smtp.gmail.com with ESMTPSA id v12-20020ac258ec000000b00515bbc2feedsm115718lfo.102.2024.03.26.11.47.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 11:47:30 -0700 (PDT) From: Maxim Moskalets X-Google-Original-From: Maxim Moskalets To: linux-kernel@vger.kernel.org Cc: maximmosk4@gmail.com, Maxim Moskalets Subject: [PATCH 8/8] kernel: replace seq_puts by seq_putc Date: Tue, 26 Mar 2024 21:47:27 +0300 Message-Id: <20240326184727.8858-1-Maxim.Moskalets@kaspersky.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240326184514.8478-1-Maxim.Moskalets@kaspersky.com> References: <20240326184514.8478-1-Maxim.Moskalets@kaspersky.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Using seq_putc for single characters is faster and more appropriate than seq_puts, since only one character is passed and there is no need to use a more powerful and less fast function. Signed-off-by: Maxim Moskalets --- kernel/latencytop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/latencytop.c b/kernel/latencytop.c index 781249098cb6..08fe9ce35ec3 100644 --- a/kernel/latencytop.c +++ b/kernel/latencytop.c @@ -261,7 +261,7 @@ static int lstats_show(struct seq_file *m, void *v) =20 seq_printf(m, " %ps", (void *)bt); } - seq_puts(m, "\n"); + seq_putc(m, '\n'); } } return 0; --=20 2.39.2