From nobody Mon Feb 9 06:50:30 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AFC813C696; Tue, 26 Mar 2024 18:57:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711479444; cv=none; b=iC+CEzfPa6Iv7c55r700cgrP/JjMC6tLQ/QfWRSLM44hx8RBJaO54O0wtUImyCsRFyGedcdANOI0O79VTGe+eAh+etrd/09VCwtzPkig07GlfzJ19Xu+uVh/vMhTjtv77tvYYoC1J+5BvA+s/MXuGyLFmiZk+00eayoDYGI+GZM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711479444; c=relaxed/simple; bh=Gsn3xXI5BKQL/2L//Z3WWmwk7DoW960rhzJRT9Ymakc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=neCYT6uEEWSDqKTpA9ouSnjGEZe2VBgbBizpOyt9EWsEUaT7XlegTQMorX2mI7CGkpAAz62LTGtdOtyPg250g9yt7SBQOa4FWAU6SXybKD07/CVup+RooA0lSgFtgSNVROsvjqtStFJ0Gog1VTqmK3FBHcZ4zv0wIzv3jVzMnlA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NFkZy5Y9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NFkZy5Y9" Received: by smtp.kernel.org (Postfix) with ESMTPS id C36E4C43390; Tue, 26 Mar 2024 18:57:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711479443; bh=Gsn3xXI5BKQL/2L//Z3WWmwk7DoW960rhzJRT9Ymakc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=NFkZy5Y9KO2Hxq0mI84mZ9prB6Fytp67o6i5a/E4qS3vwxvFWzhv4AIpeM160GWfp AAmVMtfAXgmahmiyPwYN8nj4zBFY3Yyb+7Y4bIJbrE2u1iNhqZNOAGzurwjF72Rv8w /KsXhV57usRVY+CgK3FCqCGbAvn/v0XQNJpzuteTKJK/lbrh89y7fxabQIulbXB/JA Nf1GxyoCfRttFrH1QcjZdSQR+usSkjZ+OKL69z2gBjilVDX6dcH7rekmOelO6shf2x kjd2otmYtZT0F6WGyEViMFAPXuPlKBhKx0SbtgYA8u9vLzkiIzNCu1QTykOLUtfuux LNau16lWcj5bQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2E1EC6FD1F; Tue, 26 Mar 2024 18:57:23 +0000 (UTC) From: Folker Schwesinger via B4 Relay Date: Tue, 26 Mar 2024 19:54:35 +0100 Subject: [PATCH 1/3] phy: rockchip: emmc: Enable pulldown for strobe line Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240326-rk-default-enable-strobe-pulldown-v1-1-f410c71605c0@folker-schwesinger.de> References: <20240326-rk-default-enable-strobe-pulldown-v1-0-f410c71605c0@folker-schwesinger.de> In-Reply-To: <20240326-rk-default-enable-strobe-pulldown-v1-0-f410c71605c0@folker-schwesinger.de> To: Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Chris Ruehl , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Christopher Obbard , Alban Browaeys , Doug Anderson , Brian Norris , Jensen Huang , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Folker Schwesinger X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2253; i=dev@folker-schwesinger.de; h=from:subject:message-id; bh=vn1WaogVqkovnF++lKXXa6btFkOAZlcxkgTSF4vHKKI=; b=owGbwMvMwCXG5FBoZNu1u5bxtFoSQxqz1ESGm1xxESWPdL0nBP77tEF529PKYs66r0ez70y8w 2eS2Tm5o5SFQYyLQVZMkYU1L2MLc2b5Uuuun69h5rAygQ3h4hSAibCEMfwVOiHs8frNmQnzo1mu GdVGya19sFMoZ+G78y36Xp3W6h5fGRnaD1XFVlhoO08onHh787XvZ+ad11Ko0L/3/tkVv8uFT66 zAQA= X-Developer-Key: i=dev@folker-schwesinger.de; a=openpgp; fpr=056E68B4036977A53B8AF9EB024071323D8ABB7D X-Endpoint-Received: by B4 Relay for dev@folker-schwesinger.de/default with auth_id=144 X-Original-From: Folker Schwesinger Reply-To: dev@folker-schwesinger.de From: Folker Schwesinger Restore the behavior of the Rockchip kernel that undconditionally enables the internal strobe pulldown. As the DT property rockchip,enable-strobe-pulldown is obsolete now, replace it with a property to disable the internal pulldown. This fixes I/O errors observed on various Rock Pi 4 and NanoPi4 series boards with some eMMC modules. Other boards may also be affected. An example of these errors is as follows: [ 290.060817] mmc1: running CQE recovery [ 290.061337] blk_update_request: I/O error, dev mmcblk1, sector 1411072 o= p 0x1:(WRITE) flags 0x800 phys_seg 36 prio class 0 [ 290.061370] EXT4-fs warning (device mmcblk1p1): ext4_end_bio:348: I/O er= ror 10 writing to inode 29547 starting block 176466) [ 290.061484] Buffer I/O error on device mmcblk1p1, logical block 172288 Fixes: 8b5c2b45b8f0 ("phy: rockchip: set pulldown for strobe line in dts") Signed-off-by: Folker Schwesinger --- drivers/phy/rockchip/phy-rockchip-emmc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-emmc.c b/drivers/phy/rockchi= p/phy-rockchip-emmc.c index 20023f6eb994..6e637f3e1b19 100644 --- a/drivers/phy/rockchip/phy-rockchip-emmc.c +++ b/drivers/phy/rockchip/phy-rockchip-emmc.c @@ -376,14 +376,14 @@ static int rockchip_emmc_phy_probe(struct platform_de= vice *pdev) rk_phy->reg_offset =3D reg_offset; rk_phy->reg_base =3D grf; rk_phy->drive_impedance =3D PHYCTRL_DR_50OHM; - rk_phy->enable_strobe_pulldown =3D PHYCTRL_REN_STRB_DISABLE; + rk_phy->enable_strobe_pulldown =3D PHYCTRL_REN_STRB_ENABLE; rk_phy->output_tapdelay_select =3D PHYCTRL_OTAPDLYSEL_DEFAULT; =20 if (!of_property_read_u32(dev->of_node, "drive-impedance-ohm", &val)) rk_phy->drive_impedance =3D convert_drive_impedance_ohm(pdev, val); =20 - if (of_property_read_bool(dev->of_node, "rockchip,enable-strobe-pulldown"= )) - rk_phy->enable_strobe_pulldown =3D PHYCTRL_REN_STRB_ENABLE; + if (of_property_read_bool(dev->of_node, "rockchip,disable-strobe-pulldown= ")) + rk_phy->enable_strobe_pulldown =3D PHYCTRL_REN_STRB_DISABLE; =20 if (!of_property_read_u32(dev->of_node, "rockchip,output-tapdelay-select"= , &val)) { if (val <=3D PHYCTRL_OTAPDLYSEL_MAXVALUE) --=20 2.44.0 From nobody Mon Feb 9 06:50:30 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AF6713C692; Tue, 26 Mar 2024 18:57:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711479444; cv=none; b=chHVwdd0/aW+zCygAqdrzfyHLXdVbPhZpCT0CvY508k1AkEUiPl+jISudFrR9m7d5tb5dW/z8G5h8NO8uKCI/DkAyyRXxVZymRZ4YIszNvKTzqKPgN3GGghJ19oyAtP59eJZGSerLClph/al84CEl2HADWMI+T07Q8FS+AcVhJk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711479444; c=relaxed/simple; bh=G6mc0QUGBHLFWSqnsGqxmIC8vKxJ1zCnaOScx8J3TQA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cD7C+nkRbfYZ2qFmXvfg4+KUAnQ/Lzj4208IKCnM9gf8zZK+xE9GKQifb6/qwCimfCPh8vieoOPmz54nNO557u02n1gjedpBXqBG8om8L2wjM/sOZfqYjVbCtTAxIHJNHLzrlOqAJMYaoMlGg3Wsr4HVuB+KaM0EMQoAtbAL5kg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UnQb6l4o; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UnQb6l4o" Received: by smtp.kernel.org (Postfix) with ESMTPS id DB434C433B2; Tue, 26 Mar 2024 18:57:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711479443; bh=G6mc0QUGBHLFWSqnsGqxmIC8vKxJ1zCnaOScx8J3TQA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=UnQb6l4ori1UnlnKacvSGErLo7U07JRCVt2nPfBNLMm44T/m7r57d0/k0u/sid38R lEBu8yksww/lt7cmBkm/FqLKSnNQHHiZjpLyWFP2PCCwAX55oI4Dn9SvCwc8eDbZks tMtGccHuh2dcIaWD3CNx7FELxVrUOBZJiF3z9WFPTiNPxMoZ0cW38iyNa2NHdF2CYf 288bUFgzLAy7EVmpyhht7M8tIz9Vqa6C2VBSDZNWLpVFTJY4atccQGkgXXWpG1mDi0 Ttv6Sl53VFMqMWxl0rmjxgw8/M3ISM5SW1GT4n1Nhv1F+LrX3GzLQWLCEskDxWSRYF vjNMsFjrJGcIg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id C739FC54E67; Tue, 26 Mar 2024 18:57:23 +0000 (UTC) From: Folker Schwesinger via B4 Relay Date: Tue, 26 Mar 2024 19:54:36 +0100 Subject: [PATCH 2/3] devicetree: phy: rockchip-emmc: Document changed strobe-pulldown property Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240326-rk-default-enable-strobe-pulldown-v1-2-f410c71605c0@folker-schwesinger.de> References: <20240326-rk-default-enable-strobe-pulldown-v1-0-f410c71605c0@folker-schwesinger.de> In-Reply-To: <20240326-rk-default-enable-strobe-pulldown-v1-0-f410c71605c0@folker-schwesinger.de> To: Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Chris Ruehl , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Christopher Obbard , Alban Browaeys , Doug Anderson , Brian Norris , Jensen Huang , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Folker Schwesinger X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1613; i=dev@folker-schwesinger.de; h=from:subject:message-id; bh=lYZfvZDtpySgOOqOAfgoLZ9THvZvx3kUJVgOxDEo5RE=; b=owGbwMvMwCXG5FBoZNu1u5bxtFoSQxqz1KSXEXPm32GZ9Ic3tF984fKDer0GAtunykV0cP6yz H7bbzOzo5SFQYyLQVZMkYU1L2MLc2b5Uuuun69h5rAygQxh4OIUgIloiDH8M3MoEvsnn9Sap6p9 m/mcrMz8Y3p7k5le/NnupqBbaKzYzfA/8b/SW42WBQVnEx5bsJ+P/fN+1SF+002WnFemZ19pzyr mAAA= X-Developer-Key: i=dev@folker-schwesinger.de; a=openpgp; fpr=056E68B4036977A53B8AF9EB024071323D8ABB7D X-Endpoint-Received: by B4 Relay for dev@folker-schwesinger.de/default with auth_id=144 X-Original-From: Folker Schwesinger Reply-To: dev@folker-schwesinger.de From: Folker Schwesinger Document the changes regarding the optional strobe-pulldown property. These changes are necessary as the default behavior of the driver was restored to the Rockchip kernel behavior of enabling the internal pulldown by default. Fixes: f34e43f12382 ("devicetree: phy: rockchip-emmc: pulldown property") Signed-off-by: Folker Schwesinger --- Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt b/= Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt index 57d28c0d5696..10c05437f7ab 100644 --- a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt +++ b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt @@ -16,8 +16,8 @@ Optional properties: - drive-impedance-ohm: Specifies the drive impedance in Ohm. Possible values are 33, 40, 50, 66 and 100. If not set, the default value of 50 will be applie= d. - - rockchip,enable-strobe-pulldown: Enable internal pull-down for the stro= be - line. If not set, pull-down is not us= ed. + - rockchip,disable-strobe-pulldown: Disable internal pull-down for the st= robe + line. If not set, pull-down is used. - rockchip,output-tapdelay-select: Specifies the phyctrl_otapdlysec regis= ter. If not set, the register defaults to 0= x4. Maximum value 0xf. --=20 2.44.0 From nobody Mon Feb 9 06:50:30 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BFC513C813; Tue, 26 Mar 2024 18:57:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711479444; cv=none; b=sWkhk8HdTnt9JRFp6f+eIa7Xpf1pZHiW5+2CIPfdoNTN8TV1+jn2w90THOh+JMk9qzplCTJ4A2hqFgkaYaiceq6qB9qj9hI36H7gN8xt/Lm+4zeOLDSX86xtkvx6WQvyLovXRlsWdbINX6NEAfDCuSsbO6ox35nX1LCfL6/oiWM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711479444; c=relaxed/simple; bh=t92rMDfisU2O183WicZRvvThqnLcj0E2zhg0sRyx/uA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rzbKuejXHPFvZ/mVpEKIH1mPuvskx8C3XHlVhmErXiONivCxJcFg6DsswGtE/cREDH+90/rAwvVzR8/He/84Bv6Z9GqERaK6tnrHHPPoD6TAIAJFSGX5QRiIIl1n9O51ZyUJtJZUgVMWfGDtS1cGdXajhXbNWyJy11NyWCmBosA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lxQWBkHE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lxQWBkHE" Received: by smtp.kernel.org (Postfix) with ESMTPS id E9F70C43330; Tue, 26 Mar 2024 18:57:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711479444; bh=t92rMDfisU2O183WicZRvvThqnLcj0E2zhg0sRyx/uA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=lxQWBkHE48NtOCNCYUMMn4GNtDMNqVx0YIxT9+GwVFAmFk2Jy32/hlFbq96lBba9b vuqJjKTu5OHyzHGWwylh05mfq+xheI8sSFEo0XpOG96PiYoMI6UnMvHidBtTMYj5ym ao1oMynsE/KpI4e78dA8NK0lWqep3aqTPbY6JxDouNhLSOvDB9/LfAPTnod7kCSRxX Nm5N4MYJYjnEZPWzsLHPddIE6dUnnydCU98EQ07dH3lpd1nXw4DhVey5JoVCpK9piB ZXrKBmVZRk5I4CrcDPkwQt9hcfu4CXpbND5w9/vvWTOohNr5X+8N3FWcDaOQf2+ehD XF7l6Q4b7gTnQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEF2ECD1284; Tue, 26 Mar 2024 18:57:23 +0000 (UTC) From: Folker Schwesinger via B4 Relay Date: Tue, 26 Mar 2024 19:54:37 +0100 Subject: [PATCH 3/3] arm64: dts: rockchip: Remove enable-strobe-pulldown for NanoPi4 boards Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240326-rk-default-enable-strobe-pulldown-v1-3-f410c71605c0@folker-schwesinger.de> References: <20240326-rk-default-enable-strobe-pulldown-v1-0-f410c71605c0@folker-schwesinger.de> In-Reply-To: <20240326-rk-default-enable-strobe-pulldown-v1-0-f410c71605c0@folker-schwesinger.de> To: Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Chris Ruehl , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Christopher Obbard , Alban Browaeys , Doug Anderson , Brian Norris , Jensen Huang , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Folker Schwesinger X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=724; i=dev@folker-schwesinger.de; h=from:subject:message-id; bh=fmO1sP9nAwWwIfDKXcaV6YI0IH/hcl1UfJExvs0KGtI=; b=owGbwMvMwCXG5FBoZNu1u5bxtFoSQxqz1KSLdfclJe/cdDUz+/2kl+1vlNncrZtWMwXdsI2zz Obt51PvKGVhEONikBVTZGHNy9jCnFm+1Lrr52uYOaxMIEMYuDgFYCJlxowMUxteL/2zjlHg1162 50fY9v/3D+Q+G9j4zG9K5kYTttqjXowMV2buML48c6NI60+fT5tf/Q9o/dhVHZW/LE7hbpPWpuD v7AA= X-Developer-Key: i=dev@folker-schwesinger.de; a=openpgp; fpr=056E68B4036977A53B8AF9EB024071323D8ABB7D X-Endpoint-Received: by B4 Relay for dev@folker-schwesinger.de/default with auth_id=144 X-Original-From: Folker Schwesinger Reply-To: dev@folker-schwesinger.de From: Folker Schwesinger The Rockchip eMMC PHY driver enables the internal strobe pulldown by default. So, remove the enable-strobe-pulldown property from the NanoPi4 series boards DTS. Signed-off-by: Folker Schwesinger --- arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi b/arch/arm64/= boot/dts/rockchip/rk3399-nanopi4.dtsi index b7f1e47978a6..38af91b9e756 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi @@ -168,7 +168,6 @@ &cpu_l3 { }; =20 &emmc_phy { - rockchip,enable-strobe-pulldown; status =3D "okay"; }; =20 --=20 2.44.0