From nobody Fri Dec 19 21:47:26 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00763184403; Sun, 24 Mar 2024 23:51:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711324270; cv=none; b=Ccr8rf9NqqIULkK38NsPbwPIDRkQr4kpl7VnYhDwQceZVUlqnJZYyzNteEz4/ofgL4B8trskkjU9sY6idctZp3rTo0Km+hbCgGS6Y1eLos4w7oY03wUu41MArvHcA7wuPfyf3pU3Kl4fKxLrawd/13RotPsJCfbufWasdbzEivo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711324270; c=relaxed/simple; bh=t0dlIHKdQlh5FOxOWMgprE0F0SGdYtgOUdiJq8cKvLg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eBVNS7XvonIRCrGCLlaoCfiuVyhHF4Rcffsr5w4oqQofN3FuD9ZX5lIPPtyJ9UG1TovWbe+kEVlEkJ2tvWWCGZrQY8SFjhhbGMW0G9JRNEmuaXFGqj5wg2O+ElRiFsgyxSCgRRU9U3+MF1o8w9RIuEs051wi4IP9l/PfqnQvEtQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=g+S0MSJQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="g+S0MSJQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A85AC433C7; Sun, 24 Mar 2024 23:51:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711324268; bh=t0dlIHKdQlh5FOxOWMgprE0F0SGdYtgOUdiJq8cKvLg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g+S0MSJQbzShn6+1lhH83E4nepGjkZXnS9yH01EvY/MsrnM+sXqsSiUh8mxXfjZDm tYA2x2OV+xCyeeowKb2X3hN3+r15desgnhUmp5NDKJPk6jXEnJ4bX5x437k4BMsd8S orToadriWLygdJiCIPuY6DVZNvOY3Xg5b4b7wERcw9ZM868fvYtTpzxPh+GPK7YXJB oLIQTwfXVzMAbuicbl+J3jZg/nTL5QEHFU4Jp7DVGoUyxLutXk47OWkeO4zWf07tRl xyLnVkVSKq2i81U7WMgeFkuiY1xnhQI83vnJ1gsXaIOLn7TsfD9krwl3oRU6TDayqC 3lLG79Wihy/IA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zhipeng Lu , Chuck Lever , Sasha Levin Subject: [PATCH 4.19 048/148] SUNRPC: fix some memleaks in gssx_dec_option_array Date: Sun, 24 Mar 2024 19:48:32 -0400 Message-ID: <20240324235012.1356413-49-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324235012.1356413-1-sashal@kernel.org> References: <20240324235012.1356413-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Zhipeng Lu [ Upstream commit 3cfcfc102a5e57b021b786a755a38935e357797d ] The creds and oa->data need to be freed in the error-handling paths after their allocation. So this patch add these deallocations in the corresponding paths. Fixes: 1d658336b05f ("SUNRPC: Add RPC based upcall mechanism for RPCGSS aut= h") Signed-off-by: Zhipeng Lu Signed-off-by: Chuck Lever Signed-off-by: Sasha Levin --- net/sunrpc/auth_gss/gss_rpc_xdr.c | 27 +++++++++++++++++++-------- 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/net/sunrpc/auth_gss/gss_rpc_xdr.c b/net/sunrpc/auth_gss/gss_rp= c_xdr.c index 444380f968f11..730a9c4dc9931 100644 --- a/net/sunrpc/auth_gss/gss_rpc_xdr.c +++ b/net/sunrpc/auth_gss/gss_rpc_xdr.c @@ -263,8 +263,8 @@ static int gssx_dec_option_array(struct xdr_stream *xdr, =20 creds =3D kzalloc(sizeof(struct svc_cred), GFP_KERNEL); if (!creds) { - kfree(oa->data); - return -ENOMEM; + err =3D -ENOMEM; + goto free_oa; } =20 oa->data[0].option.data =3D CREDS_VALUE; @@ -278,29 +278,40 @@ static int gssx_dec_option_array(struct xdr_stream *x= dr, =20 /* option buffer */ p =3D xdr_inline_decode(xdr, 4); - if (unlikely(p =3D=3D NULL)) - return -ENOSPC; + if (unlikely(p =3D=3D NULL)) { + err =3D -ENOSPC; + goto free_creds; + } =20 length =3D be32_to_cpup(p); p =3D xdr_inline_decode(xdr, length); - if (unlikely(p =3D=3D NULL)) - return -ENOSPC; + if (unlikely(p =3D=3D NULL)) { + err =3D -ENOSPC; + goto free_creds; + } =20 if (length =3D=3D sizeof(CREDS_VALUE) && memcmp(p, CREDS_VALUE, sizeof(CREDS_VALUE)) =3D=3D 0) { /* We have creds here. parse them */ err =3D gssx_dec_linux_creds(xdr, creds); if (err) - return err; + goto free_creds; oa->data[0].value.len =3D 1; /* presence */ } else { /* consume uninteresting buffer */ err =3D gssx_dec_buffer(xdr, &dummy); if (err) - return err; + goto free_creds; } } return 0; + +free_creds: + kfree(creds); +free_oa: + kfree(oa->data); + oa->data =3D NULL; + return err; } =20 static int gssx_dec_status(struct xdr_stream *xdr, --=20 2.43.0