From nobody Fri Dec 19 20:12:13 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A2D228BD28; Sun, 24 Mar 2024 23:48:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711324083; cv=none; b=T1RILeDX2UzjqHEBBagPzv4PAolPtP/Nh2D84xQwDoDpfsArAYNMKW4gqEydSigi6BwG2DqWcSZYzNf4GCgFu3dEgUrjdtmOnEJdb+z5c6v3HcgHzOMRgeK3Ar6o9dSThWmAoonF1w3zi0Vuk9HT+H4TT7085tR5/LLrml3YPiU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711324083; c=relaxed/simple; bh=ir/H48WBd9iJTs/xTH8Oz5/Qn+uxWcc9t3DZeEZ5L6g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MXBFmEYl9IM9beRawOnUXbtKWviq4ZQlGd5BbmwNB/M3wHrUrMwyXtR/7fBVwbzWqfmvLaeC11J+C7RwUi1mdlAB8u17bfGbM76A+7IL7tv1zaEEZnWlnqCkswvKP1Ati+HBG5kV97nubkv3PPQiwdmw0d/ME0kcLCqHI+PTELE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lmiQzhgV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lmiQzhgV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90280C43394; Sun, 24 Mar 2024 23:48:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711324082; bh=ir/H48WBd9iJTs/xTH8Oz5/Qn+uxWcc9t3DZeEZ5L6g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lmiQzhgV8Pl9X32Wp5oBt3Njthn6tB+Z2KEaOIsaIyprQ/934nhu/2kWrdzIvBBlK dBqOsg4Vh4/2JDI9VoFHoWlljfmWvIVe5MIte0IbKq4KYF/qXvfwwQ4DJ9Xj5g1fiZ 5bxC2iVG+VW1Ho9cbR4dod5bgWKIm4xbh8wBYHAnwfP7AUsZO8EpulEGpmSFV/5tvB X6p4cWU631p1Cjh0V7Tz/MeMZ84MZP78qnVpZE3jfHCQqrPBrSdrjYMhq3qjGXwo1b FD5UsDLDNvwD+RHi7o48hRsFC149ZIDFzS+suiauHZpcCnsKq5HA5O4220QQSBYL9b livId0xoFXr1A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Duoming Zhou , Louis Peens , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.4 082/183] nfp: flower: handle acti_netdevs allocation failure Date: Sun, 24 Mar 2024 19:44:55 -0400 Message-ID: <20240324234638.1355609-83-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324234638.1355609-1-sashal@kernel.org> References: <20240324234638.1355609-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Duoming Zhou [ Upstream commit 84e95149bd341705f0eca6a7fcb955c548805002 ] The kmalloc_array() in nfp_fl_lag_do_work() will return null, if the physical memory has run out. As a result, if we dereference the acti_netdevs, the null pointer dereference bugs will happen. This patch adds a check to judge whether allocation failure occurs. If it happens, the delayed work will be rescheduled and try again. Fixes: bb9a8d031140 ("nfp: flower: monitor and offload LAG groups") Signed-off-by: Duoming Zhou Reviewed-by: Louis Peens Link: https://lore.kernel.org/r/20240308142540.9674-1-duoming@zju.edu.cn Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/netronome/nfp/flower/lag_conf.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/netronome/nfp/flower/lag_conf.c b/drivers= /net/ethernet/netronome/nfp/flower/lag_conf.c index 63907aeb3884e..3167f9675ae0f 100644 --- a/drivers/net/ethernet/netronome/nfp/flower/lag_conf.c +++ b/drivers/net/ethernet/netronome/nfp/flower/lag_conf.c @@ -308,6 +308,11 @@ static void nfp_fl_lag_do_work(struct work_struct *wor= k) =20 acti_netdevs =3D kmalloc_array(entry->slave_cnt, sizeof(*acti_netdevs), GFP_KERNEL); + if (!acti_netdevs) { + schedule_delayed_work(&lag->work, + NFP_FL_LAG_DELAY); + continue; + } =20 /* Include sanity check in the loop. It may be that a bond has * changed between processing the last notification and the --=20 2.43.0