From nobody Fri Dec 19 20:13:22 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D03E181329; Sun, 24 Mar 2024 23:47:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711324078; cv=none; b=JZTMWi0WFhpMFEWxSbicAci8K4mHi2GAhslEvZJXwTs7IzajeUFcPRPDPp2DaiYiBfNZLHFI69317CrQbM8JnbbNhaZBdRZoBie3kkBfUBg4p299rsDrhhGxzLuBtpMz4wthlKw1twSU5XX0k6lMCphNcoDk2t2xqky+kcxke9I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711324078; c=relaxed/simple; bh=4DaxpUzWlRp6+J1iAwHH9aJOrxqrNkhArjxWeuBu49s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iiWsPcHBuKjPIhxwjKdwXWAHcx9KJ4j7ZaQfqmbs6KPyUHvi7joxOz5RJt2C1QQFwhZiWm7IYuRnieZakGRykZg/E4yuZOy+w3lq6WYJtERTw8GkR/8Vm5IweHDJKZflXoWlIQtnd0Ga/blataoRJE6FrYnvsd6XVSGgQ3kFUYc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nvHL5XmM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nvHL5XmM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65BA1C433F1; Sun, 24 Mar 2024 23:47:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711324077; bh=4DaxpUzWlRp6+J1iAwHH9aJOrxqrNkhArjxWeuBu49s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nvHL5XmMnCuKAEA2sj3NISX+y55TToVoWak5z7DEs/m1eVwl+5tt462xuVH8MpzX5 mDPXdOu/9cdh/lXj58dg9QlA8KWLcvXK8ib1JkvNuQvS1bLmYj1qRW6YmJfottBTna 28KR30CDOE8Y+iAsCYBkAfEQza7tVLqMfO11MmGDqQgGoY5RrNrukGRbkN6eB7WXuu kM/V51tmdTasz1nbqSOSkJCfwgwjMiRyrefw7HtbkH/3spIMq6b8hUpkeaZZShx09n at8rY6n2QP8903f85ZS263aM+/N1ghgViTwl/w7vnGnlFUEvzrPdd6LgTLbW7ETXic xhL0c4cNs0tPQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Gavrilov Ilia , Jason Xing , "David S . Miller" , Sasha Levin Subject: [PATCH 5.4 077/183] tcp: fix incorrect parameter validation in the do_tcp_getsockopt() function Date: Sun, 24 Mar 2024 19:44:50 -0400 Message-ID: <20240324234638.1355609-78-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324234638.1355609-1-sashal@kernel.org> References: <20240324234638.1355609-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Gavrilov Ilia [ Upstream commit 716edc9706deb3bb2ff56e2eeb83559cea8f22db ] The 'len' variable can't be negative when assigned the result of 'min_t' because all 'min_t' parameters are cast to unsigned int, and then the minimum one is chosen. To fix the logic, check 'len' as read from 'optlen', where the types of relevant variables are (signed) int. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Gavrilov Ilia Reviewed-by: Jason Xing Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/ipv4/tcp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index 8d7933989de0e..8ebcff40bc5ac 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -3451,11 +3451,11 @@ static int do_tcp_getsockopt(struct sock *sk, int l= evel, if (get_user(len, optlen)) return -EFAULT; =20 - len =3D min_t(unsigned int, len, sizeof(int)); - if (len < 0) return -EINVAL; =20 + len =3D min_t(unsigned int, len, sizeof(int)); + switch (optname) { case TCP_MAXSEG: val =3D tp->mss_cache; --=20 2.43.0