From nobody Fri Dec 19 20:14:26 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 314C2229C04; Sun, 24 Mar 2024 23:48:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711324134; cv=none; b=jTLPivObf37tvYzjBqeYnSJdGfeao1CuYKsUKeknlZIGIyHk9QICzYNTJEiYnZZd95NcdQIMiSws1LGnJsgmQNO2ajRDhgy3gRXZd1P/NpzT6pqZnGah2ustcCCACLbZWtP6EzZ27PR2c0xH+ysKN8UCXbm1Yxgol6Tsrp2zkMQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711324134; c=relaxed/simple; bh=AzJDd6RMY3BBgLb2b4nm2mnDH2oSiiGl+bC7buMZM0w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SjQm6kSUhhm1xmTnG5oI8VN4LtYGjdds/Hjxfo7pNlRA0Bmm9Y39xpcAhydCHQhyAjiOVty3/W+g/sUicCMIVEqdFp878H86Afnz9cVXJjwruoD3w+GG/CcFs/VgbZ7fmpcAxDPedpiZM8kuAVfF7O4zOUQ/dR49NgzvYpZDixw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vOqsvwZp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vOqsvwZp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D121C43399; Sun, 24 Mar 2024 23:48:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711324133; bh=AzJDd6RMY3BBgLb2b4nm2mnDH2oSiiGl+bC7buMZM0w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vOqsvwZpoHeh+O/+jDgX34Hfhrf2vySlYNhGh5Ga+PW3uyhe3gGq1oir+ynurA95u 2jjDezagnGwdjoLgqwzoNjPLEskgdr037ExRHJPp+YskhGMT/KoGnvjywzogjyWyM7 5WpDK/H89uAvBQYEHMZ70Z+fFvv+JED88T+xHY/jCEZCQahcH8+idVGerVv6Dy5XMv /G28JO+FZqi3QxrHghfP0F0WCjt+wmDoo1I0ddGv0qwHLrfIClc8Vun4HAI5b7Dxa9 mQoRL/HGp7h/Bp/Y/WM1EZAweUoHnrpVuFsQynUuGWG8pJJBfnrfB9lHgj7mEoQtRe MmoqzpO9GgWAQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Arnd Bergmann , Miquel Raynal , Sasha Levin Subject: [PATCH 5.4 130/183] mtd: rawnand: lpc32xx_mlc: fix irq handler prototype Date: Sun, 24 Mar 2024 19:45:43 -0400 Message-ID: <20240324234638.1355609-131-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324234638.1355609-1-sashal@kernel.org> References: <20240324234638.1355609-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann [ Upstream commit 347b828882e6334690e7003ce5e2fe5f233dc508 ] clang-16 warns about mismatched function prototypes: drivers/mtd/nand/raw/lpc32xx_mlc.c:783:29: error: cast from 'irqreturn_t (*= )(int, struct lpc32xx_nand_host *)' (aka 'enum irqreturn (*)(int, struct lp= c32xx_nand_host *)') to 'irq_handler_t' (aka 'enum irqreturn (*)(int, void = *)') converts to incompatible function type [-Werror,-Wcast-function-type-s= trict] Change the interrupt handler to the normal way of just passing a void* pointer and converting it inside the function.. Fixes: 70f7cb78ec53 ("mtd: add LPC32xx MLC NAND driver") Signed-off-by: Arnd Bergmann Signed-off-by: Miquel Raynal Link: https://lore.kernel.org/linux-mtd/20240213100146.455811-1-arnd@kernel= .org Signed-off-by: Sasha Levin --- drivers/mtd/nand/raw/lpc32xx_mlc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/nand/raw/lpc32xx_mlc.c b/drivers/mtd/nand/raw/lpc3= 2xx_mlc.c index 78b31f845c50a..a7d0a76eee7f4 100644 --- a/drivers/mtd/nand/raw/lpc32xx_mlc.c +++ b/drivers/mtd/nand/raw/lpc32xx_mlc.c @@ -304,8 +304,9 @@ static int lpc32xx_nand_device_ready(struct nand_chip *= nand_chip) return 0; } =20 -static irqreturn_t lpc3xxx_nand_irq(int irq, struct lpc32xx_nand_host *hos= t) +static irqreturn_t lpc3xxx_nand_irq(int irq, void *data) { + struct lpc32xx_nand_host *host =3D data; uint8_t sr; =20 /* Clear interrupt flag by reading status */ @@ -778,7 +779,7 @@ static int lpc32xx_nand_probe(struct platform_device *p= dev) goto release_dma_chan; } =20 - if (request_irq(host->irq, (irq_handler_t)&lpc3xxx_nand_irq, + if (request_irq(host->irq, &lpc3xxx_nand_irq, IRQF_TRIGGER_HIGH, DRV_NAME, host)) { dev_err(&pdev->dev, "Error requesting NAND IRQ\n"); res =3D -ENXIO; --=20 2.43.0