From nobody Fri Dec 19 20:14:12 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08C1615ADA0; Sun, 24 Mar 2024 23:48:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711324126; cv=none; b=bQEieS/o4zEVewJrLHGJWrBXVRlTc3tX4vdio702jxypaLas07RDuqkznd7AbaEcuVquNXn/KzcNnJWRZIOeaKUNtULP8NEdWUNGKb/qehsVgwgUZzepztQgUBAw+SHpk5AKya9htBNaB3Odm2N6z22n7ktS4NPYA9NNBm+tljo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711324126; c=relaxed/simple; bh=E/aVq3LMLOS4w8fJ1kkLvsMvFHnSWyWMsphkSLSDtHo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cqdnfC6+k1LqQgi4uvbzwLZlVaixPWdVvl9Jw8O8NJqEE+mXXLNELK1ZvTbtCMowPkk6zIPupxmNl0+UK6/pkY9tMwGoM994UyohkPKB80Jmug9sD7rWs9OkICHzb08TI1PUPV1j8IBaCpsQ9RGErM1KKnqO05SUEWgToqswPVM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZIMZSGPT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZIMZSGPT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45D3AC43390; Sun, 24 Mar 2024 23:48:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711324125; bh=E/aVq3LMLOS4w8fJ1kkLvsMvFHnSWyWMsphkSLSDtHo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZIMZSGPTcdS5dQTJPDycEvCGsRNm8iajya+YAnzMdekAo73cKyST0PYoIZBQMaLzK nNZoKfxWtvHU6vNWZuO5Y8EFIMNf3z6UI1G3Hz1zTAG8bJRrv4/hChH7IK9uK5mI8r oiY29RZWSAMy3Bdq4WKsxM0SfWpGd6eHYGKkgtoJMWtJc4q3yXRiilHHXyAwvqYAbw BPTZurBs3y8DkkLIPuT1ccRQd01Ql3bKxlkAVSyf8egBHHOV6/+AvpsJfSLhJDcvfW Ce/a//jq6EW7LgXUDlhpmbkBAWiYGS4Mw5+OaV/qP0kKEVcPBkdJHwSEWRlRzziFkB rlR5vasrlSuNg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?J=C3=B6rg=20Wedekind?= , Bjorn Helgaas , Sasha Levin Subject: [PATCH 5.4 123/183] PCI: Mark 3ware-9650SE Root Port Extended Tags as broken Date: Sun, 24 Mar 2024 19:45:36 -0400 Message-ID: <20240324234638.1355609-124-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324234638.1355609-1-sashal@kernel.org> References: <20240324234638.1355609-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: quoted-printable From: J=C3=B6rg Wedekind [ Upstream commit baf67aefbe7d7deafa59ca49612d163f8889934c ] Per PCIe r6.1, sec 2.2.6.2 and 7.5.3.4, a Requester may not use 8-bit Tags unless its Extended Tag Field Enable is set, but all Receivers/Completers must handle 8-bit Tags correctly regardless of their Extended Tag Field Enable. Some devices do not handle 8-bit Tags as Completers, so add a quirk for them. If we find such a device, we disable Extended Tags for the entire hierarchy to make peer-to-peer DMA possible. The 3ware 9650SE seems to have issues with handling 8-bit tags. Mark it as broken. This fixes PCI Parity Errors like : 3w-9xxx: scsi0: ERROR: (0x06:0x000C): PCI Parity Error: clearing. 3w-9xxx: scsi0: ERROR: (0x06:0x000D): PCI Abort: clearing. 3w-9xxx: scsi0: ERROR: (0x06:0x000E): Controller Queue Error: clearing. 3w-9xxx: scsi0: ERROR: (0x06:0x0010): Microcontroller Error: clearing. Link: https://lore.kernel.org/r/20240219132811.8351-1-joerg@wedekind.de Fixes: 60db3a4d8cc9 ("PCI: Enable PCIe Extended Tags if supported") Closes: https://bugzilla.kernel.org/show_bug.cgi?id=3D202425 Signed-off-by: J=C3=B6rg Wedekind Signed-off-by: Bjorn Helgaas Signed-off-by: Sasha Levin --- drivers/pci/quirks.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 821e71a45849c..3bc7058404156 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -5396,6 +5396,7 @@ static void quirk_no_ext_tags(struct pci_dev *pdev) =20 pci_walk_bus(bridge->bus, pci_configure_extended_tags, NULL); } +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_3WARE, 0x1004, quirk_no_ext_tags); DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, 0x0132, quirk_no_ext_ta= gs); DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, 0x0140, quirk_no_ext_ta= gs); DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, 0x0141, quirk_no_ext_ta= gs); --=20 2.43.0