From nobody Fri Dec 19 19:15:43 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA22917C6C9; Sun, 24 Mar 2024 23:43:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323799; cv=none; b=D5HFBjKuAmPP0tgKENpBX+If4ONRMLUtRZkFfSzKI2585UVWoTz6o/CaN8DGcsQPF5yZzx/DeRIHy+Wea1dnIyal96xOtnyPMDlcMh/MYTnR8P+M1D92hWtqvfBxVxFPCF9kpafJpJaMoqB0D3hPlgWq8eFRuU8mNhz92OnsRWg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323799; c=relaxed/simple; bh=7NUHxeM3H+naqYQrNNM4q/hfhzTzd4IROGguJ8zofz0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S7747DuWGj/azQA3/g9w1k1kxEvelbR+zcUxgtmP0lhVY4Jg+DnHr20ov5x013J7HRNoRxF+nPwfDe9JObczeGrOkO7G6M2q5aICclfLiqU9sa11lLCTRSkCKu9PQqlD7lA9042l5uGRBo78wu71CrvuEYcXyNKB0agaTjIP0ng= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=olHMhOxp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="olHMhOxp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2158C43390; Sun, 24 Mar 2024 23:43:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711323798; bh=7NUHxeM3H+naqYQrNNM4q/hfhzTzd4IROGguJ8zofz0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=olHMhOxpb0yRbBro/zm9KfCnLAjjdSdIovKugD29CjgekmdSRjLGyuxbNRdpuMgj9 EXMKcAn2wXO5/hsWwZg7eLe9/Atksd1SjsfNfOXz+VF7vbplqpX/WYACt3NM+Ykuky 5bpxkSwMzlKSFq0oSdsB2fWC1r86XZzD1F0nLGSciPiEeflN7USSwaew2LiujOlv7H sJpj69DcEHCyQn1jPvyMcfJAvTs+uc8ZmM3ijwdaV0VOkzSX5H6sMOtmq4TSsUdi/b 8PUJpUycuFs6GSULUO/62eFhr80cgWIzeMbqDKY/r3X0rWipmFF30UDytCmN7cFYGt NytXZFfljAtoA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Arnd Bergmann , Ricardo Ribalda , Hans Verkuil , Sasha Levin Subject: [PATCH 5.10 176/238] media: mediatek: vcodec: avoid -Wcast-function-type-strict warning Date: Sun, 24 Mar 2024 19:39:24 -0400 Message-ID: <20240324234027.1354210-177-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324234027.1354210-1-sashal@kernel.org> References: <20240324234027.1354210-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann [ Upstream commit bfb1b99802ef16045402deb855c197591dc78886 ] The ipi handler here tries hard to maintain const-ness of its argument, but by doing that causes a warning about function type casts: drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw_vpu.c:38:32: er= ror: cast from 'mtk_vcodec_ipi_handler' (aka 'void (*)(void *, unsigned int= , void *)') to 'ipi_handler_t' (aka 'void (*)(const void *, unsigned int, v= oid *)') converts to incompatible function type [-Werror,-Wcast-function-ty= pe-strict] 38 | ipi_handler_t handler_const =3D (ipi_handler_t)handler; | ^~~~~~~~~~~~~~~~~~~~~~ Remove the hack and just use a non-const argument. Fixes: bf1d556ad4e0 ("media: mtk-vcodec: abstract firmware interface") Signed-off-by: Arnd Bergmann Reviewed-by: Ricardo Ribalda Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c | 2 +- drivers/media/platform/mtk-vcodec/mtk_vcodec_fw_vpu.c | 10 +--------- drivers/media/platform/mtk-vpu/mtk_vpu.c | 2 +- drivers/media/platform/mtk-vpu/mtk_vpu.h | 2 +- 4 files changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c b/drivers/media/p= latform/mtk-mdp/mtk_mdp_vpu.c index b065ccd069140..378a1cba0144f 100644 --- a/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c @@ -26,7 +26,7 @@ static void mtk_mdp_vpu_handle_init_ack(const struct mdp_= ipi_comm_ack *msg) vpu->inst_addr =3D msg->vpu_inst_addr; } =20 -static void mtk_mdp_vpu_ipi_handler(const void *data, unsigned int len, +static void mtk_mdp_vpu_ipi_handler(void *data, unsigned int len, void *priv) { const struct mdp_ipi_comm_ack *msg =3D data; diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_fw_vpu.c b/driver= s/media/platform/mtk-vcodec/mtk_vcodec_fw_vpu.c index cfc7ebed8fb7a..1ec29f1b163a1 100644 --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_fw_vpu.c +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_fw_vpu.c @@ -29,15 +29,7 @@ static int mtk_vcodec_vpu_set_ipi_register(struct mtk_vc= odec_fw *fw, int id, mtk_vcodec_ipi_handler handler, const char *name, void *priv) { - /* - * The handler we receive takes a void * as its first argument. We - * cannot change this because it needs to be passed down to the rproc - * subsystem when SCP is used. VPU takes a const argument, which is - * more constrained, so the conversion below is safe. - */ - ipi_handler_t handler_const =3D (ipi_handler_t)handler; - - return vpu_ipi_register(fw->pdev, id, handler_const, name, priv); + return vpu_ipi_register(fw->pdev, id, handler, name, priv); } =20 static int mtk_vcodec_vpu_ipi_send(struct mtk_vcodec_fw *fw, int id, void = *buf, diff --git a/drivers/media/platform/mtk-vpu/mtk_vpu.c b/drivers/media/platf= orm/mtk-vpu/mtk_vpu.c index e7c4b0dd588a9..a2f61d97ffeb1 100644 --- a/drivers/media/platform/mtk-vpu/mtk_vpu.c +++ b/drivers/media/platform/mtk-vpu/mtk_vpu.c @@ -612,7 +612,7 @@ int vpu_load_firmware(struct platform_device *pdev) } EXPORT_SYMBOL_GPL(vpu_load_firmware); =20 -static void vpu_init_ipi_handler(const void *data, unsigned int len, void = *priv) +static void vpu_init_ipi_handler(void *data, unsigned int len, void *priv) { struct mtk_vpu *vpu =3D priv; const struct vpu_run *run =3D data; diff --git a/drivers/media/platform/mtk-vpu/mtk_vpu.h b/drivers/media/platf= orm/mtk-vpu/mtk_vpu.h index ee7c552ce9289..d4453b4bcee92 100644 --- a/drivers/media/platform/mtk-vpu/mtk_vpu.h +++ b/drivers/media/platform/mtk-vpu/mtk_vpu.h @@ -15,7 +15,7 @@ * VPU interfaces with other blocks by share memory and interrupt. **/ =20 -typedef void (*ipi_handler_t) (const void *data, +typedef void (*ipi_handler_t) (void *data, unsigned int len, void *priv); =20 --=20 2.43.0