From nobody Wed Oct 15 22:45:58 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74B82174979; Sun, 24 Mar 2024 23:35:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323357; cv=none; b=u7NAhxN7Fhc3GEf1sFfiT0LAvBjWw6Q90+KOI+Y+kmhHtcYlgN3vU9ky/S6ficJKdpFLTWgQ5RRccjIEl2GYuXy8IOmTDNC2OBXMtFUmrYoTtszXNGV9CHiNXOa5ilx7WqcOiVxEmXfMe/UbLtD0vcqbmHzaZfAzEgSTqirBckY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323357; c=relaxed/simple; bh=lk9a3sR+Gf80Nc1LTDgoNyiixBCKAWQX3ANl8n28usg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YGshLRtJrXtbz11oQLc5oekvTF6/D/b79l3ButC6HYILFhymjkEt/+/CoY/kl0swjI3ZvnTagy+c1+Ak9ttPW4+id7FKfY57S3XJMbaCsN6+KKZsBp2lTAC3aL39gElskgpdhe4t5MrxWgF+2tLB2XSOqaUjdGy26dajTN/Nz1s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZRuh9tCw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZRuh9tCw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98A78C43394; Sun, 24 Mar 2024 23:35:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711323357; bh=lk9a3sR+Gf80Nc1LTDgoNyiixBCKAWQX3ANl8n28usg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZRuh9tCwhWRvpVA1jNAKN8jBggeF6Kp5Npy9D6GiRiOUpvW3mhmM4qu2Lbmd7P8WS mlvJeR+c6OVadYCmiRlZkdvWutROMzTYNPvt6sYdGRSnMhcvlQVdQzncnNjd2/Lqo3 gly6/UPRioLlOHpyynFy+DsjO8tymGgTuwYR95b3uudAvG3iy55Ijhyf6TzvoNwDTx msAoFYAm2AdOUxllr4KWYVk6IbaSuv9zlWX4EmWd0VFSbTxNlgF0ygScBGBCqS4xRF zRAP8mlitK/oEgV7kE4aNou7rSOIH5tVhHfNTcfY9I+OTgIlT3Q8b2DHVD8PmGrp1a YkyLYBVBk9Wxw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Martin Kaistra , Ping-Ke Shih , Kalle Valo , Sasha Levin Subject: [PATCH 5.15 057/317] wifi: rtl8xxxu: add cancel_work_sync() for c2hcmd_work Date: Sun, 24 Mar 2024 19:30:37 -0400 Message-ID: <20240324233458.1352854-58-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324233458.1352854-1-sashal@kernel.org> References: <20240324233458.1352854-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Martin Kaistra [ Upstream commit 1213acb478a7181cd73eeaf00db430f1e45b1361 ] The workqueue might still be running, when the driver is stopped. To avoid a use-after-free, call cancel_work_sync() in rtl8xxxu_stop(). Fixes: e542e66b7c2e ("rtl8xxxu: add bluetooth co-existence support for sing= le antenna") Signed-off-by: Martin Kaistra Reviewed-by: Ping-Ke Shih Signed-off-by: Kalle Valo Link: https://msgid.link/20240111163628.320697-2-martin.kaistra@linutronix.= de Signed-off-by: Sasha Levin --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/driver= s/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index 30d9a195c6fb5..3536b9f8470f4 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -6484,6 +6484,7 @@ static void rtl8xxxu_stop(struct ieee80211_hw *hw) if (priv->usb_interrupts) rtl8xxxu_write32(priv, REG_USB_HIMR, 0); =20 + cancel_work_sync(&priv->c2hcmd_work); cancel_delayed_work_sync(&priv->ra_watchdog); =20 rtl8xxxu_free_rx_resources(priv); --=20 2.43.0