From nobody Wed Oct 15 22:36:21 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94132219543; Sun, 24 Mar 2024 23:35:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323350; cv=none; b=Tq4aB4bPRUEaka2S3wP0kuwGdzBGtHA4w0Z1oA36GSJt2Jl8hk7Dl4sKMIjHNbLByAwjY8DMNyl47QEF1FKdTfNa5T0uiTOexupRyJ+Osh02pWiljIhMsivf1YfawDHGdEin2SyrBN6/UgFKWzqwSJ7lo691BizYDvGR8tb9wvk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323350; c=relaxed/simple; bh=xmtqkWTODmXjADlJwYaL6d+EDtCCdjOUJyLKvhJG4/M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eiEuITcp6uTmW9WLyxDPit073NVDLiLlAYCtp0NEWBmXR2dU/Egy2+/MWPqekyC1+RJpuKACUN0Mx51KnZqOv5CnzuwEX21JUbqGXfZN7KxYBZFhJCA10tD1ZdmflJPsqvyL355q32FdCZk6F8LbumGIY2g0b/cfAb1EogZblQw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nK9QyzRo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nK9QyzRo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B872DC43399; Sun, 24 Mar 2024 23:35:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711323350; bh=xmtqkWTODmXjADlJwYaL6d+EDtCCdjOUJyLKvhJG4/M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nK9QyzRoYruGQffyGtTLrPHNSQ2H3ua9UWVc8C94VlVLQWrI7pol5lepGZggnG5Dg VwzWdGoe5GvWleXiP1k0nW0FCHEBiNKFH0dOJ8n+GltqieRWJI6UOT68FBg8dTN9a+ Lkl5FPXP2w1aXNRPB+y93hnJtg9Ki1pFWoPzZm1UKb9TQj8Sn/1xhWgXr24C2lF1C/ ERVP5fcLS3ob3XcMh7/PJRJ/TYjn1Y0FXb4pSwk4LCbyVQBf2q0DfjbQhZBfaWg9B8 EdE4o9Jx2+5UxJG+oHwvImrTWQNAoMgGszV3ScUt0644tYLjhO9i0RoRJbFR0iM+NI gFKC23raE3TxQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Xingyuan Mo , Jeff Johnson , Kalle Valo , Sasha Levin Subject: [PATCH 5.15 050/317] wifi: ath10k: fix NULL pointer dereference in ath10k_wmi_tlv_op_pull_mgmt_tx_compl_ev() Date: Sun, 24 Mar 2024 19:30:30 -0400 Message-ID: <20240324233458.1352854-51-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324233458.1352854-1-sashal@kernel.org> References: <20240324233458.1352854-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Xingyuan Mo [ Upstream commit ad25ee36f00172f7d53242dc77c69fff7ced0755 ] We should check whether the WMI_TLV_TAG_STRUCT_MGMT_TX_COMPL_EVENT tlv is present before accessing it, otherwise a null pointer deference error will occur. Fixes: dc405152bb64 ("ath10k: handle mgmt tx completion event") Signed-off-by: Xingyuan Mo Acked-by: Jeff Johnson Signed-off-by: Kalle Valo Link: https://msgid.link/20231208043433.271449-1-hdthky0@gmail.com Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wirele= ss/ath/ath10k/wmi-tlv.c index 7efbe03fbca82..d5dafbecc1845 100644 --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c @@ -844,6 +844,10 @@ ath10k_wmi_tlv_op_pull_mgmt_tx_compl_ev(struct ath10k = *ar, struct sk_buff *skb, } =20 ev =3D tb[WMI_TLV_TAG_STRUCT_MGMT_TX_COMPL_EVENT]; + if (!ev) { + kfree(tb); + return -EPROTO; + } =20 arg->desc_id =3D ev->desc_id; arg->status =3D ev->status; --=20 2.43.0