From nobody Wed Oct 15 22:45:59 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DB0A2789BD; Sun, 24 Mar 2024 23:37:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323456; cv=none; b=BfJpw1U80ddRTkg4dQwLa3OregxC5HOmz31v3nDHxK6aFp5pWkdbdbkK2uUK0ifz1eH3XN1l1eR9W0DkPk4D+cQn7ZJL/ELetQAJv9ibx2g2ymJw+dSzqh9ZGN05LGZMByeOByEOqzpC5esmT24CfSW8hWNX9wovYnhycQTnumo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323456; c=relaxed/simple; bh=I5IZLXRovJJX137SJGnoEbJCPVfKKUehgGid1mWVd0k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ix17dkZjxcISLEVXma7OCjWhyb3D9h6L3ZCLOsxsU2Yufz4llV2B87UB03NCQLFPtrF1uJ7JC9/Noc5iXjkXBI+3MS8H5aKQR8XK4J0lDWFk7F7o/a3JuxULnpuSwjkXgr03hP1m8H5pe9CooQfcSle+j5KHpPOQUZaQtWmFMTw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jtapN0J5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jtapN0J5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8F10C43390; Sun, 24 Mar 2024 23:37:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711323455; bh=I5IZLXRovJJX137SJGnoEbJCPVfKKUehgGid1mWVd0k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jtapN0J5jWghDr0SEnLlYX53mYDQM/SJv+Xpt1TW70lu1hLU/4qW1eFm295V7FdOP i/yB2AlzjUqMvzd+DnXrfIXF7Sw/qfMsozwosVX2rWSGSjtzhZsS1sEh59gap8hV9y s2hZNuBm8mFSX/lms53BxKF5oH9YzDqliLunfEJADxovxoWolASzgiUdz06KywR1hX IZCS4fOZ3dU5jUHF7zwnVoQlEp/V3tP+OXjunxTVByE1xuiXFQwG77bzpSSrjl7OA3 Jm+Rmbkqxcxb6b3DDbEqmLZafB/HX50hWpDoMpEFZSyd6iVkkCQsSDGACR8TuHJl1a A5WV5cdNDnlbQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Cai Huoqing , Thierry Reding , Sasha Levin Subject: [PATCH 5.15 159/317] drm/tegra: dsi: Make use of the helper function dev_err_probe() Date: Sun, 24 Mar 2024 19:32:19 -0400 Message-ID: <20240324233458.1352854-160-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324233458.1352854-1-sashal@kernel.org> References: <20240324233458.1352854-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Cai Huoqing [ Upstream commit fc75e4fcbd1e4252a0481ebb23cd4516c127a8e2 ] When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. And using dev_err_probe() can reduce code size, the error value gets printed. Signed-off-by: Cai Huoqing Signed-off-by: Thierry Reding Stable-dep-of: 830c1ded3563 ("drm/tegra: dsi: Fix some error handling paths= in tegra_dsi_probe()") Signed-off-by: Sasha Levin --- drivers/gpu/drm/tegra/dsi.c | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c index 0adce882f157b..6cbba2adb6e5a 100644 --- a/drivers/gpu/drm/tegra/dsi.c +++ b/drivers/gpu/drm/tegra/dsi.c @@ -1591,28 +1591,24 @@ static int tegra_dsi_probe(struct platform_device *= pdev) } =20 dsi->clk =3D devm_clk_get(&pdev->dev, NULL); - if (IS_ERR(dsi->clk)) { - dev_err(&pdev->dev, "cannot get DSI clock\n"); - return PTR_ERR(dsi->clk); - } + if (IS_ERR(dsi->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(dsi->clk), + "cannot get DSI clock\n"); =20 dsi->clk_lp =3D devm_clk_get(&pdev->dev, "lp"); - if (IS_ERR(dsi->clk_lp)) { - dev_err(&pdev->dev, "cannot get low-power clock\n"); - return PTR_ERR(dsi->clk_lp); - } + if (IS_ERR(dsi->clk_lp)) + return dev_err_probe(&pdev->dev, PTR_ERR(dsi->clk_lp), + "cannot get low-power clock\n"); =20 dsi->clk_parent =3D devm_clk_get(&pdev->dev, "parent"); - if (IS_ERR(dsi->clk_parent)) { - dev_err(&pdev->dev, "cannot get parent clock\n"); - return PTR_ERR(dsi->clk_parent); - } + if (IS_ERR(dsi->clk_parent)) + return dev_err_probe(&pdev->dev, PTR_ERR(dsi->clk_parent), + "cannot get parent clock\n"); =20 dsi->vdd =3D devm_regulator_get(&pdev->dev, "avdd-dsi-csi"); - if (IS_ERR(dsi->vdd)) { - dev_err(&pdev->dev, "cannot get VDD supply\n"); - return PTR_ERR(dsi->vdd); - } + if (IS_ERR(dsi->vdd)) + return dev_err_probe(&pdev->dev, PTR_ERR(dsi->vdd), + "cannot get VDD supply\n"); =20 err =3D tegra_dsi_setup_clocks(dsi); if (err < 0) { --=20 2.43.0