From nobody Mon Feb 9 12:12:55 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 431FD52F97; Sun, 24 Mar 2024 23:11:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711321905; cv=none; b=J4iOgv+LaCj6p/2xSEt3SNoXPwVu4HflOIdEn8kSjw++mtCLydENvA6mjghRXdiAxIDZf0RPxT59nL7ed/KWR7a6sa0axkr1GU3tmbIg1sL0pLsPnvMyFxmp7B0rTiC9vIHCx77ZhMCp8Kp49CNKSPhD69ApIaiubZnDtAS0b2Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711321905; c=relaxed/simple; bh=90Uqm9QF4FUxa1GZXRDF0mBH1f1Bbm0BPJYWcT65jps=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=De6sW0TTHGs/lIVBYc21v4l1IE/N7+TWzw+Tkh+2iiQwZI6ahB5oVqD89Rfb0DMt24RFZC4zm0ayb9h7sCA9UGDt6Pp2IogXiZHx4c1WmpwCKUOA9QrmaaGREWnQ6ywRqmPZjkt/8u34q4e1XuEKevK+BhZU0waPH2sD/206cjw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KKA3VSza; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KKA3VSza" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54023C433F1; Sun, 24 Mar 2024 23:11:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711321904; bh=90Uqm9QF4FUxa1GZXRDF0mBH1f1Bbm0BPJYWcT65jps=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KKA3VSzaopCLH93+CDgiMCPDVJBgrD8UfnBySh9GR5mC7G9pI6ec1zWheS4ydESw+ LuHILKyXJuxIkFbHOjao8fCKpsp/2zUKmjOjqixGgBWQ12FBANE7wUIynwzm7lEqfv mSL/VXzDo6Scw98Izf6vP2SXV6C+4h/J8oMFAEegQnhf9GZi8LAOfrBXP3RfnjduPZ Ygd6Delf3M6IlG+lu90Ulgws5t7pp7OnHwiHlbKFHRxNajPGuOWSYqQfWeXHCKV+n7 YW9QYdx2nOnC6dpbCeoAFeo2oIzmdrbSES1CVdMOYz6gmUVGbF1XLNHZD1147ZmbGK mTFlYPeml0MGA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ido Schimmel , Paolo Abeni , Hangbin Liu , Jiri Pirko , Sasha Levin Subject: [PATCH 6.6 633/638] selftests: forwarding: Fix ping failure due to short timeout Date: Sun, 24 Mar 2024 19:01:10 -0400 Message-ID: <20240324230116.1348576-634-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324230116.1348576-1-sashal@kernel.org> References: <20240324230116.1348576-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ido Schimmel [ Upstream commit e4137851d4863a9bdc6aabc613bcb46c06d91e64 ] The tests send 100 pings in 0.1 second intervals and force a timeout of 11 seconds, which is borderline (especially on debug kernels), resulting in random failures in netdev CI [1]. Fix by increasing the timeout to 20 seconds. It should not prolong the test unless something is wrong, in which case the test will rightfully fail. [1] # selftests: net/forwarding: vxlan_bridge_1d_port_8472_ipv6.sh # INFO: Running tests with UDP port 8472 # TEST: ping: local->local [ OK= ] # TEST: ping: local->remote 1 [FAI= L] # Ping failed [...] Fixes: b07e9957f220 ("selftests: forwarding: Add VxLAN tests with a VLAN-un= aware bridge for IPv6") Fixes: 728b35259e28 ("selftests: forwarding: Add VxLAN tests with a VLAN-aw= are bridge for IPv6") Reported-by: Paolo Abeni Closes: https://lore.kernel.org/netdev/24a7051fdcd1f156c3704bca39e4b3c41dfc= 7c4b.camel@redhat.com/ Signed-off-by: Ido Schimmel Reviewed-by: Hangbin Liu Reviewed-by: Jiri Pirko Link: https://lore.kernel.org/r/20240320065717.4145325-1-idosch@nvidia.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- .../testing/selftests/net/forwarding/vxlan_bridge_1d_ipv6.sh | 4 ++-- .../testing/selftests/net/forwarding/vxlan_bridge_1q_ipv6.sh | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/net/forwarding/vxlan_bridge_1d_ipv6.sh= b/tools/testing/selftests/net/forwarding/vxlan_bridge_1d_ipv6.sh index ac97f07e5ce82..bd3f7d492af2b 100755 --- a/tools/testing/selftests/net/forwarding/vxlan_bridge_1d_ipv6.sh +++ b/tools/testing/selftests/net/forwarding/vxlan_bridge_1d_ipv6.sh @@ -354,7 +354,7 @@ __ping_ipv4() =20 # Send 100 packets and verify that at least 100 packets hit the rule, # to overcome ARP noise. - PING_COUNT=3D100 PING_TIMEOUT=3D11 ping_do $dev $dst_ip + PING_COUNT=3D100 PING_TIMEOUT=3D20 ping_do $dev $dst_ip check_err $? "Ping failed" =20 tc_check_at_least_x_packets "dev $rp1 egress" 101 10 100 @@ -410,7 +410,7 @@ __ping_ipv6() =20 # Send 100 packets and verify that at least 100 packets hit the rule, # to overcome neighbor discovery noise. - PING_COUNT=3D100 PING_TIMEOUT=3D11 ping6_do $dev $dst_ip + PING_COUNT=3D100 PING_TIMEOUT=3D20 ping6_do $dev $dst_ip check_err $? "Ping failed" =20 tc_check_at_least_x_packets "dev $rp1 egress" 101 100 diff --git a/tools/testing/selftests/net/forwarding/vxlan_bridge_1q_ipv6.sh= b/tools/testing/selftests/net/forwarding/vxlan_bridge_1q_ipv6.sh index d880df89bc8bd..e83fde79f40d0 100755 --- a/tools/testing/selftests/net/forwarding/vxlan_bridge_1q_ipv6.sh +++ b/tools/testing/selftests/net/forwarding/vxlan_bridge_1q_ipv6.sh @@ -457,7 +457,7 @@ __ping_ipv4() =20 # Send 100 packets and verify that at least 100 packets hit the rule, # to overcome ARP noise. - PING_COUNT=3D100 PING_TIMEOUT=3D11 ping_do $dev $dst_ip + PING_COUNT=3D100 PING_TIMEOUT=3D20 ping_do $dev $dst_ip check_err $? "Ping failed" =20 tc_check_at_least_x_packets "dev $rp1 egress" 101 10 100 @@ -522,7 +522,7 @@ __ping_ipv6() =20 # Send 100 packets and verify that at least 100 packets hit the rule, # to overcome neighbor discovery noise. - PING_COUNT=3D100 PING_TIMEOUT=3D11 ping6_do $dev $dst_ip + PING_COUNT=3D100 PING_TIMEOUT=3D20 ping6_do $dev $dst_ip check_err $? "Ping failed" =20 tc_check_at_least_x_packets "dev $rp1 egress" 101 100 --=20 2.43.0