From nobody Fri Dec 19 07:01:47 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E20B6217E0C; Sun, 24 Mar 2024 23:09:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711321782; cv=none; b=hLnWzfrs4XN6M0ijPzL0Qpoekza0i5X4ZL9QIAWkWeJGcZbNE68DG2qNlWHUfp4/jyExE422jJ4FMeXEDWnIE3QqPul7lAiaWA6+mjlQAil/IaW8rQK+5cmDE/HhBB3JlSbCZDZyg9jIyQhfmbsN5WzKzxY02/S8IdPAUXV6eN4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711321782; c=relaxed/simple; bh=hkI4T48tky6Dsn098i4nYiPHOajWB4JBuWm2GZ+ywxE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K7xNd5EqTJUS2hvfeA5QdBVyuxpEiJtNf2zZnz/53fQyRyyYksJ1zGexOIfk13Gwizw82ixId5Qfd1/+1v74xVHpkg4qwyDzKUqrPclY+Pw2oInVFZQ2Q102fyLCT18kEHOJ93kuQGFRLnzKn55k7glp4lVRv6QIEerLaW5cd2k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Gww13tkf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Gww13tkf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1417CC43390; Sun, 24 Mar 2024 23:09:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711321780; bh=hkI4T48tky6Dsn098i4nYiPHOajWB4JBuWm2GZ+ywxE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Gww13tkf3iy7G+o7FySOflCXhLn7H27tOc3NgrUIyhJw0p26R2WXnKfzA4mW+buXN KfXUAhf30MxSG5MGeVDscIQexYYOyZgJMXHsojb68551ZPL+B4dh8FUqIbBICp4/Yo jAS1Gj6E6ykiybI8XW/xBwvUA9kBvFP7ljTAeMIkkGh03agYF9f6/WNRS6spmHfUrR 6xC51RNJ4LeyeqSfU50CLjuKhDqXE+kBdqeKUi76pppriZW3pN1OusSnsMZqxvTDGE gsk8u5Gx42XYLLX8gPNTdd2OVQpaWqJtsuKV2IlJtm8oPxq1YqOfWq09dYkK5xYQ/8 2ZSh5vo9kwEeA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: William Kucharski , Bart Van Assche , Leon Romanovsky , Sasha Levin Subject: [PATCH 6.6 508/638] RDMA/srpt: Do not register event handler until srpt device is fully setup Date: Sun, 24 Mar 2024 18:59:05 -0400 Message-ID: <20240324230116.1348576-509-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324230116.1348576-1-sashal@kernel.org> References: <20240324230116.1348576-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: William Kucharski [ Upstream commit c21a8870c98611e8f892511825c9607f1e2cd456 ] Upon rare occasions, KASAN reports a use-after-free Write in srpt_refresh_port(). This seems to be because an event handler is registered before the srpt device is fully setup and a race condition upon error may leave a partially setup event handler in place. Instead, only register the event handler after srpt device initialization is complete. Fixes: a42d985bd5b2 ("ib_srpt: Initial SRP Target merge for v3.3-rc1") Signed-off-by: William Kucharski Link: https://lore.kernel.org/r/20240202091549.991784-2-william.kucharski@o= racle.com Reviewed-by: Bart Van Assche Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/ulp/srpt/ib_srpt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp= /srpt/ib_srpt.c index 015bfeede90e1..45547bf281e31 100644 --- a/drivers/infiniband/ulp/srpt/ib_srpt.c +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c @@ -3209,7 +3209,6 @@ static int srpt_add_one(struct ib_device *device) =20 INIT_IB_EVENT_HANDLER(&sdev->event_handler, sdev->device, srpt_event_handler); - ib_register_event_handler(&sdev->event_handler); =20 for (i =3D 1; i <=3D sdev->device->phys_port_cnt; i++) { sport =3D &sdev->port[i - 1]; @@ -3232,6 +3231,7 @@ static int srpt_add_one(struct ib_device *device) } } =20 + ib_register_event_handler(&sdev->event_handler); spin_lock(&srpt_dev_lock); list_add_tail(&sdev->list, &srpt_dev_list); spin_unlock(&srpt_dev_lock); @@ -3242,7 +3242,6 @@ static int srpt_add_one(struct ib_device *device) =20 err_port: srpt_unregister_mad_agent(sdev, i); - ib_unregister_event_handler(&sdev->event_handler); err_cm: if (sdev->cm_id) ib_destroy_cm_id(sdev->cm_id); --=20 2.43.0