From nobody Fri Dec 19 22:01:59 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B2A021413D; Sun, 24 Mar 2024 23:08:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711321737; cv=none; b=gU3oXHFfKw9DCgQB1lcjNtdbnDIOaxnQi46IuqbVPl8kIUQnh+KR1MMDuzGHWRBGYBV7IRY9cftDYf2ldiJ2VrYC8Q4xQYE4jFA2n3dmgHGIAzjtIfgqCGr/Xet5a8jfDJhn7Yah6KahX99wxMCN1XtoRnq/2jDA4I7JiOQyxnk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711321737; c=relaxed/simple; bh=TLyEqfyntQ6dgjomKdKwyWv+EdNOs2VIapsu7gTdO5I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=L3L6HNCRRBwr2FpX353QLwrrXuHX0i+k6dOAt+v0YS07SYXWW3YxK+McmmqfXMArg5SXjVHudrWJhXa4PXwsOxR/AiFEWsxbHjTfFTkyt4H5Wcs6qVJJe1Odbx5a6H+tDc7M6mPhuDrYJVbo6U6rx72HMeECRdvH/6phbXyj86c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WI6XOu9b; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WI6XOu9b" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B6E4C43399; Sun, 24 Mar 2024 23:08:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711321736; bh=TLyEqfyntQ6dgjomKdKwyWv+EdNOs2VIapsu7gTdO5I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WI6XOu9bzLb0GHcmGXPA5dkpImKZ3Da8E2St0sOgFcCbtPppjzyPLMdtuRZcXJMTq 98PUVZymOVZcdkn4YT6tS6EJhILm7JyMqjmmNvjnKY49NxPB6TpQx20IsCEGdJ4bbU veR5fkBSiYMPZri20gCO1v0dK0TeKDYIpZ1ztAOBqS1Kr6vKRrJLOUsU+5HlYOWUzw HfxCVCoK0bXtkHwr9wJWPy6lRT7vxDcx/gBHu3mQ2WmSwzmlV1C9yfAPRwBNZVV7yW lQS+gE7HhGEHIA1sPCKwBlbWA8xRTOEq6H+YLHpV3eDoR5koaZjBBZSdR5/mVOH7hJ hV10Ym1H0iH7A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zhipeng Lu , Hans Verkuil , Sasha Levin Subject: [PATCH 6.6 464/638] media: go7007: fix a memleak in go7007_load_encoder Date: Sun, 24 Mar 2024 18:58:21 -0400 Message-ID: <20240324230116.1348576-465-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324230116.1348576-1-sashal@kernel.org> References: <20240324230116.1348576-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Zhipeng Lu [ Upstream commit b9b683844b01d171a72b9c0419a2d760d946ee12 ] In go7007_load_encoder, bounce(i.e. go->boot_fw), is allocated without a deallocation thereafter. After the following call chain: saa7134_go7007_init |-> go7007_boot_encoder |-> go7007_load_encoder |-> kfree(go) go is freed and thus bounce is leaked. Fixes: 95ef39403f89 ("[media] go7007: remember boot firmware") Signed-off-by: Zhipeng Lu Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/usb/go7007/go7007-driver.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/go7007/go7007-driver.c b/drivers/media/usb/g= o7007/go7007-driver.c index 0c24e29843048..eb03f98b2ef11 100644 --- a/drivers/media/usb/go7007/go7007-driver.c +++ b/drivers/media/usb/go7007/go7007-driver.c @@ -80,7 +80,7 @@ static int go7007_load_encoder(struct go7007 *go) const struct firmware *fw_entry; char fw_name[] =3D "go7007/go7007fw.bin"; void *bounce; - int fw_len, rv =3D 0; + int fw_len; u16 intr_val, intr_data; =20 if (go->boot_fw =3D=3D NULL) { @@ -109,9 +109,11 @@ static int go7007_load_encoder(struct go7007 *go) go7007_read_interrupt(go, &intr_val, &intr_data) < 0 || (intr_val & ~0x1) !=3D 0x5a5a) { v4l2_err(go, "error transferring firmware\n"); - rv =3D -1; + kfree(go->boot_fw); + go->boot_fw =3D NULL; + return -1; } - return rv; + return 0; } =20 MODULE_FIRMWARE("go7007/go7007fw.bin"); --=20 2.43.0